GitLab

Change-Id: I67162d0c055d49e29e0e22687db8c56e7d8f850c
Reviewed-on: https://chromium-review.googlesource.com/1028757
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553846}

If the AdTracker sees an ad script in the stack when a frame is created,
or its parent frame is thought to be an ad, label the LocalFrame as an
ad frame. The subresource filter will then label subsequent requests in
that frame as ad requests.

A future CL will handle situations where the frame changes processes.

Bug: 807640
Change-Id: Ie4d3bab747c3158d310652f6376cc79f6da38b7a
Reviewed-on: https://chromium-review.googlesource.com/1019743
Commit-Queue: Josh Karlin <jkarlin@chromium.org>
Reviewed-by: Nate Chapin <japhet@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553845}

Following bot results are included.
4953 4958 4961 4966 4967 4969 4971 4977 4978 4982 4985 4986
4990 4992

5 lines were removed and 10 lines were deflaked by consecutive
results since 4905.

TBR=eae@chromium.org, mstensho@chromium.org
NOTRY=true

Bug: 591099
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: I14beab6e153fac6095ff47d01ad657e8dfb47223
Reviewed-on: https://chromium-review.googlesource.com/1025538
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553844}

Highlight the first search result immediately after finding it while the
search continues onwards. Instead of waiting for all the search results
to return before highlighting the first search result.

BUG=764635

Change-Id: I445ffb88527bd592fc5a51d499ea90d752a88918
Reviewed-on: https://chromium-review.googlesource.com/1013748
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Paul Meyer <paulmeyer@chromium.org>
Reviewed-by: dsinclair <dsinclair@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553843}

Pass receiver list to Android to restricted packages which can receive
the USB event.

Bug: b/78231419
Test: Manual
Change-Id: I3938fb5b105eb95017ee0e34136ad78a70fd03c6
Reviewed-on: https://chromium-review.googlesource.com/1017809Reviewed-by: Luis Hector Chavez <lhchavez@chromium.org>
Reviewed-by: Mattias Nissler <mnissler@chromium.org>
Commit-Queue: Long Cheng <lgcheng@google.com>
Cr-Commit-Position: refs/heads/master@{#553842}

The app no longer renders the first frame after we recreate the renderer
context when the app resumes. User has to move the cursor or viewport
to get the frame rendered. That's because we didn't set the transformation
matrix after the renderer context is recreated.

This CL makes GlRenderer cache the viewport matrix and set it on the
canvas when the canvas is recreated.

Bug: 836975
Change-Id: I3d4bb2575aa59f9148181104f320cf7a72770ad5
Reviewed-on: https://chromium-review.googlesource.com/1028848
Commit-Queue: Yuwei Huang <yuweih@chromium.org>
Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553841}

Disabled test, but fixed in issue 829310. Running this test locally in
DEBUG, no flakes. Re-enable this test on all chrome-os bots.

Mash browser tests do not support this test (see patch set #2 trys) so
disable it in mash.

Bug: 836254,711290
Change-Id: Ieac0fea5b568f738fda04bddc8c8dcc488f83887
Reviewed-on: https://chromium-review.googlesource.com/1028534
Commit-Queue: Noel Gordon <noel@chromium.org>
Reviewed-by: Stuart Langley <slangley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553840}

`ThisExpression` is not considered an `Identifier`, but it should
similarly have no side effects.

Change-Id: I894869716541dd9692d96938db76b2b3a1d3b1a1
Reviewed-on: https://chromium-review.googlesource.com/1028187Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Joel Einbinder <einbinder@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553839}

Kim points out in the bug that the current logic (see
https://chromium-review.googlesource.com/c/chromium/src/+/991073)
doesn't allow dev tools to be focused, so it's not possible to trigger
webauthn requests from the dev tools console.

Nasko thought that the addition of a ContentBrowserClient API was too
large a hammer too. I've not been able to come up with any cleaner
solution however, but this change perhaps makes the hammer more
reasonable:

In order to address the devtools issue, this change switches the focus
check to requiring that the tab be active in the focused window. (This
also matches what the cryptotoken extension does.) This means that it
has to chrome/ logic, rather than content/ logic, but we already had to
add an API to ContentBrowserClient for this and we can reuse that to
solve this problem too.

Additionally, this change adds an interactive_ui_test to ensure that we
don't regress.

Bug: 827266,836203
Change-Id: I62226fc0366a83dc69d9cb32016108bdbe590d29
Reviewed-on: https://chromium-review.googlesource.com/1007637
Commit-Queue: Adam Langley <agl@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553838}

This reverts commit 9bbdf45e.

Reason for revert: The patch verified that the reporting is accurate, no
crashes were introduced from the added CHECKs. And we have enough data
to check the UKM logs.

Original change's description:
> cc: Disable checker-imaging for decode=async tag.
> 
> Temporarily disabling checkering of decode=async tag images to debug
> entries in ukm logs for checkerboarded images in the control group for
> checkerimaging finch study.
> 
> R=​vmpstr@chromium.org
> 
> Bug: 833666
> Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
> Change-Id: Ib9a79262599efa17fd18e9cb71d7518492e9a7ee
> Reviewed-on: https://chromium-review.googlesource.com/1014644
> Reviewed-by: vmpstr <vmpstr@chromium.org>
> Commit-Queue: Khushal <khushalsagar@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#551513}

TBR=vmpstr@chromium.org,khushalsagar@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 833666
Change-Id: I3425d7a7b4cc6d57ec26fee7ddee8827e97992dd
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Reviewed-on: https://chromium-review.googlesource.com/1029090Reviewed-by: Khushal <khushalsagar@chromium.org>
Commit-Queue: Khushal <khushalsagar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553837}

- Implement a TestDocumentLoader and a TestClient.
- Hook them up to PDFiumEngine to observe its behavior.
- Load a simple 2 page PDF and perform a text search.

Change-Id: I03417880c3b6c3f493f7e08ba07b694272b5b5fc
Reviewed-on: https://chromium-review.googlesource.com/1012976
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: dsinclair <dsinclair@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553836}

GetAppOutput relies on a platform-supplied shell interpreter to
exercise ProcessUtil's output handling codepaths
and the GetAppOutput tests rewritten to use it.

This doesn't work for Fuchsia, as packaged executables aren't
allowed to access other binaries that aren't included
in the package.

This CL defines a trivial test executable "test_child_process",
which behaves similar to "echo", and the GetAppOutput tests
are rewritten to use it.


Bug: 836341
Change-Id: If681b62f4ecf486a6b62387be0610fec6771ae4e
Reviewed-on: https://chromium-review.googlesource.com/1026796
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553835}

The AutoRoll server is located here: https://fuchsia-sdk-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:fuchsia_arm64_cast_audio;master.tryserver.chromium.linux:fuchsia_x64_cast_audio
TBR=cr-fuchsia+bot@chromium.org

Change-Id: I254691f260d8a7d02b7e7fe093201b39adb162f0
Reviewed-on: https://chromium-review.googlesource.com/1029125
Commit-Queue: Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#553834}

Bug: 729849
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I28f621849bbc3260df2cd818a1daf58c5969755f
Reviewed-on: https://chromium-review.googlesource.com/1029009Reviewed-by: Chong Zhang <chongz@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553833}

Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet
Bug: 836823, 829429
Change-Id: Id69a596b5d260ceec0794c6c6478ad01ce61a0da
Reviewed-on: https://chromium-review.googlesource.com/1028630Reviewed-by: Ryan Hamilton <rch@chromium.org>
Commit-Queue: Misha Efimov <mef@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553832}

rebase_path is being applied twice on skia_workaround_list file path.
This patch removes the redundancy.

Component: Gpu config Gn
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Ieea6c860dabbd0d76983a67a7fa7de53c014a963
Reviewed-on: https://chromium-review.googlesource.com/1028578Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Reviewed-by: enne <enne@chromium.org>
Commit-Queue: Malay Keshav <malaykeshav@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553831}

Blink Intent to Implement and Ship discussion and approval happened in
https://groups.google.com/a/chromium.org/d/topic/blink-dev/hnAWBzq1qys/discussion

Bug: 802835
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I608817ddbbf538f5074774715eeb9b27920c1bf7
Reviewed-on: https://chromium-review.googlesource.com/1028356
Commit-Queue: Charlie Reis <creis@chromium.org>
Reviewed-by: Charlie Reis <creis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553830}

Clarify kiosk test failures.

Bug: none
Change-Id: Ie238700e76dcb279453917e3d2075f42bd821fae
Reviewed-on: https://chromium-review.googlesource.com/1029201Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553829}

https://swiftshader.googlesource.com/SwiftShader.git/+log/99be318..bf58b9

BUG=

TBR=kbr@chromium.org

TEST=bots

CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_chromium_cfi_rel_ng;luci.chromium.try:android_optional_gpu_tests_rel

Change-Id: I5964f90bad824754fc3d6b4354ec13d9cbad643c
Reviewed-on: https://chromium-review.googlesource.com/1028250Reviewed-by: Alexis Hétu <sugoi@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553828}

on-manually-add-discovered-printer was being called with invalid
parameters.  Refactor so it's easier to call properly and fix
the bad callsite.

Observed behavior was that the setup dialog would close without
any messaging.  User is prompted for a PPD now.

Bug: 835476
Change-Id: I85ae96cf1f9638098cd819fccb47b30e16274a58
Reviewed-on: https://chromium-review.googlesource.com/1023040
Commit-Queue: Sean Kau <skau@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553827}

This reverts commit 30e23517.

Reason for revert: This script turned animated PNGs for ChromeOS into flat PNGs. Scary!

Original change's description:
> Run tools/resources/optimize-png-files.sh
>
> Optimizes a significant number of .png files and cuts ~3.6M in total.
>
> Bug: None
> Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
> Change-Id: I53a951a6410839c3b21f7155f22e2fedb3fb963f
> Reviewed-on: https://chromium-review.googlesource.com/1012263
> Reviewed-by: Scott Violet <sky@chromium.org>
> Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
> Commit-Queue: Peter Boström <pbos@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#551066}

TBR=sky@chromium.org,bauerb@chromium.org,pbos@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: chromium:835197
Change-Id: I4852e2ee84ac51ffb765649ff838c03dfba564d3
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Reviewed-on: https://chromium-review.googlesource.com/1028336
Commit-Queue: Peter Boström <pbos@chromium.org>
Reviewed-by: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553826}

* Adds 2dips of bottom margin and 2dips of padding between items (for
  all layout modes).
* Uses 4dips of rounded-corner radius under Refresh (already in use
  under touchable).

Bug: chromium:822072
Change-Id: I6fba6c49a01fa5f79cc33fe2e53aa998e350e03b
Reviewed-on: https://chromium-review.googlesource.com/1026392
Commit-Queue: Bret Sepulveda <bsep@chromium.org>
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553825}

Bug: 836851
Change-Id: I6d83b276596cb41770161f40283e6638463cf67d
Reviewed-on: https://chromium-review.googlesource.com/1028377
Commit-Queue: Filip Gorski <fgorski@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553824}

ax_layout_object.cc includes rendered_position.h to use some hacky
utility functions there.

As editing code no longer uses those functions, this patch moves the
functions to AX, and stops AX from including rendered_position.h to
improve code health.

Change-Id: I85a50fbd81f05eded792721e8fd99eac0373b6c3
Reviewed-on: https://chromium-review.googlesource.com/1024734Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Yoichi Osato <yoichio@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553823}

Un-breaking WebRTC to let them revert a CL to un-break CrOS.

TBR=agrieve@chromium.org

Bug: 836344
Change-Id: I48abc7353825571873f63f37af54026db6c429c8
Reviewed-on: https://chromium-review.googlesource.com/1028571Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553822}

This eliminates a call into ash::Shell::GetRootWindowForNewWindows,
which we need to do for out-of-process ash (go/mustash).

The existing code looks like it was just copied from another place
that shows a similar notification. Regardless, the primary display
should be fine.

Bug: 372857, 826569
Test: browser_tests KioskUpdateTest.*
Change-Id: Iebe8a3a614bdb346fc30f8baab8b77e24ad466c2
Reviewed-on: https://chromium-review.googlesource.com/1029115Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553821}

Original change: https://crrev.com/c/1015850

Chromium and Google Chrome show different messages when the PDF plugin
is missing in Print Preview. Modify the test to accept either message,
to fix official build failures.

Bug: 814860
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I1672512db0c50bbf2e95ae6c9798dca82e4ee71c
Reviewed-on: https://chromium-review.googlesource.com/1028566Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553820}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c56c9493dbc3..6376ebcedebd

$ git log c56c9493d..6376ebced --date=short --no-merges --format='%ad %ae %s'

Created with:
  roll-dep src-internal
BUG=chromium:None


The AutoRoll server is located here: https://src-internal-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: Ic5adff09355d66c0d0ddb752674c42dd4b96683e
Reviewed-on: https://chromium-review.googlesource.com/1028970
Commit-Queue: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#553819}

TBR=tdresser@chromium.org

Bug: 836996
Change-Id: Ieb41ef895cdc2ea3ca26b47c4f3a2e9694bacf78
Reviewed-on: https://chromium-review.googlesource.com/1029110
Commit-Queue: Patrick Noland <pnoland@chromium.org>
Reviewed-by: Patrick Noland <pnoland@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553818}

No change to production logic aside from metrics changes.

This changes SafeBrowsing.WebView.UserOptIn into an enumerated histogram
in order to capture when the underlying API for user consent
(SafetyNetClient#isVerifyAppsEnabled) returns neither true nor false,
but indicates a failure.

Technically, this also covers the case where
PlatformServiceBridge#canUseGms() returns false (we also invoke the
callback with 'null'), however we don't log UMA metrics in this case
anyway.

This renames entries in enums.xml for clarity.

Bug: 836461
Test: check that metric is logged under chrome://histograms/SafeBrowsing
Change-Id: I570e88a66c5955026988ebe05ed6acc55685b0e2
Reviewed-on: https://chromium-review.googlesource.com/1027007Reviewed-by: Nate Fischer <ntfschr@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Nate Fischer <ntfschr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553817}

To make it easier to write fake DocumentLoaders for testing. Split the
implementation off into DocumentLoaderImpl.

Change-Id: I44f16c757b8a9be133936c41c231a552a7e05f0a
Reviewed-on: https://chromium-review.googlesource.com/1013998
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: dsinclair <dsinclair@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553816}

This CL adds a new interface viz::SkiaOutputSurface which extends
viz::OutputSurface for SkiaRenderer to support compositing with SkDDL
(skia deferred display list). SkiaRenderer draws quads into a DDL SkCanvas,
and draw operations will be recorded into a DDL.
In OutputSurface::SwapBuffers(), a GPU task will be scheduled with
gpu::Schduler. The task will be executed on the GPU thread when all resource
sync tokes are satisfied. The task will play the DDL back on a GrContext
which is backed by a native platform GL context.

We have a goal to use SkiaRenderer everywhere, and remove GLRenderer and
Software Compositor. The new viz::SkiaOutputSurface interface and
viz::OutputSurface interface will be merged into one interface when DirectRenderer
subclasses are removed. The new interface is for making development
faster because when we change methods in viz::SkiaOutputSurface, we will not break
all other existing OutputSurface implementations.

Bug: 824382
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I776a76dc8496d40f88950856867596f5c44f735f
Reviewed-on: https://chromium-review.googlesource.com/978366
Commit-Queue: Peng Huang <penghuang@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553815}

https://chromium.googlesource.com/chromium/third_party/ffmpeg.git/+log/ba32080311ac..16ee25d20583

$ git log ba3208031..16ee25d20 --date=short --no-merges --format='%ad %ae %s'
2018-04-25 dalecurtis Allow msvc builds to keep working with inline assmebly.

Created with:
  roll-dep src/third_party/ffmpeg

BUG=783021
TEST=none
TBR=liberato

Change-Id: I7e113fab5b3e03393a40bee445c26290778481cb
Reviewed-on: https://chromium-review.googlesource.com/1028842Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553814}

Bug: 835628
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: I06c983e2e12b804a3fd31ef909917c30d6cf1b06
Reviewed-on: https://chromium-review.googlesource.com/1027801
Commit-Queue: Ria Jiang <riajiang@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553813}

The paint cache used by layer paint delegates(views) do not work well
with Mirrored layers that are on different device scale factor.

This patch forces a schedule repaint when the user stops dragging the
window so that the invalid data in PaintCache is not used.

Bug: 786628
Change-Id: Ic249d592d4f93b47dc4ede4461f44a59ce7b18d7
Component: Window, Drag window, phantom window
Reviewed-on: https://chromium-review.googlesource.com/1028620Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Malay Keshav <malaykeshav@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553812}

Original change:
Initial Google tts engine settings page

- hooks up a message to retrieve display voice name and language (for *only* Google tts engine)
- adds the initial page UI (under UI review)
- adds string resources (under review)

Bug: 831286

TBR=dtseng@chromium.org,hcarmona@chromium.org,katie@chromium.org

Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I1bb2780758992ed9f8e240ed28a8176201d06f05
Reviewed-on: https://chromium-review.googlesource.com/1028766
Commit-Queue: David Tseng <dtseng@chromium.org>
Reviewed-by: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553811}

Also, alpha-ordered the links.

Bug: 829116, 759794
Change-Id: I5e71079964122591df68268136b23de3f605a8d6
Reviewed-on: https://chromium-review.googlesource.com/1028838
Commit-Queue: Max Moroz <mmoroz@chromium.org>
Reviewed-by: Abhishek Arya <inferno@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553810}

This patch introduces LeadingBoxOfEntireSecondaryRun() to wrap some
traversal logic, and also reduce the frequency |box| gets changed.

Change-Id: I8bf6c8170370bfb92e8a44a0620069015f11a07d
Reviewed-on: https://chromium-review.googlesource.com/1026930
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553809}

The reported crashes likely come from accessing objects in
WebContents when it's on the way to destruction. Adds a check to
ensure it won't attempt to access objects that already become invalid.

Bug: 788278
Change-Id: I8d4ef4907c73a93ac4d6d12e78540bbbbfbae08e
Reviewed-on: https://chromium-review.googlesource.com/1027170
Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553808}

Before this patch, the browser identification contained the version number as well (which happens to be the last directory of the path). This patch strips that directory so that the identification stays stable after upgrades.

Change-Id: I11b3b37c37f01eb07d8003174ecf5c80da1ba718
Reviewed-on: https://chromium-review.googlesource.com/1028663Reviewed-by: Owen Min <zmin@chromium.org>
Commit-Queue: Georges Khalil <georgesak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553807}