- 01 Mar, 2019 36 commits
-
-
Dan Beam authored
Screenshots: https://imgur.com/a/juHC3Fz R=dpapad@chromium.org BUG=936977 Change-Id: Ibef2af96df3599b79d3c94e979f8039a2cea42f0 Reviewed-on: https://chromium-review.googlesource.com/c/1496295 Commit-Queue: Dan Beam <dbeam@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Auto-Submit: Dan Beam <dbeam@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#636649}
-
Keishi Hattori authored
Adds a crash key so we can identify oom intervention related crashes. Bug: None Change-Id: I96722ec0af4362aa42536d119f92c06084cd9012 Reviewed-on: https://chromium-review.googlesource.com/c/1484396 Commit-Queue: Keishi Hattori <keishi@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Yuzu Saijo <yuzus@chromium.org> Cr-Commit-Position: refs/heads/master@{#636648}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 932fdb31. With Chromium commits locally applied on WPT: 68d5240e "[ChromeDriver] Set key modifiers with mouse actions" a6d9cfda "[WPT] Changes to generated files by CL 1476144" 4665f96b "RestrictDeviceSensorEventsToSecureContexts by default." 03505df6 "[Origin Policy] Implement error reporting via Reporting API" 2c455f7b "Move outputContext from XRSession to XRRenderState" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: rego@igalia.com: external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests NOAUTOREVERT=true TBR=lukebjerring No-Export: true Change-Id: I4657b21944de6dfc1a0f35c8aa408e0dc4684260 Reviewed-on: https://chromium-review.googlesource.com/c/1495746Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#636647}
-
Dale Curtis authored
BUG=930203 TEST=passes cq TBR=tguilbert Change-Id: I05eae1e344cbeabc48b12aca6cac64b2ea87c9e5 Reviewed-on: https://chromium-review.googlesource.com/c/1493161Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#636646}
-
Robbie McElrath authored
NetworkPortalDetectorImpl uses a raw pointer to the SystemNetworkContextManager's URLLoaderFactory, which will be invalid if mojo pipe runs into any issues. This CL makes it use a SahredURLLoaderFactory instead, which will handle failures automatically. Bug: 936625 Change-Id: I2ea71ef6cc46440f66349729e16cc2558ef145b1 Reviewed-on: https://chromium-review.googlesource.com/c/1495748Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Cr-Commit-Position: refs/heads/master@{#636645}
-
Aidan Wolter authored
This is a temporary solution until we implement a Fuchsia version of CastSysInfo. The only downside to using the dummy is that the strings, such as serial number, model, build, etc are all faked out. Bug: internal b/126768956 Test: CQ Change-Id: I3364d87c57d7f40dbe2d1e80b19bb2f02532512b Reviewed-on: https://chromium-review.googlesource.com/c/1496419Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Auto-Submit: Aidan Wolter <awolter@chromium.org> Commit-Queue: Aidan Wolter <awolter@chromium.org> Cr-Commit-Position: refs/heads/master@{#636644}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/00b1f1e2a50e..14a41b316425 git log 00b1f1e2a50e..14a41b316425 --date=short --no-merges --format='%ad %ae %s' 2019-02-28 dgarrett@google.com cbuildbot_launch: Wipe out the paygen subdir every build. Created with: gclient setdep -r src/third_party/chromite@14a41b316425 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@chromium.org Change-Id: I3d5e22db1376cf1b09627f757bc322a4137b6b79 Reviewed-on: https://chromium-review.googlesource.com/c/1495959Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#636643}
-
Xianzhu Wang authored
For pre-CompositeAfterPaint, we let subpixel accumulation propagate through isolation to keep consistent with legacy compositing code. For ComposteAfterPaint, we discard subpixel accumulation at isolation. Change-Id: Id9460dbb3c7c89931c38119e75f044b9079f3de8 Reviewed-on: https://chromium-review.googlesource.com/c/1488020Reviewed-by:
vmpstr <vmpstr@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#636642}
-
Miyoung Shin authored
- unsigned short / unsigned -> uint16_t. - USHRT_MAX -> std::numeric_limits<uint16_t>::max() - Reference: https://google.github.io/styleguide/cppguide.html#Integer_Types Bug: 929986 Change-Id: If80935d74042f4f8e50275d0ec17832e19ae7046 Reviewed-on: https://chromium-review.googlesource.com/c/1490367 Commit-Queue: Miyoung Shin <myid.shin@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#636641}
-
Sammie Quon authored
The dimming layer is a extra fullscreen quad that we do not need to draw. Remove it and dim the wallpaper instead. Does a minor refactoring and moves some code from wallpaper view to wallpaper controller to watch overview/tablet changes. Exposes wallpaper view so we can schedule paints outside. Also fixes a bug with the wallpaper preview being dimmed in tablet mode. Next we should be removing the whole shield widget. Test: manual Bug: 774690, 917902 Change-Id: I303762e3180de9f82f1d0b1398305f7c7f9e0837 Reviewed-on: https://chromium-review.googlesource.com/c/1481899Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Wenzhao (Colin) Zang <wzang@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#636640}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/5de69e91bd93..5546fb4fdd85 git log 5de69e91bd93..5546fb4fdd85 --date=short --no-merges --format='%ad %ae %s' 2019-02-28 tobine@google.com Vulkan:Adding custom pool allocator 2019-02-28 shrekshao@google.com Use string literal style for shader string in WebGLCompatibilityTest 2019-02-28 shrekshao@google.com add ext_float_blend feature and test 2019-02-28 ynovikov@chromium.org Require VK_EXT_queue_family_foreign for EGL_ANDROID_image_native_buffer support Created with: gclient setdep -r src/third_party/angle@5546fb4fdd85 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:None,chromium:930993,chromium:857138 TBR=ynovikov@chromium.org Change-Id: I84a19167fd94228ccf5aaa4b32ff738ee59c6219 Reviewed-on: https://chromium-review.googlesource.com/c/1496374Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#636639}
-
Ricardo Quesada authored
Add setTabletModeEnabled() private Autotest JS API. It is needed for certain ChromeOS tests that need to switch/to TabletMode without restarting Chrome. And using dbus PowerManager signal is not reliable. misc: added missing #include<> in tablet_mode_controller.cc reported by git cl lint TEST=Tested with browser_test'test that is included in this CL. Manually tested on DUT by calling JS API manually. BUG=chromium:931767 Change-Id: I25e888cba38c08188ec21475d3530ad3090bbcd3 Reviewed-on: https://chromium-review.googlesource.com/c/1470937 Commit-Queue: Ricardo Quesada <ricardoq@chromium.org> Auto-Submit: Ricardo Quesada <ricardoq@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Mitsuru Oshima (OOO til 3/4) <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#636638}
-
Varun Khaneja authored
R=drubery Bug: 933065 Change-Id: If5b7c41875f36f53c217607c2270688c4af3cad9 Reviewed-on: https://chromium-review.googlesource.com/c/1496298 Commit-Queue: Varun Khaneja <vakh@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Commit-Queue: Nathan Parker <nparker@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Reviewed-by:
Nathan Parker <nparker@chromium.org> Auto-Submit: Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#636637}
-
Hiroshige Hayashizaki authored
It's always InlineType::kBlock. Bug: 934651 Change-Id: I12090136c066387c004e09de63d0286daac12f9f Reviewed-on: https://chromium-review.googlesource.com/c/1485126 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Andy Paicu <andypaicu@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#636636}
-
James Cook authored
It is only used with mus. This also makes the class name match the file name. Also fix the build file so it only compiles when mus is enabled. TBR=msw@chromium.org Bug: none Change-Id: I93dbc1a14051208bb0d5964fe68ec4d22201d2ce Reviewed-on: https://chromium-review.googlesource.com/c/1495812Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Commit-Queue: Michael Wasserman <msw@chromium.org> Auto-Submit: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#636635}
-
chrome://extensions-framedpapad authored
Since M59, this URL simply forwards to chrome://extensions. This CL removes the redirect. reached" page. Bug: None Test: Visit chrome://extensions-frame, should see "This site can’t be Change-Id: Iff52fdf5cfbd6e945b1565945f786e77591edfce Reviewed-on: https://chromium-review.googlesource.com/c/1495864Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#636634}
-
Avery Musbach authored
The |kTopViewInset| window property can change during overview. Particularly, the Settings window behaves that way if overview starts during transition to tablet mode as another window carries over from clamshell snapped state to tablet split view. Now, when the |kTopViewInset| window property changes, consistent with existing behavior for bounds changes, the visual appearance of overview shall generally be corrected at the expense of interrupting animation effects. The one exception is if the |kTopViewInset| window property changes while overview is being prepared. In this case, still consistent with existing behavior for bounds changes, nothing shall be done, because when the overview preparation has been completed, overview will look right anyway. Test: ash_unittests OverviewSessionTest.TopViewInsetChangeDuringOverview Bug: 932816 Change-Id: I482d5ce5c24ff40ccc28e898ae3668f6831b71bd Reviewed-on: https://chromium-review.googlesource.com/c/1495444 Commit-Queue: Avery Musbach <amusbach@chromium.org> Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#636633}
-
Matt Reynolds authored
Information about the HID report descriptor, including a hierarchical representation of the described collections and reports, will be made available through the WebHID API. This CL adds information about input, output, and feature reports contained within a collection, as well as a list of the children of the collection. BUG=890096 Change-Id: I7d40fef222baf9456dda0920ee88550ca02ff41f Reviewed-on: https://chromium-review.googlesource.com/c/1381263 Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Cr-Commit-Position: refs/heads/master@{#636632}
-
Michael Thiessen authored
# Dependency already existed, this is just a mechanical code relocation. TBR=vakh@chromium.org Bug: 933884 Change-Id: Iea4dad10d14698a681a5e90038313d1c3fe1683e Reviewed-on: https://chromium-review.googlesource.com/c/1491908Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#636631}
-
Katie D authored
Bug: 905419 Change-Id: I8b1980ff1ea6fdce686f9fd7de71058efc1ec6a0 Reviewed-on: https://chromium-review.googlesource.com/c/1490406 Commit-Queue: Katie Dektar <katie@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Auto-Submit: Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#636630}
-
Mei Liang authored
This CL implements TabGroupModelFilter, but it's not used in anywhere yet. Bug: 934557 Change-Id: I3f25fc913aa9f76aa8b5f393c6c59b6e082681a3 Reviewed-on: https://chromium-review.googlesource.com/c/1480721Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#636629}
-
Ramya Nagarajan authored
Histograms are extended to M90, since it will be useful to track request latency and feature utilization over a long timeframe. Also picked a milestone whose feature freeze avoids holidays. Bug: 930908, 930909, 930913, 930921 Change-Id: I5caecf78a64fead656f1b059a841eafa68f99764 Reviewed-on: https://chromium-review.googlesource.com/c/1490435Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Ramya Nagarajan <ramyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#636628}
-
John Lee authored
https://i.imgur.com/BAXJzRC.png Bug: 924176 Change-Id: I4328752370dafa3c00d178b0b28a3320e26b071d Reviewed-on: https://chromium-review.googlesource.com/c/1490053 Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#636627}
-
Juanmi Huertas authored
These functions receive parameters of type long, and those were not being checked in case they were receiving infinity or other not-long values. Added EnforceRange in the idl to ensure those functions are receiving valid longs. Removing the expected on the WPT tests to stop ignoring these failures. Changing a fast test that was testing the original throw behavior. Bug: 934841, 934839, 934837 Change-Id: Iaa95d3c5ed9ac545472ff72e9ef4b535d22cbedf Reviewed-on: https://chromium-review.googlesource.com/c/1494798 Commit-Queue: Juanmi Huertas <juanmihd@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#636626}
-
Morten Stenshorne authored
This saves 192 bytes [*] of stack space per in-flow layout recursion. [*] Linux 64bit release. Bug: 930637 Change-Id: Ib4531d031312d97023c5e14ef40b8f25684ae29c Reviewed-on: https://chromium-review.googlesource.com/c/1489421Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#636625}
-
Staphany Park authored
AppCache will also need to share the same key used to pad CacheStorage. This CL also updates the singleton key's implementation from base::LazyInstance to base::NoDestructor. Bug: 918293 Change-Id: I792d700a445dc1bfa408564401288e6bd56918b2 Reviewed-on: https://chromium-review.googlesource.com/c/1490951Reviewed-by:
Ben Kelly <wanderview@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Commit-Queue: Staphany Park <staphany@chromium.org> Cr-Commit-Position: refs/heads/master@{#636624}
-
Kevin Strohbehn authored
Bug: 936504 Change-Id: I98436eb82c64fe5b3b6ba1a9d39176317883026a Reviewed-on: https://chromium-review.googlesource.com/c/1496239 Commit-Queue: Kevin Strohbehn <ginko@google.com> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Auto-Submit: Kevin Strohbehn <ginko@google.com> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#636623}
-
Ian Kilpatrick authored
Since we started painting floating objects directly (instead of using the FloatingObjects data-structure), we were only using this for overflow calculation. This change removes the copy back, and modifies the visual&layout overflow calculations to use the correct object. (non-LayoutNG object uses the FloatingObjects data-structure still, LayoutNG object uses the object directly). This change breaks some LayoutNGBlockFragmentation tests. Bug: 635619 Change-Id: Ie0422b4b9071eb75f293c8c5510af87e0dac21b1 Reviewed-on: https://chromium-review.googlesource.com/c/1474677Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Aleks Totic <atotic@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#636622}
-
Roman Aleksandrov authored
Change messages of the warning for both cases: 1) Non-risky configuration 2) Risky configuration Bug: 936955 Change-Id: I32c863decab87e8ea11183039edeceeadab66475 Reviewed-on: https://chromium-review.googlesource.com/c/1495535Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Commit-Queue: Roman Aleksandrov <raleksandrov@google.com> Cr-Commit-Position: refs/heads/master@{#636621}
-
Ben Pastene authored
R=jbudorick, martiniss Bug: 815387, 731982, 800178, 731980, 731976, 731966 Change-Id: If2b3c143766e0738be985f7c7542efc4569afc52 Reviewed-on: https://chromium-review.googlesource.com/c/1496250 Auto-Submit: Ben Pastene <bpastene@chromium.org> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#636620}
-
John Delaney authored
This test is flaking due to not waiting for resources to finish loading. Currently "AddMinimumAdResourceExpectation" only checks for resources reported as ads to be identified, rather than waiting for the resources to complete. This modifies the method to wait for complete ad resources. This change modifies the EvalJS call that plays the video to not have a user gesture so it is clear that the frame doesn't receive user activation. This is purely to provide clarity in the code and does not change the testing path. Flake analysis: https://analysis.chromium.org/p/chromium/flake-portal/analysis/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vNGMxNmRkZDA1NmY4ZTE3NGMzOGQ1Zjg2Y2FiMGJkYjBjNzM5MzRmMww Change-Id: Ide73b6696610a134c4d0c5990d3a92685f1fc5b9 Reviewed-on: https://chromium-review.googlesource.com/c/1495674 Commit-Queue: John Delaney <johnidel@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#636619}
-
Piotr Pawliczek authored
A list of enterpise printers is not ready immediately after creation of CupsPrintersManager. It caused a problem for testing procedure since from the level of autotest_private_api we do not know if the final list is ready or there are still some ongoing calculations. A new method called OnEnterprisePrintersInitialized() was added to the observer of CupsPrintersManager to solve this issue. Also whole code related to enterprise printers were refactored, large part of functionality was moved from SyncedPrintersManager to new class EnterprisePrintersProvider. Classes ExternalPrintersPrefBridge and DeviceExternalPrintersSettingsBridge have been merged into one class called CalculatorsPoliciesBinder. This is reland of CL:1220547, it fixes the problem detected by the test AutotestPrivateApiTest.AutotestPrivate (method execution after destruction of CupsPrintersManager object). BUG=chromium:816996 TEST=Tested on cave with the use of CL:1451591 TBR=achuith@chromium.org Change-Id: I70958421aadd9fab9a2401555bef0dbb28ad5a6a Reviewed-on: https://chromium-review.googlesource.com/c/1491909 Commit-Queue: Piotr Pawliczek <pawliczek@chromium.org> Reviewed-by:
Sean Kau <skau@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Auto-Submit: Piotr Pawliczek <pawliczek@chromium.org> Cr-Commit-Position: refs/heads/master@{#636618}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/fe83cfa6b43a..5117888302cf git log fe83cfa6b43a..5117888302cf --date=short --no-merges --format='%ad %ae %s' 2019-02-28 iannucci@chromium.org [led] Roll back to cc015d8903532826f4430b87501a3c542ef468ce. Created with: gclient setdep -r src/third_party/depot_tools@5117888302cf The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:936254 TBR=agable@chromium.org Change-Id: I6939abe7d0d1b247145dbda437177f52ca468e19 Reviewed-on: https://chromium-review.googlesource.com/c/1496157Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#636617}
-
Ken Rockot authored
Introduces new bindings types described by https://docs.google.com/document/d/18pOsJOTuLVH-V7s9xwR-em9t-R4icyPjk7i8I8bfjjg/edit In summary: - Remote will replace InterfacePtr - PendingRemote will replace InterfacePtrInfo - PendingReceiver will replace InterfaceRequest - Receiver will replace Binding - mojom IDL will use pending_remote<T> and pending_receiver<T> to replace T and T& syntax. See the lone unittest.cc and .test-mojom files in this patch for working example usage. Bug: 875030 Change-Id: Id4b76599d4d6973661c80fa438b37b14d4b1e93a Reviewed-on: https://chromium-review.googlesource.com/c/1474844 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#636616}
-
Aran Gilman authored
Currently it only looks at the background color and does not check whether high contrast mode is enabled overall. Future CLs will add the ability to process and correctly classify background images. This code is not under platform/graphics with the existing high contrast code because it needs access to ComputedStyle and LayoutObject, and code in platform cannot depend on core. Follow-up CLs are planned to modify GraphicsContext::SetHighContrast() to take the return value of this function as a parameter. Bug: 925949 Change-Id: I79376205d5ee5d0b20a1138ffcf1568ac7bf0ae7 Reviewed-on: https://chromium-review.googlesource.com/c/1448988 Commit-Queue: Aran Gilman <gilmanmh@google.com> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#636615}
-
Gyuyoung Kim authored
As a step to annotate the macros of Allocator for the Onion Soup, this CL annotates some classes of //third_party/blink/renderer/platform/font with the macros of Allocator. After some analyzes, it was concluded that for the case of FontFallbackList, FontGlobalContext, FontSelectionValue, FontUniqueNameLookup, OpenTypeVerticalData, ShapeResult, and UnicodeRangeSet classes, they make sense to use USING_FAST_MALLOC because they have been used with smart pointers. In HarfBuzzShaper class, it makes sense to use DISALLOW_NEW because it's used as a member variable with a reference type. Bug: 919389 Change-Id: Ia03ab46b86af39f6cb5a2d5161a7cb0809ddebb7 Reviewed-on: https://chromium-review.googlesource.com/c/1491879Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#636614}
-
- 28 Feb, 2019 4 commits
-
-
Aaron Krajeski authored
From: https://html.spec.whatwg.org/multipage/canvas.html: """ When the ImageData() constructor is invoked with its first argument being an Uint8ClampedArray source and its second and optional third arguments being numeric arguments sw and sh, it must run these steps: 1. Let length be the number of bytes in source. 2. If length is not a nonzero integral multiple of four, then throw an "InvalidStateError" DOMException. """ Previously we were throwing an IndexSizeError. Change the error type to match the spec. Bug: 934838 Change-Id: Id122dcbae49426c3c10bf690f8bf940bbf481fc7 Reviewed-on: https://chromium-review.googlesource.com/c/1495195 Commit-Queue: Aaron Krajeski <aaronhk@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#636613}
-
Harley Li authored
This is a reland of 3dc09a0d Original change's description: > [DevTools] Application>Clear Site Data: stop service worker when unregistering it > > We should stop the service worker before unregistering it. > > Originally, clicking "Clear site data" will unregister the service worker. In > Application>Service Workers, the service worker's tab title is marked as > "deleted", but its "status" says it's still running. > > Bug: 894783 > Change-Id: Ib1550cfab8274a27495bb795501f54e9a19f6a36 > Reviewed-on: https://chromium-review.googlesource.com/c/1480725 > Reviewed-by: Dmitry Gozman <dgozman@chromium.org> > Commit-Queue: Haihong Li (Harley) <hhli@chromium.org> > Cr-Commit-Position: refs/heads/master@{#635263} Bug: 894783 Change-Id: I4b1b9a2f3764391846e47f8752cab6e223adbb1d Reviewed-on: https://chromium-review.googlesource.com/c/1490432Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Commit-Queue: Haihong Li (Harley) <hhli@chromium.org> Cr-Commit-Position: refs/heads/master@{#636612}
-
Kenichi Ishibashi authored
This seems flaky. Update TestExpectations. Tbr: nhiroki@chromium.org,falken@chromium.org Bug: 937048 Change-Id: Ibf0b0145af5eb891fa06a3759225cf8cd3ab2a6e Reviewed-on: https://chromium-review.googlesource.com/c/1496254Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#636611}
-
Gayane Petrosyan authored
This reverts commit dbf62e53. Reason for revert: Crash following ProfileResetter::ResetNtpCustomizations() call. Original change's description: > Reset NTP customizations when all settings are reset. > > Bug: 931806 > Change-Id: I89db8c24edfb9a7e1c4c6bf3ac3d0faa68d70ca1 > Reviewed-on: https://chromium-review.googlesource.com/c/1472450 > Commit-Queue: Gayane Petrosyan <gayane@chromium.org> > Reviewed-by: Balazs Engedy <engedy@chromium.org> > Reviewed-by: Ramya Nagarajan <ramyan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#636087} TBR=engedy@chromium.org,gayane@chromium.org,ramyan@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 936830 Change-Id: Ib81b7839c10f6bd7e75b438c2f98b015e866d4a5 Reviewed-on: https://chromium-review.googlesource.com/c/1495749Reviewed-by:
Gayane Petrosyan <gayane@chromium.org> Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Cr-Commit-Position: refs/heads/master@{#636610}
-