GitLab

I'm going to nuke DockInfo soonish. This is a stup in that
direction.

BUG=none
TEST=none
R=erg@chromium.org

Review URL: https://codereview.chromium.org/165463003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251342 0039d316-1c4b-4281-b951-d872f2087c98

The fake PO2TS does not actually use the request context. This CL overrides the
GetRequestContext() in PO2TS and returns NULL to avoid errors like the ones
explained at (that occur on iOS)
https://groups.google.com/a/chromium.org/forum/#!msg/chromium-dev/HWdp5roPpF4/j7drB1WW01EJ

BUG=NONE

Review URL: https://codereview.chromium.org/166573002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251341 0039d316-1c4b-4281-b951-d872f2087c98

The Geolocation API was launched a long time ago, and a mock is used in layout tests.
There are no unit tests so nothing needs to be set for them.

BUG=343592,36451

Review URL: https://codereview.chromium.org/164163002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251340 0039d316-1c4b-4281-b951-d872f2087c98

The functionality is the same, just moving the code to a new place.

NOTRY=True
BUG=333995
R=bauerb@chromium.org, brettw@chromium.org, joaodasilva@chromium.org, nhiroki@chromium.org, noms@chromium.org, rlarocque@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251221

Review URL: https://codereview.chromium.org/150003004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251339 0039d316-1c4b-4281-b951-d872f2087c98

String will be used at OOBE.

BUG=334576

Review URL: https://codereview.chromium.org/166663003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251338 0039d316-1c4b-4281-b951-d872f2087c98

BUG=343650
TEST=manually

Review URL: https://codereview.chromium.org/159903007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251337 0039d316-1c4b-4281-b951-d872f2087c98

BCKSFactory::SetTestingFactory() calls BCKSFactory::BrowserContextShutdown(),
which a BCKSFactory subclass may override to perform operations that result in
BrowserContextDependencyManager::AssertBrowserContextWasntDestroyed() being
called (e.g., BCKSFactory::GetServiceForContext()). When used with
TestingProfile::Builder, BCKSFactory::SetTestingFactory() is called *before*
the TestingProfile calls
BrowserContextDependencyManager::CreateBrowserContextServicesForTest(). These
facts set up the potential for a flaky crash: if the BrowserContext instance
being used is at the same address as one that had been used in a previous test,
then the call to AssertBrowserContextWasntDestroyed() will raise an error. This
CL eliminates the potential for that crash by explicitly informing
BrowserContextDependencyManager that the BrowserContext instance being used in
BCKSFactory::SetTestingFactory() is live.

NOTRY=true

Review URL: https://codereview.chromium.org/159763004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251336 0039d316-1c4b-4281-b951-d872f2087c98

In this CL I introduce 2 classes (EmbeddedSharedWorkerDevToolsAgent, EmbeddedSharedWorkerStub).

EmbeddedSharedWorkerStub and EmbeddedSharedWorkerDevToolsAgent are almost same as WebSharedWorkerStub and SharedWorkerDevToolsAgent which are used in the worker process now.
These classes are not used yet.
EmbeddedSharedWorkerStub will be created when CreateWorker message is received by RenderThreadImpl.

In this CL I move shared_worker_devtools_agent.* from content/worker/ to content/child/ because I want use it from content/renderer/shared_worker.

BUG=327256

Review URL: https://codereview.chromium.org/158953008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251335 0039d316-1c4b-4281-b951-d872f2087c98

It will be used instead of WorkerMessageFilter when "enable-embedded-shared-worker" is set.

BUG=327256

Review URL: https://codereview.chromium.org/166273002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251334 0039d316-1c4b-4281-b951-d872f2087c98

When crosscompiling for android on mac hosts, some machines don't have
the NLS header files available. Rather than insist on another build
dependency, just disable NLS when building yasm; we can live without
localisation in a build-time tool.

BUG=

Review URL: https://codereview.chromium.org/146833017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251333 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251332 0039d316-1c4b-4281-b951-d872f2087c98

TBR=jkummerow@chromium.org

Review URL: https://codereview.chromium.org/165633002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251331 0039d316-1c4b-4281-b951-d872f2087c98

BUG=343024

Review URL: https://codereview.chromium.org/135013007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251330 0039d316-1c4b-4281-b951-d872f2087c98

On ES2 with OES_texture_float/OES_texture_half_float support, it is only possible to render to 16-bit half float textures using EXT_color_buffer_half_float. There's no support for rendering to 32-bit float textures in ES2 extensions. On ES3, rendering to some 32-bit float texture formats is exposed with EXT_color_buffer_float, but one must use the sized internal formats specified in ES3 core to do that. To expose this, a new command buffer extension is added which enables clients to directly use the sized internal format GL_RGBA32F.

A similar extension is also added to expose GL_RGB32F on desktop GL platforms for the sake of consistency.

These extensions are available whenever rendering to float textures is available. To support the current version of ANGLE, format conversions back to unsized internal formats are added to ui/gl.

Tests are added to cover this functionality. The new tests also add coverage for the handling of 32-bit float formats on ES2 and on desktop GL that existed before this patch.

BUG=329605
TEST=gpu_unittests, WebGL conformance tests

Review URL: https://codereview.chromium.org/139013008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251329 0039d316-1c4b-4281-b951-d872f2087c98

Apparently this type is not used by the unit tests and allow us to
remove another entry from the DEPS file.

BUG=140037
TEST=unit_tests
R=joi@chromium.org,blundell@chromium.org

Review URL: https://codereview.chromium.org/165453003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251328 0039d316-1c4b-4281-b951-d872f2087c98

Rename input_method_property to input_method_menu_item, and move to ash/ime.

This is a reland of https://codereview.chromium.org/150203015,reverted by https://codereview.chromium.org/165453002

Use Singleton<> instead of trying to maintain my own singleton.

BUG=342336, 343044

Review URL: https://codereview.chromium.org/165783002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251327 0039d316-1c4b-4281-b951-d872f2087c98

This should fix NULL pointer access failure on app reload.

Review URL: https://codereview.chromium.org/166153002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251324 0039d316-1c4b-4281-b951-d872f2087c98

The supported non-blocking path for drawing content that updates on the
order of 60fps is to create a CAOpenGLLayer and set its asynchronous
property to YES. In practice, just calling setNeedsDisplay about
about 60fps results in noticeable jank.

The downside to setting the CAOpenGLLayer to be asynchronous is that it
will be asked, every vsync, if it has anything new to draw (via the
canDrawInOpenGLContext callback), resulting in high CPU usage, even
when idle.

The solution to this is to dynamically set the isAsynchronous property
to YES when new frames are seen, and leave it at NO when it has been a
while (defined as a quarter second arbitrarily) since a new frame has
been generated.

Note that when a new frame is generated, the gotNewFrame call is made,
while when a re-display is required (say, because the window became
visible), only setNeedsDisplay is called. This is to avoid going in to
asynchronous mode unnecessarily.

Also note that the DelayTimer object is hung off the RWHVMac class
instead of the CompositingIOSurfaceLayer object. This is because
the DelayTimer class requires a C++ class to hang off of, instead of an
Objective C interface.

BUG=340133

Review URL: https://codereview.chromium.org/165623002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251323 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None

Review URL: https://codereview.chromium.org/163023002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251322 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/165803003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251321 0039d316-1c4b-4281-b951-d872f2087c98

[IME] Releases key events to Chromium's default behavior if no handler defined in the active IME extension.

BUG=337082
TEST=Locally verified in sandbox.

Review URL: https://codereview.chromium.org/162973002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251320 0039d316-1c4b-4281-b951-d872f2087c98

BUG=336124

Review URL: https://codereview.chromium.org/164183004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251319 0039d316-1c4b-4281-b951-d872f2087c98

This more closely matches Ubuntu build options, and fixes at least some of
NSS-related test failures.

BUG=313751
TBR=glider@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/163053004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251318 0039d316-1c4b-4281-b951-d872f2087c98

BUG=341224

Review URL: https://codereview.chromium.org/163183002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251317 0039d316-1c4b-4281-b951-d872f2087c98

unused prerenders.  It also reports on the total number of bytes
fetched for that profile since the last prerender report.

This gives us insight into the balance of used vs wasted prerenders.
Understanding the ratio of wasted prerender bytes to total bytes gives
us a better understanding of whether we need an option to disable
prerender on mobile networks.

BUG=334602

Review URL: https://codereview.chromium.org/160513002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251316 0039d316-1c4b-4281-b951-d872f2087c98

Add a custom user pod icon for such apps.
Enable this UI by default.
Provide --disable-new-kiosk-ui flag which reverts back to the original UI (menu).

BUG=334304,341884
R=xiyuan@chromium.org
TBR=oshima

Review URL: https://codereview.chromium.org/158833003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251315 0039d316-1c4b-4281-b951-d872f2087c98

The strings currently say Chrome apps will close. Actually they will
close and then relaunch in the new desktop type.

BUG=315239

Review URL: https://codereview.chromium.org/161083004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251314 0039d316-1c4b-4281-b951-d872f2087c98

I'll look into if we can eliminate this.

BUG=343696

Review URL: https://codereview.chromium.org/165273002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251313 0039d316-1c4b-4281-b951-d872f2087c98

BUG=343616

Review URL: https://codereview.chromium.org/164403002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251312 0039d316-1c4b-4281-b951-d872f2087c98

call. The call takes an array of activity IDs (each activity
ID is a string) and deletes the matching activities form the
Activity Log database.

BUG=330210

Review URL: https://codereview.chromium.org/154053004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251311 0039d316-1c4b-4281-b951-d872f2087c98

Modifies the output to the following style:
  #LEAK renderer pid PID (DETAIL_IN_JSON_FORMAT)

Now, this leaking output is not used anywhere, and this will 
be used by https://codereview.chromium.org/148153009/.

See also:
https://docs.google.com/a/chromium.org/document/d/1sFAsZxeISKnbGdXoLZlB2tDZ8pvO102ePFQx6TX4X14/edit

BUG=332630

Review URL: https://codereview.chromium.org/142043010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251310 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Fix (or tag) uses of explicit '64' instead of GL_MAILBOX_SIZE_CHROMIUM (https://codereview.chromium.org/138763009/)

Reason for revert:
FAILED: c++ -MMD -MF obj/cc/layers/cc_unittests.texture_layer_unittest.o.d -DV8_DEPRECATION_WARNINGS -D_FILE_OFFSET_BITS=64 -DCHROMIUM_BUILD -DCOMPONENT_BUILD -DTOOLKIT_VIEWS=1 -DUI_COMPOSITOR_IMAGE_TRANSPORT -DUSE_AURA=1 -DUSE_ASH=1 -DUSE_CAIRO=1 -DUSE_GLIB=1 -DUSE_DEFAULT_RENDER_THEME=1 -DUSE_NSS=1 -DUSE_X11=1 -DOS_CHROMEOS=1 -DUSE_XI2_MT=2 -DIMAGE_LOADER_EXTENSION=1 -DENABLE_REMOTING=1 -DENABLE_WEBRTC=1 -DUSE_PROPRIETARY_CODECS -DENABLE_PEPPER_CDMS -DENABLE_CONFIGURATION_POLICY -DENABLE_INPUT_SPEECH -DENABLE_NOTIFICATIONS -DENABLE_HIDPI=1 -DUSE_UDEV -DENABLE_EGLIMAGE=1 -DENABLE_TASK_MANAGER=1 -DENABLE_EXTENSIONS=1 -DENABLE_PLUGINS=1 -DENABLE_SESSION_SERVICE=1 -DENABLE_THEMES=1 -DENABLE_AUTOFILL_DIALOG=1 -DENABLE_BACKGROUND=1 -DENABLE_AUTOMATION=1 -DENABLE_GOOGLE_NOW=1 -DCLD_VERSION=2 -DENABLE_FULL_PRINTING=1 -DENABLE_PRINTING=1 -DENABLE_SPELLCHECK=1 -DENABLE_CAPTIVE_PORTAL_DETECTION=1 -DENABLE_APP_LIST=1 -DENABLE_MANAGED_USERS=1 -DENABLE_MDNS=1 -DGTEST_HAS_POSIX_RE=0 -DGL_GLEXT_PROTOTYPES -DSKIA_DLL -DGR_GL_IGNORE_ES3_MSAA=0 -DSK_ENABLE_INST_COUNT=0 -DSK_SUPPORT_GPU=1 '-DGR_GL_CUSTOM_SETUP_HEADER="GrGLConfig_chrome.h"' -DSK_ENABLE_LEGACY_API_ALIASING=1 -DSK_ATTR_DEPRECATED=SK_NOTHING_ARG1 -DSK_USE_POSIX_THREADS -DSK_DEFERRED_CANVAS_USES_FACTORIES=1 -DUNIT_TEST -DGTEST_HAS_RTTI=0 -DU_USING_ICU_NAMESPACE=0 -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -D_FORTIFY_SOURCE=2 -I../../cc/test -I../../cc -I../.. -I../../third_party/khronos -I../../gpu -I../../skia/config -I../../third_party/skia/src/core -I../../third_party/skia/include/core -I../../third_party/skia/include/effects -I../../third_party/skia/include/pdf -I../../third_party/skia/include/gpu -I../../third_party/skia/include/lazy -I../../third_party/skia/include/pathops -I../../third_party/skia/include/pipe -I../../third_party/skia/include/ports -I../../third_party/skia/include/utils -I../../skia/ext -I../../testing/gmock/include -I../../testing/gtest/include -I../../third_party/icu/source/i18n -I../../third_party/icu/source/common -Werror -pthread -fno-exceptions -fno-strict-aliasing -Wall -Wno-unused-parameter -Wno-missing-field-initializers -fvisibility=hidden -pipe -fPIC -pthread -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -O2 -fno-ident -fdata-sections -ffunction-sections -funwind-tables -fno-rtti -fno-threadsafe-statics -fvisibility-inlines-hidden -Wsign-compare  -c ../../cc/layers/texture_layer_unittest.cc -o obj/cc/layers/cc_unittests.texture_layer_unittest.o
In file included from ../../testing/gmock/include/gmock/gmock-spec-builders.h:71:0,
                 from ../../testing/gmock/include/gmock/gmock-generated-function-mockers.h:43,
                 from ../../testing/gmock/include/gmock/gmock.h:61,
                 from ../../cc/layers/texture_layer_unittest.cc:33:
../../testing/gmock/include/gmock/gmock-matchers.h: In member function 'bool testing::internal::EqMatcher<Rhs>::Impl<Lhs>::MatchAndExplain(Lhs, testing::MatchResultListener*) const [with Lhs = const gpu::Mailbox&, Rhs = gpu::Mailbox]':
../../cc/layers/texture_layer_unittest.cc:2173:1:   instantiated from here
../../testing/gmock/include/gmock/gmock-matchers.h:784:1: error: no match for 'operator==' in 'lhs == ((const testing::internal::EqMatcher<gpu::Mailbox>::Impl<const gpu::Mailbox&>*)this)->testing::internal::EqMatcher<gpu::Mailbox>::Impl<const gpu::Mailbox&>::rhs_'
../../testing/gmock/include/gmock/gmock-matchers.h:784:1: note: candidate is:
../../testing/gtest/include/gtest/internal/gtest-linked_ptr.h:213:6: note: template<class T> bool testing::internal::operator==(T*, const testing::internal::linked_ptr<T>&)
../../testing/gmock/include/gmock/gmock-matchers.h:784:1: error: control reaches end of non-void function [-Werror=return-type]


Original issue's description:
> Fix (or tag) uses of explicit '64' instead of GL_MAILBOX_SIZE_CHROMIUM
> 
> That way we can easily change the size later. Security says 64 may be overkill.
> 
> BUG=None
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251306

TBR=danakj@chromium.org,piman@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=None

Review URL: https://codereview.chromium.org/166853002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251309 0039d316-1c4b-4281-b951-d872f2087c98

There was nothing specific about this class, so I'm generalizing it and moving it upwards in the tree for more use cases (e.g. app banners).

Code that will use it is not ready for review, but is located at https://chromiumcodereview.appspot.com/156343002/

BUG=341556

Review URL: https://codereview.chromium.org/155273002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251308 0039d316-1c4b-4281-b951-d872f2087c98

BUG=323150

Review URL: https://codereview.chromium.org/151203005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251307 0039d316-1c4b-4281-b951-d872f2087c98

That way we can easily change the size later. Security says 64 may be overkill.

BUG=None

Review URL: https://codereview.chromium.org/138763009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251306 0039d316-1c4b-4281-b951-d872f2087c98

TranslatePrefs now needs the path to preferences in its constructor.
To help with this, a helper method is added to TranslateTabHelper to build
TranslatePrefs instances.
As a result, TranslatePrefs are no longer instantiated on the stack, but rather
on the heap.

BUG=335079
TBR=battre, jochen, joi

Review URL: https://codereview.chromium.org/159883002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251305 0039d316-1c4b-4281-b951-d872f2087c98

In normal mode, the plugin is created at the moment the page is loaded. Then when the first time the plugin is clicked. It will set the flag "has_webkit_focus_" true in real plugin instance. Then, send out the focus change notification in PepperPluginInstanceImpl::SetWebKitFocus, which will finally affect the IME stuff.

However, at "Click to play" mode, WebViewPlugin is created at first, which will be replaced by real plugin. When the first time we click, the real plugin is created, loaded. But no focus is set in real plugin, which cause the IME stuff can't be enabled. 

In solution, we transfer the |focused_| in WebViewPlugin to new plugin after it loaded.

BUG=336740

Review URL: https://codereview.chromium.org/144803003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251303 0039d316-1c4b-4281-b951-d872f2087c98

Adds bubble buttons to indicate which settings are shared.

When signed in as a secondary user (i.e., added to a multi-profile session),
a banner should be display. The "Internet connection" header should show a
shared icon. Owner-controlled settings should show the owner icon.
"Require password to wake from sleep" is a special case.

This also fixes a bug where controlled settings on managed devices should say
they are controlled by policy, but instead say the (non-existent) owner controls
them.

For details, see PRD with additional links at bottom:
https://docs.google.com/a/google.com/document/d/1G09Mql1TtVFA4qhb7hlt4u2crBv6_fhrZMf40Yo--lc

BUG=326354
R=dbeam@chromium.org, stevenjb@chromium.org, oshima@chromium.org

Review URL: https://codereview.chromium.org/152143009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251302 0039d316-1c4b-4281-b951-d872f2087c98

This change brings this type of event in line with the rest - having separate types
for audio / video. As a new type that is potentially sent over in RTCP is introduced,
a new RTCP encoding for that type is added as well.

This change is backwards-compatible because these events aren't being sent over in RTCP because they are not processed by ReceiverRtcpEventSubscriber.

BUG=337901

Review URL: https://codereview.chromium.org/164253003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251301 0039d316-1c4b-4281-b951-d872f2087c98

R=tapted
BUG=343692

Review URL: https://codereview.chromium.org/164953003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251300 0039d316-1c4b-4281-b951-d872f2087c98