- 01 Oct, 2020 40 commits
-
-
Siyu An authored
We found the offer data would be successfully synced down to client but would not be saved. After debugging we found the client tag hash for the offer data is missing in the update response. Similar to wallet data, every time offer data is updated, it will be a full update. So we need to set this manually. Bug: 1112095 Change-Id: I304a078f44f5647d4f3da26b7086f0ddec973ab5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441939 Commit-Queue: Siyu An <siyua@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#812881}
-
Moe Ahmadi authored
Fixed: 1130864 Change-Id: I5ca24433cb2892a8a1e8f243b6f280f9389b66ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442092 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Auto-Submit: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#812880}
-
Anders Hartvoll Ruud authored
- The insertion point crossing flag needs to be reset in a similar way to the tree crossing flag. Otherwise flags may "leak" from one nested complex selector to another unrelated nested complex selector. - In ExtractInvalidationSetFeaturesFromSelectorList, don't return as soon as we encounter kRequiresSubtreeInvalidation, as this causes selectors following a :host-context to be skipped, for example we would ignore '.b' in ':is(:host-context(.a), .b)'. - We should also not propagate the kRequiresSubtreeInvalidation value from nested complex selectors, as it causes whole subtree invalid for _everything_ in the top-level rightmost compound, even the parts unrelated to kRequiresSubtreeInvalidation. For example, for ':is(:host-context(.a), .b)', .b would be marked as whole subtree invalid. Instead we rely on this being handled locally inside each call to UpdateInvalidationSetsForComplex. Bug: 568705 Change-Id: If54b7c006a4c1d886513a0bfb3e075fd4f71be63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438417 Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#812879}
-
Yusuf Sengul authored
Bug: 1133586 Change-Id: I791e4e900936fbc9349d0742c93bc2a3f13700d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2439675Reviewed-by:
Rakesh Soma <rakeshsoma@google.com> Commit-Queue: Yusuf Sengul <yusufsn@google.com> Cr-Commit-Position: refs/heads/master@{#812878}
-
Klaus Weidner authored
Adds support for a per-view viewport scale factor, dynamically configurable on a per-frame basis. The feature is controlled by the WebXRViewportScale Blink feature, and can be enabled via chrome://flags#webxr-incubations or the --enable-features=WebXRIncubations command line flag. See https://github.com/immersive-web/webxr/pull/1132/files for the related spec changes. This CL does not yet implement a recommended scale factor which is an optional feature in the spec. The attribute just returns base::nullopt for now. In addition to the Blink experimental feature flag, the device backends also need to opt in by setting XRSession.supports_viewport_scaling via mojo response. Currently, only the GVR device enables the feature. Bug: 1133381 Change-Id: I5ccf3fd613eb78475e1f4512025cc3eab6fd149d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438207 Commit-Queue: Klaus Weidner <klausw@chromium.org> Reviewed-by:
Piotr Bialecki <bialpio@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Brandon Jones <bajones@chromium.org> Cr-Commit-Position: refs/heads/master@{#812877}
-
Aya ElAttar authored
- Changed ClipboardDlpController to a singleton to decouple its ownership and lifetime from ui::Clipboard, which was previously unexpectedly destructed by DestroyClipboardForCurrentThread. - Removed Clipboard::GetDlpController and Clipboard::SetDlpController. - Changed DlpRulesManager to be responsible for controlling EnterpriseClipboardDlpController lifecycle. Bug: 1102332 Change-Id: I603f5d61c218290dbcc74a9292f89e78f08d7dce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424086 Commit-Queue: Aya Elsayed <ayaelattar@chromium.org> Commit-Queue: Sergey Poromov <poromov@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Nikita Podguzov <nikitapodguzov@chromium.org> Reviewed-by:
Darwin Huang <huangdarwin@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#812876}
-
Yao Xiao authored
Switched to do ReadVarint64 from CodedInputStream. Each blocklist check would involve a file scan on the background. Bug: 1062736 Change-Id: I6b0153e8a8e39025a4bf9485a837897767b3abde Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440305 Commit-Queue: Yao Xiao <yaoxia@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Cr-Commit-Position: refs/heads/master@{#812875}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/75b9ab6751f3..dba4db5668d6 2020-10-01 landrey@webrtc.org Revert "Reland "Reduce the amount of howling reduction in AEC3"" 2020-10-01 perkj@webrtc.org Refactor reporting of VideoBitrateAllocation 2020-10-01 peah@webrtc.org Reland "Reduce the amount of howling reduction in AEC3" 2020-10-01 landrey@webrtc.org Revert "Reland "Activating AVX2 support by default"" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I0780bbb6fadb565c077cda665017c63b7d6f1499 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443272Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#812874}
-
Rune Lillesveen authored
Check that a dark color-scheme meta results in a dark content background color for the web view. Bug: 1103667 Change-Id: If71c3211a4ae54af9826d925517a7ec79cdef76d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440595Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#812873}
-
Elaine Chien authored
Bug: 772945 Change-Id: I61ac71e470cc79734ca775c7294b46f6a87a92ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436576Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#812872}
-
Manas Verma authored
AutofillManager now accesses AutofillOfferManager via the AutofillOfferManagerFactory, which will be used for updating credit card suggestions to display offers. AutofillOfferManager will be a BrowserContextKeyedService, with one instance per profile. Bug: 1093057 Change-Id: Ia065577c702ad2784d54031b781eec0cdc74b89d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419238 Commit-Queue: Manas Verma <manasverma@google.com> Reviewed-by:
Jared Saul <jsaul@google.com> Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Tommy Martino <tmartino@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Siyu An <siyua@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#812871}
-
Scott Violet authored
The following sequence leaves the layer associated with RenderWidgetHostViewAndroid hidden: 1. window hides 2. view is removed from window. 3. view added back to window 4. window is shown. The bug occurs because StopObservingRootWindow() assumes the window is shown, so that in step 4 when OnRootWindowVisibilityChanged() is called the code early outs, leaving the layer hidden. BUG=1075744 TEST=RenderWidgetHostViewAndroidTest.HideWindowRemoveViewAddViewShowWindow Change-Id: I7ba61189b0be4882335721cf6fdc5ae2253c5827 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437718Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#812870}
-
Xiaohan Wang authored
This is now the same as `is_linux`. Replace it with `is_linux` everywhere to avoid confusion. We'll remove it after all third_party code are updated as well. Bug: 1132395 Change-Id: I6a4a765e5166f60567667460f4426b21f29f172b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432052 Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Reviewed-by:
Michael Spang <spang@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#812869}
-
Mehran Mahmoudi authored
As per UX review, this CL disables the progressbar when paint preview is shown. It also fakes a progress fill animation on upgrading to the live tab. Bug: 1131497 Change-Id: I8054f2aacaaea7d76423017b89057f811895e548 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441188 Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org> Reviewed-by:
Calder Kitagawa <ckitagawa@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#812868}
-
Xianzhu Wang authored
Some web sites create huge layers with tiny scale. Previously because the scale was clamped to minimum scale, causing too many tiles with too big scale and out of tile memory. This CL contains the following changes: 1. Remove LayerTreeSettings::minimum_contents_scale. It was added when we used layer coordinates in PicturePile and needed to expand record / invalidation rects by 1/scale pixels to ensure all affected texels were covereda. The minimum scale avoided problems caused by too many pixels to expand when the ideal scale was too small. Now we use texel coordinates in PictureLayerTiling and all rects in layer coordinates will be mapped into texel coordinates by scaling the rect then getting the enclosing int rect, which ensures coverage of affected texels, so the minimum scale is no longer useful. 2. Adjust scale clamping for will-change:transform. a) If the ideal scale is much smaller than the native scale, don't clamp to the native scale; b) Update raster contents scale only if it's too small compared to the ideal contents scale. Without this, we would update tiny raster contents scale when the ideal scale changes which would defeat the optimization for will-change:transform. Bug: 1132991 Change-Id: I3a31f654fe4a5ccc925aaad3a2b75748c4e37164 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438756Reviewed-by:
vmpstr <vmpstr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#812867}
-
Austin Sullivan authored
uses saturated_cast Bug: 116075 Change-Id: I228a00f77bd2df3b429b16a58c15eb47285c055b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435282Reviewed-by:
enne <enne@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Commit-Queue: enne <enne@chromium.org> Commit-Queue: Austin Sullivan <asully@chromium.org> Cr-Commit-Position: refs/heads/master@{#812866}
-
Mei Liang authored
TabUiFeatureUtilities.isTabGroupsAndroidEnabled() does not guarantee TabModelFilterProvider().getTabModelFilter() returns TabGroupModelFilter. It can return null before TabModelSelectorBase#initialize() is called. This CL early returns when TabModelFilterProvider().getTabModelFilter() is not a TabGroupModelFilter to avoid the casting exception. This CL is gated by Finch parameter "enable_launch_polish" under flag "enable-tab-grid-layout", with gate function TabUiFeatureUtilities#isLaunchPolishEnabled. Bug: 1133922 Change-Id: I9766d4f0f54c954f8205866aa0c514b508d7a5a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442479 Commit-Queue: Mei Liang <meiliang@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#812865}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e2764fee10f6..30ea8e724567 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC karandeepb@google.com,aaronhk@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1061119,chromium:1099917,chromium:1099982,chromium:1133575 Tbr: karandeepb@google.com,aaronhk@google.com Change-Id: I825aee916705c51b03fd4e8321c996f30218564d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443270 Commit-Queue: Michael Moss <mmoss@chromium.org> Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#812864}
-
George Burgess IV authored
As discussed on https://groups.google.com/a/chromium.org/g/cxx/c/iow8Ugo7190, adding these sounds like a good idea. Bug: None Change-Id: Ic7a721d8c94e5e5f0629bdc50b6d466c7b344ab6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438310 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#812863}
-
cfredric authored
This will be used to analyze how much entropy leaked by this API can be used for cross-site tracking. Bug: 973801 Change-Id: I3741e7bf887e0d7b07b203531afac230ca7dcf70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441324Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Reviewed-by:
Asanka Herath <asanka@chromium.org> Commit-Queue: Asanka Herath <asanka@chromium.org> Auto-Submit: Chris Fredrickson <cfredric@google.com> Cr-Commit-Position: refs/heads/master@{#812862}
-
Mark Schillaci authored
This CL updates some test expectations that include the new state description to fix failing content_browsertests Related change: https://crrev.com/c/2432089 AX-Relnotes: N/A Bug: 1133354, 1134201 Change-Id: I981eb7b465971e818df87efb04c21f1ccc3480d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443071Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Mark Schillaci <mschillaci@google.com> Commit-Queue: Mark Schillaci <mschillaci@google.com> Cr-Commit-Position: refs/heads/master@{#812861}
-
Olivier Yiptong authored
This changes the page info string to match the UI recommendation as necessary to ship in Origin Trial. Bug: 1043306 Change-Id: I77133f0a3e95c87d1a261043d596f669bbde62c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441955 Auto-Submit: Olivier Yiptong <oyiptong@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Commit-Queue: Olivier Yiptong <oyiptong@chromium.org> Cr-Commit-Position: refs/heads/master@{#812860}
-
Dirk Pranke authored
This reverts commit 11eba3d1. Reason for revert: re-landing with fix. Original change's description: > Revert "Change blink_web_tests and blink_python_tests test types." > > This reverts commit 71c10e67. > > Reason for revert: Breaking Dawn's CQ. This CL likely needs to > update webgpu_blink_web_tests as well. > > Original change's description: > > Change blink_web_tests and blink_python_tests test types. > > > > This CL changes the GN blink_web_tests and blink_python_tests > > targets to use a new script_test() GN template. > > > > A script_test is a kind of test target that implements the > > [test executable API](//docs/testing/test_executable_api.md) > > via a Python script (rather than being an executable target). > > > > :blink_web_tests, :blink_python_tests are examples of this type > > of test; other targets will be switched over in future CLs as well. > > > > Most importantly, using script_test() will ensure that > > the $root_build_dir/bin/run_$target_name test wrappers are > > generated with all of the appropriate arguments, simplifying the > > invocation of the test both for devs and for the bots. > > > > Bug: 816629 > > Change-Id: Ib4bfd2342d762db24cdef75b64ed5dd7fbf3c10e > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380936 > > Commit-Queue: Dirk Pranke <dpranke@google.com> > > Reviewed-by: Robert Ma <robertma@chromium.org> > > Reviewed-by: Rakib Hasan <rmhasan@google.com> > > Cr-Commit-Position: refs/heads/master@{#812523} > > TBR=dpranke@google.com,robertma@chromium.org,rmhasan@google.com > > Change-Id: I16c0d8bfaebbeabbeee7dd98a0f4bb083403444f > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 816629 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442872 > Reviewed-by: Austin Eng <enga@chromium.org> > Commit-Queue: Austin Eng <enga@chromium.org> > Cr-Commit-Position: refs/heads/master@{#812694} TBR=robertma@chromium.org,rmhasan@google.com # Not skipping CQ checks because this is a reland. Bug: 816629 Change-Id: I78f30594215fe5c9a4dcd60a6ba49ae101a69abe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441351 Commit-Queue: Dirk Pranke <dpranke@google.com> Reviewed-by:
Robert Ma <robertma@chromium.org> Reviewed-by:
Austin Eng <enga@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/master@{#812859}
-
Andy Paicu authored
HidConnectionImpl is self-owned and will self-destruct on disconnection of the HidConnection or HidConnectionWatcher. This CL modifies the FakeHidConnection used in tests so it behaves the same way. BUG=1126689 Change-Id: I8bbdcca7c77699749c6022f01b8a456c4891cdb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441151 Commit-Queue: Reilly Grant <reillyg@chromium.org> Auto-Submit: Matt Reynolds <mattreynolds@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#812858}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/68377adad5ae..98218e9219b1 2020-10-01 kimstephanie@google.com Revert "Add optional enforce_fetch kwarg to fetch and refresh git cache" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1129235 Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: I38cb06e701babe192893cab0021740c22cbcf775 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443232Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#812857}
-
Istiaque Ahmed authored
Bug: None Change-Id: Ib69f766773c55d231d52f3eb7100cc71c61e561e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442149 Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#812856}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: I1b2e02800e9ccc49e05c7ec1c2338070acd550e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443350Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#812855}
-
Tomasz Wiszkowski authored
With the introduction of post-destroy Tab access checkers we observed an increase of EditUrl crashes that we need to address. Context: http://shortn/_leZzHPdfGB Bug: 1117396 Change-Id: If2bd62392360a9e24db7c55d206ba3e5b9a7169a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422268 Commit-Queue: Tomasz Wiszkowski <ender@google.com> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#812854}
-
chromium-autoroll authored
Roll ChromeOS Broadwell AFDO profile from 87-4258.0-1601290734-benchmark-87.0.4277.0-r1 to 87-4258.0-1601290734-benchmark-87.0.4278.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-broadwell-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I74f4850c81203e5a30fdf13d907093ffa59500e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443353Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#812853}
-
David Dorwin authored
Addresses post-commit feedback in https://crrev.com/c/2430302. Bug: 1104369 Change-Id: Id4024d55445a10e9b5cf1770ffd71829ecb7833b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436381Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: David Dorwin <ddorwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#812852}
-
Lei Zhang authored
Do not take an accessibility snapshot if the RenderFrame is gone. Bug: 1133983 Change-Id: I612cc72936a1dcedc5180c24eae067e47237b09b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442375Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#812851}
-
Ahmed Fakhry authored
This reverts commit 6a5d7abc. Reason for revert: HashAffiliationFetcherTest.BuildQueryURL fails consistently on linux-chromeos-chrome BUG=1134278 Original change's description: > Add HashAffiliationFetcher skeleton to retrieve affiliations by hash prefix. > > This change creates HashAffiliationFetcher skeleton that extends AffiliationFetcherBase. > This fetcher will provide additional privacy layer as it will request affiliations for a larger group of facets by passing only the prefixes of hashed URLs. > > Bug: 1108279 > Change-Id: I4a2b09aa7d8c3c51f4b30ba966a17ba5afb9b09b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423883 > Commit-Queue: Nela Kaczmarek <nelakaczmarek@google.com> > Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org> > Cr-Commit-Position: refs/heads/master@{#812653} TBR=vasilii@chromium.org,jdoerrie@chromium.org,nelakaczmarek@google.com Change-Id: I8636d3cdd74f75de4ce4be9d2f76f18d3ada2f83 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1108279 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441379Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#812850}
-
Shakti Sahu authored
This CL adds an activity to show the list of video tutorials. UX : https://docs.google.com/presentation/d/1jszfqrCLufu0mskWls6unqilpmG3PoHKdySsf4uF-eo/edit#slide=id.g95aea48d7d_0_128 Bug: 1130256 Change-Id: Ie35538f0d1ee582a61c4b04a755e3af46680b87b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2420530Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#812849}
-
Tomasz Wiszkowski authored
The typo suggests that the omnibox would have only one suggestion to show. Skipping the screenshot check as the corresponding screenshot is already submitted. Skip-Translation-Screenshots-Check: True Bug: 1106109 Change-Id: Iccf8e9f595ed6b2dcebd83dad1dcf176e40923a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442771 Commit-Queue: Tomasz Wiszkowski <ender@google.com> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#812848}
-
Ionel Popescu authored
As discussed on the security review this CL adds the following mitigations: - require a transient user activation on the browser side, and consume it when showing the eye dropper for the renderer (this will prevent a compromised renderer to repeatedly ask for a color) - require the eye dropper UI to be visible for a minimum amount of time before color selection is allowed in order to ensure the user has a chance to see the UI. There is also a fix for the popup not correctly updating the user activation state. This happens because it is using a EmptyLocalFrameClient and its frame is not related to the owner element's frame. Bug: 992297 Change-Id: Ia5d2aead0be153ce4b49048552062de3a6c72e63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442132Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#812847}
-
David Dorwin authored
Also remove the copy of the LICENSE file and an obsolete SDK path in third_party/.gitignore. Change-Id: Id67cb2bfec128572f23f8dcdccc08b54a2601338 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427964Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: David Dorwin <ddorwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#812846}
-
David Black authored
The label is being given only enough height for a single line of text despite being a multiline line label with max of 2 lines. Bug: b:169806293 Change-Id: I8d9374270dff1a0aa43c6b397aea0462474efe2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441685Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#812845}
-
Ahmed Fakhry authored
This reverts commit d30e1594. Reason for revert: NewTabPageModulesShoppingTasksModuleTest.All fails consistently on linux-chromeos-chrome BUG=1134274 Original change's description: > WebUI Modules: shopping tasks, hide elements that do not fit > > Bug: 1132424 > Change-Id: I1b56fdec5c37d81a4939e986b3282af4585772ee > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440970 > Commit-Queue: Esmael Elmoslimany <aee@chromium.org> > Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org> > Auto-Submit: Esmael Elmoslimany <aee@chromium.org> > Cr-Commit-Position: refs/heads/master@{#812569} TBR=tiborg@chromium.org,aee@chromium.org Change-Id: Ia0be2a22e0ffa23c22a18adc78f26de5eb729e48 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1132424 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443277Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#812844}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 3211fba0. With Chromium commits locally applied on WPT: 8ee75745 "[layout] Track inflow-bounds within box fragment builder." 3ed38849 "[COOP] access reporting: expose "type" to ReportingObserver." a94d6a18 "[LayoutNG] Don't prevent column breaks before a spanner." 3211fba0 "Launch fontBoundingBoxAscent/Descent" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: hbos@chromium.org, hta@chromium.org, guidou@chromium.org, philipp.hancke@googlemail.com: external/wpt/webrtc NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Change-Id: Id78d620f526bddc12ffbb0115f30cc219d4392d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440240Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#812843}
-
Rayan Kanso authored
WebAPKs using the new minting mechanism, identified by their package name, should have a separate latency histogram to track if overall latency will be affected. Bug: 1134173 Change-Id: Ib75ec57828c1df1f038c2a1bf383a52cc602647f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443011Reviewed-by:
Glenn Hartmann <hartmanng@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Commit-Queue: Rayan Kanso <rayankans@chromium.org> Auto-Submit: Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#812842}
-