GitLab

to resolve some differences between chromium and internal versions.
Also various cleanups to end_to_end_test.cc

Merge internal change: 193703843

Change-Id: I3bc92c6057d37c97948229d499c2cc9c279923b4
Reviewed-on: https://chromium-review.googlesource.com/1022511
Commit-Queue: Ryan Hamilton <rch@chromium.org>
Reviewed-by: Zhongyi Shi <zhongyi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552909}

TBR=smut

Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I09558dfae0b9b01e308a7ed5258099906972d50f
Reviewed-on: https://chromium-review.googlesource.com/1024696
Commit-Queue: iOS Autoroller <ios-autoroller@chromium.org>
Reviewed-by: iOS Autoroller <ios-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552908}

Also replace NULL with nullptr throughout FocusManager and
FocusSearch.

Bug: 764918
Change-Id: Ic90607c470130ac53375b26e601c1226c34a501a
Reviewed-on: https://chromium-review.googlesource.com/1024990Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552907}

Bug: 822469
Change-Id: Id244e5120962a7ee5e7bdcb25e46221aad868d8a
Reviewed-on: https://chromium-review.googlesource.com/1024405Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Daniel Park <danielpark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552906}

This CL fixes a bug in sizing the entity images where they would be sized
too large if shown after an Answer result (such as weather). This
occurred because the old height for the answer result was being used in
the entity sizing.

Bug: None
Change-Id: Ia372c142a011657af150eb651403a61aeab2943d
Reviewed-on: https://chromium-review.googlesource.com/1024926Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Commit-Queue: Dave Schuyler <dschuyler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552905}

NG did not traverse children, which are needed for Focus rings.

Bug: 835484
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: I33a326b18da85b65f76b5035634d9b8151431313
Reviewed-on: https://chromium-review.googlesource.com/1022979
Commit-Queue: Aleks Totic <atotic@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552904}

This is a reland of b3fdac1b

Original change's description:
> skia: Add workaround header define
> 
> Chromium-side changes for:
> https://skia-review.googlesource.com/c/skia/+/120608
> 
> Bug: 829614
> Change-Id: I59dc05ae1d66622ce3c771311ec3e1b64023b66f
> Reviewed-on: https://chromium-review.googlesource.com/1008924
> Reviewed-by: Brian Salomon <bsalomon@chromium.org>
> Commit-Queue: enne <enne@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#551370}

Bug: 829614
Change-Id: I206bed834a1819aea819648ba1f3ca486af94657
Reviewed-on: https://chromium-review.googlesource.com/1024310Reviewed-by: Brian Salomon <bsalomon@chromium.org>
Commit-Queue: enne <enne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552903}

These changes were scripted as part of the effort to restrict exposure of the
raw MessageLoop*.

Note that many static methods exposed on MessageLoopCurrent are also deprecated
so it is very well possible that this is migrating to an already deprecated
method.

The goal of this pass is to reduce usage of MessageLoop::current() (and
ultimately make it impossible to obtain the MessageLoop* statically).

As such I will not edit this CL unless the script did something logically wrong.
I defer to owners to fix highlighted usage of already deprecated APIs.

Possible script screw ups / things to look out for in this review:
 - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against
   one (I will go over that in a separate pass).

Includes should have been stripped if that was the last usage of message_loop.h
in that file.

Please CQ if LGTY

This CL was uploaded by git cl split.

R=morlovich@chromium.org

Bug: 825327
Change-Id: Ifaba7bb17406a913293c2ba918334d28da4cbc3c
Reviewed-on: https://chromium-review.googlesource.com/1024790Reviewed-by: Maks Orlovich <morlovich@chromium.org>
Commit-Queue: Maks Orlovich <morlovich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552902}

Makes the mojo_core shared library a data dependency of the chrome
binary target on Chrome OS to ensure that it gets built whenever chrome
gets built. A follow-up change to chromite will cause this to be
included in device deployments.

Also adds a linker script to ensure that symbol exports are limited to
MojoGetSystemThunks.

Bug: 822034
Change-Id: Iad03f28377ecc5094c2019b22c723d7705242230
Reviewed-on: https://chromium-review.googlesource.com/1024750Reviewed-by: Jay Civelli <jcivelli@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552901}

In the unlikely event that a remote instance deletes our local session,
either via garbage collection or by the user manually requesting a
deletion from the UI, restore a consistent state once a local change
is observed.

This mimics the analogous logic in SessionsSyncManager.

Bug: 681921
Change-Id: Ie3171852abb9a9f1b350535317b73a3fcb907cb6
Reviewed-on: https://chromium-review.googlesource.com/1024036
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552900}

Keeping things consistent in Bijou Phase 1

https://drive.google.com/file/d/14nkloZ4PX0UD0HnXZgMLKYo6-iUzn5kt/view?usp=sharing


Bug: 833623
Change-Id: Ie5aeaac7c3787775d4845aa6cb030236b6de9c2f
Reviewed-on: https://chromium-review.googlesource.com/1022173
Commit-Queue: Chris Lu <thegreenfrog@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552899}

Bug: 782057
Change-Id: Ib7d35e227414f4f9980c5cf70bb3d767c9961029
Reviewed-on: https://chromium-review.googlesource.com/1013984Reviewed-by: Sean Kau <skau@chromium.org>
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Vladislav Kuzkokov <vkuzkokov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552898}

Replace with std::move(foo).

Change-Id: I7b2db906e9643fd70eb5188143f564cd4899baf5
Reviewed-on: https://chromium-review.googlesource.com/1014375
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Stephen Lanham <slan@chromium.org>
Reviewed-by: Nick Carter <nick@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552897}

Moving the backend & frontend code to their own folders. This CL contains no
functional changes.

Bug: 830931
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ia6147c93063214143c8de29ca945cc3df8892bfa
Reviewed-on: https://chromium-review.googlesource.com/1023114Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Filip Gorski <fgorski@chromium.org>
Commit-Queue: Brandon Wylie <wylieb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552896}

MessageLoopRunner is deprecated and should use RunLoop instead. This CL
should not introduce any behavior change.

Bug: None
Change-Id: I1df20af20e14b828596b755b5aaa308c082d86b8
Reviewed-on: https://chromium-review.googlesource.com/1012195Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552895}

linked_ptr is long deprecated, used unique_ptr instead.


Bug: 556939
Change-Id: Ibfd38af13cd5646265bdfa4570e6e30c05db1ab2
Reviewed-on: https://chromium-review.googlesource.com/1020521Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552894}

These changes were scripted as part of the effort to restrict exposure of the
raw MessageLoop*.

Note that many static methods exposed on MessageLoopCurrent are also deprecated
so it is very well possible that this is migrating to an already deprecated
method.

The goal of this pass is to reduce usage of MessageLoop::current() (and
ultimately make it impossible to obtain the MessageLoop* statically).

As such I will not edit this CL unless the script did something logically wrong.
I defer to owners to fix highlighted usage of already deprecated APIs.

Possible script screw ups / things to look out for in this review:
 - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against
   one (I will go over that in a separate pass).

Includes should have been stripped if that was the last usage of message_loop.h
in that file.

Please CQ if LGTY

This CL was uploaded by git cl split.

R=tguilbert@chromium.org

Bug: 825327
Change-Id: I2f85f18902de98bcb47125595e31379eb3c11169
Reviewed-on: https://chromium-review.googlesource.com/1024757
Commit-Queue: Gabriel Charette <gab@chromium.org>
Commit-Queue: Thomas Guilbert <tguilbert@chromium.org>
Reviewed-by: Thomas Guilbert <tguilbert@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552893}

Use ChromeViewsDelegate/WidgetObserver combination to ensure that all
widgets are tested for accessibility as they become hidden or visible
in a browsertest.

The test goes through the View entire subtree and ensure any focusable
View has an accessible name.

TBR=sky@chromium.org,tapted@chromium.org

CQ_INCLUDE_TRYBOTS: master.tryserver.chromium.linux:linux_chromium_msan_rel_ng,linux_chromium_asan_rel_ng,linux_chromium_chromeos_asan_rel_ng,linux_chromium_chromeos_msan_rel_ng

Bug: 819350
Change-Id: I001d4cd2eac566445ec65c0228100e5323610765
Reviewed-on: https://chromium-review.googlesource.com/981937Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552892}

Canceling a single request is currently linear in the number of
requests, making the overall behavior quadratic. Fix it to be linear, so
we scale well and avoid upsetting the fuzzer.

Bug: 834578
Change-Id: Ieb17b106b0a8308b7b5a882fa1f61f899ee4dbcd
Reviewed-on: https://chromium-review.googlesource.com/1020022Reviewed-by: Eric Roman <eroman@chromium.org>
Commit-Queue: David Benjamin <davidben@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552891}

These changes were scripted as part of the effort to restrict exposure of the
raw MessageLoop*.

Note that many static methods exposed on MessageLoopCurrent are also deprecated
so it is very well possible that this is migrating to an already deprecated
method.

The goal of this pass is to reduce usage of MessageLoop::current() (and
ultimately make it impossible to obtain the MessageLoop* statically).

As such I will not edit this CL unless the script did something logically wrong.
I defer to owners to fix highlighted usage of already deprecated APIs.

Possible script screw ups / things to look out for in this review:
 - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against
   one (I will go over that in a separate pass).

Includes should have been stripped if that was the last usage of message_loop.h
in that file.

Please CQ if LGTY

This CL was uploaded by git cl split.

R=boliu@chromium.org

Bug: 825327
Change-Id: If410a2423e1780c769a768ea4dd533b37cc39488
Reviewed-on: https://chromium-review.googlesource.com/1024655
Commit-Queue: Gabriel Charette <gab@chromium.org>
Commit-Queue: Bo <boliu@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552890}

These changes were scripted as part of the effort to restrict exposure of the
raw MessageLoop*.

Note that many static methods exposed on MessageLoopCurrent are also deprecated
so it is very well possible that this is migrating to an already deprecated
method.

The goal of this pass is to reduce usage of MessageLoop::current() (and
ultimately make it impossible to obtain the MessageLoop* statically).

As such I will not edit this CL unless the script did something logically wrong.
I defer to owners to fix highlighted usage of already deprecated APIs.

Possible script screw ups / things to look out for in this review:
 - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against
   one (I will go over that in a separate pass).

Includes should have been stripped if that was the last usage of message_loop.h
in that file.

Please CQ if LGTY

This CL was uploaded by git cl split.

R=raymes@chromium.org

Bug: 825327
Change-Id: I2f106d59abb16b11a5b866bf109666bfad595823
Reviewed-on: https://chromium-review.googlesource.com/1024392
Commit-Queue: Raymes Khoury <raymes@chromium.org>
Reviewed-by: Raymes Khoury <raymes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552889}

This CL re-enables the separator line between the toolbar and the content area.

Bug: 822061
Change-Id: Iee0ff91b2f1b39daef89d4c9c1a09ba0142d9a08
Reviewed-on: https://chromium-review.googlesource.com/1024230Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Commit-Queue: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552888}

Flakiness cause in the FileManagerBrowserTests was resolved on issues:
issue 831074 issue 804413 issue 829310.

In this change, re-enable gallery browser tests disabled on 804413.

Mash browser tests passed (patch set #1), so these tests are supported
by mash on the ChromeOS bots. Thus, I did not them to the mash browser
test exclusion file (see crrev.com/552603 for a counter example).

Bug: 835794
Change-Id: I7c61b5c694346975d0dd72591bfbe5f564845aa3
Reviewed-on: https://chromium-review.googlesource.com/1023681
Commit-Queue: Noel Gordon <noel@chromium.org>
Reviewed-by: Stuart Langley <slangley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552887}

This CL removes special handling for Android pre-L devices that have
exactly one account and user has accepted TOS in Android Setup Wizard.

This behavior is removed as it doesn't make sense for streamlined
sign-in screens. This should only affect a small percentage of users
that go through FRE on devices with Android J & K.

Bug: 833850
Change-Id: I0f680027dbb7d01654ddc6a63e8ae9eded3a7b66
Reviewed-on: https://chromium-review.googlesource.com/1013985Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Boris Sazonov <bsazonov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552886}

Use public. Document the browser test classes. Order the base virtuals
to match our other browser tests.

No change in behavior, no new tests.

Bug: 833834
Change-Id: I3695fabab379d86cc6cdc38bde3c6312832c567a
Reviewed-on: https://chromium-review.googlesource.com/1023678Reviewed-by: Stuart Langley <slangley@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552885}

The test randomly times out.

BUG=833854
TBR=yoichio@chromium.org
NOTRY=true

Change-Id: Iffd451c87381c6d6520fd8ba8ba51beeadd2e30c
Reviewed-on: https://chromium-review.googlesource.com/1025138Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552884}

See https://skia-review.googlesource.com/c/skia/+/123181

Change-Id: I5cfc3f2f3031d1d30f85cc96bf73c1d243a15606
Reviewed-on: https://chromium-review.googlesource.com/1024692Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Mike Klein <mtklein@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552883}

Small change to make the code cleaner.

Change-Id: I6203bc934b0d4c2762670a48445a5d2b67964611
Reviewed-on: https://chromium-review.googlesource.com/1023519Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552882}

This should be enough for printing traces, and will save some precious disk
space on the bots.

R=justincohen@chromium.org

Bug: 834527
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I0ff1210c48aeba8abb4639eba6a334559085fda7
Reviewed-on: https://chromium-review.googlesource.com/1018497Reviewed-by: smut <smut@google.com>
Commit-Queue: Sergey Berezin <sergeyberezin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552881}

https://chromium.googlesource.com/catapult.git/+log/219bbf110903..6fd1dbd39dac

$ git log 219bbf110..6fd1dbd39 --date=short --no-merges --format='%ad %ae %s'
2018-04-19 simonhatch Dashboard - Remove MR code.
2018-04-19 simonhatch Dashboard - Remove unused layered_cache.Prewarm()

Created with:
  roll-dep src/third_party/catapult


The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=sullivan@chromium.org

Change-Id: I104bec71aa6b32cd4e8fc3b08709a8e38b096128
Reviewed-on: https://chromium-review.googlesource.com/1024797
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#552880}

After V8 roll this test will behave properly.

TBR: luoe@chromium.org
Bug: chromium:810176
Change-Id: Ieb64794bde43bca4c345220c70b83f02996c00c2
Reviewed-on: https://chromium-review.googlesource.com/1025033Reviewed-by: Erik Luo <luoe@chromium.org>
Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552879}

This is a preliminary change to remove the posix source exclusion
filter in a future commit.

Bug: 835405
Change-Id: I80edca54856078335d6e09303738a63bed451d18
Reviewed-on: https://chromium-review.googlesource.com/1022129
Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552878}

Bug: 781703
Change-Id: I716d1e0fcf7e6023e6b516e195171ee8c0a0feee
Reviewed-on: https://chromium-review.googlesource.com/1022318
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552877}

These changes were scripted as part of the effort to restrict exposure of the
raw MessageLoop*.

Note that many static methods exposed on MessageLoopCurrent are also deprecated
so it is very well possible that this is migrating to an already deprecated
method.

The goal of this pass is to reduce usage of MessageLoop::current() (and
ultimately make it impossible to obtain the MessageLoop* statically).

As such I will not edit this CL unless the script did something logically wrong.
I defer to owners to fix highlighted usage of already deprecated APIs.

Possible script screw ups / things to look out for in this review:
 - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against
   one (I will go over that in a separate pass).

Includes should have been stripped if that was the last usage of message_loop.h
in that file.

Please CQ if LGTY

This CL was uploaded by git cl split.

R=dgozman@chromium.org

Bug: 825327
Change-Id: Ib4b771dcae94fc61abc5a49deffb45bb068f7c7c
Reviewed-on: https://chromium-review.googlesource.com/1024807
Commit-Queue: Gabriel Charette <gab@chromium.org>
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552876}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/c78c94ca..6267b449

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org

Change-Id: I58629a33a390a31ce2ee2170ecfa77eeca26def7
Reviewed-on: https://chromium-review.googlesource.com/1024379Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552875}

https://chromium.googlesource.com/angle/angle.git/+log/af2b33be5a3a..b3474d9d77de

$ git log af2b33be5..b3474d9d7 --date=short --no-merges --format='%ad %ae %s'
2018-04-20 oetuaho Clean up ClipRectangle
2018-04-23 oetuaho Restrict BlitFramebuffer dimensions in WebGL mode

Created with:
  roll-dep src/third_party/angle
BUG=chromium:830046,chromium:830046


The AutoRoll server is located here: https://angle-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=geofflang@chromium.org

Change-Id: Ia3181cdc2541c174f2c8b7f5fd3001448ec2b470
Reviewed-on: https://chromium-review.googlesource.com/1024535Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#552874}

Current use of background page and event page is confusing.
This document updates the terminology to Background Scripts
with an option to use it as a page in the manifest.
All background scripts should be persistent false,
with little to no exceptions.
This update had a huge focus on how to create effective
non-persistent background scripts.

Change-Id: I985caa739104d3608157c5e39119f9e27d57442e
Reviewed-on: https://chromium-review.googlesource.com/677735
Commit-Queue: Crystal Lambert <crystallambert@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552873}

Further replacement of a content:: enum with a blink::mojom enum for the
Presentation API.  No behavioral changes.

Bug: 817903
Change-Id: I66fc39db2e8f1e2220aa293e81a77b61d1f69c03
Reviewed-on: https://chromium-review.googlesource.com/1015289
Commit-Queue: mark a. foltz <mfoltz@chromium.org>
Reviewed-by: Will Harris <wfh@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Derek Cheng <imcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552872}

This was only used in unit tests. Add a simpler bool accessor to
ColorSpace that indicates if the parametric approximation is accurate,
and use that to continue testing specific profiles. This makes the test
logic more accurately reflect the actual logic used at runtime around
caching of profiles.

Change-Id: I5b73f13e7912ad9c7903b83af823e8bf9ac9da29
Reviewed-on: https://chromium-review.googlesource.com/1022633Reviewed-by: Mike Klein <mtklein@chromium.org>
Reviewed-by: ccameron <ccameron@chromium.org>
Commit-Queue: Brian Osman <brianosman@google.com>
Cr-Commit-Position: refs/heads/master@{#552871}

These changes were scripted as part of the effort to restrict exposure of the
raw MessageLoop*.

Note that many static methods exposed on MessageLoopCurrent are also deprecated
so it is very well possible that this is migrating to an already deprecated
method.

The goal of this pass is to reduce usage of MessageLoop::current() (and
ultimately make it impossible to obtain the MessageLoop* statically).

As such I will not edit this CL unless the script did something logically wrong.
I defer to owners to fix highlighted usage of already deprecated APIs.

Possible script screw ups / things to look out for in this review:
 - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against
   one (I will go over that in a separate pass).

Includes should have been stripped if that was the last usage of message_loop.h
in that file.

Please CQ if LGTY

This CL was uploaded by git cl split.

R=sky@chromium.org

Bug: 825327
Change-Id: If9302ab0bd2df5e0bb6926ff2c0a784e45442bb0
Reviewed-on: https://chromium-review.googlesource.com/1024809
Commit-Queue: Gabriel Charette <gab@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552870}