Skip to content

GitLab

T
tangled
Switch branch/tag
  1. 18 Dec, 2017 10 commits
    • Daniel Cheng's avatar
      Remove unnecessary use of media::ScopedCallbackRunner in shape_detection · cf396c95
      Daniel Cheng authored 
      Just calling the callback on early return is good enough.

Cq-Include-Trybots: master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win10_chromium_x64_rel_ng
Change-Id: Ie0a4ca353f294237d54c4fe101559aa82d711ba0
Reviewed-on: https://chromium-review.googlesource.com/752481
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: default avatarReilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524642}
      cf396c95
    • Hiroki Nakagawa's avatar
      Worker: Move implementation of the "fetch a module worker script graph" algorithm · c219b34a
      Hiroki Nakagawa authored 
      This CL moves implementation of the "fetch a module worker script graph"
algorithm from WorkletGlobalScope to WorkerOrWorkletGlobalScope so that it can
be reused for module workers.

There is no behavioral change.

Bug: 680046
Change-Id: I7eba8ec1e1dc65396ec2aea8486b22fd1d829fa2
Reviewed-on: https://chromium-review.googlesource.com/826206Reviewed-by: default avatarKouhei Ueno <kouhei@chromium.org>
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524641}
      c219b34a
    • Wez's avatar
      Disable some flaky FlingController and RenderWidgetHostViewAura tests. · 635de947
      Wez authored 
      Bug: 795617
TBR: dtapuska@chromium.org
Change-Id: I9bb71a8556ee6fab4734a29e9525f1cb680d0738
Reviewed-on: https://chromium-review.googlesource.com/831402
Commit-Queue: Wez <wez@chromium.org>
Reviewed-by: default avatarWez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524640}
      635de947
    • Wez's avatar
      Switch LaunchWithHandleTransfer test to use action_timeout(). · 2490b28c
      Wez authored 
      This test times-out on Fuchsia bots, seemingly due to an extremely long
delay in getting around to scheduling the sub-process to execute, some
of the time. Other similar ProcessUtilTests succeed because they wait
indefinitely for the sub-process to do its work; raising the timeout
to action_timeout() provides enough head-room that this test passes.

This also has the advantage that the test's timeouts are now
configurable.

Bug: 793412
Change-Id: I8b43e3cadfe302cf8afd9e835ee4ed1fbcda3c9e
Reviewed-on: https://chromium-review.googlesource.com/828383Reviewed-by: default avatarScott Graham <scottmg@chromium.org>
Reviewed-by: default avatarDaniel Cheng <dcheng@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524639}
      2490b28c
    • Renee Wright's avatar
      [Ribbon] Start moving getPropertyName and similar to CSSProperty · 85b6741b
      Renee Wright authored 
      The old versions of these methods are in CSSPropertyNames.h/.cpp

Moved methods are
- getPropertyName             -> CSSProperty::GetPropertyName
- getPropertyNameAtomicString -> CSSProperty::GetPropertyNameAtomicString
- getPropertyNameString       -> CSSProperty::GetPropertyNameString
- getJSPropertyName           -> CSSProperty::GetJSPropertyName


Adds GetPropertyName & GetPropertyNameAtomicString methods to CSSProperty.
For properties that are in group CSSProperty classes, these methods call through
to the legacy CSSPropertyNames versions (passing the result of PropertyID).
For the properties that have unique CSSProperty classes, these methods are
overridden, with the returned string hard-coded in the override.

Moves getPropertyNameString and getJSPropertyName to CSSProperty.

Updates all the callers of these 4 methods to use the CSSProperty versions.

Removes the CSSProperty subclass "Inherited" and adds unique subclasses for
its members.

GetPropertyName also needs to support aliases, so I have added generated
CSSProperty classes for aliases. These derive from a new base class called
CSSUnresolvedProperty, which CSSProperty also derives from. I'm not sure if
casting from CSSUnresolvedProperty to CSSProperty upon CSSProperty::Get
incurs a runtime cost. This support is added in patch set 9 & up.

gist for gen diff here:
https://gist.github.com/rjwright/78980ce0a9c5c589bab98fcec1e74a13/revisions

Part 2 of this effort is here:
https://chromium-review.googlesource.com/c/chromium/src/+/804645

Bug: 788554
Change-Id: I245e7a807e696addc44cebc55c92b3b463861bdb
Reviewed-on: https://chromium-review.googlesource.com/793650Reviewed-by: default avatarKentaro Hara <haraken@chromium.org>
Reviewed-by: default avatardstockwell <dstockwell@chromium.org>
Reviewed-by: default avatarmeade_UTC10 <meade@chromium.org>
Commit-Queue: Renée Wright <rjwright@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524638}
      85b6741b
    • Blake O'Hare's avatar
      Update WorkspaceLayoutManager to only listen to locked keyboard changes · 9f5a8f4f
      Blake O'Hare authored 
      OnKeyboardWorkspaceDisplacingBoundsChanging gets fired only if the
bounds change in a way that affect workspace layout (i.e. when the
locked full width keyboard does something). This simplifies the logic
here so that the check to end early if the keyboard is not locked can
be removed entirely.

Bug: 786290
Change-Id: I9710049271bcbf0e5f662f0d4959cbc817ca569a
Reviewed-on: https://chromium-review.googlesource.com/828480Reviewed-by: default avatarMitsuru Oshima <oshima@chromium.org>
Commit-Queue: Blake O'Hare <blakeo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524637}
      9f5a8f4f
    • Weidong Guo's avatar
      Reland "Display mirroring persistency changes" · 78d6fb65
      Weidong Guo authored 
      This is a reland of fa8dfaa6
Original change's description:
> Display mirroring persistency changes
>
> Changes:
> 1. Change mirroring persistency rule to:
> If previous mirror mode is not set (e.g. no external display in previous
> configuration), turn on mirror mode if at least one of the external
> displays was in mirror mode before and turn off mirror mode otherwise.
> If previous mirror mode is set, mirror mode remains its previous value
> as long as there are more than 1 displays.
> For example:
> Case 1: Connect display A; Turn on mirror mode; Connect display B. B
> should be in mirror mode as well.
> Case 2: Connect display A; Turn on mirror mode; Remove A; Reconnect A; A
> should be in mirror mode.
> Case 3: Connect display A; Turn on mirror mode; Remove A; Connect
> display B. B should not be in mirror mode.
> Case 4: Connect display A; Turn on mirror mode; Connect display B;
> Remove B; Remove A; Reconnect B; B should be in mirror mode.
>
> 2. Fix a bug in MirrorWindowController: mirroring source display may be
> changed in mirror mode (e.g. Connect two external displays; Turn on
> mirror mode; Close internal display lid; Then the internal display will
> be replaced with one external display as the mirroring source.),
> reflector and mirror windows should be updated in this case.
>
> 3. Fix broken test.
>
> Bug: 785416,792207
> Test: MultiMirroringTest.*
> Change-Id: Ia1da9f25df2bcc04f98ab087478a14685fff7708
> Reviewed-on: https://chromium-review.googlesource.com/804647
> Commit-Queue: Weidong Guo <weidongg@chromium.org>
> Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
> Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#524627}

TBR=afakhry@chromium.org, oshima@chromium.org

Bug: 785416, 792207
Change-Id: I6f0c7b4169f5a0e0ab8a8f97a073cd165d21622d
Reviewed-on: https://chromium-review.googlesource.com/831666Reviewed-by: default avatarWeidong Guo <weidongg@chromium.org>
Commit-Queue: Weidong Guo <weidongg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524636}
      78d6fb65
    • Robert Liao's avatar
      Pass/store Task by value in TaskScheduler. · d07daf95
      Robert Liao authored 
      MessageLoop and the Blink scheduler pass/store tasks by value. This
avoids having a heap allocation for every task.

With this CL, TaskScheduler also passes/stores tasks by value. This
is a prerequisite to make the TaskScheduler and the Blink scheduler
work together.

ScopedTaskEnvironment refactor and previous review at https://chromium-review.googlesource.com/c/chromium/src/+/764531

Bug: 783309, 795024
TBR: gab@chromium.org
Change-Id: I2ae01bed216f7d4e9c6a2615689df1817a2507d0
Reviewed-on: https://chromium-review.googlesource.com/826569
Commit-Queue: Robert Liao <robliao@chromium.org>
Reviewed-by: default avatarFrançois Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524635}
      d07daf95
    • Hwanseung Lee's avatar
      [css-typed-om] replace undefined variable with defined variable · 72e39c13
      Hwanseung Lee authored 
      there is using undefined variable in iterable.html.
it is cause to fail layout test.

Bug: 774887
Change-Id: Ibe516bcd8a24cc21ed604a1a9cf85e392a1c40c5
Reviewed-on: https://chromium-review.googlesource.com/828562Reviewed-by: default avatarDarren Shen <shend@chromium.org>
Commit-Queue: Hwanseung Lee <hs1217.lee@samsung.com>
Cr-Commit-Position: refs/heads/master@{#524634}
      72e39c13
    • Eric Willigers's avatar
      Revert "Separate out the four classes contained in CSSPropertyValueSet.h into four different files" · cedfd986
      Eric Willigers authored 
      This reverts commit 951544c9.

Reason for revert: Suspected performance regression.

Original change's description:
> Separate out the four classes contained in CSSPropertyValueSet.h into four different files
>
> Bug: 752745
> Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
> Change-Id: I43c650c37c33cb92d500e5e82d437f24faf6287a
> Reviewed-on: https://chromium-review.googlesource.com/795515
> Reviewed-by: Kentaro Hara <haraken@chromium.org>
> Reviewed-by: Eric Willigers <ericwilligers@chromium.org>
> Reviewed-by: Bugs Nash <bugsnash@chromium.org>
> Commit-Queue: meade_UTC10 <meade@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#522385}

TBR=ericwilligers@chromium.org,haraken@chromium.org,senorblanco@chromium.org,meade@chromium.org,bugsnash@chromium.org
BUG=794983,752745

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I2a5cd1bde00080ad50c963f09627dcbeab5c6ba8
Reviewed-on: https://chromium-review.googlesource.com/831372
Commit-Queue: Eric Willigers <ericwilligers@chromium.org>
Reviewed-by: default avatarEric Willigers <ericwilligers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524633}
      cedfd986
  3. 17 Dec, 2017 17 commits
  5. 16 Dec, 2017 13 commits