GitLab

BUG=24182
TBR= jianli@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/562123003

git-svn-id: svn://svn.chromium.org/blink/trunk@181813 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Like we do for all integer types, use helper functions from V8Binding.h
to convert from v8::Value to native types. These helper functions throw
all exceptions via their ExceptionState& argument, which means we don't
need to initialize a v8::TryCatch in the caller.

The helpers initialize a v8::TryCatch if they call in to V8 to convert
a value, but they do not do this if the value is already of the correct
type.

Review URL: https://codereview.chromium.org/567503002

git-svn-id: svn://svn.chromium.org/blink/trunk@181812 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch finishes the process of allowing policy parsing outside of
an ExecutionContext, and adjusts Document::initContentSecurityPolicy
to accept a ContentSecurityPolicy object rather than a set of headers.
If such an object is provided, the document will take ownership of it
and use it going forward. If no such object is provided, an empty
policy will be created and stored.

A future patch will move parsing out of FrameLoader::didBeginDocument
into DocumentLoader::responseReceived so that we can begin doing some
checks before a document is created.

BUG=411889

Review URL: https://codereview.chromium.org/559503002

git-svn-id: svn://svn.chromium.org/blink/trunk@181811 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Only DatabaseManager::closeDatabasesImmediately could be called in non-main
threads. However, it just calls
DatabaseTracker::closeDatabasesImmediately(). This CL removes
DatabaseManager::closeDatabasesImmediately, and only the main thread uses
DatabaseManager.

So, we can remove DatabaseManager::m_contextMapLock.  We still need m_contextMap
because the main thread can have multiple Documents.

Oilpan: We can use PersistentHeapHashMap, and remove some |#if ENABLE(OILPAN)|.

BUG=347902,397429
TEST=No new tests because of no behavior changes.

Review URL: https://codereview.chromium.org/567453002

git-svn-id: svn://svn.chromium.org/blink/trunk@181810 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL merges
 - AbstractSQLStatement into SQLStatement
 - AbstractSQLStatementBackend into SQLStatementBackend
 - AbstractSQLTransaction into SQLTransaction
 - AbstractSQLTransactionBackend into SQLTransactionBackend
 - DatabaseBase into Database.

'Sync' versions of their subclasses were removed. These abstract classes are
unnecessary.

BUG=397429
TEST=none; No behavior changes.

Review URL: https://codereview.chromium.org/561143002

git-svn-id: svn://svn.chromium.org/blink/trunk@181809 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch adjusts DrawingBuffer's behavior when a context is lost in
two ways:

1. Always tell DrawingBuffer whether it is visible or not regardless of
   whether the WebGL context is lost. This is needed because visibility
   notifications may arrive from the browser while the context is lost
   and the compositor may also attempt to composite the DrawingBuffer
   during this time.

2. Don't check the current visibility in
   DrawingBuffer::prepareMailbox() if the DrawingBuffer is being
   destroyed. This is because the DrawingBuffer may become hidden right
   before the context is forcibly lost (using WEBGL_lose_context), and
   after that point WebGLRenderingContextBase no longer has a reference
   to the DrawingBuffer to update its visibility state.

BUG=411372
TEST=Added in https://codereview.chromium.org/560023002

Review URL: https://codereview.chromium.org/556303002

git-svn-id: svn://svn.chromium.org/blink/trunk@181808 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Removed unused threading/os code from tool/main.py and
tool/mocktool.py.

BUG=None

Review URL: https://codereview.chromium.org/563533002

git-svn-id: svn://svn.chromium.org/blink/trunk@181807 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This enables and tweaks ready.html to follow up the implementation changes.

1) Blink: https://codereview.chromium.org/476043002/
2) Chromium: https://codereview.chromium.org/477593007/
3) Blink: THIS PATCH


BUG=399533
TEST=run_webkit_tests.py --debug http/tests/serviceworker/

Review URL: https://codereview.chromium.org/532653002

git-svn-id: svn://svn.chromium.org/blink/trunk@181806 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Schedule an invalidation set for :empty on an element when the pseudo state
changes instead of a SubtreeStyleChange.

R=chrishtr@chromium.org,esprehn@chromium.org
BUG=412999

Review URL: https://codereview.chromium.org/565493002

git-svn-id: svn://svn.chromium.org/blink/trunk@181805 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We're currently performing mixed content checks based on Resource::Type,
which isn't granular enough to support the behavior specified in the
mixed content specification (hence the introduction of the
MixedContentBlockingTreatment enum).

This patch introduces a new static mixed content checking method based
on WebURLRequest::RequestContext, which will allow us to remove most
of the complexity of MixedContentChecking in future patches.

BUG=411184

Review URL: https://codereview.chromium.org/537983002

git-svn-id: svn://svn.chromium.org/blink/trunk@181804 bbb929c8-8fbe-4397-9dbb-9b2b20218538

ExecutionContextClient was introduced in https://codereview.chromium.org/27311002. Now it isn't used.

R=vsevik@chromium.org

Review URL: https://codereview.chromium.org/559553002

git-svn-id: svn://svn.chromium.org/blink/trunk@181803 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Since Blink 175446
https://src.chromium.org/viewvc/blink?revision=175446&view=revision
we're loading data into a file. The downloadToFile flag is determined in
createRequest() i.e. inside xhr.send() call. But responseType is allowed
to be changed even after xhr.send() call.

Accumulate data into m_binaryResponseBuilder and create a Blob from it
anyway if m_downloadingToFile is not set.

BUG=412704

Review URL: https://codereview.chromium.org/562563003

git-svn-id: svn://svn.chromium.org/blink/trunk@181802 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Left-over from the removal of diffNeedsRecompositeLayer [1].

[1] https://codereview.chromium.org/360103008

R=abarth@chromium.org

Review URL: https://codereview.chromium.org/565583002

git-svn-id: svn://svn.chromium.org/blink/trunk@181801 bbb929c8-8fbe-4397-9dbb-9b2b20218538

After r164062 percentages of indefinite sizes were correctly
computed to "auto". The problem is that we were not doing it when
the percentage was inside the minmax() function. In those cases
it should compute to min-content for the min track sizing
function or to max-content for the max track sizing function.

Added a couple of tests, one to verify that we do not assert with
percentages inside minmax() and another one to verify that we
properly compute the percentage of indefinite size in various
situations.

BUG=401477,409085

Review URL: https://codereview.chromium.org/450093004

git-svn-id: svn://svn.chromium.org/blink/trunk@181800 bbb929c8-8fbe-4397-9dbb-9b2b20218538

ElementRareData::resetStyleState() cleared the StyleAffectedByEmpty flag
before recalculating style for an Element. However, this flag can be set by
style recalc for any of the sibling subtree elements in the presence of
adjacent combinators. If you have a LocalStyleChange for the element that
may become empty/non-empty, the flag can not be cleared since it may never
be set again unless the siblings affected by the :empty state are
recalculated.

R=esprehn@chromium.org
BUG=412950

Review URL: https://codereview.chromium.org/558333002

git-svn-id: svn://svn.chromium.org/blink/trunk@181799 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Revert of Revert of Mixed Content: Move subframe checks into ResourceFetcher. (patchset #1 id:1 of https://codereview.chromium.org/550083003/)

Reason for revert:
This wasn't the root cause of the non-V8 context call.

Original issue's description:
> Revert of Mixed Content: Move subframe checks into ResourceFetcher. (patchset #2 id:40001 of https://codereview.chromium.org/544573002/)
> 
> Reason for revert:
> calls V8 from a non-V8 context
> 
> Original issue's description:
> > Mixed Content: Move subframe checks into ResourceFetcher.
> > 
> > Currently we're checking for mixed content when loading the main
> > resource of subframes in two places: DocumentLoader and ResourceFetcher.
> > The former properly checks against the frame's parent frame, while the
> > latter bypasses the checks entirely by virtue of the request's
> > 'Resource::Type' being 'Main'.
> > 
> > This is both confusing and difficult to replicate when moving to the
> > brave new world of request contexts and frame types that Fetch now
> > defines.
> > 
> > This patch drops the DocumentLoader check, and moves the relevant
> > logic into ResourceFetcher::canRequest and
> > ResourceFetcher::checkInsecureContent.
> > 
> > BUG=400087
> > 
> > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181383
> 
> TBR=mkwst@chromium.org
> NOTREECHECKS=true
> NOTRY=true
> BUG=400087
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181543

TBR=jochen@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=400087

Review URL: https://codereview.chromium.org/559333002

git-svn-id: svn://svn.chromium.org/blink/trunk@181798 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This just moves code from sdk/TracingModel.js to timeline/TracingModel.js
and renames the former to sdk/TracingManager.js. No actual code was harmed.

BUG=412709

Review URL: https://codereview.chromium.org/563463003

git-svn-id: svn://svn.chromium.org/blink/trunk@181797 bbb929c8-8fbe-4397-9dbb-9b2b20218538

By assuming that the |value| expression throws exceptions via the
ExceptionState object, and only via it, we can skip the v8::TryCatch
declaration and check. This is good since it is less code, and since
v8::TryCatch objects cost a bit of CPU time to initialize.

The correctness of this patch depends on
  https://codereview.chromium.org/559553003/
and
  https://codereview.chromium.org/556273003/
that make sure all type conversion helpers with an ExceptionState&
argument actually throw all exceptions via it.

Review URL: https://codereview.chromium.org/552143004

git-svn-id: svn://svn.chromium.org/blink/trunk@181796 bbb929c8-8fbe-4397-9dbb-9b2b20218538

As discussed on blink-core-owners-discuss, Kouhei should be an owner!

TBR=kouhei

Review URL: https://codereview.chromium.org/553773003

git-svn-id: svn://svn.chromium.org/blink/trunk@181795 bbb929c8-8fbe-4397-9dbb-9b2b20218538

plugins/touch-events-details.html
plugins/transformed-events.html

They were regressed by jdduke@ at #294250 (dd03ea64)

BUG=413098
TBR= jianli@chromium.org, jdduke@chromium.org,
NOTRY=true

Review URL: https://codereview.chromium.org/564673002

git-svn-id: svn://svn.chromium.org/blink/trunk@181794 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://fetch.spec.whatwg.org/

https://github.com/whatwg/fetch/commit/a898f9a2941350aa625aa79b24673628ac2b2a8e
Request.body and Response.body is removed from the spec.
Body interface is introduced.

interface Body {
  readonly attribute boolean bodyUsed;
  Promise<ArrayBuffer> arrayBuffer();
  Promise<Blob> blob();
  Promise<FormData> formData();
  Promise<JSON> json();
  Promise<ScalarValueString> text();
};
Request implements Body;
Response implements Body;

BUG=411743,410197,410196
TEST=http/tests/serviceworker/ http/tests/local/serviceworker/

Review URL: https://codereview.chromium.org/555443002

git-svn-id: svn://svn.chromium.org/blink/trunk@181793 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=123896

Review URL: https://codereview.chromium.org/561673002

git-svn-id: svn://svn.chromium.org/blink/trunk@181792 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL adds internalAbort() call to handleDidCancel(). This is
not harmful. It's rather good that we clear resources.

R=yhirano,sof,kouhei
BUG=406229

Review URL: https://codereview.chromium.org/490083002

git-svn-id: svn://svn.chromium.org/blink/trunk@181791 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Intent to remove:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/SYlD0YVUnQk

Remove all *Sync interfaces and implementations, and WorkerGlobalScope::
openDatabase.
CLs to simplify code follow.

BUG=397429,323858,310866,357427

Review URL: https://codereview.chromium.org/561093003

git-svn-id: svn://svn.chromium.org/blink/trunk@181790 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The only functional difference is that we no longer repeat the
step name on every line. Otherwise, it's all CSS tweaks.

NOTRY=true
R=michaelpg@chromium.org

Review URL: https://codereview.chromium.org/553343002

git-svn-id: svn://svn.chromium.org/blink/trunk@181789 bbb929c8-8fbe-4397-9dbb-9b2b20218538

RenderFlexibleBox has several methods that take pointers to RenderBox instances but
those methods assumes that the objects will never be NULL. We should replace them by
references. This makes the caller code safer.

Review URL: https://codereview.chromium.org/555213002

git-svn-id: svn://svn.chromium.org/blink/trunk@181787 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This has been an alias for innerNode with a "remove this" FIXME for some
time.  The cleanup is pretty easy.

BUG=

Review URL: https://codereview.chromium.org/476303002

git-svn-id: svn://svn.chromium.org/blink/trunk@181786 bbb929c8-8fbe-4397-9dbb-9b2b20218538

HTMLTextAreaElement::value() is a costly operation, and we can avoid it
if a <textarea> has neither 'required' attribute nor 'maxlength' attribute.

This CL improves PerformanceTests/DOM/textarea-dom.html and
textarea-edit.html by a few percent.

BUG=

Review URL: https://codereview.chromium.org/543403003

git-svn-id: svn://svn.chromium.org/blink/trunk@181785 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is the first step towards implementing getRegistration method of
ServiceWorkerContainer. This patch adds definition of the method and
its callback type to WebServiceWorkerProvider.

[2/3] https://codereview.chromium.org/535753002/
[3/3] https://codereview.chromium.org/540823003/

BUG=404951
TEST=compile (tests will be added by subsequent patches)

Review URL: https://codereview.chromium.org/553983010

git-svn-id: svn://svn.chromium.org/blink/trunk@181784 bbb929c8-8fbe-4397-9dbb-9b2b20218538

ServiceWorkerRegistration::unregister returns false when the registration is already unregistered. (3/3)

1. [Blink] https://codereview.chromium.org/549093002/
2. [Chromium] https://codereview.chromium.org/554573002/
3. [Blink] this patch

BUG=390894
TEST=run_webkit_tests.py http/tests/serviceworker/unregister.html

Review URL: https://codereview.chromium.org/550093002

git-svn-id: svn://svn.chromium.org/blink/trunk@181783 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This looks like a no-op, but forthcoming changes to
IDBPendingTransactionMonitor require this and it makes those patches
much easier to understand.

BUG=390704,411532

Review URL: https://codereview.chromium.org/555633002

git-svn-id: svn://svn.chromium.org/blink/trunk@181782 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We used <button> for cells, and we had unexpected focus behaviors. This CL
changes <button> to <div>.
This is a preparation to support accessibility in the month popup.

BUG=123896

Review URL: https://codereview.chromium.org/556323003

git-svn-id: svn://svn.chromium.org/blink/trunk@181781 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Bug 401177 added more explicit tracking of the source of synthetic mouse
events.  This CL updates the remianing places that generate mouse event
from touch input to explicitly mark them as so.  To do this I've removed
an ASSERT I added that attempted to lock-in hit-test reduction
improvements.  We have a dedicated test for this (hit-test-counts.html)
and so the ASSERT wasn't adding much.  It's not worth the effort at this
point to refactor the touch drag and drop code (a little used feature)
to remove a couple of hit tests (but I've left the comments in place
saying that ideally we'd do so in the future).

BUG=408660

Review URL: https://codereview.chromium.org/558753002

git-svn-id: svn://svn.chromium.org/blink/trunk@181780 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The comment is outdated since the css values have been
implemented and the referenced bug is closed.

NOTRY=true

Review URL: https://codereview.chromium.org/562743003

git-svn-id: svn://svn.chromium.org/blink/trunk@181778 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Use reference instead of pointer in BMPImageDecoder::processFileHeader

Review URL: https://codereview.chromium.org/556913002

git-svn-id: svn://svn.chromium.org/blink/trunk@181777 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=ojan@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/558363002

git-svn-id: svn://svn.chromium.org/blink/trunk@181776 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Remove this field as it is no longer used by Chromium. Also prepare the
way for removing |WebTouchEvent.changedTouches| by populating
|WebTouchEvent.touches| with *all* touch points, even those that are
released or cancelled, in WebTouchEventBuilder. The plugin consumer
downstream can resynthesize the changed touches on-demand.

This is part 2 of a 4-sided patch simplifying WebTouchEvent:
1) https://codereview.chromium.org/557863002/
2) This change
3) https://codereview.chromium.org/559693003/
4) https://codereview.chromium.org/560493003/

BUG=358132

Review URL: https://codereview.chromium.org/558773002

git-svn-id: svn://svn.chromium.org/blink/trunk@181775 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is a Blink side patch for visualizing paint
invalidation for newly created RenderObject.
Demo @ https://www.youtube.com/watch?v=L-zo91nL2nE&list=UUGC5ommqy7KyPzZ-eGlL_Dg

After this CL, GraphicsLayerDebugInfo holds a vector of
invalidation rects along with their source / reason.
The rects can be queried from the embedder using the method
|GraphicsLayerDebugInfo::getAnnotatedInvalidationRects|.

This CL also adds a flag |RenderObject::hadPaintInvalidation|
to track if the RenderObject had ever been painted.
The flag is then used to annotate invalidation rects
for first paint of the RenderObject.

After this CL, WebLayer implementator can query this info to
visualize the layer invalidation including the first paint,
which is useful for telling if the repaint storm is due to
the page itself, or is a performance bug in Blink rendering
stack.

BUG=402033

Review URL: https://codereview.chromium.org/498193003

git-svn-id: svn://svn.chromium.org/blink/trunk@181774 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Review URL: https://codereview.chromium.org/560613002

git-svn-id: svn://svn.chromium.org/blink/trunk@181773 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Followup to CL 459633002, this fixes a compile error with some
older toolchains.

BUG=401254

Review URL: https://codereview.chromium.org/558283003

git-svn-id: svn://svn.chromium.org/blink/trunk@181772 bbb929c8-8fbe-4397-9dbb-9b2b20218538