- 17 Oct, 2019 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/c9f13b8d903d..8df31ad1d9b8 git log c9f13b8d903d..8df31ad1d9b8 --date=short --no-merges --format='%ad %ae %s' 2019-10-17 crouleau@chromium.org Reland "[Telemetry] Refactor expectations code into story_filter.py." Created with: gclient setdep -r src/third_party/catapult@8df31ad1d9b8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC oysteine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=oysteine@google.com Bug: chromium:985103 Change-Id: I71b1b2f2d63f06b5680de86e9d0af1341bc24ad7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865138Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#706759}
-
Sanket Joshi authored
This change fixes a bug where the HSL and Hex values for the selected color could be NaN if the color well's selection ring was the bottom of the color well and the page zoom was set to 150%. At certain zoom levels like 150%, the height of the color well is not a round number. However, the getImageData API, which is used to retrieve the underlying pixel color data for the color well, only works with integer values and will truncate decimal values. As such, if the color well's selection ring is placed at the bottom of the color well, a valid pixel data point for the ring's position cannot be found in the image data array for the color well. When such a situation occurs, the fix is to use the last color in the color well's image data array. This color will be the same as the color seen at the bottom of the color well (black), so the user will see what they expect. Bug: 1015238 Change-Id: I1b74a4870fa455d197c525dca39dc88e7c6f75f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866060Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Sanket Joshi <sajos@microsoft.com> Cr-Commit-Position: refs/heads/master@{#706758}
-
Fritz Koenig authored
GLES 3.0 does not have glFramebufferParameteri. The spec for MESA_framebuffer_flip_y was updated to add glFramebufferParameteriMESA which will allow the MESA_framebuffer_flip_y functionality on GLES 3.0. BUG=955198 TEST=betty-vm Change-Id: I7e7d762e85b862a1264e130bbb22000adb17ba58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850797Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Fritz Koenig <frkoenig@chromium.org> Auto-Submit: Fritz Koenig <frkoenig@chromium.org> Cr-Commit-Position: refs/heads/master@{#706757}
-
Joel Hockey authored
Currently we disallow dropping tabs onto a browser that does not support FEATURE_TABSTRIP. This adds an extra check to also disallow if the source and target browser are not the same type (APP vs NORMAL). This CL includes some refactoring of the logic to check whether a tab can attach to a new target. * New function CanAttachTo replaces GetContextForWindow and ShouldDisallowDrag. * Removed TabDragContext.IsCompatibleWith and inlined the profile checking into CanAttachTo. * OnWidgetBoundsChanged no longer calls GetContextForWindow which was previously doing a number of pointless checks to see if the current attached context could drag to itself. Rather this codesite uses attached_context_ directly. From what I can tell, the widget change observer happens on move_loop_widget_ which is attached_context_. * GetTargetTabStripForPoint was previously doubling up on the checks in GetContextForWindow as this function was being called by ShouldDisallowDrag, then again immediately after to get destination_tab_strip_. Now these checks happen only once in CanAttachTo. * BringWindowUnderPointToFront now calls CanAttachTo which has the additional modal dialog check from ShouldDisallowDrag. Bug: 1012169 Change-Id: Iab0a09a1b37024b8611798822c94edd9c6820daf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862884 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#706756}
-
Brandon Wylie authored
The Google G (or other dse icon) should appear when scrolling the NTP. This icon wasn't displaying because the hasFocus boolean isn't set when scrolling. Adding plumbing to store the current focus percent in StatusMediator and factoring that into the dse icon showing logic. Bug: 1012508 Change-Id: Ia1f5a935ba5ceb8814000a520f482c661da716f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854505 Commit-Queue: Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Ender <ender@google.com> Cr-Commit-Position: refs/heads/master@{#706755}
-
Elly Fong-Jones authored
There are a handful of dialogs that need to customize parts of the DialogClientView or BubbleFrameView that DialogDelegate creates internally. Currently, that customization is achieved by overriding DialogDelegate::UpdateButton(), which is called "whenever needed" by DialogClientView. This change reworks that logic. Specifically, this change: 1) Adds a virtual method DialogDelegate::OnDialogInitialized() which is called after the DialogDelegate's frame, widget, etc are all initialized but not yet shown. This will be the new customization point for DialogDelegate subclasses that need to customize these elements. 2) Adds a virtual method WidgetDelegate::OnWidgetInitialized() which is called after Widget::Init is complete. DialogDelegate uses this to call OnDialogInitialized at the proper point. 3) Adds some accessors to DialogDelegate to make getting at the buttons in the DialogClientView easier (and make users of DialogDelegate not need to know about DialogClientView, which should be an implementation detail). 4) Removes DialogDelegate::UpdateButton, which is now superfluous, and folds the body of the old base implementation into DialogClientView where it belongs. 5) Removes some of the GlobalErrorBubbleViewTest suite, which were "change detector" unit tests for the internals of DialogDelegate. OnDialogInitialized is also a logical place to move some of the other customizations of DialogDelegate that are currently done via other hooks (e.g. CreateExtraView and friends); this will happen in a followup change. This is why DialogDelegate has OnDialogInitialized rather than encouraging subclasses to directly override WidgetDelegate::OnWidgetInitialized: soon it will be necessary for DialogDelegate to do its own setup in OnWidgetInitialized, and I want to maintain the "contractless" behavior of OnDialogInitialized. Bug: 1011446 Change-Id: I9a9a24aa077cd62fb219b8104267c5d6ab6edb40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865410 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#706754}
-
gogerald authored
This CL is based on https://chromium-review.googlesource.com/c/chromium/src/+/1825165 Bug: 982018 Change-Id: I1cf69ab2aa2ecdaf97d39b92bcfdd690ca4f12ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1853826 Commit-Queue: Ganggui Tang <gogerald@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#706753}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/81607380ef4e..3800252a84f8 git log 81607380ef4e..3800252a84f8 --date=short --no-merges --format='%ad %ae %s' 2019-10-17 vapier@chromium.org upload_symbols: drop poster module 2019-10-16 jrosenth@chromium.org lib/cros_build_lib_unittest: remove DummyOutput class Created with: gclient setdep -r src/third_party/chromite@3800252a84f8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I4df36373cb54bdc8ea7e2a25c75ecfc330670660 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865137Reviewed-by:
-
Tsuyoshi Horo authored
We decided to use "WebBundles" for BundledHTTPExchanges in Chrome. Bug: 995177 Change-Id: I012effbaf1e1f413bc1aed47571dbb4677eb2593 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862882Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#706751}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 2e4c0dc7. With Chromium commits locally applied on WPT: 6386d9d8 "Update service_worker_unregister_and_register()" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: I2482308ce4cdd859286eabc7d30f6ed807a15719 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866029Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#706750}
-
Tsuyoshi Horo authored
Spec side PR: https://github.com/WICG/webpackage/pull/505 TBR=palmer@chromium.org Bug: 969596 Change-Id: I862fd24c2b3d8a4b237d0852829361dcf9cdde40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1861614Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Reviewed-by:
-
Fritz Koenig authored
GL_MESA_framebuffer_flip_y is needed for ChromeOS, which uses gles. There is no current benefit to using it on other platforms. BUG=964010 TEST=chrome://gpu Change-Id: I5261ac6aed84441d4cc79bea74fd18fd0f35e680 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862250 Auto-Submit: Fritz Koenig <frkoenig@chromium.org> Reviewed-by:
-
Xida Chen authored
This CL adds a metric to measure the draw interval of the compositor, when there is a running custom property animation on the compositor thread. At this moment, a custom property animation is running on the compositor thread only if it is used by a paint workelt. So this metric reflect how smooth a paint worklet animation is running. Bug: 1002076 Change-Id: I7d3a7df096bb347a0f09257ed7bce498b447cac4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827246Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#706747}
-
Kazuki Takise authored
The current scenario is as follows: 1. Just before PIP resize, the next animation type is set kAnimationAnimated. 2. If the bounds doesn't change, the next animation type remains kAnimationAnimated. 3. PIP resize is started and window geometry and viewport are sent from Android before the first commit of PIP resize. 4. On the first commit, as the next animation type is set kAnimationAnimated, window geometry is applied with animation enabled, but viewport is applied immediately, so we observe a glitch for one frame. This CL changes it so that we make sure to set kAnimationNone once PIP resize has started. at the start of resize. Bug: b/142105182 Test: Resized PIP window and confirmed I didn't observe a glitch Change-Id: Ie61db4fe86891d5d10654d3c44b6dfe6cb7b1730 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850684 Commit-Queue: Kazuki Takise <takise@chromium.org> Auto-Submit: Kazuki Takise <takise@chromium.org> Reviewed-by:
Eliot Courtney <edcourtney@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#706746}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b060ba608175..5cf279fb5b69 Created with: gclient setdep -r src-internal@5cf279fb5b69 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I9b229e0f3219844ec5ba2d618bb1f09dfdf5bde3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865482Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#706745}
-
sczs authored
Also fixes an issue where Mobile.Messages.Badge.Tapped wasn't part of the affected histograms. Bug: 1014652 Change-Id: Ic80c062183e8cc4fba5a00399ea7bbb3fb0a1d3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862867 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#706744}
-
Rob Schonberger authored
This CL could be split in two. First, adds a method to Stroke for the biggest touch-major of that stroke, and the corresponding unit test. More importantly: Adds an abstract class for what a checked in model looks like. All the configuration is accessible from the model when instantiated, and no implementation is added. All the fields in configuration are documented, and an explicit constructor for the configuration is added since this counts as a complex struct. Bug: 1009290 Change-Id: I7eeca918540e80a34133230c6d0a67c6b58c2af5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864490Reviewed-by:
Michael Spang <spang@chromium.org> Commit-Queue: Rob Schonberger <robsc@chromium.org> Cr-Commit-Position: refs/heads/master@{#706743}
-
Stefan Zager authored
If the explicit root element is the document's scrollingElement, we interpret that to mean we should apply the root scroller's overflow clip (just as we already do with the implicit root). Hidden behind a flag for testing, and pending resolution of spec issues and sending intent's. BUG=1015183 R=chrishtr@chromium.org Change-Id: I6b2542dd353ea0be6b67b5922eee75445070f10a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865257 Commit-Queue: Stefan Zager <szager@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#706742}
-
Jeremie Boulic authored
Update FileBrowser.TeamDrivesCount metric to expire after M89, at the beginning of 2021. Bug: 988794 Change-Id: I4df30b27726f4c29e1c4a602fd5e922ed23c394b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863066Reviewed-by:
François Degros <fdegros@chromium.org> Commit-Queue: François Degros <fdegros@chromium.org> Cr-Commit-Position: refs/heads/master@{#706741}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/0cb3e4bf7d70..55e5853e5ce4 git log 0cb3e4bf7d70..55e5853e5ce4 --date=short --no-merges --format='%ad %ae %s' 2019-10-17 ehmaldonado@chromium.org depot_tools: Stop using oauth2client Created with: gclient setdep -r src/third_party/depot_tools@55e5853e5ce4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: chromium:1001756 Change-Id: Iab3c23e4a0ef58feed8363689f99ac09249e2bba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865135Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/1dfc77cc08ee..f29cb70281d5 git log 1dfc77cc08ee..f29cb70281d5 --date=short --no-merges --format='%ad %ae %s' 2019-10-16 herb@google.com Revert "Introduce SkGlyphSourceBuffer" Created with: gclient setdep -r src/third_party/skia@f29cb70281d5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC csmartdalton@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=csmartdalton@google.com Bug: None Change-Id: Ic08eca63c2cdf7e428fb84056d7206b491bc4def Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865134Reviewed-by:
-
Aga Wronska authored
Child users should be prevented from playing audio content when their account is locked, because of screen time/bedtime/other parental lock. Disabling media includes suspending media session and disabling media controls on lock screen. Bug: 1008189 Change-Id: I1f365ddda9fb0e810f537c4f140e3163b447390c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857503 Commit-Queue: Aga Wronska <agawronska@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#706738}
-
Sara Kato authored
Previously (https://crrev.com/c/1092394) tooltip value was added to description on automation nodes, however there should be a tooltip property to store this value. Bug: b/137246277 Test: AXNodeDataTest.TextAttributes Test: AXTreeSourceArcTest.AccessibleNameComputation Change-Id: I80c3a048631fe06260eb66fc0a5c056771bc0b62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1741328Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
Sara Kato <sarakato@chromium.org> Commit-Queue: Sara Kato <sarakato@chromium.org> Cr-Commit-Position: refs/heads/master@{#706737}
-
Joe DeBlasio authored
Change-Id: I168e905bdadbda58f1553a8b99eae40fdd417895 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865260 Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Auto-Submit: Joe DeBlasio <jdeblasio@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#706736}
-
Sammie Quon authored
Instead of doing extra step to transform the window and then find the bounds of these objects by reverse transform. Test: manual Bug: 1011973 Change-Id: I00e7432d4c02c6d8f08dd7ddaa195a5d7de2591b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864169Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#706735}
-
Oystein Eftevaag authored
TBR=croleau@chromium.org NOTRY=true Bug: 1008001 Change-Id: I336b2c111f0e3b32a5ee81d6952aa5c99955fb16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865140Reviewed-by:
oysteine <oysteine@chromium.org> Commit-Queue: oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#706734}
-
Dan Beam authored
Bug: 1003210 Change-Id: I4aa346dbd8df0681f08021b0d499403d3a1e9e52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865210 Auto-Submit: Dan Beam <dbeam@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#706733}
-
Yang Guo authored
R=efoo@chromium.org Bug: 977050 Change-Id: I5cd52a8efdd4c2c64ee5787722928ba55624486a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863014 Auto-Submit: Yang Guo <yangguo@chromium.org> Commit-Queue: Eric Foo <efoo@chromium.org> Reviewed-by:
Eric Foo <efoo@chromium.org> Cr-Commit-Position: refs/heads/master@{#706732}
-
John Budorick authored
No-Trying around a different layout test flake on windows :/ No-Try: true Bug: 1015187 Change-Id: Ib55d89898f18a7ec01ab01f9c82c8b865c7f32aa Tbr: yhirano@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864406 Commit-Queue: John Budorick <jbudorick@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#706731}
-
Elly Fong-Jones authored
This change removes overrides from: * PlatformVerificationDialog, which used static strings * ExternalProtocolDialog, which used a static string * EnrollmentDialogView, which used a static string * InvertBubbleView, which used a static string * ArcAppDialogView, which used strings supplied to the constructor * ConfirmBubbleViews, which used strings from a model. Every instance of this model uses static strings, and in any case the model has no facility for signalling changes to its state. * CrostiniAppUninstallerView, which used a static string * CrostiniForceCloseDialogview, which used a static string * CrostiniUninstallerView, which used a static string * ImportLockDialogView, which used a static string * OutdatedUpgradeBubbleView, which used a string computed from a constructor parameter * OneClickSigninDialogView, which used static strings * TaskManagerView, which used a static string All of these are fairly mechanical. Bug: 1011446 Change-Id: Ifa189cb4da637dc4451ee5cccd85316e5145b25c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865417Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#706730}
-
Nick Harper authored
Change-Id: I7865db59f537d73b85d8f367550e42ea26e8780a Bug: b/142135785 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864404Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Ryan Hamilton <rch@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Auto-Submit: Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#706729}
-
Tommy Steimel authored
This CL makes GMC notifications clickable. When clicked, the tab that originated the media is focused. Bug: 1011052 Change-Id: I4f14cf8f5d19e12afbb5eaf11c1b8e7ac1a042c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862868 Commit-Queue: Tommy Steimel <steimel@chromium.org> Reviewed-by:
Jazz Xu <jazzhsu@chromium.org> Cr-Commit-Position: refs/heads/master@{#706728}
-
Peter Kasting authored
Because the location bar used to be light even in dark windows, the find bar had a hack to use the non-incognito NativeTheme object. Now that the location bar is dark in incognito, this hack is incorrect. Remove it. This also means View::SetNativeTheme() is only called by test code, so this renames it accordingly so people don't add additional non-test uses. Bug: none Change-Id: Id0a3363c0d3457cdfdff5ab81bff9be7ce34f15d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864515Reviewed-by:
Tommy Steimel <steimel@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#706727}
-
Mike Dougherty authored
BreadcrumbManagerObserver allows objects to listen for newly added events to BreadcrumbManager. Bug: 1003922 Change-Id: I4a493bb12aa50ff6c36f2965ac55600abbc9d711 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864520 Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#706726}
-
Scott Violet authored
This is a stale dependency that isn't necessary anymore. BUG=none TEST=none Change-Id: I904c2854f6c9e06b32de243962541692a983fa41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864330Reviewed-by:
-
dpapad authored
There is no clear benefit of using the file generated by polymer_modulizer() for type checking (for the case where html_type is 'v3-ready'). Moreover this causes the lines reported by Closure compiler to not correspond to the lines under src/. Bug: 965770 Change-Id: I56f7ed3dd18419ac549736aa2bfff863fc4c58d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865660Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#706724}
-
Charles Zhao authored
Bug: 1012936 Change-Id: Iac49d866aa30160da097179506e0bc6bb1cae024 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865910Reviewed-by:
Charles . <charleszhao@chromium.org> Reviewed-by:
Tony Yeoman <tby@chromium.org> Commit-Queue: Charles . <charleszhao@chromium.org> Commit-Queue: Tony Yeoman <tby@chromium.org> Auto-Submit: Charles . <charleszhao@chromium.org> Cr-Commit-Position: refs/heads/master@{#706723}
-
Linkun Chen authored
Bug: b/141204302 Bug: 1015146 Test: try on device Change-Id: Ieec8e915e27375e3cda3f9390eb762cda1e8735d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1563645 Commit-Queue: Michael Spang <spang@chromium.org> Reviewed-by:
-
Jinsuk Kim authored
BottomSheet for gesture navigation should have the lifecycle as same as that of the tab it was brought up for. Bug: 1011073, 1009338 Change-Id: Ibf86a5710e9cef3a4d7bc513b89d331054228fb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1851889 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#706721}
-
Johannes Henkel authored
This keeps pending messages in a list, and identifies waiting_for_response with a hash map. In this way we avoid reordering messages coming from the client. Previously, we ordered some messages coming from the client by their call_id, but this assumes that the client sends them in order of their call id, which isn't always true. Change-Id: Idd87e37fff64736117a9d0d780e7bf4f20e59974 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863631 Commit-Queue: Johannes Henkel <johannes@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#706720}
-
