- 05 Sep, 2019 40 commits
-
-
Jesse Schettler authored
When print preview is closed, notify the PrintSessionImpl so it can close the ARC Custom Tab used for printing. Bug: b:139551164 Test: Close print preview in ARC Custom Tab and verify the tab is closed Change-Id: I5ed70a26eef781b9e8224bfa88617d93d7709a12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782010 Commit-Queue: Jesse Schettler <jschettler@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#693739}
-
Jinfeng Ma authored
Custom scroll corners and resizers are LayoutScrollbarPart objects, they will set scrollable container box as parent by calling SetDangerousOneWayParent. By now, this one way parent is just used for getting the writing mode style. Bug: 999062 Change-Id: I7a31fe23e6558e70fb3de83519a473633c4303fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778899Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#693738}
-
Gabriel Charette authored
Backport some tests in /content/browser/renderer_host/render_widget_host_view_mac_editcommand_helper_unittest.mm to SingleThreadTaskEnvironment These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /content/browser/renderer_host/render_widget_host_view_mac_editcommand_helper_unittest.mm. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. R=rsesek@chromium.org Bug: 891670 Change-Id: I21d55afc3729de3571d2c15215992656753cae7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786747 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#693737}
-
Kevin Bailey authored
Just adds a field-trial test config to exercise the higher suggestions, URL limit logic. Desktop only. (Also removes mention of OmniboxTailSuggestions.) Bug: 964049 Change-Id: Iad68a65c59a1033887ea41a3f6f4efb444052a77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778361 Commit-Queue: Kevin Bailey <krb@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Cr-Commit-Position: refs/heads/master@{#693736}
-
Rafał Godlewski authored
Bug: 986322 Change-Id: Icacf75505712412ebfa6afffac4b46afab4adfaa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787637 Commit-Queue: Rafał Godlewski <rgod@google.com> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#693735}
-
Gabriel Charette authored
These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /chrome/browser/safe_browsing/chrome_cleaner. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. R=joenotcharles@google.com Bug: 891670 Change-Id: I16c7853ec95cc1aa12416234ec09778b5e1bd840 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787057 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Joe Mason <joenotcharles@google.com> Commit-Queue: Joe Mason <joenotcharles@google.com> Cr-Commit-Position: refs/heads/master@{#693734}
-
Andrew Grieve authored
Reverting whole CL has merge conflicts, so quickly reverting this one more known bad file. NOTRY=true NOPRESUBMIT=true TBR=estevenson Bug: 1000471 Change-Id: Ica8158d081cb4e7c833787e8196e2cbf792093bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786671Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#693733}
-
Peter Beverloo authored
Bug: 891339 Change-Id: I5e144d89715e067469a01ae4b23a4ffb599ceab4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784610Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Jason Chase <chasej@chromium.org> Commit-Queue: Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#693732}
-
Gabriel Charette authored
These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /content/browser/compositor. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. R=danakj@chromium.org Bug: 891670 Change-Id: Ifb26dd922e4c13b81182127448e399677505989b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786821 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#693731}
-
Michael Ludwig authored
Bug: 1001093 Change-Id: I93ff0c9929221fa7b9c2d14a1ff2a3013256004c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787243 Auto-Submit: Michael Ludwig <michaelludwig@google.com> Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#693730}
-
Peter Kasting authored
This is now effectively the guidance of the public Google C++ styleguide, and thus unnecessary. Bug: none Change-Id: I5896ec95822cc586d8f30427083108c34ac1206c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1785747 Auto-Submit: Peter Kasting <pkasting@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
-
danakj authored
The WebWidget in a frame-based RenderWidget is always a WebFrameWidget now. The TextInputClientObserver checks if the WebWidget is a WebFrameWidget when it is not null, but for a frame-based RenderWidget is always a WebFrameWidget now when not null, and becomes null instead of a non- WebFrameWidget when the main local frame is detached. So we can just check (and return directly) the nullptr instead. R=dcheng@chromium.org Bug: 419087 Change-Id: If0c3eea72a468d5d1b63cc8a5427c7a17880c59a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783919Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#693728}
-
Nicolas Ouellet-payeur authored
This CL was submitted without updating annotations.xml due to an issue with the presubmit bot: https://chromium-review.googlesource.com/c/chromium/src/+/1783879 TBR=rhalavati@chromium.org Bug: 1001108 Change-Id: Ib5e0b6d51e843e0b48c79d9fecae9ecf27bc823c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787862 Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Reviewed-by:
Nicolas Ouellet-Payeur <nicolaso@chromium.org> Cr-Commit-Position: refs/heads/master@{#693727}
-
Ian Clelland authored
This reverts commit a5c0d47c. Reason for revert: Breaks Android build: https://ci.chromium.org/p/chromium/builders/ci/android-archive-rel/4323 Original change's description: > Remove deprecated methods in CallbackHelper.java > > Bug: 1000510 > Change-Id: I6d26647c389b75bbc37dcc0fbafc18d25e84285b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1785102 > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > Reviewed-by: Bo <boliu@chromium.org> > Auto-Submit: Andrew Grieve <agrieve@chromium.org> > Cr-Commit-Position: refs/heads/master@{#693693} TBR=boliu@chromium.org,agrieve@chromium.org Change-Id: I332fe630da34560893ccc1ca470624f067db3428 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1000510 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787353Reviewed-by:
Ian Clelland <iclelland@chromium.org> Commit-Queue: Ian Clelland <iclelland@chromium.org> Cr-Commit-Position: refs/heads/master@{#693726}
-
Nico Weber authored
This reverts commit 0bf621ef. Reason for revert: This breaks the iOS build, see e.g. https://ci.chromium.org/p/chrome/builders/try/ipad-device/113 Original change's description: > base: Remove temporary "WithTraits" task API wrappers > > Now that everyone has been migrated to the renamed > PostTask/CreateTaskRunner APIs, we can remove these temporary wrappers. > > TBR=gab@chromium.org > (to apply side-effects of mechanical change in //base) > > Bug: 968047 > Change-Id: I69c53abd899f37586f23ec295ffcc9bf12042c4a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752787 > Reviewed-by: Sami Kyöstilä <skyostil@chromium.org> > Reviewed-by: Gabriel Charette <gab@chromium.org> > Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> > Auto-Submit: Sami Kyöstilä <skyostil@chromium.org> > Cr-Commit-Position: refs/heads/master@{#693695} TBR=gab@chromium.org,skyostil@chromium.org Change-Id: If1229c8390dc657b7525e58994a94b51f598e880 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 968047 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786836Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#693725}
-
Gabriel Charette authored
These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /gin. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. R=jbroman@chromium.org Bug: 891670 Change-Id: Idc0de22233bb1dfa72b0111d2dc5d24ba32208a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786942 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#693724}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/3fa35aa420ee..3de1b8d0b098 git log 3fa35aa420ee..3de1b8d0b098 --date=short --no-merges --format='%ad %ae %s' 2019-09-05 wl@gnu.org [cmake] Add brotli support. 2019-09-05 wl@gnu.org FindHarfBuzz.cmake: Change indentation to two spaces; shorten lines. 2019-09-05 wl@gnu.org Fix handling of `AF_CONFIG_OPTION_INDIC'. 2019-09-05 wl@gnu.org CMakeLists.txt: Fix generation of DLL related stuff (#56852). Created with: gclient setdep -r src/third_party/freetype/src@3de1b8d0b098 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/freetype-chromium Please CC bungeman@google.com,drott@google.com,thestig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux-blink-rel;luci.chromium.try:mac10.12-blink-rel;luci.chromium.try:mac10.13_retina-blink-rel;luci.chromium.try:win10-blink-rel;luci.chromium.try:win7-blink-rel TBR=bungeman@google.com,drott@google.com,thestig@google.com Bug: None Change-Id: I6061bbaf2b0997c47c9d3833babb052c11f9ef02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787840Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Ben Wagner <bungeman@chromium.org> Cr-Commit-Position: refs/heads/master@{#693723}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/79401df82ffb..5c3c41d20e9c Created with: gclient setdep -r src-internal@5c3c41d20e9c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:None Change-Id: Iaac3011090b024fefee8a600a4548433993794b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786926Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#693722}
-
John Budorick authored
This is a partial revert of crrev.com/c/1780982. Bug: 950413,1001063e Change-Id: Ie76a8ad85aaa58b68d5bb11539dd36756a5f36ae Tbr: sque@chromium.org,hypan@google.com No-Tree-Checks: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787917Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#693721}
-
Jit Yao Yap authored
Sync server-side changes from https://critique.corp.google.com/#review/265486891 and https://critique.corp.google.com/#review/264162159 to client. Change-Id: I301e0b34a206bd6bf382db0c5100ccf9bf67389a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1781440Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Jit Yao Yap <jityao@google.com> Cr-Commit-Position: refs/heads/master@{#693720}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/f3f61591146b..5b728cca77c4 git log f3f61591146b..5b728cca77c4 --date=short --no-merges --format='%ad %ae %s' 2019-09-05 alessiob@webrtc.org Revert "Make relative arrival delay mode default in NetEq delay manager." 2019-09-05 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision e96090c3..7e5c3643 (693514:693630) Created with: gclient setdep -r src/third_party/webrtc@5b728cca77c4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None Change-Id: I0043e925070cc8c08cfef2f9cc619489de222e94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787842Reviewed-by:
-
Andrew Grieve authored
Bug: 1000462 Change-Id: I4ca955c2ec90be382b27f7d12dfe967619684579 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1785009 Auto-Submit: Andrew Grieve <agrieve@chromium.org> Commit-Queue: Sam Maier <smaier@chromium.org> Reviewed-by:
Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#693718}
-
Ian Clelland authored
This reverts commit 31276982. Reason for revert: The test is crashing periodically on ChromeOS builders -- see failures at https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-rel/28853 https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-rel/28862 https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-rel/28864 https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-rel/28873 Original change's description: > Add ArcAppModelBuilderTest.IconLoaderCompressed > > BUG=826982 > > Change-Id: I29f5c1ea49d6c47dd324760b440daa5637fbcb53 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772851 > Commit-Queue: Nigel Tao <nigeltao@chromium.org> > Reviewed-by: Yury Khmel <khmel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#693015} TBR=khmel@chromium.org,nigeltao@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 826982 Change-Id: Ifd2652eef6ba9b97a08abc8094fa78fe40d0bab9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786929Reviewed-by:
-
chrome://policyFelipe Andrade authored
This CL changes chrome/browser/resources/policy/policy.css to wrap policy values when they are too long. The problem was reported for policy value of OpenNetworkConfiguration. A screenshot of the new policy page has been added to the bug thread. Bug: 585629 Change-Id: I0804ab8ddd743d6861eb0e3afa3be781a76fc4cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778049Reviewed-by:
Lutz Justen <ljusten@chromium.org> Reviewed-by:
Denis Kuznetsov <antrim@chromium.org> Reviewed-by:
Yann Dago <ydago@chromium.org> Commit-Queue: Felipe Andrade <fsandrade@chromium.org> Cr-Commit-Position: refs/heads/master@{#693716}
-
Ian Clelland authored
This reverts commit 5eb2341c. Reason for revert: Breaks build at https://ci.chromium.org/p/chrome/builders/ci/mac-google-rel/4397 (Maybe some others need to be whitelisted as well) Original change's description: > mac: Enable gn check for data vars pointing to directories below the build dir. > > Mac bundles violate this constraint, so this adds many whitelist entries. > Fixing them seems not super easy, so I filed https://crbug.com/1000667 for it. > > Bug: 1000667, 912946 > Change-Id: Ibc1704fe779c6ccc86871a1b651f52572db3f919 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1780883 > Commit-Queue: Nico Weber <thakis@chromium.org> > Reviewed-by: Takuto Ikuta <tikuta@chromium.org> > Auto-Submit: Nico Weber <thakis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#693705} TBR=thakis@chromium.org,tikuta@chromium.org Change-Id: Ib2ad91564aefb659e5a18d9caad43947b5159944 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1000667, 912946 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787861Reviewed-by:
-
Andrew Luo authored
Bug: 1000798 Change-Id: If100bbcd2ed09b18b24f473927d28db94ddb797f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1785088Reviewed-by:
Changwan Ryu <changwan@chromium.org> Commit-Queue: Andrew Luo <aluo@chromium.org> Cr-Commit-Position: refs/heads/master@{#693714}
-
Friedrich Horschig authored
If a field in a filled form is focused, the shown suggestions match the field contents. When the shown suggestion is an exact match, clicking it will fill the exact same content again -- effectively, it's a no-op. This CL hides exact matches on Android. This is harmless unless label disambiguation is enabled. Now, a sublabel seemingly differentiates between multiple suggestions since their sublabels differ. But clicking any of the suggestions will again only fill the selected field (which is still a no-op). If a user is presented with multiple different options, they will expect that each option fills the entire dataset that a label represents. Instead, they get multiple, differently labeled no-ops. For Android, disambiguation labels are very prominent, especially in the keyboard accessory which hosts them. Therefore, it makes sense to hide the no-op suggestions completely. For Desktop, label disambiguation isn't launched yet and the dataset merging algorithm aggressively filters the datasets to one single suggestion. This means the issue isn't very prominent. Hiding the labels would actually have a negative side-effect: there would be no access to the "Clear Form" option (which currently isn't visible on Android). Bug: 1000039 Change-Id: Ibe43617202003900b3fa0f80259906d8467993eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787598 Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#693713}
-
Gabriel Charette authored
These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /components/ssl_errors. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. R=felt@chromium.org Bug: 891670 Change-Id: I9965909522968e20f1631f49142d37928cf11a71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786982 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Adrienne Porter Felt <felt@chromium.org> Commit-Queue: Adrienne Porter Felt <felt@chromium.org> Cr-Commit-Position: refs/heads/master@{#693712}
-
Gabriel Charette authored
These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /components/captive_portal. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. R=mmenke@chromium.org Bug: 891670 Change-Id: I1125b34060d286987b18944e071148b8b7dacb84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787097 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#693711}
-
Rune Lillesveen authored
To support different color values for form controls in UA stylesheets based on color-scheme, we need a way to provide a way to specify that. This CL introduces a new color function only available in UA stylesheets to do that. Design document: https://docs.google.com/document/d/1RRyQSdohsl8S9kQIdC6rYwwVy6cY15gjkGMgyadTORg Bug: 939811 Change-Id: I9c68d0bf0dea1eb6c5bd6c3b07d677e57779b6ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782158Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#693710}
-
Andrew Grieve authored
This reverts commit 0ad8ca81. Reason for reland: Removed @CheckDiscard and filed bug TBR=agrieve #reland Change-Id: I88779e45a49c1bad7fc6365c373d55ed9d800df0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784962 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#693709}
-
Gabriel Charette authored
Backport some tests in /media/mojo/services/mojo_audio_input_stream_unittest.cc to SingleThreadTaskEnvironment These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /media/mojo/services/mojo_audio_input_stream_unittest.cc. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. R=henrika@chromium.org Bug: 891670 Change-Id: Ia3896fb8e3744e12405528a785479e08ab05d395 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786677 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Olga Sharonova <olka@chromium.org> Commit-Queue: Olga Sharonova <olka@chromium.org> Cr-Commit-Position: refs/heads/master@{#693708}
-
Gabriel Charette authored
Backport some tests in /media/mojo/services/mojo_audio_output_stream_provider_unittest.cc to SingleThreadTaskEnvironment These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /media/mojo/services/mojo_audio_output_stream_provider_unittest.cc. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. R=olka@chromium.org Bug: 891670 Change-Id: I6db90bfd72373e3fef77b101d7c940b4b7de9ffb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786854 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/ca5ee4c937cc..2dc5f73698ee git log ca5ee4c937cc..2dc5f73698ee --date=short --no-merges --format='%ad %ae %s' 2019-09-05 treehugger-gerrit@google.com Merge "Show devices in target selection dropdown & improve error handling" 2019-09-05 hjd@google.com Merge "trace_processor: Parse async systrace events" Created with: gclient setdep -r src/third_party/perfetto@2dc5f73698ee If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: I1f2ecadffa6ddd05b1ec56be38e44ca6da3728ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787839Reviewed-by:
-
Nico Weber authored
Mac bundles violate this constraint, so this adds many whitelist entries. Fixing them seems not super easy, so I filed https://crbug.com/1000667 for it. Bug: 1000667, 912946 Change-Id: Ibc1704fe779c6ccc86871a1b651f52572db3f919 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1780883 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
-
Olga Sharonova authored
TBR=dmazzoni@chromium.org Bug: 1000965 Change-Id: I710ccc544142c26ede9497436f8a19ca37c1a97a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787780Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 5eeb3db1. With Chromium commits locally applied on WPT: e7387117 "[sms] Allow SMS Receiver for same origin iframes" 36b875c4 "[WPT/mixed-content] Regenerate test files warning: inexact rename detection was skipped due to too many files. warning: you may want to set your diff.renameLimit variable to at least 648 and retry the command." afac3266 "Set `Sec-Fetch-Mode` from the network service." 851ab8fb "[WPT/referrer-policy] Regenerate attr-referrer tests" 6facce4a "[WPT/referrer-policy] Regenerate img-tag meta-referrer tests" 9d98088f "[WPT/referrer-policy] Regenerate a-tag tests" bb9c94d9 "Simplify fetch-event-within-sw.https.html using async/await" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I34e5e3bed3c71ac40b9f8e70ab34ca38e6f240bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787242Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#693703}
-
Carlos Caballero authored
Remove references in /media/audio MessageLoopForIO is going away soon. Use SingleThreadTaskExecutor for main functions and SingleThreadTaskEnvironment for tests instead. Both are no op changes. This CL was uploaded by git cl split. R=olka@chromium.org Bug: 891670 Change-Id: Iea502221ede3aec4f88c76f3ac7ccb744a365b84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1781151 Auto-Submit: Carlos Caballero <carlscab@google.com> Commit-Queue: Olga Sharonova <olka@chromium.org> Reviewed-by:
-
Gabriel Charette authored
These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /ui/ozone/platform/drm. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. R=dnicoara@chromium.org Bug: 891670 Change-Id: I1a2cb17e769126e955b904a0625393bc095febd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786937 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Commit-Queue: Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#693701}
-
Gabriel Charette authored
These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /content/browser/speech. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. R=olka@chromium.org Bug: 891670 Change-Id: Ia9f81a7ca8460bb6e4aba386fc5f0e72fd62fa05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787061 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
-
