- 28 Oct, 2020 5 commits
-
-
James Vecore authored
Previously a new IpcNetworkManager was created for each PeerConnection. IpcNetworkManager calls StartNetworkNotifications on the p2p_socket_manager_ which is not re-created for each PeerConnection. The second call failed and ended up blocking ice candidate gathering because it was waiting for the network list to come through which it never did. The simple solution here is to just re-used the IpcNetworkManager for each new peer connection in the same way the socket_factory_ is reused. See the bug for more details. Fixed: 1142717 Change-Id: I033e986361a7c3a7acce3a7dea12e1f51c3b3b75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503889Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Commit-Queue: James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#821512}
-
Xianzhu Wang authored
Bug: 1141739 Change-Id: I3b41c6328bf328b6734c6eadc422c45534fe42da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503330Reviewed-by:
Steve Kobes <skobes@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#821511}
-
Mitsuru Oshima authored
This is required because when the virtual desks takes screenshot, old layer is already detached, so it'll be copyed as a black. Bug: 1083951 Test: maually testsed. See bug for repro step. Change-Id: Ia26398d2d88557a70a970748623f665ac065c46d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2501970Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#821510}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Ib233eb5054f8c8d04e34228e04f9ddaee977208e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2504492Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#821509}
-
Aleks Totic authored
All TableNG painting related code: - NGTablePainter family of painters - Legacy methods that support painting - getting correct border widths for collapsed borders. - invalidation in StyleDidChange - visual overflow for table/row - misc paint-specific legacy methods (ex: BackgroundIsKnownToBeOpaqueInRect) Bug: 958381 Change-Id: I6e6b5d0145e51e8819df7958578505a2d04bbcea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494024 Commit-Queue: Aleks Totic <atotic@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#821508}
-
- 27 Oct, 2020 35 commits
-
-
Peter Kasting authored
Bug: 772945 Change-Id: Iade9be1584a696fe14680b829085c02add99d64a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2502779 Auto-Submit: Peter Kasting <pkasting@chromium.org> Commit-Queue: Jun Mukai <mukai@chromium.org> Reviewed-by:
Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#821507}
-
Nate Chapin authored
Change-Id: I014d211b395ec217c72c7b1ff5105a2f44fbfdac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503817 Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Nate Chapin <japhet@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#821506}
-
Xianzhu Wang authored
This reverts commit 80a372d9. Reason for revert: To diagnose performance regressions. Original change's description: > Remove GraphicsLayer::SetNeedsDisplay() > > With unified PaintController, to support SetNeedsDisplay() we would > need to add PaintController mechanism to invalidate all display items > in a range for a GraphicsLayer. Removing SetNeedsDisplay() can avoid > that. We instead use the normal paint invalidation code path. For > needed invalidation, now invalidate the display items of and in the > GraphicsLayer. Some invalidations are not needed because we have > already invalidated the DisplayItemClients. > > Also rename SetContentsNeedsDisplay() to InvalidateContents(), and > SetNeedsDisplayInrect() to InvaldiateRaster() which is only called by > RasterInvalidator. > > Bug: 1132717 > Change-Id: I535cdcc7ee1d07e23a490fdf2aa267573a54d0ba > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2478026 > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > Reviewed-by: Philip Rogers <pdr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#818673} TBR=wangxianzhu@chromium.org,pdr@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1132717, 1140634 Change-Id: Ife45cc8b39b6aac762f228d80634a33b6b4889b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503322Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#821505}
-
Tom Anderson authored
R=sky BUG=1066670 Change-Id: Ibced1b861c9090d4a8b5d49b81f62c4aeec1a6ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473839 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#821504}
-
Thanh Nguyen authored
Rename local search service proxy for the new LSS. Please see go/lss-sandboxing-impl for more details Bug: 1137560 Change-Id: I92a9b38f425462f6b771e835f6afd0cc4666b3a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500382Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Rachel Carpenter <carpenterr@chromium.org> Reviewed-by:
Jia Meng <jiameng@chromium.org> Commit-Queue: Thanh Nguyen <thanhdng@chromium.org> Cr-Commit-Position: refs/heads/master@{#821503}
-
Collin Baker authored
Bug: 1133016 Change-Id: Ia40222beff775014959a6b52ce25ef36893d713d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503816Reviewed-by:
Dana Fried <dfried@chromium.org> Commit-Queue: Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#821502}
-
Christopher Lam authored
Bug: None Change-Id: I231f11b9c2ac392473d6ef837fafdc12a8be7478 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2497902Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#821501}
-
S. Ganesh authored
* Added support to prefix replacement guids with a fixed 'PLACEHOLDER-GUID-' string in the template file. This makes it easier to see the GUIDs that are being replaced. * Added support to regenerate the checked-in IDL files with the replaceable guids. This is needed when the IDL template changes and the checked-in IDL files need to be refreshed. Bug: 1109612 Change-Id: Ie113d2504c1a44f408641e34422bb081733a7458 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495396Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: S. Ganesh <ganesh@chromium.org> Cr-Commit-Position: refs/heads/master@{#821500}
-
Toni Barzic authored
The original cl was reverted due to test failures on dbg build (CL:2500688) - landed CL:2503628 to address the failures. Introduces a concept of partially initialized HoldingSpaceItem - this state will be used when loading items from persistent storage in case the item file system URL cannot immediately be resolved (e.g. if the associated mount point hasn't been loaded yet). HoldingSpacePersistenceDelegate will deserialize persisted items into partial state when they are first loaded from the storage, and "finalize" them when their file system URL can be resolved. Compared to an alternative approach where items whose initialization has to be deferred, this approach keeps the order in which items are added to the model. Updates holding space UI not to show partially initialized items. BUG=1140150 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493323 Commit-Queue: Toni Baržić <tbarzic@chromium.org> Reviewed-by:
David Black <dmblack@google.com> Cr-Original-Commit-Position: refs/heads/master@{#821024} Change-Id: I53bf0140a92e702a9baf59fd0a8be4739973a182 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2504070 Cr-Commit-Position: refs/heads/master@{#821499}
-
Isuru Pathirana authored
This CL updates the VideoCaptureDeviceMFWin/VideoCaptureDeviceFactoryWin implementations to use an NV12 output buffer format when MF D3D11 capture is enabled (for zero-copy capture). This requires ensuring that the input media type set on the Media Foundation CaptureEngine preview sink is NV12. In order to do this, we: 1. Expose PIXEL_FORMAT_NV12 as the sole supported capture pixel format from VideoCaptureDeviceFactoryWin::GetSupportedFormatsMediaFoundation when hardware capture is enabled. 2. Ensure that the VideoCaptureDeviceMFWin implementation sets an MF subtype of MFVideoFormat_NV12 on the video capture preview sink when the requested capture pixel format is PIXEL_FORMAT_NV12. This CL also makes some other minor changes to helpers in video_capture_system_impl.cc and capability_list_win.cc to prevent the NV12 pixel format from being filtered out before reaching the VideoCaptureDeviceMFWin implementation. Change-Id: Ie9bb7c9ef35281b4edecb3007f16faae2a892ac7 Bug: 1120900 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434924 Commit-Queue: Isuru Pathirana <Isuru.Pathirana@microsoft.com> Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Ilya Nikolaevskiy <ilnik@chromium.org> Reviewed-by:
Rafael Cintron <rafael.cintron@microsoft.com> Reviewed-by:
Markus Handell <handellm@google.com> Cr-Commit-Position: refs/heads/master@{#821498}
-
Weiliang Chen authored
In order for OutputSurface and OverlayProcessor to work together, they need to share the same memory and task controller. This CL uses the same data structure for Android WebView to share these controls, so that WebView could use this to enable overlay in the future. R=boliu, rjkroege TBR=vollick@chromium.org Bug: 1093440 Change-Id: I2bcefe178906ede25dc0b962448e2ba6168128a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450494 Commit-Queue: weiliangc <weiliangc@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Cr-Commit-Position: refs/heads/master@{#821497}
-
Kartik Hegde authored
crrev.com/c/2490252 adds new portal states when the connection state is kPortal. Integrate these new states into this routine. BUG=chromium:956783 TEST=unit_tests --gtest_filter=CaptivePortalRoutineTest.* Change-Id: I181127d60179e1439a1fb39a9bc5994ee631c871 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2499623Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Kartik Hegde <khegde@chromium.org> Cr-Commit-Position: refs/heads/master@{#821496}
-
Fergal Daly authored
Also fix 1 test to make it pass. I expect most of these were fixed by the proactive browsing instance swap work, although NavigationControllerBrowserTest.NoHistoryOnNavigationToSameUrl is a bit of a puzzle. There is still another reload failure remaining. Bug: 1102358,1100745,1068965,1064944 Change-Id: I0026f32f7f0ab6a3d75466b53a5815d8bff5facd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494244 Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Auto-Submit: Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#821495}
-
chinsenj authored
Currently overview can create overview items for transient children of the browser. This can cause bugs where if the transient child is destroyed, its respective overview item is as well. This leaves the transient root of this child without an overview item, resulting in this bug. This CL makes it so overview uses the transient roots of any transient child returned by BuildMruWindowList() to create overview items. It also prevents MessageBoxDialog from closing if it deactivates but is being shown in overview. Test: manual + added Bug: 972015 Change-Id: I90b2f94528a4a695a784fd5a1596111dc0103021 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495642 Commit-Queue: Jeremy Chinsen <chinsenj@chromium.org> Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#821494}
-
Regan Hsu authored
TetherControllerImpl will now mark the tether feature ineligible if it is notified by the PhoneModel that the SIM state has changed to anything other than kSimWithReception. Fixed: 1140812 Bug: 1106937 Change-Id: Ia18c5e06c57805541b03b29afea1762e85b8304f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500182 Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#821493}
-
Karthika Pai authored
This CL moves two helper functions that extracts IDs and creates trials and associate IDs into their own file. Bug: 1134444 Change-Id: I056871f2245ba3e9c72a05ffd019f2e96499a45e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500434 Commit-Queue: Karthika Pai <karthikapai@google.com> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#821492}
-
Jesse Schettler authored
Add support for passing in a progress callback to LorgnetteScannerManager::Scan(). This allows clients to receive progress updates for in-progress scan jobs. Bug: 1059779 Change-Id: Ib787c925fbd8033f85e349cb9387168306cd83e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503313Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
-
Minoru Chikamune authored
Context: RemoteFrame’s mojo interfaces should be associated with per-AgentSchedulingGroup task runners instead of per-thread task runners. What this CL does: Use per-AgentSchedulingGroup task runners for AgentSchedulingGroup’s mojo interfaces instead of per-thread task runners. Bug: 1105403 Change-Id: Ia4e2885163bb73a73e4a73d6459f37e68738e18f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2497961Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Minoru Chikamune <chikamune@chromium.org> Cr-Commit-Position: refs/heads/master@{#821490}
-
Minoru Chikamune authored
Context: For MBI, per-AgentSchedulingGroup task runners should be used where appropriate. What this CL does: Use per-AgentSchedulingGroup task runners for instead of per-thread task runners. Bug: 1105403, 1111231 Change-Id: I545fb445f2d52b85c49b01a9c160cc9050fa2cb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2501167Reviewed-by:
-
Minoru Chikamune authored
Context: Per-AgentSchedulingGroup task runners should be used where appropriate. What this CL does: Use per-AgentSchedulingGroup task runners for BrowserInterfaceBrokerProxy’s mojo interfaces instead of per-thread task runners. Bug: 1105403 Change-Id: I692cf7cc11af80e4b875f2d5b7492b44f58ef9ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2501170Reviewed-by:
-
Joel Riley authored
Also exposed in chrome://flags. Bug: 1142601 Change-Id: I0067a298e160510150dd793830a13837ccc083ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500261Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Joel Riley <joelriley@google.com> Cr-Commit-Position: refs/heads/master@{#821487}
-
Zhaoyang Li authored
Includes step by step instructions of writing a new test, talking with app from test, add new tests to suites, running tests. Bug: None Change-Id: I39124524fae4bc56c9f3fbe02bca7d9387bdfefb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503809 Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org> Auto-Submit: Zhaoyang Li <zhaoyangli@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#821486}
-
Dana Fried authored
Modified behavior to avoid calling global function which changes arrow key behavior, rather than method which changes for current widget. Bug: 1140632 Original change's description: > Keyboard accessibility for extensions menu. > > This change switches the extensions menu to enable focus traversal at > the focus manager level, allowing both right/left and up/down key > traversal. > > It also removes > BubbleDialogDelegateView::EnableUpDownKeyboardAccelerators() - which is > only used in one other place - in favor of > FocusManager::set_arrow_key_traversal_enabled(), which also supports > left/right arrows and pre-exists the bubble dialog method. > > These changes mean that when the scroll pane is active in either dialog, > up and down will scroll the pane but left and right arrow keys will > still allow the user to traverse the dialog (at least on Windows and > Linux; on Mac, up/down may still work within the pane). > > Bug: 1140632 > Change-Id: I8ea5bc79e9b9ed2595e9503be1221843c50a7b3e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487904 > Reviewed-by: Peter Bostrom <pbos@chromium.org> > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > Commit-Queue: Dana Fried <dfried@chromium.org> > Cr-Commit-Position: refs/heads/master@{#820456} Change-Id: I3a877c6165f7c993f38ddcaee934ed7790888ca4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503988 Commit-Queue: Dana Fried <dfried@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#821485}
-
David Black authored
Previously showing holding space context menu via ChromeVox (which is performed via Search + M), we didn't update the holding space selection state. Now we do. Bug: 1142890 Change-Id: I65973be470cea22b582df4895d111eeab790ebc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2504192Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#821484}
-
Sergey Ulanov authored
Previously AudioOutputStreamFuchsia wasn't setting stream usage for the AudioRenderer. The usage is required by the system audio service to make correct audio policy decisions for the stream. This change updates AudioOutputStreamFuchsia to SetUsage() appropriately. Bug: 1065605 Change-Id: If96a9b0713b4acdff63035725b7322d1a5ad65a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500431 Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#821483}
-
Mikel Astiz authored
This addresses some leftovers of the old refactoring effort in https://codereview.chromium.org/2569333003. The unittest file is now renamed to match the name of the class under test, which is TitledUrlIndex. Some mechanical refactoring is included such that the unit-tests don't involve BookmarkModel, which is a higher-level layer. A few tests that actually do exercise the integration with BookmarkModel are now moved to BookmarkModelTest. Change-Id: Icf791ce0f88647c6305a4f460d2398cfb63bb155 Bug: 1129524 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2498544Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Eric Noyau <noyau@chromium.org> Reviewed-by:
manuk hovanesian <manukh@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#821482}
-
Edward Lesmes authored
Generate DIR_METADATA files and remove metadata from OWNERS files for directories under //chrome. Bug: 1113033 Change-Id: I24ce584ef282fdd31592d52e6131d381498b2603 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2492668 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org> Cr-Commit-Position: refs/heads/master@{#821481}
-
Yulun Wu authored
Bug: 1142780 Change-Id: I853e483af89d2a4e20da42f7098bda54a842a745 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503820Reviewed-by:
Yulun Wu <yulunwu@chromium.org> Commit-Queue: Yulun Wu <yulunwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#821480}
-
Asanka Herath authored
I haven't touched this in a while and won't have the bandwidth to keep up with //net work. Bug: None Change-Id: If422a56713caa4ceb77ef28eb0c651061945813a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503584 Auto-Submit: Asanka Herath <asanka@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Commit-Queue: Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#821479}
-
Eric Roman authored
Change-Id: I10db78da7491d05138e387f05f09789a5afe99a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503325Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#821478}
-
Aaron Colwell authored
Unable to reproduce flakiness locally. Enabling tests and removing skip test logic for --site-per-process. Code was added to remove this flag in SetUpCommandLine() so the tests can run on all platforms. Bug: 1110497 Change-Id: I552f82d1fe4786e59cd624edf5504b713318d523 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500280Reviewed-by:
-
Lukasz Anforowicz authored
This CL removes entires from manual-fields-to-ignore.txt that are already covered by the exclusions automatically generated by the rewriter tool. This CL was generated semi-automatically by running the rewriter and then: $ cat ~/scratch/automated-fields-to-ignore.txt | \ sed -e 's/#.*//g' | sed -e 's/ *$//g' | \ sort | uniq > ~/scratch/automated.txt $ ... same for ~/scratch/manual.txt $ comm -1 -2 ~/scratch/manual.txt ~/scratch/automated.txt \ > ~/scratch/redundant-fields-to-exclude.txt $ for i in `cat ~/scratch/redundant-fields-to-exclude.txt`; do \ cat tools/clang/rewrite_raw_ptr_fields/manual-fields-to-ignore.txt \ | grep -v "$i" > ~/scratch/tmp cp ~/scratch/tmp \ tools/clang/rewrite_raw_ptr_fields/manual-fields-to-ignore.txt done and then removing stranded comments. Bug: 1069567 Change-Id: Ifd976902da12637cb2698d39c72147135c0b6aff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503324 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by: -
Darren Shen authored
This reverts commit 31c7133d. Reason for revert: Suspecting as cause of failure in https://ci.chromium.org/p/chromium/builders/ci/Mac10.10%20Tests/60360 Apologies if it's an incorrect revert, I will reland your CL if it's not the culprit. Original change's description: > Updater: Implement candidate self-uninstall. > > Bug: 1098934 > Change-Id: I226fc7201e04dfbf1722399434e3900cedc35120 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487940 > Commit-Queue: Joshua Pawlicki <waffles@chromium.org> > Reviewed-by: Sorin Jianu <sorin@chromium.org> > Auto-Submit: Joshua Pawlicki <waffles@chromium.org> > Cr-Commit-Position: refs/heads/master@{#821372} TBR=sorin@chromium.org,waffles@chromium.org Change-Id: Icaef3974d3fbc8325f92bda4df0220ab3f012bc8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1098934 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503529Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#821475}
-
Jeffrey Kardatzke authored
This adds parsing of the VUI and methods for returning size and colorspace information based on the SPS. BUG=chromium:1141237,b:153111783 TEST=media_unitests, media_h265_parser_fuzzer Change-Id: I6959bf7706183f5239a91ea201effeed9a735dfb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495838Reviewed-by:
Sergey Volk <servolk@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com> Cr-Commit-Position: refs/heads/master@{#821474}
-
Edward Lesmes authored
Generate DIR_METADATA files and remove metadata from OWNERS files for directories under //chrome. Bug: 1113033 Change-Id: I427c70063f2d2e21038c3c050f5db34729392fb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491994 Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
-
