- 10 Nov, 2020 40 commits
-
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/goldctl-win-chromium-autoroll Please CC bsheedy@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: bsheedy@chromium.org Change-Id: I4e10a21c929e76850236506ad66789f6df3fa33e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527696Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#825782}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/goldctl-linux-chromium-autoroll Please CC bsheedy@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: bsheedy@chromium.org Change-Id: I03e1c461d4f3b548f90e87a3b846ce91b7798a0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2528954Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#825781}
-
Matt Jones authored
This patch adds the LayoutManager interface which extends the LayoutStateProvider to provide more functionality around adding components (SceneOverlays) on top of the visible layout. This interface adds the following methods - addSceneOverlay(...) - createCompositorModelChangeProcessor(...) The existing LayoutManager has been renamed to LayoutManagerImpl and should no longer be used by feature code. Bug: 1070281 Change-Id: I76839f056ace90b39f7f3008f438d94585d9e096 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2525849Reviewed-by:
Mei Liang <meiliang@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#825780}
-
Jason Lin authored
See the bugs for why we are doing this. Notes: * `tab_id` is removed. `TerminalPrivateAckOutputFunction::Run()` used to use `tab_id` to figure out whether it should actually acknowledge the output on the process --- it should only do so if the sender owns the terminal id. Now that we store the terminal id in the web contents, we don't need it anymore. * We change the signature of api `ackOutput`. It is not going to break anything because only `.../externs/terminal_private.js`, which is also updated in this CL, but not "libapps" is supposed to call it. * Potentially, we should kill the renderer if the validation fails, but we cannot do it for now because libapps might send a invalid ID before it receives a valid one. * `SetLastActiveTerminal()` is used for setting the CWD for a new terminal, but due to a bug, it has been effectively disabled. We don't want this CL to change the CWD behavior so we explicitly disable it here. We will soon have a follow up CL to deal with the CWD feature. Also see https://crbug.com/1113207. Fixed: 1145053, 1144625 Test: new browser tests, and manual tests Change-Id: I0f39c544a28e23df3aeefe98b626c2b94b973af7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519182Reviewed-by:
Ben Wells <benwells@chromium.org> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Mike Frysinger <vapier@chromium.org> Commit-Queue: Jason Lin <lxj@google.com> Cr-Commit-Position: refs/heads/master@{#825779}
-
Manuel Rego Casasnovas authored
This patch stores a boolean instead of the NGConstraintSpace in NGOutOfFlowLayoutPart. That way container_space.HasBlockFragmentation() is only called once for each NGOutOfFlowLayoutPart element. BUG=1091797 Change-Id: I7cb19821e20503210d247e2167b7994308db7dea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526421 Commit-Queue: Manuel Rego <rego@igalia.com> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#825778}
-
Stephane Zermatten authored
Before this change, CheckOnTop would only check the current frame. While this could detect the case where an element covers the goal element, this did not detect the case where an element covers the iframe containing the element. With this change, CheckOnTop requires the target element as well as any iframe containing the target element to be on top (not covered by another element). Bug: b/171463353 Change-Id: I3d32fdff3cb55724fd096de18034e9b4e002cab3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523172 Commit-Queue: Stephane Zermatten <szermatt@chromium.org> Reviewed-by:
Sandro Maggi <sandromaggi@google.com> Cr-Commit-Position: refs/heads/master@{#825777}
-
Arthur Hemery authored
Correcting an inversed condition for recording isolated vs non isolated SharredArrayBuffer constructions. Bug: 1143191 Change-Id: Ibd51e5eb13a3228732c1dad34405101fe824eb40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527059Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Arthur Hemery <ahemery@chromium.org> Cr-Commit-Position: refs/heads/master@{#825776}
-
Ilya Nikolaevskiy authored
This replaces VideoFrameFeedback member in VideoFrame, which was used before to pass resource utilization to the capturer. The follow-up CL would decouple VideoFrameFeedback from media::VideoFrame. Bug: chromium:1134073 Change-Id: I55697a98c0c04d150dae70c53ddd9348f36c4038 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495022 Commit-Queue: Ilya Nikolaevskiy <ilnik@chromium.org> Auto-Submit: Ilya Nikolaevskiy <ilnik@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Cr-Commit-Position: refs/heads/master@{#825775}
-
Roman Aleksandrov authored
Bug: None Change-Id: I33f8caecc9123a377ded08c1ae5fba25d17e2955 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521191Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Roman Aleksandrov <raleksandrov@google.com> Cr-Commit-Position: refs/heads/master@{#825774}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/bc5c4781..aee5f31f Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ie2bca10b907003d0ec372289342462db6559f071 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2528923Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#825773}
-
Alexander Surkov authored
Keep tree formatters generic. Each consumer defines filtering directives on its own: dumptest operaters with platform specific directives and dumptools have own directives. Keep directives logic in consumers AX-Relnotes: n/a Bug: 1133330 Change-Id: I411237bb0a5539bc2642ed29a013648acd003b93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517542Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Alexander Surkov <asurkov@igalia.com> Cr-Commit-Position: refs/heads/master@{#825772}
-
Yuzu Saijo authored
This CL makes bfcache trigger SetDefersLoading() for content::URLLoaderClientImpl() so that the messages are queued in the renderer and get flushed upon resume. Bug: 1137682 Change-Id: I26ff4ed85ce2c869403ffb483067aedb8ebc2f32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462980 Commit-Queue: Yuzu Saijo <yuzus@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#825771}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/goldctl-mac-chromium-autoroll Please CC bsheedy@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: bsheedy@chromium.org Change-Id: Ic2025910d7e2e505e0cba6e46eaedc73187c4a70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2529049Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#825770}
-
arthursonzogni authored
Exhaustively remove all the functions that don't have a caller in the RenderFrameHostImpl class. Bug: 1146469 Change-Id: Id1825ac6634a8768173da680bc58e7b094663f27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523114 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#825769}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/aa1e66743da1..d4e32eb5788c 2020-11-10 changhaohan@chromium.org Update CSSAngle to use value modification helper from UIUtils If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1126178 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ic8c631b3c4916fa9905f75b8a24398528b247e6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2528617Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#825768}
-
Pavol Marko authored
Remove the EcryptfsMigrationStrategy user policy. This is relevant when a user signs in whose home directory is still ecryptfs-encrypted. Managed users: Chrome OS will automatically start migration. Rationale: This behavior has been enforced server-side by auto-setting the EcryptfsMigrationStrategy to MIGRATE since Jan 2020 (b/142814563). Unmanaged users: No behavior change, Chrome OS will ask the user if they want to migrate. Whether the user is managed or not is inferred from the known_user "ProfileRequiresPolicy" flag, because this needs to be known before a potential user policy blob is available. Side effect: It is not possible to trigger minimal migration anymore, because it could only be triggered through enterprise policy. If minimal migration was attempted previously but failed, resuming a regular migration will be attempted instead. This is acceptable because no minimal migration should have been triggered since Jan 2020 (see above), so this case should never happen in practice. This allows us to also remove the known_user flag which was tracking whether minimal migration was attempted. Bug: 832127 Change-Id: I19d4fcd0ed5d61107def0fa32ddcbcee9aaedb5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2513205Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Josh Horwich <jhorwich@chromium.org> Commit-Queue: Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#825767}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/36787dcb4382..a89c6b9a5c5b 2020-11-10 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 61aafe63 to 90258074 (438 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: timvp@google.com Change-Id: I14d9eadc186d6a974a0c59a7a018ea284e31ea7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2528913Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#825766}
-
Devlin Cronin authored
Add support for serializing JS functions to strings, rather than to empty base::DictionaryValues. This will only be done for functions that are marked with the trait serializableFunction in the schema. Add testing for the same. Bug: 1144841 Change-Id: I3990447ff336143a38eb97bf91a90503b0ee5c3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518451 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#825765}
-
Yuichiro Hanada authored
This CL extracts a logic to calculate disallowed/allowed/always_allowed state and enabled/disabled state of ARC IMEs into ArcInputMethodState class from ArcInputMethodManagerService. Bug: 1139332 Test: unit_tests Change-Id: I76a0466b4c7148994e0f0a56327b5b23ffbbc2ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2513315Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#825764}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/38f3d771bd8e..952ef3e06472 2020-11-10 treehugger-gerrit@google.com Merge "tp: add time in activityRestart to startup metric" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I0daddf7b7f8ee9ef3626c98b30336e2df51b13aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2528953Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#825763}
-
Kent Tamura authored
This CL merges LayoutNGTextArea flag and LayoutNGTextField flag into LayoutNGTextControl flag. It makes a future finch experiment easier. Bug: 1040826 Change-Id: Ic277a9ebe23cb3a661c7b9fe56cca5ada717ca5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526644 Commit-Queue: Koji Ishii <kojii@chromium.org> Auto-Submit: Kent Tamura <tkent@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#825762}
-
Sami Kyöstilä authored
This reverts commit 2ed82a41. Reason for revert: Looks like this is causing the Linux perf tests to crash in xlib_support.cc: https://ci.chromium.org/p/chrome/builders/ci/linux-perf/13312 Original change's description: > Set Xlib error handler after GTK X11 initialization > > The default GTK error handler exits the process, which we don't want. > We used to reset the error handler at some point after GTK > initialization, but this became lost after r815319. > > Also refactor the XlibLoader instance to be global so it doesn't have > to be created multiple times for each connection. > > R=sky > > Bug: 1145929 > Change-Id: I73a3f27551534c2262bd8994d33e30fc2a0a4e27 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527743 > Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Cr-Commit-Position: refs/heads/master@{#825585} TBR=sky@chromium.org,thomasanderson@chromium.org Change-Id: Ie9f3614a8773220e0d6d6596d14c858a879a6704 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1145929 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2529152Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#825761}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/e7a31f42cda3..edd94d2b8c50 2020-11-10 adetaylor@chromium.org Fix owners.py all_possible_owners API 2020-11-10 sokcevic@google.com Return HEAD when ref is refs/heads/main If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: Ibdf8ef2c1d6a6d454e3a4ae7fa9e0c397de795fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2528171Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#825760}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/33858054c805..139be0697741 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC hbos@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: hbos@google.com Change-Id: Ifa396027f8d9d66c3b00584b33c31e3c7ce5b7df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2528951Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#825759}
-
Illia Klimov authored
Due to Flash/Plugins deprecation this CL removes UNSANDBOXED_PLUGINS from the SiteSettings page. Bug: 1138156 Change-Id: I443f9aa2626216dc0c1f357e70fb0e3f4e274119 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517688Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Illia Klimov <elklm@google.com> Auto-Submit: Illia Klimov <elklm@google.com> Cr-Commit-Position: refs/heads/master@{#825758}
-
Honglin Yu authored
NoDestructor should be preferred over Singleton according to the comments in singleton.h and https://bugs.chromium.org/p/chromium/issues/detail?id=925323. And this *may* also relate to https://bugs.chromium.org/p/chromium/issues/detail?id=922327 BUG=chromium:925323, chromium:922327 TEST=cq Change-Id: Icb014d0eae9e0032a2a5ca56dcec59cf72300315 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526643Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Honglin Yu <honglinyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#825757}
-
David Roger authored
The AppShortcutManager was not correctly unregistering as a ProfileAttributesStorage observer. The reason is that the AppShortcutManager is destroyed as part of the ProfileManager destruction. At this time, g_browser_process()->profile_manager() already returns nullptr. AppShortcutManager was happily skipping the unregistration in that case, because of test-related logic. I did not repro the crash and verified the fix, but this CL should solve the issue. Fixed: 1145906 Change-Id: I2ad4e574ad128ec920f94978446ae33c8dc73a46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520776Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#825756}
-
dpapad authored
With this CL, HTML imports inovlving chrome-extension:// URLs are correctly translated to JS imports. For example chrome-extension://path/to/folder/foo.html becomes chrome-extension://path/to/folder/foo.m.js This is necessary to unblock CrOS FileManager migration to JS modules. Fixed: 1145876 Change-Id: Ie2e02b6925108db280f626be9c1ad0c261ffd797 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526501 Commit-Queue: dpapad <dpapad@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#825755}
-
Morten Stenshorne authored
Avoid undefined behavior, such as negative values, when casting from double to int. Bug: 1116832 Change-Id: I49d4d5c6e73a9441d20c8a502c3d9d8cff71b7d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2528529Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#825754}
-
Heng-Ruey Hsu authored
In order to support multiple streams for one camera, we need to support multiple clients in camera device context to allocate buffer from corresponding client. Bug: b:151047537 Test: manually Change-Id: I10855309a3dc4a6883af0d852180371e2f807dbe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351930Reviewed-by:
Dan Sanders <sandersd@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Wei Lee <wtlee@chromium.org> Commit-Queue: Heng-ruey Hsu <henryhsu@chromium.org> Auto-Submit: Heng-ruey Hsu <henryhsu@chromium.org> Cr-Commit-Position: refs/heads/master@{#825753}
-
Camillo Bruni authored
- Use the ParametrizedModuletTest for worklet tests - Split ParametrizedModuleTestBase from ParametrizedModuleTest Bug: 1132793 Change-Id: I28f89c0f1c1a1093d43922eaf9e53949ae4e2bf1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465902 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#825752}
-
Antonio Gomes authored
... instead of ash_constants. It is used in default_frame_header.cc, that will be moved to //chromeos/ui/frame next. BUG=1113900 R=jamescook@chromium.org Change-Id: Ibd4417c516ae912964fbd07179912797257d308b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522921 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#825751}
-
Ben Reich authored
The structure of the coverage directory is internal details of the DevToolsListener class, extract the structure into a static function |SetupCoverageStore| to avoid duplication of setup code. R=noel@chromium.org --devtools-code-coverage Bug: 1113941 Test: browser_tests --gtest_filter=*FilesApp* --devtools-code-coverage Test: browser_tests --gtest_filter=*DevToolsListener* Change-Id: Ia5d2a0553eeb791af707734bb5e28d8b3ef1c304 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2528607 Auto-Submit: Ben Reich <benreich@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#825750}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/eba8b028ddbc..38f3d771bd8e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I3bfb221dccb7b80e5bb3cd43ca9cdee9fae8a897 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2528952Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#825749}
-
Kim-Anh Tran authored
Disable to allow for new module linear memory inspector module to land. Bug: chromium:1110202 Change-Id: I7d6ea76a1fd9803f22e04af3aab9fac70befa9ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526442Reviewed-by:
Alex Rudenko <alexrudenko@chromium.org> Commit-Queue: Kim-Anh Tran <kimanh@chromium.org> Cr-Commit-Position: refs/heads/master@{#825748}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/1d532cbd0baa..eba8b028ddbc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I1848bd59a45fb15ad7ffb06a94333d5dacc5649d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2528616Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#825747}
-
Wei Lee authored
This CL fixes a bug that on SWA the intent with shouldHandleResult=false does not finish right after the app startup. Bug: b/172780736 Test: tast run [DUT] camera.CCAUIIntent.* Change-Id: Ie3069660d6e71d505caf4a9922fa1967deafb405 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526854 Commit-Queue: Wei Lee <wtlee@chromium.org> Commit-Queue: Shik Chen <shik@chromium.org> Auto-Submit: Wei Lee <wtlee@chromium.org> Reviewed-by:
Shik Chen <shik@chromium.org> Cr-Commit-Position: refs/heads/master@{#825746}
-
Danila Kuzmin authored
unbinding Bug: 1142565 Change-Id: I4d201961aba5e78ec1c3d9c0291c8bba6cf4c36b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517523 Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#825745}
-
Victor-Gabriel Savu authored
Add LTS to the reported feedback in feedback reports. This will allow queries in Listnr to either include or exclude LTS customers. Bug: chromium:1146354 Change-Id: Iee4c724206666bff804991bf8c00610883ac5cb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521182Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Reviewed-by:
Miriam Zimmerman <mutexlox@chromium.org> Commit-Queue: Victor-Gabriel Savu <vsavu@google.com> Cr-Commit-Position: refs/heads/master@{#825744}
-
Christian Dullweber authored
Close settings activity before loading a URL to try to avoid flakiness. Bug: 1139480 Change-Id: I4e9b617941f07fc3baa313ddf10b6c9cb656990c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526341Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Ehimare Okoyomon <eokoyomon@chromium.org> Reviewed-by:
Andy Paicu <andypaicu@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#825743}
-