GitLab

virtual/gpu/fast/canvas/canvas-blending-gradient-over-pattern.html times out on
Linux and Mac, so labeling as slow.

NOTRY=true
TBR=fserb@chromium.org

Bug: 866850,869276
Change-Id: I973034fa00e46504db0d528b72c726913a46c675
Reviewed-on: https://chromium-review.googlesource.com/1156999
Commit-Queue: Mohammad Reza Zakerinasab <zakerinasab@chromium.org>
Reviewed-by: Mohammad Reza Zakerinasab <zakerinasab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579451}

The header file is obsolete and will be deleted in webrtc cl
https://webrtc-review.googlesource.com/c/src/+/90410.

Bug: webrtc:6854
Change-Id: Ia3dff6686d8135ad54df8436f2c0125472c936bf
Reviewed-on: https://chromium-review.googlesource.com/1156388
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579450}

ResolutionNotificationControllerTest.MultipleResolutionChange.

TBR=tetsui@chromium.org,yoshiki@chromium.org,estade@chromium.org

Bug: 869401
Change-Id: Ic2cd931481cc43ac900c829f8f6b82a4e632ce63
Reviewed-on: https://chromium-review.googlesource.com/1156850Reviewed-by: Roger Tawa <rogerta@chromium.org>
Commit-Queue: Roger Tawa <rogerta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579449}

This reverts commit f9b39463.

Reason for revert: Not meant for m70

Original change's description:
> cros: Disable views login by default
> 
> This CL is targeting only for m69.
> 
> Bug: 869411
> Change-Id: Ie0cf9c8eb0f98b53ac3e7c4fda5585185ce95b9c
> Reviewed-on: https://chromium-review.googlesource.com/1156875
> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
> Commit-Queue: Jacob Dufault <jdufault@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#579432}

TBR=xiyuan@chromium.org,jdufault@chromium.org

Change-Id: I09b0cb12eb8d6c1e66cc7081fe66009e90be4a92
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 869411
Reviewed-on: https://chromium-review.googlesource.com/1156926Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Commit-Queue: Jacob Dufault <jdufault@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579448}

Newer pylint warns when files have trailing blank lines.  Trim them.

Bug: 866772
Change-Id: I34e4325d071fde874558cee68c0460ecde5023c7
Reviewed-on: https://chromium-review.googlesource.com/1147718Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Commit-Queue: Mike Frysinger <vapier@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579447}

The token is required to prevent fingerprinting of receiver IDs across
profiles. It was introduced for Receiver objects sent by via Cast SDK
and is used by Cast MRP in a previous patch. This patch adds the use
of token to DIAL MRP as well.

Bug: 808720
Change-Id: I73bcad3ec361a3b48b0e97850ab4370fdd710418
Reviewed-on: https://chromium-review.googlesource.com/1155799
Commit-Queue: Derek Cheng <imcheng@chromium.org>
Reviewed-by: Takumi Fujimoto <takumif@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579446}

BUG=869185

Change-Id: I9785566ea733c97da198251f752b33a3a9a31e57
Reviewed-on: https://chromium-review.googlesource.com/1155811Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579445}

Change-Id: I7100ad20d78b39c630edeadee1c1ea4fe2970ad4
Reviewed-on: https://chromium-review.googlesource.com/1156143Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579444}

Bug: 814906
Change-Id: I34fea3500218fee452d2c6134002cdb3aa43d071
Reviewed-on: https://chromium-review.googlesource.com/1149085Reviewed-by: anthonyvd <anthonyvd@chromium.org>
Commit-Queue: Mustafa Emre Acer <meacer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579443}

Add a Safe Browsing Interstitial Page for Trick to Bill.

Add a Trick to Bill enum to SBThreatType and
SBInterstitialReason.

Overview CL:
https://chromium-review.googlesource.com/c/chromium/src/+/1148598

Testing:
- SafeBrowsingBlockingPageTest.TrickToBillPage unit test

Bug: 867518
Change-Id: I0f5c342f419c2f326c7f25fa7e965d47ed242bbd
Reviewed-on: https://chromium-review.googlesource.com/1150917Reviewed-by: Varun Khaneja <vakh@chromium.org>
Reviewed-by: Mustafa Emre Acer <meacer@chromium.org>
Commit-Queue: Sarah Chan <spqchan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579442}

This reverts commit 68793bfa.

Reason for revert: SDK appears to make SSH connection to VM flaky.

Original change's description:
> Roll Fuchsia SDK from be1455d02b09 to 0e8488b5f1c0
>
>
> The AutoRoll server is located here: https://fuchsia-sdk-chromium-roll.skia.org
>
> Documentation for the AutoRoller is here:
> https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
>
> If the roll is causing failures, please contact the current sheriff, who should
> be CC'd on the roll, and stop the roller if necessary.
>
>
> CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio
> TBR=cr-fuchsia+bot@chromium.org
>
> Change-Id: Ife1784c580c2b4fb9e19f6a24fcd4111dc0e54e3
> Reviewed-on: https://chromium-review.googlesource.com/1155791
> Reviewed-by: Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
> Commit-Queue: Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
> Cr-Commit-Position: refs/heads/master@{#579219}

TBR=fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com,cr-fuchsia+bot@chromium.org

Change-Id: Ib5f8aab6e5bdf123c9c57b3c29aee1fd0e157f96
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 869452
Cq-Include-Trybots: luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio
Reviewed-on: https://chromium-review.googlesource.com/1155616Reviewed-by: Wez <wez@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579441}

Their use was removed in 6c0aed57.

BUG=829347

Change-Id: Ia5e99e49ba53cb4a416fda37407fdf5faa516f27
Reviewed-on: https://chromium-review.googlesource.com/1156845Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579440}

Remove WebContentsObserver from DisplayCutoutHostImpl

BUG=859241

Change-Id: Icd79a7ae476afe5c5b1e4a778a93b7f411d512cf
Reviewed-on: https://chromium-review.googlesource.com/1130224Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579439}

While we're here, also alphabetize the file.

Bug: none
Change-Id: If6de2987266a4a6272a0eebad5d3562cdde1c07f
Reviewed-on: https://chromium-review.googlesource.com/1156307Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Reviewed-by: Kristi Park <kristipark@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579438}

In stable since M65.

Bug: 657748
Change-Id: I25bd7ae44e3084b3a198eff6bad811118a460d52
Reviewed-on: https://chromium-review.googlesource.com/1156548
Commit-Queue: Emil A Eklund <eae@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579437}

The Bluetooth stack will drop a Connect request while there is a
Connect request pending. The request's callback is never called.

This CL queues concurrent Connect requests to avoid this issue.

Bug: internal 111887604
Test: cast_bluetooth_unittests
      Try concurrent Connect requests, second request returned
      successfully.

Change-Id: I187330f94f75c643c896549d49f8e00a7ff3e195
Reviewed-on: https://chromium-review.googlesource.com/1155998Reviewed-by: Bailey Forrest <bcf@chromium.org>
Commit-Queue: Tiansong Cui <tiansong@google.com>
Cr-Commit-Position: refs/heads/master@{#579436}

Having the response allows the caller to do things like examine the
rcode (which may provide more information about the failure).

Bug: 142918, 506227
Change-Id: I0fb562542ac866d12ad2a8887d8c15c8c8e92a01
Reviewed-on: https://chromium-review.googlesource.com/1152925Reviewed-by: Paul Jensen <pauljensen@chromium.org>
Commit-Queue: Rob Percival <robpercival@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579435}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/45880cd3..e8e10fdf

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I14dbcfd8107ebcb2e5a06fe893bb70de8c9e0a06
Reviewed-on: https://chromium-review.googlesource.com/1156479Reviewed-by: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#579434}

SafeBrowsingContextImpl is ref counted, and its first reference used to
be made in its constructor through base::Bind. The reference is passed
to the IO thread, and released when the task is destroyed.
However, if PostTask failed or the posted task ran soon even before the
constructor has finished, the SafeBrowsingContextImpl instance may be
destroyed before the construction has completed.

Though the SafeBrowsingContextImpl case is safe, even if
`new SafeBrowsingContextImpl` returns a stale pointer, this hits an
sanity check that is being added to base::Bind.

This CL moves the PostTask() out of the constructor, and holds an
reference to the instance while base::Bind is called to avoid the
check failure.

Bug: 866456
Change-Id: Iee58de1e4cd807ff858985f9831e48f4a903bbd4
Reviewed-on: https://chromium-review.googlesource.com/1156332Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579433}

This CL is targeting only for m69.

Bug: 869411
Change-Id: Ie0cf9c8eb0f98b53ac3e7c4fda5585185ce95b9c
Reviewed-on: https://chromium-review.googlesource.com/1156875Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Jacob Dufault <jdufault@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579432}

This patch fixes an issue with the scrim that would cause it to become
invisible if re-shown while hiding. The onAnimationEnd event would
remove the scrim from the tree when it was still needed. This is
resolved by making the animator listener one that is cancel-aware. The
scrim is not removed from the tree if the animation is canceled (if
the animation should end early, the #end() method should be called
instead).

Bug: 865109
Change-Id: I5a83bc486a2798ddca8dca4fefc6a0a340fa1613
Reviewed-on: https://chromium-review.googlesource.com/1156482Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579431}

BUG=chromium:861998
TEST=manual

Change-Id: Icd98a6c5c0d94c7adbb57a3d104b633440b38f09
Reviewed-on: https://chromium-review.googlesource.com/1156394Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Roman Sorokin <rsorokin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579430}

In LayoutNG computing the border outsets turned out to be more expensive
than expected. Change NGBoxFragmentPainter to compute it lazily instead.

Bug: 714962
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I623e0f3a0fd62ee853843ba31e8e4075c0599938
Reviewed-on: https://chromium-review.googlesource.com/1153302Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579429}

https://chromium.googlesource.com/angle/angle.git/+log/67c388e6c04e..2eb65034db71


git log 67c388e6c04e..2eb65034db71 --date=short --no-merges --format='%ad %ae %s'
2018-07-31 jmadill@chromium.org Add Context::getActiveBufferedAttribsMask.


Created with:
  gclient setdep -r src/third_party/angle@2eb65034db71

The AutoRoll server is located here: https://angle-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=fjhenigman@chromium.org

Change-Id: Iae6c8a8f145d787f98512ee6c8311047f987fa91
Reviewed-on: https://chromium-review.googlesource.com/1156744Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#579428}

GetLatestInFlightSurface will return null if fallback surface doesn't
exists which might happen after garbage collection, hence causing
jittering when resizing.
This CL refactor SurfaceManager::GetLatestInFlightSurface to return a
surface in the case when fallback is non-existent.

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: Ib95b4ca3f8819b668022fd9b6942304b07cef340
Bug: 868447
Reviewed-on: https://chromium-review.googlesource.com/1153088Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Reviewed-by: Saman Sami <samans@chromium.org>
Commit-Queue: Andre Kaba <akaba@google.com>
Cr-Commit-Position: refs/heads/master@{#579427}

This is needed for supporting profiling and code coverage reporting on
ChromeOS and Android.

Bug: 843356,865376
Change-Id: I36836a7876c5e9230b33594362ac029bc1670c86
Reviewed-on: https://chromium-review.googlesource.com/1153653Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Abhishek Arya <inferno@chromium.org>
Reviewed-by: Hans Wennborg <hans@chromium.org>
Commit-Queue: Max Moroz <mmoroz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579426}

The FakeServer used in many tests runs on the UI thread (which is very
questionable, but hard to change).

FakeServerHttpPostProvider::MakeSynchronousPost (running on the Sync
thread) posts to the UI thread and waits for a response.
ProfileSyncService::Shutdown (running on the UI thread) waits for the
Sync thread to stop.
If these two events intersect, we get a deadlock between the UI thread
and the Sync thread.

As a workaround, this CL adds a timeout to MakeSynchronousPost.

This was exposed by https://crrev.com/c/1148392, but the problem really
existed all along.

Bug: 856179
Change-Id: I099953f1231fadd4ad4cb845daabfd055e9ab5a2
Reviewed-on: https://chromium-review.googlesource.com/1156587
Commit-Queue: Marc Treib <treib@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579425}

PasswordStoreX now takes 3 backends: a native backend, an unencrypted
LoginDB and an encrypted LoginDB. If the unencrypted LoginDB has data
(because the native backend was previously unavailable), its contents
will be moved into the native backend. If that succeeds, the contents
of the native backend will be moved into the encrypted LoginDB. From
then on, PasswordStoreX will only use the encrypted LoginDB. Progress
is tracked on a user preference.

This migration may take a non-trivial amount of time, therefore the
steps are designed to be safe to repeat if Chrome fails: the source
of the data is not cleared. Also, the encrypted LoginDB is a different
location than the unencrypted one, since distinguishing the two just
from their contents is unreliable.

In a future version, we will clear Chrome's data from the native
backend and move the encrypted LoginDB onto the standard location.

The migration is disabled behind a feature. Enabling the feature will
perform the migration once. If the feature is disabled again, the
store will serve again from the (possibly out-of-date) native backend.
Re-enabling will not repeat a migration for any new data produced while
disabled.

Bug: 571003
Change-Id: I2206b043638ae1484b30ac884c5cf2d0acaea2b8
Reviewed-on: https://chromium-review.googlesource.com/1120165Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Christos Froussios <cfroussios@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579424}

As part of the network servicification effort, histograms were removed
from ResourceLoader in https://crrev.com/c/1122712, and are now added to
ResourceDispatcher in this CL.

Bug: 859546
Change-Id: I1c073098cdc532d067ab69ec98daa0aec1f9c910
Reviewed-on: https://chromium-review.googlesource.com/1145129
Commit-Queue: Bence Béky <bnc@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579423}

Preferences related to Extensions are removed from the persistent
storage list for incognito mode.
After this CL, if these preferences are changed from incognito mode,
they are only stored in memory and won't affect user profile.

Bug: 861722
Change-Id: Id54e7c234961d6814c3bd55692c93a28d2917f84
Reviewed-on: https://chromium-review.googlesource.com/1149370Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579422}

JavaScript event listeners (V8AbstractEventListener) in the DOM were
required to be held alive by an artificial root for Oilpan garabge
collections as they were not properley connected to their JavaScript
wrappers.

This is changed in crrev.com/579039. As a consequence, the root can be
removed. The wrappable (V8AbstractEventListener) will be held alive as
long as the JavaScript wrapper or the C++ wrappable are reachable.

Bug: chromium:843903
Change-Id: I7f509dfd0edd6cdcc485636a59c5e10334e279a6
Reviewed-on: https://chromium-review.googlesource.com/1155122
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579421}

This converts autofill and password manager use Channel-assocaited
interfaces for the AutofillDriver and AutofillAgent mojom interfaces.
This is necessary due to subtle timing dependencies between autofill
IPC and frame IPC (e.g. FrameHostMsg_Detach) which were exposed when
attempting to make changes to mojom message dispatch scheduling.

Bug: 866616
Change-Id: I2b2f521673715b1a6aa7bbb59dad605306b175de
Reviewed-on: https://chromium-review.googlesource.com/1148587
Commit-Queue: Ken Rockot <rockot@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579420}

In Libassistant, the ResourceProvider platform interface got
removed. The alternative way of getting resources is via the
FileProvider. Updated the implementation of the interfaces to
comply with API change.

Bug: b/111924222
Change-Id: I8e29a73f2db0c1bffee39357dbc7e6e4853e84f2
Reviewed-on: https://chromium-review.googlesource.com/1153563
Commit-Queue: Eyor Alemayehu <eyor@google.com>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579419}

This CL renames SvgLocalToBorderBoxTransform to ReplacedContentTransform
and moved its application from SVGRootPainter to ReplacedPainter.

This CL itself should introduce no behavior changes. The purpose of this
CL is in preparation to use transform nodes to implement CSS object-fit
for other type of replaced elements than <svg>.

BUG=866647

Cq-Include-Trybots: luci.chromium.try:linux-blink-gen-property-trees;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I8b6fa6eae7f852a2c275a09836f2fa60334ccbbf
Reviewed-on: https://chromium-review.googlesource.com/1155792Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579418}

Avoid a pointless allocation by having NonMainThreadScheduler own the
helper directly.

R=yutak@chromium.org
CC=haraken@chromium.org

Change-Id: Ib0b414f5556569424263b8bfeb46ec01a80867b1
Reviewed-on: https://chromium-review.googlesource.com/1153050Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579417}

When a ContentSuggestions section is reloaded in the NTP, it is possible
that new sections/items in other sections are added.
This CL makes sure that the collection is updated to take those new
elements into account.

Bug: 866849
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Id474ca33afdafb18871b2bb77e4a94e8bfe1cc68
Reviewed-on: https://chromium-review.googlesource.com/1154986
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579416}

WebViewImpl::ContentsPreferredMinimumSize only needs layout information
for MinPreferredLogicalWidth and ScrollHeight. This patch updates the
lifecycle update call to only do a layout lifecycle update, (similar to
OffsetWidth).

Bug: 868983

Change-Id: Id31b6fb884b2c182b541eab5e8baf61b17579158
Reviewed-on: https://chromium-review.googlesource.com/1153979Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579415}

Bug: 868533
Change-Id: Ieb2d140b7293de20e6c53f6ab497308b4df7dc0f
Reviewed-on: https://chromium-review.googlesource.com/1153665
Commit-Queue: Roger McFarlane <rogerm@chromium.org>
Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579414}

No-try: true
Change-Id: I02b469facfa82771c934d590ae66c36018bd4de2
Reviewed-on: https://chromium-review.googlesource.com/1156594Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579413}

This reverts commit b166ec24.

Reason for revert: Build failure on https://ci.chromium.org/buildbot/chromium.chrome/Google%20Chrome%20Win/34655

Original change's description:
> Reland "Fix to remove /wd4018 (-Wno-sign-compare) for /build/config"
> 
> This is a reland of 1f75f99f
> 
> Original change's description:
> > Fix to remove /wd4018 (-Wno-sign-compare) for /build/config
> >
> > This is a part of effort to remove /wd4018 warning suppression.
> >
> > Master CL is
> > https://chromium-review.googlesource.com/c/chromium/src/+/1152755
> >
> > This CL was uploaded by git cl split.
> >
> > R=dpranke@chromium.org
> >
> > Bug: 868248, 588506
> > Change-Id: I3c31dc8f72266eda85904c4a860e156fadb2a76e
> > Reviewed-on: https://chromium-review.googlesource.com/1152840
> > Commit-Queue: Nico Weber <thakis@chromium.org>
> > Reviewed-by: Nico Weber <thakis@chromium.org>
> > Reviewed-by: Dirk Pranke <dpranke@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#579311}
> 
> Bug: 868248, 588506
> Change-Id: Ic673677dfc0800b361d97f6516ee61887635d9d4
> Reviewed-on: https://chromium-review.googlesource.com/1156164
> Commit-Queue: Nico Weber <thakis@chromium.org>
> Reviewed-by: Nico Weber <thakis@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#579401}

TBR=thakis@chromium.org,dpranke@chromium.org,pmonette@chromium.org,tikuta@chromium.org

Change-Id: I4cab2a6abe6cb7b3f953f0ced3f8368f5c97fac9
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 868248, 588506
Reviewed-on: https://chromium-review.googlesource.com/1156764Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579412}