- 11 Apr, 2019 40 commits
-
-
Jordan Demeulenaere authored
Bug: 933070 Change-Id: Ib921de52cbff937e63c3de568e3d8c9fde7220fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1552833 Commit-Queue: Jordan Demeulenaere <jdemeulenaere@chromium.org> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#649830}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/7ac0d5f348f0..48cce4d9e827 git log 7ac0d5f348f0..48cce4d9e827 --date=short --no-merges --format='%ad %ae %s' 2019-04-11 hta@webrtc.org Parse "max-message-size" parameter from SCTP SDP description Created with: gclient setdep -r src/third_party/webrtc@48cce4d9e827 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:943975 TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I497276362f6e23de56af76336fb5dc2d08592016 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1564370Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#649829}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/3304bd02..43d68733 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ia9a189d80e5fd0fdec13d8e725dd182088160feb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1564210Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#649828}
-
Clemens Arbesser authored
[Autofill Assistant] Fixed terms & conditions radio buttons initially not triggering the listener notification. This is a hotfix for b/130205250. A proper fix is part of the larger PR refactoring: http://crrev/c/1538294 Bug: b/130205250 Change-Id: I3f28085b568dd73889ad989551b04a570226f2ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1564151Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Commit-Queue: Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#649827}
-
Lutz Justen authored
The KerberosCredentialsManager is a layer on top of the Kerberos daemon D-Bus client (KerberosClient). It should be used to add/remove accounts, set configuration and authenticate. It makes sure that Kerberos tickets get put into a place where GSSAPI finds them, so Kerberos web authentication works. BUG=chromium:933798 TEST=Ran unit tests and ExistingUserControllerActiveDirectoryTest.* after temporarily enable disabled tests. Change-Id: I4287c269677322436f6809d07cc14105390397b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1511397 Commit-Queue: Lutz Justen <ljusten@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#649826}
-
Ioana Pandele authored
This case was previously handled by the hiding logic of the autofill popup. Since the generation popup's handling logic has been separated from the autofill popup, this needs to be handled by the passwords code. Bug: 949090 Change-Id: I68ecec3c7eef983ab7d1f3ddcd987f8383422f11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1552851 Commit-Queue: Ioana Pandele <ioanap@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#649825}
-
Jan Krcal authored
This CL adds debug logs to better understand why this integration test is flaky on Mac. Bug: 917498 Change-Id: Ibba39c5e72a5f543fea6ce9b6c0a2d475246f656 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1563854 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Auto-Submit: Jan Krcal <jkrcal@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#649824}
-
Kush Sinha authored
Navigating to Gaia URLs like /AddSession opens the Chrome OS Account Manager (for adding a session) but we want to ensure that this does not happen for background navigations. Please check the attached bug for context. Bug: 945218 Change-Id: I0cafbe62b0215a9bcd9e8190031c9baab9c96466 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1561139Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Kush Sinha <sinhak@chromium.org> Cr-Commit-Position: refs/heads/master@{#649823}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/71ec39e355a8..7ac0d5f348f0 git log 71ec39e355a8..7ac0d5f348f0 --date=short --no-merges --format='%ad %ae %s' 2019-04-11 sprang@webrtc.org Replace usage of old SetRates/SetRateAllocation methods Created with: gclient setdep -r src/third_party/webrtc@7ac0d5f348f0 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Iea4e5a2c44dbc0fa78dfd2da34e86c26500a0504 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1563618Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#649822}
-
Nicholas Verne authored
Now says "Connect to Linux" Bug: 951522 Change-Id: I31ab3abc9bbe1dc1420e453fb2b2644963862647 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1563533Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Commit-Queue: Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#649821}
-
Jérôme Lebel authored
Adding dispatcher to GoogleServicesNavigationCoordinator and AdvancedSigninSettingsCoordinator, to be able to open links from the advanced sign-in settings. Bug: 883075, 948681 Change-Id: I18db56209daa32a5b1c3ad6e7b2c26878b51c0f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559310Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#649820}
-
Hirokazu Honda authored
CloneVideoFrameLayout is not specific function for image processor client. There is a possibility to use in any test code. Move it to video_frame_helpers.h. Bug: None Test: video_decode_accelerator_unittest w/wo video frame validator Test: video_decode_accelerator_tests w/wo video frame validator Change-Id: I92e96296b378de248f441ca416246002e102c263 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1563594 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
David Staessens <dstaessens@chromium.org> Cr-Commit-Position: refs/heads/master@{#649819}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 588b54ad. With Chromium commits locally applied on WPT: 0a8f3ffa "Use testdriver Action API in WPT pointerevent touch tests - Part 2" adc34f41 "Fix web_test pointerevent_coordinates_when_locked on wpt" 8659792f "[WPT] Move wrapResult to common.js and clarify requestVia*() return values" e525003f "Do not resume a suspended BaseAudioContext when AudioWorklet starts" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Ifab6e41383abd685d905bfbb5ed6640544a9b7be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1563912Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#649818}
-
Henrique Ferreiro authored
As advised in [1], this CL ports calls to Foo::Create() factory functions to use MakeGarbageCollected<Foo> from classes in //third_party/blink/renderer/core/svg. [1] https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/iJ1bawbxbWs/vEdfT5QtBgAJ Bug: 939691 Change-Id: I7b74b0f26f81eb266512b2a639d5bc62f300b77a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1561092Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Cr-Commit-Position: refs/heads/master@{#649817}
-
David Jean authored
Also fixes memory leaks, thanks rohitrao@ for pointing this out. Bug: 907527 Change-Id: I3252451e30733df8d0d952b8ed9a440b965e19ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1557017 Commit-Queue: David Jean <djean@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#649816}
-
Kamila Hasanbega authored
This reverts commit b6e4771b. Reason for revert: The reviews from UI and Testing are still ongoing, so disabling the feature for M74. Original change's description: > Enabled AndroidSiteSettingsUIRefresh flag > > Enabling AndroidSiteSettingsUIRefresh flag after approval in Beta. > > Bug: 933701 > Change-Id: If6908af06f78424e3e6cecae665b2b2d2410c8bc > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1532227 > Reviewed-by: Balazs Engedy <engedy@chromium.org> > Commit-Queue: Kamila Hasanbega <hkamila@google.com> > Cr-Commit-Position: refs/heads/master@{#642905} TBR=engedy@chromium.org,hkamila@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 951700 Change-Id: I2e4b7f54e4fc90ab025d0794ef1592bcd9638ac9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1563932Reviewed-by:
Balazs Engedy <engedy@chromium.org> Commit-Queue: Kamila Hasanbega <hkamila@google.com> Cr-Commit-Position: refs/heads/master@{#649815}
-
Nikita Podguzov authored
Add PIN settings section with two components there: PIN checkbox and cr-input for its value. Add binding from UI to settings values and vice versa. Bug: 848942 Change-Id: Icbba0dc319f0666d0676a1fad5e0f59b4d518dd5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526263 Commit-Queue: Nikita Podguzov <nikitapodguzov@google.com> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#649814}
-
Oskar Sundbom authored
When making a low-latency output stream, AudioManagerMac ensures it is created with the current hardware sample rate of the device. This CL ensures the requested buffer size is adjusted accordingly, to maintain the requested latency. Since there's only a single buffer size per device per process on Mac, this also means that requesting playback with 10 ms buffers at different sample rates will now require less rebuffering. Change-Id: I6bd363b131017b0df2747b4db089135c1ae56d42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1376489Reviewed-by:
Max Morin <maxmorin@chromium.org> Commit-Queue: Oskar Sundbom <ossu@chromium.org> Cr-Commit-Position: refs/heads/master@{#649813}
-
Jan Krcal authored
For communication between the controller of a sync data type (running always on the UI sequence) and the actual sync processor (running potentially on backend sequences) we use proxy delegates that take care of posting tasks across sequences. This is not needed for data types that run on the UI sequence. This CL makes use of the already existing ForwardingModelTypeControllerDelegate for the USER_EVENTS sync data type. This has many caveats because the delegate gets fetched immediately in some browser unit-tests and thus: - The FakeUserEventService has to provide a fake bridge and a fake processor (that provides a null delegate). This in turn revealed a previous BUILD.gn hack so the fake user event service needs to move into a separate test_support build target. - on ios, the SessionSyncService has to provide a non-null GlobalIdMapper to make the UserEventService constructor happy. Bug: 867801 Change-Id: I47845732e9076e21544fba296323088750fff411 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1349690 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Auto-Submit: Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#649812}
-
Jordan Demeulenaere authored
This CL improves the support of wrapped BottomSheetContent by: * ensuring that we don't force the wrapped content height to be equal to the BottomSheet height. * introducing a SizeListenable interface than can be implemented by content views to notify when their size changed. This can be used by contents whose height is animated. Bug: 933070 Change-Id: Ib9b11e239f6c24e1bcbe57303a9c4ce5e8078723 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1552844 Commit-Queue: Jordan Demeulenaere <jdemeulenaere@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#649811}
-
Jan Krcal authored
This CL deals with flakiness in sync integration tests for autofill wallet metadata. These tests timeout while waiting in nested RunLoops. The previous attempt to make the loops nestable did not work as expected so this CL implements a more robust solution -- making sure we never nest these RunLoops. Bug: 921386 Change-Id: I2ba640f3f22e5f727345ffb76f7cc811e1671e42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1563930 Auto-Submit: Jan Krcal <jkrcal@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#649810}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/f4c3f4562eee..c005c9acf051 git log f4c3f4562eee..c005c9acf051 --date=short --no-merges --format='%ad %ae %s' 2019-04-11 cwallez@chromium.org Metal: Fail BackendConnection creation when Metal isn't supported Created with: gclient setdep -r src/third_party/dawn@c005c9acf051 The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:852089 TBR=cwallez@chromium.org Change-Id: I9e6c36dadbd2a6d12db4bdddcb3b81e0fdb09a98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1563718Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#649809}
-
David Jean authored
Bug: 951437 Change-Id: Ib25d69f2dbd3ff73240bb21e50bed4291feb0404 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1563853Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: David Jean <djean@chromium.org> Cr-Commit-Position: refs/heads/master@{#649808}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/80eff54147f2..6d60534e95d8 git log 80eff54147f2..6d60534e95d8 --date=short --no-merges --format='%ad %ae %s' 2019-04-11 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update go_deps asset Created with: gclient setdep -r src/third_party/skia@6d60534e95d8 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=egdaniel@chromium.org Change-Id: I97455aef5b25d750706bb5fc68fd35a9c0f73806 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1563717Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#649807}
-
Wei-Yin Chen (陳威尹) authored
In TabGroupModelFilter, after closeTab() is called, getRelatedTabList() can have NullPointerException. Now it won't crash. TODO: the behavior of closing the last tab is still not entirely correct. Bug: 949073 Change-Id: Ie0da62d19dbdf98b43ca77d3a9f1802e78d43272 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559356Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#649806}
-
Manu Cornet authored
Change-Id: I33be69b601f18ead14c2ffc4395583ea9673166b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559420Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Commit-Queue: Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#649805}
-
Umesh Patil authored
Bug: b/130310317 Change-Id: Ife5676ea96057d2409517d4264e9678af396a3fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1562763 Commit-Queue: Umesh Patil <upatil@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#649804}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/aaccc8a44bdb..d27288f5266a git log aaccc8a44bdb..d27288f5266a --date=short --no-merges --format='%ad %ae %s' 2019-04-11 benjhayden@chromium.org Migrate chart-base from dom-module to Polymer.html Created with: gclient setdep -r src/third_party/catapult@d27288f5266a The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:950011 TBR=skyostil@chromium.org Change-Id: Ic1651dce522b2de576525266602539aab49711d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1563910Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#649803}
-
Ahmed Mehfooz authored
Add Highlight Path for Collapse Button Focus Bug: 922423 Test: Manual Test on PixelBook Change-Id: If37e818714ccbd5248e2257e346378b3d848bbc7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1542562 Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Reviewed-by:
Tim Song <tengs@chromium.org> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#649802}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/4d657d5e894a..80eff54147f2 git log 4d657d5e894a..80eff54147f2 --date=short --no-merges --format='%ad %ae %s' 2019-04-11 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 f39b4f0280ef..e6b23e45b380 (7 commits) 2019-04-11 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 1b121674..f8764798 (366 commits) Created with: gclient setdep -r src/third_party/skia@80eff54147f2 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=egdaniel@chromium.org Change-Id: I9ac067efd5f3656117739e4cf1e97c7cec692e3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1563715Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#649801}
-
Noel Gordon authored
Referring to self works but confuses some; just say window. And these one would use globalThis, but it's not shipped everywhere yet. Bug: 935285 Change-Id: If70c05a35563a4545376eeea85dcebd3ae2c09fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1563532Reviewed-by:
Alex Danilo <adanilo@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#649800}
-
Ahmed Mehfooz authored
Add Highlight Path for Sign out Button Focus Change ConfigureTrayPopupButton to always draw focus on highlight path Bug: 922423 Test: Manual Test on PixelBook Change-Id: I34751c84ed06933d81bc77062ac9eca8f20f3ab6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1542468 Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Reviewed-by:
Tim Song <tengs@chromium.org> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#649799}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/dc0c991440db..aaccc8a44bdb git log dc0c991440db..aaccc8a44bdb --date=short --no-merges --format='%ad %ae %s' 2019-04-11 benjhayden@chromium.org Migrate cp-input to es6 module Created with: gclient setdep -r src/third_party/catapult@aaccc8a44bdb The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:950011 TBR=skyostil@chromium.org Change-Id: I72104d7ffa4179b8f08f64e60c9bd7a823b0c6ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1563714Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#649798}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/408a3c63d37b..71ec39e355a8 git log 408a3c63d37b..71ec39e355a8 --date=short --no-merges --format='%ad %ae %s' 2019-04-11 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision bc377d9b..ca726156 (649669:649772) 2019-04-10 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 19364ba5..bc377d9b (649524:649669) Created with: gclient setdep -r src/third_party/webrtc@71ec39e355a8 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:None,chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I35cd82f67601f3da39143baa226b81c2017cee7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1563712Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#649797}
-
liberato@chromium.org authored
When analyzing the learning results, it's helpful to see the effect of the amount of training data on the quality of the predictions. However, DistributionReporter only reports the results as one confusion matrix per LearningTask. This merges the predictions from models with potentially wildly different amounts of training data, making it hard to see how the model's ramp up time differs from its steady state performance. This CL lets DistributionReporter report confusion matrices that are split up by the total weight of the training data used to train the model that made the prediction. The UMA x-axis is divided into buckets, numbered 0 to 15. The bucket number is provided in the label name for the ByTrainingWeight histogram. Which bucket is used is based on the total weight of the training set used to train the model. By default, bucket 0 will report the confusion matrix for models trained on [0, 9] examples. Bucket 1 will report [10, 19] examples, etc. Bucket 9 will report [90, 99]. The overflow bucket, bucket 10, will report 100 and up. This was chosen to match the default maximum training set size of 100, if each example in the set has the default weight of 1. This CL also modifies LearningHelper to report the weighted task results in buckets of 50000 frames each, such as [0-49999] for all tasks that weight examples by the number of frames. Last, this CL renames the histograms to: Media.Learning.BinaryThreshold.Aggregate.$LEARNING_TASK_NAME for the total, aggregate confusion matrix from all predictions (i.e. this is the same as it reported before). Media.Learning.BinaryThreshold.ByTrainingWeight.$LEARNING_TASK_NAME for the bucketed-by-weight matrices described above. Change-Id: I75953747b62ebefd9d7fa4f427489f683e608117 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1557077 Commit-Queue: Frank Liberato <liberato@chromium.org> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#649796}
-
Mikel Astiz authored
Prior to this patch, the SendTabToSelf bridge leveraged the LocalDeviceInfoProvider interface offered (and owned) by DEVICE_INFO. However, all the bridge is interested in is knowing about the name of the local device, which can be done with a simple function call to GetSessionNameBlocking(). Bug: 922971 Change-Id: I6e5cda32028f36239c80f6448180d9d9d6bfc17e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1561124 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
sebsg <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#649795}
-
Jeevan Shikaram authored
Change the host URL of App Management from chrome://apps to chrome://app-management. Bug: 949397 Change-Id: I84679310872fd1d74ceef20b58f335e99f81aaca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1556863Reviewed-by:
calamity <calamity@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Jeevan Shikaram <jshikaram@chromium.org> Cr-Commit-Position: refs/heads/master@{#649794}
-
Marc Treib authored
instead of just the ServerConnectionCode and the net error code. For now, this makes sure that the connection code and the net error are always updated together and thus remain consistent. Later, it will also allow us to expose the http error code as well. Bug: 842096 Change-Id: I41b2dfae80b55c69ae3693ac2a8c6d6b8fa2547e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560195 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#649793}
-
Marc Treib authored
Previously, the actual .proto files in /protocol/ were already in their own build file and target, but the .h/.cc files next to them were in the main sync target. This CL creates a new /protocol:util target and moves those files there. Bug: 947443 Change-Id: If20d8021b61c482af30f5ff60bff7614d94bfab8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1561106 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Auto-Submit: Marc Treib <treib@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#649792}
-
Hirokazu Honda authored
CreatePlatformVideoFrame in video_frame_helpers.h almost delegates CreatePlatformVideoFrame in media/gpu/linux/platform_video_frame_utils.h. We remove the function in media/gpu/test to reduce the code size Bug: None Test: video_decode_accelerator_unittest w/wo video_frame_validator Test: video_decode_accelerator_tests w/wo video_frame_validator Change-Id: Ice7ed5b099104d613456692c43ae8df65e67a5cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1563531Reviewed-by:
David Staessens <dstaessens@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#649791}
-