- 17 Nov, 2020 40 commits
-
-
Philipp Hancke authored
BUG=webrtc:12181 Change-Id: Ifaa94e2ac7124a7c275093059c7f67790009aacc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542382 Commit-Queue: Henrik Boström <hbos@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#828090}
-
Takashi Sakamoto authored
This reverts commit 86556051. Reason for revert: suspect causing "generate_build_files" failure on builder "win-chrome" and "win64-chrome" First detected build: https://ci.chromium.org/p/chrome/builders/ci/win64-chrome/10142 https://ci.chromium.org/p/chrome/builders/ci/win-chrome/17094 Sample log: --- ERROR at //chrome/browser/win/conflicts/incompatible_applications_browsertest.cc:21:11: Can't include this header from here. #include "chrome/browser/browser_process.h" ^------------------------------- The target: //chrome/browser/win/conflicts:browser_tests is including a file from the target: //chrome/browser:browser_process --- Original change's description: > Extract browser_process.h/cc into own gn target > > This CL pulls out browser_process.h and browser_process.cc into their > own gn target so that other gn targets can depend on it without creating > cyclic dependencies with //chrome/browser:browser. > > This is required for CL: > https://chromium-review.googlesource.com/c/chromium/src/+/2528519 > > Bug: 1147410, 883570, 925153 > Change-Id: I17ef1f0b1683c4abb7588a6ef24ec89f15647545 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2529309 > Commit-Queue: Alan Cutter <alancutter@chromium.org> > Reviewed-by: Filip Gorski <fgorski@chromium.org> > Reviewed-by: Glen Robertson <glenrob@chromium.org> > Auto-Submit: Alan Cutter <alancutter@chromium.org> > Cr-Commit-Position: refs/heads/master@{#828077} TBR=fgorski@chromium.org,alancutter@chromium.org,glenrob@chromium.org Change-Id: Idbbe592586e2469f59b9d7b51bf584bd94aa86e8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1147410 Bug: 883570 Bug: 925153 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543169Reviewed-by:
Takashi Sakamoto <tasak@google.com> Commit-Queue: Takashi Sakamoto <tasak@google.com> Cr-Commit-Position: refs/heads/master@{#828089}
-
Keishi Hattori authored
Use nullptr instead of NULL for places that gives errors when we do the MiraclePtr rewrite. The error is error: conversion from 'int' to 'CheckedPtr<>' is ambiguous Bug: 1073933 Change-Id: Idcdbf9cc986bd03080d0d00ad0556ee80fc4fcdd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537451 Commit-Queue: Keishi Hattori <keishi@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Etienne Bergeron <etienneb@chromium.org> Cr-Commit-Position: refs/heads/master@{#828088}
-
Melissa Zhang authored
This reverts commit f878d2a2. Reason for revert: Re-enabling flag for M89 Original change's description: > Revert "[Sharesheet] Run file manager browser tests with sharesheet enable." > > This reverts commit efbf947b. > > Reason for revert: Reverting because we are disabling sharesheet flags by default. > Original change's description: > > [Sharesheet] Run file manager browser tests with sharesheet enable. > > > > This CL updates the option.enable_sharesheet default value to be true to > > run all tests with sharesheet enabled. This is because we turn on the > > sharesheet flags by default. > > > > BUG=1097623 > > > > Change-Id: I8714da4bffa30992ca0caf40a34b5237423c34b3 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461666 > > Reviewed-by: Luciano Pacheco <lucmult@chromium.org> > > Commit-Queue: Maggie Cai <mxcai@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#816074} > > TBR=lucmult@chromium.org,mxcai@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 1097623 > Change-Id: I48580601e1287ae27b3c8be32e199963b8cdc713 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2501164 > Reviewed-by: Melissa Zhang <melzhang@chromium.org> > Reviewed-by: Noel Gordon <noel@chromium.org> > Reviewed-by: Maggie Cai <mxcai@chromium.org> > Commit-Queue: Noel Gordon <noel@chromium.org> > Commit-Queue: Melissa Zhang <melzhang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#821095} TBR=noel@chromium.org,lucmult@chromium.org,mxcai@chromium.org,melzhang@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1097623 Change-Id: I58c0f13790f66cf337058864eec850078a7ecfa7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543862Reviewed-by:
Melissa Zhang <melzhang@chromium.org> Commit-Queue: Melissa Zhang <melzhang@chromium.org> Cr-Commit-Position: refs/heads/master@{#828087}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/89e3ceea..15247228 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I42812930272783c750b5448cc2318e2d9f1d869b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543316Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#828086}
-
Ryan Keane authored
This CL adds DEPS for CmaBackendProxy: - Protobuf is needed for processing of messages sent to/from gRPC (in a future CL) - Openscreen is needed for proto files Change-Id: I376015023915d4ba96a77fee6604726d3b450a72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537231Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Commit-Queue: Ryan Keane <rwkeane@google.com> Cr-Commit-Position: refs/heads/master@{#828085}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1605538580-6a865849c18026af9e6bfd8c91f845d03275941b.profdata to chrome-win64-master-1605560272-77c0d8d0117a28bac6ffdb0ad2fa6b677cbad6f9.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I3ed12a38b3649cf90286526a677f16b760a01765 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543446Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#828084}
-
Anand K Mistry authored
In OpenDecoderOnMediaThread(), the error callback to media::BlockingUrlProtocol is being bound to a stack variable. However, the BlockingUrlProtocol (and callback) outlives the function. So any read error that occurs later, such as in AssistantAudioDecoder::Decode(), will cause a write to the out-of-scope variable, causing stack corruption. Bug: None Change-Id: I1149e48416c1a6ca2d8ddd9d9f124cf3bb6d5f8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542930Reviewed-by:
Jeroen Dhollander <jeroendh@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Anand K Mistry <amistry@chromium.org> Cr-Commit-Position: refs/heads/master@{#828083}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/2c5b040b5c2a..f2bc3b3edd6f 2020-11-16 enga@chromium.org Print warning if errors occur and no error callback has been set 2020-11-16 cwallez@chromium.org Metal: Wrap NS classes and protocols in NSRef. 2020-11-16 enga@chromium.org Remove --skip-validation test flag from Dawn tests If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC kainino@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: kainino@google.com Change-Id: If1b833528e879683bb77019c693892a54b2c8769 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543200Reviewed-by:
-
Mitsuru Oshima authored
This is cleaner tha altering opacity. Bug: 1147187 Change-Id: I7b547b570f06280b6dfccb8ac62afe160151f0f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2525363Reviewed-by:
Malay Keshav <malaykeshav@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#828081}
-
Patrick Monette authored
Bug: 971272 Change-Id: I56b43e5119db30fae638be3503a2c990241e5430 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530215 Commit-Queue: Patrick Monette <pmonette@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#828080}
-
Michael Hansen authored
This sets initial focus to the device name input on the onboarding page. Focus is set manually because the page is initially hidden when the dialog loads, preventing the 'autofocus' attribute from working. Fixed: 1148529 Change-Id: I57a0a7a092591c0b29fe64be60adfdd635e0e141 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2541644 Commit-Queue: Michael Hansen <hansenmichael@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#828079}
-
Yu-Hsuan Hsu authored
Create a virtual device when two nodes share the same device because a pinned stream only can pin to a device not a node. The code are modified from ProcessVirtualDeviceName in audio_manager_chromeos.cc. BUG=b:173113548 Change-Id: Ie0d2ecd8c405aebb94e947c8150b2c47346411b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2534994Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Yu-Hsuan Hsu <yuhsuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#828078}
-
Alan Cutter authored
This CL pulls out browser_process.h and browser_process.cc into their own gn target so that other gn targets can depend on it without creating cyclic dependencies with //chrome/browser:browser. This is required for CL: https://chromium-review.googlesource.com/c/chromium/src/+/2528519 Bug: 1147410, 883570, 925153 Change-Id: I17ef1f0b1683c4abb7588a6ef24ec89f15647545 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2529309 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
Glen Robertson <glenrob@chromium.org> Auto-Submit: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#828077}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/598b98fe2b9b..b7e7aba113f5 2020-11-16 michael.liao@microsoft.com [Data Grid]: Fix narrator support for Data Grid tables If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1146241 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Id7a1cd5905fccc87cf9d9229642c6375155c0418 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543304Reviewed-by:
-
David Bienvenu authored
This is the list of directories excluded from presubmit checks for base::Bind, base::Closure, and base::Callback. Bug: 1007807 Change-Id: I3709ef9dff97beabc02c9cc4d90763bfe557b39c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543445Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: Ide7aa804b5ddea0fffdb80c57a6285e20ed1fe07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543310Reviewed-by:
-
Nancy Wang authored
BUG=1083331 Change-Id: I281b0673b84c3ddcf518a42790defeb489554e9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542929 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#828073}
-
Jacob Kopczynski authored
Move its builders into official.chrome.continuous, remove them, or move them into the new group chromeos.continuous Bug: chromium:1127088 Change-Id: Id6b6449237fd1c384cb716f2b72c837cfddcfe0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543322Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Auto-Submit: Jacob Kopczynski <jkop@chromium.org> Cr-Commit-Position: refs/heads/master@{#828072}
-
Joey Arhar authored
If you call AbortSignal.abort() and then pass that AbortSignal to addEventListener, it shouldn't add the event listener. It currently adds the event listener and still runs the handler, and this patch stops it from adding the listener in that case. Fixed: 1149553 Change-Id: I7aee86d3fb2901947054c66d50e2aef1bb9467bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2541503 Auto-Submit: Joey Arhar <jarhar@chromium.org> Commit-Queue: Mason Freed <masonfreed@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#828071}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=lakpamarthy@chromium.org Change-Id: Ia1de93b4a1f628fd0598d81e6f969ae569faa3f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543368Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#828070}
-
Lukasz Anforowicz authored
Bug: 888079 Change-Id: Ia471fbadb864570f5aa48e0ca032ea5d889a0d48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533280 Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#828069}
-
Noel Gordon authored
Initialize this.backgroundPage_ with new BackgroundWindowSWA() fake if Files app is running in the SWA container. window.BackgroundWindowSWA || null is used to pass Closure compile for current Files app (there are no extern defines for the SWA fakes). No change in Files app behavior. Test: browser_tests --gtest_filter="*launchFilesAppSwa*" Bug: 1113981 Change-Id: Ia079ea266583afd5a2ea67412758a77939327c8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542931Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Alex Danilo <adanilo@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#828068}
-
Jesse McKenna authored
This change migrates uses of base::Bind to BindOnce/BindRepeating, and uses of base::Callback to OnceCallback/RepeatingCallback, in c/b/chromeos/base/locale_util*. Please see crbug.com/714018 for full details about the migration. Bug: 1148570 Change-Id: If16174080f643fddcd5c2d1c1ca86417c5b0b913 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536473Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Jesse McKenna <jessemckenna@google.com> Cr-Commit-Position: refs/heads/master@{#828067}
-
Harry Cutts authored
This CL adds a new setting for pointing stick sensitivity, with a corresponding slider on the pointers subpage. If the flag is disabled, changes to the mouse sensitivity are copied to the pointing stick setting as well. See go/cros-pointing-stick-settings (Googlers only, sorry) for the design doc. Bug: 1114828 Test: check the new slider changes pointer speed Change-Id: I76d49f66f259276bb90427b4b32e00b415e328f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487253 Commit-Queue: Harry Cutts <hcutts@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Michael Spang <spang@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
-
Gavin Williams authored
This change makes sure that on all platforms each expected destination icon is tested for. Bug: 1146550 Change-Id: I79a2c4407c8439d9988534b2f9e3ddbd99509a69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2539669 Commit-Queue: Gavin Williams <gavinwill@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#828065}
-
Yutaka Hirano authored
We had to calculate https://fetch.spec.whatwg.org/#concept-request-response-tainting in core/fetch because the CORS logic implemented in ThreadableLoader didin't support the concept. Now the CORS logic in /services/network calculates reponse's type, so we can use the value. Bug: None Change-Id: I98b56e1d79a73e364a7bec709e8cc4437131b261 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537522 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Auto-Submit: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Dominic Farolino <dom@chromium.org> Cr-Commit-Position: refs/heads/master@{#828064}
-
Leo Lai authored
Since chromium:1109629, eula screen doesn't show the owner password but it still tryies to fetch the password before showing the security system settings. Thus, cleaning it up for sake of security as well as for product excellence. Also, it is part of steps getting rid of `TpmGetPassword()` D-Bus method. BUG=b:172748724 BUG=b:168852740 BUG=chromium:1109629 TEST=browser_tests. Change-Id: If5c0829658753aacadc1dfc3df7d054e6f458851 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536657 Commit-Queue: Leo Lai <cylai@google.com> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#828063}
-
Mitsuru Oshima authored
Intoduce WMHelper::AppPropertyResolver to populate window properties for given |app_id| and |startup_id". Move the code to identify AppType property to app service directory. EXO should be generic window/composition server and should is a generic window server and should interpret the application id. Bug: None Test: covered by unittest Change-Id: I134c4071a515a0b9bdee7fbb17d1487c2eb60b95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526500 Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Nic Hollingum <hollingum@google.com> Reviewed-by:
Yury Khmel <khmel@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#828062}
-
Fergal Daly authored
This reverts commit bea26525. Reason for revert: This debugging has made it into M88 but it's a too noisy to allow into the release. This revert will be cherry- picked and then the debugging will be restored and improved. Original change's description: > Add DumpWithoutCrashing to try find navigations that later hit a CHECK. > > > > Bug: 1146573 > Change-Id: I695cecab30b60028a6003245da150b1a72089706 > Cq-Do-Not-Cancel-Tryjobs: true > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531334 > Commit-Queue: Fergal Daly <fergal@chromium.org> > Reviewed-by: Alex Moshchuk <alexmos@chromium.org> > Auto-Submit: Fergal Daly <fergal@chromium.org> > Cr-Commit-Position: refs/heads/master@{#826624} TBR=alexmos@chromium.org,fergal@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1146573 Change-Id: I8b1c55e206f1b2b0353df2eb8f303b18efd13bc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543523Reviewed-by:
Fergal Daly <fergal@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Fergal Daly <fergal@chromium.org> Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Auto-Submit: Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#828061}
-
Gabriel Charette authored
R=altimin@chromium.org Change-Id: Ia0794808672a61a70b7a3dd5e5f15ff4e6ec0a8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537140 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Auto-Submit: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#828060}
-
Nina Satragno authored
Plumb the minimum PIN length into the security key PIN settings page. forcePINChange will be implemented in a follow-up. Bug: 1143427 Change-Id: I399712fd00de1dda50a29b0e8e95fa77e34cca44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2528624 Commit-Queue: Nina Satragno <nsatragno@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Reviewed-by:
Theodore Olsauskas-Warren <sauski@google.com> Cr-Commit-Position: refs/heads/master@{#828059}
-
Norman Rosas authored
Generate DIR_METADATA files and remove metatada from OWNERS files for //components/content_settings Bug:1113033 Add DIR_METADATA files to //components/about_ui Generate DIR_METADATA files and remove metatada from OWNERS files for //components/about_ui Bug: 1113033 Change-Id: I556e7821267dab5eeb003b8b6935d7337e172838 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543195Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Norman Rosas <normando@google.com> Cr-Commit-Position: refs/heads/master@{#828058}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/bee2bff5b0e1..bde2c3c32a2b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC tasak@google.com,tguilbert@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1149580 Tbr: tasak@google.com,tguilbert@google.com Change-Id: I84e95f3b36cca27473215885cff0f2dba35441d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543307Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#828057}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/620cb770e3dd..c669bf529619 2020-11-16 syoussefi@chromium.org Vulkan: Optimize PBO copy from depth xor stencil src 2020-11-16 jdarpinian@chromium.org Remove trailing whitespace. 2020-11-16 geofflang@chromium.org GL: Implement EXT_YUV_target 2020-11-16 jmadill@chromium.org Vulkan: Fix serial handling for queries 2020-11-16 syoussefi@chromium.org Vulkan: prerotation deqp expectations 2020-11-16 syoussefi@chromium.org Optimize building prerotation deqp targets 2020-11-16 jmadill@chromium.org Vulkan: Remove RendererVk::getNextSubmitFence. 2020-11-16 syoussefi@chromium.org Vulkan: Expose OES_shader_image_atomic without VS/FS atomics 2020-11-16 jmadill@chromium.org Vulkan: Give CommandQueue an abstract interface. 2020-11-16 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-Headers from 670ffea9d61b to 11c6670b4a4f (1 revision) 2020-11-16 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from 1cda495274bb to 1f2fcddd3963 (2 revisions) 2020-11-16 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from 128608f6da3a to 9d3ef3258715 (31 revisions) 2020-11-16 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 28c8eb1a to 089f5a3e (514 revisions) 2020-11-16 xiaoxuan.liu@arm.com Vulkan: Add support for headless surface 2020-11-14 timvp@google.com Update emulated_prerotation_ to emulatedPrerotation 2020-11-14 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-Loader from e2b55419a370 to be6ccb9ecaf7 (1 revision) 2020-11-14 syoussefi@chromium.org Fix texture buffer width query 2020-11-14 timvp@google.com Metal: Suppress TransformFeedbackTest::BufferOutOfMemory() If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: cnorthrop@google.com Test: Test: TextureBufferTestES31.QueryWidthAfterBufferResizeTest: Test: TransformFeedbackTest.BufferOutOfMemory/ES3_MetalTest: Test: dEQP-GLES31.functional.state_query.texture_level.texture_buffer.width_* Change-Id: Ib1e5d1446cc883a52864cd649945f737f466ce55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543309Reviewed-by:
-
Harvey Yang authored
As the samples' channels should be ordered (accel_x, accel_y, accel_z), using ++it should reduce the complexity slightly compared with using find for each channel. BUG=b:172208566, b:172414227 TEST=builds, unit tests, and run on octopus Change-Id: Ibfcb385f71aec5c202a50940c04954393be0817a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519348 Commit-Queue: Cheng-Hao Yang <chenghaoyang@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#828055}
-
Thanh Nguyen authored
Bug: 1149451, 1149504 Change-Id: Ic24dcb714db843aae17aafd6ba83a2c7a83d7ae1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543522Reviewed-by:
Tony Yeoman <tby@chromium.org> Commit-Queue: Tony Yeoman <tby@chromium.org> Cr-Commit-Position: refs/heads/master@{#828054}
-
Min Qin authored
complete notification The download complete notification use Uri as an extra type. But when reading the extra, we treat it as an String. This CL fixes the issue BUG=1149649 Change-Id: If937c3688f4af8482fd4e7bbdc392cfcc84ff8f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542665Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#828053}
-
Preethi Mohan authored
See crbug.com/1149035 as well. Bug: 739522 Change-Id: Iaba40802428c26075162298cbcd013fca3adfc7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486482 Commit-Queue: Preethi Mohan <preethim@google.com> Reviewed-by:
Robert Ma <robertma@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#828052}
-
Patrick Monette authored
Bug: 971272 Change-Id: I35e1dc341bbf62b1639e03620ed549f2effd4678 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530239 Commit-Queue: Patrick Monette <pmonette@chromium.org> Reviewed-by:
-
