GitLab

Switch the collection of cached_vpd and storage information
from runtime_probe to cros_healthd.

to a sona device with some code to log what StatusUploader is
uploading. I then checked that data was consistent with the data
reported by the command-line invocation of cros_healthd.

Bug: b:128683357
Test: manual and unit tests. Manually, I built and deployed Chrome
Change-Id: Id680449eed59cba7ed92bc4b4934e466d457ff79
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809612Reviewed-by: Pavol Marko <pmarko@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Commit-Queue: Paul Moy <pmoy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#700324}

To detect whether Application Verifier is running,
sandbox/win/src/target_interceptions.cc checks if vrfcore.dll is loaded,
while sandbox/win/src/handle_closer_agent.cc checks for verifier.dll.

This change makes both use verifier.dll, to be consistent and remove any
confusion around whether these two are checking for the same thing (they
are).

      Open Application Verifier
      File > Add Application > chrome.exe (any chrome.exe binary works)
      Under 'Tests', uncheck everything but Basics > Handles, then Save
      Run chrome.exe with this change; it works normally
        (on versions without lines 176-177, no pages will load)
      Return to Application Verifier
      Right-click chrome.exe > Delete Application, then Save
        (so Chrome runs normally again)

Test: Manual
Change-Id: If97a1115373c394f0cbbf1d31d3ca7b60549bbee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776781
Commit-Queue: Jesse McKenna <jessemckenna@google.com>
Reviewed-by: Greg Thompson <grt@chromium.org>
Reviewed-by: Will Harris <wfh@chromium.org>
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#700323}

There is no need anymore to block navigations from the signin page to
other chrome URLs, because concerns from https://crbug.com/366127 are no
longer applicable:

1. Site Isolation has shipped since then and guarantees process isolation
   between 1) the signin page, 2) other chrome URLs and 3) web/http
   content (in particular, see how r689561 and r595259 modified
   SiteInstanceImpl::DoesSiteURLRequireDedicatedProcess).

2. Project DICE has significantly refactored how the signin page works.
   In particular web/http content is now hosted inside a <webview> tag
   (see inline_login.html and new_inline_login.html in r449349 and
   r301130).

3. Chrome no longer has a "signin process" with higher privileges.

Bug: 1003957, 442674, 366127
Change-Id: I022af05d339d29a1f57b4a7128e69036c6eecb5c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804680Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: Roger Tawa <rogerta@chromium.org>
Commit-Queue: Alex Moshchuk <alexmos@chromium.org>
Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#700322}

This test is flaky on iOS devices, but FLAKY_ prefix is no longer used,
so this test is disabled on iOS devices.

Bug: 1008023
Change-Id: I7bb3e2d530d584585f2c89c57a1c8b05067e30b8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825319
Auto-Submit: Eugene But <eugenebut@chromium.org>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#700321}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/87e5c742..6384e38b

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I308bce27d8f2fcdbb8c5afb3d92d6bb101276bb7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827607Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#700320}

This CL was generated by
//base/android/jni_generator/jni_refactorer.py.

Bug: 929661
Change-Id: I93cfe2c52279c115e2c896aff034ef650c4e6ec2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809242Reviewed-by: Paul Jensen <pauljensen@chromium.org>
Commit-Queue: Eric Stevenson <estevenson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#700319}

Change-Id: Ib9710772ce534e49d42f51dd8c4b374d85659127
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1823852
Commit-Queue: Gabriel Charette <gab@chromium.org>
Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#700318}

This removes almost all remaining usage of Connector from child
processes, instead preferring use of ChildProcessHost.BindHostReceiver
to acquire process-scoped interfaces from the browser.

The one remaining use case after this CL is for the Device Service's
PowerMonitor API. This is left as a separate change because it requires
substantial additional support code for testing.

Bug: 977637
Change-Id: I679c6d7f5ec01d1bc1bb6852e0f79a3f1650df34
Tbr: penghuang@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815731
Commit-Queue: Ken Rockot <rockot@google.com>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#700317}

Translate option under Content Settings is not shown if Language Settings
is enabled. However, Sync can trigger the translate prefs to be changed
and Content Settings tried to update _translateDetailItem which hasn't
been initialized.

Added unit test to call -onPreferenceChange:.

Bug: 1006720
Change-Id: If97799c1a13b6913ff7bc8ceed0674fbebc3491c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1826000
Commit-Queue: Peter Lee <pkl@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#700316}

Before the patch: the worker would never ignore corrupted passwords,
which blocks other updates.

After this patch: the worker ignore corrupted passwords.

Change-Id: Ia8d3fd9a351f6949b9348fb57c7b721643d2e182
Bug: 1008403
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1826892
Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#700315}

This wipes out the File service completely, migrating DOM Storage code
to direct usage of LevelDBServiceImpl. This is a precursor to further
migration over to Storage Service code.

Bug: 994911
Change-Id: Ic8f8219c1c07316598ead9d2b214f8cfa7e17c75
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824025Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Commit-Queue: Ken Rockot <rockot@google.com>
Cr-Commit-Position: refs/heads/master@{#700314}

This is CL [4/4] in a series of CLs to expose "display: none"
elements to the browser process AXTree.

1. Add and improve tests for CSS display and visibility.
2. Introduce new command line flag and chrome://flags entry.
3. Update AXObject::ComputeAccessibilityIsIgnoredButIncludedInTree
   and relevant logic for the feature to work, disabled using the
   feature flag.
4. Enable the feature in tests; update expectation files.

---

This change enables exposing "display: none" nodes to the browser-side
AX tree for tests only by enabling the appropriate base::Feature
and assigning a "status" to the flag in :
third_party/blink/renderer/platform/runtime_enabled_features.json5
content/browser/accessibility/dump_accessibility_browsertest_base.cc

---

Bug: 651614
Change-Id: I70ebede486ef157ef0c0dce5b9338621101c76af
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809421Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Kurt Catti-Schmidt <kschmi@microsoft.com>
Commit-Queue: Adam Ettenberger <adettenb@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#700313}

https://chromium.googlesource.com/catapult.git/+log/eecf29fbbcd3..62960ae89911

git log eecf29fbbcd3..62960ae89911 --date=short --no-merges --format='%ad %ae %s'
2019-09-26 wnwen@chromium.org Add fake module support to device.Install API

Created with:
  gclient setdep -r src/third_party/catapult@62960ae89911

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/catapult-autoroll
Please CC zhanliang@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=zhanliang@google.com

Bug: chromium:1000751
Change-Id: Ie4c3d8b3ff401bb2ccbcd1b8164b1d5108eca7dd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827662Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#700312}

Bug: 1008161
Change-Id: Ib8daa0315d3c22c810848d4f696961e7ba005d82
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824127Reviewed-by: Sébastien Marchand <sebmarchand@chromium.org>
Commit-Queue: Jenny Wong <jyw@google.com>
Cr-Commit-Position: refs/heads/master@{#700311}

The commands that were added to the command menu (i.e. ctrl+shift+p) were not calling ls().

This fix does two things:
1. Adds a call to ls() for Action.title, Action.category
2. Adds an ls call for title and category arguments for CommandMenu.createCommand, CommandMenu.createRevealViewCommand, and CommandMenu.createSettingCommand

Before:
https://imgur.com/sWQWAqK

After:
https://imgur.com/2O4xq3k

Bug: 941561
Change-Id: I82944ecf2a9eeb47bb7824336b6ac49283829e42
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789843Reviewed-by: Jeff Fisher <jeffish@microsoft.com>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Lorne Mitchell <lomitch@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#700310}

Disable flaky system_health.memory_desktop/browse:news:hackernews:2018
on desktop perf bots.

TBR=crouleau@chromium.org
NOTRY=true

Bug: 1008028
Change-Id: I15b7f313a9c409c1b7a107c4a1f22f5f057d9570
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1826995
Commit-Queue: John Chen <johnchen@chromium.org>
Reviewed-by: John Chen <johnchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#700309}

This change exposes LayoutTheme::PlatformColorsDidChange() through
WebRenderTheme. This allows system colors to update dynamically when
new colors are sent from the browser process.

Bug: 970285
Change-Id: Ic3b75dfec668dc5523b0e12765574e66dd35ff8f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797057Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Kurt Catti-Schmidt <kschmi@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#700308}

- Splits Write into two parts, response time and data. Uses stream 0
  for response time, stream 1 for data, to avoid a slowdown.
- Splits Read similarly.
- Eliminates the extra data copy when writing caused by passing a
  span from CodeCacheHostImpl rather than the Mojo BigBuffer received
  from the renderer.
- Changes the keyed PendingOperation queues to keep the active op at
  the head. This simplifies the helper method and callback signatures.
- PendingOperations now own the IOBuffers for Write and Fetch.
- Using stream 0 now will make deduplication of the code caches (not
  storing a copy of the code for each origin) easier in the future.

Behavior changes:
- IssuePendingOperations now runs PendingOperations through the queues
  rather than all at once. This was probably didn't happen in the real
  world but seems incorrect.
- Reads where one or more parts fail now doom the entry. We should
  help the cache eliminate inaccessible data.
- Response time is now stored in stream 0. This means any data in the
  cache from previous Chromes where response time was a prefix on
  stream 1 will cause a cache miss, since the time stamp read will fail.
  This CL then makes the data read fail, since returning data prefixed
  with a timestamp could be confusing now. Invalidating the caches
  shouldn't be a problem, since we expect a new version of Chrome/V8
  to cause the code caches to become invalid since their version/feature
  header won't match, see:
  https://cs.chromium.org/chromium/src/v8/src/snapshot/code-serializer.cc?rcl=6c89d2ffb531b3c79181532b5de04adaf7206049&l=387

Bug: chromium:992991
Change-Id: If3c5e8a83bca811fcb809a8a89c6d22942456f13
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1814685
Commit-Queue: Bill Budge <bbudge@chromium.org>
Reviewed-by: Maks Orlovich <morlovich@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Mythri Alle <mythria@chromium.org>
Cr-Commit-Position: refs/heads/master@{#700307}

See https://docs.google.com/document/d/1rskVuhK9wAqgntcq9WYPSknMEc_jsAp3zrqb4YSMAqE/edit#
for the mock and expected behaviors.

See crbug.com/997885#c5 for demo. For now with this CL in place, we can
only drag the window around. More will be done in follow up Cls.

Bug: 997885
Change-Id: Iecea3a8cb4a6fe3c6a64ddddea08bc010cfb72dc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817105
Commit-Queue: Xiaoqian Dai <xdai@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#700306}

Visual: http://screen/mG7ARfoC0iB

Bug: 1008156
Change-Id: I6cf6cb84ef6b797162147900b978aea293f94a28
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824836Reviewed-by: Yann Dago <ydago@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Yann Dago <ydago@chromium.org>
Cr-Commit-Position: refs/heads/master@{#700305}

No margin was provided, so <cr-icon-button> used the default margin,
which happened to be -8px. This CL sets the margin to 0.

Bug: 981318
Change-Id: I6fa10935feecdda9626d3698ca10b707d28761e2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825141
Auto-Submit: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#700304}

Everything has been moved to chrome/browser/util.

Bug: 995916
Change-Id: I679927eef785f04f95f34604687ef81f1c794dd4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816973Reviewed-by: Peter Wen <wnwen@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#700303}

Bug: None
Change-Id: I44ce5e128389a0a64f310e5b6d9d26a0ae231710
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1823118
Auto-Submit: Boris Sazonov <bsazonov@chromium.org>
Reviewed-by: Pâris Meuleman <pmeuleman@chromium.org>
Reviewed-by: Alex Ilin <alexilin@chromium.org>
Commit-Queue: Boris Sazonov <bsazonov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#700302}

Bug: 1007180
Change-Id: I791e11308f6febc6cf3f73bb8c723341e0adee3e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1821523Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org>
Commit-Queue: Denis Kuznetsov <antrim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#700301}

It was using separate HostSchemePorts for wss/https and ws/http. This CL
makes it normalize scheme to https and http.

Bug: 997241
Change-Id: Ic0688f6eb40a6a70f940ae7c4547c9d1475baaa2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1822819
Commit-Queue: Matt Menke <mmenke@chromium.org>
Reviewed-by: Zhongyi Shi <zhongyi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#700300}

TBR=perezju@chromium.org

Bug: 1007355
Change-Id: I77060168b5135d016d8f0cb11f613f9cfb37bee7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1822104Reviewed-by: Simon Hatch <simonhatch@chromium.org>
Commit-Queue: Simon Hatch <simonhatch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#700299}

Nothing should call these through a StyleFetchedImage, so we can make
these private. Add a comment about the overrides (also in
StyleFetchedImageSet).

Change-Id: I564d9603a77cf2452c504e3150f49dd11ea14053
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824276Reviewed-by: Stephen Chenney <schenney@chromium.org>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#700298}

Without this change, cr-dialog will scroll with the content.
This fixes that issue.

Bug: 828795
Change-Id: I75ed18dd8f8cc2b8f0f93395b207c99fd53bbf99
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1826118Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#700297}

Before, when the scrim was up, dimming the results view, Voiceover
would still read the dimmed elements. Now, as part of putting up the
scrim, the table view marks all its subviews as accessibilityHidden,
so they don't appear in Voiceover. The opposite happens when the scrim
is removed.

Bug: 981343
Change-Id: Ibfb9d37f64c30f75fbe6d05633c7e6f4790f3713
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1826888Reviewed-by: Sergio Collazos <sczs@chromium.org>
Commit-Queue: Robbie Gibson <rkgibson@google.com>
Cr-Commit-Position: refs/heads/master@{#700296}

Test has been flaky in the recent runs:
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=ash_unittests&tests=DropTargetOnCorrectDisplayForDraggingFromOverview

TBR=sammiequon@chromium.org

Change-Id: I30ff04ef28a9a4be996f76a7ae88c23d68b00771
Bug: 1008408
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827501Reviewed-by: Sebastien Lalancette <seblalancette@chromium.org>
Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org>
Auto-Submit: Sebastien Lalancette <seblalancette@chromium.org>
Cr-Commit-Position: refs/heads/master@{#700295}

TabContextObserver is used to signal changes to the tab model.
It has applications where we want to prefetch the tab close
suggestions after the tab model changes so they are available
for the UI thread (and the UI thread doesn't have to block on them).

Bug: 1005573
Change-Id: I91ea9367a90301d6bc6dc9a00c141c59a574db5a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1811935
Commit-Queue: David Maunder <davidjm@chromium.org>
Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#700294}

* aura::Window default property values return 0 as the default value if
  the property isn't defined. So we can't initialize the IDs to 0 by
  default otherwise we could get matches on un-initialized Webviews.
* Register the WebviewWindowManager::Observer when the Webview is
  created since this is when we have the Webview to parent. If it
  happens that we get a parenting request without a valid Webview it
  will crash the browser process.

Bug: b/132811925
Test: Try to register Webview with ID=0
Change-Id: Ieb82c97be3850633b02894cb2a805272d38d227e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827582Reviewed-by: Alex Sakhartchouk <alexst@chromium.org>
Commit-Queue: Daniel Nicoara <dnicoara@chromium.org>
Cr-Commit-Position: refs/heads/master@{#700293}

Add build.gradle and AndroidManifest.xml files that are needed to build
these interfaces as an independent target in AndroidX repo.

These files are used by AndroidX build scripts only and should not be
used inside chromium project.

Bug: https://issuetracker.google.com/issues/140178227
Change-Id: I7686c7e49bfc023dd818210e583b7f535fe9b61c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1823119
Commit-Queue: Hazem Ashmawy <hazems@chromium.org>
Reviewed-by: Nate Fischer <ntfschr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#700292}

SetFontRenderParams() took only the family name of the returned fallback
font, and performed rematching based on the run's styling. This
rematching leads to an inaccurate recreation of the intended fallback
font. The intention with fallback fonts returned from Skia is to use the
exact SkTypeface that was returned by the fallback call, not to attempt
to extract family, weight, style parameters and recreate.

This CL split SetFontRenderParams() on TextRun::FontParams into two
cases: One that allows rematching, which is useful for styling when
doing the shaping runs with the primary fonts (as the Omnibox uses it
for styling substring matches, for example). Secondly, for fallback, the
new method SetRenderParamsOverrideSkiaFaceFromFont() is used which tries
to extract the SkTypeface from PlatformFontSkia if that is the
underlying PlatformFont implementation. Otherwise it performs a rematch
using CreateSkiaTypeface() as in SetFontRenderParams(). This gives us a
viable path forward towards moving to PlatformFontSkia exclusively, in
which case we can remove the last resort rematching step, as we will
always have an underlying SkTypeface.

This CL is also preparation for fixing issue 1003829 in which a specific
weight of Segoe UI is returned by the Skia fallback methods but
inaccurately recreated in SetFontRenderParams() as the weight
information is lost.

Bug: 1003829
Change-Id: I8d0ed08754b97ec0254325c4b09cd74aec9e07ea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824469
Commit-Queue: Dominik Röttsches <drott@chromium.org>
Reviewed-by: Etienne Bergeron <etienneb@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#700291}

Show cookie controls notice on incognito ntp when
the improvedCookieControls flag is enabled.

screenshot: https://screenshot.googleplex.com/WTCUPwSowr9

Bug: 967668
Change-Id: I83b0d6c607ccd4a339ea66b829405224bfbc1732
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1814817Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Dan Beam <dbeam@chromium.org>
Reviewed-by: Christian Dullweber <dullweber@chromium.org>
Commit-Queue: Huanzhong Huang <huanzhong@chromium.org>
Cr-Commit-Position: refs/heads/master@{#700290}

This reverts commit 3dd95e21.

Reason for revert: Suspect for android-builder-perf compile failures:
https://ci.chromium.org/p/chrome/builders/ci/android-builder-perf/115402

Original change's description:
> [Payments] Enable shipping and contact info delegation [4/5]
> 
> This cl implements shipping address/option change events for PH. With
> this change payment handlers can notify the merchant when the user
> changes the selected shipping address/option, and wait for updated
> details (e.g. new shipping cost, etc) from merchant.
> 
> For overall flow please check
> https://chromium-review.googlesource.com/c/chromium/src/+/1779003
> 
> Bug: 984694
> Change-Id: Id881ba22bf4c846a4570801bacc49e5d4e89a72b
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804557
> Reviewed-by: Mike West <mkwst@chromium.org>
> Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
> Commit-Queue: Sahel Sharify <sahel@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#700238}

TBR=rouslan@chromium.org,mkwst@chromium.org,sahel@chromium.org

Change-Id: I74d8507117fc9a0000142071b71146d14f17f8bf
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 984694
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827544Reviewed-by: Sebastien Lalancette <seblalancette@chromium.org>
Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org>
Cr-Commit-Position: refs/heads/master@{#700289}

Bug: 759184
Change-Id: I72c874798047f89c08271ba471d67baf04f2a920
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825899
Commit-Queue: Lucas Gadani <lfg@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#700288}

If an item in the Tab menu either is or recently was playing sound,
append a sound state icon to it to make it stand out as such in the
tab menu. This will help users with a lot of tabs find the ones
making noise.

Bug: 1006624
Change-Id: Ia718f655d25a23731d705b5f6faa7fbb2bb91978
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827502Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#700287}

persistent failures.

Bug: 1008275
TBR: nikitapodguzov
Change-Id: Ie35e6388214e84095432fa5cadebcc69e53286c6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827291Reviewed-by: Finnur Thorarinsson <finnur@chromium.org>
Commit-Queue: Finnur Thorarinsson <finnur@chromium.org>
Cr-Commit-Position: refs/heads/master@{#700286}

In the new APIs the notion of readiness (which is more abstract) was
replaced by the cryptographer's CanEncrypt() state. This patch
addresses a TODO to rename some leftovers from earlier patches, as well
as the string in chrome://sync-internals.

Bug: 967417
Change-Id: Ia9c24a756c06fa4036dfedf0475b3d8cb5c3f37d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1826781
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: Maksim Moskvitin <mmoskvitin@google.com>
Cr-Commit-Position: refs/heads/master@{#700285}