GitLab

In blink, we convert the string position to root frame and then convert to
AppKit coordinates by inverting y-axis. To do so, we must always use
FrameView::height() of the root frame rather than that of the
LocalFrame.

BUG=640353

Review-Url: https://codereview.chromium.org/2275323003
Cr-Commit-Position: refs/heads/master@{#414814}

BUG=640116

Review-Url: https://codereview.chromium.org/2268193002
Cr-Commit-Position: refs/heads/master@{#414813}

BUG=638630
TEST=mus_ws_unittests events_unittests blink_converters_unittests
     ash_unittests views_mus_unittests

Review-Url: https://codereview.chromium.org/2256343003
Cr-Commit-Position: refs/heads/master@{#414812}

Remove password_reveal_duration_ member in Textfield and always
gets it from ViewsDelegate.

BUG=634472
TEST=TextfieldTest.SetPasswordRevealDuration

Review-Url: https://codereview.chromium.org/2286433002
Cr-Commit-Position: refs/heads/master@{#414811}

//services/ui/surfaces code runs in the window-server, and so should not
directly use code in //services/ui/gpu, which should run in the gpu
process.

BUG=613366

Review-Url: https://codereview.chromium.org/2280723004
Cr-Commit-Position: refs/heads/master@{#414810}

Allows BindingSet<T>::AddBinding to associate an arbitrary
|context| value with a new binding when added. The set's
dispatch_context() accessor will return this value during
the extent of any message or error dispatch targeting
that specific binding.

Refactors BindingSet to simplify lifetime management
and allow it to be reused for associated bindings as well.

Also implements AddFilter for master interface bindings on
interface types which support associated interfaces, as this
was accidentally omitted when AddFilter was introduced.

BUG=612500
R=yzshen@chromium.org

Review-Url: https://codereview.chromium.org/2283543002
Cr-Commit-Position: refs/heads/master@{#414809}

Folds the following helper functions:

  applyCSSPropertyToTargetAndInstances
  removeCSSPropertyFromTargetAndInstances
  notifyTargetAndInstancesAboutAnimValChange

into their users, hoisting common predicates and simplifies
accordingly.

BUG=640676

Review-Url: https://codereview.chromium.org/2285473002
Cr-Commit-Position: refs/heads/master@{#414808}

* Remove timestamp tracking from X11DesktopHandler
* Track focus state in DWTHX11. Inspired by gtk/docs/focus_tracking.txt
  Hopefully this will fix most Linux-aura focus related bugs

BUG=635169,635177

Review-Url: https://codereview.chromium.org/2165083002
Cr-Commit-Position: refs/heads/master@{#414807}

When deciding if HTMLCanvasElement should be accelerated we changed
the code to get the shared main thread context before making the
decision because it's part of the decision. However, for most of the
things we decide on (such as are-we-using-display-list-canvas) we
don't care about the context. We only care once we decide we do want
to use it, then verify it's not using swiftshader.

So, defer getting/creating the shared main thread context until we
know we want to accelerate, then just fail to accelerate if swiftshader.

To make this logic more clear, I split the createImageBufferSurface()
method into createAcceleratedImageBufferSurface() and
createSoftwareImageBufferSurface() which is used if the former
fails/returns null. There is less nesting now so hopefully that's nice.

With this the memory.blink_memory_mobile's TheVerge case goes from
6422Kb of gpu memory back down to 4324Kb.

R=junov@chromium.org, kbr@chromium.org
BUG=640811,606056

Review-Url: https://codereview.chromium.org/2280723003
Cr-Commit-Position: refs/heads/master@{#414806}

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/90d4177d32d5c0ee899f50fc431ad9cc2f1b25d9 Delete all references to GIT_MODE=True from build (agable@chromium.org)
  https://crrev.com/76d5c79ed794fe690650978678171b28027c8af8 Add dtu to recipe_modules/auto_biect OWNERS. (dtu@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=640251

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2286913002
Cr-Commit-Position: refs/heads/master@{#414805}

Settings are sometimes difficult to get access to, depend on the context.
Also we don't find any use cases to applying different rootLayerScrolls value
to individual frames. Migrating to RuntimeEnabledFeatures to simplify code.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2258523006
Cr-Commit-Position: refs/heads/master@{#414804}

Revert of IME for Mus: Make InputMethodMus use the IME Mojo API. (patchset #16 id:300001 of https://codereview.chromium.org/2230393002/ )

Reason for revert:
All text input appears to be broken in chrome on mash, and I bisected to this patch. Reverting locally appears to fix this.

Original issue's description:
> IME for Mus: Make InputMethodMus use the IME Mojo API.
>
> This CL:
> * Uses Mus' IMEServer to do the IME logic in InputMethodMus.
> * Adds unittests to test InputMethodMus.
> * Starts test_ime_driver on mus+ash session startup.
> * Modifies test_ime_driver to not-handle non character events.
>
> BUG=548407
>
> Committed: https://crrev.com/aa4f90ab72b60fd90e048b1e18193c30f0462d77
> Cr-Commit-Position: refs/heads/master@{#414748}

TBR=sadrul@chromium.org,sky@chromium.org,tsepez@chromium.org,moshayedi@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=548407

Review-Url: https://codereview.chromium.org/2284003002
Cr-Commit-Position: refs/heads/master@{#414803}

- Remove unused includes.
- Use auto and nullptr.
- Simplify code.

Review-Url: https://codereview.chromium.org/2272933002
Cr-Commit-Position: refs/heads/master@{#414802}

TBR=schenney@chromium.org
NOTRY=true
BUG=641398

Review-Url: https://codereview.chromium.org/2279263003
Cr-Commit-Position: refs/heads/master@{#414801}

The existing MediaSession::Type does not work well for
Pepper&WebRTC. Spliting MediaContentType for MediaPlayer and
AudioFocusType for MediaSession to gain more control of audio focus.

Explainer for this CL:
https://docs.google.com/a/google.com/document/d/1W4uRH8Wvgau0_GtMda4EOSXRtxFuFLhb9W77sJagJpI/edit?usp=sharing

BUG=626351

Review-Url: https://codereview.chromium.org/1996043002
Cr-Commit-Position: refs/heads/master@{#414800}

The implementation is not async yet. I will add the state machine in a second
CL.

R=ikilpatrick@chromium.org,eae@chromium.org
BUG=635619

Review-Url: https://codereview.chromium.org/2281153002
Cr-Commit-Position: refs/heads/master@{#414799}

The tray separator has an opacity of 0.24 and it looks too dim when the
shelf is completely opaque. Update the tray separator's opacity to 0.3.

BUG=641453

Review-Url: https://codereview.chromium.org/2281173002
Cr-Commit-Position: refs/heads/master@{#414798}

This change provides the client-side classes needed to receive and send
geolocation messages. GeolocationFeature sends messages from the client
that either contain a geolocation coordinate or error message. The
GeolocationFeature class handles incoming GeoloationSetInterestLevelMessages
and RequestRefreshMessages.

Other items included:
* Changes device/geolocation/mock_location_provider to use fake_location_provider name
* Moves blimp/client/feature/mock_location_provider into device/geolocation.

BUG=614486

Review-Url: https://codereview.chromium.org/2161223003
Cr-Commit-Position: refs/heads/master@{#414797}

Work on making RootScrollerController work across iframes revealed that there's
two responsibilities that need management. All frames need a
RootScrollerController to manage the Element currently set as root scroller and
determine which Element should eventually become the effective root scroller.
In addition, we need the RootScrollerController to manage the
ViewportApplyScroll and set it on the appropriate element. Since only one
Element on the whole page needs this callback set, it makes sense that only the
top document should have this responsibility. Experience with classes like
FrameView and EventHandler shows that this may be better served by subclassing
the top level object rather than having isMainFrame() checks intermingled with
the other code.

BUG=505516

Review-Url: https://codereview.chromium.org/2280453002
Cr-Commit-Position: refs/heads/master@{#414796}

This change detects when we can paint the background onto the scrolling contents layer. This will unblock promoting scrollers with supported backgrounds on low DPI devices as we can now maintain subpixel antialiased text.

BUG=381840,568847
TEST=compositing/overflow/overflow-scroll-with-local-image-background.html, LayoutBoxTest.BackgroundRect, CompositedLayerMappingTest.ShouldPaintBackgroundOntoScrollingContentsLayer
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2068723002
Cr-Commit-Position: refs/heads/master@{#414795}

BUG=568415

Review-Url: https://codereview.chromium.org/2272053002
Cr-Commit-Position: refs/heads/master@{#414794}

BUG=

Review-Url: https://codereview.chromium.org/2275113003
Cr-Commit-Position: refs/heads/master@{#414793}

Use base::Bind and content::BrowserThread::PostTaskAndReplyWithResults()
instead of custom function pointer based callbacks.

Review-Url: https://codereview.chromium.org/2283823003
Cr-Commit-Position: refs/heads/master@{#414792}

Menu should use the new browser tools error icon.

BUG=630354

Review-Url: https://codereview.chromium.org/2280033003
Cr-Commit-Position: refs/heads/master@{#414791}

* Successfully removed requests where returned in result as duplicates
* above was fixed with tests updated

BUG=641380
R=dewittj@chromium.org

Review-Url: https://codereview.chromium.org/2283813003
Cr-Commit-Position: refs/heads/master@{#414790}

When the activity stops (or rather the context goes away and
resident textures incl. UI resources are evicted), don't
evict the thumbnails for the tab that was visible *if*
the bitmap is still available and wasn't uploaded to a texture
yet.

Also, don't force the UIResource to be created proactively
when the ETC1 compression completes *if* there are no running
activities, since it's racy with uploading it into
the old context that's going away, while throwing away the bitmap.

When there's critical memory pressure, free all thumbnails.

BUG=636630

Review-Url: https://codereview.chromium.org/2244783005
Cr-Commit-Position: refs/heads/master@{#414789}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/393e77578d5b..470a9e84e35b

$ git log 393e77578..470a9e84e --date=short --no-merges --format='%ad %ae %s'
2016-08-26 alexandermont Fix confusion of read vs. write bandwidth in bus_parser.html.
2016-08-26 alexandermont Change FormatBytes in strip_memory_infra_trace to use binary prefixes.

TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2284803002
Cr-Commit-Position: refs/heads/master@{#414788}

This patch adds a histogram to count the microseconds used to preload
scan the first chunk of CSS for the @import scanning experiment.

BUG=596676

Review-Url: https://codereview.chromium.org/2283803002
Cr-Commit-Position: refs/heads/master@{#414787}

This CL instantiates ImeFeature and NavigationFeature inside
BlimpClientContext. BlimpClientContext owns these features and passes
raw pointers to BlimpContents during construction.

BUG=611111

Review-Url: https://codereview.chromium.org/2258563003
Cr-Commit-Position: refs/heads/master@{#414786}

This can happen if you create a new UI resource (through LTH)
which queues a request while there are any evicted resources
(as tracked by LTHImpl).

RecreateUIResources() will then iterate over all existing client
ids and queue another CREATE request.

Simply check for duplicates before queuing more requests.

The double-upload behavior didn't play well with Android's
Thumbnail class which drops the bitmap after every
UIResourceClient::GetBitmap() call.

BUG=636630
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Review-Url: https://codereview.chromium.org/2247573002
Cr-Commit-Position: refs/heads/master@{#414785}

When clearing is in progress, we disable the buttons. We should also
disable the checkboxes.

Leaving them enabled not only gives the false impression that the
datatype selection is modifiable during clearing, it can also have
an undesired effect: When the clearing finishes, we show the message
about other forms of history based on whether the history checkbox was
checked - and thus we shouldn't allow (un)checking in.

https://screenshot.googleplex.com/0VXxxLtXHZU.png

BUG=595580
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2283853002
Cr-Commit-Position: refs/heads/master@{#414784}

Contrary to what had been assumed, CheckCountAndPostQuitTask doesn't
run on the main thread. Because of that, it cannot quit the RunLoop
running on the main thread by calling its QuitWhenIdle function; it
needs to post a QuitWhenIdleClosure to it.

BUG=641142

Review-Url: https://codereview.chromium.org/2284693003
Cr-Commit-Position: refs/heads/master@{#414783}

Status bubble height may be smaller than kMinimumOnScreenArea, which is 25. The current logic in AdjustBoundsToEnsureWindowVisibility fails in this case.

For example, bounds->y() > visible_area.bottom() - min_height is satisfied when status bubble (height 22) touches the bottom of work area. If we adjust bounds using bounds->set_y(visible_area.bottom() - min_height), it will cause unwanted white space.

BUG=624806
TEST=Device test, fixing the reporter's bug. The bug in comment 8 is a different bug and will be dealt with later by filing another bug with it.
add unittest coverage

Review-Url: https://codereview.chromium.org/2175833002
Cr-Commit-Position: refs/heads/master@{#414782}

Also don't bother compiling it on ChromeOS at all.

Review-Url: https://codereview.chromium.org/2285843002
Cr-Commit-Position: refs/heads/master@{#414781}

R=iannucci@chromium.org
BUG=640251

Review-Url: https://codereview.chromium.org/2282933002
Cr-Commit-Position: refs/heads/master@{#414780}

Unless the user manually tabs in the message center bubble, we shouldn't request
the focus by default to prevent the ugly blue border from showing automatically
[See screenshot: https://drive.google.com/a/google.com/file/d/0B6G_-uQnf1_LelZhbUN2aWtMSzg/view?usp=sharing]

BUG=620801

Review-Url: https://codereview.chromium.org/2281983002
Cr-Commit-Position: refs/heads/master@{#414779}

Need to alloc bitmap before creating canvas or it will create
an empty bitmap instead of one in WHITE.

BUG=636630

Review-Url: https://codereview.chromium.org/2238173003
Cr-Commit-Position: refs/heads/master@{#414778}

BUG=622445

Review-Url: https://codereview.chromium.org/2275513003
Cr-Commit-Position: refs/heads/master@{#414777}

We can no longer listen after events on something that is an instance in
a <use>. Move the executeTest() call to the <use> element instead.

Since the mentioned file is almost a stub, the actual change is in
svg/animations/script-tests/use-animate-width-and-height.js.

BUG=641398

Review-Url: https://codereview.chromium.org/2283893002
Cr-Commit-Position: refs/heads/master@{#414776}

Interface control messages were added before union support was ready so
the structs used for messages manually imitate unions. Now that union
support is ready, this workaround is no longer necessary and the structs
used for interface control messages can contain unions of the possible
message types.

Review-Url: https://codereview.chromium.org/2277853003
Cr-Commit-Position: refs/heads/master@{#414775}