- 27 Mar, 2018 40 commits
-
-
Ryan Tseng authored
The Linux ASan builders are on chromium.memory, not chromium.linux Bug: 790280, 731523, 790264, 826275 Change-Id: I0356fc73cf52de878ec8c5173bd7c7bdf3b77580 Reviewed-on: https://chromium-review.googlesource.com/982508Reviewed-by:
Jao-ke Chin-Lee <jchinlee@chromium.org> Commit-Queue: Ryan Tseng <hinoka@chromium.org> Cr-Commit-Position: refs/heads/master@{#546246}
-
Kurt Horimoto authored
BrowserContainerView's |-displayContentView:| should have no effect if called twice with the same argument, but its current implementation changes the view hierarchy in this case. This CL is a partial solution to fix a specific issue with the voice search button NamedGuide to minimize risk. Bug: 826093 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ia2d58883df057df2ad430ecdbc7ccdf28f02a4cd Reviewed-on: https://chromium-review.googlesource.com/981609 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#546245}
-
Koji Ishii authored
Another round to port InlineTextBox code to LayoutNG. This function is used by Slider and testing/internals. Bug: 636993 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: Iac2bbb59f49b02aeb0fd2e95cda5477a9160c444 Reviewed-on: https://chromium-review.googlesource.com/981574Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#546244}
-
Mohamed Amir Yosef authored
Some fields aren't current propagated between ModelTypeWoker and ModelTypeProcessor that are necessary for Bookmarks. This CL takes care of propagating the followings fields: parent_id is_folder unique_position/position_in_parent While this CL causes a potential behavioral change in EntityDataTraits::HasValue, this change isn't exercised in reality. This can be confirmed by checking all references of EntityData::Swap() Bug: 516866 Change-Id: I95a8bd803f808d7ee69aa5d38b525d422fcab3a8 Reviewed-on: https://chromium-review.googlesource.com/971321 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#546243}
-
sczs authored
Followup to https://chromium-review.googlesource.com/c/chromium/src/+/982364 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I99e1498d85ad296b3c343dafd858fa27d035ef22 Reviewed-on: https://chromium-review.googlesource.com/982391Reviewed-by:
edchin <edchin@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#546242}
-
Alan Cutter authored
Simple clean up CL with no binary changes. Change-Id: Iee75ccbb18e6b563a1baf01324cc9998aa61a46c Reviewed-on: https://chromium-review.googlesource.com/981852Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#546241}
-
Peter K. Lee authored
UI*FeedbackGenerator and AVCaptureDevice* classes are claimed to be available for iOS 10+, but they are not really available at runtime on iOS 10.0. iOS 10.1+ appears to be OK. Use workarounds for unavailable symbols. Bug: 824941 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Idb9e42e6f72cbd96ff81e99f3ec455c03e09f8ce Reviewed-on: https://chromium-review.googlesource.com/976945 Commit-Queue: Peter Lee <pkl@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#546240}
-
Daniel Bratell authored
In jumbo builds many cc files are compiled together in the same translation unit. When that happens, those files will share the same anonymous namespace so if they use symbols of the same name they will clash. That happened with two kBubbleReshowsHistogramName constants in chrome/browser/ui/exclusive_access and this patch gives those two more unique names. Bug: 803406 Change-Id: I2b8e3a060c7b7853a3a001317e80d32b7d6e56d4 Reviewed-on: https://chromium-review.googlesource.com/980879 Commit-Queue: Yuri Wiitala <miu@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Cr-Commit-Position: refs/heads/master@{#546239}
-
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/ee04b9a2f489..fe68c91e470a $ git log ee04b9a2f..fe68c91e4 --date=short --no-merges --format='%ad %ae %s' 2018-03-22 mmoss Add hierarchy information to flattened "visited DEPS" output. Created with: roll-dep src/third_party/depot_tools BUG=chromium:825063 The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I4a7b92e125f229ee379e1ec97130140103c0f6d2 Reviewed-on: https://chromium-review.googlesource.com/982394 Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#546238}
-
Becca Hughes authored
History is expired automatically after 90 days. This clears data from MEI if history is expired and there is no more history remaining on that origin. BUG=818153 Change-Id: I7dd309d5abddb398ff0ec452147d25a86ce827b6 Reviewed-on: https://chromium-review.googlesource.com/960142 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#546237}
-
Nick Harper authored
Bug: 824888 Change-Id: Ife836938b0a6a1e97c5e838b80ab88511d692e6f Reviewed-on: https://chromium-review.googlesource.com/980810Reviewed-by:
Eric Lawrence <elawrence@chromium.org> Cr-Commit-Position: refs/heads/master@{#546236}
-
Jacob Dufault authored
- Reorder class members to follow styleguide - Move LockScreenAppsFocusObserver to LoginScreenController::Observer I am planning on adding more methods to the observer; instead of having a separate observer for each method it seems cleaner to have one larger observer. Bug: 784495 Change-Id: I7de65cbc4abae26b23a11344b0a065b73032e09d Reviewed-on: https://chromium-review.googlesource.com/978833 Commit-Queue: Jacob Dufault <jdufault@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#546235}
-
Theresa authored
Contextual suggestions should only be enabled for phones and when modern is enabled. A follow-up CL will also add other relevant checks. BUG=823987 Change-Id: Iadf323534a03b65fe27b1d8fdc64f625096db334 Reviewed-on: https://chromium-review.googlesource.com/982244 Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#546234}
-
Ria Jiang authored
Fuzz the hit-test data sent to HitTestManager and aggregate that in HitTestAggregator. One problem the fuzzer revealed is fixed in https://chromium-review.googlesource.com/c/chromium/src/+/957881. Coverage report: https://goto.google.com/riajiang-hit-test-fuzzer-report Bug: 819435 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I6029ffcaa0ccb696648d09da1e344aa2daa0eff6 Reviewed-on: https://chromium-review.googlesource.com/969927 Commit-Queue: Ria Jiang <riajiang@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Cr-Commit-Position: refs/heads/master@{#546233}
-
Kevin McNee authored
The hang in issue 818214 has been identified, so we can remove this diagnostic DumpWithoutCrashing. Bug: 818214 Change-Id: I61012b9f0d825b3a86f4fef48f3398701676f0d3 Reviewed-on: https://chromium-review.googlesource.com/982102Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#546232}
-
Harald Alvestrand authored
Proper state checking requires the operations queue, so disabling for now. Bug: 826194 Change-Id: I48b27834f93e3d01665dcb3c96ddd94ef0589944 Reviewed-on: https://chromium-review.googlesource.com/980945Reviewed-by:
Tommi <tommi@chromium.org> Commit-Queue: Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#546231}
-
Christopher Grant authored
BUG=825203 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I06bd09f0c0599756541ac0ce1077e7275fe41a64 Reviewed-on: https://chromium-review.googlesource.com/981295Reviewed-by:
Biao She <bshe@chromium.org> Commit-Queue: Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#546230}
-
Mustaq Ahmed authored
We originally had the notification conditional on whether the current frame had been activated before or not. This works fine for the sticky activation bit but for the transient bit (which can expire or get consumed), other processes should be notified at every user activation. Bug: 780556, 775930 Change-Id: I902129651504371bad0b9ab841e65b223bee46b4 Reviewed-on: https://chromium-review.googlesource.com/973507Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
-
Sergey Ulanov authored
Previously the SDK was unpacked in //third_party/fuchsia-sdk. Moving it to a nested directory will allow adding GN build files under //third_party/fuchsia-sdk for libraries and FIDL interfaces in the SDK. Bug: 707030 Change-Id: I7687f7e44010e5b93ba487c25b7e48ea755ae024 Reviewed-on: https://chromium-review.googlesource.com/976741Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#546228}
-
https://chromium.googlesource.com/catapult.git/+log/6b8f67cc144c..0428350035df $ git log 6b8f67cc1..042835003 --date=short --no-merges --format='%ad %ae %s' 2018-03-27 simonhatch Dashboard - Don't merge into a bug with multiple culprits. 2018-03-27 eakuefner [TBMv2] Test add_reserved_diagnostics 2018-03-27 kraynov Fix frame grouping for [Web]FrameScheduler since it was renamed. Created with: roll-dep src/third_party/catapult BUG=chromium:780473 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=sullivan@chromium.org Change-Id: If1fa6cf37de04ab4876805d8e70b8732679464de Reviewed-on: https://chromium-review.googlesource.com/981018 Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#546227}
-
Alexei Filippov authored
BUG=826045 Change-Id: I7273015bcac131f028116380e928f6a9c6d67182 Reviewed-on: https://chromium-review.googlesource.com/981444 Commit-Queue: Alexei Filippov <alph@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#546226}
-
Dirk Pranke authored
This adds a subcommand to MB that will allow you to build everything needed to run a given target, and then put all of the needed files into a single zip file that can be easily redistributed. Also, this fixes a couple of minor bugs where `isolate` didn't work for an additional_compile_target, and wouldn't build the target by default, and fixes the TOC entries in the user guide to display properly by working around a Gitiles bug. R=maruel@chromium.org BUG=824595 Change-Id: I3d77a33efbce6f6159cd6c8c1b2d727494d9f200 Reviewed-on: https://chromium-review.googlesource.com/974718 Commit-Queue: Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Marc-Antoine Ruel <maruel@chromium.org> Cr-Commit-Position: refs/heads/master@{#546225}
-
Emily Hanley authored
Change-Id: I87e15877022159c32fd92cd320e588b13fb63636 Reviewed-on: https://chromium-review.googlesource.com/982360Reviewed-by:
Ashley Enstad <ashleymarie@chromium.org> Commit-Queue: Emily Hanley <eyaich@chromium.org> Cr-Commit-Position: refs/heads/master@{#546224}
-
Alexei Filippov authored
It had been broken in https://chromium.googlesource.com/chromium/src/+/e17afc530a565d3d1c66f316750c817af60cb3ff Change-Id: Ia78f1592a284d3a7acc9cc33cb54a2a677d1f743 Reviewed-on: https://chromium-review.googlesource.com/980808Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#546223}
-
Wenzhao Zang authored
1) The original idea was to create a WallpaperPaths class in //ash/public, but it's unnecessary now. We only need a one-time initialization of the wallpaper paths, and they can be internal to //ash after that. 2) Saving and syncing thumbnail is entirely implemented in wallpaper_manager.js, so delete all thumbnail related code in *.cc files. The |thumbnail_path| variable in https://goo.gl/HZw6r7 is left because https://chromiumcodereview.appspot.com/12334030 forgot to clean it up. 3) Removed code duplication of thumbnail generation in wallpaper_api and wallpaper_private_api. Bug: 795159 Test: Manual Change-Id: Ia861da7579f743e5fc380128c6d28405246de2c4 Reviewed-on: https://chromium-review.googlesource.com/967882Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#546222}
-
mrefaat authored
Bug: 623016 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I67f24017a4be006fe53e59b0f49355e70833ffeb Reviewed-on: https://chromium-review.googlesource.com/980809Reviewed-by:
-
Chris Harrelson authored
Matrices can be non-invertible on the web, such as scale(0). Bug:809701 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Ia5b1b893f0a0d922b8b40d45577f8be0bff16ca2 Reviewed-on: https://chromium-review.googlesource.com/981688 Commit-Queue: Tien-Ren Chen <trchen@chromium.org> Reviewed-by:
Tien-Ren Chen <trchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#546220}
-
Joshua Peraza authored
9c89cd99f335 gn: add templates for executables and loadable_modules 6b23575b34bd linux: verify whether a broker has been successfully forked 5754f608cb57 android: unset source filters to use linux files 58e4bbecc246 win, gn: use new lists when using templated targets Bug: crashpad:30 Change-Id: I0902c600b7257a419b8b0d770ac4f40fc6a808e6 Reviewed-on: https://chromium-review.googlesource.com/981690Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Joshua Peraza <jperaza@chromium.org> Cr-Commit-Position: refs/heads/master@{#546219}
-
Troy Hildebrandt authored
When searching for google.com on Google with it as your default search engine, you see the text google.com in your omnibox after navigating to the results for that search. However, typing google.com into the omnibox will treat it as a URL and navigate to google.com. This CL uses some AutocompleteController logic to avoid displaying the search string when that string would be interpreted as a URL for navigation if typed into the ominbox. Change-Id: I34d4cf59fd53dc7d7d7f65a27718c703a1ea4cd1 Reviewed-on: https://chromium-review.googlesource.com/978670 Commit-Queue: Troy Hildebrandt <thildebr@chromium.org> Reviewed-by:
Maria Khomenko <mariakhomenko@chromium.org> Cr-Commit-Position: refs/heads/master@{#546218}
-
Nick Harper authored
TBR=elawrence@chromium.org Change-Id: Iafac5429318117e83df2887190830207546b40c5 Reviewed-on: https://chromium-review.googlesource.com/981521Reviewed-by:
Nick Harper <nharper@chromium.org> Reviewed-by:
-
Jay Civelli authored
Making the subresource loaded notification in frame.mojom be for all resources including frame resources. This is going to be used by the task manager when the network service is enabled to track network usage. Bug: 825905 Tbr: tsepez@chromium.org Change-Id: I890d6c4103141a7e1d78e7cda015a750e62da380 Reviewed-on: https://chromium-review.googlesource.com/981080 Commit-Queue: Jay Civelli <jcivelli@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
-
Devlin Cronin authored
This is a reland of 7a1b3bb0 TBR=karandeepb@chromium.org (reland with no changes) Original change's description: > [Extensions] Remove manifest v1 support for accessible resources > > In manifest version 1, all extension resources were considered > accessible by the web (i.e., could be embedded within or > requested by a web page). In manifest v2, only resources > explicitly specified in the web_accessible_resources key are > accessible. Remove support for manifest v1, and always check > the web accessible resources. > > Update unit tests to migrate relevant tests and remove tests for > manifest v1-specific behavior. > > Bug: 816677, 816679 > Change-Id: Id0dd3ef75cd5d49e3f87e45ac3a8b19a00391146 > Reviewed-on: https://chromium-review.googlesource.com/953177 > Commit-Queue: Devlin <rdevlin.cronin@chromium.org> > Reviewed-by: Karan Bhatia <karandeepb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#545898} Bug: 816677, 816679 Change-Id: Ic26fb161878df83c40e92e2fa19dd3f698b4d62c Reviewed-on: https://chromium-review.googlesource.com/981090 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#546215}
-
David Roger authored
Updates code generating INVALID_GAIA_CREDENTIALS errors to also set an error reason. Report these error reasons in the Signin.InvalidGaiaCredentialsReason histogram. Bug: 822728 TBR: alemate Change-Id: Ie727964845f0677a31d0ab035c0dee788d2b7859 Reviewed-on: https://chromium-review.googlesource.com/966422 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#546214}
-
Steve Kobes authored
LayoutObject::WillBeDestroyed removes children before calling Remove() on itself. Make LayoutFullScreen's override do the same. The tree walk in FindReferencingScrollAnchors relies on this. If an ancestor layout object has already been removed, we will fail to clear ScrollAnchor::anchor_object_. Bug: 823150 Change-Id: I30bf225ef22ad740c031bca0520e238e88fef23e Reviewed-on: https://chromium-review.googlesource.com/974745Reviewed-by:
Stefan Zager <szager@chromium.org> Commit-Queue: Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/master@{#546213}
-
Gabriel Charette authored
Sampling profiler highlights high contention on this lock: crbug.com/821034. Initializing/tear down was already single-threaded (tear down had to be moved from BrowserProcessSubThread::Cleanup() to ~BrowserProcessSubThread() to enforce this with a ThreadChecker however). Add dchecks to confirm/enforce this and remove the lock which is usuless on data structures that are now (as of series of changes over the last year) read-only after startup. Use atomics to protect reads across the RUNNING=>SHUTDOWN boundary. Bug: 821034 Change-Id: I7800048bff51ad79cb10ee89fd3a0a31534c393e Reviewed-on: https://chromium-review.googlesource.com/973556 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
-
Eric Stevenson authored
This is a reland of 3e261e9b. Reason for reland: * Fixed deps order (caused flaky compile errors) * Fixed cronet apk by removing resources dep Original change's description: > Android: Add extra fields related to resources to crash reports. > > This CL adds two fields to Android crash reports. Specifically: > 1. custom_themes: Whether or not the user has apps installed for using > custom themes. This should help debug obscure resources related > crashes. > 2. resources_version: The product version as stored in resources.arsc. > This should help us detect if we tried to load resources from the old > apk during an update. > > Bug: 820591 > Change-Id: I1e2b36ec5640bb1376f83452851eaa5319d0f32f > Reviewed-on: https://chromium-review.googlesource.com/969597 > Commit-Queue: Eric Stevenson <estevenson@chromium.org> > Reviewed-by: Lei Zhang <thestig@chromium.org> > Reviewed-by: agrieve <agrieve@chromium.org> > Reviewed-by: Yaron Friedman <yfriedman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#545798} Bug: 820591 Change-Id: Id30e79ed508dbecc1b277a0450ec7784120e2efe tbr: yfriedman@chromium.org Reviewed-on: https://chromium-review.googlesource.com/981156 Commit-Queue: Eric Stevenson <estevenson@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#546211}
-
Pedro Amaral authored
Override |ShowContextMenu()| in InterstitialPageImpl and have it call |WebContentsViewAndroid.ShowContextMenu()| on Android. This is done to show the floating text selection menu (see linked bug). Bug: 823173 Change-Id: I01090aee43536cd06c8f8bc28ebccf5c2767d0d8 Reviewed-on: https://chromium-review.googlesource.com/977240Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Carlos IL <carlosil@chromium.org> Commit-Queue: Pedro Amaral <amaralp@chromium.org> Cr-Commit-Position: refs/heads/master@{#546210}
-
Donn Denman authored
Shortens the "availability" setting for In Product Help for Contextual Search, which will match our server-configs and seems better than the long window currently in place. BUG=822087 Change-Id: I583428cd101973a0c4d4e4950b014591d1006d8c Reviewed-on: https://chromium-review.googlesource.com/981318Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#546209}
-
Philip Rogers authored
We current have a histogram for LayersUpdateTime but it is bucketed by the layer count. This patch adds a new metric for the total LayersUpdateTime that is not bucketed. Bug: 825912 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ie9d83f90abf529af97bc2393f8f3ad6dc2e3530d Reviewed-on: https://chromium-review.googlesource.com/981262Reviewed-by:
Majid Valipour <majidvp@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Reviewed-by:
-
Istiaque Ahmed authored
We call HashHelper::Cancel on IO during extension unload. If the extension's hash retrieval through ContentHash was ongoing at that point, ContentHash might not see the cancellation if it already progressed enough on non-IO thread. This CL makes sure we check for cancellation before passing the read hash value on IO thread. This fixes WebstoreInstallerTest.ReinstallDisabledExtension test's flakiness locally. Bug: 825470 Change-Id: Ib5b166cb14d3aee16b0cac9ae198a4141dc3563c Reviewed-on: https://chromium-review.googlesource.com/981610 Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
-
