- 22 Oct, 2019 40 commits
-
-
Synthia authored
If user click on Cancel button in dialog,then Dialog should be disapper and display a error message Bug: 1006820 Change-Id: I5a75da76c4b5403a824f49855f9f939de74bd984 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860734Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#708271}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0dbd897b2d65..2ba136292e50 Created with: gclient setdep -r src-internal@2ba136292e50 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:None,chromium:None Change-Id: Id9b170376df7452f60c76e4809bb13d394237da4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873286Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#708270}
-
Jasper Chapman-Black authored
Use runtime endianness check to avoid system-dependent header files. Bug: 1011921 Change-Id: I1870db11d986eb8a805c5105ed67750cb8ce2c96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873395Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Jasper Chapman-Black <jaspercb@chromium.org> Cr-Commit-Position: refs/heads/master@{#708269}
-
Chris Mumford authored
ChromeAndroidBase.version, AndroidWebview.find_binary, and ChromeAndroidBrowser._adb_run were not using the device serial supplied by the --device-serial command-line option. Additionally the device serial number was not being passed to the webdriver when running tests for Chromium on Android. Bug: None Change-Id: I3f79191a9cb556f119f7b167f363bf596591c2c8 TESTING: Manually for both Chromium and WebView. Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860676 Commit-Queue: Chris Mumford <cmumford@google.com> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#708268}
-
Scott Little authored
Before this CL, the VisibleLoadTime metrics for image elements are recorded when the image finishes loading. This means that: (a) Images that finish loading before the image element's visibility observer triggers for the first time will have their VisibleLoadTime recorded as being below-the-fold, even if the image is actually above-the-fold, (b) When automatic lazyloading is disabled, VisibleLoadTime samples will be recorded for images that finish loading even if the viewport is never scrolled near the image, meaning that many more samples will be recorded than when automatic lazyloading is enabled. To solve this, this CL changes VisibleLoadTime for images to be recorded after the image becomes visible, instead of being recorded when the image finishes loading. This also makes the metric consistent with how VisibleLoadTime is recorded for frames. Bug: 1010761 Change-Id: I2d89d413df1d49a2aa0d8974fcc188d86e0e6d92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1870109Reviewed-by:
rajendrant <rajendrant@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Scott Little <sclittle@chromium.org> Cr-Commit-Position: refs/heads/master@{#708267}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/66aae7e647fd..9122bec28506 git log 66aae7e647fd..9122bec28506 --date=short --no-merges --format='%ad %ae %s' 2019-10-22 mihu@microsoft.com Fix EXT_multisample_render_to_texture perf regression 2019-10-22 jmadill@chromium.org Metal: Move ldflags to Metal backend config. Created with: gclient setdep -r src/third_party/angle@9122bec28506 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jonahr@google.com Bug: chromium:1015031,chromium:1014228 Change-Id: I347f991a0a19706680cb3c47bfd9357dc66d7ac0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872320Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#708266}
-
danakj authored
The renderer doesn't expect emulation to be disabled if already disabled, and no need to do any work. R=yangguo@chromium.org Bug: 1015926 Change-Id: Ib35f232761ec096519af777752d327be5de99b3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868656 Auto-Submit: danakj <danakj@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#708265}
-
Ahmed Fakhry authored
This reverts commit 561b1956. Reason for revert: This solution is broken, will land a proper fix soon. Original change's description: > Fix regression that dev-shortcut to enable tablet mode doesn't show overview button > > This was a rgression caused by a previous CL of mine https://crrev.com/c/1865543. > Using the developer keyboard shortcut to enable tablet mode should > force the overview tray button visible even though the internal > input events are not being blocked. > > BUG=1016594, 925087 > TEST=Manually, added a new test. > > Change-Id: Ic9046c07dcce9de03c5fc5acd10a2077d599c711 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872468 > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> > Cr-Commit-Position: refs/heads/master@{#708222} TBR=xiyuan@chromium.org,afakhry@chromium.org Change-Id: I98c49ad99d804242adaa7172de9e74337bdecda1 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1016594, 925087 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874199Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#708264}
-
Ella Ge authored
TBR=xidachen@chromium.org No-Try: true Bug: 1008826 Change-Id: I91b36c8395da6096c553a5c3a5efee31de5cf4e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874195Reviewed-by:
Ella Ge <eirage@chromium.org> Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#708263}
-
David Black authored
Query source should be set in |AssistantInteractionMetadata| so that we have the most accurate information possible when setting the pending query source in |AssistantInteractionController::OnInteractionStarted|. This is a follow up to: https://chromium-review.googlesource.com/c/chromium/src/+/1869811 Bug: None Test: Built locally Change-Id: I18280710fc48d623c303453ab860c0b0331f071a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1870989 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Cr-Commit-Position: refs/heads/master@{#708262}
-
Tomasz Wiszkowski authored
This change introduces Android specific ZPS configuration variants. Bug: 1016557 Change-Id: I036474be17b657d608fed7f9225a0b5ace41408f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873085 Commit-Queue: Ender <ender@google.com> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#708261}
-
Guido Urdaneta authored
The old heuristic checked that the title of all windows was readable, but it failed in some corner cases where an application creates a window whose title cannot be read even with screen capture permissions. The new heuristic checks that the title of at least one normal, dock or status window running on another process is readable, which is less susceptible to failures. Drive-by: return SYSTEM_PERMISSION_DENIED instead of PERMISSION_DENIED when the system permission check fails in getDisplayMedia(). Bug: 993692 Change-Id: Ie127d1e2d6bd29dd8885b0c461bdab838559fcb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871885 Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#708260}
-
Elly Fong-Jones authored
This dialog gets its strings from a CredentialLeakDialogController. The only subclass of that class, CredentialLeakDialogControllerImpl, returns a string depending solely on its leak_type_ member, which is const. It is therefore safe to fetch the strings once at construction time and keep them. Bug: 1011446 Change-Id: I795b98548e084b1c3cf9ae389d2f41017452fb09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872571Reviewed-by:
Peter Boström <pbos@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#708259}
-
Dana Fried authored
That's it! Change-Id: I6f4fefd046345834bc68aea69e59f7bbd7574b35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873913 Commit-Queue: Dana Fried <dfried@chromium.org> Commit-Queue: Caroline Rising <corising@chromium.org> Auto-Submit: Dana Fried <dfried@chromium.org> Reviewed-by:
Caroline Rising <corising@chromium.org> Cr-Commit-Position: refs/heads/master@{#708258}
-
Maks Orlovich authored
We will restrict cookies from 3rd party contexts when they don't explicitly grant such access, and require those accessible there to be secure, so some tests need updated to mark their partiness correctly, and to not try to use insecure 3rd-party accessible cookies. Bug: 1016512 Change-Id: I86659cf72d64d26597a0be3b74793b009d5c8a6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872572Reviewed-by:
Lily Chen <chlily@chromium.org> Commit-Queue: Maksim Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#708257}
-
Wei-Yin Chen (陳威尹) authored
Bug: 991888 Change-Id: I9cf0ff45a08532377f16cbee6c063ed71fa38bdb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808582Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#708256}
-
dpapad authored
This is in preparation of converting the remaining parts of PDF Viewer to JS modules. Fixed: 1011585 Change-Id: I904ec1b03268e9d11881f4055173bcea5c952326 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842625 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#708255}
-
Min Qin authored
This CL moves the DirectoryOption and DownloadDirectoryProvider.java BUG=1013759 Change-Id: I78bef333bed85a4e34a70843caaf37ef1dbfa7de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867192Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#708254}
-
Dave Tapuska authored
Change FrameHostMsg_SetNeedsOcclusionTracking so that it is implemented in the LocalFrameHost interface. BUG=1008432 Change-Id: Ia2fb0a7da539a94790edcd8f8e6b4bf65dfa7484 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872717 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#708253}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/0b40cfb3..b8b45f95 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I9995da8a0bfcd46d137b7633fd0349dd03618676 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871906Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#708252}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/488a0bd3c7d3..e28f27831dbe git log 488a0bd3c7d3..e28f27831dbe --date=short --no-merges --format='%ad %ae %s' 2019-10-22 9856269+sarahM0@users.noreply.github.com spvc: add spvc parsing option to msl, glsl and vulkan compilers (#845) Created with: gclient setdep -r src/third_party/shaderc/src@e28f27831dbe If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=radial-bots+chrome-roll@google.com Bug: None Change-Id: I2cb892364ea20d13357757d712c4790eecbd56dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873870Reviewed-by:
-
Scott Violet authored
This is a good basic set. I would like more, but they require js injection. The fix since the last patchset is to toggle on touchend. This is necessary as we block toggling fullscreen if the page isn't active. It would appear the page is made active *after* the touchstart event. By toggling on touchend the active state is up to date. BUG=none TEST=test*Fullscreen* Change-Id: I0074aa8b1c56dbe6f35803f044437b64d0d95817 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872295 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#708250}
-
Jeremy Roman authored
When enabled, this provides browser-side enforcement precluding navigations in a portal to any origin other than the origin of its host. Bug: 1013389 Change-Id: Ia7b2a94463b3fb4ba68fcf63f0e6e56342ca20ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854150 Commit-Queue: Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#708249}
-
Jeff Yoon authored
Removing the jumbo builders. Support for jumbo logic in GN build remains. List of removed builders: * linux-jumbo-rel * mac-jumbo-rel * win-jumbo-rel * android-jumbo-rel * Jumbo Linux x64 * Jumbo Mac * Jumbo Win x64 Bug: 994387 Change-Id: Iff65cecb37bf866e992f22e0c564c1a26d420b32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872757 Commit-Queue: Jeff Yoon <jeffyoon@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#708248}
-
Ryan Hansberry authored
Change-Id: I370c12f07fe85b89d1959b4775f7d56ba0f60b8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871641Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#708247}
-
Ella Ge authored
This reverts commit 00722f1e. Reason for revert: Suspect causing UserCloudPolicyTokenForwarderTest crash https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests/15882 Original change's description: > Remove NOTIFICATION_PROFILE_ADDED from UserCloudPolicyManagerChromeOS > > Use ProfileManagerObserver::OnProfileAdded instead. > > Also worth noting that this removes an obsolete superclass from > UserCloudPolicyManagerChromeOS, i.e. KeyedService. Both KeyedService > and ConfigurationPolicyProvider have a "virtual void Shutdown()" > so this removes that collision (not that it was doing any harm). > > Bug: 268984,171406 > Change-Id: Ia0b3dd4dd34a0f62e84dd057928d61c5677231d5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854525 > Commit-Queue: Evan Stade <estade@chromium.org> > Reviewed-by: Denis Kuznetsov <antrim@chromium.org> > Cr-Commit-Position: refs/heads/master@{#707909} TBR=antrim@chromium.org,bartfab@chromium.org,estade@chromium.org Change-Id: Iacac6735ab45557c35a3c05e58e142ec26cecca7 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 268984, 171406 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874185Reviewed-by:
-
Hans Wennborg authored
Instead, version the package as e.g. n12345-3bf7fdde-0, where 12345 is the number of commits since the first commit in the git repo. Bug: 1015315 Change-Id: I1996a5268a5320276f01b9517ae29219b74892e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874165Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#708245}
-
Ella Ge authored
TBR=xiyuan@chromium.org No-Try: true Bug: 1016843 Change-Id: I736070c19d82cc5e8cafe614e6bb568363d8fc6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873401Reviewed-by:
-
Brandon Walderman authored
This change updates ChromeDriver to use a BRANDING file to manage vendor -specific strings, similar to how this is done in the browser itself. This should make it easier for Chromium forks such as MSEdge to apply their own branding to the WebDriver binary in addition to the browser. The BRANDING file is used to generate a version.h/.cc files which contain constants for the driver name, company prefix (for extension capabilities), and browser name. Hard-coded references to "Chrome", "ChromeDriver" or "Google" have been updated to use these constants instead. This also has the advantage of gathering these terms in one place so they can easily be updated in the future. This change does not yet cover renaming the executable itself. Also, branded strings in the python test suite and unit tests files have been left as is. It seemed like templatizing the test code would make it harder to read. It might be neater to just let downstream forks of Chromium such as MSEdge handle updating the strings in the unit tests. Bug: 1012965 Change-Id: I7b47e74026598cc71dd093399cdee3940defee2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864462 Commit-Queue: Brandon Walderman <brwalder@microsoft.com> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#708243}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/d15a0283d1d8..13a8e162476b git log d15a0283d1d8..13a8e162476b --date=short --no-merges --format='%ad %ae %s' 2019-10-22 sprang@webrtc.org Cleanup use of deprecated PacketRouter methods 2019-10-22 minyue@webrtc.org Reduce log level of Opus bitrate. Created with: gclient setdep -r src/third_party/webrtc@13a8e162476b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None Change-Id: I6efe133e6c24614c672540cca8fb5fe75b291dde Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873279Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/e25df6cf7879..9f2b86c54d32 git log e25df6cf7879..9f2b86c54d32 --date=short --no-merges --format='%ad %ae %s' 2019-10-22 bsalomon@google.com More SkISizification in GPU code. 2019-10-22 herb@google.com Revert "Use common fallback code for drawing an SkGlyphRun" 2019-10-22 egdaniel@google.com Add SurfaceProxyView support to Surface/TextureContext. 2019-10-22 jvanverth@google.com Enable Programs (formerly GLPrograms) test for other APIs 2019-10-22 fmalita@chromium.org [skottie] Site update 2019-10-22 fmalita@chromium.org [skottie] Expose native frame rate and seekFrame() in WASM 2019-10-22 egdaniel@google.com Add GrSurfaceProxyView and add support for it on GrRenderTargetContext. Created with: gclient setdep -r src/third_party/skia@9f2b86c54d32 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC michaelludwig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=michaelludwig@google.com Bug: None Change-Id: I8d8a7ecbf75930b1022c8013db78fce75d918162 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873280Reviewed-by:
-
Joe DeBlasio authored
This CL removes the now-removed /chrome/browser/resources/safety-tips directory, and adds the forgotten /chrome/browser/reputation directory, to the Safety Tips watchlist definition. Change-Id: Ic38c362f0557e5b94e8f33beffaa58385bf727f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873387 Auto-Submit: Joe DeBlasio <jdeblasio@chromium.org> Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#708240}
-
Xiyuan Xia authored
Regressed in https://crrev.com/c/1825892 that uses a wrong transform in PartialBoundsRootWindowTransformer. Bug: 1016565 Change-Id: I56febc2515f2abe26853db6292064de27d3a4e81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873909 Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
-
Sammie Quon authored
Before: https://screenshot.googleplex.com/FJyL5zborbs https://screenshot.googleplex.com/ADhhbeZN1Ee After: https://screenshot.googleplex.com/ef9cyxjNxQQ https://screenshot.googleplex.com/c6MGGiOOhFv The real change is from Base -> PS1. After that, most of the change is moving a function from private to public to expose it. Test: manual Bug: 1011973 Change-Id: I7bb2aab1440a8c1e8db16c81ea2b038b1481db6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872761 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#708238}
-
Caroline Rising authored
Bug: 959933 Change-Id: I27dc0c52bec3b010e6f70417c9616f375adac146 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872773 Commit-Queue: Caroline Rising <corising@chromium.org> Reviewed-by:
-
Emily Stark authored
This CL duplicates some of the basic Safety Tips tests for incognito mode, checking that the site engagement checks and component updater work as expected. Bug: 1003417 Change-Id: Ic4faaa2e046f0d96d07dcd26fd2859615c8be4d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874047 Commit-Queue: Emily Stark <estark@chromium.org> Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Reviewed-by:
Joe DeBlasio <jdeblasio@chromium.org> Cr-Commit-Position: refs/heads/master@{#708236}
-
Mikhail Khokhlov authored
Before this CL Results Processor did its processing in several stages: aggregating traces for all tests in parallel, then computing metrics for all tests in parallel, and so on. Now we move the parallelization to the upper level, so that all processing for a particular test is done inside one thread. This allows us to: 1) Make processing of tests independent, so that errors in one of them do not affect others. 2) Mark the tests with failures 'FAIL' in the final results. 3) Add test-specific diagnostics to histograms. Also we add support for the new intermediate results format (where there are no benchmarkRun messages; all metadata is contained in testResults). Bug: 981349, 1015192 Change-Id: I75d036a3ded439e092ee7b892a26bc26f3600520 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869212 Commit-Queue: Mikhail Khokhlov <khokhlov@google.com> Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#708235}
-
Peter Kasting authored
Bug: 82078 Change-Id: If8d5f52bc9f36fc1dc5b50c7d7f4301a51b59dc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867816 Auto-Submit: Peter Kasting <pkasting@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#708234}
-
Akihiro Ota authored
This change adds a new ChromeVox keyboard command to announce the url behind the currently selected link. If no link is selected, the command does nothing. This change also adds a test to verify correct behavior. Bug: 690196. Change-Id: Iecacb0bcf71657be4c1ea17221ad1f031542b273 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860482Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Cr-Commit-Position: refs/heads/master@{#708233}
-
Adam Ettenberger authored
Recently there have been performance improvements in ui/accessibility. This CL creates BUILD.gn entry for accessibility_perftests.exe which will be used to run performance tests for this directory. With this CL, I'm adding perf tests for the following methods : AXPosition<>::AsTreePosition AXPosition<>::AsLeafTextPosition Bug: 928948 Change-Id: Iedbb274868a42009766de31d6f8b8731640847e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838264Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Adam Ettenberger <adettenb@microsoft.com> Cr-Commit-Position: refs/heads/master@{#708232}
-
