- 27 Feb, 2019 40 commits
-
-
sczs authored
Bug: 911864 Change-Id: I98b9992822b6432ad2531f77b5749192e143dc52 Reviewed-on: https://chromium-review.googlesource.com/c/1488060Reviewed-by:
Peter Lee <pkl@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#635904}
-
Josh Pratt authored
Changes the /crostini/shared_usb_devices page in crostini settings to more closely match /crostini/shared_paths and other settings UI. Bug: 930588 Change-Id: I14ec8a58ce4b263520efbdcd317281a30de3d2ad Reviewed-on: https://chromium-review.googlesource.com/c/1477569 Commit-Queue: Josh Pratt <jopra@chromium.org> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#635903}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f90ad85cf0cc..75e6934397d8 Created with: gclient setdep -r src-internal@75e6934397d8 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ia70c65cc11bd368ed3f501bcf69ae3a322f22f47 Reviewed-on: https://chromium-review.googlesource.com/c/1490389Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#635902}
-
Gayane Petrosyan authored
Remove blue rectange for focused element with .using-mouse-nav class. Previously CSS selector only selected children of .using-mouse-nav element that are focused. Bug: 935252 Change-Id: I338d995ab02076fc9fb671c660d8f397dd1a6898 Reviewed-on: https://chromium-review.googlesource.com/c/1490734Reviewed-by:
Kristi Park <kristipark@chromium.org> Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Cr-Commit-Position: refs/heads/master@{#635901}
-
Findit authored
This reverts commit d7c1e86c. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 635829 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2Q3YzFlODZjMzNjNDIzMjJmMWQ0M2QwOTU3NmUyZjNjNDFhOGUyNDEM Sample Failed Build: https://ci.chromium.org/buildbot/chromium.memory/Linux%20ChromiumOS%20MSan%20Tests/11520 Sample Failed Step: browser_tests Original change's description: > Delay querying for printers list until the policy file is parsed > > A list of enterpise printers is not ready immediately after creation of > CupsPrintersManager. It caused a problem for testing procedure since from the > level of autotest_private_api we do not know if the final list is ready or > there are still some ongoing calculations. A new method called > OnEnterprisePrintersInitialized() was added to the observer of > CupsPrintersManager to solve this issue. Also whole code related to > enterprise printers were refactored, large part of functionality was moved > from SyncedPrintersManager to new class EnterprisePrintersProvider. Classes > ExternalPrintersPrefBridge and DeviceExternalPrintersSettingsBridge have been > merged into one class called CalculatorsPoliciesBinder. > > BUG=chromium:816996 > TEST=Tested on nautilus with the use of CL:1451591 > > Change-Id: I50745f18beacab213216e5f367db0d023190e9e4 > Reviewed-on: https://chromium-review.googlesource.com/c/1220547 > Commit-Queue: Piotr Pawliczek <pawliczek@chromium.org> > Reviewed-by: Achuith Bhandarkar <achuith@chromium.org> > Reviewed-by: Maksim Ivanov <emaxx@chromium.org> > Reviewed-by: Sean Kau <skau@chromium.org> > Auto-Submit: Piotr Pawliczek <pawliczek@chromium.org> > Cr-Commit-Position: refs/heads/master@{#635829} No-Presubmit: true No-Tree-Checks: true No-Try: true BUG=chromium:816996 Change-Id: I03bae898e61c3107977268bf33d1582fe6eacb81 Reviewed-on: https://chromium-review.googlesource.com/c/1491134 Cr-Commit-Position: refs/heads/master@{#635900}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/71865048224b..620621059b29 git log 71865048224b..620621059b29 --date=short --no-merges --format='%ad %ae %s' 2019-02-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 6c9fb0e6353c..ead1a345a36c (1 commits) 2019-02-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 9f20dd777b50..009696c56169 (2 commits) 2019-02-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 1bc7ee95f75b..6c9fb0e6353c (1 commits) 2019-02-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 7f6f891204d0..1bc7ee95f75b (1 commits) Created with: gclient setdep -r src/third_party/skia@620621059b29 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=scroggo@chromium.org Change-Id: If647d6f17d71ff6a9dcf0369458ddfb038e7164c Reviewed-on: https://chromium-review.googlesource.com/c/1490390Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#635899}
-
Miyoung Shin authored
- unsigned short -> uint16_t. - No logic changes. - Reference: https://google.github.io/styleguide/cppguide.html#Integer_Types Bug: 929986 Change-Id: Idddb94ba48c84b22cbaea850ae2c6d394759d50e Reviewed-on: https://chromium-review.googlesource.com/c/1490360Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@chromium.org> Cr-Commit-Position: refs/heads/master@{#635898}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/9e723d07..32291a4d Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ie0ce355f61c0b301fd0b0f4f8ca9cc114ac9574c Reviewed-on: https://chromium-review.googlesource.com/c/1490908Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#635897}
-
Istiaque Ahmed authored
Do not create new LazyContextIds when existing ones can be used. Bug: None Test: No visible side-effect expected. Change-Id: Id8837392f74e07efa1efa200fd87789cddc866e3 Reviewed-on: https://chromium-review.googlesource.com/c/1487204 Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#635896}
-
Kent Tamura authored
Form-associated custom elements: ElementInternals methods should throw NotSupportedError instead of InvalidStateError to match to the latest specification pull request [1]. Also, 'labels' attribute should throw a NotSupportedError. [1] https://github.com/whatwg/html/pull/4383 Change-Id: Ie1679e0746d72d5f2c06423eba70d8f570b61911 Bug: 905922 Reviewed-on: https://chromium-review.googlesource.com/c/1491055 Commit-Queue: Kent Tamura <tkent@chromium.org> Commit-Queue: Hayato Ito <hayato@chromium.org> Auto-Submit: Kent Tamura <tkent@chromium.org> Reviewed-by:
Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#635895}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. The AutoRoll server is located here: https://autoroll.skia.org/r/afdo-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: I3068e0a434d19a30c14a66a83f7abd11a9343909 Reviewed-on: https://chromium-review.googlesource.com/c/1491111Reviewed-by:
-
Rakina Zata Amni authored
TBR=hiroshige@chromium.org Bug: 936279 Change-Id: Ia3f9de79ab04d0b360d5bee164b9263eb0040ea7 Reviewed-on: https://chromium-review.googlesource.com/c/1491057 Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
Rakina Zata Amni <rakina@chromium.org> Cr-Commit-Position: refs/heads/master@{#635893}
-
Yoichi Osato authored
This patch fixes LocalSelectionRect rect for vertical-rl. It should be flipped physical. This is similar to previous koji's work: crrev.com/c/1457812 Test invalidation reason is also updated because if a LayoutText is selected, visual rect is expanded and it is (miss)recognized as geometry(full) invalidation: https://cs.chromium.org/chromium/src/third_party/blink/renderer/core/paint/object_paint_invalidator.cc?l=266 In legacy, this occurs when the selection includes the link break (which is not covered by the original visual rect of LayoutText but covered by the selection visual rect). For now this is a drawback of using LayoutText's visual rect for fragments. We'll improve this in the future when combining FragmentData and NGPaintFragment and use their real visual rects instead of LayoutText's (because LayoutText's visual rect will no longer need to include selection visual rect). Selection update within a line will still use partial selection invalidation for both NG and legacy. Bug: 930034 Change-Id: I4fa3e41797655bd6b436b798f25e8b7012ac05d8 Reviewed-on: https://chromium-review.googlesource.com/c/1484398 Commit-Queue: Yoichi Osato <yoichio@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#635892}
-
Xianzhu Wang authored
1. Set opacity to 0 which is the final value of the animation to avoid the glitch at the end of the animation. 2. Make element id consistent with other BGPT animations. Bug: 933754 Change-Id: I05fd00d4ce3a42242f6455ab72440bea0821cbdf Reviewed-on: https://chromium-review.googlesource.com/c/1479880 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#635891}
-
Kent Tamura authored
to match to the latest pull request [1]. - If the element has zero-length name attribute, it should not add an entry. - The first argument of setFormValue() should be nullable, and the null value should add no entry. [1] https://github.com/whatwg/html/pull/4383 Bug: 905922 Change-Id: I5bcacd633e43050e5065682043d126359bdeca7c Reviewed-on: https://chromium-review.googlesource.com/c/1491051 Auto-Submit: Kent Tamura <tkent@chromium.org> Commit-Queue: Hayato Ito <hayato@chromium.org> Reviewed-by:
-
Paul Wankadia authored
https://chromium.googlesource.com/external/github.com/google/re2.git/+log/59f03f30627f..96b75fa24527 $ git log 59f03f306..96b75fa24 --date=short --no-merges --format='%ad %ae %s' 2019-02-25 junyer Make the fuzzer handle \p and \P specially. 2019-02-25 junyer Check onepass_nodes_.data(), not .size(). 2019-02-25 ckennelly Use PODArray<> for OnePass nodes. 2019-02-13 junyer Update the Erlang wrapper URL. Created with: roll-dep src/third_party/re2/src R=mmoroz@chromium.org Bug: 930554 Change-Id: I994603e42d48137999ed53b2b8c85cf66afd32f6 Reviewed-on: https://chromium-review.googlesource.com/c/1488022Reviewed-by:
Max Moroz <mmoroz@chromium.org> Commit-Queue: Paul Wankadia <junyer@chromium.org> Cr-Commit-Position: refs/heads/master@{#635889}
-
rbpotter authored
This is needed so that pages using the polyfill will still work with Polymer 1. Polymer 1 is currently tested on the bots and is expected to be supported through at least M-74. Bug: 925517 Change-Id: Iabe257fb1228dd9803403dd478889080bba64962 Reviewed-on: https://chromium-review.googlesource.com/c/1484506 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#635888}
-
Esmael El-Moslimany authored
cr-link-row is used by with a subpage arrow or a external link icon. This change streamlines the way that these two modes are specified by introducing a boolean flag |external| with a default of false. This is tangentially related to the work of replacing paper-icon-button with cr-icon-button. Bug: 736891 Change-Id: I741d2292e41c4c014d27286e3c2c4fabd93fd71b Reviewed-on: https://chromium-review.googlesource.com/c/1464431Reviewed-by:
-
Abhijeet Kandalkar authored
network_hints.h is only used by core/loader. Hence this CL moves network_hints.h to core/loader and port other dependent files to refer to a new include path. Bug: 933883 Change-Id: Iaf8847348f3f174afcdd5b34a99aa045ee3b0cad Reviewed-on: https://chromium-review.googlesource.com/c/1484873 Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#635886}
-
Owen Rodley authored
Change-Id: I24e2ce9d712e2d5d1c2fb619216395aa6cf7a1be Reviewed-on: https://chromium-review.googlesource.com/c/1490369 Auto-Submit: Owen Rodley <orodley@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#635885}
-
Alexey Baskakov authored
Refactor CreateOsShortcuts util. CreateOsShortcuts and PinAppToShelf are unrelated steps. Bug: 915043 Change-Id: I67cb8e2685e96149ec88fb3cd20c9383e4e35d6c Reviewed-on: https://chromium-review.googlesource.com/c/1491052Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#635884}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/d56f8d2e0501..738567f148b2 git log d56f8d2e0501..738567f148b2 --date=short --no-merges --format='%ad %ae %s' 2019-02-27 shaobo.yan@intel.com Validate buffer to buffer copy size to be a multiple of 4 bytes Created with: gclient setdep -r src/third_party/dawn@738567f148b2 The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: I7f59616fdf179dd9a0eef5396f3f9f232db4fbb5 Reviewed-on: https://chromium-review.googlesource.com/c/1490387Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/3ee6a6225e33..b400da62cf14 git log 3ee6a6225e33..b400da62cf14 --date=short --no-merges --format='%ad %ae %s' 2019-02-27 saklein@chromium.org Build API: Make autotest more generic. 2019-02-27 bpastene@chromium.org cros_chrome_sdk: Fetch the chromeos-base/tast-* packages when entering the SDK. 2019-02-27 vapier@chromium.org image_test: allow /usr/share/misc/magic.mgc in base images 2019-02-27 lamontjones@chromium.org buildstore: Redirect GetSlaveStatuses. 2019-02-27 nednguyen@google.com board_build_dependency: fix breakage of query dependencies for "whirlwind" board 2019-02-27 gmeinke@chromium.org scheduler stage: propagate cbb_snapshot_revision 2019-02-27 gmeinke@chromium.org cbuildbot: set properties for Findit integration 2019-02-27 derat@chromium.org chromite: Run bvt-tast-informational suite. Created with: gclient setdep -r src/third_party/chromite@b400da62cf14 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@chromium.org Change-Id: Ifa73ca8c1edc568bd98ce7586d2dc340dd73d9f9 Reviewed-on: https://chromium-review.googlesource.com/c/1490525Reviewed-by:
-
Rakina Zata Amni authored
Previously, locked subtrees are skipped when doing find-in-page. With this change, we force updates to activatable locked subtrees that affect the block we're currently doing find-in-page in so that we can do find-in-page on activatable-locked nodes with guaranteed updated style & layout values. This change makes the total match count include matches that are in activatable-locked subtrees, but this change doesn't make the locked matches navigable (e.g. highlighted and can be scrolled to with find next/prev arrow buttons). That functionality will be added in a different CL. Bug: 882663 Change-Id: Icf7cec63959f7b429bbdbcaa671bf9ef5caa661e Reviewed-on: https://chromium-review.googlesource.com/c/1477466 Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#635881}
-
Justin Cohen authored
When correcting the NavigationItem URL, such as a restore targetURL, don't reset the visible URL. Doing so breaks navigating back to an NTP by overwriting the NTP's visible URL. Change-Id: If220cf65ff5bebae72e7a7e42c5ba94beab3e170 Reviewed-on: https://chromium-review.googlesource.com/c/1490056 Commit-Queue: Justin Cohen <justincohen@chromium.org> Auto-Submit: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#635880}
-
Antonio Gomes authored
R=haraken@chromium.org CC=blink-reviews-vendor@chromium.org BUG=891908 Change-Id: I0156c1ba2fad75f50678d6446b53b1bf1b6b9ae9 Reviewed-on: https://chromium-review.googlesource.com/c/1489953 Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
-
Rakina Zata Amni authored
Revert "Remove mojo-blob-urls virtual test suites now that network service has launched on desktop and trunk is running with it enabled." This reverts commit 868af228. Reason for revert: 3 external/wpt/FileAPI tests failure causes failed builds on non_network_service_webkit_layout_tests (see crbug.com/936237) Original change's description: > Remove mojo-blob-urls virtual test suites now that network service has launched on desktop and trunk is running with it enabled. > > Bug: 933880 > Change-Id: I3fbc8b037126ddefe75fa1400e89486cc22d214c > Reviewed-on: https://chromium-review.googlesource.com/c/1488834 > Commit-Queue: John Abd-El-Malek <jam@chromium.org> > Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> > Auto-Submit: John Abd-El-Malek <jam@chromium.org> > Reviewed-by: Marijn Kruisselbrink <mek@chromium.org> > Cr-Commit-Position: refs/heads/master@{#635708} TBR=jam@chromium.org,mek@chromium.org Change-Id: Iab8bcf874a288ffec625b9b51094d8bdcfa372a3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 933880 Reviewed-on: https://chromium-review.googlesource.com/c/1491061Reviewed-by:
-
Yuwei Huang authored
This CL makes FtlClient async such that it makes the RPC call asynchronously and runs the callback after the response is received. Bug: 927962 Change-Id: Id1399f3edc381f0acca7780aca2959a4aa1a3737 Reviewed-on: https://chromium-review.googlesource.com/c/1487960 Commit-Queue: Yuwei Huang <yuweih@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#635877}
-
John Chen authored
This is a reland of 4fe92e6c Original change's description: > [ChromeDriver] Remove unused shadow DOM object cache > > ChromeDriver uses object caches for use while calling JavaScript > functions. The data structure was designed to allow a separate cache for > each shadow DOM, but that feature was never used, and objects in shadow > DOMs have always been stored in the main page cache. This CL removes > unused code, and resolves differences between test expectancies and > actual code behavior. It prepares for future changes to make the object > cache standard compliant. > > Bug: chromedriver:1461 > Change-Id: I10fcd94a7fd2359cc43fe6bc7241d36647e9d744 > Reviewed-on: https://chromium-review.googlesource.com/c/1485011 > Commit-Queue: John Chen <johnchen@chromium.org> > Reviewed-by: Caleb Rouleau <crouleau@chromium.org> > Cr-Commit-Position: refs/heads/master@{#635754} Bug: chromedriver:1461 chromedriver:2794 Change-Id: Iedd6b7e43eb256d65bf71fec7e66454ceb0f776c Reviewed-on: https://chromium-review.googlesource.com/c/1490855Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#635876}
-
iOS Autoroller authored
TBR=smut Change-Id: I0794b5eceb8cf1a481b5a060ca9881bec97c4993 Reviewed-on: https://chromium-review.googlesource.com/c/1490635Reviewed-by:
iOS Autoroller <ios-autoroller@chromium.org> Commit-Queue: iOS Autoroller <ios-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#635875}
-
Erik Luo authored
Dragging the cursor in Elements results in a new blank property, whenever there is no text selection. This is not ideal when users select text, then unselect text within the same mousedown-up phase. Screenshot: https://imgur.com/a/xZoos2r Bug: 929536 Change-Id: Ic9800dbb5c37d93943154bc4af71dd88965c633a Reviewed-on: https://chromium-review.googlesource.com/c/1413400 Commit-Queue: Erik Luo <luoe@chromium.org> Reviewed-by:
Joel Einbinder <einbinder@chromium.org> Cr-Commit-Position: refs/heads/master@{#635874}
-
Khushal authored
BufferQueue maintains tracking for damage in previous frames, and copies it to the buffer for the current frame for partial swap. But because the copy happens after generating the ready fence for the OutputSurface's overlay, this creates a synchronization bug where the display controller could try to read from this overlay while the GPU is still writing to it. Avoid this by notifying the OutputSurface of the damage for the current frame before the ready fence is generated. R=piman@chromium.org Bug: 889530 Change-Id: Ic9e099c0bea7b8c990d1485d581590ee3ce81b77 Reviewed-on: https://chromium-review.googlesource.com/c/1487884 Commit-Queue: Khushal <khushalsagar@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#635873}
-
Martin Kreichgauer authored
WebAuthn requests originating from cryptotoken are executed in the RenderFrame of the cryptotoken background page. Hence, navigation events in the U2F request's sender tab have no influence over the lifetime of the request. This means the corresponding WebAuthn request lives on until it eventually times out; new requests are immediately resolved with a PENDING_REQUEST error in the meantime. As a workaround, have AuthenticatorImpl cancel any pending request, when a new request from the cryptotoken extension arrives. This will make the post-reload u2f request cancel the zombie pre-reload request. However, it will also make subsequent requests (across tabs) cancel any pending requests, whereas before cryptotoken proxying requests would have been queued. Bug: 935480 Change-Id: I6c8986ab010d687efae14927328d3a3eb900ea4a Reviewed-on: https://chromium-review.googlesource.com/c/1490892 Commit-Queue: Martin Kreichgauer <martinkr@google.com> Commit-Queue: Adam Langley <agl@chromium.org> Reviewed-by:
Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#635872}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/4dbb96dfaa04..71865048224b git log 4dbb96dfaa04..71865048224b --date=short --no-merges --format='%ad %ae %s' 2019-02-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 54c4772e855c..7f6f891204d0 (1 commits) 2019-02-26 csmartdalton@google.com Reland "Stack-allocate pipelines for GrMeshDrawOp" 2019-02-26 mtklein@google.com remove mention of SkPaintDefaults_Flags 2019-02-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 8adf1fcd08d0..54c4772e855c (1 commits) Created with: gclient setdep -r src/third_party/skia@71865048224b The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=scroggo@chromium.org Change-Id: I6027cf020b20d2afb2ca6ce6ff12492a9194b867 Reviewed-on: https://chromium-review.googlesource.com/c/1490380Reviewed-by:
-
Maggie Chen authored
The z order of an underlay should be a decreasing number for each underlay layer at the bottom. It doesn't have to be a contiguous number though. Bug: 868561 Change-Id: I3ba9afbd9f02404ca23f416a464f18c30771b962 Reviewed-on: https://chromium-review.googlesource.com/c/1488151 Commit-Queue: Maggie Chen <magchen@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#635870}
-
Yuzu Saijo authored
When OomIntervention is performed on an iframe, its lifecycle becomes kV8MemoryIsForciblyPurged. And then it is possible that the iframe gets detached, and lifecycle moves to kFrameIsDetachedAndV8MemoryIsPurged. This CL allows this transition to happen. Also it changes the name of lifecycle from kForciblyPurgedV8Memory to kV8MemoryIsForciblyPurged. Change-Id: Id1459ec99fdac840bcb3dc4b3355002af77c57ac Reviewed-on: https://chromium-review.googlesource.com/c/1445341Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Keishi Hattori <keishi@chromium.org> Reviewed-by:
-
Wenzhao Zang authored
The mock is at https://docs.google.com/document/d/1Ai-U_4n5Clfc7ni6XVwhTev9XnPaEa1WyNLlnHGsKqs/edit#heading=h.e2ilewob1a3d Bug: 888733 Change-Id: I7568aa3600c639068d0c9d393381281fd4d649db Reviewed-on: https://chromium-review.googlesource.com/c/1471463 Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#635868}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/f6100576bcc4..0d1d8c12e826 git log f6100576bcc4..0d1d8c12e826 --date=short --no-merges --format='%ad %ae %s' 2019-02-27 benjhayden@chromium.org Serialize a new HistogramSet JSON format. 2019-02-26 benjhayden@chromium.org Add cursor lines to chart-base. Created with: gclient setdep -r src/third_party/catapult@0d1d8c12e826 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:918208,chromium:918193 TBR=sullivan@chromium.org Change-Id: If58b5d2b2bdc4da318e72e694128b369e9f4c25d Reviewed-on: https://chromium-review.googlesource.com/c/1490386Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f9240dad68dd..f90ad85cf0cc Created with: gclient setdep -r src-internal@f90ad85cf0cc The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I823cbb177337ce96820b7a6ac5c9cabc30d6e733 Reviewed-on: https://chromium-review.googlesource.com/c/1490384Reviewed-by:
-
Yuli Huang authored
BUG=b:117816926 TEST=Tested by taking pictures and checking GA traffic. Change-Id: I984a0cd69d9977f2b3faf2b3054c1156340e268c Reviewed-on: https://chromium-review.googlesource.com/c/1484876Reviewed-by:
Sheng-hao Tsao <shenghao@google.com> Commit-Queue: yuli <yuli@chromium.org> Cr-Commit-Position: refs/heads/master@{#635865}
-
