- 06 Apr, 2015 14 commits
-
-
dgozman authored
BUG=469421 Review URL: https://codereview.chromium.org/1047653003 Cr-Commit-Position: refs/heads/master@{#323902}
-
hirono authored
Previously the width of input box exceeded the width of container, and it got other components in the same component scrolled out. BUG=472582 TEST=manually Review URL: https://codereview.chromium.org/1063663002 Cr-Commit-Position: refs/heads/master@{#323901}
-
dgozman authored
BUG=472077 Review URL: https://codereview.chromium.org/1054253004 Cr-Commit-Position: refs/heads/master@{#323900}
-
peria authored
Move getGCReason() and two string definitions into _AddTracingResults() BUG=438074 TEST=./tools/perf/run_tests oilpan --browser=content-shell-release Review URL: https://codereview.chromium.org/1067503002 Cr-Commit-Position: refs/heads/master@{#323899}
-
hirono authored
Previously Gallery adds image items to its model after fetching the metadata. Because items are added by chunk, users cannot see all the items before load completes. It causes strange behavior e.g. users may move from the last item of the current chunk to the first item when the next chunk has not been loaded. The CL lets Gallery add all items to the model without fetching metadata. And then, lets Gallery dispatch 'content' event to update thumbnails after fetching metadata. BUG=chrome-os-partner:33931 TEST=manually Review URL: https://codereview.chromium.org/853653004 Cr-Commit-Position: refs/heads/master@{#323898}
-
yoshiki authored
This patch make the menus in Files.app accessible by Chromevox. This patch works: - Make the menuitems focusable - Even the elements get lost focus, don't focus to the mainview BUG=465938 TEST=manually tested Review URL: https://codereview.chromium.org/1052343004 Cr-Commit-Position: refs/heads/master@{#323897}
-
chromeos-commit-bot authored
Cr-Commit-Position: refs/heads/master@{#323896}
-
je_julie.kim authored
Adds AX role of <details> element for blink layout tests. BUG=N/A R=dmazzoni Review URL: https://codereview.chromium.org/1066503002 Cr-Commit-Position: refs/heads/master@{#323895}
-
shreeram.k authored
This test case would be enabled after this blink CL https://codereview.chromium.org/1045693002/ rolls in. BUG=471152 Review URL: https://codereview.chromium.org/1059983002 Cr-Commit-Position: refs/heads/master@{#323894}
-
hirono authored
We have progress bar on dialog footer, and it should show for file open dialog that needs local cache file for drive files. (e.g. dialog called by NPAPI plugin) Also the CL adjust mergin so that "Preparing..." label should be placed with the correct margin no matter if the "New directory" button is shown or not. BUG=459876 TEST=manually Review URL: https://codereview.chromium.org/1056413002 Cr-Commit-Position: refs/heads/master@{#323893}
-
hirono authored
The CL extracts existing code as utility methods so that they can be used by newly added BatchRequest class. BUG=451917 TEST=None Review URL: https://codereview.chromium.org/1053623004 Cr-Commit-Position: refs/heads/master@{#323892}
-
skia-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/skia/+log/aa4c7a7..26fc1bf CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel TBR=msarett@google.com Review URL: https://codereview.chromium.org/1065533002 Cr-Commit-Position: refs/heads/master@{#323891}
-
kochi authored
This is for https://codereview.chromium.org/1058723004/ in Blink, to add "tabStop" property/attribute stats. BUG=380445 TBR=isherman Review URL: https://codereview.chromium.org/1059153002 Cr-Commit-Position: refs/heads/master@{#323890}
-
yoshiki authored
In menu.js, the Menu.menuItemSelector is refereed in the decorator, so we need to set it before decoration BUG=none TEST=manually tested Review URL: https://codereview.chromium.org/1053123003 Cr-Commit-Position: refs/heads/master@{#323889}
-
- 05 Apr, 2015 4 commits
-
-
grt authored
BUG=412045, 454716 R=anthonyvd@chromium.org Review URL: https://codereview.chromium.org/1062693002 Cr-Commit-Position: refs/heads/master@{#323888}
-
rtenneti authored
Fix is to notify the factory about session being closed. BUG=473884 R=rch@chromium.org Review URL: https://codereview.chromium.org/1056263002 Cr-Commit-Position: refs/heads/master@{#323887}
-
oth authored
isolate_holder.h is public and used by blink and therefore cannot refer to types from base. As part of porting this to other platforms we needed to load snapshots from BaseFile descriptors. BUG=421063 Review URL: https://codereview.chromium.org/1011133006 Cr-Commit-Position: refs/heads/master@{#323886}
-
haraken authored
This reverts commit 3f8a241f. This was a wrong optimization to "improve" the performance of Speedomenter. We shouldn't have landed a change that is not adopted in the upstreamed Speedometer. TBR=peria@chromium.org Review URL: https://codereview.chromium.org/1064433003 Cr-Commit-Position: refs/heads/master@{#323885}
-
- 04 Apr, 2015 22 commits
-
-
tfarina authored
It is already done. BUG=461019 R=dpranke@chromium.org CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:android_chromium_gn_compile_dbg,android_chromium_gn_compile_rel;tryserver.chromium.win:win8_chromium_gn_rel,win8_chromium_gn_dbg;tryserver.chromium.mac:mac_chromium_gn_rel,mac_chromium_gn_dbg Review URL: https://codereview.chromium.org/1054753003 Cr-Commit-Position: refs/heads/master@{#323884}
-
tfarina authored
They were basically including it for DISALLOW macros. BUG=138542 TEST=sandbox_linux_unittests R=mdempsky@chromium.org Review URL: https://codereview.chromium.org/1065503002 Cr-Commit-Position: refs/heads/master@{#323883}
-
vasilii authored
BUG=468474 Review URL: https://codereview.chromium.org/1028243004 Cr-Commit-Position: refs/heads/master@{#323882}
-
tfarina authored
The implementation of HashExtensionId() is identical to the one in id_util.h BUG=384613 TEST=extensions_unittests R=rockot@chromium.org Review URL: https://codereview.chromium.org/1051413003 Cr-Commit-Position: refs/heads/master@{#323881}
-
rob authored
De-duplicated the logic for contextMenus custom bindings. And changed the contextMenus.update method, so that calling it with "onclick: null" will remove the onclick handler. BUG=461869 TEST=browser_tests ExtensionContextMenuBrowserTest.UpdateOnclick Review URL: https://codereview.chromium.org/948243005 Cr-Commit-Position: refs/heads/master@{#323880}
-
chrome://inspectrob authored
BUG=337765 R=pfeldman@chromium.org NOTRY=true TEST=Visit chrome://inspect, apply the CSS changes then compare the result with the previous version. Open many tabs (to overflow #pages), then click on the Pages tab. Old version: No spacing at top (= crbug.com/337765). New version: Space still appears at the top. Review URL: https://codereview.chromium.org/946713002 Cr-Commit-Position: refs/heads/master@{#323879}
-
dcheng authored
BUG= Review URL: https://codereview.chromium.org/1052123002 Cr-Commit-Position: refs/heads/master@{#323878}
-
dcheng authored
Summary of changes available at: https://chromium.googlesource.com/chromium/blink/+log/54ac8d7..f0c2b57a TBR=haraken@chromium.org,jsbell@chromium.org Review URL: https://codereview.chromium.org/1062663002 Cr-Commit-Position: refs/heads/master@{#323877}
-
chromeos-commit-bot authored
Cr-Commit-Position: refs/heads/master@{#323876}
-
cjhopman authored
BUG=454477,471439 Review URL: https://codereview.chromium.org/1051673002 Cr-Commit-Position: refs/heads/master@{#323875}
-
gunsch authored
R=halliwell@chromium.org,lcwu@chromium.org BUG=internal b/19963256 Review URL: https://codereview.chromium.org/1051083003 Cr-Commit-Position: refs/heads/master@{#323874}
-
gunsch authored
See: https://codereview.chromium.org/1028853002 R=reveman@chromium.org,lcwu@chromium.org BUG=None Review URL: https://codereview.chromium.org/1055793004 Cr-Commit-Position: refs/heads/master@{#323873}
-
erikchen authored
The benchmarks are taking longer than 30 seconds to start up Chrome. This could be a sign that the large profile is working very well on slow machines! Disable the benchmark while I investigate further. BUG=473827 Review URL: https://codereview.chromium.org/1061683002 Cr-Commit-Position: refs/heads/master@{#323872}
-
chrome-tpm authored
Cr-Commit-Position: refs/heads/master@{#323871}
-
fahl authored
BUG=461589 Review URL: https://codereview.chromium.org/1035023002 Cr-Commit-Position: refs/heads/master@{#323870}
-
kalman authored
There are high crash rates caused by invalid ScriptContexts and it's unclear which of these patches is causing them - potentially all of them. Reverting all to be safe, and because they stomped on each other and can't be reverted separately. Revert "Move Extension ScriptContext creation into ScriptContextSet." This reverts commit 745b6623. Revert "[Extensions] extension sendMessage respect to ActiveDOMObject policy" This reverts commit 441ece58. Revert "Add back the call to extensions::ScriptContext::DispatchOnUnloadEvent." This reverts commit 0eda971a. Revert "[Extensions] Fix crash in ScriptContextSet" This reverts commit a08a3109. BUG=471599 TBR=rdevlin.cronin@chromium.org Review URL: https://codereview.chromium.org/1064473003 Cr-Commit-Position: refs/heads/master@{#323869}
-
anandc authored
BUG= Review URL: https://codereview.chromium.org/1059893002 Cr-Commit-Position: refs/heads/master@{#323868}
-
dbeam authored
R=tbreisacher@chromium.org BUG=none Review URL: https://codereview.chromium.org/1062653002 Cr-Commit-Position: refs/heads/master@{#323867}
-
marcheu authored
Revert of Use the desktop GL core profile on Linux when ES3 support is requested. (patchset #3 id:40001 of https://codereview.chromium.org/1052153002/) Reason for revert: This causes Chrome rendering to break on some Chrome OS devices, see crbug.com/473891 for details Original issue's description: > Use the desktop GL core profile on Linux when ES3 support is requested. > > Request an OpenGL 4.2 context (the minimum version Chromium's WebGL > 2.0 prototype currently requires) on Linux when > --enable-unsafe-es3-apis is specified on the command line. > > Clean up the shader translator's selection of the GLSL output format. > > BUG=471960 > > Committed: https://crrev.com/0b17446f9591af9377d18c9ccfe50471651d6bc7 > Cr-Commit-Position: refs/heads/master@{#323658} TBR=piman@chromium.org,kbr@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=471960 Review URL: https://codereview.chromium.org/1054883004 Cr-Commit-Position: refs/heads/master@{#323866}
-
dbeam authored
This wont work any time some fancy /dev setup is going on. R=thestig@chromium.org BUG=463209 Review URL: https://codereview.chromium.org/1057093003 Cr-Commit-Position: refs/heads/master@{#323865}
-
rsleevi authored
BUG=469516 Review URL: https://codereview.chromium.org/1062603004 Cr-Commit-Position: refs/heads/master@{#323864}
-
enne authored
This macro is no longer needed, as the command buffer can do the same thing with GL_CLIENT_FAIL_GL_ERRORS in gles2_implementation.h. Review URL: https://codereview.chromium.org/1065463002 Cr-Commit-Position: refs/heads/master@{#323863}
-