GitLab

Currently the first time you press a key (any key) in WebContent
on Chrome Mac, Chrome makes a NSMenuItem for every bookmark you have,
and spawns tasks to convert each favicon. These then persist in memory
to service the Bookmarks menu on the menubar.

On my profile with ~1000 bookmarks, Chrome jumps from 95MB to 105MB
resident memory if I open about:blank and press a key. And there is
noticeable lag. Each browser window's App menu also has a full
bookmarks tree, populated once the 'Bookmarks' item is hovered over,
and persisted in memory; taking up about 800kB (approximately doubling
the browser process memory used by a single-tab browser window).

In order to populate these lazily, the bookmarks menu must respond `NO`
to -[NSMenuDelegate menuHasKeyEquivalent:..]. Otherwise the menu is
fully populated on the first key event to see if any bookmark titles
match the event. With this in place, we can leave all bookmarks
submenus empty, but set a delegate that AppKit uses to populate the
menu when the user first shows it.

Bug: 33102, 647183, 733921, 786845
Change-Id: Idc0a28cf9483f7161dc3fbe9bd6cda717e65de98
Reviewed-on: https://chromium-review.googlesource.com/778644
Commit-Queue: Trent Apted <tapted@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#518459}

BUG=782793

Change-Id: I92c16d68cd47d7c20b241420ff3264188a49b6c2
Reviewed-on: https://chromium-review.googlesource.com/773720Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Dominic Battré <battre@chromium.org>
Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
Commit-Queue: Tsuyoshi Horo <horo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#518458}

Bug: 767621
Change-Id: I18aa2d13d2a255692adeee28e0319540358c3f31
Reviewed-on: https://chromium-review.googlesource.com/782799
Commit-Queue: Jialiu Lin <jialiul@chromium.org>
Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#518457}

Bug: 744736
Change-Id: Ibd0bd94b8e6a481892fcd968839da667c5746ca2
Reviewed-on: https://chromium-review.googlesource.com/782360Reviewed-by: Simon Hatch <simonhatch@chromium.org>
Reviewed-by: Emily Hanley <eyaich@chromium.org>
Commit-Queue: Simon Hatch <simonhatch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#518456}

Bug: 758690
Change-Id: Ia2b1981b8edc12016e24f53e68e0d771d706c8fc
Reviewed-on: https://chromium-review.googlesource.com/777477
Commit-Queue: Jian Li <jianli@chromium.org>
Reviewed-by: Filip Gorski <fgorski@chromium.org>
Cr-Commit-Position: refs/heads/master@{#518455}

Bug: 690364
Change-Id: Idab949d70f6da65b4d1b17a445ad1574c0431679
Reviewed-on: https://chromium-review.googlesource.com/775886
Commit-Queue: Chrome Cunningham <chcunningham@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#518454}

This changes streams to only propagate inherited prioirities to
already existing wait fences.

New wait fences initially inherit the default priority of the waiter.
If the waiter gets a priority bump, that priority is propagated to
existing wait fences at that time.

BUG=786820

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Iab04f21985e69aba7f3b90b7ffe2545d3c8510e6
Reviewed-on: https://chromium-review.googlesource.com/778422
Commit-Queue: Victor Miura <vmiura@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org>
Cr-Commit-Position: refs/heads/master@{#518453}

Fix two issues with GetSurfaceSize(). First, the Surface could have been
evicted so check if |current_surface| is null. Second, simplify logic by
getting the size_in_pixels() from Surface::surface_info_ since it will
always be the same for active/fallback frame.

Bug: none
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: If38f0673c878ebaadba8ee7038b4f677a522bdbe
Reviewed-on: https://chromium-review.googlesource.com/783253Reviewed-by: Yuri Wiitala <miu@chromium.org>
Commit-Queue: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#518452}

Make it take in a unique_ptr<content::ResourceRequest>, to avoid having
to copy it on retry, or when making a delayed request.

Also make the constructor take the ResourceRequest and NetworkAnnotation
as parameters, to simplify things a little.

TBR=jdufault@chromium.org

Bug: 746977
Change-Id: Ic0e2a573c8b8601e2b1ab9a4b58430006b8679dc
Reviewed-on: https://chromium-review.googlesource.com/777587
Commit-Queue: Matt Menke <mmenke@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Randy Smith <rdsmith@chromium.org>
Cr-Commit-Position: refs/heads/master@{#518451}

Convert the global coordinates reported by each AXAuraObjWrapper into
parent-relative coordinates to be used in the accessibility tree. That
way when any Window, Widget, or View moves (and fires a location
changed event), its descendants all move relative to it by default.

Bug: 761164
Change-Id: I19eae6f1ca5f00726107aca764d537d776cc16f3
Reviewed-on: https://chromium-review.googlesource.com/780362Reviewed-by: David Tseng <dtseng@chromium.org>
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#518450}

This reverts commit 6809a4d6.

Reason for revert: This is breaking many Mac builds (see linked issue).

Original change's description:
> Use scanout overlays for pepper2d when possible.
> 
> If GL image textures are supported, and we can find the image texture
> target for the desired format, then use TexStorage2DImageCHROMIUM to
> allocate the texture so that it may be used for scanout.
> 
> R=​piman@chromium.org
> 
> Bug: 786140
> Change-Id: I36875f82796614f4d5c7290f27bd0bacfce510fb
> Reviewed-on: https://chromium-review.googlesource.com/779883
> Reviewed-by: Antoine Labour <piman@chromium.org>
> Commit-Queue: danakj <danakj@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#518269}

TBR=danakj@chromium.org,piman@chromium.org

Change-Id: I747d76984c0641a01a44e62595432d287baf7405
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 786140,787548
Reviewed-on: https://chromium-review.googlesource.com/783491Reviewed-by: Carlos Knippschild <carlosk@chromium.org>
Commit-Queue: Carlos Knippschild <carlosk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#518449}

Whenever ECT changes, the a "ECT changed" event is logged on the
"Interventions Logs" table in the "Logs" tab.

Reversed the order of the ECT change logs on Network Quality so that
newer events will be appended to the top of the table.

Screenshot: https://drive.google.com/a/chromium.org/file/d/1lnhBZ3u2gOM0GlurRNgJgeg2O13uc07O
Screenshot: https://drive.google.com/a/chromium.org/file/d/1c6ekJzCQb7_RKbTWcdtZ4mfPhoUT9AyI

Bug: 785059
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I9372e6c70c6b9f5d775a033bed9089f072078848
Reviewed-on: https://chromium-review.googlesource.com/783450Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: Thanh Le <thanhdle@chromium.org>
Cr-Commit-Position: refs/heads/master@{#518448}

Add a new histogram metric tracking the number of daily
suspends triggered by Chromebooks' lids being closed.

Bug: 782953
Change-Id: I86540cec8b677823b00d79d8699dc005c238ab1d
Reviewed-on: https://chromium-review.googlesource.com/780427
Commit-Queue: Dan Erat <derat@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#518447}

Control Flow Integrity [1] indirect call checking verifies that function
pointers only call valid functions with a matching type signature. This
condition can be too strict, a common form of 'abstraction' relies on
function pointers being cast to generalize argument pointer types to
void*. For example, qsort() accepts two const void*s but the
implementations are likely to implement the comparison function using
pointers to the specific type being sorted.

This function relaxes cfi-icall type checking for code that uses this
pattern by using the new -fsanitize-cfi-icall-generalize-pointers
argument. It considers all pointer types equal as long as their
qualifiers match.

TBR=drott@chromium.org,rsleevi@chromium.org,piman@chromium.org

Bug: 785442
Change-Id: Ic9487908b6372898f031502c84284d008a3fdec1
Reviewed-on: https://chromium-review.googlesource.com/777555
Commit-Queue: Peter Collingbourne <pcc@chromium.org>
Reviewed-by: Ryan Sleevi <rsleevi@chromium.org>
Reviewed-by: Dominik Röttsches <drott@chromium.org>
Reviewed-by: David Benjamin <davidben@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Peter Collingbourne <pcc@chromium.org>
Reviewed-by: Johann Koenig <johannkoenig@google.com>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#518446}

Compilation fails in CSSNumericValue.equals in GCC,
in a lambda expression predicate for std::all_of.
Equals() call does not automatically use this in the
calling function scope.

This is caused by the bug in GCC "Inconsistent `this->`
required when calling member function in a lambda
capturing `this` through another function"
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67274

The change exposing GCC error was:
    commit 4bb7df98
    Author: Darren Shen <shend@chromium.org>
    Date:   Thu Nov 16 04:25:01 2017 +0000

    [css-typed-om] Implement CSSNumericValue.equals

Bug: 787601
Change-Id: I92009d38a52665d719314f4d7b7d874cd4b419ad
Reviewed-on: https://chromium-review.googlesource.com/783710Reviewed-by: Darren Shen <shend@chromium.org>
Commit-Queue: José Dapena Paz <jose.dapena@lge.com>
Cr-Commit-Position: refs/heads/master@{#518445}

Layers need to be checked for paint order and overlap with
composited layers to determine if they too must be composited.
This is called overlap testing and happens in a compositing update
if the compositing inputs are marked as dirty.

Scrolling normally doesn't dirty compositing inputs but viewport
scrolling is special if it has fixed layers. This is because
scrolling the viewport can change what fixed layers overlap,
unlike other content on the page which scrolls together.

Before root-layer-scrolling, the LocalFrameView would do this in
LocalFrameView::UpdateLayersAndCompositingAfterScrollIfNeeded.
With root-layer-scrolling, the top PaintLayerScrollableArea handles
viewport scrolling. This patch simply copies that behavior from
LocalFrameView to PaintLayerScrollableArea.

Bug: 776969
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I0cc6062caded3c42eb0febb48c391a1fe4af54bf
Reviewed-on: https://chromium-review.googlesource.com/754346Reviewed-by: Steve Kobes <skobes@chromium.org>
Commit-Queue: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#518444}

Currently StylePropertyMaps don't support strings e.g.

  styleMap.set('width', CSS.px(1)) works, but
  styleMap.set('width', '1px') doesn't.

This patch adds string support by moving parsing code to
StyleValueFactory so that both CSSStyleValue.parse and
StylePropertyMaps can share the parsing logic.

We also do some refactoring to make handling both CSSStyleValue
and strings easier.

There are still some code paths that we're not sure is correct,
pending clarification on GitHub:
https://github.com/w3c/css-houdini-drafts/issues/512

Spec: https://drafts.css-houdini.org/css-typed-om-1/#the-stylepropertymap

Bug: 545318
Change-Id: Iaef3cfad69789fc115b7e98a296eec5cb4480cd8
Reviewed-on: https://chromium-review.googlesource.com/769797
Commit-Queue: Darren Shen <shend@chromium.org>
Reviewed-by: nainar <nainar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#518443}

Made ServiceWorkerPaymentAppFactory singleton.

Bug: 786116
Change-Id: I263edd64e7452a81f07011f1a7bda83e8b57c90e
Reviewed-on: https://chromium-review.googlesource.com/774906Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Commit-Queue: Ganggui Tang <gogerald@chromium.org>
Cr-Commit-Position: refs/heads/master@{#518442}

The values that are now accepted are:
- view=Fit
- view=FitH
- view=FitV

Bug: 64309
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I1072e3dc895e4c21cd9823adac13a8c3cf5dcd90
Reviewed-on: https://chromium-review.googlesource.com/775153
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#518441}

Bug: 
Change-Id: Ib1f3a413560ba926cfb0bf1a4704b84f8ec69847
Reviewed-on: https://chromium-review.googlesource.com/780184
Commit-Queue: Owen Min <zmin@chromium.org>
Reviewed-by: Georges Khalil <georgesak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#518440}

SSLSocketDataProvider is used to vend MockSSLClientSockets
for unittests. It was originally just used to simulate the
behaviour of Connect() with a given cert, but has since
grown to include a number of additional fields that are then
exposed via the StreamSocket::GetSSLInfo() interface.

Rather than maintaining discrete fields on the
SSLSocketDataProvider and adding more fields as they grow,
just store an SSLInfo in the data provider so that any of
the fields can be simulated.

BUG=787574

Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I03f5dd6241e38221067220e9547b1ea5052a539a
Reviewed-on: https://chromium-review.googlesource.com/783256Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: David Benjamin <davidben@chromium.org>
Commit-Queue: Ryan Sleevi <rsleevi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#518439}

This is a mechanical refactor moving all free functions that take
PartitionRootGeneric as the first parameter into the PartitionRootGeneric struct.

See related bug for more details on methodology.

Bug: 787153
Change-Id: Ia95fc30ed030397303dc1999f4fdac8a72c01c9b
Reviewed-on: https://chromium-review.googlesource.com/780759
Commit-Queue: Albert J. Wong <ajwong@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#518438}

DCHECK happens for AppWindowCreateFunction did_respond() when an
AppWindow is closed before OnReadyToCommitFirstNavigation is invoked.
This is because AppWindowCreateFunction respond is deferred
until navigation is committed when PlzNavigate is enabled.

Bug: 783903
Change-Id: I2d0ef5ee1611c869314a8c9fe07808235f6e318c
Reviewed-on: https://chromium-review.googlesource.com/775902Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#518437}

with migrate back to default
network support. We will not mark session as going away until consistent
failure on migrating back to the default network with no platform notifications.

This also handles packet write error.

Bug: 774622
Change-Id: I9e9fa301d60d7a56c3d1b92af315932451e7db7a
Reviewed-on: https://chromium-review.googlesource.com/777612
Commit-Queue: Zhongyi Shi <zhongyi@chromium.org>
Reviewed-by: Jana Iyengar <jri@chromium.org>
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#518436}

This reverts commit a2ec7611.

Reason for revert: This roll still does not include the fix for the build error on "chromium.win/WinMSVC64 (dbg)".
This had to be manually adjusted to the last working commit.

Original change's description:
> Roll src/third_party/webrtc/ 202be3957..ed1023db0 (19 commits)
>
> https://webrtc.googlesource.com/src.git/+log/202be3957d95..ed1023db0eb8
>
> $ git log 202be3957..ed1023db0 --date=short --no-merges --format='%ad %ae %s'
>
> Created with:
>   roll-dep src/third_party/webrtc
> BUG=None
>
>
> The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org
>
> Documentation for the AutoRoller is here:
> https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
>
> If the roll is causing failures, please contact the current sheriff, who should
> be CC'd on the roll, and stop the roller if necessary.
>
>
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng
> TBR=webrtc-chromium-sheriffs-robots@google.com
>
> Change-Id: I660131e50f90463ee04ddd62292b7858525a8b03
> Reviewed-on: https://chromium-review.googlesource.com/781366
> Reviewed-by: WebRTC Roll Bot <webrtc-autoroll@chromium.org>
> Commit-Queue: WebRTC Roll Bot <webrtc-autoroll@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#518294}

TBR=webrtc-autoroll@chromium.org,webrtc-chromium-sheriffs-robots@google.com

Change-Id: I79ff7c5d777a62975b20ed5678f982b4e7f7d4ce
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 787192
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng
Reviewed-on: https://chromium-review.googlesource.com/783850
Commit-Queue: Carlos Knippschild <carlosk@chromium.org>
Reviewed-by: Carlos Knippschild <carlosk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#518435}

PurgeCachedWebViewPages() is presumably fail to wait for pageload and
-[ChromeEarlGrey waitForPageToFinishLoading] causes assert. Because
PurgeCachedWebViewPages() is called multiple times inside a single test
it's unclear where the bug actually happens. And the test only fails on
bots, so the logs are the only way to debug the failure.

This CL makes PurgeCachedWebViewPages() return bool, which pushes assert
call up to the test, which should clarify the failure point.

PurgeCachedWebViewPages() now uses
chrome_test_util::WaitForPageToFinishLoading helper function, because
-[ChromeEarlGrey waitForPageToFinishLoading] is not suppose to return
bool result. -[ChromeEarlGrey waitForPageToFinishLoading] now uses
chrome_test_util::WaitForPageToFinishLoading as well to avoid code
duplication.

Bug: 785025
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I4e45d30394609825fe9974e0d4077918563295cc
Reviewed-on: https://chromium-review.googlesource.com/780388Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: Mike Baxley <baxley@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#518434}

Taking advantage of the new kBoundToThread mode on
TestMockTimeTaskRunner.

This change also required tweaking the
ScopedTaskEnvironment::RunUntilIdle() logic as RunLoop().Run() on
TestMockTimeTaskRunner results in advancing time when there's no
request to quit-when-idle which is undesired here. New logic gets rid
of need for |on_queue_empty_closure_| and I think is simpler overall.
As of patch set 20, this new RunUntilIdle() logic also avoids using
TaskScheduler::FlushForTesting() as that can result in hangs should a
TaskScheduler task synchronously block on the main thread.

R=fdoray@chromium.org
TBR=gab@chromium.org (IWYU fixes)

Bug: 708584
Change-Id: I76ba55ec64d398151420379d3fcdcd5186fbceb8
Reviewed-on: https://chromium-review.googlesource.com/638550
Commit-Queue: Gabriel Charette <gab@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#518433}

https://pdfium.googlesource.com/pdfium.git/+log/135c6601bd9d..7c986a085631

$ git log 135c6601b..7c986a085 --date=short --no-merges --format='%ad %ae %s'
2017-11-21 dsinclair Cleanup CXFA_FillData

Created with:
  roll-dep src/third_party/pdfium


The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: I74586a02f10a590e11c3f9af70f6c13021cdfc95
Reviewed-on: https://chromium-review.googlesource.com/783656
Reviewed-by: <pdfium-deps-roller@chromium.org>
Commit-Queue: <pdfium-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#518432}

This CL completes ios/web Download API implementation. Integration test
will be landed in a separate CL.

Embedder does not set DownloadController delegate yet, so this CL does
not trigger the second download.

Design doc: http://go/ios-web-download-api

Bug: 780646
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Icc9d5c5432a038237f80e7f35ddaa787dbb165fe
Reviewed-on: https://chromium-review.googlesource.com/764890
Commit-Queue: Eugene But <eugenebut@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#518431}

This CL creates a URLLoaderFactoryPtr based on the existing
URLRequestInterceptor which fails the first N requests then
begins allowing the loads.

If the network service feature flag is not set, we fall back
to just using the old URLRequestInterceptor.

Relanding after adding common:interfaces to public_deps.


Bug: 769401
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: If9cda1d728161a7067d8d2f4f8d88b06e55059c9
Reviewed-on: https://chromium-review.googlesource.com/782703Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Doug Turner <dougt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#518430}

See the following document for details:
https://docs.google.com/document/d/1QabRo8c7D9LsYY3cEcaPQbOCLo8Tu-6VLykYXyl3Pkk

Bug: 
Change-Id: I49b7f3a00be777a88e5e6c86a4a582da94b917a9
Reviewed-on: https://chromium-review.googlesource.com/783641Reviewed-by: Kevin Bailey <krb@chromium.org>
Commit-Queue: Justin Donnelly <jdonnelly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#518429}

https://skia.googlesource.com/skia.git/+log/0a3adc0b0ad8..bff5a98cdfda

$ git log 0a3adc0b0..bff5a98cd --date=short --no-merges --format='%ad %ae %s'
2017-11-21 jvanverth Disable tonal color for shadowutils GMs
2017-11-21 benjaminwagner Remove Skolo NVIDIA Linux bots.
2017-11-21 liyuqian Enable DAA for MSVC
2017-11-21 reed detect too many points
2017-11-21 brianosman Remove SampleApp and convert HelloWorld to sk_app
2017-11-21 update-skps Update SKP version

Created with:
  roll-dep src/third_party/skia


The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=herb@chromium.org

Change-Id: Icee96a2df8edffec8cef60247ef4fc13c0f56ac7
Reviewed-on: https://chromium-review.googlesource.com/783270Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#518428}

NotificationPlatformBridge for TRANSIENT notifications until such time
that platform bridges can be updated to handle TRANSIENT notifications
via their delegates.

This should not have any immediate effect as would-be TRANSIENT
notifications do not use NotificationDisplayService yet, but it allows
them to be updated to use NDS while the platform bridges are still a
work in progress.

Bug: 783018
Change-Id: I224da7b03172152fbd9a5ee2cd4d5017a4de5f74
Reviewed-on: https://chromium-review.googlesource.com/779067Reviewed-by: Peter Beverloo <peter@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#518427}

Analysis showed that MRU was as good as engagement score to choose
which tabs to discard. The new plan is to build a machine learning
model to choose which tabs to discard.

Bug: 775644
Change-Id: If85f0911d158201190bcb15f4b865c644c6426b4
Reviewed-on: https://chromium-review.googlesource.com/779081
Commit-Queue: François Doray <fdoray@chromium.org>
Reviewed-by: Gayane Petrosyan <gayane@chromium.org>
Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Cr-Commit-Position: refs/heads/master@{#518426}

The spec has changed StylePropertyMap's IDL. StylePropertyMap.append
and set now take a variadic number of (CSSStyleValue or Strings). This
patch changes the IDL and updates the implementation.

Bug: 785132
Change-Id: I502abbd369bea20853e68f434f3c96dc6437a892
Reviewed-on: https://chromium-review.googlesource.com/768330
Commit-Queue: Darren Shen <shend@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: nainar <nainar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#518425}

This patch adds the function to find containing LayoutObject for
absolute positioned objects in the current inline formatting
context.

Bug: 636993
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: I8f576a49376f9828ca75ee4def4358e7d4a0ee2f
Reviewed-on: https://chromium-review.googlesource.com/783290
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Aleks Totic <atotic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#518424}

Bug: 787571
Change-Id: Id7f2533890ca493b4eb6bee16cd6cdbee475554c
Reviewed-on: https://chromium-review.googlesource.com/783750
Commit-Queue: Sidney San Martín <sdy@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#518423}

The flag was added in cl/734165, but did not restrict to Android,
we want to run the intervention only on Android.

Bug: 763573
Change-Id: I180c32992ef4a36cec616e33d59b418305500265
Reviewed-on: https://chromium-review.googlesource.com/780691Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Shubhie Panicker <panicker@chromium.org>
Cr-Commit-Position: refs/heads/master@{#518422}

Various RootDirectory test cases exist to make sure browsing file:///
works. However, this action is not allowed on Android, so it is a slight
mystery how the tests manage to pass on earlier version of Android. The
tests fail under newer version of Android.

Given this situation, just disable the tests on Android altogether, as
it is pointless to test a disallowed action. Also combine the test cases
which are very similar into a single test case with a for-loop.

BUG=787149

Change-Id: Icec5ed676b245519ae98e8914b397122d5c7bbd5
Reviewed-on: https://chromium-review.googlesource.com/780921
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#518421}

This patch fixes a bug in where japanese-rl-selection-clear.html
was rebaselined incorrectly:
https://chromium.googlesource.com/chromium/src/+/cc645ca3adb300e03f222bb239aa9b40b35f0719

Bug: 781419

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_root_layer_scrolls
Change-Id: I6c35947c11e912da420f217f6b0c71b568bb324e
Reviewed-on: https://chromium-review.googlesource.com/783652Reviewed-by: Steve Kobes <skobes@chromium.org>
Commit-Queue: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#518420}