GitLab

This contains fixes for the following sorts of issues:
* Signedness mismatch
* Assignment inside conditional
* Possibly-uninitialized local variable

This also contains a very small number of other cleanups to nearby code.

BUG=81439
TEST=none

Review URL: https://codereview.chromium.org/388893003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282743 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282742 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=177974:177980&mode=html
TBR=junov@chromium.org,falken@chromium.org
BUG=

Review URL: https://codereview.chromium.org/386083003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282741 0039d316-1c4b-4281-b951-d872f2087c98

BUG=391005

Review URL: https://codereview.chromium.org/372243003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282740 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/367523002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282739 0039d316-1c4b-4281-b951-d872f2087c98

This pathway is obsolete, and is removed in this CL.

BUG=392851

Review URL: https://codereview.chromium.org/388583002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282738 0039d316-1c4b-4281-b951-d872f2087c98

ASSERT_TRUE only prints the first call frame in the error message. In our case, this is the _ASSERT_TRUE wrapper function, which is not useful.

To help with debugging, this CL dumps the full stack.

Review URL: https://codereview.chromium.org/382193004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282737 0039d316-1c4b-4281-b951-d872f2087c98

Reformat the bisect results output to give detailed information regarding the bisect job.
Includes clear instructions to repro steps.

BUG=383669,383935
NOTRY=true

Review URL: https://codereview.chromium.org/388623002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282735 0039d316-1c4b-4281-b951-d872f2087c98

The PutBytes() method in PnaclTranslateThread is used for two purposes: giving
data to the translator processes and signaling the end of the stream.  The way
it's currently done is a bit confusing; this breaks the method into two
for clarity. This is to make code review easier to read for an upcoming change
which removes FileDownloader from the trusted plugin.

BUG=370556

Review URL: https://codereview.chromium.org/383213005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282734 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282733 0039d316-1c4b-4281-b951-d872f2087c98

Reverted for merge conflict

> Reland "Use upstream libaddressinput in Chrome."
> 
> Remove static initializer and reland https://crrev.com/282408 which was
> reverted in https://crrev.com/282426.
> 
> TBR=estade@chromium.org,thestig@chromium.org
> BUG=389918
> 
> Review URL: https://codereview.chromium.org/386873002

TBR=rouslan@chromium.org

Review URL: https://codereview.chromium.org/387123004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282732 0039d316-1c4b-4281-b951-d872f2087c98

On parse failure, FFmpeg does not always error out, so ensure the OPUS
initializer we construct is completely initialized.

BUG=389280
TEST=none

Review URL: https://codereview.chromium.org/382123002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282731 0039d316-1c4b-4281-b951-d872f2087c98

BUG=367595
NOTRY=true

Review URL: https://codereview.chromium.org/371643002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282730 0039d316-1c4b-4281-b951-d872f2087c98

Callbacks can cause the ChildSharedBitmapManager to be used after the compositor is gone, so pass the ThreadSafeSender (which is refcounted) to the callbacks instead.

BUG=390563

Review URL: https://codereview.chromium.org/382133002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282729 0039d316-1c4b-4281-b951-d872f2087c98

BUG=392938
R=navabi@chromium.org, tonyg@chromium.org

Review URL: https://codereview.chromium.org/383933003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282728 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282727 0039d316-1c4b-4281-b951-d872f2087c98

Remove static initializer and reland https://crrev.com/282408 which was
reverted in https://crrev.com/282426.

TBR=estade@chromium.org,thestig@chromium.org
BUG=389918

Review URL: https://codereview.chromium.org/386873002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282726 0039d316-1c4b-4281-b951-d872f2087c98

TBR=nduca@chromium.org
BUG=346958

Review URL: https://codereview.chromium.org/385253002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282725 0039d316-1c4b-4281-b951-d872f2087c98

leak was fixed in r213560

BUG=175815
NOTRY=true

Review URL: https://codereview.chromium.org/383333002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282724 0039d316-1c4b-4281-b951-d872f2087c98

DeviceMonitorMac: move CrAVFoundationDeviceObserver and most of SuspendObserverDelegate to UI Thread

(tl; dr : Move all operations to UI thread except device enumerations.)

CrAVFoundationObserver was located in Device Thread based 
on the assumption that OS KVO callbacks would come on that 
thread too, but instead they come from UI thread.
-observeValueForKeyPath:... is then called in UI thread, and since
the rest of the actions of the class are small, this CL moves the
whole class to UI thread. 

Its overlord SuspendObserverDelegate (best not use acronyms 
for its name :) ), however, lives a mixed life in UI and Device
 threads. The model is simplified by making it work always in
UI thread _except_ for device enumerations (done via
[AVCaptureDeviceglue devices]).

AVFoundationMonitorImpl will destroy SuspendObserverDelegate
in UI thread and that in turn destroys CrAVFoundationObserver
in that very thread, thus cleaning up the multi threading and
hopefully addressing the bug reports of a small but consistent
crash rate (~2 crashes every four canaries or so). 

UI Thread checks are added everywhere.

The code around CrAVFoundationDeviceObserver::dealloc and 
-stopObserving is refactored in order to avoid a redundant 
search-for-device in |monitoredDevices_|.

BUG=366087

Review URL: https://codereview.chromium.org/368613002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282723 0039d316-1c4b-4281-b951-d872f2087c98

IDs can't begin with a digit. However, this syntax allows it.

BUG=361809
TBR=dtu@chromium.org,chrishenry@google.com
NOTRY=True

Review URL: https://codereview.chromium.org/383263004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282721 0039d316-1c4b-4281-b951-d872f2087c98

R=estade@chromium.org
BUG=none

Review URL: https://codereview.chromium.org/388723002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282720 0039d316-1c4b-4281-b951-d872f2087c98

BUG=337663

Review URL: https://codereview.chromium.org/383903004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282718 0039d316-1c4b-4281-b951-d872f2087c98

Patch set 1: Use XInput2 events for keyboard events.

XI2 keyboard events are generated, rewritten to core events, and consumed. EventRewriter tests pass with XI2 key events.

Patch set 2: Move source_device_id_ up to |ui::Event|.

Patch set 3: EventRewriter is no longer a PlatformEventObserver or DeviceHierarchyObserver.

|chromeos::EventRewriter| now uses |ui::KeyEvent::source_device_id()| instead of tracking XI2 key events itself as a chromeos::DeviceHierarchyObserver and |ui::PlatformEventObserver|.

Patch set 4: Convert Alt + Left Button rewriter from XI2 events to|ui::Event|s.

BUG=368750

Review URL: https://codereview.chromium.org/336403005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282717 0039d316-1c4b-4281-b951-d872f2087c98

BUG=391943
TBR=nduca@chromium.org

Review URL: https://codereview.chromium.org/387893004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282715 0039d316-1c4b-4281-b951-d872f2087c98

Fixes r282703.

BUG=none
R=brettw@chromium.org
TBR=msw@chromium.org

Review URL: https://codereview.chromium.org/387993006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282714 0039d316-1c4b-4281-b951-d872f2087c98

The current implementation assumes the Android system OpenSSL and our copy have
compatible ABIs. This will be a problem when switching to BoringSSL which has
already changed from ABIs. Moreoever, it's already slightly off now as any
globals (error queue and locks) have different instances between the two.

Rework the code to never mix the two ABIs. We replicate the subset of OpenSSL
ABI we care about and use it to find the rsa_priv_enc implementation. This is
then mapped to Chromium OpenSSL via the custom RSA_METHOD. In addition, because
we cannot safely increase reference counts, retain references to Java wrappers
where appropriate in lieu of the C structures.

Also fix AndroidKeyStore unit tests on 4.1; they broke after an overzealous
NOTREACHED() in r278305.

BUG=389414

Review URL: https://codereview.chromium.org/365503007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282713 0039d316-1c4b-4281-b951-d872f2087c98

BUG=384640

Review URL: https://codereview.chromium.org/347183005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282712 0039d316-1c4b-4281-b951-d872f2087c98

The crash is caused when a guest is attached, a parameter "repaint" is passed in. For most device, their scale factor is 1, so we don't need to repaint and "repaint" is set to  false. However, for high dpi devices like Mac, the scale factor is 2, rather than 1. Therefore, a DECHECK of the scale factor == 1 is failed. 

So we use GetDeviceScaleFactor() to initialize last_device_scale_factor as well.

BUG=393278

Review URL: https://codereview.chromium.org/385173003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282711 0039d316-1c4b-4281-b951-d872f2087c98

If an autofill popup is supposed to display a multi-line address,
the address needs to be converted into a single-line format with
separators.

BUG=362373
R=estade@chromium.org
TBR=isherman@chromium.org

Review URL: https://codereview.chromium.org/264053007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282710 0039d316-1c4b-4281-b951-d872f2087c98

BUG=349436

Review URL: https://codereview.chromium.org/384893002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282709 0039d316-1c4b-4281-b951-d872f2087c98

As of current code, HiDPI should be enabled by default for both Desktop and Metro mode unless someone overrides with registry key.

BUG=393050
R=cpu,ananta

Review URL: https://codereview.chromium.org/385023002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282706 0039d316-1c4b-4281-b951-d872f2087c98

BUG=375333

Review URL: https://codereview.chromium.org/386933007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282705 0039d316-1c4b-4281-b951-d872f2087c98

NSS gets dlopen'd on Windows and Mac, so it can be built
in the OpenSSL port.

BUG=38883

Review URL: https://codereview.chromium.org/385873002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282704 0039d316-1c4b-4281-b951-d872f2087c98

Make SetFontRenderParams() pass the hinting setting through
to SkPaint instead of exposing a separate SetFontHinting()
method. Also add a default c'tor for FontRenderParams and
pass its autohinter setting through to SkPaint as well.

BUG=125235,375824

Review URL: https://codereview.chromium.org/387743002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282703 0039d316-1c4b-4281-b951-d872f2087c98

This broke LSAN.

http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Builder/builds/9737/steps/compile/logs/stdio


> Non-SFI NaCl: Fix browser_tests based on libc_free.c
> 
> There were two issues with clang:
> 
> - Clang emits .data.rel.ro.local for local struct values with
>   an initializer, which lets the linker to emit a few
>   relocation info.
> - In debug build, clang uses memcpy to copy a structure with
>   five members. Neither -fno-builtin nor -ffreestanding did
>   not prevent this issue.
> - In release build, clang translates for-loop based zero copy
>   to memset.
> 
> This patch initializes all structures without initializers
> or copy. This patch works with GYP_DEFINES=clang=0.
> 
> To make sure we will not add memcpy or something in future,
> we will build libc_free.nexe with -Wl,--no-undefined.
> 
> This also reverts
> 
> https://codereview.chromium.org/386543002
> 
> to enable the disabled tests.
> 
> BUG=392768
> TEST=./out/Debug/browser_tests --gtest_filter='*NonSfi*Messaging*'
> 
> Review URL: https://codereview.chromium.org/381883002

TBR=hamaji@chromium.org

Review URL: https://codereview.chromium.org/385073010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282702 0039d316-1c4b-4281-b951-d872f2087c98

BUG=383941

Review URL: https://codereview.chromium.org/382643002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282701 0039d316-1c4b-4281-b951-d872f2087c98

The non-testing code in src/mojo/public should be buildable without
depending on anything outside of that directory. It's fine for test
code to depend on base/ and gtest/, though. Due to the way GYP works,
having targets for both production and test code in the same .gypi
file winds up trying to resolve the dependencies for both kinds of
targets, breaking the ability to build the public mojo code
hermetically.

Splitting the targets out will enable consumers of the mojo code to
build the public code standalone using GYP.

BUG=chromium:388412
TEST=build and run all mojo unittests

Review URL: https://codereview.chromium.org/385603003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282699 0039d316-1c4b-4281-b951-d872f2087c98

BUG=392745
R=rsleevi@chromium.org

Review URL: https://codereview.chromium.org/385983006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282698 0039d316-1c4b-4281-b951-d872f2087c98

There were two issues with clang:

- Clang emits .data.rel.ro.local for local struct values with
  an initializer, which lets the linker to emit a few
  relocation info.
- In debug build, clang uses memcpy to copy a structure with
  five members. Neither -fno-builtin nor -ffreestanding did
  not prevent this issue.
- In release build, clang translates for-loop based zero copy
  to memset.

This patch initializes all structures without initializers
or copy. This patch works with GYP_DEFINES=clang=0.

To make sure we will not add memcpy or something in future,
we will build libc_free.nexe with -Wl,--no-undefined.

This also reverts

https://codereview.chromium.org/386543002

to enable the disabled tests.

BUG=392768
TEST=./out/Debug/browser_tests --gtest_filter='*NonSfi*Messaging*'

Review URL: https://codereview.chromium.org/381883002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282697 0039d316-1c4b-4281-b951-d872f2087c98