- 12 Dec, 2018 40 commits
-
-
Roger McFarlane authored
The server generated profile validity priority pref is encoded as a base64 encoded serialized proto within a pref string value. Misc: - Fixes the name of a member variable (was missing trailing _) - Move impl of a method whose address is taken from .h to .cc Bug: 913685 Change-Id: I6ddf194a54d536289b1fcb5a95067d24cb642f4c Reviewed-on: https://chromium-review.googlesource.com/c/1371006 Commit-Queue: Roger McFarlane <rogerm@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#615874}
-
tzik authored
CreateVideoCaptureDeviceFactory requires the task runner for UI thread, but the task runner passed by DeviceFactoryProviderImpl to CVCDF is not. That causes DCHECK failure around AddObserverOnDisplayThread on ScreenObserverDelegate. Bug: 909975 Change-Id: I778647b87c619002c64fa871252e88ac184ea5cf Reviewed-on: https://chromium-review.googlesource.com/c/1367388Reviewed-by:
Emircan Uysaler <emircan@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#615873}
-
Friedrich Horschig [CET] authored
This reverts commit 28e9c18c. Reason for revert: Broke numerous browser_tests and viz_browser_tests on Linux ChromiumOS MSan Tests: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20ChromiumOS%20MSan%20Tests/10120 Relevant log snippet: ==23389==WARNING: MemorySanitizer: use-of-uninitialized-value #0 0x55d8b905b0bd in views::PlaybackImageButton::UpdateImageAndTooltipText() ./../../chrome/browser/ui/views/overlay/playback_image_button.cc:65:3 #1 0x55d8b905ac31 in views::PlaybackImageButton::SetButtonSize(gfx::Size const&) ./../../chrome/browser/ui/views/overlay/playback_image_button.cc:52:3 ==> 37 broken *PictureInPictureWindowControllerBrowserTest* Original change's description: > Add replay button to Picture-in-Picture window when video ends > > This CL makes sure there's a new replay button visible in the PiP window > when video ends. This icon comes from Material Icons library at > https://material.io/tools/icons/?icon=replay. > > https://i.imgur.com/I1n90tM.png > > Bug: 911620 > > Change-Id: Ibfcb96b9c69228ad74afe96ec00eb0e28d335ad8 > Reviewed-on: https://chromium-review.googlesource.com/c/1360852 > Commit-Queue: François Beaufort <beaufort.francois@gmail.com> > Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> > Reviewed-by: Evan Stade <estade@chromium.org> > Cr-Commit-Position: refs/heads/master@{#615846} TBR=beaufort.francois@gmail.com,estade@chromium.org,mlamouri@chromium.org Change-Id: I655a32a2e5033500392cd44c921442f066297190 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 911620 Reviewed-on: https://chromium-review.googlesource.com/c/1373758Reviewed-by:
Friedrich Horschig [CET] <fhorschig@chromium.org> Commit-Queue: Friedrich Horschig [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#615872}
-
Francois Doray authored
The failure reason is missing from logs received as part of user feedback reports. Change-Id: I8b0d7e06f7ab78595f30fb2eb6b949a3eaead705 Reviewed-on: https://chromium-review.googlesource.com/c/1371933Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#615871}
-
Noel Gordon authored
Foreground import_controller_unittest needs a mock MediaScanner. Allow background {MockMediaScanner} to be used by foreground tests. No change in test behavior. Tbr: slangley@ Bug: 914197 Change-Id: I146bff5e4ef5f12df5a060b3efedb1c2e1ea378e Reviewed-on: https://chromium-review.googlesource.com/c/1373589Reviewed-by:Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#615870}
-
Peter Beverloo authored
Also change the variable's name from camelCase to hacker_style. Change-Id: Ib8ef997fa0193b00874d880053a495d649a08175 Reviewed-on: https://chromium-review.googlesource.com/c/1371806 Commit-Queue: Peter Beverloo <peter@chromium.org> Reviewed-by:
Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#615869}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/4998533202d9..c00efea4fee9 git log 4998533202d9..c00efea4fee9 --date=short --no-merges --format='%ad %ae %s' 2018-12-12 hjd@google.com Merge "traced_processor: Convert CoerceTo* functions to use base::Optional" Created with: gclient setdep -r src/third_party/perfetto@c00efea4fee9 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: If14758940a4077cd205ed067f71331d4b0469c36 Reviewed-on: https://chromium-review.googlesource.com/c/1373890Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#615868}
-
Friedrich Horschig [CET] authored
This reverts commit 229cb506. Reason for revert: Builder Deterministic Linux (dbg) failed several fuzz tests: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Deterministic%20Linux%20%28dbg%29/3801 From Log: Unexpected files with diffs: libboringssl_fuzzer.so libboringssl_fuzzer_no_fuzzer_mode.so merkle_integrity_source_stream_fuzzer renderer_fuzzer renderer_proto_tree_fuzzer renderer_tree_fuzzer Original change's description: > [code coverage] Add all fuzzer targets > > R=jbudorick,stgao,liaoyuke > > Change-Id: I78ffec6525cd1d808a4b431ae1e2729b76357d46 > Reviewed-on: https://chromium-review.googlesource.com/c/1372917 > Commit-Queue: Shuotao Gao <stgao@chromium.org> > Reviewed-by: Shuotao Gao <stgao@chromium.org> > Reviewed-by: John Budorick <jbudorick@chromium.org> > Cr-Commit-Position: refs/heads/master@{#615834} TBR=stgao@chromium.org,robertocn@chromium.org,liaoyuke@chromium.org,jbudorick@chromium.org Change-Id: Id148793c58c415ceec56a532257f1beebfdee041 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/1373835Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/8a193dc7e2b4..dd3ad7fe5db7 git log 8a193dc7e2b4..dd3ad7fe5db7 --date=short --no-merges --format='%ad %ae %s' 2018-12-12 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 a48f26fb7a4d..88faa6967431 (1 commits) Created with: gclient setdep -r src/third_party/skia@dd3ad7fe5db7 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ethannicholas@chromium.org Change-Id: Iac9ace9f9a41cf9b0e28a90ca61d0ce6accd357b Reviewed-on: https://chromium-review.googlesource.com/c/1373889Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ff9b06b60550..beee6ad0f2af Created with: gclient setdep -r src-internal@beee6ad0f2af The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I2ded4a8b88a61743e511899b17186c62e32a5ff7 Reviewed-on: https://chromium-review.googlesource.com/c/1373439Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#615865}
-
Henrik Grunell authored
Bug: 826664, 830624 Change-Id: I55a214693cd2af11467a198ee85b926f822225f9 Reviewed-on: https://chromium-review.googlesource.com/c/1371429Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Olga Sharonova <olka@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Henrik Grunell <grunell@chromium.org> Cr-Commit-Position: refs/heads/master@{#615864}
-
Matthew Cary authored
Extends the dexlayout build path with profile obfuscation. This hooks build/android/gyp/dex.py into the recent convert_dex_profile.py, and makes the necessary changes to GN to pass the proguard mapping to the dex pass. Bug: 875276 Change-Id: Id595b17fdba69c7e2e2dcd252c467954a558c56f Reviewed-on: https://chromium-review.googlesource.com/c/1366315 Commit-Queue: Matthew Cary <mattcary@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#615863}
-
Christopher Cameron authored
The previous name was no longer reflective of the behavior. Updated comments as well. TBR=dominickn Change-Id: Id8791c8e4272e51f86ac84c93f94ed06a49f2de7 Reviewed-on: https://chromium-review.googlesource.com/c/1373733Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#615862}
-
Yi Su authored
This CL migrates the SavePasswordsCollectionViewController from CollectionViewController, which is based on MDCCollectionViewController, to ChromeTableViewController, which is based on UITableViewController. old version UI: https://drive.google.com/open?id=1wep_qWxpoFYed6K3k2y2uwN6nJZut5f3 https://drive.google.com/open?id=1n_Vzc5AjlnrmAL5BmaGEuY18kG_3DKL4 https://drive.google.com/open?id=1G3ceF52yDQcg2WDvthP7dIPCy-BND_w1 new version UI: https://drive.google.com/open?id=1HC33oWDWtgd0V1daf7OYceUo7zj5dB8t https://drive.google.com/open?id=1P7wi_a47hpWzzB30nzIV9JIu1puwGL8r https://drive.google.com/open?id=1E1EYLq56jsy9QjSkzqcPTUCdV0XBkeS1 Bug: 894791,751311 Change-Id: I7ae4b244a9eb18d0c4af556ae2ed39da4fec0451 Reviewed-on: https://chromium-review.googlesource.com/c/1361241Reviewed-by:
Eric Noyau <noyau@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
Chris Lu <thegreenfrog@chromium.org> Commit-Queue: Yi Su <mrsuyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#615861}
-
Yuki Shiino authored
Run script in content attributes that are injected by Chrome extensions (content scripts) in the main world in order to keep backward compatibility. Change-Id: Ie50d62e4a19c050dd2187638b383680bde492e2a Bug: 912069 Reviewed-on: https://chromium-review.googlesource.com/c/1373283 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#615860}
-
Hajime Hoshi authored
Use per-frame task runners instead of per-thread task runners for bfcache. This is based on Alexander's CL https://chromium-review.googlesource.com/c/chromium/src/+/1367325 Bug: 913912 Change-Id: If41723bc50fb402414e8108a4f99755c982e33af Reviewed-on: https://chromium-review.googlesource.com/c/1369748 Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
-
Clemens Hammacher authored
The API was rewritten in https://crrev.com/c/1363140. This CL changes chromium code to use the new API. R=mlippautz@chromium.org Bug: chromium:912031 Change-Id: I10493dd711b565217fcdb437bb70fa380b4cfa84 Reviewed-on: https://chromium-review.googlesource.com/c/1373749Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#615858}
-
François Beaufort authored
Change-Id: I887f62915f3220652cfe9a440d1d2133f61b7bf8 Reviewed-on: https://chromium-review.googlesource.com/c/1360651Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/master@{#615857}
-
Daniel Bratell authored
Compiling app_icon_factory code triggered compilation errors in some Windows and Mac builds since the code references app_list which only exists in ChromeOS. In most builds it was ok because the generated object file was unused and got stripped by the linker before the dangling references was found. BUG=826982 TBR=nigeltao@chromium.org,rdevlin.cronin@chromium.org,dominickn@chromium.org Change-Id: I25f0fa090f3466bcc83e06a070c7aa6c8600976d Reviewed-on: https://chromium-review.googlesource.com/c/1373450Reviewed-by:
Daniel Bratell <bratell@opera.com> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#615856}
-
Javier Ernesto Flores Robles authored
Reduces the estimated size of the row to the minimum, so it is correctly calculated on |contentSize|. Starts the view controller with a more appropiate size for the popover. Bug: 912515 Change-Id: If7c2dc4a0ab2a6df445fdac2c5fc21453927a71c Reviewed-on: https://chromium-review.googlesource.com/c/1371873 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#615855}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/12278165eded..ff9b06b60550 Created with: gclient setdep -r src-internal@ff9b06b60550 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I738e2d9a308dab93e290665349a5425bf577cee5 Reviewed-on: https://chromium-review.googlesource.com/c/1373438Reviewed-by:
-
Andrew Comminos authored
Verifies that the UA sets responseStart to the time that an initial 1XX response was received by returning {100, delay, 200} and testing that the delay is not included in responseStart. Bug: 568024 Change-Id: I7295e6478a95abe1b6154ddf1feab764f596a5ec Reviewed-on: https://chromium-review.googlesource.com/c/1372359Reviewed-by:Yoav Weiss <yoavweiss@chromium.org> Commit-Queue: Yoav Weiss <yoavweiss@chromium.org> Cr-Commit-Position: refs/heads/master@{#615853}
-
Tanja Gornak authored
* As of today, when subscription to the topic gets deleted, the value in prefs is cleaned up only after the response for HTTP unsubscription request arrives. * It can happen, e.g. on the browser shutdown that the clean-up code is never executed, hence prefs won't be cleaned up. * This CL makes the prefs cleanup happen when the decision to unsubscribe from the topic notifications is made. BUG=913486 Change-Id: I3d58df8896ef87ecef4535fb588d9a73494c2de1 Reviewed-on: https://chromium-review.googlesource.com/c/1370164 Commit-Queue: Tatiana Gornak <melandory@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#615852}
-
Michael van Ouwerkerk authored
Bug: 911669 Change-Id: I62a97d76a0b88099a5a42b93463307f03be9b3e2 Reviewed-on: https://chromium-review.googlesource.com/c/1361104Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Cr-Commit-Position: refs/heads/master@{#615851}
-
Andreas Haas authored
We have separate finch trials for the different platforms, so we should use the same trial names here. R=jwd@chromium.org Bug: chromium:906565, chromium:903736 Change-Id: Icc6ca6d9074239ca277ccdf0546234b3626ed282 Reviewed-on: https://chromium-review.googlesource.com/c/1367664Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#615850}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/d86edb310a70..069664e58b9d git log d86edb310a70..069664e58b9d --date=short --no-merges --format='%ad %ae %s' 2018-12-12 brandon1.jones@intel.com Remove textureAspect from TextureCopyView 2018-12-12 jiawei.shao@intel.com Make TextureDescriptor match WebGPU IDL Created with: gclient setdep -r src/third_party/dawn@069664e58b9d The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: I4231fd7e4a06fbf02932a43b9f5e457714f915d0 Reviewed-on: https://chromium-review.googlesource.com/c/1373437Reviewed-by:
-
rajendrant authored
Some images cannot be lazyloaded, for example., images with dimensions in attribute or style, and images inside iframes which are already lazyloaded. For such images creating intersection observer and recording visibility metrics is not needed. This also reduces the amout of intersection observers. Bug: 914024 Change-Id: I34907ac9c7930964288544c135a8e3cbe2262f61 Reviewed-on: https://chromium-review.googlesource.com/c/1372317 Commit-Queue: rajendrant <rajendrant@chromium.org> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#615848}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/b0b5835a1715..8a193dc7e2b4 git log b0b5835a1715..8a193dc7e2b4 --date=short --no-merges --format='%ad %ae %s' 2018-12-12 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update go_deps asset 2018-12-12 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 be607ad63609..a48f26fb7a4d (3 commits) Created with: gclient setdep -r src/third_party/skia@8a193dc7e2b4 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ethannicholas@chromium.org Change-Id: I728478e2e9519848e969fcdf848d6dcb094ce329 Reviewed-on: https://chromium-review.googlesource.com/c/1373256Reviewed-by:
-
François Beaufort authored
This CL makes sure there's a new replay button visible in the PiP window when video ends. This icon comes from Material Icons library at https://material.io/tools/icons/?icon=replay. https://i.imgur.com/I1n90tM.png Bug: 911620 Change-Id: Ibfcb96b9c69228ad74afe96ec00eb0e28d335ad8 Reviewed-on: https://chromium-review.googlesource.com/c/1360852 Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#615846}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/60446b8d5f30..f6b10fbe4ad7 git log 60446b8d5f30..f6b10fbe4ad7 --date=short --no-merges --format='%ad %ae %s' 2018-12-12 benwright@webrtc.org Basic fuzzing of rtc::s_url_decode. Created with: gclient setdep -r src/third_party/webrtc@f6b10fbe4ad7 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ib0c89bb0de5b252fa431346551ba2fe35cc930e6 Reviewed-on: https://chromium-review.googlesource.com/c/1373230Reviewed-by:
-
Yuki Shiino authored
WorldSafeV8Reference class provides safe access across worlds plus wrapper-tracing. The usage is demonstrated at CustomEvent.detail. Change-Id: I6c640d916063ac87604bd63f25524f8a4f8dd817 Bug: 501866, 755520, 803478 Reviewed-on: https://chromium-review.googlesource.com/c/1358611 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#615844}
-
Rakina Zata Amni authored
Constructor for CSSStyleSheets has changed in a recent CL, so this test is failing. TBR=crouleau@chromium.org Bug: 914084 Change-Id: Icbf34425f9141bdd581a0c2ab9b568aaf058a358 Reviewed-on: https://chromium-review.googlesource.com/c/1373373Reviewed-by:
Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Cr-Commit-Position: refs/heads/master@{#615843}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/45637bf3b4b6..12278165eded Created with: gclient setdep -r src-internal@12278165eded The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ia5b3ca95c632c1c024c386c488391a9c1adc0e46 Reviewed-on: https://chromium-review.googlesource.com/c/1373435Reviewed-by:
-
Olivier Robin authored
When running unittests, number of categories reach 253. Max number needs to be increased. Bug: 908002 Change-Id: Iaf8d449eb005b6a5b4e4a2524f913d3eeba54f41 Reviewed-on: https://chromium-review.googlesource.com/c/1373470Reviewed-by:
Primiano Tucci <primiano@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#615841}
-
Stephen Chenney authored
This is a reland of aed99d7e It was reverted in https://chromium-review.googlesource.com/c/chromium/src/+/1373285 But the real culprit is a recipe change which is being reverted in https://chromium-review.googlesource.com/c/chromium/tools/build/+/1373509 Original change's description: > Fix SVG-As-Background sizing > > Addresses a TODO where we were snapping the intrinsic size of an SVG image, > even when that is no longer useful. This was posing issues with operations > using aspect ratio, because the computed aspect ratio on the snapped value > was wrong when then used on un-snapped values. > > R=fs@opera.com > BUG=855882 > > Change-Id: I0c14c0109da4c5ca5e52aebf408e9b702eda799c > Reviewed-on: https://chromium-review.googlesource.com/c/1370486 > Commit-Queue: Stephen Chenney <schenney@chromium.org> > Reviewed-by: Fredrik Söderquist <fs@opera.com> > Cr-Commit-Position: refs/heads/master@{#615798} Bug: 855882 Change-Id: Icdd1ad0af2aaae6f633b8940522115e9742d1d7f Reviewed-on: https://chromium-review.googlesource.com/c/1373286Reviewed-by:
Shuotao Gao <stgao@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/3a2562287939..88faa6967431 git log 3a2562287939..88faa6967431 --date=short --no-merges --format='%ad %ae %s' 2018-12-12 jiajia.qin@intel.com ES31: Add unsized array length support in SSBO 2018-12-12 jiajia.qin@intel.com ES31: Use deepCopy to make sure that every node being used only once Created with: gclient setdep -r src/third_party/angle@88faa6967431 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jmadill@chromium.org Change-Id: I2f9b6884298885ce25f6cca4589a74ece6b7c4b1 Reviewed-on: https://chromium-review.googlesource.com/c/1372479Reviewed-by:
-
Friedrich Horschig [CET] authored
This reverts commit e515fd07. Reason for revert: Consistently failing as "Incorrect or missing bot configuration failing on [.*]-autofill-captured-sites-rel" Original change's description: > Trigger continuous integration on autofill bots. > > Bug: 885350 > Change-Id: If7e100dafc6203bdd9ea86aa7c05bfbe1342e03f > Reviewed-on: https://chromium-review.googlesource.com/c/1372176 > Reviewed-by: Stephen Martinis <martiniss@chromium.org> > Reviewed-by: smut <smut@google.com> > Commit-Queue: Yiming Zhou <uwyiming@google.com> > Cr-Commit-Position: refs/heads/master@{#615716} TBR=smut@google.com,martiniss@chromium.org,uwyiming@google.com Change-Id: Icc7e1d800f87d46d8d6ef945672b7a711f7306af No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 885350 Reviewed-on: https://chromium-review.googlesource.com/c/1373474Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium b0bff15d. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: jsbell@chromium.org: external/wpt/encoding NOAUTOREVERT=true TBR=markdittmer No-Export: true Change-Id: Ic250418eabbedcba693187a5532128834272426d Reviewed-on: https://chromium-review.googlesource.com/c/1373278Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#615837}
-
Mirko Bonadei authored
Change Log: https://chromium.googlesource.com/external/github.com/abseil/abseil-cpp/+log/445998d7ac..455dc17ba1 Full diff: https://chromium.googlesource.com/external/github.com/abseil/abseil-cpp/+/445998d7ac..455dc17ba1 Bug: None Change-Id: I258de2a53bb1457e7ff8064e9305d8f12a4362f2 Reviewed-on: https://chromium-review.googlesource.com/c/1371886Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Cr-Commit-Position: refs/heads/master@{#615836}
-
Michael Lippautz authored
The write barrier will ensure that newly set values will be marked black in any case and thus make the callback obsolete. Bug: 843903 Change-Id: I058df9c4e21ba4a5045ea6890b5ee8d5b0e7fc27 Reviewed-on: https://chromium-review.googlesource.com/c/1372788Reviewed-by:
-
![Friedrich Horschig [CET]'s avatar](https://secure.gravatar.com/avatar/f27b033ce4cd5371e6e413eed6db870f?s=80&d=identicon "Friedrich Horschig [CET]")
