- 04 Oct, 2018 40 commits
-
-
Sylvain Defresne authored
TestingFactoryFunction is a simple function pointer. It is deprecated in favor of TestingFactory which is a Callback<>. Convert indirect uses by using base::BindRepeating() in all invocation of SetTestingFactory/AddTestingFactory. This converts uses in src//chrome/browser/profiles. This CL was uploaded by git cl split. R=skuhne@chromium.org Bug: 809610 Change-Id: Ic45b0fc9fbeb570f14e193b37723234c6ab74ee3 Reviewed-on: https://chromium-review.googlesource.com/c/1257932Reviewed-by:
Stefan Kuhne <skuhne@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#596677}
-
Sylvain Defresne authored
TestingFactoryFunction is a simple function pointer. It is deprecated in favor of TestingFactory which is a Callback<>. Convert indirect uses by using base::BindRepeating() in all invocation of SetTestingFactory/AddTestingFactory. This converts uses in src//chrome/browser/ui/views/autofill. This CL was uploaded by git cl split. R=vasilii@chromium.org Bug: 809610 Change-Id: Idd31113f973dcb3906be2c0db166fb8536ee5c99 Reviewed-on: https://chromium-review.googlesource.com/c/1258176Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#596676}
-
Sylvain Defresne authored
TestingFactoryFunction is a simple function pointer. It is deprecated in favor of TestingFactory which is a Callback<>. Convert indirect uses by using base::BindRepeating() in all invocation of SetTestingFactory/AddTestingFactory. This converts uses in src//chrome/browser/ui/webui/signin. This CL was uploaded by git cl split. R=rogerta@chromium.org Bug: 809610 Change-Id: Ib267c7d43afb0b4682fa8232431169012389e732 Reviewed-on: https://chromium-review.googlesource.com/c/1259004Reviewed-by:
Roger Tawa <rogerta@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#596675}
-
Sylvain Defresne authored
TestingFactoryFunction is a simple function pointer. It is deprecated in favor of TestingFactory which is a Callback<>. Convert indirect uses by using base::BindRepeating() in all invocation of SetTestingFactory/AddTestingFactory. This converts uses in src//chrome/browser/safe_browsing/settings_reset_prompt. This CL was uploaded by git cl split. R=robertshield@chromium.org Bug: 809610 Change-Id: Ia4da1523758d8091bad781d01026453d4085560f Reviewed-on: https://chromium-review.googlesource.com/c/1259008Reviewed-by:
Robert Shield <robertshield@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#596674}
-
Sylvain Defresne authored
TestingFactoryFunction is a simple function pointer. It is deprecated in favor of TestingFactory which is a Callback<>. Convert indirect uses by using base::BindRepeating() in all invocation of SetTestingFactory/AddTestingFactory. This converts uses in src//chrome/browser/ui/passwords. This CL was uploaded by git cl split. R=vasilii@chromium.org Bug: 809610 Change-Id: Ibd9fe9cf5088c2c4885b3278073e0979f1b4c6f9 Reviewed-on: https://chromium-review.googlesource.com/c/1257838Reviewed-by:
-
Johannes Kron authored
Bug: chromium:884165 Change-Id: Id84a41af832adcc204e9c6372bc1c85033a0c0b0 Reviewed-on: https://chromium-review.googlesource.com/c/1261476Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Johannes Kron <kron@chromium.org> Cr-Commit-Position: refs/heads/master@{#596672}
-
Xi Han authored
This CL originally comes from ran@'s CL(https://crrev.com/c/1102826). It follows up CLs: https://crrev.com/c/1148959 and https://crrev.com/c/1213308. In this CL, we create the local_state in ChromeFetureListCreator, and its ownership is passed to the BrowerProcessImpl when the full browser starts. Classes required to create FeatureList and setup FieldTrial, e.g. VariationsService, MetricsServicesManager etc., are also created in the ChromeFeatureListCreator and the ownerships are passed to the BrowserProcessImpl when it is instantiated. For ChromeOS, we move the initialization of the DBus to ChromeFeatureListCreator as well before creating the BrowserPolicyConnectorChromeOS. The BrowserPolicyConnector is required to create the PolicyService when creating local_state. internal::PreEarlyInitDBus is moved to a helper file with two static functions. Bug: 848615, 729596 Change-Id: I93a31879e566b14eb01b4e63a4ad8786cc7e16da Reviewed-on: https://chromium-review.googlesource.com/c/1173163 Commit-Queue: Xi Han <hanxi@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Cait Phillips <caitkp@chromium.org> Cr-Commit-Position: refs/heads/master@{#596671}
-
Etienne Bergeron authored
R=oysteine@chromium.org, sebmarchand@chromium.org Bug: 867931 Change-Id: If49d4168b55b32c46e080018469ff392b8136000 Reviewed-on: https://chromium-review.googlesource.com/c/1259614Reviewed-by:
Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Cr-Commit-Position: refs/heads/master@{#596670}
-
Anthony Vallee-Dubois authored
This CL adds 2 histograms that record languages added and removed from Accept Languages by the user from the Explicit Language Ask prompt during Android Chrome 2nd run. Bug: 891307 Change-Id: I1b6e8feb7e3d56f77c0381ec5870eb9694085b74 Reviewed-on: https://chromium-review.googlesource.com/c/1255575Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Michael Martis <martis@chromium.org> Commit-Queue: anthonyvd <anthonyvd@chromium.org> Cr-Commit-Position: refs/heads/master@{#596669}
-
Marc Treib authored
This is a reland of 3efff7c9 Changes from the previous patch: - Fixed the waiting condition in tests to be reliable. TBR=sebsg for autofill_wallet_data_type_controller.cc which is unchanged since the first attempt. Original change's description: > Consistently clear server credit cards with USS > > AutofillWalletDataTypeController is used (pre-USS) for both AUTOFILL_WALLET_DATA > and AUTOFILL_WALLET_METADATA. When Sync is stopped, it calls > PersonalDataManager::ClearAllServerData. Since there are two instances of the > controller, that happens twice (which is unnecessary but doesn't hurt). However, > when AUTOFILL_WALLET_DATA is on USS, then the remaining ClearAllServerData call > (for the metadata controller) still happens, which brings Sync into a bad state > since the data is now gone, but the progress marker is still there (see bug 885211). > > This CL changes AutofillWalletDataTypeController to only call ClearAllServerData > for AUTOFILL_WALLET_DATA (i.e. it won't be called anymore if Wallet is on USS). > Instead, AUTOFILL_WALLET_DATA gets special-cased in ModelAssociationManager to > clear even in the STOP_SYNC case. This achieves the same "clear data on stopping > sync, but *not* on browser shutdown", but without requiring a special side channel > to the SyncService. > > One consequence is that with AUTOFILL_WALLET_DATA on USS, the clearing now happens > asynchronously (because it goes through the DB), which requires some test changes. > > Bug: 889941 > Change-Id: I54c36050c81fa862acfc0052f355ff1645a8b292 > Reviewed-on: https://chromium-review.googlesource.com/1251041 > Commit-Queue: Marc Treib <treib@chromium.org> > Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> > Reviewed-by: Jan Krcal <jkrcal@chromium.org> > Reviewed-by: Florian Uunk <feuunk@chromium.org> > Cr-Commit-Position: refs/heads/master@{#595787} Bug: 889941 Change-Id: I1c577212e06e39cc8fca9a39658d2bd96b6b3bed Reviewed-on: https://chromium-review.googlesource.com/c/1261083 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#596668}
-
Achuith Bhandarkar authored
Bug: 891484 Change-Id: I0bb055d35a1fd9706d26773909837b0526fe4562 Reviewed-on: https://chromium-review.googlesource.com/c/1261655Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Achuith Bhandarkar <achuith@chromium.org> Cr-Commit-Position: refs/heads/master@{#596667}
-
Sylvain Defresne authored
TestingFactoryFunction is a simple function pointer. It is deprecated in favor of TestingFactory which is a Callback<>. Convert indirect uses by using base::BindRepeating() in all invocation of SetTestingFactory/AddTestingFactory. This converts uses in src//chrome/browser/ui/sync. This CL was uploaded by git cl split. R=msarda@chromium.org Bug: 809610 Change-Id: If5762ddf6e72164a48469b451923d757ab2e69c0 Reviewed-on: https://chromium-review.googlesource.com/c/1257933Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#596666}
-
Daniel Bratell authored
A local mojom namespace meant that it became ambigious inside the content namespace whether "mojom" meant "::mojom" or "::content::mojom". This problem surfaced in jumbo build experiments where the compiler knew about the ::content::mojom namespace. In most builds the compiler only knows about ::mojom and then it compiles. Bug: 746953 Change-Id: Ifec37f45009693d7e41eb393ca9bbea136f884b2 Reviewed-on: https://chromium-review.googlesource.com/c/1256926Reviewed-by:
Camille Lamy <clamy@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#596665}
-
Thomas Tangl authored
Bug: 862983 Change-Id: I5313040afd56d6605e3be72a37f07312000b37ef Reviewed-on: https://chromium-review.googlesource.com/c/1259044Reviewed-by:
-
Fredrik Söderquist authored
This allows reusing the data from the KURL - i.e does not require performing canonicalization again. Bug: 889183 Change-Id: I10e5f9b3725a0fb25594bc6dbe61791bb3826fe9 Reviewed-on: https://chromium-review.googlesource.com/c/1257927Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#596663}
-
Andy Paicu authored
As part of checking if the linked bug is still an issue, I have taken the opportunity to fix the current mostly non-sensical tests. Bug: 240058 Change-Id: I716d43d38be6dd161aa0437dbda03f2c77eb6d88 Reviewed-on: https://chromium-review.googlesource.com/c/1225886 Commit-Queue: Andy Paicu <andypaicu@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#596662}
-
Valeriya Sinevich authored
It is needed because server can send RETRY status which means the error is transient and we have to retry. Change-Id: Idbaefa1f1a4d79e10d5b5b361409f29fdbbc4525 Reviewed-on: https://chromium-review.googlesource.com/c/1255223 Commit-Queue: Valeriya Sinevich <valeriyas@google.com> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#596661}
-
Daniel Vogelheim authored
Bug: 890316 Change-Id: I529c99ee497b154ca42d3e3ab5bcf1ab52ab00f3 Reviewed-on: https://chromium-review.googlesource.com/c/1256947 Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/4a72ba99a704..bc2959072dc5 git log 4a72ba99a704..bc2959072dc5 --date=short --no-merges --format='%ad %ae %s' 2018-10-04 barrerap@webrtc.org NetEq: Fix an UBSan error 2018-10-04 mbonadei@webrtc.org Remove noop system_wrappers_default build target. 2018-10-04 minyue@webrtc.org Adding field trial to force target level percentile in NetEQ. 2018-10-04 mbonadei@webrtc.org Revert "Export symbols needed by the Chromium component build (part 1)." 2018-10-04 oprypin@webrtc.org Allow the autoroller service account to commit 2018-10-04 philipel@webrtc.org Don't ovewrite complex member VCMPacket::generic_descriptor when fuzzing. 2018-10-04 saza@webrtc.org Delete deprecated AEC interfaces 2018-10-04 kwiberg@webrtc.org Remove `using` declaration for rtc::Buffer 2018-10-04 mbonadei@webrtc.org Export symbols needed by the Chromium component build (part 1). Created with: gclient setdep -r src/third_party/webrtc@bc2959072dc5 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:886904,chromium:836566,chromium:891597 TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ie1e5ee706877b2abfac26b0f61da440764ba750e Reviewed-on: https://chromium-review.googlesource.com/c/1261420Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#596659}
-
Matthew Cary authored
* Unnecessary debug art libraries are removed from dependancies. * Command-line flag dash vs underscore usage diverged from what the python script uses. Bug: 875276 Change-Id: Icb308a4ce62bdac4d6341952f6f088ad7aa201da Reviewed-on: https://chromium-review.googlesource.com/c/1261555Reviewed-by:agrieve <agrieve@chromium.org> Commit-Queue: Matthew Cary <mattcary@chromium.org> Cr-Commit-Position: refs/heads/master@{#596658}
-
Morten Stenshorne authored
Added a comment to LayoutInline, pointing out that LayoutNG seems to be doing the right thing already, while legacy is wrong. Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I0f906dab6efa7b3d4c72a297926d542f77251052 Reviewed-on: https://chromium-review.googlesource.com/c/1261575Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#596657}
-
Xi Han authored
Reland "[FeatureList] Change GetApplicationLocale() in VariationsServiceClient to be a local function. [2/3]" TThis is a reland of 08ae48ad(r586711, reverted in r588564). The reland caches the locale value in VariationsFieldTrialCreator after calling GetApplicationLocale() in the constructor. This is because GetApplicationLocale() needs IO work and shouldn't be called on the UI thread. Besides, the locale value won't change after the startup, so it is fine to cache its value. Original change's description: Before this function uses a pref in Chrome so we need to override it in Chrome to access that pref value. As a followup for this cl https://crrev.com/c/1135198, now we can access the pref directly in componment/ and we no longer need to do that. This CL comes from https://crrev.com/c/1140356. See previous discussion there. Bug: 729596 Change-Id: I1519f80d393416b58cdb3fcd599fb15e0dd14280 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/c/1213308 Commit-Queue: Xi Han <hanxi@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
-
Raphael Kubo da Costa authored
Alexander's no longer at Intel, so remove his email from those files. While here, add myself to external/wpt/generic-sensor's OWNERS file. Change-Id: Ic14db99aa9caf7f7ec208da5a26d975edc06d824 Reviewed-on: https://chromium-review.googlesource.com/c/1256787Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Raphael Kubo da Costa (CET) <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/master@{#596655}
-
Marc Treib authored
https://crrev.com/c/1030177 introduced lazy creation of the ConfigurationRefresher in SyncTest::InitializeInvalidations. However, it unconditionally re-created it for every Sync client. Re-creating it drops any previous observer registrations, which means the refresher would effectively only work for the *last* client. This CL fixes this by creating it only if it doesn't exist yet. Interestingly, this didn't seem to cause any problems in practice. Bug: 832019 Change-Id: Ic9df260fdc5b8955d591d96678b4e1500035067f Reviewed-on: https://chromium-review.googlesource.com/c/1261439Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#596654}
-
Stephane Zermatten authored
Before this patch, unknown action would be skipped and not reported to the server. This made it difficult to see what actions were unsupported. Also, this made the client mistakenly think that response with only unsupported action signalled the end of a script. This patch introduces an unknown action type, which always fail. This way, neither the client nor the developer will be confused by this case. This patch also transition UpdateProcessedAction from taking a boolean to taking a ProcessActionStatusProto, which lets us be more specific in what failed. I also left TODOs for the cases where we should be more specific and distinguish at least "element not found" from other errors. Bug: 806868 Change-Id: I6efe1f2ac733f2048a5028c5ebb51fab2953868c Reviewed-on: https://chromium-review.googlesource.com/c/1257901 Commit-Queue: Stephane Zermatten <szermatt@chromium.org> Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#596653}
-
Fredrik Söderquist authored
Rather than deferring the check until ExpandUseElementsInShadowTree (which will fail if the initial target is an ancestor of the <use>), just check for cycles directly in BuildShadowAndInstanceTree(), and don't build the initial shadow tree if the cycle check fails. Stop cleaning up the partial tree after ExpandUseElementsInShadowTree(), and adjust HasCycleUseReferencing such that it detects cycles earlier (not requiring a clone into the shadow tree before a cycle can be noticed.) Behavior-wise this means that we now don't clone a target subtree if it will create a cycle. We will however abort cloning of nested <use> after a cycle is detected. Bug: 397525 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I1b2c22bacb63d788509ec7984ac35357b84a3020 Reviewed-on: https://chromium-review.googlesource.com/c/1258065 Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#596652}
-
Mario Sanchez Prada authored
Migrated to IdentityManager::Observer and implemented the corresponding virtual functions from there. Bug: 887465 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I9436fe11d90b7593d05a0bf97ab11134d12105b7 Reviewed-on: https://chromium-review.googlesource.com/c/1257834 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#596651}
-
stkhapugin@chromium.org authored
Calling -containsString: with nil argument throws an exception, so this check is needed. Bug: 880590 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Ieb3944b05fdf3573f6a552c8910025bf93312987 Reviewed-on: https://chromium-review.googlesource.com/c/1225983Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#596650}
-
Mario Sanchez Prada authored
Add new overloads to FakeProfileOAuth2TokenService and IdentityTestEnvironment methods so that we can specify the |id_token| that should be returned along with a token when fetched via AccessTokenFetcher, and use that to check that such information is indeed passed along from the relevant unit tests. Bug: 889764 Change-Id: I593dca07362ce7392d2cd2439369f1b440deb1b3 Reviewed-on: https://chromium-review.googlesource.com/c/1249086Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Cr-Commit-Position: refs/heads/master@{#596649}
-
Javier Ernesto Flores Robles authored
This CL adds the capability to pause the keyboard views when the webstate is hidden. This happens i.e. when the passwords coordinator presents a full screen selection. This way, when the webstate is shown again, it can restore it's views if needed. Bug: 845472 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I5eddf31ada277a1a9c0c0e8cc0ae7be3d8d01ad2 Reviewed-on: https://chromium-review.googlesource.com/c/1236436 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Eric Noyau <noyau@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#596648}
-
Sylvain Defresne authored
TestingFactoryFunction is a simple function pointer. It is deprecated in favor of TestingFactory which is a Callback<>. Convert indirect uses by using base::BindRepeating() in all invocation of SetTestingFactory/AddTestingFactory. This converts uses in src//chrome/browser/sync. This CL was uploaded by git cl split. R=melandory@chromium.org Bug: 809610 Change-Id: Ie5cf8f1bb9884eb74ed4bd44697b8b5a94a85e39 Reviewed-on: https://chromium-review.googlesource.com/c/1258169 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Tatiana Gornak <melandory@chromium.org> Cr-Commit-Position: refs/heads/master@{#596647}
-
Marc Treib authored
We have reports of the DCHECK firing; this will let us figure out which ModelType(s) hand inconsistent data to the processor. Bug: 872360 Change-Id: I7d206a075870fe5be65234a6ebc5ba8d93e2099c Reviewed-on: https://chromium-review.googlesource.com/c/1261396Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#596646}
-
Mathieu Perreault authored
In this change we properly clear PaymentsCustomerData from disk and update several sync integration tests to take this into account. Bug: 884689 Test: sync_integration_tests, components_unittests Change-Id: I851d17fc0d0f1e02817e73d94e6cb7cf8341d6ae Reviewed-on: https://chromium-review.googlesource.com/c/1256283 Commit-Queue: Mathieu Perreault <mathp@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#596645}
-
Sylvain Defresne authored
TestingFactoryFunction is a simple function pointer. It is deprecated in favor of TestingFactory which is a Callback<>. Convert indirect uses by using base::BindRepeating() in all invocation of SetTestingFactory/AddTestingFactory. This converts uses in src//chrome/browser/extensions/api/identity. This CL was uploaded by git cl split. R=courage@chromium.org Bug: 809610 Change-Id: Id702299e37de9a9f224e11f948537c13df068fc6 Reviewed-on: https://chromium-review.googlesource.com/c/1259042 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Michael Courage <courage@chromium.org> Cr-Commit-Position: refs/heads/master@{#596644}
-
Javier Ernesto Flores Robles authored
This new button opens passwords settings. This CL also sets accessibility identifiers for manual fill accessories. Bug: 878388 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I5dde83c04d3e07e37526c2c8456ebe79d549f3c9 Reviewed-on: https://chromium-review.googlesource.com/c/1249486 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#596643}
-
Koji Ishii authored
When lines are wrapped, line-height quirks mode requires each line not to have a strut by default. LayoutNG does this by resetting |text_metrics|, but it forgot to reset |text_top| and |text_height|, two derived variables from |text_metrics|. This results in slightly different geometry for LayoutBR when the layout was paused and restarted from a break token (such as reusing unchanged lineboxes or an inline formatting context was fragmented) from when we layout from top to bottom. This patch properly resets these values so that the layout result is consistent in such cases. Also the changes match better to legacy. Bug: 636993 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I76cdb57daf68833639fc454862af1e296a89d4cd Reviewed-on: https://chromium-review.googlesource.com/c/1260743Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#596642}
-
Vasilii Sukhanov authored
It was recording an obsolete event. Bug: 860737 Change-Id: I642fbd2bf2fd30e33e604c28070371a8fb318bb4 Reviewed-on: https://chromium-review.googlesource.com/c/1255637Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#596641}
-
Sylvain Defresne authored
TestingFactoryFunction is a simple function pointer. It is deprecated in favor of TestingFactory which is a Callback<>. Convert indirect uses by using base::BindRepeating() in all invocation of SetTestingFactory/AddTestingFactory. This converts uses in src//chrome/browser/autocomplete. This CL was uploaded by git cl split. R=tommycli@chromium.org Bug: 809610 Change-Id: I5c6588a869225aeefef8b6d8198d92678a2d7642 Reviewed-on: https://chromium-review.googlesource.com/c/1259028 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#596640}
-
Morten Stenshorne authored
Writing back to legacy layout is a bit bumpy, because legacy layout has the rendered legend inside the anonymous fieldset content wrapper, while in NG it's a direct child fragment of the fieldset container. This solution uses NG painting of block children, which isn't really ready yet. The NG paint code, when first entered, will attempt to descend into everything that doesn't establish a new formatting context. Luckily, both the fieldset container and the anonymous child wrapper establish new formatting contexts, and we have to make sure to mark them as such, to help the NG paint code fall back to legacy painting. Introduced a new NGBoxType that is kMinimumBlockFormattingContextRoot or greater, since none of the other existing types were right (this isn't floated, atomic inline, OOF, etc.) There's no support for self-painting layers established by legends. Most likely better to wait for NG to support layers natively, rather than hacking something up for legends. Similarly no support for fieldsets that establish scrollable containers (also layers), which are supposed to be delegated to the anonymous fieldset content wrapper, and the paint code doesn't want scrollable containers to be established by anonymous objects. The new painting code is inspired by FieldsetPainter and NGBoxFragmentPainter. Added some virtual tests that enable NGFieldset. Rebaselined those that only had irrelevant differences in render tree dumps. Bug: 875235 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I49e9eab8bb4aa469c76a13f15bc16d63c80d5940 Reviewed-on: https://chromium-review.googlesource.com/c/1252581 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#596639}
-
Daniel Vogelheim authored
- An empty trusted-types declaration means no policies are allowed. - A declaration of only "*" means all policies are allowed. - Quoted strings are considered reserved (and thus cannot be policy names) This aligns the implementation close with the trusted types polyfill. Bug: 739170 Change-Id: If9fc66e80d60a81ec4228da35ae8c8820ebaa9b5 Reviewed-on: https://chromium-review.googlesource.com/c/1249269 Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org> Reviewed-by:
Andy Paicu <andypaicu@chromium.org> Cr-Commit-Position: refs/heads/master@{#596638}
-
