- 02 Mar, 2020 40 commits
-
-
Andrew Xu authored
It is a regression issue caused by my recent CL: https://crrev.com/c/2052593. A test case is added for this scenario. Bug: 1057710 Change-Id: Iccdffd7f0eab7d4216a0ae9bc675797f52dc0f10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080954Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Andrew Xu <andrewxu@chromium.org> Cr-Commit-Position: refs/heads/master@{#746112}
-
Robin Lewis authored
Bug: 1039781 Change-Id: Ie89490e0087a752cc746453184cba0f62cb16fc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083345 Commit-Queue: Robin Lewis <wrlewis@google.com> Commit-Queue: Rakesh Soma <rakeshsoma@google.com> Reviewed-by:
Rakesh Soma <rakeshsoma@google.com> Cr-Commit-Position: refs/heads/master@{#746111}
-
Gregory Guterman authored
This reverts commit 5c614415. Reason for revert: The CL is missing an important piece of validation code. 'generate_buildboy_json.py --check' needs to validate the new bucket files, which it does not in this CL. Original change's description: > infra: Generate source side spec by bucket > > Doesn't include internal builders. > > Bug: 1028719 > Change-Id: Iec40cb84086ed23cd7d5ca60c317296460466497 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033847 > Commit-Queue: Gregory Guterman <guterman@google.com> > Reviewed-by: Stephen Martinis <martiniss@chromium.org> > Cr-Commit-Position: refs/heads/master@{#745574} TBR=agable@chromium.org,martiniss@chromium.org,guterman@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1028719 Change-Id: I9f0beb4efc49f532eb8a25137aafc6ad35c36354 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083621Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Gregory Guterman <guterman@google.com> Cr-Commit-Position: refs/heads/master@{#746110}
-
Shimi Zhang authored
AutoCloseableRouter implements close() method from java.io.Closeable, however close() will be called only when used with try-with-resources statement. Normally this class won't be in a try-with-resources statement unfortunately, so one needs to call close() explicitly. Bug: None Test: No logic change, only comments. Change-Id: I9c0b36372b8b51f0d3610fb82799db42a1fb910d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2081012Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Cr-Commit-Position: refs/heads/master@{#746109}
-
Mason Freed authored
Prior to this CL, the chrome://settings and other WebUI pages would report deprecation messages in the Console, such as: [Deprecation] HTML Imports is deprecated and will be removed in M80, around February 2020. Please use ES modules instead. See https://www.chromestatus.com/features/5144752345317376 and https://developers.google.com/web/updates/2019/07/web-components-time-to-upgrade for more details. These will no longer be shown. Additionally, this usage of the deprecated APIs will also no longer be counted. Fixed: 1057337 Bug: 965770 Change-Id: Ibef14072bda8b4ad1147593d587d4fd941669ddb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2081236 Commit-Queue: Mason Freed <masonfreed@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#746108}
-
Peng Huang authored
Base on the log, the crash is because ProduceSkia failed, so we need check it indead of assuming ProdcueSkia() will be always successfully. So the upper level can handle the failure properly. [ERROR:shared_image_backing_factory_ahardwarebuffer.cc(843)] Failed to bind egl image [ERROR:shared_image_manager.cc(219)] SharedImageManager::ProduceSkia: Trying to produce a Skia representation from an incompatible mailbox. Bug: 1055511 Change-Id: Ib7e3494c36a3172efd3e6c3e66b51df771f09328 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083713Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#746107}
-
Johannes Kron authored
Add receive time to video.rAF for remote video sources according to a recent update of the specification https://github.com/WICG/video-raf/pull/17 Bug: chromium:1011581 Change-Id: I7bd7450ff50e5c69f5e85ca3f1182d4d5f264848 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2073940 Commit-Queue: Johannes Kron <kron@google.com> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#746106}
-
Aaron Gable authored
This reverts commit b9f529d2. Reason for revert: The underlying host didn't have its OS updated, so builds weren't able to find any hosts capable of running them. Original change's description: > Promote Mac10.14 Tests to main waterfall > > Mac10.14 Tests is now stable and green, and is ready to be promoted > to the main waterfall alongside its prior-release siblings. This CL > makes a few changes to accomplish that: > 1) Updates the OS of the existing main waterfall Mac Builder to 10.14 > 2) Moves Mac 10.14 Tests to be triggered by Mac Builder > 3) Moves it from just master (like all FYI bots) to exist in branch CI > as well > 4) Moves it from FYI to CI consoles > > This change leaves Mac Builder Next intact, so that it can be updated > and used for 10.15 soon. > > Bug: 1018852 > Change-Id: I3d5723ab7c565c37681696acb2f2de79ddcac1f2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036769 > Commit-Queue: Aaron Gable <agable@chromium.org> > Auto-Submit: Aaron Gable <agable@chromium.org> > Reviewed-by: John Budorick <jbudorick@chromium.org> > Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> > Cr-Commit-Position: refs/heads/master@{#746074} TBR=ellyjones@chromium.org,agable@chromium.org,jbudorick@chromium.org Change-Id: I04c9d8b05cc1ca68465ae22730549ecfd0cf7ed7 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1018852 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2081617Reviewed-by:
Aaron Gable <agable@chromium.org> Reviewed-by:
-
Christopher Cameron authored
This feature has been shipping for a while now. TBR=avi Bug: 982024 Change-Id: Ia16055903779e734836ca6b3868c49fe88a07c42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083533Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#746104}
-
Lei Zhang authored
Link it to device/bluetooth/OWNERS. Change-Id: I368888c62b22883162bfbf4af7d62afef2a0811c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079164Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#746103}
-
Jeff Yoon authored
Run iOS test runner unit tests as part of presubmit. Keeping scope to functional tests, and will have separate CLs for the remaining files that require further fixes. * PRESUBMIT.py - include unit test execution for ios/build/bots/scripts * run.py - unit tests caught logic incorrectness. Running the json parsing first, before validation. * wpr_runner_test.py - remove install xcode mock, fixed broken tests * test_apps_test.py and xcode_log_parser_test.py - include main call to unittest. Bug: 1056457 Change-Id: Ifc233695ba8f6120f862586a497df61e96d4954f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076765Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Jeff Yoon <jeffyoon@chromium.org> Cr-Commit-Position: refs/heads/master@{#746102}
-
S. Ganesh authored
We create the service with a new name if the creation with the original name failed. I think this should take care of failures, and may perhaps fix issue 1023080 as well. The idea here is that in some cases, a deletion of the original service may not be complete and there may still has some stale state left over in the SCM database. In such cases, we may be unable to open it or recreate it. In these cases, we now will create a new name and install a new service. Bug: 1055470 Change-Id: I7e0f5e76892fe29fa597c77cd4b64702a3f717c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071387Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: S. Ganesh <ganesh@chromium.org> Cr-Commit-Position: refs/heads/master@{#746101}
-
Henrique Ferreiro authored
This CL migrates the mentioned legacy IPC message to the content.mojom.FrameHost Mojo interface as RequestOverlayRoutingToken => UnguessableToken. Because it now uses a callback to return its result, the related FrameMsg_SetOverlayRoutingToken message used to receive the token is removed. Bug: 1047321 Change-Id: Id5bb1158c475ec788f95e36160b10adf23ebf30e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2061159Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Cr-Commit-Position: refs/heads/master@{#746100}
-
Yicheng Li authored
This change implements the GetAssertion operation in ChromeOS authenticator. It uses the first assertion returned by ChromeOS platform daemons. Resident credentials are not supported yet. Bug: b:144861739 Change-Id: Icc9ae86568d42a4f15f95e6fdc5cc8fd367353cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040064 Commit-Queue: Yicheng Li <yichengli@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#746099}
-
Adam Langley authored
This change reflects https://github.com/w3c/webauthn/pull/1375 in code. Since that spec change isn't breaking, it's fine to implement this first as the format still conforms to general JSON. This change will allow some validators to test against it, prove out that it works, and then we'll report back results to the W3C group — hopefully resulting in the WebAuthn spec change being accepted. Change-Id: Icedf405bf7eb91b752493badccad892aa9822e9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083394 Commit-Queue: Adam Langley <agl@chromium.org> Auto-Submit: Adam Langley <agl@chromium.org> Reviewed-by:
-
Robert Liao authored
use_color_pipeline is undergoing conversion to a runtime flag. This also moves dump_colors to the same deps as //chrome. BUG=1057239 Change-Id: Ifac81badcd85f338e8374a9ea1d085900ac8264e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080854Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#746097}
-
Stephen McGruer authored
This diff was generated by running: find . -type f -print0 | xargs -0 perl -pi -e 'BEGIN { $/ = undef; } s/assert_throws\(([ \n]*)new ([A-Za-z]*Error) *\(\) *(, *.)/assert_throws_js(\1\2\3/gs' Then manually fixing up whitespace and making the following changes: fast/dom/geometry-interfaces-dom-matrix.html - use assert_thows_dom instead fast/dom/geometry-interfaces-dom-matrix-readonly.html - use assert_thows_dom instead fast/dom/geometry-interfaces-dom-matrix-setMatrixValue.html - use assert_thows_dom instead fast/xpath/parser-crash-by-deep-expression.html - use assert_throws_dom instead http/tests/credentialmanager/federatedcredential-basics.html - use assert_throws_dom instead http/tests/credentialmanager/passwordcredential-basics.html - use assert_throws_dom instead typedcssom/cssUnitValue_toMethod.html - use assert_throws_dom instead Bug: 1051932 Change-Id: Ia4272f7f0a01df7c392007e99aa2c4d14f92017b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079452Reviewed-by:Nina Satragno <nsatragno@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Luke Z <lpz@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#746096}
-
Thomas Tellier authored
Bug: 1047175 Change-Id: If7e1aea305a80889d0527bc12e2f0924ec28ba15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082916Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Thomas Tellier <tellier@google.com> Cr-Commit-Position: refs/heads/master@{#746095}
-
Travis Skare authored
Change-Id: I128817e07c195d1403faccd80f6ee846b179cabe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080789 Commit-Queue: Travis Skare <skare@chromium.org> Reviewed-by:
Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#746094}
-
Guido Urdaneta authored
It is possible to modify the data field without replacing it, so syncing always. Will work on an optimization for a follow-up CL. Bug: 1052765 Change-Id: Ibc5b143413163f12af3c6cacefb3a9ee028b7eb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083092Reviewed-by:
Harald Alvestrand <hta@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#746093}
-
Nate Chapin authored
Change-Id: I3bbae75aa5dfa99bf2ae4053993a50daca3b6bd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2049915 Commit-Queue: Nate Chapin <japhet@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
-
Tomasz Wiszkowski authored
This change pushes the Vertical padding out of the suggestion definition and into the DecoratedSuggestionView. Two variants are available: - Default (10dp paddings, giving 60dp suggestion height) and - Compact (6dp paddings, giving 52dp suggestion height). the 60 and 52 variants were suggested by jpor@. Bug: 1050813 Change-Id: I6e967e0d53d6c485b7feb5773c6981a4eb8d6da4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079298Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Ender <ender@google.com> Cr-Commit-Position: refs/heads/master@{#746091}
-
Reilly Grant authored
The flag to enable WebNFC is now the regular experimental web platform features flag. The "WebNFC" feature can still be used as a kill-switch but should not normally be touched by users or developers. Bug: 1035048 Change-Id: I7989ccd610affb5f0b8341f112a583e5dbacc3f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071365Reviewed-by:
Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#746090}
-
Jonathan Freed authored
Change-Id: I3fe9e64585cbf6115748e9f8eddcdb84475d9aca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083407Reviewed-by:
Dan H <harringtond@chromium.org> Commit-Queue: Jonathan Freed <freedjm@chromium.org> Cr-Commit-Position: refs/heads/master@{#746089}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/9ca9c52c4c04..4576851428dd git log 9ca9c52c4c04..4576851428dd --date=short --first-parent --format='%ad %ae %s' 2020-03-02 ehmaldonado@google.com git-cl: Remove support for GetPreferredTryMasters. Created with: gclient setdep -r src/third_party/depot_tools@4576851428dd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1042324 Tbr: agable@chromium.org Change-Id: I6d45104d7d63fe5d03e8ea55900422e69be58f20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083624Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#746088}
-
Vasiliy Telezhnikov authored
This CL ports some fixes for SkiaRenderer/WebView for case when viz is not enabled. This is not very well supported configuration, fixing to avoid crashes. Bug: 1057623 Change-Id: Ideb473d7c36bde4034a311c27e1210c27ee9acac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083732Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#746087}
-
Robert Sesek authored
Bug: 1057369 Change-Id: Ie17d277b09c084eb224cb3228deb489d2ce96168 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083434 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#746086}
-
Sreerenj Balachandran authored
Make sure to use the VDEnc(Low-Power Fixed Function Encoder on IA platforms)for the VP9 encoder if the driver and hardware have the support. BUG=1057196 TEST=Run the VP9 encoder application on a TGL device and make sure the pipeline is using hardware acceleraton and not falling back to the software encoder. Change-Id: I8af6be2421eeef15cbc69715877b6d1559dde0c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2075879 Commit-Queue: Sreerenj Balachandran <sreerenj.balachandran@intel.com> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#746085}
-
Yue Zhang authored
* Clean up code related to "Create group" button. * Make TabGroup M4 the default setup when TabGroup flag is on. * Remove out-dated feature checks. TBR=yusufo@chromium.org Bug: 1020711 Change-Id: I9fc289f75ba37b17077644bc7593da38924a0402 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913718 Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Reviewed-by:
Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#746084}
-
Xinghui Lu authored
Now that different profiles own their own url_lookup_service, identity_manager can be a reference inside url_lookup_service. This can make url_lookup_service more self-contained and reduce the number of parameters pass into safe_browsing_url_checker. Bug: 1050859 Change-Id: Ic5886460327d79df245b57e4ced967b14bf3b99a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071359 Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
-
Leonard Grey authored
Bug: 1055953 Change-Id: I6e95e0304e2587cb24e3f5e3f302f6ea43cb59aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083591 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Auto-Submit: Leonard Grey <lgrey@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#746082}
-
rbpotter authored
Bug: 1026426 Change-Id: I35cc47e76a5fd46d2851fc3e4b1dd0ff390ea4b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079542 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#746081}
-
Vladimir Levin authored
This patch makes it so that the activation due to scroll to text is allowed to span multiple blocks. The activated element is the block at the beginning of the range. R=chrishtr@chromium.org Bug: https://github.com/WICG/display-locking/issues/125 Change-Id: I4223a59f8910175aaa5c1e877afd2d1e70f9ec93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083574Reviewed-by:
Joey Arhar <jarhar@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#746080}
-
John Budorick authored
Includes content_browsertests and chrome_public_test_apk. Bug: 1056878, 1056325, 1046059 Change-Id: Ic34ecb06a4ef9926bf0550a989df28e477330343 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083596Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#746079}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b780372797ea..e92ada58142f Created with: gclient setdep -r src-internal@e92ada58142f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1053586,chromium:1057083 Tbr: jbudorick@google.com Change-Id: Iebc75342b6c63a1ec636e4bde4a0519676902caf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083616Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#746078}
-
Esmael El-Moslimany authored
The https://chromium-review.googlesource.com/c/chromium/src/+/2076533 CL makes it so the promo is not loaded on the app page during tests. This is likely the cause of the flaky tests. Bug: 1056063 Change-Id: I86c8e17e13625a444e278e9d5f0fe78b78ce3cbe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083339 Commit-Queue: Esmael Elmoslimany <aee@chromium.org> Auto-Submit: Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#746077}
-
Vasiliy Telezhnikov authored
It seems like on NVidia keeping reference to eglImage itself is not enough. When all siblings get deleted all future siblings texture are corrupted (like driver reuses this texture memory). This CL adds gpu driver workaround for NVidia to keep one sibling for the time of SharedImage is kept alive by client. After client calls DestroySharedImage this extra sibling is deleted allowing to clean up memory. As SharedImageBacking is kept alive only by representations after this moment there always will be at least one sibling inside them to prevent bug to occur. Bug: 1052114 Change-Id: Ie1714e1f696e4e59cc5fba12c15e421f694f1a25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080488Reviewed-by:
Peng Huang <penghuang@chromium.org> Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#746076}
-
Tiancong Wang authored
This is an effort to only allow using cros orderfiles and thus hugepages on Chrome OS devices, by checking is_chromeos_device. Try to eliminate possibly of errors on unsupported platforms like linux-chromeos. BUG=chromium:1056198 TEST=linux-chromeos is not using orderfile anymore TEST=emerge chromeos-chrome still has orderfile with crrev.com/c/1995570 Change-Id: I0b394e6e0731e1236db80c77293c3c44afe19684 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076404Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
-
Aaron Gable authored
Mac10.14 Tests is now stable and green, and is ready to be promoted to the main waterfall alongside its prior-release siblings. This CL makes a few changes to accomplish that: 1) Updates the OS of the existing main waterfall Mac Builder to 10.14 2) Moves Mac 10.14 Tests to be triggered by Mac Builder 3) Moves it from just master (like all FYI bots) to exist in branch CI as well 4) Moves it from FYI to CI consoles This change leaves Mac Builder Next intact, so that it can be updated and used for 10.15 soon. Bug: 1018852 Change-Id: I3d5723ab7c565c37681696acb2f2de79ddcac1f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036769 Commit-Queue: Aaron Gable <agable@chromium.org> Auto-Submit: Aaron Gable <agable@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/416d37452275..a4347a9460bb git log 416d37452275..a4347a9460bb --date=short --first-parent --format='%ad %ae %s' 2020-03-02 capn@google.com Enable ASTC on supported builds only Created with: gclient setdep -r src/third_party/swiftshader@a4347a9460bb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: Id0f5cc116f7de8f3cff80b013f9e0892cf1f717e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083620Reviewed-by:
-
