GitLab

R=apavlov

Review URL: https://codereview.chromium.org/426563004

git-svn-id: svn://svn.chromium.org/blink/trunk@179014 bbb929c8-8fbe-4397-9dbb-9b2b20218538

* selector is not required.

BUG=316092

Review URL: https://codereview.chromium.org/420193004

git-svn-id: svn://svn.chromium.org/blink/trunk@179013 bbb929c8-8fbe-4397-9dbb-9b2b20218538

CSSPresentationModel has been introduced in order to
- manage source mappings,
- store live locations,
- perform the rawLocationToUILocation conversions.

R=pfeldman, vsevik

Review URL: https://codereview.chromium.org/297923002

git-svn-id: svn://svn.chromium.org/blink/trunk@179012 bbb929c8-8fbe-4397-9dbb-9b2b20218538

When SharedWorker script load has failed and the |WebSharedWorkerImpl|
was explicit told to terminate, the |WebSharedWorkerImpl| instance
was never deleted.

This CL fixes the issue by invoking "delete this" when a worker thread
instance does not exist in |stopWorkerThread()|.

TEST=fast/workers/worker-crash-with-invalid-location.html doesn't leak when --enable-leak-detection
BUG=364390

Review URL: https://codereview.chromium.org/424653002

git-svn-id: svn://svn.chromium.org/blink/trunk@179011 bbb929c8-8fbe-4397-9dbb-9b2b20218538

As same as http://crrev.com/407073009 , this CL may increase the size of these classes by +16 or +8 bytes. +8 bytes for |m_wrapperOrTypeInfo| (type of uintptr_t) in ScriptWrappable. Another +8 bytes for vtbl.

BUG=235436

Review URL: https://codereview.chromium.org/412183003

git-svn-id: svn://svn.chromium.org/blink/trunk@179010 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This was probably originally FullscreenController.

Also fix a typo and simplify isActiveFullScreenElement.

Review URL: https://codereview.chromium.org/421693003

git-svn-id: svn://svn.chromium.org/blink/trunk@179009 bbb929c8-8fbe-4397-9dbb-9b2b20218538

- Make sure |this| is kept while offlineRender() by passing PassRefPtr<> to
  bind().

- Make sure |this| is kept until finishing notifyComplete() by
  createCrossThreadTask(), which uses bind() internally.

BUG=395941

Review URL: https://codereview.chromium.org/423783002

git-svn-id: svn://svn.chromium.org/blink/trunk@179008 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Hidden columns are supported by DataGrid now.

BUG=316092

Review URL: https://codereview.chromium.org/422543002

git-svn-id: svn://svn.chromium.org/blink/trunk@179007 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=tkent@chromium.org
BUG=

Review URL: https://codereview.chromium.org/421883002

git-svn-id: svn://svn.chromium.org/blink/trunk@179006 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Found by a prototype of -Wunused-local-typedef for clang.

BUG=none

Review URL: https://codereview.chromium.org/427473002

git-svn-id: svn://svn.chromium.org/blink/trunk@179005 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=hajimehoshi
NOTRY=true
BUG=364390

Review URL: https://codereview.chromium.org/427483002

git-svn-id: svn://svn.chromium.org/blink/trunk@179004 bbb929c8-8fbe-4397-9dbb-9b2b20218538

    
When executing editing commands, endingSelection is valid.
However, if undo some commands, endingSelection might be invalid and
FrameSelection might be updated by the invalid selection.
i.e. the selection might be owned by another document without any frames.
    
BUG=368978
TEST=Source/core/editing/FrameSelectionTest

Review URL: https://codereview.chromium.org/359593002

git-svn-id: svn://svn.chromium.org/blink/trunk@179003 bbb929c8-8fbe-4397-9dbb-9b2b20218538

There is no users of it on either Blink or Chromium. This fixes the
FIXME in WebLeakDetector.h.

BUG=None
TEST=None
R=tkent@chromium.org

Review URL: https://codereview.chromium.org/428473002

git-svn-id: svn://svn.chromium.org/blink/trunk@179002 bbb929c8-8fbe-4397-9dbb-9b2b20218538

ElementAnimation:getAnimationPlayers() crashes when it is called and no
animations have been previously created on the element.

BUG=396376

Review URL: https://codereview.chromium.org/423763002

git-svn-id: svn://svn.chromium.org/blink/trunk@179001 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG= 397563

Review URL: https://codereview.chromium.org/422443004

git-svn-id: svn://svn.chromium.org/blink/trunk@179000 bbb929c8-8fbe-4397-9dbb-9b2b20218538

It makes lock/unlock of AudioSourceProviderClient easier.
This class holds a strong reference to AudioSourceProviderClient. So we
don't need MediaElementAudioSourceNode::m_keepAliveWhileLocking.

BUG=395940

Review URL: https://codereview.chromium.org/416333002

git-svn-id: svn://svn.chromium.org/blink/trunk@178999 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Before this patch, calc values in cubic-bezier functions
weren't being read correctly since they were handled as
simple floats.

R=rob.buis@samsung.com,timloh@chromium.org,alancutter@chromium.org
BUG=388332

Review URL: https://codereview.chromium.org/369313002

git-svn-id: svn://svn.chromium.org/blink/trunk@178998 bbb929c8-8fbe-4397-9dbb-9b2b20218538

- Disallow new/delete operations for HitTestResult.
HitTestResult was used
-- with new/delete operators
-- as part objects of ContextMenuController and MouseEventWithHitTestResult.
-- as stack allocated objects

We'd like to avoid to make such classes in Oilpan.
So, this CL disallows new/delete, and WebHitTestResult owns another
class to hold only required data copied from a HitTestResult.

- Move ContextMenuController to Oilpan heap, and trace HitTestResult member.

- Mark MouseEventWithHitTestResults STACK_ALLOCATED.

- We can't get HitTestResult from a WebHitTestResult. So we need to
introduce new function to WebViewImpl for WebSubstringUtil.mm.

Difference from r176393:
Always calling HitTestResult member functions was bad. Some of them are
expensive. So WebHitTestResultPrivate contains a HitTestResult copy, and
WebHitTestResultPrivate is RefCountedWillBeGarbageCollectedFinalized in order to
trace HitTestResult.

BUG=357163

Review URL: https://codereview.chromium.org/413903004

git-svn-id: svn://svn.chromium.org/blink/trunk@178997 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Before this patch, the document held by ServiceWorker registered by
the LayoutTests were detected as leaks. The service worker is designed to live
longer than registerer document. The service worker implementation,
|WebEmbeddedWorkerImpl| carries a |WebFrame| to hold a resource loader.
The frame has its associating document, and it confused WebLeakDetector.

This patch work arounds the issue by terminating all |WebEmbeddedWorkerImpl|
instances before counting number of documents.

BUG=396493

Review URL: https://codereview.chromium.org/413993002

git-svn-id: svn://svn.chromium.org/blink/trunk@178996 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=397892
TBR=hajimehoshi
NOTRY=true

Review URL: https://codereview.chromium.org/415403003

git-svn-id: svn://svn.chromium.org/blink/trunk@178995 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Chrome does not handle large numbers of layers well and the flakiness
dashboard was creating thousands of them (one for each interpolated
result.) This patch switches to manually calculating the opacity value
and baking it into the css. This is less maintainable but avoids
expensive non-zero opacity layers.

http://hex2rgba.devoth.com is a simple tool I used to calculate the
20% opacity version of the test result colors.

NOTRY=true
TEST=manual. With this patch applied, the flakiness dashboard scrolls smoothly.
BUG=397886

Review URL: https://codereview.chromium.org/421853002

git-svn-id: svn://svn.chromium.org/blink/trunk@178994 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Intent to Ship:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/iWDqDWQ8mhs

BUG=243354
R=eseidel@chromium.org

Review URL: https://codereview.chromium.org/418133011

git-svn-id: svn://svn.chromium.org/blink/trunk@178992 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Minimize RenderObject* casting to RenderText* by providing renderer() methods
on Text and InlineTextBox that return a RenderText. This hides the more generic
renderer() methods in their parent that return a RenderObject.

This is inspired by WebKit r157373 by antti@apple.com:
https://trac.webkit.org/r157373

R=esprehn@chromium.org, pdr@chromium.org

Review URL: https://codereview.chromium.org/414863002

git-svn-id: svn://svn.chromium.org/blink/trunk@178991 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=374343

Review URL: https://codereview.chromium.org/421043002

git-svn-id: svn://svn.chromium.org/blink/trunk@178990 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Use tighter typing in editing to increase code readability. This CL focuses on
Editor and EditorCommand.

R=leviw@chromium.org

Review URL: https://codereview.chromium.org/426433002

git-svn-id: svn://svn.chromium.org/blink/trunk@178988 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Of the 2 callers one doesn't really need the conversion and  the other can get
the same results with a local flag.

BUG=

Review URL: https://codereview.chromium.org/412353003

git-svn-id: svn://svn.chromium.org/blink/trunk@178987 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Use tighter typing in editing to increase code readability. This CL
focuses on CompositeEditCommand.

R=leviw@chromium.org

Review URL: https://codereview.chromium.org/424493003

git-svn-id: svn://svn.chromium.org/blink/trunk@178986 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Use tighter typing in editing/ to increase code readability and avoid
unnecessary type checks. This CL focuses on BreakBlockquoteCommand and
Caret.

R=leviw@chromium.org

Review URL: https://codereview.chromium.org/419313002

git-svn-id: svn://svn.chromium.org/blink/trunk@178985 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=178888

BUG=259547
TBR=pkasting@chromium.org

Review URL: https://codereview.chromium.org/419683011

git-svn-id: svn://svn.chromium.org/blink/trunk@178984 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=178873

BUG=108833,178745,248065
TBR=pkasting@chromium.org

Review URL: https://codereview.chromium.org/420613007

git-svn-id: svn://svn.chromium.org/blink/trunk@178983 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=178796

BUG=23476,243732,243248
TBR=pkasting@chromium.org

Review URL: https://codereview.chromium.org/414113006

git-svn-id: svn://svn.chromium.org/blink/trunk@178982 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=178901

BUG=388780,377445
TBR=h.joshi@samsung.com

Review URL: https://codereview.chromium.org/420713010

git-svn-id: svn://svn.chromium.org/blink/trunk@178981 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The current reparenting logic for overlay scrollbars for compositor-
driven scrollable areas does not account for ancestor clips. The result
is that the scrollbars can escape clips that need to affect them.

Consider the following stacking tree. (The '-' characters in the
following trees should be ignored. I've only added them so that
my indenting doesn't get stripped).

+ stacking-context
- + overflow-hidden-clipper
- + overflow-scroller
- + fixed-positioned-descendant-of-the-scroller
- + relative-positioned-descendant-of-the-scroller

Where, in tree order, these are arranged like this
+ stacking-context
- + overflow-hidden-clipper
--- + overflow-scroller
----- + fixed-positioned-descendant-of-the-scroller
----- + relative-positioned-descendant-of-the-scroller

Since overflow-scroller is clipped by overflow-hidden-clipper, a layer
that is not an ancestor in the stacking tree, it gets an ancestor
clipping layer. If the overflow controls are parented under
overflow-scroller's m_graphicsLayer, everything works fine: the
controls inherit the clip from the ancestor clipping layer.

Unfortunately, if we are using overlay scrollbars, we can't hang
the scrollbars under m_graphicsLayer because they'd stack behind
fixed-positioned-descendant-of-the-scroller and
relative-positioned-descendant-of-the-scroller. In order to get things
stacking correctly, we have to reparent the overflow controls like
this:

+ stacking-context
- + overflow-hidden-clipper
- + overflow-scroller
- + fixed-positioned-descendant-of-the-scroller
- + relative-positioned-descendant-of-the-scroller
- + <overflow controls for overflow-scroller>

If we reparent the controls like this in the graphics layer tree,
the overflow controls will no longer be a descendant of the
ancestor clipping layer that applies the clip for m_graphicsLayer,
unfortunately. In order to get the overflow controls clipped
correctly, we need to ensure that they have a clipping layer
above them. This CL adds m_overflowControlsClippingLayer for this
purpose.

BUG=393926

Review URL: https://codereview.chromium.org/397713004

git-svn-id: svn://svn.chromium.org/blink/trunk@178980 bbb929c8-8fbe-4397-9dbb-9b2b20218538

These test cases should have been enabled when Blob support landed, but
were missed.

BUG=108012
R=cmumford@chromium.org,dgrogan@chromium.org

Review URL: https://codereview.chromium.org/414223008

git-svn-id: svn://svn.chromium.org/blink/trunk@178979 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Now that the spec specifies that data should be passed using
ArrayBuffer/ArrayBufferView, change the IDL to match.

BUG=358271
TEST=Updated EME layouts tests pass

Review URL: https://codereview.chromium.org/397463005

git-svn-id: svn://svn.chromium.org/blink/trunk@178978 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=178952

BUG=394833
TBR=wangxianzhu@chromium.org

Review URL: https://codereview.chromium.org/416403010

git-svn-id: svn://svn.chromium.org/blink/trunk@178977 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We must notify nodes that they were removed before calling childrenChanged
because childrenChanged could run script. If don't then the script can remove
the parent and then Element::removedFrom doesn't think the parent is
inTreeScope or inDocument so it'll fail to clean up the TreeScope hash maps
like the id map.

I tried this once before for a different reason in:
https://src.chromium.org/viewvc/blink?revision=175732&view=revision
but that got rolled out because it caused crashes http://crbug.com/382160

By looking at the code it appears that the reason for this is that
m_element in the WebPluginContainerImpl is a raw ptr, and so nothing is
keeping the element alive inside the UpdateSuspendScope. In this patch
I didn't remove the NodeVector, a future patch will attempt to do that.

Unfortunately even when I did remove the NodeVector I couldn't reproduce
the crashes mentioned in the bug, but by code inspection and the crash
stacks it appears to be the situation I described.

BUG=387389

Review URL: https://codereview.chromium.org/418133003

git-svn-id: svn://svn.chromium.org/blink/trunk@178976 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is the final part of the core infrastructure of Blink-in-JS. This CL implements internal APIs exposed only to private scripts. They are not visible from user's JavaScript. They are needed for moving XSLT and editing/ to Blink-in-JS.

Here is a summary of the IDL extended attributes around private scripts:

interface X {
  aaa();
  [ImplementedInPrivateScript] bbb();
  [OnlyExposedToPrivateScript] ccc();
  [ImplementedInPrivateScript, OnlyExposedToPrivateScript] ddd();
};

- aaa() is a normal DOM method implemented in C++. aaa() is exposed to both user's JavaScript and private scripts.

- bbb() is implemented in a private script. bbb() is exposed to both user's JavaScript and private scripts.

- ccc() is implemented in C++. ccc() is exposed only to private scripts.

- ddd() is implemented in a private script. ddd() is not exposed to user's JavaScript nor private scripts. V8X::ddd() is exposed to C++ so that Blink can invoke ddd() from C++.

In other words, we essentially need the following four kinds of APIs, and the two IDL attributes control the kind of each API.

- user's JS & private scripts => C++ (e.g., aaa())
- user's JS & private scripts => private scripts (e.g., bbb())
- private scripts => C++ (e.g., ccc())
- C++ => private scripts (e.g., ddd())

This design might be a bit confusing but this is the least confusing design we can come up with at the moment.

BUG=341031
TEST=fast/dom/private-script-unittest.html

Review URL: https://codereview.chromium.org/413393003

git-svn-id: svn://svn.chromium.org/blink/trunk@178974 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=dpranke@chromium.org
BUG=397678

Review URL: https://codereview.chromium.org/421623005

git-svn-id: svn://svn.chromium.org/blink/trunk@178973 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=178711

BUG=395103,390587
TBR=pkasting@chromium.org

Review URL: https://codereview.chromium.org/422603002

git-svn-id: svn://svn.chromium.org/blink/trunk@178972 bbb929c8-8fbe-4397-9dbb-9b2b20218538