GitLab

This is needed because of how argument-dependent lookup works (it
looks in the namespace of the type for an unqualified function name).

According to go/using-std-swap, the recommended usage pattern is:
  using std::swap;
  swap(thing1, thing2);
Having swap outside of base namespace wouldn't work with this
recommendation as slower std::swap would be silently used instead.

Bug: 1073933
Change-Id: Ib4485b51ba52ad491306bec9b4402a154adae16c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2167796
Auto-Submit: Bartek Nowierski <bartekn@chromium.org>
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#763350}

Jank analysis uncovered that Windows uses native ::PeekMessage calls as
an opportunity to yield to other threads according to some heuristics
(e.g. presumably when there's no input but perhaps a single WM_USER
message posted later than another thread was readied). MessagePumpForUI
doesn't intend to give this opportunity to the kernel when invoking
::PeekMessage however as it runs most tasks out-of-band. Hence,
PM_NOYIELD should be used to tell ::PeekMessage it's not the only source
of work for this thread.

R=fdoray@chromium.org

Bug: 1075960
Change-Id: Ic8808cab8c15aa690f7dfd8405741323285c107b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2169728
Auto-Submit: Gabriel Charette <gab@chromium.org>
Commit-Queue: François Doray <fdoray@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#763349}

These all seem to be related to each other:
ProfileHelperTest.DeleteActiveProfile (WIN)
ProfileHelperTest.DeleteSoleProfile (WIN)
ProfileManagerBrowserTest.DeleteAllProfiles (WIN)
ProfileManagerBrowserTest.DeleteCurrentProfile (WIN + LINUX)
ProfileManagerBrowserTest.DeleteSingletonProfile (WIN)

TBR=droger@chromium.org,rhalavati@chromium.org

Bug: 1073451
Change-Id: Id3817808337330664a04210ed6a3a1c94639ac1a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2169104Reviewed-by: Alexander Hendrich <hendrich@chromium.org>
Commit-Queue: Alexander Hendrich <hendrich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#763348}

Bug: None
Change-Id: I9d6c7023c3ec0bd016a84606fda509a3f56e6496
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2169990Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Victor Vianna <victorvianna@google.com>
Cr-Commit-Position: refs/heads/master@{#763347}

URL navigation in incognito with intent based scheme "intent://"
currently results in one of these behaviour:

1) Launches an incognito intent with a user dialog that requires
permission to leave incognito. This is shown only if chrome can't
handle the resultant intent via willChromeHandleIntent method.
The method willChromeHandleIntent returns true, if target intent
has the same package name as chrome; if not then android is
asked to resolve this check; the method returns false otherwise.
|OVERRIDE_WITH_ASYNC_ACTION|

2) Default case, launches the resultant intent without any user
dialog. |OVERRIDE_WITH_EXTERNAL_INTENT|

Behaviour 2 is a bug that leaks user session from incognito without
the user dialog. For example, clicking on an intent url that opens
custom tabs from incognito doesn't show any dialog. This is
because, the package name of intent is that of chrome which
fails condition 1.

This CL modifies the behaviour in incognito for external navigation
from intent based schemes as :

a) Same as behaviour 1.
b) In case chrome can handle the resulting intent it will continue
to do so in the incognito session.
c) The default case, i.e behaviour 2, is no longer true for incognito
session, we will fall in either a) or b) always.

It also adds unit tests and browser test.

Bug: 1062548, 1062550
Change-Id: I1dcab96f054e2696c6993a9f11975e436bc12ebe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148738Reviewed-by: Rohit Agarwal <roagarwal@chromium.org>
Reviewed-by: Ramin Halavati <rhalavati@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Reviewed-by: Peter Conn <peconn@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Commit-Queue: Rohit Agarwal <roagarwal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#763346}

This CL makes the numbers in the debug string in the FrameSequenceTracker
% 1000 such that the debug string won't be too long, and will be
easier for debugging.

Bug: 1072482
Change-Id: I732eced597a568dc365eafa6d12b8661469ca486
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2166394Reviewed-by: Robert Flack <flackr@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#763345}

This patch changes "paste-4039777-fix.html" to utilize selection_test() for
ease of maintenance and help to implementing EditingNG.

Bug: 707656, 679977
Change-Id: I1b16bde5e3b6d3bb4a3d82551dbda7787e7b47c7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2170007
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Auto-Submit: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#763344}

Extend the expiry of AccountManager.TokenLoadStatus histogram by 1 year.

Bug: 1075621
Change-Id: Ia5d7e664c2e4d42098bd24608326f9d2f9363bc2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2169893
Commit-Queue: Kush Sinha <sinhak@chromium.org>
Commit-Queue: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#763343}

This CL adds a render test for
AccountPickerDialogFragment.updateSelectedAccount to check that this
call updates the account selection mark.

Bug: 967374
Change-Id: I0ebd2abfa0f7782daa3b2690101271af65dc1f0f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2166904Reviewed-by: Boris Sazonov <bsazonov@chromium.org>
Commit-Queue: Alice Wang <aliceywang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#763342}

Change-Id: Ib2f8514e4c1c54cf92bb25c66109fbe3a243564f
Bug: 1075680
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145249
Commit-Queue: Vincent Boisselle <vincb@google.com>
Reviewed-by: Dan H <harringtond@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#763341}

Bug: 1074512
Change-Id: Ic7d1436b78fb5786cb451a33e4c7d0448fd13721
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2167761
Commit-Queue: Alex Chau <alexchau@chromium.org>
Reviewed-by: Michael van Ouwerkerk <mvanouwerkerk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#763340}

This is a reland of 0823e911

Plus: missed the nacl-broker process type (used for x86 on x64 nacl).
This previously reported kInvalid as a sandbox type, and acted as if
it had no sandbox, so now has kNoSandbox following
components/nacl/browser/nacl_broker_host_win.cc:36.

TBR'ing wez & jam as those parts are unchanged.

Original change's description:
> Exchange SandboxType::kInvalid for a CHECK.
>
> No processes should be launched with an invalid combination of flags for
> sandboxing. This eliminates SandboxType::kInvalid and adds a CHECK at
> the point where the command line is parsed when child processes start.
>
> Unit tests exist for this code and continue to pass. Tests that
> verified that bad command lines were recognized are now removed as
> Chrome will safely CHECK in these cases.
>
> The following changes in default or behavior:-
>
> * cloud print service (--type=service) now reports kNoSandbox
> * NaCl loader process on non-Mac now reports kUtility
>    - The NaCl loader defines its own sandbox but its command line
>      is processed in some tests and needs a valid value.
> * Fuchsia: sandbox types are now enumerated and the type must be
>    specified when the low level sandbox policy is constructed.
> * Linux: type added for Zygote to have before it grows up to get a
>    real sandbox
>
> Bug: 1065087
> Change-Id: Ibe277153fa58771d12bae7e3c2f9c6b92b9370a4
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120049
> Reviewed-by: John Abd-El-Malek <jam@chromium.org>
> Reviewed-by: Wez <wez@chromium.org>
> Reviewed-by: Robert Sesek <rsesek@chromium.org>
> Commit-Queue: Alex Gough <ajgo@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#762525}

TBR=wez,jam

Bug: 1065087
Change-Id: Ic66f04e7ac05de694d16eff7af3387d333d8149c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2167995Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Alex Gough <ajgo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#763339}

This CL adapts //chrome's translate_manager_browsertest.cc tests of
several error conditions to //weblayer. There are more that can be
adapted, but this seemed like a reasonable initial cutpoint.

Bug: 1025620
Change-Id: Ia1c79c23e2193bf5f35a75a5be1fccbc42bb5a1a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2161017
Commit-Queue: Colin Blundell <blundell@chromium.org>
Reviewed-by: anthonyvd <anthonyvd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#763338}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/df658be0297c..3623f72383d9


Created with:
  gclient setdep -r src-internal@3623f72383d9

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC yukishiino@google.com,hendrich@google.com,tommycli@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: chromium:1019685
Tbr: yukishiino@google.com,hendrich@google.com,tommycli@google.com
Change-Id: Id4d22619f55168ce1c26c142455620e4cfed2905
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2170249Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#763337}

Firefox has not stored search engine data in XML files in the past five
years (https://bugzilla.mozilla.org/show_bug.cgi?id=1203167). Something
about the search engines importer is causing crashes, but with no tests
and no good way to get an old-style profile to test with, fixing that
bug is difficult. Just remove the code instead, since it has bitrotted
and it's unlikely that anyone is importing a 3+ year-old Firefox profile
that has not been migrated to the new storage scheme.

Firefox now stores search engines in an LZ4-compressed JSON file called
search.json.mozlz4, which would be the thing to read if Chromium wanted
to re-add support for importing Firefox search engines.

Bug: 1073905
Change-Id: Ib1643d64407a550805105908df40075d85cfa118
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2163872Reviewed-by: Gabriel Charette <gab@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#763336}

This CL defines new performance tests to evaluate 2 different cases.

One is measuring how efficient we implement the propagation of a custom
property when its declaration changes.

The other test evaluates the performance of a case that apparently
forces a style recalc which implies resolving all the variable
references.

Change-Id: Ib4576670ee9914aca8d1eea9eac3e085493350ca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153124Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Javier Fernandez <jfernandez@igalia.com>
Cr-Commit-Position: refs/heads/master@{#763335}

https://android.googlesource.com/platform/external/perfetto.git/+log/bed1eba707ac..03fcfdd74f97

git log bed1eba707ac..03fcfdd74f97 --date=short --first-parent --format='%ad %ae %s'
2020-04-28 eseckler@google.com processor: Fix a potential use-after-free

Created with:
  gclient setdep -r src/third_party/perfetto@03fcfdd74f97

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel
Bug: None
Tbr: perfetto-bugs@google.com
Change-Id: I31a9ecf51781e592dde256e59e19af3c5362b017
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2170248Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#763334}

Was left over from previous cleanup: https://crrev.com/c/1287209

Now confusing due to newly added kEnableExperimentalCookieFeatures flag.

Bug: 840359
Change-Id: If7342f18acec92307292fde1948baa5bfbefc450
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2169575
Commit-Queue: Matt Menke <mmenke@chromium.org>
Auto-Submit: Lily Chen <chlily@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#763333}

Also adds stubbed out support for ATK for follow-up work.

Bug: 1074380
Change-Id: Ifeaf86aa1581c5e374e09edfe4ddea89c63aa084
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2165568
Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
Reviewed-by: Nektarios Paisios <nektar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#763332}

This reverts commit b28a9077.

Reason for revert: consistent test failures on linux TSan bots (see https://crbug.com/1075983)

Original change's description:
> heap: Whitelist bailout for Vectors
> 
> This CL introduces VectorTraits<T>::kCanTraceConcurrently which serves
> as a whitelist for skipping the bailout in Vector/Deque concurrent
> marking.
> Default is set to false. Only Member nad Persistent types are currently
> set to true.
> 
> Bug: 986235
> Change-Id: Ibbddde09221bc9ac29366c1538a13a03ce84672c
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148741
> Commit-Queue: Omer Katz <omerkatz@chromium.org>
> Reviewed-by: Kentaro Hara <haraken@chromium.org>
> Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#763302}

TBR=haraken@chromium.org,mlippautz@chromium.org,omerkatz@chromium.org

Change-Id: Idcc8a3c39b4ae7d6410a4da331d123bd20a84d12
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 986235
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2169105Reviewed-by: Alexander Hendrich <hendrich@chromium.org>
Commit-Queue: Alexander Hendrich <hendrich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#763331}

This implements the change in
https://github.com/httpwg/http-extensions/issues/1083, where dictionary
members are specified to default to boolean True if their value is
omitted from headers, and are required to be omitted from serialization
if their value is True, even if they have associated parameters.

This allows dictionary headers of the form

    Header: key;param=value

where 'key' will be assigned the value 'true' by default.

Bug: 1069784
Change-Id: I1d08ef812bf7316fd69b36094e4ea932ac367be2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091712Reviewed-by: Asanka Herath <asanka@chromium.org>
Commit-Queue: Ian Clelland <iclelland@chromium.org>
Cr-Commit-Position: refs/heads/master@{#763330}

The performance bug on Trend Micro's side that necessitated disabling
the profiler is reported to be fixed. So we can remove the workaround
that disables the profiler.

This is an effective revert of 7ce02641.

Bug: 1018291
Change-Id: Id45265b8992f547bc0b68da7b65ffebc06d8e704
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2168796
Auto-Submit: Mike Wittman <wittman@chromium.org>
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
Reviewed-by: Etienne Pierre-Doray <etiennep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#763329}

A recent change on browser view controller stop setting the dispatcher
on Password Controller. This is preventing PasswordBreachCommands to be
dispatched, as well as setting a nil dispatcher in the delegate in
IOSChromeSavePasswordInfoBarDelegate.

The fix in this CL is to get the dispatcher from the new passed object
|browser| and cast it using HandlerForProtocol. Also adds some DCHECKs
to try to catch this issue early next time.

Cleans up now unused dispatcher property.

Bug: 1075961
Change-Id: Iaef1df9870b9b7f788dcf5175d60ded86bd9eb90
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2170095Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#763328}

This patch adds support for explicit timestamps on async events, which
will enable us to typify e.g. LatencyInfo event argument.

Bug: 149824486
Change-Id: Iab11436140482c77c41459313ee594d2d01d5592
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2164752
Commit-Queue: Andrew Shulaev <ddrone@google.com>
Reviewed-by: Eric Seckler <eseckler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#763327}

This CL dedupes several functions related to calculating the referrer
between the //chrome and //weblayer embeddings of
//components/external_intents. We do this by moving these functions into
the shared ExternalNavigationHandler. This necessitates adding a new
ExternalNavigationDelegate method and adjust a couple existing delegate
methods to take referrer-related state as params rather than
calculating it internally.

A note: We add ExternalNavigationDelegate#hasValidTab() rather than
incorporating the usage of that method into the implementations of
ExternalNavigationDelegate#getWebContents() because there are many
accesses of the WebContents instance in //chrome's
ExternalNavigationDelegateImpl that do not guard the access by checking
hasValidTab(). We will be porting some of these accesses to
ExternalNavigationHandler, and we don't want to take a risk by changing
semantics in doing so.

Bug: 1071390
Change-Id: I205a2ed92d581152f1e21377478979182fc324fc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2166908Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Commit-Queue: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#763326}

This CL deprecates two data types: FAVICON_IMAGES and FAVICON_TRACKING.
The CL also removes all logic related to these data types that can be
removed at the moment. The actual data types need to stay until 2020-12
because of clean-up code.

Bug: 978775
Change-Id: I396ba5f55b97075635167d762677f51e5dc6612e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2162847
Auto-Submit: Jan Krcal <jkrcal@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#763325}

By subtracting 1 at the call sites, the argument is always either zero
or negative (but never positive), which can conceptually be thought of
as occasionally undoing an overly eager parse to get back to the error
(but never skipping ahead).

Bug: 1069271
Change-Id: I16cf3a9812a9624f2aa5d561c3996c2c6b3dc124
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2160673Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Nigel Tao <nigeltao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#763324}

getHandler() may return null, which the code was not
prepared for.

I'll work out a test case separately.

BUG=1075662
TEST=none

Change-Id: Ie880cba5a7bcfeaf848a71d667c36cc30e5b57ff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2169021Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#763323}

The lock retries are not helping very much and there are indications
that other things may be going on. Add additional metrics/diagnostics:

- Record if we enter WebView initialization more than once, as this
  implies that an app caught and ignored an exception we threw during
  the previous init; this is one possible cause of problems with the
  data dir lock and is not safe (our init is not restartable).

- Detect if we already hold the lock when entering AwDataDirLock.lock
  and log more specific information about this state, as well as
  explicitly crashing on non-stable channels.

- Include the current process's name and pid in the error for failing to
  acquire the lock as well as those of the current lock holder, to make
  the error message more meaningful when seen outside the context of
  actual log output.

Bug: 557377, 1054774

Change-Id: Id3d3f92a9c4650cef7b5d26d141c5a977e2a3bfb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153785
Auto-Submit: Richard Coles <torne@chromium.org>
Commit-Queue: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Tobias Sargeant <tobiasjs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#763322}

https://chromium.googlesource.com/angle/angle.git/+log/7c83a44539bf..80d3e268d2ec

git log 7c83a44539bf..80d3e268d2ec --date=short --first-parent --format='%ad %ae %s'
2020-04-28 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-validation-layers/src 1512acdf047f..72b2a3b275e5 (4 commits)
2020-04-28 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-headers/src 62becc509a88..4c19ae6b95e4 (1 commits)
2020-04-28 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-tools/src 7774c964d3df..30eb0a301c33 (1 commits)
2020-04-28 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/SwiftShader 60aa34a990fa..2717702e9a1f (6 commits)
2020-04-28 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/spirv-tools/src 5547553a0c7b..23d68608b007 (7 commits)

Created with:
  gclient setdep -r src/third_party/angle@80d3e268d2ec

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC cnorthrop@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86
Bug: None
Tbr: cnorthrop@google.com
Change-Id: Iefe20d4192f48c19068a39330e1966097b70a472
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2170246Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#763321}

Profile API is being updated (issue 1033903) and the usage of
GetOffTheRecordProfile and HasOffTheRecordProfile without argument is
getting deprecated. Use cases of this call that ONLY refer to incognito
or guest mode can use [Get/Has]PrimaryOTRProfile() instead.

All calls to this function in c/b/ui/toolbar are updated.

This CL does not make any behavioral changes.

Bug: 1060940
Change-Id: I6c8fbc991bf434f40835b90c8e46e1887ce64c06
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2167434Reviewed-by: Finnur Thorarinsson <finnur@chromium.org>
Reviewed-by: Brandon Tolsch <btolsch@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#763320}

Updates patches so they apply, and fixes the the --feature-jar patch.

Bug: 1032609
Change-Id: Ic33b85e0dc4991fe92a8c671f778eabd9027d55d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2168216
Commit-Queue: Sam Maier <smaier@chromium.org>
Auto-Submit: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Sam Maier <smaier@chromium.org>
Cr-Commit-Position: refs/heads/master@{#763319}

This is needed to support the stalemanifest case, i.e when the
manifest is no longer available but an update is still required
to use a newer shell version.

This is also needed for intranet requests, since the server won't
be able to fetch the icons.

Bug: 1074351

Change-Id: I538b0ee054d14ed4c2881d28ca6c6c2f6636df8f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2162733Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Peter Kotwicz <pkotwicz@chromium.org>
Commit-Queue: Rayan Kanso <rayankans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#763318}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/811c6e98ee25..80e9d2ce1c17

git log 811c6e98ee25..80e9d2ce1c17 --date=short --first-parent --format='%ad %ae %s'
2020-04-28 sigurds@chromium.org [issues] Introduce the IssueAggregator abstraction

Created with:
  gclient setdep -r src/third_party/devtools-frontend/src@80e9d2ce1c17

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: chromium:1073797
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: I199dd42decc7ca784ba0d67a78020484e9b00831
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2169983Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#763317}

CustomTabNavigationDelegate was getting |clientPackageName| from
|TabAssociatedApp.getId| but it could change over time (reset to null
whenever IME event occurs). The valid name should be cached once and
used for the rest of its lifetime. This was how it worked before the
bug snuck in at https://crrev.com/c/1843994. This CL rectifies it.

Bug: 1034872
Change-Id: I3d39dfdb983770dbc5b0b239d5496e7cbe4b15bf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2169446Reviewed-by: Peter Conn <peconn@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#763316}

Extends the histogram and updates its owners.

Bug: 1061970
Change-Id: Ie32b09b7a5d1e705da2c207cbca47557064a34dc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2167448
Commit-Queue: Alex Ilin <alexilin@chromium.org>
Auto-Submit: Boris Sazonov <bsazonov@chromium.org>
Reviewed-by: Alex Ilin <alexilin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#763315}

Convert a few places which can use FrameTreeNode::parent to use
RenderFrameHostImpl::GetParent instead.

This is more robust given that GetParent() never changes, while the
current RenderFrameHost in the parent FrameTreeNode might.

R=arthursonzogni@chromium.org,creis@chromium.org,lfg@chromium.org
CC=​alexmos@chromium.org,bfcache-bugs@chromium.org
BUG=1073269

Change-Id: I9b162f48825688f4b20c329721630d4c5cedb3e5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2161076Reviewed-by: Charlie Reis <creis@chromium.org>
Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Commit-Queue: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#763314}

ShowWidgetMessageFilter could be destroyed after the browsertest body
exits and on a different sequence as the IPC ChannelProxy will hold a
reference to it.
Explicitly 'shut down' the ShowWidgetMessageFilter before the
browsertest body exits so that it stops observing the passed WebContents
in a well-defined state (i.e. on the UI thread and before the
WebContents itself may go out of scope)

Also while here, move from deprecated MessageLoopRunner to RunLoop in
ShowWidgetMessageFilter.

A note about this property of BrowserMessageFilters will be added in
CL:2168871.

Bug: 830337
Change-Id: I8cbbc82fbd6b65034ce190f76034ddf2d55f5079
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2166165Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Pavol Marko <pmarko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#763313}

Found out that the height of the toolbar in ConfirmationAlertVC
was different when the VC was instantiated in compact height
versus regular height. With this change, the toolbar will
update its height accordingly.

Bug: 1064990
Change-Id: I13a6f130fdf86516e2f0c72526b66e6057a58569
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2166427Reviewed-by: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org>
Cr-Commit-Position: refs/heads/master@{#763312}

OTRProfileID java class is added and Profile.java and ProfileAndroid
C++ classes are updated to support OTRProfileID.

Bug: 1033903
Change-Id: I16e0cee4e3bbf9b3baa097508fda774ce8cf36cb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144965
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Reviewed-by: Boris Sazonov <bsazonov@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Cr-Commit-Position: refs/heads/master@{#763311}