- 29 Jun, 2018 40 commits
-
-
Shakti Sahu authored
Provided implementation for DownloadOfflineContentProvider::OpenItem. It will call DownloadItem::OpenDownload and eventually hits ChromeDownloadManagerDelegate. We will also need to pass DownloadOpenSource to this interface later for UMA purposes. Bug: 855727 Change-Id: I86f4f802ab8711ea2162e512e18cbcbf93c1822f Reviewed-on: https://chromium-review.googlesource.com/1114068 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#571580}
-
Ken Rockot authored
This prevents Chrome from attempting to spin up an instance of the download_manager service on non-Android platforms, where it doesn't exist. Stops spam from the service manager regarding the service. Bug: 859111 Change-Id: Ie2eef9d5d8dfa7bf6573fae1768fe7a9f5b61a85 Reviewed-on: https://chromium-review.googlesource.com/1120644 Commit-Queue: Ken Rockot <rockot@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#571579}
-
Xiangjun Zhang authored
To support the new media remoting UI, for each cast session, permission is checked once at the first time render requests to start remoting. TBR=imcheng@chromium.org Bug: 849020 Change-Id: I0663190707e2fed9ae5cf2392a57c0b79475dd0c Reviewed-on: https://chromium-review.googlesource.com/1099267 Commit-Queue: Xiangjun Zhang <xjz@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Cr-Commit-Position: refs/heads/master@{#571578}
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/e33bdbe1d4a1..f028e346c07f git log e33bdbe1d4a1..f028e346c07f --date=short --no-merges --format='%ad %ae %s' 2018-06-29 xixuan@chromium.org chromeos_config: Enable skylab_hwtest for reef. Created with: gclient setdep -r src/third_party/chromite@f028e346c07f The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:854862 TBR=chrome-os-gardeners@chromium.org Change-Id: I366e565516ba4e43459db34eab77d73052f65794 Reviewed-on: https://chromium-review.googlesource.com/1120836Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#571577}
-
S. Ganesh authored
* This change exposes individual elevator class factories via the Elevator. * A more tenable approach as compared to the former commands-based approach. Design document: Design document link will be added to the linked bug soon. Bug: 833687 Change-Id: Iea4b981c7b4375788c8333a4fe5dc0ac51c1585d Reviewed-on: https://chromium-review.googlesource.com/1106045Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: S. Ganesh <ganesh@chromium.org> Cr-Commit-Position: refs/heads/master@{#571576}
-
Wenzhao Zang authored
A combination of several small fixes: 1) Use the image title as the aria-label of each image. 2) Add role attribute to all buttons. 3) The "Explore" button should be hidden when the url is empty. 4) Enable selecting the entire image collection by using Tab key only (previously user has to use the up and down arrows). Bug: 779449, 857585, 857567 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I36d2a15de494ad4294d67aab15e897d69b9c3faa Reviewed-on: https://chromium-review.googlesource.com/1119645Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#571575}
-
Christian Fremerey authored
Fixes an issue where takePhoto would occasionally fail due to a Java object being released too early. In particular, an ImageReader instance is created and its Surface object is held on to and used asynchronously while the ImageReader goes out of scope and may get garbage collected. The fix is to hold on to the ImageReader instance for as long as the Surface may be used. Bug: 846576 Change-Id: Icb0e3b247a1a75af8ce86c44774960c2b036083b Reviewed-on: https://chromium-review.googlesource.com/1117854Reviewed-by:
Emircan Uysaler <emircan@chromium.org> Commit-Queue: Christian Fremerey <chfremer@chromium.org> Cr-Commit-Position: refs/heads/master@{#571574}
-
Sky Malice authored
Also updated DownloadServiceImpl's pending tasks and actions to use OnceClosure and fixed lint errors in modified files. Bug: 714018 Change-Id: I3efdae52913657519dfca2bd1aa7b46aa98ae45d Reviewed-on: https://chromium-review.googlesource.com/1117311Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Commit-Queue: Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#571573}
-
Nico Weber authored
On most bots, we don't know why the test is disabled. Worst case, we'll find out and redisable it on bots where it doesn't yet work for some reason. On Mac 10.13 and Win 7, we do know why it's disabled, but the Win 7 bug has been fixed, and the 10.13 bug was spurious and I have put in better debug logging if it were to fail again, and I haven't seen any failures in the last 200 builds on the main waterfall. Bug: 846729,813163,843511 Change-Id: Ibd14dea1c5fb72bc4d298b53f55e87be05aa211e Reviewed-on: https://chromium-review.googlesource.com/1120225 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#571572}
-
Nico Weber authored
The currently disabled set of tests on that bot is fairly arbitrary. Since the bot is currently red anyway and has been for a while (see 2nd bug), let's run all tests there, and when we get around to greening it up we can then disable suites that turn out to be unamenable to fixing. It likely won't be the suites that are currently disabled. Bug: 843511,851705 Change-Id: Ifabc504fe56ebdbdab32609055cdaf39d8d73d11 Reviewed-on: https://chromium-review.googlesource.com/1120227 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
-
Yi Gu authored
TBR=wez@chromium.org NOTRY=True Bug: 859151 Change-Id: I00ade2e948eab9a7b6d76457cea2659ff0ef0a9b Reviewed-on: https://chromium-review.googlesource.com/1120936Reviewed-by:
Yi Gu <yigu@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#571570}
-
Mathieu Perreault authored
Bug: 856604 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ie75cdf7ccb3743f09632a305fec0bca00a78e19b Reviewed-on: https://chromium-review.googlesource.com/1114687Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#571569}
-
Dominic Mazzoni authored
Originally landed: crrev.com/c/1117628 Reverted: crrev.com/c/1118945 The test output just needed to be rebaselined because another change that landed at around the same time eliminated some of the extra table nodes from the AX tree. TBR=aleventhal@chromium.org Bug: 856277 Change-Id: I6c22a0ff4af5322378207253fc260365f0efcbe4 Reviewed-on: https://chromium-review.googlesource.com/1120636Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#571568}
-
David Tseng authored
Bug: 854867 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I69de2def818e7e91f5cb7e4a3ff1051a517101c1 Reviewed-on: https://chromium-review.googlesource.com/1117459 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
-
Nico Weber authored
It's not clear why these suppressions exist. (It's not even clear if these bots should still exist since their configs are on the main waterfall too nowadays -- I'm asking around if I can remove them completely, but that's for a different CL.) Bug: 843511 Change-Id: I40bedd29065dba896455821ef58a3ffbe50435b4 Reviewed-on: https://chromium-review.googlesource.com/1120231Reviewed-by:
-
Elad Alon authored
1. Create MockNetworkConnectionTracker. 2. Refactor ChromeSigninClientTest to use it (instead of three separate locally-defined mocks). 3. As a drive-by, make ChromeSigninClientTest more explicit about what events it is waiting for to complete asynchronously. Bug: 775415 Change-Id: Ib860e986c00285ae0b66a8e9248656a35f4d64f2 Reviewed-on: https://chromium-review.googlesource.com/1119921 Commit-Queue: Elad Alon <eladalon@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Helen Li <xunjieli@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#571565}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/4e85e80a5a32..c91fe3ab1c5d git log 4e85e80a5a32..c91fe3ab1c5d --date=short --no-merges --format='%ad %ae %s' 2018-06-29 caryclark@google.com fix fuzzer found timeout Created with: gclient setdep -r src/third_party/skia@c91fe3ab1c5d The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:858985 TBR=jcgregorio@chromium.org Change-Id: Iceb8a9b3e8821e17ea0d8eaf8d118228aa3c4713 Reviewed-on: https://chromium-review.googlesource.com/1120409Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#571564}
-
Bret Sepulveda authored
When a new tab is added in the background, its title color is calcuated before single-tab mode is updated, which means it uses a frame color of white regardless of the actual frame color. This patch fixes that. This patch also changes Tab::ViewHierarchyChanged to AddedToWidget since it's more correct and helped me debug. Bug: 855338 Change-Id: I007c5f1577260e22265f5c3df877955f3953cfee Reviewed-on: https://chromium-review.googlesource.com/1119574Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#571563}
-
Greg Kraynov authored
Since scheduler/base is getting moved to //base/task/sequence_manager we don't want to explicitly support the concept of virtual time because it might be confused with the existing mechanism to override a TickClock in //base. So we can't move VirtualTimeDomain to //base. It was used in some tests in scheduler/base as a mock time domain, so this CL makes it explicit and test-only. Bug: 783309 Change-Id: I0a11e565de94fce06af4aff288427b6bc78e890b Reviewed-on: https://chromium-review.googlesource.com/1120257Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Greg Kraynov <kraynov@chromium.org> Cr-Commit-Position: refs/heads/master@{#571562}
-
Leonard Grey authored
This is temporary until we have bandwidth to do a correct dark mode implementation. Opting out fixes glitches caused by the system thinking that Chrome is in dark mode (for example, light text colors where we are expecting the system to provide dark text colors). Bug: 850103 Change-Id: I38d46631f714907231da89bd47bdd800ceb1bb3e Reviewed-on: https://chromium-review.googlesource.com/1120744Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#571561}
-
Helen Li authored
This makes RenderViewHostTestHarness own a NetworkChangeNotifier, so Network Service can skip creating one (see CreateNetworkChangeNotifierIfNeeded() in network_service.cc). The in-process NetworkService is a leaky global singleton, which also leaks a NetworkChangeNotifier that conflicts with subsequent unit tests. See: https://groups.google.com/a/chromium.org/d/msg/network-service-dev/IgNFrq1zFHI/FNCAplsCCQAJ An alternative approach is to tear down the in-process singleton NetworkService, but I ran into issues when doing that mostly because the BrowserThreadDelegate::CleanUp hook is only implemented by chrome/browser/io_thread.h and not by other content embedders. Change-Id: I1fbfca32e582621c3cfcbb7af3a82a4243c5b44b Reviewed-on: https://chromium-review.googlesource.com/1114924 Commit-Queue: Helen Li <xunjieli@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#571560}
-
Amy Qiu authored
Since the smoothness.__ benchmarks have been merged into rendering.desktop and rendering.mobile, remove the benchmarks and the no longer necessary page set json files. For now, add the deleted benchmarks to NON_TELEMETRY_BENCHMARKS in perf_data_generator.py to avoid errors related to the sharding map. For the fetch_benchmark_deps_unittest that used smoothness.top_25_smooth, change to use system_health.common_desktop because using rendering.desktop fails the "no static local files" assertion. Also, remove tough_ad_cases.py completely because it is no longer used. Bug: 855063 Change-Id: I9b3c0a46b7704b520f8d44479fcd5385c78eb573 Reviewed-on: https://chromium-review.googlesource.com/1120345Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Amy Qiu <amyqiu@google.com> Cr-Commit-Position: refs/heads/master@{#571559}
-
Bence Béky authored
Bug: 807724 Change-Id: Iff21f7cc6ba5c3005b440fb7b6d51fdccbbd230b Reviewed-on: https://chromium-review.googlesource.com/1117325Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#571558}
-
Lan Wei authored
When we coalesce the touch events or mouse events, we should check their pointer id and pointer type, so we do not coalesce events from stylus inputs with events from other input sources. Bug:857209 Change-Id: I157ca5047047bb812564382f49e316bee9f88f19 Reviewed-on: https://chromium-review.googlesource.com/1117633 Commit-Queue: Lan Wei <lanwei@chromium.org> Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Cr-Commit-Position: refs/heads/master@{#571557}
-
David Tseng authored
This puts ChromeVox in line with other popular mobile screen readers where these gestures are mapped to their physical equivalents and non-accessibility scrolling actions. Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Ice2da6bf013fbbb5c0213505b34fdb9189620dc0 Reviewed-on: https://chromium-review.googlesource.com/1116074Reviewed-by:
-
Tom Anderson authored
Most window managers clear the _NET_WM_STATE property when a window is unmapped, as specified by the EWMH spec [1]. This means if apps set always-on-top for a window which is hidden and then shown, the window will no longer be always-on-top. This CL restores the state set by Chrome when a window is re-mapped. [1] https://standards.freedesktop.org/wm-spec/wm-spec-1.3.html#idm140130317598336 BUG=856607 Change-Id: I1c72d9b20c0b68198c7f3d0f31ea28ce5e6f2da3 Reviewed-on: https://chromium-review.googlesource.com/1117439Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#571555}
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/43d0b98fe5ad..7a29426142dd git log 43d0b98fe5ad..7a29426142dd --date=short --no-merges --format='%ad %ae %s' 2018-06-29 phensman@webrtc.org Detach audio devices from thread on terminate. Created with: gclient setdep -r src/third_party/webrtc@7a29426142dd The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I65be0b275e1fde671302714ea0b8cba3593a3eb7 Reviewed-on: https://chromium-review.googlesource.com/1120407Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#571554}
-
Navid Zolghadr authored
Selection and dragging should be done regardless of whether js calls preventDefault on mousemove or pointermove events according to the spec: https://w3c.github.io/uievents/#event-type-mousemove This cl makes Chrome to handle selection/dragging regardless of return value of js handler to match other browsers. Bug: 346473 Change-Id: I71f2c808f224be23ffbc80ee25e2897a9dc9f090 Reviewed-on: https://chromium-review.googlesource.com/1112628Reviewed-by:
Lan Wei <lanwei@chromium.org> Reviewed-by:
Ella Ge <eirage@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Navid Zolghadr <nzolghadr@chromium.org> Cr-Commit-Position: refs/heads/master@{#571553}
-
danakj authored
Use the standard RenderWidgetCompositor instead of test overrides of the WebLayerTreeView interface. This gets us closer to removing the interface, and removes a bunch of test-only lines of code, using the standard FrameTestHelpers::TestWebViewClient instead, which provides a RenderWidgetCompositor. R=haraken@chromium.org Bug: 838693 Change-Id: Ifc5f219f6918a793a46ec229667f43fa72ec4b03 Reviewed-on: https://chromium-review.googlesource.com/1119247Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#571552}
-
depot-tools-chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/406de133efaf..a19649b86b3d git log 406de133efaf..a19649b86b3d --date=short --no-merges --format='%ad %ae %s' 2018-06-29 iannucci@chromium.org Clean up cache_dir handling in gclient/git_cache/bot_update. Created with: gclient setdep -r src/third_party/depot_tools@a19649b86b3d The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:823434 TBR=agable@chromium.org Change-Id: I3003d9a0a791da948c861cb0156cf924fb6864e9 Reviewed-on: https://chromium-review.googlesource.com/1120411Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#571551}
-
Yi Gu authored
TBR=carlosk@chromium.org NOTRY=true Bug: 857520 Change-Id: I5ac3dd6a38f7000c82d8e17545bf6d5463501560 Reviewed-on: https://chromium-review.googlesource.com/1120857Reviewed-by:
-
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/cdf50444934c..71a151fd11ae git log cdf50444934c..71a151fd11ae --date=short --no-merges --format='%ad %ae %s' 2018-06-29 jmadill@chromium.org Vulkan: Use TSymbolTable in ExtractStructSamplers. Created with: gclient setdep -r src/third_party/angle@71a151fd11ae The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ynovikov@chromium.org Change-Id: I5e4fabe50963357dddf6a288df5ba713c6b376fe Reviewed-on: https://chromium-review.googlesource.com/1120412Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#571549}
-
Koji Ishii authored
When r565930 (CL:999080) implemented background support for `::first-line`, it broke applying other properties to first line because anonymous inline box prevents to apply `::first-line` style to its descendants. This patch fixes computing first-line style for anonymous LayoutInline for that specific case. How to fix other anonymous LayoutInline (such as one for `display: content`) isn't clear yet, and even this fix may need to revisit. css2.1/t0510-c25-pseudo-elmnt-00-c.html turns IMAGE+TEXT failure to TEXT failure due to the additonal anonymous inline box. This patch includes text dump rebaselines. Other 3 rebaselines are the height of LayoutBR, which we generally rebaseline. Bug: 636993 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I5e08c6b783fb82b5e0bdc97bd1d782ccb569a38c Reviewed-on: https://chromium-review.googlesource.com/1118405Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#571548}
-
Li Lin authored
Bug: b:77876001 Change-Id: Iac4efcebda4573cb66af4f47a21c373a9a86ec92 Reviewed-on: https://chromium-review.googlesource.com/1112903 Commit-Queue: Li Lin <llin@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#571547}
-
Wenzhao Zang authored
This issue is not very easy to fix since: - The png decoder is not reliable according to [1] - The default codec is considered "unsafe", confirmed by multiple sources (e.g. [2], [3]) So I think we should continue to use the jpeg decoder on login screen (it's always working because we re-encode all the wallpaper images in jpeg [4]) and make an "exception" to use the default codec only when it's safe. This will solve the issue because online wallpapers used to be decoded by the code point at [3] before the refactoring, which uses default codec. [1] https://cs.chromium.org/chromium/src/ui/gfx/codec/png_codec.h?dr=Ss&g=0&l=24 [2] https://cs.chromium.org/chromium/src/chrome/browser/chromeos/login/users/avatar/user_image_manager_impl.cc?type=cs&q=DEFAULT_CODEC&sq=package:chromium&g=0&l=386 [3] https://cs.chromium.org/chromium/src/chrome/browser/chromeos/extensions/wallpaper_function_base.cc?q=wallpaper_function_base&sq=package:chromium&dr=C&l=81 [4] https://cs.chromium.org/chromium/src/ash/wallpaper/wallpaper_controller.cc?type=cs&g=0&l=207 Bug: 857240 Change-Id: I1bb0f1351a72acec233539e08c43221c8952d032 Reviewed-on: https://chromium-review.googlesource.com/1117764Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#571546}
-
Stefan Zager authored
Get rid of Mac-specific code that uses LocalFrameView as a ScrollableArea. BUG=823365 R=skobes@chromium.org,pdr@chromium.org Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ic7f7ffe99d2d3fdd6e12dd950d78e4f26eecdf9b Reviewed-on: https://chromium-review.googlesource.com/1119664Reviewed-by:
Steve Kobes <skobes@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#571545}
-
Tommy C. Li authored
Many devs have complained that the text moves unexpectedly when the popup opens. After consulting with UX, we are embracing the text jogging to make it line up with the suggestions text. This CL adds an animation to slide the text over, making the text jog hopefully less jarring. Bug: 853355 Change-Id: If272e4076e30c967c0211c988e5e9f10300366bf Reviewed-on: https://chromium-review.googlesource.com/1119400 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#571544}
-
Fredrik Söderquist authored
Check Document::hidden() in LayoutObject::WillRenderImage, thus pausing animations on pages that are not visible. To resume animations, we may need to explicitly resume the timeline, so a hook is added in Page::SetVisibilityState to allow calling StartAnimation() on the relevant SVGImages. Bug: 856082 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I4a0b008730ec3e6c2af26e15d52eebb26020ad32 Reviewed-on: https://chromium-review.googlesource.com/1115130Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#571543}
-
Peter K. Lee authored
FeedbackKit V2 launched in M67. In order to deprecate the V1 implementation, the first step needs to force the chrome://flags to true and then implementation code can be removed. Bug: 847329 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I9451fa04453584d6e056e82f8c9f323d0a87c06c Reviewed-on: https://chromium-review.googlesource.com/1119355Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Peter Lee <pkl@chromium.org> Cr-Commit-Position: refs/heads/master@{#571542}
-
Klaus Weidner authored
Managing the Surface/SurfaceTexture pair is somewhat expensive, and we don't need it for SharedBuffer transport. Now that the mailbox_to_surface_bridge supports surfaceless initialization (thanks to AR mode), use that to avoid this allocation. This required some minor reshuffling to ensure we have the right initialization order. BUG=857547 Change-Id: I7edca6e791f9b13bef4a3a50266715182517fdef Reviewed-on: https://chromium-review.googlesource.com/1120677Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#571541}
-
