- 23 Sep, 2020 40 commits
-
-
Raphael Kubo da Costa authored
The features are still under development. The flag is used for testing. Change-Id: I974916c349775f0cb95938423d15e728c3121591 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421729 Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#809661}
-
Pranav Batra authored
Bug: chromium:832152 Test: ./libcups_unittests Change-Id: I556ff53fdb997d9b22d94efd035704242a36b0bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359570 Commit-Queue: Pranav Batra <batrapranav@chromium.org> Reviewed-by:
Luum Habtemariam <luum@chromium.org> Cr-Commit-Position: refs/heads/master@{#809660}
-
Ken Rockot authored
Self-referencing structs and unions should not cause the backcompat checker to fail. This fixes it. Bug: None Change-Id: Ia852c0aa68c63ff7f8c613b830f7a259489fe41b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425304Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#809659}
-
Jeevan Shikaram authored
Add the Stadia app ID and preload it after Duo on the first page. Bug: 1125414 Change-Id: I156319452ff8d8d855020041dedeac5b14935de6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2397042Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
dstockwell <dstockwell@google.com> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: Jeevan Shikaram <jshikaram@chromium.org> Cr-Commit-Position: refs/heads/master@{#809658}
-
Ionel Popescu authored
This CL fixes the following eye dropper UI issues: - center square for the eye dropper border should be black & white double strokes - macOS pre-10.15 eye dropper size should be a 9x9 square. Bug: 1130418, 1130415 Change-Id: I8ae3c22b01aef0ebd4bbf94a9e31d0192d3f58a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424668Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Ionel Popescu <iopopesc@microsoft.com> Cr-Commit-Position: refs/heads/master@{#809657}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1600797595-fd8ddba8caaa456739bdf5b1d17d7be117d929dc.profdata to chrome-linux-master-1600819087-f018447afe1bff252e1e84ad0f3e21a12934b752.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com,chrome-brapp-engprod@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com,chrome-brapp-engprod@google.com Change-Id: I1871ac8f4995275867c90104db026fda73ccd088 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425286Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#809656}
-
James Cook authored
Clarify that the value of MinVersion isn't related to particular ordinal values. Bug: none Change-Id: Ie3dcca5e494e51e0adbbf0bc0bbea24d7054515b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425326Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#809655}
-
Megan Jablonski authored
Align Translate histogram expiration to 2021-01-31, re-enable Translate.LocalesOnDisabledByPrefs, and expire obsolete histogram. Bug: 1089599, 1089597 Change-Id: I0bf51f94a8d0f98fae4ec95a0d11fb89b738ebbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419577 Commit-Queue: Megan Jablonski <megjablon@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#809654}
-
James Hawkins authored
R=khorimoto@chromium.org Bug: 1045266 Test: OSSettingsCellularSetupDialog* Change-Id: I8da974e120b534be54f454580c23f55f2632d395 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422319 Commit-Queue: James Hawkins <jhawkins@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#809653}
-
Brian Sheedy authored
Changes the GPU pixel tests to only upload data to the Chrome Gold instance now that all the data has been migrated. Bug: 1113308, skia:10723 Change-Id: I99271ec1ddc41989eb854e6ce0117fa18b723d33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424497 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#809652}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/7b2a8dea..d2ea1c89 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I3e557eb485e5d1d45f32f2797e9aae5f6e35f027 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425086Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#809651}
-
Haiyang Pan authored
Bug: 997376, 1127110, 1131181 Change-Id: Idccf2d3a97f3f82a36125dc563bfb26a4f528e4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425183Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Haiyang Pan <hypan@google.com> Cr-Commit-Position: refs/heads/master@{#809650}
-
Adam Rice authored
Add a content browser test for receiving a bidirectional stream that was initiated by the server. BUG=1123772 Change-Id: I2f6f9c464215a949d06ad6a251f352508055f7e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416048Reviewed-by:
Victor Vasiliev <vasilvv@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#809649}
-
Joel Hockey authored
In order to send a URL as a param, we must be allow plain string args which will be passed through unchanged as well as files which will be shared and remapped. Bug: b/168506505 Change-Id: Ica2ca4c7b79047d1811961c19e79f9db0d3cfcda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423744 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Jason Lin <lxj@google.com> Cr-Commit-Position: refs/heads/master@{#809648}
-
Maggie Cai authored
This CL adds a few more browser tests for intent picker: 1. Navigate out of the intent filter scope will not show the intent picker icon or the intent picker bubble. 2. Intent picker bubble will not automatically pop up if there is only PWA candidates in the bubble. 3. Intent picker bubble will not automatically pop up if the navigation is not from a link. 4. Intent picker bubble will stop showing up after dismiss the bubble for 2 times for the same origin. BUG=853604 Change-Id: If1081911e42ad134d75fde51f9bab24740499424 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423825Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Maggie Cai <mxcai@chromium.org> Cr-Commit-Position: refs/heads/master@{#809647}
-
Mitsuru Oshima authored
Bug: 1060690 Change-Id: Ic13dd8260154b6982b2913a9cb3551699c23da26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419925Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#809646}
-
Reilly Grant authored
This change updates the icon used for the "idle-detection" permission to the Material Design "person" icon. Screenshot: https://photos.app.goo.gl/JwVUKqXkBsssYrTE8 Bug: 878979 Change-Id: Id790417d92e04cd7e517736c3eac66747b315c51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421634Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
-
Daniel Rubery authored
This CL extends a number of metrics related to download deep scanning. These are useful for monitoring both the upcoming launch of download deep scanning for Advanced Protection users and the performance as the user count for enterprise download scanning increases. We'd like to get enough usage on these histograms to understand the performance of each subcomponent before expiring these fine-grained histograms. M90 was chosen because several other metrics for this feature were already extended to M90, so it makes sense to evaluate all the metrics then. Fixed: 1089452, 1089443, 1089442, 1089383 Change-Id: I661328fa887797c20c1e5de722d64c3640ee92fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421898Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#809644}
-
Xiqi Ruan authored
Records the Chrome OS user session duration to UMA at the beginning of the first session on the next day. It helps us understand users' usage on Chrome OS and improve family users' experience. Metrics from abnormally terminated sessions will be skipped. Bug: 1103081 Change-Id: Ibb33059adf2e5421846ae222876a06f6902b4f52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327847 Commit-Queue: Xiqi Ruan <xiqiruan@chromium.org> Reviewed-by:
Toby Huang <tobyhuang@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#809643}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/407b5a54a9b5..d1580d53b7bc 2020-09-22 jeffyoon@google.com Add xcode version for Mac OS 10.15.4 in osx_sdk If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1128042,chromium:1128044 Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: I527483769d286ba97da70395474eb792eb569853 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424740Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/a5f3c3149033..3eb813e0cc13 2020-09-22 adlai@google.com Migrate metal tools away from GrContext 2020-09-22 csmartdalton@google.com Extract SkFindCubicMidTangent from SkChopCubicAtMidTangent 2020-09-22 brianosman@google.com SkSL: Start refactoring pre-include handling 2020-09-22 johnstiles@google.com Add `rc` accessor method to SkMatrix. 2020-09-22 johnstiles@google.com Promote bool(k) to true/false during constant propagation. 2020-09-22 adlai@google.com Revert "Take GrContext private, GrDDLContext inherit from GrRecordingContext" 2020-09-22 johnstiles@google.com Fix ClangTidy bugprone-bool-pointer-implicit-conversion warning. 2020-09-22 johnstiles@google.com Fix nondeterminism when copying intrinsic functions. 2020-09-22 adlai@google.com Take GrContext private, GrDDLContext inherit from GrRecordingContext 2020-09-22 robertphillips@google.com Yet more GrThreadSafeUniquelyKeyedProxyViewCache purging tests If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC csmartdalton@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: chromium:1108408 Tbr: csmartdalton@google.com Change-Id: If5accf0cddf2c61c34a3746d04ccdc6aaa26b3f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425265Reviewed-by:
-
Alexandre Courbot authored
CL crrev.com/c/2373181 renamed the gbm ozone platform to drm, but our Tast video tests for Chrome OS still refer to the old name when selecting the Ozone platform at runtime. Temporarily map "gbm" to "drm" to avoid tests breakage until we switch to the new name. BUG=b:169115289 BUG=1116466 TEST=video.EncodeAccel.h264_360p_i420 passes on Kukui. Change-Id: Idd8775b30ec07fa5af0c19d4e1a624846b9fe2fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423443 Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Auto-Submit: Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Reviewed-by:
Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#809640}
-
My Nguyen authored
Proposed new name found in http://go/cros-input-methods Rationale: http://go/cros-input-methods-naming Current view for US International: http://screen/3sankWPvq6xQW2R New view for US International: http://screen/BrfNpMZn7GYzS5h Current view for Belgium: http://screen/B9USEaX8iX2JuTp New view for Belgium: http://screen/4A4hVAMrK62JP2z Remove adding language before input name logic as there are no longer duplicate names for IME tray. It's fine not to update string for OOBE for now because it's clear what language the keyboard is referring to. OOBE view: http://go/cros-oobe-2019#slide=24 Bug: 1113439, 889763 Change-Id: Ia7dadd44874937872c1f10fa51ca81e344378ed6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423068Reviewed-by:
Shu Chen <shuchen@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: My Nguyen <myy@chromium.org> Cr-Commit-Position: refs/heads/master@{#809639}
-
Raphael Kubo da Costa authored
The Mac bots are occasionally timing out. Clean up the iframe tests a bit more hoping it helps: * Remove redundant call to 'reset_sensor_backend' that is already performed by the test's cleanup function. * Move the message handler to a separate function, so that we can then call it from a catch-all try/catch statement and ensure we will always send a reply. This also allows us to remove several try/catch blocks from the handler itself. Bug: 1073865 Change-Id: I9756c85ee401a78dabe5f283250ab68110decabb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424248 Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by:
-
Melissa Zhang authored
Bug: 1130409 Change-Id: Iaa4c0c624dd238d1fe26c42f6dfe606fe5c20fdd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421987Reviewed-by:
-
Matt Falkenhagen authored
Change-Id: I30dd3f55cc8832512f52062d9b5bff085887f392 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415918Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#809636}
-
Ryan Keane authored
This CL adds a new MediaPipelineBackend to allow audio data to be proxied across an IPC through the MultizoneAudioDecoderProxy. Video data decoding will not be changed, and should be passed through to the environment-specific CmaBackend. This change is accomplished through the use of an environment variable orthogonal to that used for platform type. After this change, all audio data processed by the AudioPipelineImpl should be diverted across the IPC, as described in go/cast-media-chromium-runtime Bug: b/167425332 Change-Id: Iaefd150bac0b6edf9708c79d4c6d50f2a5eb27ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412558Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Commit-Queue: Ryan Keane <rwkeane@google.com> Cr-Commit-Position: refs/heads/master@{#809635}
-
Fabrice de Gans-Riberi authored
https://chromium.googlesource.com/chromium/deps/icu.git/+log/79326efe..83b2ac66 83b2ac66 [fuchsia] Bring more changes from the Fuchsia copy 368b1cb1 Upstream Fuchsia changes in build file fb520a53 Add CPEPrefix. Bug: 1124037, fuchsia:56362 Change-Id: Ia77c08b48668de4315b44d3b72a3a3e23d722494 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412548 Auto-Submit: Fabrice de Gans-Riberi <fdegans@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#809634}
-
Raphael Kubo da Costa authored
This does not directly fix the timeouts on the ARM64 Mac bots reported in the bug below, but it simplifies the test and hopefully eliminates some of the sources of flakiness. Bug: 1128439 Change-Id: I4b1840a8db6e8d2541003b5b1ecb860f4bc04c57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418378 Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by:
-
Melissa Zhang authored
Target counter currently has an off by 1 error. Bug: 1131108 Change-Id: Ib180c0fd4c165be6708adc9b008fcee209b41595 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423752Reviewed-by:
-
My Nguyen authored
Experiment with new maps. Related CL: http://cl/332964764 Bug: b/166523259 Change-Id: I9ba8f3d637fb8b68cb3e776d3f5156156d4b53ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423063Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: My Nguyen <myy@chromium.org> Cr-Commit-Position: refs/heads/master@{#809631}
-
Bo Majewski authored
Moves all main files to main.* Creates a separate directory for images and moves the icon there Renames resources ID to match file names. Bug: 1111229 Change-Id: Idbf49a3fb273bf7a4a64cb1431087db1199a9ed3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409657 Commit-Queue: Bo Majewski <majewski@chromium.org> Reviewed-by:
Alex Danilo <adanilo@chromium.org> Cr-Commit-Position: refs/heads/master@{#809630}
-
James Darpinian authored
https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/c1d5cef..71413e9 Cq-Include-Trybots: luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64 Change-Id: I9ad35d0700b17584cad73f851c603c591636b7e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422320 Commit-Queue: James Darpinian <jdarpinian@chromium.org> Commit-Queue: Kai Ninomiya <kainino@chromium.org> Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Reviewed-by:
Shrek Shao <shrekshao@google.com> Auto-Submit: James Darpinian <jdarpinian@chromium.org> Cr-Commit-Position: refs/heads/master@{#809629}
-
Asanka Herath authored
Bug: 973801 Change-Id: I4567b856ab55097edddf8939cb5c1c3cff6f5768 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422618 Commit-Queue: Asanka Herath <asanka@chromium.org> Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Cr-Commit-Position: refs/heads/master@{#809628}
-
Darwin Huang authored
TBR=takumif@chromium.org Bug: 1124982 Change-Id: I5464b1abdf11c13fea7d0819abc809d2a6abf184 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424521Reviewed-by:
Darwin Huang <huangdarwin@chromium.org> Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#809627}
-
Trevor Perrier authored
Bug: 1127531 Change-Id: I42538f522e6ce49483d6070566bc9f06c15c77d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422711 Commit-Queue: Trevor Perrier <perrier@chromium.org> Reviewed-by:
Megan Jablonski <megjablon@chromium.org> Cr-Commit-Position: refs/heads/master@{#809626}
-
David Black authored
Holding space needs to support selection of multiple holding space items to perform bulk context menu and drag/drop operations on them at a time. This CL refactors HoldingSpaceItemContextMenu into a shared HoldingSpaceItemViewDelegate to facilitate these requirements. Note that this CL does not change any existing behavior, just lays the groundwork for supporting multiple selection. Bug: 1129981 Change-Id: If4da6c19ba01bd7104a1b1487350c362d7be1dd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419136 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Ahmed Mehfooz <amehfooz@chromium.org> Cr-Commit-Position: refs/heads/master@{#809625}
-
Becca Hughes authored
Adds Shaka Player to //third_party to be used by Chrome Kaleidoscope. Eng-Review: https://groups.google.com/a/google.com/g/chrome-eng-review/c/TWyhpLrpc-8 BUG=1117052 Change-Id: I5e682287951962c06fb32060100e26d7d5097551 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359572Reviewed-by:
Darin Fisher <darin@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Alex Gough <ajgo@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#809624}
-
James Vecore authored
This CL adds a pref to track if onboarding was run by this user before. If it has not, when enabling for the first time, onboarding is run first by navigating to the subpage and showing in a dialog. Once onboarding has been done once, the user can freely toggle on/off without triggering onboarding. However, onboarding will still run if the user triggers the pod button and the feature is disabled. This matches the Android behavior. Additionally, this CL fixes a bug with the premature closing of the shared receiveManager which needs to stay alive and connected after the dialog closes otherwise getReceiveManager returns a remote with a closed pipe. Bug: b/154866951 Change-Id: I1e3cbd15f4995f019b3476c2f7a69f67d6eb1888 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424763Reviewed-by:
-
Robbie McElrath authored
This CL prevents the top view from being force shown unless the renderer crashes or us unresponsive. Bug: 1127076 Change-Id: I0092a473726376c11181863d3041aa60de15eb1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419384 Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Reviewed-by:
-
