- 11 Feb, 2020 40 commits
-
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/582021e12e80..d31fdd914bc4 Created with: gclient setdep -r src-internal@d31fdd914bc4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I50bc9cd0fbd2f97fd949026810dd9a31b3f60fb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050546Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#740282}
-
Adrienne Walker authored
This is part of moving IndexedDB to live in the storage service. This API used by BrowserContext needs to communicate over the IndexedDBControl interface instead of directly via IndexedDBContext. Bug: 1015214 Change-Id: I86ce83390f297c8780bfab9c38f393de2c58a888 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2047964Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Auto-Submit: enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#740281}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/c05ee8a3ffb4..74cb8b70d83f git log c05ee8a3ffb4..74cb8b70d83f --date=short --first-parent --format='%ad %ae %s' 2020-02-11 aerotwist@chromium.org Fixes UIString closure annotation Created with: gclient setdep -r src/third_party/devtools-frontend/src@74cb8b70d83f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ie90d92227db497c32a4311831df0d0220a951ca1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050545Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#740280}
-
sandromaggi authored
This change fully deprecates the |SUGGESTION| type chips that were rendered in a separate row. Bug: b/149080863 Change-Id: I5e232c710aac8aa251bf6a573977f557bc0e3f7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033259 Commit-Queue: Sandro Maggi <sandromaggi@google.com> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#740279}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 6c573ee6. With Chromium commits locally applied on WPT: 5579aad0 "SharedWorker: Name shared workers identically in credentials mode WPT" 822dbfeb "[LayoutNG] Clip when hit-testing floats inside clipped containers." ca0673ac "Fix line-breaking-replaced-006" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: yhirano@chromium.org, mkwst@chromium.org, japhet@chromium.org: external/wpt/fetch NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I3fc1c1c9cfed2605f6aaad7377cbd7bb3f4e3c04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050126Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#740278}
-
Dominik Röttsches authored
Addresses unbounded memory growth of font_data_table_ in CSSSegmentedFontFace leading to out of memory situations when animating variable fonts. Manually tested observing Chrome's task manager memory consumption on Linux for a tab running a variable font animation test page. Tab memory stays around 75MB over a period of 2 minutes vs. growing to around 1.3GB before. Bug: 778352 Change-Id: I53b1f5805974d667aec35d6a9358205f5346b63c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032112 Commit-Queue: Dominik Röttsches <drott@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#740277}
-
Denis Kuznetsov authored
Change-Id: I15fe2194703605918de6a3253d978e7e14ccae31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2046172 Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org> Auto-Submit: Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#740276}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/88c3793a4eaa..dc2782c380f6 git log 88c3793a4eaa..dc2782c380f6 --date=short --first-parent --format='%ad %ae %s' 2020-02-11 reed@google.com Update OverdrawColorFilter to clarify how it interprets its input array. 2020-02-11 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 a8e6a463121b..b40d48a67c93 (10 commits) 2020-02-11 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader b3b2a4fc756f..196d81774ef8 (1 commits) 2020-02-11 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 437a856b..32b4892f (392 commits) Created with: gclient setdep -r src/third_party/skia@dc2782c380f6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC stani@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: stani@google.com Change-Id: Ic700a604e198f5f8614b005df0e7f2fe155fd9d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050543Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/c7b6ede78ab7..081d18cb9c92 git log c7b6ede78ab7..081d18cb9c92 --date=short --first-parent --format='%ad %ae %s' 2020-02-11 taylori@google.com Merge "perfetto-ui: Fix gridlines" Created with: gclient setdep -r src/third_party/perfetto@081d18cb9c92 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I4572597924be5cfc1a591b976ef5094ad371e270 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050544Reviewed-by:
-
Maksim Moskvitin authored
GetOwnerName() must return unique value for each handler within the same invalidation service. This is currently not the case for CloudPolicyInvalidator. This change documents this contract to avoid further API misuse and updates TODO for codepath depending on this contract. Bug: 1020117, 1049591 Change-Id: I7fbda6569bf6837c274be753fee5a472bbe2fff4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2049973Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Cr-Commit-Position: refs/heads/master@{#740273}
-
Santiago Aboy Solanes authored
Bug: v8:10149 Change-Id: I3abaf70fef14307cc40adbc3759b6ec9c84c31d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050484 Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Auto-Submit: Santiago Aboy Solanes <solanes@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#740272}
-
Maksim Moskvitin authored
There is no need to listen invalidations for commit-only types, so this change filters them out at the moment of registration. Bug: 1007932 Change-Id: Iedda8432a875d592024f7c417b3a3ff87b436eee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2047066 Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Reviewed-by:
-
Maxim Kolosovskiy authored
This reverts commit 5381b40a. Reason for revert: this CL probably caused GmockCallbackSupportTest.RunOnceClosureValueMultipleCall failures. The first failed build https://ci.chromium.org/p/chrome/builders/ci/chromeos-eve-chrome/3283 Test 'GmockCallbackSupportTest.RunOnceClosureValueMultipleCall' completed with the following status(es): 'FAILURE','FAILURE' Test 'GmockCallbackSupportTest.RunOnceClosureValueMultipleCall' had the following logs when run: ================================================================================ [ RUN ] GmockCallbackSupportTest.RunOnceClosureValueMultipleCall ../../base/test/gmock_callback_support_unittest.cc:174: Failure Death test: check.Call() Result: died but not with expected error. Expected: contains regular expression "copyable_cb->data" Actual msg: [ DEATH ] Stack trace: #0 0x57c25d527cd4 base::test::GmockCallbackSupportTest_RunOnceClosureValueMultipleCall_Test::TestBody() [ FAILED ] GmockCallbackSupportTest.RunOnceClosureValueMultipleCall (26 ms) [ RUN ] GmockCallbackSupportTest.RunOnceClosureValueMultipleCall ../../base/test/gmock_callback_support_unittest.cc:174: Failure Death test: check.Call() Result: died but not with expected error. Expected: contains regular expression "copyable_cb->data" Actual msg: [ DEATH ] Stack trace: #0 0x58a33c3f9cd4 base::test::GmockCallbackSupportTest_RunOnceClosureValueMultipleCall_Test::TestBody() [ FAILED ] GmockCallbackSupportTest.RunOnceClosureValueMultipleCall (29 ms) Original change's description: > Fix flaky SingleSampleMetricsFactoryImpl DCHECK_DEATH test. > > Test was missing the FLAGS_gtest_death_test_style = "threadsafe" > declaration that's necessary for multi-threaded death tests. See > https://github.com/google/googletest/blob/master/googletest/docs/advanced.md#death-tests-and-threads > > R=isherman > > Fixed: 1009360 > Change-Id: I795e055c9fdfda727853ce52c1278dd430cbfdef > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2049023 > Commit-Queue: Dale Curtis <dalecurtis@chromium.org> > Commit-Queue: Ilya Sherman <isherman@chromium.org> > Auto-Submit: Dale Curtis <dalecurtis@chromium.org> > Reviewed-by: Ilya Sherman <isherman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#740119} TBR=dalecurtis@chromium.org,isherman@chromium.org Change-Id: I06415066abd98925dc7dcaac961e666ca68d6864 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050365Reviewed-by:
Maxim Kolosovskiy <kolos@chromium.org> Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> Cr-Commit-Position: refs/heads/master@{#740270}
-
Oleg Davydov authored
This is a reland of bf17bc25 Original change's description: > [Extensions] Enable content verification for new policy non-webstore installs > > After this commit: > * For non-webstore policy force-installed extensions, write > computed_hashes.json on installation. > * If (according to computed_hashes.json) extension's resource is > detected corrupted, this extension will be disabled and reinstalled. > This applies only for policy force-installed extensions, and for > webstore extensions it worked before this commit. > > This commit will NOT change behavior for already-installed extension. > So, if some (non-webstore) extension was already corrupted, it will not > be detected. The reason for this is that there is no source of truth for > resources of already-installed non-webstore extension. It's possible to > reinstall all previously-installed non-webstore extensions, but it's out > of scope of this commit. See the bug for more details. > > Bug: 958794 > Change-Id: Ie9c014e7fd998f4eae6e852a59bd692d57ff7d8c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2012964 > Commit-Queue: Oleg Davydov <burunduk@chromium.org> > Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org> > Reviewed-by: Sergey Poromov <poromov@chromium.org> > Cr-Commit-Position: refs/heads/master@{#737034} Bug: 958794 Change-Id: I90d2c398712b1c716f5299a199c72e12e42b0c8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033160Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Commit-Queue: Oleg Davydov <burunduk@chromium.org> Cr-Commit-Position: refs/heads/master@{#740269}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/fec8f201c2c6..582021e12e80 Created with: gclient setdep -r src-internal@582021e12e80 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I4c62f4076a583aa9a1bd79300fa59779d9006774 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050087Reviewed-by:
-
Jack Franklin authored
This test is exercising code from Devtools that is not used and is being removed in another CL [1]. Given that this code isn't used it was decided that we're good to remove this test as it's not providing any benefit given it tests code that never gets called. [1]: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2050223/ Change-Id: If4728429468c37ff9c58dbedf6508fb2e3133bfb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2049964Reviewed-by:
Paul Lewis <aerotwist@chromium.org> Commit-Queue: Jack Franklin <jacktfranklin@chromium.org> Cr-Commit-Position: refs/heads/master@{#740267}
-
Yang Guo authored
Change-Id: I402e71b8a54a78437dc0f339ed4b9636e2d77430 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2044081Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#740266}
-
Kevin Marshall authored
Fixes an issue where web_engine_integration_tests was attempting to deploy WebEngine by the wrong filename, with the release channel as part of the .far filename. Change-Id: I68c7a8c0bb897627d6f94d9825f83a81ee8a0c1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042128 Auto-Submit: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#740265}
-
Jan Scheffler authored
Tbr: yangguo@chromium.org Bug: chromium:1050756 Change-Id: Ieb0d3b0110e02373053900922e54112d05321dc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2049968 Auto-Submit: Jan Scheffler <janscheffler@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#740264}
-
Victor Costan authored
1) Remove inline definition of virtual function. 2) Remove CONTENT_EXPORT from virtual overrides. They should always be accessed via vtables. 3) Add const to a class member that supports it. 4) Use scoped_refptr instead of raw pointer argument on method that ends up holding a reference to the argument. Bug: 1016065 Change-Id: I24fb866a98f278e915e62378eca49f35231846d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2045656 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
-
Bret Sepulveda authored
This patch adds some additional logging for two scenarios: * When TestBrowserDialog::VerifyUi reports that >1 Widget was added, we will log the titles of all the Widgets that were added. * Added some DCHECKs that will hopefully produce a stack trace if ExtensionsMenuItemView fails to be constructed or is destructed before TestBrowserDialog::VerifyUi runs. I intend to revert this patch after the associated bug is fixed. Bug: 1050012 Change-Id: If9f86ee91ff748b1a73b979d4961cd3d04496798 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2043800 Commit-Queue: Bret Sepulveda <bsep@chromium.org> Auto-Submit: Bret Sepulveda <bsep@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#740262}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/26a68eeffcd0..c05ee8a3ffb4 git log 26a68eeffcd0..c05ee8a3ffb4 --date=short --first-parent --format='%ad %ae %s' 2020-02-11 jacktfranklin@chromium.org [Unittest] Add unit tests to UIString Created with: gclient setdep -r src/third_party/devtools-frontend/src@c05ee8a3ffb4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1009443 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ibe0ffc170e79e15cd12479e947d47f69c75d8a39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050088Reviewed-by:
-
Christian Biesinger authored
This is no longer supported in the spec. Some cleanup is possible now (such as removing IntrinsicLength()), but I will do that in a future CL. Bug: 991096 Change-Id: I59cc600f4b8f2e49334756615cf2df5fe9f40378 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042129 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Auto-Submit: Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#740260}
-
Demetrios Papadopoulos authored
The previous SettingsBasicPageBrowserTest were loading the entire Settings page, and attempted to test various subtle scrolling logic which ended up being flaky, and disabled for 3 years. Re-instating a subset of these tests, so that there is some coverage for settings-basic-page, as opposed to none. The problematic tests have been deleted. Also the new tests only load basic_page.html similar to other Settings' unit tests. Bug: 738146 Change-Id: I7b90fb95ed62bec3854543446f03963a834cea4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2045225 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#740259}
-
Zain Afzal authored
This is a reland of 26f2d0fd It attempts to fix the compile failures by adding the dep from https://chromium-review.googlesource.com/c/chromium/src/+/2048918 . Original change's description: > Added a mojo generated Pagehandler for chrome://media-app. > > This CL defines a mojom file for the mojo interface > between the Browser and the chrome://media-app page and > implements the relevant CPP (Page Handler) and JS > (mojo_api_bootstrap.js) interfaces. This interface is leveraged to > expose the native browser open feedback dialog functionality > to the page via a MediaAppUIDelegate. > > This Cl also adds the kFeedbackSourceMediaApp constant to > the chrome::FeedbackSource enum to allow feedback dialogs > opened by the media app to be correctly logged. > > Bug: 996088,1045222 > Change-Id: Ia6f28c2330cfb592f9440778b94ebf45da89dbc2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015874 > Commit-Queue: Zain Afzal <zafzal@google.com> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org> > Reviewed-by: Sam McNally <sammc@chromium.org> > Reviewed-by: Trent Apted <tapted@chromium.org> > Cr-Commit-Position: refs/heads/master@{#740168} Bug: 996088, 1045222 Change-Id: I238de16b39d1381a5c384ea5cf537acb073c41b6 Tbr: zafzal, xiyuan, tapted, sammc, ortuno No-Presubmit: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050443 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
-
Rob Buis authored
This exposes the MathConstants subtable using HarfBuzz's API for the OpenType MATH table. See: https://mathml-refresh.github.io/mathml-core/#layout-constants-mathconstants Bug: 6606 Change-Id: I9a60d13a5a3314a320151b5352c83c5308c95e33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041485 Commit-Queue: Rob Buis <rbuis@igalia.com> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Reviewed-by:
Frédéric Wang <fwang@igalia.com> Cr-Commit-Position: refs/heads/master@{#740257}
-
Gauthier Ambard authored
This CL updates the new error page workflow, making sure that real error page HTML is used when the error is done on provisional navigation. For that, it is making sure that the context of the failed navigation is passed to the navigation to the error page file. It is also injecting the HTML of the error page into the loaded file when the navigation finishes. Bug: 991608 Change-Id: I382d9172bc4cdbd624d8629e6099c366f67d68a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024895 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Ali Juma <ajuma@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#740256}
-
anina koehler authored
This is a reland of 139c1efd Original change's description: > Run policy-presubmit when presubmit is changed > > When policy templates are changed, syntax_check_policy_template_json.py is run as part of the presubmit checks. It should also be run when changes to the file itself were made. > > Bug: 1045930 > Change-Id: Ic8870bd748d80d87b99b93889640cf2ebbbf0b27 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022794 > Reviewed-by: Alexander Hendrich <hendrich@chromium.org> > Commit-Queue: Anina Koehler <aninak@google.com> > Cr-Commit-Position: refs/heads/master@{#737240} Bug: 1045930 Change-Id: Ie55596dac9c5104e49af1781246c2b3fce538283 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2043886Reviewed-by:
Alexander Hendrich <hendrich@chromium.org> Commit-Queue: Anina Koehler <aninak@google.com> Cr-Commit-Position: refs/heads/master@{#740255}
-
Mugdha Lakhani authored
First pass attempt at showing the Desktop PWA CCT toolbar on ChromeOS when ARC apps need to show a CCT toolbar. Design Doc: https://docs.google.com/document/d/166h__sHZGVD7eTBKkBMF7beLGOmT6mwTVe8dtsTCU7A/edit?usp=sharing Screenshot before changes: https://drive.google.com/open?id=0B486O0P6jAtRcHZQZXJpSmF5RFBaQ2x1TnRtS1FFbkQyNkpR Screenshot after changes: https://drive.google.com/open?id=0B486O0P6jAtRZ0ptUEJXemUwczNjTjlGejFPZ1ZaZS02RXFr ARC CL here: https://googleplex-android-review.git.corp.google.com/c/platform/vendor/google_arc/+/9574364 Bug: b/64863368 Change-Id: Icff957b40c69e93082e7f4b8bdd8688fcd34d351 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866227 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#740254}
-
Huanzhong Huang authored
Bug: 1045348 Change-Id: I5c5950cb53e424d756d1de98fea122d6d75815e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2046131 Commit-Queue: Huanzhong Huang <huanzhong@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#740253}
-
Mikel Astiz authored
When the retrieval intent completes, TrustedVaultClient needs to be notified about possible changes, for it to once again pull the latest keys from the backend. Because waiting for a PendingIntent required overriding onActivityResult() in Activity/Fragment, the method is moved away from TrustedVaultClient into SyncSettingsUtils. Change-Id: I8f516966977e513ed7c6569c401ab93f8dd46a80 Bug: 1012659 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015164 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#740252}
-
Nikita Podguzov authored
This change includes special handlers for ArcPolicy, NativePrintersBulkConfiguration, DeviceNativePrinters, ExternalPrintServers policies and "Dictionary" data type policies for extensions. Now it's allowed to use commas after last objects in JSON lists and dictionaries. Bug: 843988 Change-Id: I3ced2d1cfb3e009287b95ee07ccc47595ae29edf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041618Reviewed-by:
Sean Kau <skau@chromium.org> Reviewed-by:
Bartosz Fabianowski <bartfab@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Nikita Podguzov <nikitapodguzov@chromium.org> Cr-Commit-Position: refs/heads/master@{#740251}
-
Koji Ishii authored
TBR=ikilpatrick@chromium.org Bug: 1050315 Change-Id: I2ea0191336657a91472c3407f507a6a0c7eec5d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2049012Reviewed-by:
-
Maksim Moskvitin authored
This CL changes behavior on failed requests: 1. When request fails with auth error, access token isn't invalidated if the request was sent with old access token. 2. When request fails with other errors, which allow retry, access token is refreshed right before retry. Bug: 1020117 Change-Id: Ie7123eab78ecf1a4dee2b8ae4efe8d931f2ea15a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2047226Reviewed-by:
-
Huanzhong Huang authored
Bug: 1045348 Change-Id: I6bce0d04ace4fe3d6694ec5103d407f9be4cb604 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2044097Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Huanzhong Huang <huanzhong@chromium.org> Cr-Commit-Position: refs/heads/master@{#740248}
-
Demetrios Papadopoulos authored
Bug: 1026426 Change-Id: Id6b62c39b9184532a8e3e3c34c2bdee98a37240e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2045171 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
-
chromium-autoroll authored
Roll broadwell AFDO profile from 82-4028.0-1581331201-benchmark-81.0.4044.14-r1 to 82-4028.0-1581331201-benchmark-81.0.4044.15-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-broadwell-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I96e4d4403104edc787c90d3c8d2cd1ea7e11ee36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050086Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium db8ecb4a. With Chromium commits locally applied on WPT: 5579aad0 "SharedWorker: Name shared workers identically in credentials mode WPT" 822dbfeb "[LayoutNG] Clip when hit-testing floats inside clipped containers." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: bjonesbe@adobe.com: external/wpt/css/css-shapes domenic@chromium.org, ricea@chromium.org: external/wpt/streams foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools hongchan@chromium.org, rtoy@chromium.org: external/wpt/webaudio NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Id2c503814900ce3e117f6d86380a64806a70127b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050123Reviewed-by:
-
Ken Rockot authored
Prior to this CL, blink.mojom.SessionStorageNamespace had two methods: OpenArea() and Clone(). OpenArea() takes an Origin argument which must be validated by browser security policy, while Clone() should go directly to the Session Storage implementation (eventually in the Storage Service, which may run outside of the browser). This CL reduces SessionStorageNamespace to only the Clone() method, while moving Session Storage's StorageArea binding to a new message on StoragePartitionService. No functional changes, just implementation plumbing so that the same effective behavior is preserved over the new IPC layout. Bug: 1000959 Change-Id: I6dcb8d52e7b4c34d58590fb6fbafb3f263e70fbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2045208Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#740244}
-
Morten Stenshorne authored
Change-Id: I1ee2e4c4f78a6471a4db50939076f13f9f978926 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2048423Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#740243}
-
