- 23 Mar, 2018 40 commits
-
-
Allen Bauer authored
Bug: 822000 Change-Id: I950ec472da2b5b8f8b52c54b9d14adc0098b3804 Reviewed-on: https://chromium-review.googlesource.com/969092Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#545572}
-
Xianzhu Wang authored
For <svg style="will-change: left"></svg>, previously we created a transform node just to store the direct compositing reason CompositingReason::kWillChangeCompositingHint, which broke the assumption that only objects having a PaintLayer can be composited. Bug: 825090 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I6eddb3b025ea82c08b38dc4ae0c0efc1048f6854 Reviewed-on: https://chromium-review.googlesource.com/978504Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#545571}
-
Min Qin authored
This CL moves DownloadWorker from content/browser/download to components/download. DownloadWorker is used by ParallelDownloadJob for creating parallel download requests. To remove the dependencies on content/, following changes are made: 1. Introduces URLDownloadHandlerFactory class, this class allows content/ to inject its own URLDownloadHandler implementation (UrlDownloader) when network service is disabled. 2. DownloadManager will always pass a SharedURLLoaderFactory to ResourceDownloader. ResourceDownloader will later return it back to DownloadManager, and DownloadManager will then pass it to the ParallelDownloadJob through DownloadItemImpl. Bug: 803135 Change-Id: I96dfb75daa438049df0dc9fd0fbe74abd5ff1d7a Reviewed-on: https://chromium-review.googlesource.com/974120 Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#545570}
-
Siddhartha authored
The bitmap resources held by LayerTitleCache for tabs are never cleared by tab strip model. Release resources held for a tab if the tab is marked invisible in tab strip layout. BUG=701976 Change-Id: I3539d5aa546d5f002cb2b1a670de5dea52336722 Reviewed-on: https://chromium-review.googlesource.com/977324Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Siddhartha S <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#545569}
-
Findit authored
This reverts commit cdd8661f. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 545521 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2NkZDg2NjFmM2YzNWQ3MDc1MDIwZWFkMDQ5MmNkODNlMThmNzk1ZTkM Sample Failed Build: https://ci.chromium.org/buildbot/chromium.linux/Linux%20Tests%20%28dbg%29%281%29%2832%29/48976 Sample Failed Step: base_unittests Original change's description: > base: Introduce the new Shared Memory API > > Design doc (public): https://goo.gl/HmBYy6 > > This patch proposes the new API for the Shared Memory based on two > concepts, a shared memory region and a shared memory mapping. The > region controls the platform-specific handle and mediates sharing and > access control. The mapping is just a reference to the memory bytes > which knows how to unmap itself. Ownership is per-instance: neither a > region nor a mapping may be copied, and resources are freed when then > instance dies. This is accomplished through move-only semantics. > > The goal of the new API is to provide a correct cross-platform > implementation that makes the sharing mode explicit via the C++ type > system. > > Thus, this CL introduces two classes for shared memory mappings: > - WritableSharedMemoryMapping owns and provides an access to writable > shared memory > - ReadOnlySharedMemoryMapping for read-only shared memory > > and three classes representing shared memory regions: > - UnsafeSharedMemoryRegion allows to create > WritableSharedMemoryMapping instances and cannot be used for making > read-only mappings > - ReadOnlySharedMemoryRegion, on the contrary, can produce only > ReadOnlySharedMemoryMapping instances and it also creates one writable > mapping in the caller process address space > - WritableSharedMemoryRegion allows to create writable > mappings and can be eventually converted to ReadOnlySharedMemoryRegion. > The important limitation in comparison with UnsafeSharedMemoryRegion > is that the WritableSharedMemoryRegion cannot be duplicated so in > order to pass the writable region to another process, the ownership of > the region must be moved/transferred to this process. > > Bug: 795291 > Change-Id: I7d1d0a24932145cc0f449b01ceb8cafef9b7e407 > Reviewed-on: https://chromium-review.googlesource.com/893458 > Commit-Queue: Alexandr Ilin <alexilin@chromium.org> > Reviewed-by: Matthew Cary <mattcary@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Erik Chen <erikchen@chromium.org> > Reviewed-by: Robert Sesek <rsesek@chromium.org> > Reviewed-by: Ken Rockot <rockot@chromium.org> > Cr-Commit-Position: refs/heads/master@{#545521} Change-Id: I9c5657e80b8a262a42311d4d2a0239dc242ab8f5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 795291 Reviewed-on: https://chromium-review.googlesource.com/978563 Cr-Commit-Position: refs/heads/master@{#545568}
-
Oksana Zhuravlova authored
This change moves thread_priority.mojom from //mojo/common to //mojo/public/mojom/base. Corresponding typemap and struct traits files were also moved. Unit test for ThreadPriority was added to mojo_unittests. Bug: 799482,806965 Change-Id: I47c23a6b5eea8fffd8a6aa9c18f9e8e12045e8e7 Reviewed-on: https://chromium-review.googlesource.com/976621 Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#545567}
-
Hector Carmona authored
Test was affected by paper-icon-button migration. This selects the correct element to check for the hidden attribute. Bug: 821759 Change-Id: I1bc67c41e9e9293c5f06ef0120fdde85beb959d6 Reviewed-on: https://chromium-review.googlesource.com/978470Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#545566}
-
Matt Menke authored
NOTRY=true Bug: 822717 Change-Id: I21cd2bed496cef2d8e94d1eebc7354cfa5b90ddd Reviewed-on: https://chromium-review.googlesource.com/978385 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Helen Li <xunjieli@chromium.org> Cr-Commit-Position: refs/heads/master@{#545565}
-
Avi Drissman authored
BUG=357627 Change-Id: I62ff9157d6d41bd4581ba3d080dca2c309cb3e82 Reviewed-on: https://chromium-review.googlesource.com/978387Reviewed-by:
Sidney San Martín <sdy@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#545564}
-
https://webrtc.googlesource.com/src.git/+log/06e363a6e608..9718711deed8 $ git log 06e363a6e..9718711de --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I6ad4ab8bec380255169cff3e49e71ebc27abdf20 Reviewed-on: https://chromium-review.googlesource.com/978377Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#545563}
-
Sidney San Martín authored
Bug: 823108 Change-Id: Ie1c4d5ee7fc63ea56f2a25506bab14a7a4137b87 Reviewed-on: https://chromium-review.googlesource.com/973892 Commit-Queue: Sidney San Martín <sdy@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#545562}
-
mrefaat authored
The reason for the crash is the thread inconsistency of dereferencing the weakptr of the CookieCreationTimeManager object Removed weakptr, as it appears that it's not needed at all. Bug: 813779, 820384 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Iff614621b09b92ae5fa9a41ad90a2e390a1ce6b1 Reviewed-on: https://chromium-review.googlesource.com/976095 Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#545561}
-
Matt Wolenetz authored
Adds conditional disabling of these two tests. BUG=825305,823003 TBR=sky@chromium.org,creis@chromium.org NO-TRY=True Change-Id: I9c24882c82db878883a9cd8df9abe3f95723634c Reviewed-on: https://chromium-review.googlesource.com/978666 Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Reviewed-by:
Matthew Wolenetz <wolenetz@chromium.org> Cr-Commit-Position: refs/heads/master@{#545560}
-
Wez authored
These tests were posting delayed tasks to inject video frames, with raw pointers to the target object. The tests would usually pass because the delayed task would be silently dropped during MessageLoop teardown, but on slow systems (e.g. under QEMU) these delayed tasks could end up being executed during the teardown RunUntilIdle(), after the target had been torn down. The target is a ref-counted object, so post delayed tasks to it without using Unretained(), to ensure it remains valid. Bug: 819924 Change-Id: I5a781cbaab1519b5707967753decf2672ba826d5 Reviewed-on: https://chromium-review.googlesource.com/978637Reviewed-by:
Emircan Uysaler <emircan@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#545559}
-
Jay Civelli authored
Changing the WebContentsObserver::SubresourceResponseStarted to SubresourceLoadComplete. This is going to be used to support page load metrics with the network service. Note that SubresourceResponseStarted in frame.mojom is kept, as it is used by the SSLManager. It's implementation is kept in WebContentsImpl and its parameters are changed to only what's needed for that use case. Bug: 816684 Change-Id: I78fa4b0d7f44cfb0a5e98a7fc008fb7a17f8aae4 Reviewed-on: https://chromium-review.googlesource.com/967370 Commit-Queue: Jay Civelli <jcivelli@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Conley Owens <cco3@chromium.org> Cr-Commit-Position: refs/heads/master@{#545558}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 072d5198. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/14368 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: rouslan@chromium.org, mathp@chromium.org: external/wpt/payment-request TBR=danyao No-Export: true Change-Id: I10d399868669fd9cfcbb414325abfaf1b5cfaf51 Reviewed-on: https://chromium-review.googlesource.com/978031 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#545557}
-
Michael Lippautz authored
Bug: chromium:757440 Change-Id: Ie1c8bf7aad5246e5e7325f2a5a6ebb26c915beed Reviewed-on: https://chromium-review.googlesource.com/975122 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#545556}
-
Sidney San Martín authored
Bug: 823325 Change-Id: I8c8d9d866112a7fd7ed0ab1304bea4b8ad355ee1 Reviewed-on: https://chromium-review.googlesource.com/974784Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Sidney San Martín <sdy@chromium.org> Cr-Commit-Position: refs/heads/master@{#545555}
-
Brian Salomon authored
-Specify sized internal GL format in GrGLFramebufferInfo. -Don't use pixel config when creating GrBackendRenderTarget. -Specify SkColorType when wrapping GrBackendRenderTarget in SkSurface. Bug: skia:6718 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I8337f90a9328cd13fb4eb2a96354aa84fc00aa41 Reviewed-on: https://chromium-review.googlesource.com/978032 Commit-Queue: Brian Salomon <bsalomon@chromium.org> Reviewed-by:
weiliangc <weiliangc@chromium.org> Cr-Commit-Position: refs/heads/master@{#545554}
-
chrome://reset-passwordJialiu Lin authored
Bug: 824500 Change-Id: Ie550cf437b5919a6b4c69113c73643d5b163f51b Reviewed-on: https://chromium-review.googlesource.com/977161Reviewed-by:
Cait Phillips <caitkp@chromium.org> Commit-Queue: Jialiu Lin <jialiul@chromium.org> Cr-Commit-Position: refs/heads/master@{#545553}
-
Elly Fong-Jones authored
Bug: 802257 Change-Id: I5b731977cb8ec78dc45caa3c600da0453df64ab2 Reviewed-on: https://chromium-review.googlesource.com/978029Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Leonard Grey <lgrey@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#545552}
-
Miriam Gershenson authored
Cronet has enough other owners. DNS reviews can go to top-level net/ owners. Change-Id: I2ff3b972840337ee18dcf07aa845ed77d2caf232 Reviewed-on: https://chromium-review.googlesource.com/976042Reviewed-by:
Misha Efimov <mef@chromium.org> Commit-Queue: Miriam Gershenson <mgersh@chromium.org> Cr-Commit-Position: refs/heads/master@{#545551}
-
Sidney San Martín authored
Bug: Change-Id: Ia6e2432f3b735adc080327ee517f6050859ffbfc Reviewed-on: https://chromium-review.googlesource.com/974084Reviewed-by:
Leonard Grey <lgrey@chromium.org> Commit-Queue: Sidney San Martín <sdy@chromium.org> Cr-Commit-Position: refs/heads/master@{#545550}
-
Alexei Filippov authored
It is now much easier to switch it on/off per recording. It is also made more discoverable. Removed an unused ui/panelEnablerView.css BUG=824943 Change-Id: I0fdfe11ceb42307c6538d420adcf31406eae003d Reviewed-on: https://chromium-review.googlesource.com/976557Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#545549}
-
Danyao Wang authored
This fixes occassional DCHECKs in WebStateImpl::GetCurrentURL when navigating from NTP to a web page. It seems that JavaScript messages from the new page could arrive before |didCommitNavigation| callback. So when CRWWebController's |currentURLWithTrustLevel| is called, it returns _documentURL, which is the placeholder URL when the last committed item URL is chrome://newtab. Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ic1dde752b9cbdd0cdc2793b81c5722b54a431b38 Reviewed-on: https://chromium-review.googlesource.com/976744Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Danyao Wang <danyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#545548}
-
Taylor Brandstetter authored
https://chromium.googlesource.com/external/github.com/sctplab/usrsctp/+log/0e076261b832..159d060dceec $ git log 0e076261b..159d060dc --date=short --no-merges --format='%ad %ae %s' 2018-02-19 tuexen Update Manual.md 2018-02-19 bruce.mitchener manual: Improve docs for usrsctp_socket. 2018-02-15 deadbeef Fix data race around timer_thread_should_exit. 2018-02-05 bruce.mitchener Minor corrections to manual. 2018-02-04 bruce.mitchener Fix typos. 2018-01-27 tuexen Add constant for PAD parameter and some cleanup. 2018-01-27 tuexen Sync with SCTP_NKE_HighSierra. 2018-01-16 tuexen Fix a bug related to fast retransmissions. 2018-01-15 tuexen Don't provide a cmsg with notifications. 2017-12-26 tuexen Allow the kernel to be compiled without SCTP. 2017-12-13 tuexen Cleanup. 2017-12-08 tuexen Remove debug stuff accidently committed. 2017-12-07 tuexen Retire SCTP_WITH_NO_CSUM. Created with: roll-dep src/third_party/usrsctp/usrsctplib Bug: None Change-Id: I0953d0cd3319a9354efe2674125322cc052a7af4 Reviewed-on: https://chromium-review.googlesource.com/961604Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Taylor Brandstetter <deadbeef@chromium.org> Cr-Commit-Position: refs/heads/master@{#545547}
-
Greg Kraynov authored
Change-Id: I3913efea5dd760e3496b971d871d22939c34e1af Reviewed-on: https://chromium-review.googlesource.com/968493 Commit-Queue: Greg Kraynov <kraynov@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#545546}
-
Christopher Cameron authored
This appears to not be used outside of unit tests. Add a NOTREACHED to be sure. Bug: 821651 Change-Id: I9fb45ce7afd9794aeccf6a01d646d992d1be1be5 Reviewed-on: https://chromium-review.googlesource.com/978463Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#545545}
-
Jared Saul authored
This reverts commit e363dc21. Reason for revert: Not convinced metrics are good; performing flag holdback Original change's description: > Clean up kAutofillCreditCardBankNameDisplay flag > > Bug: 812710 > Change-Id: I4344c258668c5017a0a145e487ca2eb526bd49bc > Reviewed-on: https://chromium-review.googlesource.com/923281 > Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> > Reviewed-by: Robert Kaplow <rkaplow@chromium.org> > Commit-Queue: Jared Saul <jsaul@google.com> > Cr-Commit-Position: refs/heads/master@{#537368} TBR=mathp@chromium.org,rkaplow@chromium.org,sebsg@chromium.org,jsaul@google.com Bug: 812710 Change-Id: I0f15c86af76e686ef4ab55a0313831461503d758 Reviewed-on: https://chromium-review.googlesource.com/974342Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Commit-Queue: Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#545544}
-
Ken Rockot authored
Some restructuring and cleanup of EDK code and targets: - //mojo/edk/system sources are merged into //mojo/edk:core - embedder_internal.h is removed - mojo::edk::internal::g_core is replaced with mojo:edk::Core::Get(). - Core ownership and initialization is moved into entrypoints.cc, where (a) it's used most frequently and (b) it can be shared with mojo_core in a follow-up patch. Bug: 822034 Change-Id: I193549101f00aaf5b95764eeee7065423d6576e5 Reviewed-on: https://chromium-review.googlesource.com/977900 Commit-Queue: Ken Rockot <rockot@chromium.org> Reviewed-by:
Jay Civelli <jcivelli@chromium.org> Cr-Commit-Position: refs/heads/master@{#545543}
-
Wez authored
Previously we gated run-time-configurable DCHECKs on the |is_syzyasan| argument, to have them built-in to Chrome Canary SyzyASAN binaries. We implement |dcheck_is_configurable| as a macro define rather than via a buildflag, because Chromium currently has too many components with undeclared dependencies on //base for introducing a new dependency of //base/logging.h on a generated buildflags_header() to be safe. Bug: 812058 Change-Id: Iac48c88e0c5964cc8bceac6c444e44f84133120e Reviewed-on: https://chromium-review.googlesource.com/974904Reviewed-by:
Nick Carter <nick@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#545542}
-
Ted Choc authored
BUG=822137 Change-Id: I3b9bf9c5280599f061b3c22f78569d91b78d6168 Reviewed-on: https://chromium-review.googlesource.com/974647Reviewed-by:
Maria Khomenko <mariakhomenko@chromium.org> Commit-Queue: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#545541}
-
Rune Lillesveen authored
We stored ComputedStyle for option, optgroup, and svg:stop even when their computed display was none. That caused descendants to get ComputedStyle objects and confused the WhitespaceAttacher walking down display:none subtrees for layout tree rebuilds. Bug: 822581 Change-Id: I604033d96ff194119f328ac5ced71a9e04563ccb Reviewed-on: https://chromium-review.googlesource.com/973962 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#545540}
-
Brandon Jones authored
Bug: 818276 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Ie05e6d83dc71beac0e682fad967e75616e81f6af Reviewed-on: https://chromium-review.googlesource.com/946856Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Ian Vollick <vollick@chromium.org> Reviewed-by:
Justin Novosad <junov@chromium.org> Reviewed-by:
Bill Orr <billorr@chromium.org> Commit-Queue: Brandon Jones <bajones@chromium.org> Cr-Commit-Position: refs/heads/master@{#545539}
-
Hector Carmona authored
This was missed as part of the v2 paper-icon-button-light migration. Bug: 822573 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ifeacc6ca78efb16df0de851698bff71d11fac5b5 Reviewed-on: https://chromium-review.googlesource.com/976383Reviewed-by:
Scott Chen <scottchen@chromium.org> Commit-Queue: Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#545538}
-
Dave Schuyler authored
This CL removes the need for ShowOnlyKeywordMatch() (and removes that function). The ShowOnlyKeywordMatch() was used to check whether the animation had reached the suggestion icon and then it would make it invisible. The code will now narrow the icon until it has no width, removing it smoothly rather than making it pop out of existence. ShowOnlyKeywordMatch() also had a very minor optimization effect by not laying out the suggestion if the keyword search had finished animating. This optimization is small and on an uncommon case. The primary reason for this CL is to ease the transition to CL/974656. Bug: None Change-Id: I3217b1235352b4caa05d5bc01422c88e4b65991b Reviewed-on: https://chromium-review.googlesource.com/977226Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Dave Schuyler <dschuyler@chromium.org> Cr-Commit-Position: refs/heads/master@{#545537}
-
Charles 'Buck' Krasic authored
Add a new type of IO buffer. Part of a series of changes to improve performance of QUIC uploads that become CPU constrained. R=rch@chromium.org Change-Id: Ife3b6983d80744eb390939d0d9f751cecff8f958 Reviewed-on: https://chromium-review.googlesource.com/971827 Commit-Queue: Buck Krasic <ckrasic@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#545536}
-
Steven Holte authored
Bug: 811376 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I1a745dbb16e9aa9791671afc90ff67106848c4d8 Reviewed-on: https://chromium-review.googlesource.com/944901Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#545535}
-
Emily Hanley authored
Bug: 811766 Change-Id: Ia95dc3a6639ed4334243c4476930017aef2d560e Reviewed-on: https://chromium-review.googlesource.com/978447Reviewed-by:
Ashley Enstad <ashleymarie@chromium.org> Commit-Queue: Emily Hanley <eyaich@chromium.org> Cr-Commit-Position: refs/heads/master@{#545534}
-
Marijn Kruisselbrink authored
has_backing_file_ being true implies that file_system_url_ is empty, so remove unreachable code that tried to special case this situation. This also leaves drag-and-drop code as the only user of file_system_url_, but removing that dependency would require fixing bug 394955 first. Bug: none Change-Id: Ica9544156f58bab6915a451ec272d1ea23475e9d Reviewed-on: https://chromium-review.googlesource.com/972348 Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#545533}
-