- 28 Apr, 2017 40 commits
-
-
wjmaclean authored
Since GestureScrolls can be ended by either GestureScrollEnd or GestureFlingStart, it seems wrong that OOPIF scroll bubbling, in RenderWidgetHostViewChildFrame/CrossProcessFrameConnector doesn't bubble GestureFlingStart. This CL modifies the bubbling code to include bubbling of GestureFlingStart, and re-enables a related DHECK in RenderWidgetHostImpl. BUG=695187 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2842203002 Cr-Commit-Position: refs/heads/master@{#468079}
-
thomasanderson authored
Kernel 4.11 merges the commit that added linux/dma-buf.h https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=ef96152e6a36e0510387cb174178b7982c1ae879 This CL increases the required kernel to include this file to 4.11. BUG=707604 R=danakj@chromium.org Review-Url: https://codereview.chromium.org/2851803002 Cr-Commit-Position: refs/heads/master@{#468078}
-
yosin authored
This patch add DCHECK into |ApplyStyleCommand::DoApply()| to verify that we don't apply |ApplyStyleCommand| to empty range to detect redundant command execution for improving code health. Actually, |ApplyStyleCommand::DoApply()| doesn't work with empty range, it causes DCHECK for |Position.IsNull()| in |ComparePositions()|. BUG=714311 TEST=n/a; no behavior changes Review-Url: https://codereview.chromium.org/2848823002 Cr-Commit-Position: refs/heads/master@{#468077}
-
kylechar authored
exo::Surface wasn't setting the device_scale_factor in CompositorFrames. This was triggering a DCHECK when the SurfaceInfo for new cc::Surfaces have device_scale_factor == 0. BUG=b/37654593 Review-Url: https://codereview.chromium.org/2843723003 Cr-Commit-Position: refs/heads/master@{#468076}
-
pkotwicz authored
Reland of [WebAPKs] Make WebAPK update flow more sensible (patchset #2 id:90001 of https://codereview.chromium.org/2845943006/ ) Reason for revert: Reverting the revert now that https://chrome-internal-review.googlesource.com/c/363648/ has landed. That CL should prevent official builder from breaking Original issue's description: > Revert of [WebAPKs] Make WebAPK update flow more sensible (patchset #4 id:100001 of https://codereview.chromium.org/2827233006/ ) > > Reason for revert: > broke official-* bots, see crbug.com/716330 > > Original issue's description: > > [WebAPKs] Make WebAPK update flow more sensible > > > > Previously, whenever the shell_apk in shell_apk_version.gni there was a period > > of time during which > > - Chrome tries to update the WebAPK because the "shell_apk" version with which > > Chrome is compiled with was updated > > - The WebAPK server is unable to fulfill the update request because the new > > ShellAPK has not yet been uploaded to the WebAPK server > > > > This CL splits shell_apk_version in shell_apk_version.gni into two variables: > > |template_shell_apk_version| and |expected_shell_apk_version| > > > > The new flow for updating android/webapk/shell_apk will be: > > 1) Write CL which: > > - Makes changes to code in android/webapk/shell_apk > > - Increments |template_shell_apk_version| > > This will: > > - Update the template ShellAPK which is built on the official build bot > > - Trigger an alert that the ShellAPK on the WebAPK Minting Server needs to > > be updated > > - Does not affect the "WebAPK update logic". > > 2) Upload new ShellAPK template to the WebAPK Minting Server > > At this point: > > - new WebAPK installs will have the updated shell. > > - Chrome will still not request updates to the new ShellAPK version > > 3) Write CL which: > > - Increments |expected_shell_apk_version| > > This will: > > - cause Chrome to request updates to the new ShellAPK version > > > > BUG=708053 > > > > Review-Url: https://codereview.chromium.org/2827233006 > > Cr-Commit-Position: refs/heads/master@{#467708} > > Committed: https://chromium.googlesource.com/chromium/src/+/d71abed75b07b4b9fc50591cbeb2b6c8874bf448 > > TBR=hartmanng@chromium.org,hanxi@chromium.org,zpeng@chromium.org,dominickn@chromium.org,pkotwicz@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=708053 > > Review-Url: https://codereview.chromium.org/2845943006 > Cr-Commit-Position: refs/heads/master@{#467966} > Committed: https://chromium.googlesource.com/chromium/src/+/db08d35eab5d639a6ed751dd4e42dcd5b4f683ec TBR=hartmanng@chromium.org,hanxi@chromium.org,zpeng@chromium.org,dominickn@chromium.org,timvolodine@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=708053 Review-Url: https://codereview.chromium.org/2847263002 Cr-Commit-Position: refs/heads/master@{#468075}
-
catmullings authored
The current extension permission update bubble puts both old and new permissions together in one list. This CL changes the bubble to only show the new permissions. BUG=443216 Review-Url: https://codereview.chromium.org/2821123002 Cr-Commit-Position: refs/heads/master@{#468074}
-
ntfschr authored
The "learn more" link has moved to the main content instead of the details. Tests should check for it before clicking the details, since mobile layouts will hide the main content after "details" is clicked. BUG=674732 Review-Url: https://codereview.chromium.org/2845363003 Cr-Commit-Position: refs/heads/master@{#468073}
-
lfg authored
The lifetime of GuestViewBase doesn't match the lifetime of GuestViewMessageFilter, so it's possible that the GuestViewBase is already destroyed by the time this callback is called. BUG=716223 Review-Url: https://codereview.chromium.org/2848723002 Cr-Commit-Position: refs/heads/master@{#468072}
-
justincohen authored
BUG= Review-Url: https://codereview.chromium.org/2848003002 Cr-Commit-Position: refs/heads/master@{#468071}
-
mthiesse authored
This shaves ~6ms off of our total skia render time for English. Similar numbers for other languages. BUG=715591 Review-Url: https://codereview.chromium.org/2846023002 Cr-Commit-Position: refs/heads/master@{#468070}
-
pilgrim authored
BUG=707642 Review-Url: https://codereview.chromium.org/2846273002 Cr-Commit-Position: refs/heads/master@{#468069}
-
vadimt authored
It's highly unlikely that this can happen, but just in case. The voice search popup will keep staying with no other way to dismiss it except reopening the launcher, but I don't think we should take too much care of this edge case beyond simply not breaking. Bug=712331 Review-Url: https://codereview.chromium.org/2848493004 Cr-Commit-Position: refs/heads/master@{#468068}
-
yizhou.jiang authored
https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/f7157c2..2395287 BUG=693090,712096 TEST=bots CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2844363004 Cr-Commit-Position: refs/heads/master@{#468067}
-
szager authored
A minor refactoring; the method will get a couple of other callers in subsequent patches (which I'm breaking up for digestibility). The new condition is something that currently will never be false; subsequent patches will cause it be false sometimes. BUG=701575 Review-Url: https://codereview.chromium.org/2846263002 Cr-Commit-Position: refs/heads/master@{#468066}
-
boliu authored
Make --enable-gpu-client-tracing work for the in-process context on the render thread. This matches ContextProviderCommandBuffer implementation. Review-Url: https://codereview.chromium.org/2850713002 Cr-Commit-Position: refs/heads/master@{#468065}
-
jam authored
Fix SitePerProcessBrowserTest.ProcessTransferAfterError to not requiring modifying the mock HostResolver when using the network service. This allows us to turn on the check that the host resolver isn't modified after SetUpOnMainThread in a future change. BUG=713847 Review-Url: https://codereview.chromium.org/2847003003 Cr-Commit-Position: refs/heads/master@{#468064}
-
emx authored
It now support backslashes in file paths and uses LF as EOL (instead of CRLF) even on Windows. BUG=none Review-Url: https://codereview.chromium.org/2846223002 Cr-Commit-Position: refs/heads/master@{#468063}
-
szager authored
This anticipates when the size of the main frame's root layer is based on the main frame's layout size. BUG=701575 R=skobes@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2841113002 Cr-Commit-Position: refs/heads/master@{#468062}
-
sky authored
Revert of Global Resource Coordinator: Basic service internals (patchset #30 id:560001 of https://codereview.chromium.org/2798713002/ ) Reason for revert: Reverting as CoordinationUnitImplTest.CyclicGraphUnits is crashing on windows dbg. The output isn't very helpful: https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.win%2FWin7_Tests__dbg__1_%2F59514%2F%2B%2Frecipes%2Fsteps%2Fservice_unittests%2F0%2Fstdout RUN ] CoordinationUnitImplTest.CyclicGraphUnits [114/116] CoordinationUnitImplTest.CyclicGraphUnits (CRASHED) [115/116] CoordinatorImplTest.NoProcessLocalManagers (1 ms) [116/116] CoordinatorImplTest.SeveralProcessLocalManagers (4 ms) Retrying 1 test (retry #1) [ RUN ] CoordinationUnitImplTest.CyclicGraphUnits [117/117] CoordinationUnitImplTest.CyclicGraphUnits (CRASHED) Retrying 1 test (retry #2) [ RUN ] CoordinationUnitImplTest.CyclicGraphUnits [118/118] CoordinationUnitImplTest.CyclicGraphUnits (CRASHED) Retrying 1 test (retry #3) [ RUN ] CoordinationUnitImplTest.CyclicGraphUnits [119/119] CoordinationUnitImplTest.CyclicGraphUnits (CRASHED) Original issue's description: > Global Resource Coordinator: Basic service internals > > This adds the basic internals of the GRC; CoordinationUnits which can form a DAG, receive events, and send back updated resource usage policies. > > A full prototype of GRC usage can be seen here: https://codereview.chromium.org/2710823003 > > Service architecture doc: https://docs.google.com/document/d/1qec4DNDM2pLLIFfCBtnNQTxlNXQzjml69yC8SGU9bzI/edit# > > GRC parent doc (internal only): https://docs.google.com/document/d/1dx4KDbDFvP-GWwwrSPg8Gxx4kboIoPi8kDKTSXoTbC4/edit#heading=h.td4yhfm12fe3 > > R=primiano@chromium.org,skyostil@chromium.org,fmeawad@chromium.org,rockot@chromium.org > BUG=691886 > > Review-Url: https://codereview.chromium.org/2798713002 > Cr-Commit-Position: refs/heads/master@{#468002} > Committed: https://chromium.googlesource.com/chromium/src/+/de0f39d2a625433e60b5e22e1d2d3803f3d219e5 TBR=chrisha@chromium.org,dcheng@chromium.org,fmeawad@chromium.org,jam@chromium.org,nasko@chromium.org,primiano@chromium.org,rockot@chromium.org,skyostil@chromium.org,oysteine@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=691886 Review-Url: https://codereview.chromium.org/2851813002 Cr-Commit-Position: refs/heads/master@{#468061}
-
lizeb authored
Only the WebContents is needed, don't keep a reference to Tab, that keeps a reference to the Activity. BUG=715724 Review-Url: https://codereview.chromium.org/2847533004 Cr-Commit-Position: refs/heads/master@{#468060}
-
bnc authored
SpdyFrameWithStreamIdIR was always kind of pointless. This CL lands server change 153630764 by birenroy. BUG=488484 Review-Url: https://codereview.chromium.org/2849713002 Cr-Commit-Position: refs/heads/master@{#468059}
-
pilgrim authored
BUG=707642 Review-Url: https://codereview.chromium.org/2844223006 Cr-Commit-Position: refs/heads/master@{#468058}
-
lfg authored
This change adds support for sending screen orientation change events to out-of-process iframes as well as fixing the Screen.orientation property on OOPIFs. This change adds a PageMsg_UpdateScreenInfo that updates the ScreenInfo for subframe renderers. The screen orientation is still updated on the ViewMsg_Resize for the main frame. The flow of dispatching the screen orientation update is: 1. The browser sends a ViewMsg_Resize to the main frame's renderer. The browser also sends PageMsg_UpdateScreenInfo to the OOPIF renderers. 2. The main frame renderer dispatches FrameHostMsg_FrameRectsChanged back to the browser process. 3. The browser process dispatches ViewMsg_Resize to the subframe renderers. 4. The subframe renderers dispatch the screen orientation event when they receive the resize IPC. BUG=498287 Review-Url: https://codereview.chromium.org/2832093003 Cr-Commit-Position: refs/heads/master@{#468057}
-
wangxianzhu authored
https://codereview.chromium.org/2786463004/ caused the regression. Now we paint cell's container backgrounds as display item of row/section instead of cell, so when cell's geometry changes we need to invalidate the container's backgrounds. BUG=713050 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2851553002 Cr-Commit-Position: refs/heads/master@{#468056}
-
mstensho authored
BUG=716442 Review-Url: https://codereview.chromium.org/2848883002 Cr-Commit-Position: refs/heads/master@{#468055}
-
twellington authored
appbar_background was previously used to provide a grey toolbar on phones and a white toolbar on tablets for the downloads and bookmarks UIs. The toolbar for these UIs is always gray now, so appbar_background is no longer needed. BUG=687640 Review-Url: https://codereview.chromium.org/2845373003 Cr-Commit-Position: refs/heads/master@{#468054}
-
adithyas authored
Moves TraceWrapperMember, SharedPersistent, IDLDictionaryBase and ToV8 to platform/bindings. Also moves some ScriptValue functions in ToV8 to ToV8ForCore as ScriptValue is not moving to platform/bindings right now. BUG=682322 Review-Url: https://codereview.chromium.org/2843143002 Cr-Commit-Position: refs/heads/master@{#468053}
-
torne authored
Since N, the preference directory will be created if it doesn't exist when getSharedPreferences is called. Enable disk writes to prevent a strict mode violation; this will only happen the first time an app is started up. BUG=716219 Review-Url: https://codereview.chromium.org/2846963005 Cr-Commit-Position: refs/heads/master@{#468052}
-
chrishtr authored
This is in preparation for actually fragmenting under multicol, in a future patch. BUG=648274 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2849603004 Cr-Commit-Position: refs/heads/master@{#468051}
-
torne authored
allowThreadDiskWrites also allows reads, so it's not necessary to call both together. Remove all the redundant allowThreadDiskReads calls. BUG= Review-Url: https://codereview.chromium.org/2851473007 Cr-Commit-Position: refs/heads/master@{#468050}
-
kapishnikov authored
BUG=716480 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester Review-Url: https://codereview.chromium.org/2848903003 Cr-Commit-Position: refs/heads/master@{#468049}
-
weidongg authored
* Remove touch drag for a series of tests about tab dragging to the second display as, up to now, there's no use case. * Each display has its own UI controller in the test, but, in ozone build, they do not share the state of mouse (down, up). When the mouse is moved to the second display, the UI controller for it does know that the mouse is down in first display. That's why the tab cannot be dragged to the second display only in ozone build. Simple solution is to move the mouse state variable outside of UI controller class. BUG=626769 Review-Url: https://codereview.chromium.org/2836073003 Cr-Commit-Position: refs/heads/master@{#468048}
-
ynovikov authored
Remove NVIDIA Shield Tablet expectations, since they also affect NVIDIA Shield TV. Mark conformance/textures/image_bitmap_from_video/tex-2d-rgb-rgb-unsigned_byte.html Flaky on Nexus 5X. BUG=701929, 716496 TBR=kbr@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2851773002 Cr-Commit-Position: refs/heads/master@{#468047}
-
alexilin authored
This is the first step of Glowplug Database refactoring. As a result we should get rid of boilerplate related to adding/removing tables from Glowplug. The next step will be providing users the direct access to tables instead of using Update{Resource,Redirect,etc.}Data wrappers. The code uses templates instead of google::protobuf::MessageLite for the type-safety. BUG=715525 Review-Url: https://codereview.chromium.org/2851473002 Cr-Commit-Position: refs/heads/master@{#468046}
-
dtapuska authored
Change https://chromium.googlesource.com/chromium/src/+/d892f9592860691ae9a782c12260c94ed6bd1a63%5E%21/#F30 caused the layout object to possibly be invalidated. Collapse the code so that LayoutObject is correclty scoped so we don't run this risk. BUG=712459 Review-Url: https://codereview.chromium.org/2849883002 Cr-Commit-Position: refs/heads/master@{#468045}
-
rdevlin.cronin authored
Move tests for parsing API calls against the expected signature from api_binding_unittest.cc to a new api_signature_unittest.cc. This is more correct since the parsing now happens in that file, and will also make subsequent tests cleaner. BUG=653596 Review-Url: https://codereview.chromium.org/2847843002 Cr-Commit-Position: refs/heads/master@{#468044}
-
mdjones authored
Previously, all observers of the bottom sheet had a life cycle that matched the bottom sheet, so it wasn't necessary to remove the. The suggestions content, however, does have the potential to be destroyed. This change adds a removeObserver(...) method to the bottom sheet to handle this case. BUG=715979 Review-Url: https://codereview.chromium.org/2844993003 Cr-Commit-Position: refs/heads/master@{#468043}
-
tsepez authored
Review-Url: https://codereview.chromium.org/2843263006 Cr-Commit-Position: refs/heads/master@{#468042}
-
vmpstr authored
This patch ensures that we capture all relevant work that we do during recording. This includes both the analysis (which is currently captured) and discardable image generation (which is currently missed). This is done via using RecordingSource, which does all of this work during regular Chrome operations. NOTE TO PERF SHERIFFS ===================== This patch is expected to regress rasterize and record benchmark. Some metrics like paint_time are expected to regress ~100%. This is due to the fact that the current benchmark is not capturing all of the work that the code normally does. The patch here addresses this shortcoming by adding all of the work that needs to be measured into the benchmark. R=chrishtr@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2851583002 Cr-Commit-Position: refs/heads/master@{#468041}
-
ftirelo authored
This CL had been previously landed as: https://chromium.googlesource.com/chromium/src/+/e012fe8a8e4d60ed8eba17fbac5df6d9fc4bcad3 but got reverted because it broke some browser tests: https://chromium.googlesource.com/chromium/src/+/13b26dffd848c02b1ae0f4ed86986b2a474056c1 Review-Url: https://codereview.chromium.org/2849433002 Cr-Commit-Position: refs/heads/master@{#468040}
-