- 12 Jul, 2019 40 commits
-
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/e896a0da6678..06ab6e5b1330 git log e896a0da6678..06ab6e5b1330 --date=short --no-merges --format='%ad %ae %s' 2019-07-12 jiawei.shao@intel.com Metal: Code clean up in copy commands 2019-07-12 cwallez@chromium.org Add rendering tests for all color formats Created with: gclient setdep -r src/third_party/dawn@06ab6e5b1330 The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel TBR=cwallez@google.com Change-Id: I6fa6f0f982f5d4b500222f15f8323d06c621dc90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699549Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#676818}
-
Anna Malova authored
Move Safe Browsing objects from AwBrowserContext to AwBrowserProcess. AwSafeBrowsingUIManager, TriggerManager, DatabaseManager and AwSafeBrowsingWhitelistManager are supposed to be global and not tied to any profile. Bug: 963875 Change-Id: Id353809e069a619223d396fa29b217534c680432 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1690854Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Tobias Sargeant <tobiasjs@chromium.org> Commit-Queue: Anna Malova <amalova@chromium.org> Cr-Commit-Position: refs/heads/master@{#676817}
-
Yuki Shiino authored
- Added all the APIs into IdlType - Simplified function docstring - Made the order of API listing consistent with class definitions This is a preparation to implement ReferenceType's proxy. Bug: 839389 Change-Id: I43ecdbdab9b84fbcc2503b64adb470b74fa1c0ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1698121Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#676816}
-
Javier Ernesto Flores Robles authored
Bug: 976640 Change-Id: I13b8e7ad638b7540724a65392ff8466414846420 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1697626 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Auto-Submit: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#676815}
-
Juan Antonio Navarro Perez authored
With the removal of some legacy memory benchmarks, vr_benchmarks are the sole remaining client of the top 10 URL_LIST and their WPR recordings. To make this more explicit we move both the list and the recordings to contrib/vr_benchmarks Bug: 761014 Change-Id: I8c1023655391484b245479ccb296ce0beee1972e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1687242Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#676814}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. The AutoRoll server is located here: https://autoroll.skia.org/r/afdo-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: I4e8154e696f40eb807be1c161da1961f26b7a54b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699556Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/22df64cc..b411a379 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I471f853acb0da0e8aa9e50ba3a1c067c93f8bbe6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1698171Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#676812}
-
Jordan Demeulenaere authored
Bug: 978295 Change-Id: I00cd32b667e8c7e210ec649ffc11e3a565c20802 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1698528Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Commit-Queue: Jordan Demeulenaere <jdemeulenaere@chromium.org> Cr-Commit-Position: refs/heads/master@{#676811}
-
Michael Ershov authored
Add a new error code to enterprise.platformKeys.[challengeUserKey|challengeMachineKey] so it's possible to distinguish between devices that doesn't support the operation and a real failure. Bug: 974018 Test: EPKPChallengeMachineKeyTest.AttestationUnsupported Change-Id: I77b21958007b92a061522cedffd59f40a8b39284 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695544Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Commit-Queue: Michael Ershov <miersh@google.com> Cr-Commit-Position: refs/heads/master@{#676810}
-
Daniel Vogelheim authored
Bug: 739170 Change-Id: Ie6d9dec721660c33b108fde2da226abfc9d746ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1698522Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org> Cr-Commit-Position: refs/heads/master@{#676809}
-
Sylvain Defresne authored
All the tests that were making use of that feature have been converted to use the real production workflow as IdentityTestEnvironment is not designed to allow testing sign-in or sign-out workflow since they are different on each platform. Remove the feature as it has no use, thus all the platform behave the same way when using IdentityTestEnvironment. Bug: 982259 Change-Id: I3809280d769863b80f12dcea5ac04f83ce855ee8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695344 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#676808}
-
Yutaka Hirano authored
Bug: None Change-Id: I7a1cde140753c16d8a7a6b76d7a15d305b7b9626 No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699058 Auto-Submit: Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#676807}
-
Sylvain Defresne authored
CWVSyncController wants to test the interaction with the production workflow of the sign-in which IdentityTestEnvironment cannot properly model. This is because IdentityTestEnvironment is generic code that put the IdentityManager in a known state for code that do not care how the list of accounts is updated. The only method from IdentityTestEnvironment that is used by the test is UpdatePersistentErrorOfRefreshTokenForAccount() and it does not depends on having fake backing the IdentityManager. So change the test to create a real instance and to invoke the test util method directly. This removes one usage of IdentityTestEnvironment::ExtraParams (which will eventually be removed and will allow to ensure IdentityManager is always backed by fake when using IdentityTestEnvironment). Also do some cleanup of the test: - use getter to fetch the different KeyedServices instead of storing pointer to the services as CWVSyncControllerTest member field - move initialisation and cleanup to constructor and destructor as this is preferred to overloading SetUp() and TearDown() - introduce a separate class TestIdentityManagerObserver to count the number of times OnRefreshTokenUpdatedForAccount() is called - remove unnecessary member field and duplicate initialisation This also required changing IOSWebViewSigninClient constructor to take a WebViewBrowserState* instead of the shared url loader factory and the cookie manager as the getter are creating the objects lazily which require properly initializing the network stack which is unnecessary for tests. Bug: 982259 Change-Id: Ia99bef652386d89f683db82a09c6d23cfe037ce6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695285Reviewed-by:John Wu <jzw@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/0cb36be6f6d3..80bb3116391c git log 0cb36be6f6d3..80bb3116391c --date=short --no-merges --format='%ad %ae %s' 2019-07-12 angle-autoroll@skia-public.iam.gserviceaccount.com Roll ./third_party/glslang/src c538b5d796fb..71892a5eda90 (1 commits) Created with: gclient setdep -r src/third_party/angle@80bb3116391c The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Bug: chromium:None Change-Id: I9e7dab8ef9c8308dcd1062d63b5ea91401b9f078 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699902Reviewed-by:
-
rajendrant authored
This CL includes tests for: - Testing that images and iframes with the attribute loading="lazy" are deferred until they come into view - Testing that images and iframes with the attribute loading="eager" are loaded immediately Bug: 916260 Change-Id: I323faa31c7683663d0d0136a719cf83c25758ad6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1417117 Commit-Queue: Dominic Farolino <dom@chromium.org> Reviewed-by:
Yoav Weiss <yoavweiss@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Dominic Farolino <dom@chromium.org> Cr-Commit-Position: refs/heads/master@{#676804}
-
Matthew Cary authored
The linux sandbox creates shared memory segments in SandboxIPCHandler::HandleMakeSharedMemorySegment. The wrinkle is that these segments may be created executable, which is done nowhere else in chrome. NaCl appears to be the only consumer of this feature, via NaClAppLoadModule / NaClAppLoadFile. The platform file descriptor backing the shared memory is extracted and shared via sendmsg() manually, rather than via a mojo or legacy IPC mechanism. This CL introduces a linux-only executable create for base::subtle::PlatformSharedMemoryRegion to be used for this purpose. The new create method has a stern comment, and is only exposed through the base::subtle API, in order to discourage wide usage. Bug: 795291 Change-Id: I9753c74b74c30d9873eb13415f4084ccf9b3fa35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695405 Commit-Queue: Matthew Cary (CET) <mattcary@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#676803}
-
Vadym Doroshenko authored
Bug: 975976, 945557 Change-Id: I41d8da642d12d18e8a22206384a534389c35b53a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1697483Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#676802}
-
Omer Katz authored
This CL optimizes pre-finalizer invocation. Previously, we would maintain pre-finalizers in a LinkedHashSet and invoke as follows: 1. Create a reversed copy of pre-finalizers in a Vector 2. Iterate the vector 2.a Invoke pre-finalizers on dead objects 2.b Remove dead objects from HashSet Instead, we now maintain pre-finalizers in a Deque and invoke as follows: 1. Iterate the deque backwards 2. Store non-pre-finalized (live) objects in a new Deque 3. Move the new Deque over. This improves performance on selected microbenchmarks by at least 25% (and up to 65%). Bug: 981043 Change-Id: I0f3e3bbbc9c75ca017b11c6d60f991b1a68b44be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1698465Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/master@{#676801}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Id12206148676581f9d8db65a8c5dea99261da53a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699322Reviewed-by:
-
Antonio Gomes authored
This is (likely) the last of the set of precursor CLs to pave the way to Onion souping webmediaplayer_ms{compositor}.cc. It is part of section 4.4.1 in the design doc [1]. [1] https://docs.google.com/document/d/1rHJGi1U72qZsOGIctIf7GKRaY8d7BgtVW8MaMYumzYY Note that as part of the move to blink, the CL also updates the signature of two methods, previously using GURL, banned in Blink: GetMediaURLScheme() and ReportMetrics(). BUG=704136 R=guidou@chromium.org, haraken@chromium.org Change-Id: I5f95c7749978f71781b0eb3b9c33a1ac80338054 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1698165Reviewed-by:Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Auto-Submit: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#676799}
-
Benoît Lizé authored
The foreground variant is enabled by default, and the background one unused. Simplify the code and the tests. As a side-effect, also remove the following histograms: - Memory.ParkableString.CompressionRatio - Memory.ParkableString.SavingsKb - Memory.ParkableString.TotalSizeKb Bug: 951773, 967546 Change-Id: Ia4c8a1753f59974a394d6fdb11e1ac5bfe65cac6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1697649Reviewed-by:
-
Tsuyoshi Horo authored
This CL introduces PageLoad.Clients.SignedExchange.AltSubSXG.* UMAs which are recorded when prefetched alternative subresource signed exchange is sent to the renderer process. Bug: 935267 Change-Id: Ifb74ce9c84e67eac9bc930d13ae86f719341500a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1697050 Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#676797}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/72dbab299e64..268589b895db Created with: gclient setdep -r src-internal@268589b895db The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=wjmaclean@google.com,mpearson@google.com,hayato@google.com,pmarko@google.com Change-Id: I714b674e5ca1e54fc1c392525a2e42c5bf9ce9c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699758Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#676796}
-
Ioana Pandele authored
This CL adds metrics to record whether a generated password is accepted or rejected together with whether it comes from automatic generation or manual generation. Bug:835234 Change-Id: I9d5c618f221f38e014324686b4be654679ebcce2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1683256Reviewed-by:
-
Hiroki Nakagawa authored
Non-NetworkService code is no longer used for shared workers. This CL removes it from content/renderer/worker/. For content/browser/worker_host/, see https://chromium-review.googlesource.com/c/chromium/src/+/1697522 NetworkService is not enabled by default on Android WebView yet, but this doesn't matter because shared workers are not available on Android yet (see https://crbug.com/154571). Bug: 983031 Change-Id: I4e900398d76a71b148abe61d812bfd393836bc32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699722 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#676794}
-
Dominic Battre authored
This CL removes calls to CallJavascriptFunctionUnsafe from the chrome://autofill-internals and chrome://password-manager-internals WebUI, which are not allowed. This required some clean up: Instead of AutofillInternalsLoggingImpl pushing events to a single WebUI, the WebUI now subscribes to events from the AutofillInternalsLogging, following the guidance of docs/webui_explainer.md. To allow Javascript function calls, the Javascript in the WebUI page needs to inform the native code that it has been loaded. The final step (not implemented in this CL) to clean this up further is to make the AutofillInternalsLogging not a global variable but a browser context keyed service. Bug: 928595 Change-Id: I2ea4d8a03217d50c4ee38dd9cd64266fffcb8111 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1698462 Commit-Queue: Dominic Battré <battre@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#676793}
-
Edvard Thörnros authored
A new test was added that tests that short animations still trigger some of their events when they should. No functionality was added or changed only a test. Bug: 379751, 981522 Change-Id: I7425c56ae528d9249fc0da76b47da1a5865e1571 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1697007 Auto-Submit: Edvard Thörnros <edvardt@opera.com> Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#676792}
-
wutao authored
Backdrop wallpaper handler used by wallpaper picker extension is in the folder of extensions. But the handler can be used by other ui component. This patch moves Backdrop wallpaper handler out of extensions so that the Ambient mode photo viewer can use the Backdrop service to get wallpapers. Bug: b/137228115 Test: manual Change-Id: Ia7053c2773557abbc3d849fea269c39fe621acce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1697067 Commit-Queue: Tao Wu <wutao@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#676791}
-
David Jean authored
- Moved ToT from 11.4.1 to 12.1 - Removed 11.4 tests from ios-simulator*.json and ios-slimnav.json Bug: 976348 Change-Id: I0897211be12d2975bb29c11feb46171369ac0dc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1683721Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: David Jean <djean@chromium.org> Cr-Commit-Position: refs/heads/master@{#676790}
-
Hayato Ito authored
Follow-up for https://crrev.com/c/1699523. TBR=katie@chromium.org,tikuta@chromium.org Bug: 983404 Change-Id: Ie73dda5e250825b9078ab9180734d65a462c114c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699726Reviewed-by:
Hayato Ito <hayato@chromium.org> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#676789}
-
Michael Lippautz authored
Tbr: haraken@chromium.org No-try: true Change-Id: Ib5fceb6ad910c69365234e4b2f40925a0510057d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699602Reviewed-by:
-
Yang Guo authored
This also includes fixes for JavaScript syntax highlighting. R=einbinder@chromium.org Bug: chromium:955550 Change-Id: Ia4412933c74e9c616fd55f08b302efc974610dd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1690872Reviewed-by:
Joel Einbinder <einbinder@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#676787}
-
David Staessens authored
This CL fixes a bug causing the video decoder thumbnail test to write the thumbnails image to the wrong path. When calling MakeAbsoluteFilePath() on a non-existing folder the path will always resolve to the current working directory. To fix this we need to first create the path before resolving it. This CL will also print the path of the output file, making it easier to locate. TEST=./video_decode_accelerator_tests on eve BUG=964168 Change-Id: I0f8a0c2eef1c26097bfd5072a303b7db149ac06f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695326 Commit-Queue: David Staessens <dstaessens@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#676786}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/2206e55a..22df64cc Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I2135a467703f93d19d1a2edff88bffbd12b9fc8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1698356Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/406751705ae2..72dbab299e64 Created with: gclient setdep -r src-internal@72dbab299e64 The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=wjmaclean@google.com,mpearson@google.com,hayato@google.com,pmarko@google.com Change-Id: I9e49999d8b2b08caac95b2b0e1f516afb6080ad5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699747Reviewed-by:
-
Alex Danilo authored
Changes the display of file operations that aren't copy or move so they actually work. Limit generation of operation complete panels to copy and move only. Doesn't make a lot of sense to generate them for 'delete' as the user has already interacted using the confirmation dialog. Bug: 947388 Change-Id: I3f880312681701b31fba820a0084b5000016cbf0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699702Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Alex Danilo <adanilo@chromium.org> Cr-Commit-Position: refs/heads/master@{#676783}
-
Gyuyoung Kim authored
Some files of //chrome/browser/ui have been including account_consistency_method.h even though they don't use AccountConsistencyMethod or DiceMethodGreaterOrEqual(). This CL removes all unnecessary account_consistency_method.h includes. Bug: 970268 Change-Id: Iae8b72f9c484e4af269fd139081ac78ee99d9507 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699488Reviewed-by:
-
Xiaocheng Hu authored
This patch changes the if-else blocks in the function into early return for better readability. Change-Id: I5003ae6f9ea86cbf8af937c0314478753ce3f758 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699035 Auto-Submit: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#676781}
-
David Staessens authored
This CL fixes an issue in the video_decode_accelerator_tests, where frames are being reused before rendering is done. This is most common on resolution changes, where video frames are incorrectly flagged for reuse while they are still being used. This causes random failures and crashes while validating video frames. TEST=./video_decode_accelerator_tests on nyan_big and eve BUG=964168 Change-Id: I351b56d01c91c8ecc060e1628d01381136de0a3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695325 Commit-Queue: David Staessens <dstaessens@chromium.org> Reviewed-by:
-
Henrique Ferreiro authored
account_info_unittest.cc and identity_utils_unittest.cc where accidentaly removed from the build in https://crrev.com/c/1687239. Bug: 952788 Change-Id: I2f82709aa1d1192a9ba4490f8b23ce5e72ebe1b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1698221 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
-
