Skip to content

GitLab

T
tangled
Switch branch/tag
  1. 09 Jul, 2016 27 commits
  3. 08 Jul, 2016 13 commits
    • thestig's avatar
      Use container::back() and container::pop_back(). · 96e7f36f
      thestig authored 
      Also convert !container.size() to container.empty().

TBR=alexclarke@chromium.org,eugenebut@chromium.org,reillyg@chromium.org,robertshield@chromium.org,rogerta@chromium.org,scheib@chromium.org,sky@chromium.org,wez@chromium.org

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review-Url: https://codereview.chromium.org/2070283002
Cr-Commit-Position: refs/heads/master@{#404539}
      96e7f36f
    • estade's avatar
      Avoid NOTREACHED in content settings bubble. · a9f6881d
      estade authored 
      BUG=626337

Review-Url: https://codereview.chromium.org/2130913002
Cr-Commit-Position: refs/heads/master@{#404538}
      a9f6881d
    • creis's avatar
      Update HistoryController::current_entry_ on all main frame back/forwards. · ab22bdfc
      creis authored 
      This fixes a case where it was left stale on a cross-origin commit
because the provisional_entry_ had been cleared by a different commit.

BUG=623319
TEST=See bug comment 14 for repro steps.
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2134493002
Cr-Commit-Position: refs/heads/master@{#404537}
      ab22bdfc
    • jsbell's avatar
      IndexedDB: Defer delete calls when there is a running upgrade · dd17e5be
      jsbell authored 
      Database open requests enter a limbo state when there is an upgrade
running - the request neither proceeds nor blocks, since there is no
successfully opened request to receive the "versionchange" event.
The same should be true for database delete requests, otherwise
either the delete happens during the upgrade (bad!) or is blocked but
the open connection is unaware of the request and can't close itself
(also bad!).

The spec is ambiguous here [1][2]; this change aligns Chrome's
behavior with Firefox.

[1] https://github.com/w3c/IndexedDB/issues/78
[2] https://github.com/w3c/IndexedDB/issues/79

R=palakj@chromium.org,cmumford@chromium.org
BUG=617963

Review-Url: https://codereview.chromium.org/2084053004
Cr-Commit-Position: refs/heads/master@{#404536}
      dd17e5be
    • kapishnikov's avatar
      Fixes in CrNet and Cronet frameworks · f7b51309
      kapishnikov authored 
      1. Port https://codereview.chromium.org/2115653002/
   to crnet_environment.mm
2. Port https://codereview.chromium.org/2110803002/ to
   crnet_environment.mm and cronet_environment.cc
3. Override CrNet FrameworkBundle, so that the icudtl.dat and
   IDS_ACCEPT_LANGUAGES can be read from the framework bundle itself.
4. Use base::mac::FrameworkBundle() instead of [NSBundle mainBundle].

Review-Url: https://codereview.chromium.org/2137623002
Cr-Commit-Position: refs/heads/master@{#404535}
      f7b51309
    • mark's avatar
      mac: Remove IsOSMavericksOrLater() · dd7e82fd
      mark authored 
      BUG=579255
R=erikchen@chromium.org,thakis@chromium.org
TBR=brettw@chromium.org

Review-Url: https://codereview.chromium.org/2137453003
Cr-Commit-Position: refs/heads/master@{#404534}
      dd7e82fd
    • rdevlin.cronin's avatar
      [GN docs] Add missing word in gn actions help string · bf462ea0
      rdevlin.cronin authored 
      gn actions help said "run a script a single time to produce or more
output files". Add the missing "one" to make this "one or more output
files".

BUG=None

Review-Url: https://codereview.chromium.org/2133873002
Cr-Commit-Position: refs/heads/master@{#404533}
      bf462ea0
    • miguelg's avatar
      Store the notification id as a string for Android notifications · e4c7e282
      miguelg authored 
      BUG=596161

Review-Url: https://codereview.chromium.org/2132023002
Cr-Commit-Position: refs/heads/master@{#404532}
      e4c7e282
    • rohitrao's avatar
      Disables some CRWWebController tests on iOS 10. · 9ebc13a3
      rohitrao authored 
      BUG=626688

Review-Url: https://codereview.chromium.org/2133313002
Cr-Commit-Position: refs/heads/master@{#404531}
      9ebc13a3
    • sebmarchand's avatar
      Revert of Move the Syzygy scripts out of //chrome/ (patchset #5 id:80001 of... · 6318d34b
      sebmarchand authored 
      Revert of Move the Syzygy scripts out of //chrome/ (patchset #5 id:80001 of https://codereview.chromium.org/2126673002/ )

Reason for revert:
It's breaking the Gyp Official build and I can't fix this right now.

BUG=626828

Original issue's description:
> Move the Syzygy scripts out of //chrome/
>
> Also move the syzygy_optimize and syzygy_asan GN templates to //build/win/syzygy so they can be reused in //content (without adding a dependency with //chrome).
>
> BUG=619086
>
> Committed: https://crrev.com/71a43cab53042f33d77fe8eebe8c2463a92f9758
> Cr-Commit-Position: refs/heads/master@{#404503}

TBR=chrisha@chromium.org,dpranke@chromium.org,gab@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=619086

Review-Url: https://codereview.chromium.org/2129333002
Cr-Commit-Position: refs/heads/master@{#404530}
      6318d34b
    • chrishtr's avatar
      Don't paint the stolen background of the body even when it has display:table-cell. · 4d17020d
      chrishtr authored 
      BUG=622795

Review-Url: https://codereview.chromium.org/2133803003
Cr-Commit-Position: refs/heads/master@{#404529}
      4d17020d
    • kapishnikov's avatar
      Fixed crashes in CrNetEnvironment::ConfigureSdchOnNetworkThread() · 6c799c44
      kapishnikov authored 
      Also, added a warning to [Cronet start] method.

BUG=583085

Review-Url: https://codereview.chromium.org/2134843002
Cr-Commit-Position: refs/heads/master@{#404528}
      6c799c44
    • danakj's avatar
      Revert of Refactoring: Merge VideoSenderConfig and AudioSenderConfig.... · eb8a7a07
      danakj authored 
      Revert of Refactoring: Merge VideoSenderConfig and AudioSenderConfig. (patchset #4 id:100001 of https://codereview.chromium.org/2113783002/ )

Reason for revert:
[1226/2497] CXX obj/media/cast/sender/cast_h264_vt_encoder_unittests.h264_vt_encoder_unittest.o
FAILED: obj/media/cast/sender/cast_h264_vt_encoder_unittests.h264_vt_encoder_unittest.o
/b/build/slave/cache/cipd/goma/gomacc ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF obj/media/cast/sender/cast_h264_vt_encoder_unittests.h264_vt_encoder_unittest.o.d -DV8_DEPRECATION_WARNINGS -D__ASSERT_MACROS_DEFINE_VERSIONS_WITHOUT_UNDERSCORE=0 -DCHROMIUM_BUILD -DCR_CLANG_REVISION=274369-1 -DCOMPONENT_BUILD -DUSE_LIBJPEG_TURBO=1 -DENABLE_WEBRTC=1 -DENABLE_MEDIA_ROUTER=1 -DENABLE_PEPPER_CDMS -DENABLE_NOTIFICATIONS -DUSE_EXTERNAL_POPUP_MENU -DFIELDTRIAL_TESTING_ENABLED -DENABLE_TASK_MANAGER=1 -DENABLE_EXTENSIONS=1 -DENABLE_PDF=1 -DENABLE_PLUGIN_INSTALLATION=1 -DENABLE_PLUGINS=1 -DENABLE_SESSION_SERVICE=1 -DENABLE_THEMES=1 -DENABLE_PRINTING=1 -DENABLE_BASIC_PRINTING=1 -DENABLE_PRINT_PREVIEW=1 -DENABLE_SPELLCHECK=1 -DUSE_BROWSER_SPELLCHECKER=1 -DENABLE_CAPTIVE_PORTAL_DETECTION=1 -DENABLE_SUPERVISED_USERS=1 -DENABLE_SERVICE_DISCOVERY=1 -DV8_USE_EXTERNAL_STARTUP_DATA -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL -DGTEST_HAS_POSIX_RE=0 -DGTEST_LANG_CXX11=0 -DPROTOBUF_USE_DLLS -DGOOGLE_PROTOBUF_NO_RTTI -DGOOGLE_PROTOBUF_NO_STATIC_INITIALIZER -DUNIT_TEST -DGTEST_HAS_RTTI=0 -DUSE_LIBPCI=1 -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -DDYNAMIC_ANNOTATIONS_ENABLED=1 -DWTF_USE_DYNAMIC_ANNOTATIONS=1 -Igen -I../.. -I../../third_party/khronos -I../../gpu -I../.. -I../../skia/config -Igen/angle -Igen/protoc_out -I../../third_party/protobuf/src -I../../testing/gmock/include -I../../testing/gtest/include -I../../third_party/ffmpeg/chromium/config/Chromium/mac/x64 -I../../third_party/ffmpeg -isysroot /b/build/slave/Mac_GYP__dbg_/build/src/build/mac_files/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.10.sdk -O0 -gdwarf-2 -fvisibility=hidden -Werror -mmacosx-version-min=10.7 -arch x86_64 -Wall -Wextra -Wno-unused-parameter -Wno-missing-field-initializers -Wno-selector-type-mismatch -Wpartial-availability -Wheader-hygiene -Wno-char-subscripts -Wno-unneeded-internal-declaration -Wno-covered-switch-default -Wstring-conversion -Wno-c++11-narrowing -Wno-deprecated-register -Wno-inconsistent-missing-override -Wno-shift-negative-value -Wno-undefined-var-template -Wno-nonportable-include-path -std=c++11 -stdlib=libc++ -fno-rtti -fno-exceptions -fvisibility-inlines-hidden -fno-threadsafe-statics -fcolor-diagnostics -Xclang -load -Xclang /b/build/slave/Mac_GYP__dbg_/build/src/third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.dylib -Xclang -add-plugin -Xclang find-bad-constructs -Xclang -plugin-arg-find-bad-constructs -Xclang check-templates -Xclang -plugin-arg-find-bad-constructs -Xclang follow-macro-expansion -Xclang -plugin-arg-find-bad-constructs -Xclang check-implicit-copy-ctors -fno-strict-aliasing -fstack-protector-strong  -c ../../media/cast/sender/h264_vt_encoder_unittest.cc -o obj/media/cast/sender/cast_h264_vt_encoder_unittests.h264_vt_encoder_unittest.o
../../media/cast/sender/h264_vt_encoder_unittest.cc:267:10: error: unknown type name 'VideoSenderConfig'; did you mean 'VideoDecoderConfig'?
  static VideoSenderConfig video_sender_config_;
         ^~~~~~~~~~~~~~~~~
         VideoDecoderConfig
../../media/base/video_decoder_config.h:26:20: note: 'VideoDecoderConfig' declared here
class MEDIA_EXPORT VideoDecoderConfig {
                   ^
../../media/cast/sender/h264_vt_encoder_unittest.cc:235:24: error: no matching constructor for initialization of 'media::cast::H264VideoToolboxEncoder'
    encoder_.reset(new H264VideoToolboxEncoder(
                       ^
../../media/cast/sender/h264_vt_encoder.h:38:3: note: candidate constructor not viable: no known conversion from 'media::VideoDecoderConfig' to 'const media::cast::FrameSenderConfig' for 2nd argument
  H264VideoToolboxEncoder(
  ^
../../media/cast/sender/h264_vt_encoder.h:125:28: note: candidate constructor not viable: requires 1 argument, but 3 were provided
  DISALLOW_COPY_AND_ASSIGN(H264VideoToolboxEncoder);
                           ^
../../media/cast/sender/h264_vt_encoder_unittest.cc:256:26: error: no viable overloaded '='
    video_sender_config_ = GetDefaultVideoSenderConfig();
    ~~~~~~~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../../media/base/video_decoder_config.h:26:20: note: candidate function (the implicit copy assignment operator) not viable: no known conversion from 'media::cast::FrameSenderConfig' to 'const media::VideoDecoderConfig' for 1st argument
class MEDIA_EXPORT VideoDecoderConfig {
                   ^
../../media/cast/sender/h264_vt_encoder_unittest.cc:257:26: error: reference to non-static member function must be called; did you mean to call it with no arguments?
    video_sender_config_.codec = CODEC_VIDEO_H264;
    ~~~~~~~~~~~~~~~~~~~~~^~~~~
                              ()
../../media/cast/sender/h264_vt_encoder_unittest.cc:257:32: error: expression is not assignable
    video_sender_config_.codec = CODEC_VIDEO_H264;
    ~~~~~~~~~~~~~~~~~~~~~~~~~~ ^
../../media/cast/sender/h264_vt_encoder_unittest.cc:283:1: error: unknown type name 'VideoSenderConfig'; did you mean 'VideoDecoderConfig'?
VideoSenderConfig H264VideoToolboxEncoderTest::video_sender_config_;
^~~~~~~~~~~~~~~~~
VideoDecoderConfig
../../media/base/video_decoder_config.h:26:20: note: 'VideoDecoderConfig' declared here
class MEDIA_EXPORT VideoDecoderConfig {
                   ^
6 errors generated.

Original issue's description:
> Refactoring: Merge VideoSenderConfig and AudioSenderConfig.
> In the CL: 1) VideoSenderConfig and AudioSenderConfig are merged to
> FrameSenderConfig. 2) CastRtpParams is removed . RtpParams is directly
> converted to/from FrameSenderConfig.
>
> BUG=530839
>
> Committed: https://crrev.com/4c97152e0f2b9bf5883d7ea7f149c932598c3afc
> Cr-Commit-Position: refs/heads/master@{#404520}

TBR=mek@chromium.org,miu@chromium.org,xjz@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=530839

Review-Url: https://codereview.chromium.org/2133223003
Cr-Commit-Position: refs/heads/master@{#404527}
      eb8a7a07