- 09 Mar, 2020 40 commits
-
-
Mason Freed authored
Bug: 1012108 Change-Id: Ic9a38aaae92ea1592a244283304608b429cf7bbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092933 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#748402}
-
Mohsen Izadi authored
Current diagram is a bit outdated and incomplete. The updated diagram: https://drive.google.com/file/d/1HHvLtZYou2-wjEmuwb2DmfVdO_t9PCPd/view Bug: 1055051 Change-Id: Id551cfd79372222af82b0e36a6aae598db24d269 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069850 Commit-Queue: Mohsen Izadi <mohsen@chromium.org> Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Cr-Commit-Position: refs/heads/master@{#748401}
-
Cliff Smolinsky authored
GDI patching (inconsistently) results in delayload crashes due to the sandbox restrictions applied to various processes. In an effort to catch all processes which need the patching, we applied it to all utility processes. However, this has proven to be too inclusive, as many of those processes have sandboxes which prevent this code from working properly. This change detects the sandbox type and only executes the patching if the sandbox type is ppapi, PrintCompositor, or PdfConversion. Bug: 1028670 Change-Id: I651f50d073a94bf3a7c1cfa9f01aa21761c68132 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083384Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#748400}
-
Tao Bai authored
Bug: 1059071 Change-Id: I6020bb00f73b402fb9a2ea95c11ed656d4aa9b55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092122Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Tao Bai <michaelbai@chromium.org> Cr-Commit-Position: refs/heads/master@{#748399}
-
Hazem Ashmawy authored
Use "Via-WebView-DevTools" label alongside "User-Submitted" label to explicitly track bugs filed using WebView DevTools. Fixed: 1057167 Test: Try open a crash report via the UI and see the labels fields in monorail Change-Id: Ib5efe130e7b08e444317c2f0774f3ed76e01ec98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095307 Commit-Queue: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Auto-Submit: Hazem Ashmawy <hazems@chromium.org> Cr-Commit-Position: refs/heads/master@{#748398}
-
Justin Cohen authored
This feature was dropped in lieu of the KeepRenderProcessAlive flag. TEST=Does not regress any of the WKWebView hidden test cases. Bug: 943569, 930123 Change-Id: Ia6ab0e83e808477d6dbc7498607036ac05a31899 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094468Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Auto-Submit: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#748397}
-
Manu Cornet authored
Bug: 1009638 Change-Id: I2f0671524fb3d0be94a5c2123b3273f738ffefb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093222Reviewed-by:
Andrew Xu <andrewxu@chromium.org> Commit-Queue: Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#748396}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/6190ec8363a0..85edfc8c8341 git log 6190ec8363a0..85edfc8c8341 --date=short --first-parent --format='%ad %ae %s' 2020-03-09 jalyn@microsoft.com Fix 'Add custom device' focus regression 2020-03-09 petermarshall@chromium.org [styles] Make radio button focus ring circular 2020-03-09 jalyn@microsoft.com Update module.schema.json and add missing action titles 2020-03-09 tvanderlippe@chromium.org Sort generated property values on keys 2020-03-09 jacktfranklin@chromium.org Move `self.mod` into `NumberUtilities` Created with: gclient setdep -r src/third_party/devtools-frontend/src@85edfc8c8341 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1039620,chromium:1050549,chromium:1052248,chromium:174309,chromium:920154 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I3382d4e1642b465e7f49a301c5486445c8f9c7ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095424Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#748395}
-
sauski authored
Adding a new collapsible radio toggle to the security page that includes a third safebrowsing option (enhanced), with more thorough explanations for this third option and the already available standard and disabled options. Bug: 1032584 Change-Id: I6e4732ae464120d3d264b141dbb172aa125f9824 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088851 Commit-Queue: Theodore Olsauskas-Warren <sauski@google.com> Auto-Submit: Sean Harrison <harrisonsean@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#748394}
-
Matthew Mourgos authored
Bug: 976949 Change-Id: Ie67e521cef4db401ae31a546862bb06912801abd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088638Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: Matthew Mourgos <mmourgos@chromium.org> Cr-Commit-Position: refs/heads/master@{#748393}
-
Jimmy Gong authored
- Future CL's will remove the app from the app drawer and launch the SWA from the printer settings page. - Currently using a temporary icon, will replace once UI mocks are available. - SWA is hidden behind a flag. Bug: 1053704 Change-Id: I576f119df3ceea52fac54da8e1ed035fdc2d3a3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078783 Commit-Queue: jimmy gong <jimmyxgong@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#748392}
-
jonross authored
The maps_pixel_test makes use of Skia Gold Triage links, but not only as an artifact. Not actual baselines. For those unfamiliar this can be confusing, as the lack of positive image in Skia, is juxtaposed with there only being a json of expectations in code search. To clarify this I'm adding some docs to the maps_integration_test.py to have a note that the actual pixel failures will be reported in the logs, and that the Skia Gold Triage is a supplimentary artifact. TEST=maps_pixel_test Change-Id: I1c802ba2d4d021890333cbe9c857e54824a0476a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095207 Commit-Queue: Jonathan Ross <jonross@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#748391}
-
Kevin McNee authored
This reverts commit d3cc8c2a. Reason for revert: Suspect for compile failure https://ci.chromium.org/p/chromium/builders/ci/android-archive-rel/9949? ../../content/shell/android/linker_test_apk/src/org/chromium/chromium_linker_test_apk/LinkerTests.java:16: error: cannot find symbol public class LinkerTests implements Linker.TestRunner { ^ symbol: class TestRunner location: class Linker Original change's description: > base/android: Remove linker tests support. > > The linker tests don't run on bots (and likely not locally either) and > do not support the latest library loading patterns. This is the first > step to remove them, as they add non-trivial complexity in the codebase. > > Bug: 1059707 > Change-Id: Ia14693419792f57dc4f65b2fc7f999e833aec42e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095059 > Reviewed-by: Yaron Friedman <yfriedman@chromium.org> > Reviewed-by: Egor Pasko <pasko@chromium.org> > Commit-Queue: Benoit L <lizeb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#748365} TBR=pasko@chromium.org,yfriedman@chromium.org,lizeb@chromium.org Change-Id: Ib45bd99a42903407e92dfb4a386b31ec0e7f7ee1 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1059707 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095777Reviewed-by:
Kevin McNee <mcnee@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#748390}
-
Michael van Ouwerkerk authored
Bug: 1030266 Change-Id: I50a93d7bdafea8034f8ace100e25d9d98e385a0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093480 Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#748389}
-
Dominik Inführ authored
Add accounting for global handles in memory dumps. Add UKM/UMA metrics for them as well to help uncover regressions and get some statistics. Privacy review doc: https://goo.gl/X5eYHh New metric: Memory.Experimental.Renderer2.V8.Main.GlobalHandles Change-Id: I5fba506fe9ce7f8b676f676f10f52f81f7a62639 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2084594Reviewed-by:
ssid <ssid@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Cr-Commit-Position: refs/heads/master@{#748388}
-
Cliff Smolinsky authored
In order to support updates to InitializePDF() to better scope the GDI patching to only processes which need it, this change creates a new sandbox type for PDF conversion which can be easily detected at runtime. Bug: 1028670 Change-Id: I5cd7cb252d638eb376127d2926e75bdd590ccb16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087855Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
-
Antonio Gomes authored
EnablePreferredSizeMode() was enabled for the old cocoa (non-views) based mac UI. This code is no longer needed after [1]. What is more, with recent conversion of ViewMsg_EnablePreferredSizeChangedMode to mojo [2], we actually fixed the fact that EnablePreferredSizeMode() was being called to provisional RenderView instances, and the mode was not being effectively transferred when the RenderView instanced transitioned to committed state. Prior to [2], then, the mode was simply not working. However, now that we made calls to EnablePreferredSizeMode() effective on Mac for provisional (and committed) RenderViews, a performance drop was observed on loading.desktop benchmark - see [2]. [1] https://chromium.googlesource.com/chromium/src/+/1515d1b6e029d3071b15ae2e89991de62db890e3 [2] https://crrev.com/c/2068699 [3] https://chromeperf.appspot.com/group_report?bug_id=1058975 This CL fixes the perf regression by removing calling EnablePreferredSizeMode() on Mac for provisional RenderViews. As a follow up WebContentsView::RenderViewCreated() declaration and overrides can be removed altogether. BUG=1058975, 1051155 R=dtapuska@chromium.org Change-Id: I14be481949b7e11b6eeba8fe9ac383729ec994b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092096Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Auto-Submit: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#748386}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-compile-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-compile-chrome BUG=762641 TBR=chrome-os-gardeners@google.com Change-Id: I8259fd8a9e265207846842369e28e7e06b870637 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095499Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#748385}
-
Ben Joyce authored
Now that Recyclerview has migrated to Androidx, can remove gridlayout. Bug: 1052460 Change-Id: I844e8cd1480b8eb648d0a9104266103e0051c1eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094543 Commit-Queue: benjamin joyce <bjoyce@google.com> Auto-Submit: benjamin joyce <bjoyce@google.com> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#748384}
-
Annie Liu authored
In blink we use -1 to represent infinite iterations for historical reasons. Rather, we should use std::numeric_limits<double>::infinity() to be more specification-complaint. CL based on crrev.com/c/1373409. Bug: 913662 Change-Id: I3b2ff0c44d36c03654d77784c3867555603b0576 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071100Reviewed-by:
Ian Vollick <vollick@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Reviewed-by:
Yi Gu <yigu@chromium.org> Reviewed-by:
Daniel Libby <dlibby@microsoft.com> Commit-Queue: Annie Liu <t-hunliu@microsoft.com> Cr-Commit-Position: refs/heads/master@{#748383}
-
Markus Handell authored
WebmMuxer feeds signed timestamps into a mkvmuxer method taking only unsigned timestamps. This turned into problems muxing data for the case the MediaRecorder was immediately paused on startup, and WebmMuxer would try to feed negative timestamps to mkvmuxer. The change makes sure we do not insert negative timestamps. Bug: 1045381, 1057810 Change-Id: I3ea00bb3f4d372e9f6ad4eeba484b0cb8a9582fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095071Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Markus Handell <handellm@google.com> Cr-Commit-Position: refs/heads/master@{#748382}
-
Robbie McElrath authored
This CL reduces the minimum amount of time between seed downloads from 24 to 12 hours. This should reduce the time taken for variations seeds to be distributed on WebView. 12 hours was chosen as a compromise between our need for quick seed distribution and resource usage on device. We may revisit this number based on the results of this change. Test: Manually verified with logs that 12h is used for timestamp check. Bug: 979075 Change-Id: I5b183f9970662468be1b214cf7d8cb6d4665041d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086263Reviewed-by:
Changwan Ryu <changwan@chromium.org> Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Cr-Commit-Position: refs/heads/master@{#748381}
-
Michael Thiessen authored
https://chromium-review.googlesource.com/c/chromium/src/+/1901591 made the test useless by changing the initialization order it was meant to test. That change is no longer necessary as scheme registration happens at JNI_Onload, so it can be reverted. Bug: 783819 Change-Id: I7543eee8e42c13cf2b675d97e29ef3cd14669e9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095558Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#748380}
-
Ryan Hansberry authored
Change-Id: I25d3bcf5cb68bc6c5a61f8a9fcb946924deef84a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092711Reviewed-by:
Miao-chen Chou <mcchou@chromium.org> Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#748379}
-
Scott Violet authored
This reverts commit 1dd4504b. Reason for revert: this test is still flaky. It failed twice in a row here: https://ci.chromium.org/p/chromium/builders/ci/Win10%20Tests%20x64/44908 and https://ci.chromium.org/p/chromium/builders/ci/Win10%20Tests%20x64/44907 . I am also able to reproduce the flake locally. Original change's description: > Regression test for null pointer deref. > > Bug: 1050801 > Change-Id: I67a09733abcc07e83031e05541b945ccdd56eece > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2073158 > Commit-Queue: Peter Kasting <pkasting@chromium.org> > Auto-Submit: Peter Kasting <pkasting@chromium.org> > Reviewed-by: Martin Šrámek <msramek@chromium.org> > Cr-Commit-Position: refs/heads/master@{#746908} TBR=pkasting@chromium.org,msramek@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1050801 Change-Id: Ic1e632a5e00a97e4d297217619194a0c3631d6cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095404Reviewed-by:
-
edchin authored
iOS flag owners were asked to claim ownership and state an expiry in this announcement email: https://groups.google.com/a/google.com/g/bling-team/c/7YC_3l6yEzo/m/1-iZg1fPAAAJ This is one of several CLs that adds iOS flag ownership information into flag-metadata.json. The owner of these flags was identified via git blame. A placeholder expiry milestone of M86 was added. Please either LGTM, or suggest a new owner and/or expiry. Bug: 1058614 Change-Id: I049a1e16fcd8ad7e3e85343cc01ba028f201c2f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095197 Commit-Queue: edchin <edchin@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#748377}
-
Hongchan Choi authored
In favor of the self-referencing patch, this mutex can be safely removed. Test: Ran the patch on a repro case from crbug.com/1029462 and saw no crash after 20 min. Bug: 1058555 Change-Id: I0335fa6c878f4ca7e52a03ed7eb6fc0891dfa3ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088491Reviewed-by:
Raymond Toy <rtoy@chromium.org> Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Hongchan Choi <hongchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#748376}
-
Samuel Huang authored
To aid in porting SuperSize to Python 3, this CL does the following: * Sort out int vs. float divisions. * Add "'from __future__ import division" to each python file (except mock files for testing). * For int division: Use "//" (was "/") * For float division: Ensure this can be inferred, by using float(), or float constants (e.g., 1024.0). * Change "except" variable assignment style. * Use "except Exception as e" (was "except Exception, e"). Bug: 1054018 Change-Id: I25925196fe33fc7f4ca28f126f180eb4060fa2b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094544 Commit-Queue: Samuel Huang <huangs@chromium.org> Reviewed-by: -
Henrique Nakashima authored
This reverts commit 4d4e25dd. Reason for revert: Causes crbug.com/1057586 because ChromeFeatureList is accessed before native loads. Original change's description: > [Prefetch notification service]: Java side and glue setup, feature flag. > > - Added a feature flag for the migration. > > - Added and hid new code path in OfflineNotificationBackgroundTask. > > - Created JNI bridge for gluing prefetch notification service in native. > > Bug: 1047037 > Change-Id: If7b728609f86665cfe6b4c61f521f7362000b292 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082087 > Reviewed-by: David Trainor <dtrainor@chromium.org> > Reviewed-by: Xing Liu <xingliu@chromium.org> > Commit-Queue: Hesen Zhang <hesen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#747323} TBR=dtrainor@chromium.org,sclittle@chromium.org,xingliu@chromium.org,hesen@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1047037 Change-Id: Ieefecde67de7d51dd12ae298debdc5a940c0d0db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095208Reviewed-by:
Henrique Nakashima <hnakashima@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#748374}
-
Fredrik Söderquist authored
We already have a "type tag" as part of the LayoutSVGResourceContainer handling, and can use that instead. Change-Id: I668a95abf214c744fe76a9377ab6db5ed71f249b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095068 Auto-Submit: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#748373}
-
Sophie Chang authored
Diff is to use DISABLED instead of DISABLE This is a reland of 564fad0b TBR=tbansal@chromium.org Original change's description: > Add feature flag for disabling local predictions > > This allows us to run the Client-Side Reactive Preconnect in the below > configs: > 1) Default - Local predictions only > 2) Local predictions with optimization guide filling in > 3) Optimization guide only > 4) No predictions > > Bug: 1050101 > Change-Id: I9eb87170aa0079f3384f1797b03cd3d850b1228e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094246 > Reviewed-by: Ryan Sturm <ryansturm@chromium.org> > Reviewed-by: Tarun Bansal <tbansal@chromium.org> > Commit-Queue: Sophie Chang <sophiechang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#748290} Bug: 1050101 Change-Id: I7f7fc036b313c3d8931754383cc1d17431b9cb9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095210Reviewed-by:
Sophie Chang <sophiechang@chromium.org> Commit-Queue: Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#748372}
-
Alain Michaud authored
Reason for revert: The flag has never been used and the underlying fix is being replaced by an upstream bluez fix which does not rely on this interface. Bug:None Test:Built Cq-Depend: chromium:1948095 Change-Id: Ieb8eec8b15b4931c49cddc3f288ed7d1723b437a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949152 Commit-Queue: Alain Michaud <alainm@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Sonny Sasaka <sonnysasaka@chromium.org> Cr-Commit-Position: refs/heads/master@{#748371}
-
Greg Thompson authored
BUG=1043624 Change-Id: I4941a0457a6cad84fe694c2fdd26ee3d3adfcdec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095062 Commit-Queue: Greg Thompson <grt@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#748370}
-
Sean Gilhuly authored
These tests are enabled using the GN arg "skia_use_dawn = true". Bug: 1021566 Change-Id: Ifeaa6c3bb0ab9fbfa74fb4946ef61227f6bfacd7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037346Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: Sean Gilhuly <sgilhuly@chromium.org> Cr-Commit-Position: refs/heads/master@{#748369}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/c5f5b9e95179..abdb603cd140 git log c5f5b9e95179..abdb603cd140 --date=short --first-parent --format='%ad %ae %s' 2020-03-09 bpastene@chromium.org Add betty-pi-arc to telemetry's list of test condition tags. Created with: gclient setdep -r src/third_party/catapult@abdb603cd140 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC nuskos@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: nuskos@google.com Change-Id: Id73c48dfdb581b4af0e29fe4b972f077befa934d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095423Reviewed-by:
-
Ehimare Okoyomon authored
Replaced string with the same one used on desktop. This string is clearer for toasts, preferences, and accessibility (TalkBack). Example: https://screenshot.googleplex.com/gZCvZkipoi3.png Bug: 1059718 Change-Id: I8860a37b23f879a22d4dedf1148647199b785ec0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091725Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Ehimare Okoyomon <eokoyomon@chromium.org> Cr-Commit-Position: refs/heads/master@{#748367}
-
Kelvin Jiang authored
This CL makes the "text" param in chrome.browserAction.setBadgeText optional. Setting text to be null (or not specifying it) removes the explicitly set badge text for a given tab. The tab's badge text will then be removed, or will show the default non-tab-specific badge text if set. Bug: 1002961 Change-Id: I7f9f4ef2ac3187fff0b06455fd4abcc1db0a5143 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067641 Commit-Queue: Kelvin Jiang <kelvinjiang@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#748366}
-
Benoît Lizé authored
The linker tests don't run on bots (and likely not locally either) and do not support the latest library loading patterns. This is the first step to remove them, as they add non-trivial complexity in the codebase. Bug: 1059707 Change-Id: Ia14693419792f57dc4f65b2fc7f999e833aec42e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095059Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Egor Pasko <pasko@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#748365}
-
W. James MacLean authored
This CL modifies OriginPolicyFetcher to enforce that Origin Policy manifests load with the mimetype application/originpolicy+json If an incorrect mime type is received, loading is aborted, and the OriginPolicy object is returned with an empty policy and status kNoPolicyApplies. Since this same pathway is hit if the manifest load returns 404, we can also set kNoPolicyApplies in that case as well, and a test is included for that. The test includes a valid CSP which, if applied, would lead the test to fail as eval() would not succeed. If the manifest is rejected due to its incorrect mimetype, then the test passes. Bug: 1051169 Change-Id: I59e5bde20c8a21a4fae8dbc3c6f58f34cb292195 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080696Reviewed-by:
Daniel Vogelheim <vogelheim@chromium.org> Reviewed-by:
Domenic Denicola <domenic@chromium.org> Commit-Queue: James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#748364}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/f87536c9de24..4e1d6ce38422 git log f87536c9de24..4e1d6ce38422 --date=short --first-parent --format='%ad %ae %s' 2020-03-09 danilchap@webrtc.org Rename java VideoCodecType to VideoCodecMimeType 2020-03-09 phoglund@webrtc.org Purge phoglund from most OWNERS files. 2020-03-09 brandtr@webrtc.org Add |rids| and |mid| printout to RtpConfig::ToString(). 2020-03-09 ilnik@webrtc.org Wire up internal libvpx VP9 scaler to statistics proxy Created with: gclient setdep -r src/third_party/webrtc@4e1d6ce38422 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I2aa7a3f27f170784408bfc6e03015d4961d31d1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095420Reviewed-by:
-
