- 01 Feb, 2018 40 commits
-
-
Sylvain Defresne authored
Add another section to explain that -d and -s arguments to iossim are optional and may require installing additional components in Xcode. Bug: none Change-Id: Iafb4e61d78be799f56862357e5e02c1d4f785dab Reviewed-on: https://chromium-review.googlesource.com/897484Reviewed-by:
Eric Noyau <noyau@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#533618}
-
Pavol Marko authored
Make ClientCertResolver track the last certificate that has been resolved for each network. ClientCertResolver now only notifies Observers with |network_properties_changed|=true if the network has not been resolved before, or if the resolved client certificate (or EAP identity string) actually changed. Bug: 765489 Test: chromeos_unittests --gtest_filter=ClientCertResolver* Change-Id: Ief557c95492f5b4906445f840fc29d6def73097a Reviewed-on: https://chromium-review.googlesource.com/888558 Commit-Queue: Pavol Marko <pmarko@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#533617}
-
Christian Dullweber authored
Deletions in the Storage UI on Android report as finished before LocalStorage has actually been deleted. The UI then incorrectly shows storage that should have been deleted. This CL adds a callback for LocalStorage deletions and waits until the callback is called before the UI is updated. Bug: 796151 Change-Id: I936a0bc4cbc189702aaeffa0dd63cd1fbf0e60c7 Reviewed-on: https://chromium-review.googlesource.com/850214Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
Dave Schuyler <dschuyler@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#533616}
-
Christian Dullweber authored
This reverts commit 33b07d13. Reason for revert: This change leads to crashes when sending feedback reports Original change's description: > Prevent opening a deleted profile > > When deleting a profile, the profile will be marked as deleted and all > browsing data is removed but the profile folder will remain until shutdown > and it still contains some data like bookmarks and settings. Using command > line arguments it is possible to open a new window for this profile. > This CL changes the profile manager to not return profiles that have > been deleted. Instead of opening a window for a deleted profile, > Chrome will refuse to open the window. > > Bug: 803643 > Change-Id: Iae3caf93b2895d23b90aeb6550197a81038a1ec6 > Reviewed-on: https://chromium-review.googlesource.com/883342 > Reviewed-by: Stefan Kuhne <skuhne@chromium.org> > Commit-Queue: Christian Dullweber <dullweber@chromium.org> > Cr-Commit-Position: refs/heads/master@{#532378} TBR=skuhne@chromium.org,dullweber@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 803643, 807745 Change-Id: I44ad772e3d1b7fc21ec9e414cd92c1d4b915a7af Reviewed-on: https://chromium-review.googlesource.com/897522Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#533615}
-
Mihai Sardarescu authored
Bug: NONE Change-Id: I4b711c95b4516b08519351a191ca16efa99b924f Reviewed-on: https://chromium-review.googlesource.com/895451Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#533614}
-
Kinuko Yasuda authored
Bug: 803774 Change-Id: I358d7311bf3aad9a9f96e56cadbd6b3b0dd31485 Reviewed-on: https://chromium-review.googlesource.com/890156 Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#533613}
-
Yang Guo authored
This reverts commit 7ef680c7. Reason for revert: Performance regression crbug.com/802401 Original change's description: > Do not use soon deprecated v8::ReturnValue::Set. > > Bug: v8:7289 > Change-Id: I4b7bc2640d8103b925a69e95b9687011084e0f46 > Reviewed-on: https://chromium-review.googlesource.com/863742 > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Commit-Queue: Yang Guo <yangguo@chromium.org> > Cr-Commit-Position: refs/heads/master@{#528947} TBR=haraken@chromium.org,yangguo@chromium.org,mlippautz@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: v8:7289 Change-Id: I5b8720c1eb460ffb2bd6d8774c0c3e7957d48ce5 Reviewed-on: https://chromium-review.googlesource.com/893358Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#533612}
-
Yuta Kitamura authored
Nobody (almost) uses the WebTaskRunner alias any more. It can be removed now. The files WebTaskRunner.{h,cpp} remain, since they contain several other functions. We would perhaps like to rename them. Bug: 794845 Change-Id: Ic9d358a4f852420e847fe9d7de7baa4689d2a087 Reviewed-on: https://chromium-review.googlesource.com/896728Reviewed-by:Alexander Timin <altimin@chromium.org> Commit-Queue: Yuta Kitamura <yutak@chromium.org> Cr-Commit-Position: refs/heads/master@{#533611}
-
Daniel Bratell authored
In jumbo builds many cc files compile in the same translation unit and then they share the same anonymous namespace. Having many variables with the same name will then result in compilation failures. In preparation for jumbo in chrome/browser, this patch renames all the chrome/browser kTrafficAnnotation variables so that they don't share the same name. This is an equivalent change to what was already done in //content a couple of months back. Bug: 746957 Change-Id: I4972cbb767720ac8114b9a01878df1f3ea32a735 Reviewed-on: https://chromium-review.googlesource.com/895369Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#533610}
-
Daniel Bratell authored
In jumbo builds many cc files compile in the same translation unit and then they share the same anonymous namespace. Having many variables with the same name will then result in compilation failures. In preparation for jumbo in chrome/browser, this patch renames two functions that fetch a DictionaryValue settings object so that they have different names. Bug: 746957 Change-Id: I109751abd13397b61e2eceaccbd95decf493d0c4 Reviewed-on: https://chromium-review.googlesource.com/895368Reviewed-by:
Raymes Khoury <raymes@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#533609}
-
Daniel Bratell authored
In jumbo builds many cc files compile in the same translation unit and then they share the same anonymous namespace. Having two methods with the same name will then result in compilation failures. In preparation for jumbo in chrome/browser, this patch renames some functions and metrics related to ssl interstitial pages. Bug: 746957 Change-Id: If8218168d38a7ddae9f2fcdb09b2956018aacd8f Reviewed-on: https://chromium-review.googlesource.com/895370Reviewed-by:
Emily Stark <estark@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#533608}
-
Hannes Payer authored
Bug: chromium:804279 Change-Id: I3e219c1ad295d0d2f636f089866cf213393d2295 Reviewed-on: https://chromium-review.googlesource.com/878373 Commit-Queue: Hannes Payer <hpayer@chromium.org> Reviewed-by:
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/c5c99c66..bcbf9928 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I4d13bc5eb230d1d085c49d466d5c57574285d2a5 Reviewed-on: https://chromium-review.googlesource.com/896448Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#533606}
-
Xianzhu Wang authored
- Update bug numbers and comments - Modify fast/multicol/border-radius-clipped-layer-expected.html to make it pass for both SPv1 and SPv175 (previously with one invisible pixel diff). - Rebaseline svg/hixie/perf/007.svg - enable virtual/prefer_compositing_to_lcd_text/compositing for flag-specific testing. Bug: 771643 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Ie56c6ea26672552594b7c83f0fc80252254daac3 Reviewed-on: https://chromium-review.googlesource.com/891426 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#533605}
-
Yoshifumi Inoue authored
This patch changes "4875189-2.html" to utilize |selection_test()| for ease of maintenance. Note: Following patch will rename this file to "replace_in_float.html". This patch is a preparation for the patch[1]. [1] http://crrev.com/c/737981 Introduce TextOffsetMapping to simplify word/paragraph selection Bug: 679977 Change-Id: I20cb0f4060cb6135e4fabb0c7a5bdfe0bcacf53e Reviewed-on: https://chromium-review.googlesource.com/897217Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#533604}
-
Yoshifumi Inoue authored
This patch renames "4960120-2.html" to "insert_line_break_at_end_of_anonymous_block.html" to provide what this test verifies from file name for improving code health. This is a follow-up the patch[1]. [1] http://crrev.com/c/892544 Rewrite editing/inserting/4960120-2.html to use selection_test() Bug: 679977 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: Ic3dd062e972b8bd07067916a520f6ca667163129 Reviewed-on: https://chromium-review.googlesource.com/897225Reviewed-by:
-
Koji Ishii authored
Following bot results are included. 3441 3449 16 lines were removed and 29 lines were deflaked by consecutive results since 3384. TBR=eae@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: Ibb9f9f1b9ce9e290f152bb72aec7104a27ba1dbd Reviewed-on: https://chromium-review.googlesource.com/897222 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#533602}
-
Raphael Kubo da Costa authored
We had been using the same checks for both object and any Web IDL types to determine if they were present, namely !(member.IsEmpty() || member.IsNull() || member.IsUndefined()) However, both `null' and `undefined' are valid values for the any type, and they should be considered distinct. Add a separate check for any types without the "member.IsNull()" part of the above one, so that one can pass `null' to an any member and get it back instead of `undefined'. Bug: 803448 Change-Id: I90dce8f0fc6c0f4d4764d724501a58cf26e92526 Reviewed-on: https://chromium-review.googlesource.com/895304Reviewed-by:Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/master@{#533601}
-
Koji Ishii authored
From yoichio's review for the reuslt 3333. https://docs.google.com/spreadsheets/d/1anBCj4MpgP4aY1MNJoJjshFl8-V2k4UIco-p-bhK2oQ/edit#gid=0 Excluded 3 tests that look like to have other issues. NOTRY=true Bug: 591099 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I31d0ae6bb10aced5299c18ffce42ba5aaf17272d Reviewed-on: https://chromium-review.googlesource.com/896664Reviewed-by:
-
Khushal authored
With sync scheduling, we don't have a draw deadline that can be used to predict whether the main thread will commit before it. Since the heuristic for detecting this does not for the sync scheduling case, currently we default to assume it to be slow and always perform the invalidation at the beginning of frame. This will result in more raster and block the main thread from committing. This change ensures that with sync compositing, we always defer the invalidation in order to merge with the main frame. R=brianderson@chromium.org Bug: 794986 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: If56ad4136de91d999dcf3423a90580ba64a1ccb1 Reviewed-on: https://chromium-review.googlesource.com/895188Reviewed-by:
Brian Anderson <brianderson@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#533599}
-
Xianzhu Wang authored
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I04bdf03c290f51cd349ffdc921e85d7996ed1759 Reviewed-on: https://chromium-review.googlesource.com/896027Reviewed-by:
-
Trent Apted authored
TBR=mmenke@chromium.org Bug: 807821 Change-Id: I0e3d42610cea3d87565550dee22e4806959d2893 Reviewed-on: https://chromium-review.googlesource.com/897302Reviewed-by:
-
Ramin Halavati authored
A bug is fixed in DEPS to download traffic annotation test executables on Windows, and the executables are updated. Bug: 690323 Change-Id: I0fca767d012f8bad37e0d38bc337aa9442b38a97 Reviewed-on: https://chromium-review.googlesource.com/895593Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#533596}
-
Ramin Halavati authored
'tools\clang\pylib\clang\compile_db.py' uses 'ninja' file to run ninja, while on windows 'ninja.exe' should be called. Change-Id: I2431aeb8b4c887acf0b8a0d8cafac83d062bda78 Reviewed-on: https://chromium-review.googlesource.com/894206Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#533595}
-
Takashi Toyoshima authored
CORSStatus.h is placed at public/platform, but is not used outside Blink. This patch is a mechanical change to move the CORSStatus.h to platform/loader/cors. Bug: 736308 Change-Id: I0febd97b85fe8ad9ce7866925831b043e494081d Reviewed-on: https://chromium-review.googlesource.com/892728Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#533594}
-
rbpotter authored
Add the highlighting of the search query in the destination change dialog for Print Preview. Refactor some highlighting code out of chrome/browser/resources/settings/search_settings.js in order to reuse it in print_preview. Bug: 773928 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Id79fdb23717c83337cc5e208331066f364b355bf Reviewed-on: https://chromium-review.googlesource.com/892209 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#533593}
-
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/539248475d66..b13fba7efb08 $ git log 539248475..b13fba7ef --date=short --no-merges --format='%ad %ae %s' 2018-01-31 mmoss Allow bools in gclient recipe custom_vars. 2018-01-31 mmoss Allow custom_vars to override vars in flattened output. Created with: roll-dep src/third_party/depot_tools The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: Ifde2934380453412d82d41e778eb5826907de19f Reviewed-on: https://chromium-review.googlesource.com/896548Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#533592}
-
Siddhartha authored
GetOrCreate dump is only used when the provider is not certain if the dump should be created. Multiple dumps should have unique IDs. BUG=791205 Change-Id: I46dec025517fb22f0b62a12d7e3ae64c45aa333a Reviewed-on: https://chromium-review.googlesource.com/892488 Commit-Queue: Siddhartha S <ssid@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#533591}
-
Xianzhu Wang authored
Consider <mask> element's bounds. Bug: 807379 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I2f78202095881318f9d8b09c190354ea2b9decd6 Reviewed-on: https://chromium-review.googlesource.com/896232 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Tien-Ren Chen <trchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#533590}
-
Kenneth Russell authored
NOTRY=true TBR=xlai@chromium.org Bug: 807742 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I28ca7cadaf38000f08ee1c93f6170271666e9b73 Reviewed-on: https://chromium-review.googlesource.com/896838 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#533589}
-
Alex Moshchuk authored
This is a reland of cd5b76ea. PrerenderBrowserTest.PrerenderWindowSize still failing after revert. Original change's description: > Allow navigations to opener's site to go back into opener SiteInstance. > > Previously, when a popup and its opener were cross-site, and neither > site required a dedicated process, navigating the popup back to the > opener's site did not swap processes, so the two ended up in different > processes and couldn't script each other. Even though > DetermineSiteInstanceForURL contains logic to place same-site popups > into their opener's SiteInstance (added as part of the fix for a > similar issue 796912), this logic was never reached because we never > attempted a process transfer in this case, thanks to > IsRendererTransferNeededForNavigation() returning false. > > This CL tweaks IsRendererTransferNeededForNavigation so that a > cross-process transfer is always attempted is such cases. This allows > DetermineSiteInstanceForURL to always place the popup that's going back > to its opener site into the opener's SiteInstance. > > Bug: 807184 > Change-Id: Ia4d8d8b2107d3b9e3b9329dd473c06d49b7bd5ec > Reviewed-on: https://chromium-review.googlesource.com/894369 > Reviewed-by: Charlie Reis <creis@chromium.org> > Commit-Queue: Alex Moshchuk <alexmos@chromium.org> > Cr-Commit-Position: refs/heads/master@{#533410} TBR=alexmos@chromium.org Bug: 807184, 807821 No-Presubmit: true No-Tree-Checks: true No-Try: true Change-Id: I7808cef9292ff069bcfdd00fe71883d321d7f577 Reviewed-on: https://chromium-review.googlesource.com/897262 Commit-Queue: Trent Apted <tapted@chromium.org> Reviewed-by:
-
Minh X. Nguyen authored
Bug: 722942 Change-Id: I3beee6eb439cc4ed0819771996ee4f9f4f09197f Reviewed-on: https://chromium-review.googlesource.com/877043 Commit-Queue: Minh Nguyen <mxnguyen@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#533587}
-
k2.nagaraju authored
updated idl file and VTTScanner updated test cases and expected results https://w3c.github.io/webvtt/#dom-vttregion-lines https://github.com/w3c/webvtt/pull/423 Bug: 755487 Change-Id: Ifd1ef26ede8cbc4f6bfe817aae9bce1191c18d24 Reviewed-on: https://chromium-review.googlesource.com/826666 Commit-Queue: srirama chandra sekhar <srirama.m@samsung.com> Reviewed-by:
srirama chandra sekhar <srirama.m@samsung.com> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#533586}
-
Kenneth Russell authored
Call it "trigger_multiple_dimensions.py" to be more accurate. Remove all GPU-specific references from the code. Update unit test. Change GPU buildbot JSON script to use the script in its new location and with its new command line args. Fixed pylint warnings that weren't caught by the presubmit checks in the script's original location. Add OWNERS for this new directory who are working on Swarming trigger scripts in various capacities. NOTRY=true Bug: 807810 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Iaed86ff2689e38a655d7969ce3899de3c6ebc998 Reviewed-on: https://chromium-review.googlesource.com/896831 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
-
Kent Tamura authored
#533442 updated html.idl, but didn't update interfaces-expected.txt. TBR=lukebjerring@chromium.org Bug: 807791 Change-Id: I220bdf89c5120598ae65747abb10bf71a8f6b52b Reviewed-on: https://chromium-review.googlesource.com/897164 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#533584}
-
Hayato Ito authored
Bug: 776656 Change-Id: I12b79d3867d313331507cd78bc8c75068c84ea3c Reviewed-on: https://chromium-review.googlesource.com/895027 Commit-Queue: Hayato Ito <hayato@chromium.org> Reviewed-by:
Takayoshi Kochi <kochi@chromium.org> Cr-Commit-Position: refs/heads/master@{#533583}
-
Kent Tamura authored
Fold them into their callsites. - Having complex logic in generated code is not nice. - Want to centralize custom-element-related code to Document.cpp or core/html/custom/. This CL has no behavior changes. Bug: 806641 Change-Id: Ie0e616715307d773c0733c5cef483454c5f86148 Reviewed-on: https://chromium-review.googlesource.com/897084Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#533582}
-
James West authored
- The MediaPipelineBackend::AudioDecoder interface allows SetConfig() to be called before SetDelegate(), but AudioDecoderSoftwareWrapper fails a DCHECK or potentially crashes if that happens. - AudioDecoderSoftwareWrapper::SetConfig() returns true if the codec is AC-3, E-AC-3, or DTS and the underlying audio decoder does not support them, and OnDecoderError() is later called on the DecoderDelegate. Those codecs cannot be decoded in software without a license, so SetConfig() should always return false if the underlying audio decoder does not support them. Bug: internal b/62147653 Test: cast_media_internal_unittests and smoke test on Chromecast Audio Change-Id: If351cb4e6bbd7cbe35550a559f032faafa8ed1b8 Reviewed-on: https://chromium-review.googlesource.com/896975Reviewed-by:
Stephen Lanham <slan@chromium.org> Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Commit-Queue: James West <jameswest@chromium.org> Cr-Commit-Position: refs/heads/master@{#533581}
-
Kazuhiro Inaba authored
The info was lost during a refactoring: 7803fe02870ac7833a30d3c71b15fe0aea159db BUG=807856 TEST=manually try the migration Change-Id: I5e986b53f099ce3c7c28bbb66fabf6eb7263521d Reviewed-on: https://chromium-review.googlesource.com/897066Reviewed-by:
Satoru Takabayashi <satorux@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Commit-Queue: Kazuhiro Inaba <kinaba@chromium.org> Cr-Commit-Position: refs/heads/master@{#533580}
-
Kenneth Russell authored
Fixed the suffixes for the two active histograms (BlacklistFeatureTestResults and BlacklistFeatureTestResultsWindows) and deleted an obsolete one (BlacklistFeatureTestResultsWin). NOTRY=true TBR=isherman@chromium.org Bug: None Change-Id: Ib5e372dfdf58acc5bc08c9bb17cacd938bd88c77 Reviewed-on: https://chromium-review.googlesource.com/882552 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#533579}
-
