- 01 Nov, 2017 40 commits
-
-
Greg Thompson authored
Tests in the interative_ui_tests fixture are known to timeout if there's an always-on-top window on the desktop. This change introduces a few improvements to the existing data collection strategy to help diagnose the provenance of these always-on-top windows. - Checks for always-on-top windows are moved out of the test child processes and up to the parent test proc. This is a more reliable place to log any info, as such log messages are more likely to make it into the main swarming log output. This is a result of the way GetTestOutputSnippet pulls what it thinks is the only relevant test output -- it drops messages emitted outside of the test body. - Scans for always-on-top windows now take place before running any test in the shard and after any test that times out. - A screen snapshot is saved if any always-on-top window is found, even in the case of dialogs that will be closed. - An attempt is made to find and emit the command lines for all processes in the process hierarchy of the proc owning an always-on-top window. - All details are emitted in a single log message. For example: There is an always on top window on the desktop after this test timed out. This may have been caused by this test or a previous test and may cause flakes; window class name: ConsoleWindowClass; subprocess command line: "".\interactive_ui_tests.exe" --brave-new-test-launcher --cfi-diag=0 --gtest_also_run_disabled_tests --gtest_filter=AutofillInteractiveTest.AutofillViaClick --single_process --snapshot-output-dir="e:\b\s\w\iomhwbd8" --test-launcher-bot-mode --test-launcher-output="C:\Users\CHROME~2\AppData\Local\Temp\scoped_dir6396_16240\results6396_26680\test_results.xml" --test-launcher-summary-output="e:\b\s\w\iomhwbd8\output.json" --user-data-dir="C:\Users\CHROME~2\AppData\Local\Temp\scoped_dir6396_16240\d6396_27306""; owning process lineage: (process_id: 2000, command_line: "C:\Windows\system32\cmd.exe /c ""C:\Users\chrome-bot\AppData\Roaming\Microsoft\Windows\Start Menu\Programs\Startup\run_swarm_bot.bat" ""), (process_id: 1496, command_line: "C:\Windows\Explorer.EXE"); screen snapshot saved to file: "e:\b\s\w\iomhwbd8\ss_20171030114011_636.png"; BUG=764415 R=sky@chromium.org Change-Id: I1aed3a41542680b197c7856e1f5d9ec9af6e3774 Reviewed-on: https://chromium-review.googlesource.com/737641Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#513095}
-
angle-deps-roller@chromium.org authored
https://chromium.googlesource.com/angle/angle.git/+log/c1f14fbea92b..e88ec8eed5a4 $ git log c1f14fbea..e88ec8eed --date=short --no-merges --format='%ad %ae %s' 2017-10-31 jmadill Vulkan: Refactor GarbageObject. Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.angle:android_angle_rel_ng,android_angle_deqp_rel_ng,linux_angle_rel_ng,linux_angle_dbg_ng,linux_angle_deqp_rel_ng,linux_angle_ozone_rel_ng,mac_angle_rel_ng,mac_angle_dbg_ng,win_angle_rel_ng,win_angle_dbg_ng,win_angle_x64_rel_ng,win_angle_x64_dbg_ng,win_angle_deqp_rel_ng,win_angle_x64_deqp_rel_ng;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: I9640a7405b0f235657dbf178862712f5c5c2dd60 Reviewed-on: https://chromium-review.googlesource.com/748903Reviewed-by:
angle-deps-roller . <angle-deps-roller@chromium.org> Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#513094}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/f3987906..51e24003 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I75b68b1278937a3d796bb263225cee9c0c13261d Reviewed-on: https://chromium-review.googlesource.com/748803Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#513093}
-
Makoto Shimazu authored
TBR=kochi@chromium.org Bug: 780386 Change-Id: If4286a902cde9c33ef04aebc648b9f5ad822601d Reviewed-on: https://chromium-review.googlesource.com/748462Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#513092}
-
Greg Thompson authored
This allows consumers of TestLauncher and content::LaunchTests to take action on child process timeout before the process is terminated. BUG=764415 R=phajdan.jr@chromium.org,sky@chromium.org Change-Id: Iccb359273c464f1e660a079af92edfc7feed817f Reviewed-on: https://chromium-review.googlesource.com/746701 Commit-Queue: Greg Thompson <grt@chromium.org> Reviewed-by:
-
Hayato Ito authored
Format js files by "clang-format -i <file>". TBR=kochi@chromium.org Change-Id: I28f5a0885688928dcb8b40e8f0abcedfdc6a30c5 Reviewed-on: https://chromium-review.googlesource.com/748921Reviewed-by:
Hayato Ito <hayato@chromium.org> Commit-Queue: Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#513090}
-
Greg Thompson authored
Originally, LaunchChildGTestProcess took a single callback that was run on the caller's thread when all processing was done for the child process. Eventually, a second callback was added to give consumers a chance to act immediately on process launch. This here change switches from two callbacks to an observer interface in preparation for a third observation point. BUG=764415 R=sky@chromium.org,phajdan.jr@chromium.org Change-Id: I38a8a99a78007d4598e650b85d9936beb1ef6a1e Reviewed-on: https://chromium-review.googlesource.com/746682 Commit-Queue: Greg Thompson <grt@chromium.org> Reviewed-by:
-
Scott Graham authored
Reverts the QEMU binary which caused a substantial perf regression on arm64 emu. TBR: wez@chromium.org Bug: 780096, 707030 Change-Id: Ib48849dcfb261205a6211c9eec0a9e2b997970cd Reviewed-on: https://chromium-review.googlesource.com/748682 Commit-Queue: Scott Graham <scottmg@chromium.org> Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#513088}
-
Aleks Totic authored
This patch computes static position in inline layout, and propagates OOFDescendants up the fragment tree. kojii: I've added NGInlineLayoutAlgorithm::CurrentDirection method. Rename suggestions welcome. Interesting bits: 1) LayoutBlock::LayoutPositionedObject LayoutBlock::LayoutPositionedObject had to be modified because it would relayout already positioned OOF. The way it decided relayout was needed was by positioning the element, and then comparing its position to position it already had. NG and Legacy would disagree here by a fraction of a pixel, and this would trigger relayout. My fix skips this check if LayoutNGBlockFlow is a containing block. 2) Failing tests: there are 23 new failures, and 159 passes. I've examined the failures. Will need help from inline team on 2a, 2b and 2c. 2a) DCHECK inline_size < 0 animations/interpolation/letter-spacing-interpolation.html animations/interpolation/word-spacing-interpolation.html fast/inline/empty-inline-create-linebox.html fast/text/text-large-negative-letter-spacing-with-opacity.html fast/text/text-letter-spacing.html fast/text/international/rtl-negative-letter-spacing.html css2.1/t0803-c5502-imrgn-r-03-b-a.html css2.1/t0804-c5507-ipadn-r-03-b-a.html 2b) bad static position. Block is being positioned by inline-layout-algorithm, instead of block-layout-algorithm. Should start a new line external/wpt/css/CSS2/normal-flow/block-non-replaced-width-001.xht external/wpt/css/CSS2/normal-flow/inline-block-replaced-height-004.xht external/wpt/css/CSS2/normal-flow/inline-block-replaced-height-005.xht external/wpt/css/CSS2/normal-flow/inline-block-replaced-height-007.xht external/wpt/css/CSS2/normal-flow/inline-replaced-height-004.xht external/wpt/css/CSS2/normal-flow/inline-replaced-height-005.xht external/wpt/css/CSS2/normal-flow/inline-replaced-height-007.xht fast/css/sticky/sticky-vertically-overconstrained.html 2c) <span> has many <br>. NG includes <br> in line height, Legacy does not. FF does not at all fast/replaced/absolute-position-percentage-height.html 2d) passes on reload. Content might not be laid out when document.onload() fires Fully correct (like FF), unlike Legacy which fails 2 tests. fast/box-sizing/replaced.html 2e) some relayout multicol weirdness fast/multicol/dynamic/relayout-abspos-in-relpos-spanner.html ietestcenter/css3/multicolumn/column-containing-block-001.htm ietestcenter/css3/multicolumn/column-width-applies-to-008.htm ietestcenter/css3/multicolumn/column-width-applies-to-014.htm 2f) unusual test: svg, shadow roots, i am not sure what is going on svg/foreign-object-under-shadow-root-under-hidden.html Bug: 740993 Change-Id: I0eab6ec0ee87bdb10c9a69df0e18f19bcaafef68 Reviewed-on: https://chromium-review.googlesource.com/738870 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#513087}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/a44b013a328d..611d48c1ed39 $ git log a44b013a3..611d48c1e --date=short --no-merges --format='%ad %ae %s' 2017-11-01 angle-deps-roller Roll skia/third_party/externals/angle2/ c1f14fbea..e88ec8eed (1 commit) Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=stani@chromium.org Change-Id: I29495753e4c20247d53bf90da3c27d0e35769a6f Reviewed-on: https://chromium-review.googlesource.com/748641Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#513086}
-
Tarun Bansal authored
QUIC usage and warmup URL fetching. Also, enable fetching of the warmup URL even if usage of QUIC proxies is disabled. Bug: 780117 Change-Id: I06706aed704701ca6f85553913b8cc94eb4a7afe Reviewed-on: https://chromium-review.googlesource.com/747131Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#513085}
-
Makoto Shimazu authored
This is following-on to crrev.com/c/746601 and crrev.com/c/747627. The original patch to disable the tests is missing to add MAYBE_ prefixes for each test. TBR=lazyboy@chromium.org Bug: 779973 Change-Id: Ib6a86f61972436034c84694ce87ebab763db7f89 Reviewed-on: https://chromium-review.googlesource.com/748402Reviewed-by:
-
Eddy Mead authored
Change-Id: I43488771e326310c2fd1775b8fac96ad6995b41a Reviewed-on: https://chromium-review.googlesource.com/748502Reviewed-by:
dstockwell <dstockwell@chromium.org> Commit-Queue: meade_UTC10 <meade@chromium.org> Cr-Commit-Position: refs/heads/master@{#513083}
-
Yutaka Hirano authored
Bug: 603396, 703483 Change-Id: I8b9c2ae5251670130e6c22be971fd610121be15e Reviewed-on: https://chromium-review.googlesource.com/748221Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#513082}
-
Makoto Shimazu authored
This test seems flaky when disabling browser-side-navigation according to the flakiness dashboard. TEST=interactive_ui_tests --gtest_filter=PopupBlockerBrowserTest.Regress427477 --disable-browser-side-navigation TBR=avi@chromium.org Bug: 780371 Change-Id: I2cd1027ebe8ce2d46919e8a492cda078417be935 Reviewed-on: https://chromium-review.googlesource.com/748503 Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
-
Lei Zhang authored
Most std::vector iteration can just be range-based For loops. TBR=zea@chromium.org Change-Id: Ibe18f8a088a27f41dbe0e38c40787bbcef28a7e2 Reviewed-on: https://chromium-review.googlesource.com/741545Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Stanislav Chiknavaryan <stanisc@chromium.org> Reviewed-by:
-
Hiroshige Hayashizaki authored
ScriptElementBase::InitiatorName() is "script" for both of HTMLScriptElement and SVGScriptElement. This CL replaces InitiatorName() with hard-coded "script" to reduce dependencies to ScriptElementBase. Bug: 777626 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I39bf17f0e95e169acf2cf4956c84d35b0511b618 Reviewed-on: https://chromium-review.googlesource.com/740873 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#513079}
-
Hajime Hoshi authored
This is one step of all replacings at https://chromium-review.googlesource.com/c/chromium/src/+/743663 Bug: 777775 Change-Id: Ib388098d7a6f3d1baa3b144734f470b0263f74f7 Reviewed-on: https://chromium-review.googlesource.com/748741Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#513078}
-
Yoichi Osato authored
This patch converts editing/selection/mouse/drag_focus_node.html with assert_selection to promote the use of w3c testharness and improve code health. Bug: 679977, 775701 Bug: Change-Id: Icde9911081d459ce53ac9155bedf98702b78b66c Reviewed-on: https://chromium-review.googlesource.com/746481 Commit-Queue: Yoichi Osato <yoichio@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#513077}
-
Brett Wilson authored
Enables the --experimental-tab-controlelr flag to use the new code path. Just enough is implemented to allow the tab strip to show and not crash. Changed the NotifyTypes enum in the TabStripModelImpl to use the latest style. Bug: 778461 Change-Id: I6e124044b0318c2d6b250ad86f796d570067e81a Reviewed-on: https://chromium-review.googlesource.com/747628Reviewed-by:
-
depot-tools-roller@chromium.org authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/5d790d53ea6e..70dea4270ec1 $ git log 5d790d53e..70dea4270 --date=short --no-merges --format='%ad %ae %s' 2017-10-31 hinoka Reland 2 "bot_update recipe: Upload source manifest" Created with: roll-dep src/third_party/depot_tools The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=phajdan.jr@chromium.org Change-Id: I210c7a84e2ed7cc91e42f37c2db52f62f0ddbef0 Reviewed-on: https://chromium-review.googlesource.com/748362Reviewed-by:
depot-tools-roller . <depot-tools-roller@chromium.org> Commit-Queue: depot-tools-roller . <depot-tools-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#513075}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/1facfc82..f3987906 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: Ie288a71e84e2380e42ab78add27b2d376ba8e08a Reviewed-on: https://chromium-review.googlesource.com/748066Reviewed-by:
-
Makoto Shimazu authored
ExtensionWebRequestApiTest.WebRequestUnloadImmediately in renderer_side_navigation_browser_tests is flaky on Linux/Mac. This disables it. TEST=browser_tests --disable-browser-side-navigation --gtest_filter=ExtensionWebRequestApiTest.WebRequestUnloadImmediately TBR=battre@chromium.org Bug: 780369 Change-Id: I61c32c1d35de888298d8344d0d367044ece64d39 Reviewed-on: https://chromium-review.googlesource.com/748661 Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
-
Peter Boström authored
"Close Firefox..." no longer mentions Chromium or Google Chrome so it can be used as a generic string. This fixes the current mismatch between Chromium/Google Chrome as only the former was updated for the new dialog string. Bug: chromium:754034 Change-Id: I4cfcf53057be681142ea8684a40b6b3eee33e436 Reviewed-on: https://chromium-review.googlesource.com/745310Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#513072}
-
angle-deps-roller@chromium.org authored
https://chromium.googlesource.com/angle/angle.git/+log/b8ee9dd35e60..c1f14fbea92b $ git log b8ee9dd35..c1f14fbea --date=short --no-merges --format='%ad %ae %s' 2017-10-28 oetuaho Remove empty switch statements from translated shaders Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.angle:android_angle_rel_ng,android_angle_deqp_rel_ng,linux_angle_rel_ng,linux_angle_dbg_ng,linux_angle_deqp_rel_ng,linux_angle_ozone_rel_ng,mac_angle_rel_ng,mac_angle_dbg_ng,win_angle_rel_ng,win_angle_dbg_ng,win_angle_x64_rel_ng,win_angle_x64_dbg_ng,win_angle_deqp_rel_ng,win_angle_x64_deqp_rel_ng;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: I2c824333a3d8549480054ab8d307ea579dc9f45c Reviewed-on: https://chromium-review.googlesource.com/748423Reviewed-by:
-
Michael Martis authored
This comprises: - Attaching an iOS language detection client (similar to the existing Content-based client) to each web state - Updating the language detection controller (which does the actual CLD) to notify the language detection client rather than translate code, and to use core datatypes (rather than iOS-specific ones) - Updating the translate driver to receive language info via a callback from the language detection client - Updating unit and integration tests to account for these changes Bug: 755856 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I7544863835d0d507a3e1453973f55c7fc918ba83 Reviewed-on: https://chromium-review.googlesource.com/740421 Commit-Queue: Michael Martis <martis@chromium.org> Reviewed-by:Renjie Liu <renjieliu@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#513070}
-
Tatsuhisa Yamaguchi authored
Bug: 761154 Test: gtest_filter=FileManagerJsTest.FileTasks:GenericTask/FileManagerBrowserTest.* Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I43b04bac3a5d5683d3a8c5afba71f19ce77c8231 Reviewed-on: https://chromium-review.googlesource.com/725959Reviewed-by:
Naoki Fukino <fukino@chromium.org> Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Cr-Commit-Position: refs/heads/master@{#513069}
-
Trent Apted authored
BookmarkBarInstructionsView::CalculatePreferredSize() was growing 25->30 pixels under SecondaryUiMd because Labels pick up a default minimum line height under Harmony. BookmarkBarInstructionsView should be using style::CONTEXT_BUTTON so that its text is consistent with the LabelButtons that normally appear in the bookmarks toolbar. That TextContext doesn't set line heights, so the height now stays the same. Bug: 713030 Change-Id: I5386755a8f1e77d91d95a9f03b86ce22d5f31c61 Reviewed-on: https://chromium-review.googlesource.com/746062 Commit-Queue: Trent Apted <tapted@chromium.org> Reviewed-by:
-
depot-tools-roller@chromium.org authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/47b67c426b1d..5d790d53ea6e $ git log 47b67c426..5d790d53e --date=short --no-merges --format='%ad %ae %s' 2017-11-01 hinoka Revert "Reland "bot_update recipe: Upload source manifest"" Created with: roll-dep src/third_party/depot_tools The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=phajdan.jr@chromium.org Change-Id: I14deb97c769ab25fa7363f5da9393dd4d21ae9a3 Reviewed-on: https://chromium-review.googlesource.com/748315Reviewed-by:
-
Yuke Liao authored
This CL fixes the accessibility id of the share menu button. Bug: Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I77885235b8185a4e8058fcc026f2bec6e511ef91 Reviewed-on: https://chromium-review.googlesource.com/747804Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#513066}
-
Patti authored
Make all page info combobox widths be the same as the longest currently displayed item, provided it doesn't exceed a max threshold. Screenshot - https://drive.google.com/file/d/0BzEa5HU1aAqBc1U4SjdhZnVONzA/view?usp=sharing Bug: 535074, 778088 Change-Id: I235e51e9b7d8c77eff43c5690c62e4008a411fef Reviewed-on: https://chromium-review.googlesource.com/730243Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Patti <patricialor@chromium.org> Cr-Commit-Position: refs/heads/master@{#513065}
-
Wez authored
Bug: 780317 Change-Id: I472b726726629139b57b73d7c010d9aa9744052b Reviewed-on: https://chromium-review.googlesource.com/748202Reviewed-by:
Scott Graham <scottmg@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#513064}
-
Yuki Awano authored
Bug: none Test: none Change-Id: I5045a725992f985050c230947d65c87eba9f7ee2 Reviewed-on: https://chromium-review.googlesource.com/745084Reviewed-by:
Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Commit-Queue: Yuki Awano <yawano@chromium.org> Cr-Commit-Position: refs/heads/master@{#513063}
-
Klaus Weidner authored
Add a gfx::BufferUsage parameter to the various creation methods in gpu_memory_buffer_impl_shared_memory for consistency and to facilitate sharing tests with implementations that use it. It appears that all call sites already have a "usage" parameter in scope, so it just needed to get passed through. (Split from http://crrev.com/c/680100 for AHardwareBuffer-based GpuMemoryBuffer) BUG=761432 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I33ab6255b4b0675fa5fb30b71ddbd10015bdae34 Reviewed-on: https://chromium-review.googlesource.com/747601Reviewed-by:
David Reveman <reveman@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#513062}
-
Wez authored
Bug: 772031 Change-Id: I77eb7d669be38a1163260c3487e61c9541cdca8d Reviewed-on: https://chromium-review.googlesource.com/748265Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#513061}
-
chrome-release-bot authored
TBR=anantha@chromium.org Change-Id: I83c579841ff5690a6bf6f9d14b97ed34b4159bd6 Reviewed-on: https://chromium-review.googlesource.com/748581Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#513060}
-
Brian White authored
This has been running only with sparse histograms for some time now and has been helpful in finding metrics that overflow. Now extend this to check the remaining bulk of histograms. While the original CL looked for many different reasons of acquiring a negative sample count, it's now known that there is only a single reason and so that is the only reason checked for here. Bug: 682680 Change-Id: I96785436468fdbe34f4221caf7a79da299edeca2 Reviewed-on: https://chromium-review.googlesource.com/741004Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#513059}
-
Christopher Lam authored
This CL adds a custom menu model for hosted app which has only the items that should be shown for a hosted app. It also adds 3 new commands which are currently disabled and will be implemented in a future CL. Bug: 762401 Change-Id: I7e53eb3d11042f267567e3773784c8594d7c7bee TBR: erg@chromium.org Reviewed-on: https://chromium-review.googlesource.com/721226 Commit-Queue: calamity <calamity@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Reviewed-by:
-
Junliang Yan authored
Bug: Change-Id: I96b5c9643c73a6ae37c40af1558f1520eb5201e4 Reviewed-on: https://chromium-review.googlesource.com/747513Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#513057}
-
Pawel Osciak authored
This is a reland of de566f6b Relanding with relevant *_EXPORTs added to fix the component build. Original change's description: > Add support for protected gpu memory buffers and a secure mode to ArcVDA. > > A protected gpu memory buffer is a buffer that can be referred to > by a GpuMemoryBufferHandle, which does not provide access to the buffer's > contents. Such handle can be shared with and received from clients that > should not have access to the buffer's contents. When such handle is > passed to the ProtectedGpuMemoryBufferManager service by its privileged > client, it can be translated into another GpuMemoryBufferHandle, which > allows access to the buffer. > > Also, implement a ProtectedMemoryManager to provide an allocation and > lookup service for such buffers for gbm. > > Finally, add secure mode API to the ArcVideoAccelerator stack and integrate > it with the above, to provide a secure codec mode implementation. > > TEST=E2E video playback tests > BUG=b:27174405,b:62575861,b:27204780 > > Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel > Change-Id: I80259db35463f7ed0cc3acc28bf767e55e46c8b8 > Reviewed-on: https://chromium-review.googlesource.com/689818 > Reviewed-by: Kuang-che Wu <kcwu@chromium.org> > Reviewed-by: Owen Lin <owenlin@chromium.org> > Reviewed-by: Hidehiko Abe <hidehiko@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Robert Kroeger <rjkroege@chromium.org> > Reviewed-by: David Reveman <reveman@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Antoine Labour <piman@chromium.org> > Reviewed-by: Jorge Lucangeli Obes <jorgelo@chromium.org> > Commit-Queue: Pawel Osciak <posciak@chromium.org> > Cr-Commit-Position: refs/heads/master@{#512797} Bug: b:27174405, b:62575861, b:27204780 Change-Id: I147aee03c72ea0d04def1f17ba88ea3a5abd50f6 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=kcwu@chromium.org,owenlin@chromium.org,hidehiko@chromium.org,sky@chromium.org,rjkroege@chromium.org,reveman@chromium.org,dcheng@chromium.org,jorgelo@chromium.org Change-Id: I147aee03c72ea0d04def1f17ba88ea3a5abd50f6 Reviewed-on: https://chromium-review.googlesource.com/748041Reviewed-by:
Pawel Osciak <posciak@chromium.org> Commit-Queue: Pawel Osciak <posciak@chromium.org> Cr-Commit-Position: refs/heads/master@{#513056}
-
