GitLab

Launcher_ClickOnAppListButton is generated both on launcher start and closing. Replaced (in sequencer) with Launcher_Show (new) and Launcher_Dismiss (see prev CL) pair.

Bug=712331

Review-Url: https://codereview.chromium.org/2854283005
Cr-Commit-Position: refs/heads/master@{#469477}

SurfaceDependencies is a type alias that was introduced in PendingFrameObserver
but is not used consistently making understanding types more difficult. This
CL simplify removes the type alias.

BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2861713003
Cr-Commit-Position: refs/heads/master@{#469476}

The functions are practically identical and this can be better handled with
an if statement.

R=jfernandez@igalia.com

Review-Url: https://codereview.chromium.org/2829303002
Cr-Commit-Position: refs/heads/master@{#469475}

Reporting is a spec for delivering out-of-band reports from various
other parts of the browser. See http://wicg.github.io/reporting/ for
the spec, or https://goo.gl/pygX5I for details of the planned
implementation in Chromium.

This CL plumbs from Chromium's browsing data removal code to Reporting
(and also makes a few tweaks to Reporting's browsing data removal).

BUG=704259

Review-Url: https://codereview.chromium.org/2829683004
Cr-Commit-Position: refs/heads/master@{#469474}

BUG=

Review-Url: https://codereview.chromium.org/2863733002
Cr-Commit-Position: refs/heads/master@{#469473}

Added crashing layout tests.

BUG=717019
TBR=ethannicholas@chromium.org

Review-Url: https://codereview.chromium.org/2862913003
Cr-Commit-Position: refs/heads/master@{#469472}

Follow up of http://crrev.com/2853433002 that removes fake c++ adapters
that are no longer used.

Review-Url: https://codereview.chromium.org/2856093002
Cr-Commit-Position: refs/heads/master@{#469471}

This reverts commit f07732ec
(https://codereview.chromium.org/2791933004)
and reapplies b6d0c9a0
(https://codereview.chromium.org/2690183002/).

BUG=653916
TBR=jam@chromium.org, rkaplow@chromium.org
Previously reviewed at https://codereview.chromium.org/2690183002/

Review-Url: https://codereview.chromium.org/2856583002
Cr-Original-Commit-Position: refs/heads/master@{#468376}
Committed: https://chromium.googlesource.com/chromium/src/+/3e27cb6e501ae55d614b56d566487590518ec223
Review-Url: https://codereview.chromium.org/2856583002
Cr-Commit-Position: refs/heads/master@{#469470}

BUG=715161
TEST=Manually tested with SRC/MSE playback (then checked about:://histograms)

Review-Url: https://codereview.chromium.org/2846693002
Cr-Commit-Position: refs/heads/master@{#469469}

Modify ScheduleDCLayers command to take an array of textures.  This will
allow using NV12 shared-memory GpuMemoryBuffers, which will have
separate Y and UV GLImages.

BUG=716286
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2849743002
Cr-Commit-Position: refs/heads/master@{#469468}

deqp/functional/gles3/multisample.html flakiness is supposed to be fixed
by https://codereview.chromium.org/2857953002/

BUG=714207
TBR=kbr@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2856403003
Cr-Commit-Position: refs/heads/master@{#469467}

https://skia.googlesource.com/skia.git/+log/59ad782b2b05..18f9602094ac

$ git log 59ad782b2..18f960209 --date=short --no-merges --format='%ad %ae %s'
2017-05-04 egdaniel Add support for Geom shaders in Vulkan backend.
2017-05-04 herb Factor out common code from sweep and linear.
2017-05-04 jvanverth Add ShadowUtils sample.
2017-05-04 benjaminwagner Marker for Windows NVIDIA driver update.

Created with:
  roll-dep src/third_party/skia


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=scroggo@chromium.org

Change-Id: Ide81efd89d01095d7389948976ed2b95afbb2722
Reviewed-on: https://chromium-review.googlesource.com/496546Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#469466}

BUG=710486
TBR=wjmaclean@chromium.org

Review-Url: https://codereview.chromium.org/2863633003
Cr-Commit-Position: refs/heads/master@{#469465}

Currently, mask SINGLE_TEXTURE_MASK UVs are determined solely by the size
of the masked layer. This means that if the mask texture size does not match the
expected texture size, we will end up squishing the mask when it's applied.

This CL adds a new out param, |resource_uv_size| to GetContentsResourceId. This
param represents the UV coordinate size of the mask contents within its texture.

This factor is used to adjust the existing calculation, allowing for non-exact mask
texture sizes.

R=sunxd@chromium.org, enne@chromium.org
BUG=713872
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2828353003
Cr-Commit-Position: refs/heads/master@{#469464}

This cl merges server change 154325175 by yasong.

BUG=488484

Review-Url: https://codereview.chromium.org/2861893002
Cr-Commit-Position: refs/heads/master@{#469463}

BUG=676220
R=peter@chromium.org
CC=thestig@chromium.org

Review-Url: https://codereview.chromium.org/2857293002
Cr-Commit-Position: refs/heads/master@{#469462}

In production, FileDescriptorWatchers can be leaky and post
BLOCK_SHUTDOWN tasks in response to their notification.

Stopping the service thread requires some non-trivial task lifetime
fixes to do it correctly, so this was deemed the next best quick fix
for redirection.

BUG=717380

Review-Url: https://codereview.chromium.org/2857103005
Cr-Commit-Position: refs/heads/master@{#469461}

The flakes are from 2011 and don't seem to happen on local runs. Deflake
the test.

BUG=368280,92292

Review-Url: https://codereview.chromium.org/2865503002
Cr-Commit-Position: refs/heads/master@{#469460}

BUG=714691

Review-Url: https://codereview.chromium.org/2866443002
Cr-Commit-Position: refs/heads/master@{#469459}

Adding NOTIMPLEMENTED() to BluetoothLowEnergyDeviceMac::IsConnectable() and
removing BluetoothLowEnergyDeviceMac::connectable_.

BUG=

Review-Url: https://codereview.chromium.org/2854733002
Cr-Commit-Position: refs/heads/master@{#469458}

This patch is to fix this scenario:
* Device: DidModifyServices notification
    - Chrome: Scan for primary services
* Device: DidDiscoverServices
    - Chrome: Scan for characteristics
* Device: DidModifyServices notification
    - Chrome: Scan for primary services
* Device: DidDiscoverCharacteristics
* Device: DidDiscoverServices
    - Chrome: Scan for characteristics
* Device: DidDiscoverCharacteristics

We need to wait until all the pending characteristic discoveries are done until we can start scanning
for descriptors. We need to make sure descriptors are not ready if DidModifyServices notification
is received while scanning for descriptors.

Adding discovery_pending_count_ in BluetoothRemoteGattServiceMac and BluetoothRemoteGattCharacteristicMac.
|is_discovery_complete_| can be set to true when discovery_pending_count_ is equal to 0.

BUG=690204

Review-Url: https://codereview.chromium.org/2638653002
Cr-Commit-Position: refs/heads/master@{#469457}

chrome/browser/resources/print_preview/settings/*

After this CL, there are 2 warnings and 222 errors when
running the closure compiler.

BUG=717620
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2861713004
Cr-Commit-Position: refs/heads/master@{#469456}

TBR=jbudorick@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2856123005
Cr-Commit-Position: refs/heads/master@{#469455}

This CL adds device_chooser watchlist.

BUG=None

Review-Url: https://codereview.chromium.org/2860153002
Cr-Commit-Position: refs/heads/master@{#469454}

Also use existing values from chrome/common/url_constants.h.

Review-Url: https://codereview.chromium.org/2855423002
Cr-Commit-Position: refs/heads/master@{#469453}

In preparation for making the ChildProcessConnection simpler, removing
the service number member from  BaseChildProcessConnection.
It is pertaining to the allocator, not the connection.

Also replaced the LruCache used for the moderate binding pool in
BindingManagerImpl (which was relying on the service number from the
connection) with a LinkedList. It makes the code clearer since we were
only using the LruCache to evict old connections, not the cache part.

BUG=689758

Review-Url: https://codereview.chromium.org/2855323003
Cr-Commit-Position: refs/heads/master@{#469452}

https://pdfium.googlesource.com/pdfium.git/+log/dcefccc9f0f2..cf53b788ca1c

$ git log dcefccc9f..cf53b788c --date=short --no-merges --format='%ad %ae %s'
2017-05-04 dsinclair Cleanup CXFA_RenderContext
2017-05-04 dsinclair Cleanup CFX_CharMap
2017-05-04 tsepez Remove CFX_GlyphMap

Created with:
  roll-dep src/third_party/pdfium


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


TBR=dsinclair@chromium.org

Change-Id: Ie4bc9e9977e2df14968ad260bb8e37b892c40b37
Reviewed-on: https://chromium-review.googlesource.com/495498
Reviewed-by: <pdfium-deps-roller@chromium.org>
Commit-Queue: <pdfium-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#469451}

Raster can be done on multiple threads at once, so it is not okay to
mutate a PaintOp while doing raster. This fixes the case of
RasterWithAlpha needing to change the PaintFlags back to having it make
a copy. To do this, we add a RasterWithFlags() static method to each
subclass of PaintOpWithFlags, and call that directly with the modified
flags when needed. These subclasses still need to provide a Raster()
method which just passes the |flags| member thru to the
RasterWithFlags().

Before MonochromePublic.apk: 79,762,639 bytes
After MonochromePublic.apk: 79,762,639 bytes

R=enne@chromium.org
BUG=718309
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2863673002
Cr-Commit-Position: refs/heads/master@{#469450}

Prior to this CL, the behavior of GeometryMapper version and non-GM
version of PaintLayerClipper was inconsistent with kIgnoreOverflowClip
when both CSS clip and overflow clip present on the painting root.

       | CSS clip | Overflow clip | Both
-------+----------+---------------+--------
GM     | Applied  | Skipped       | Skipped
Non-GM | Applied  | Skipped       | Applied

Also the GM-version applies only CSS clip when both present and
context.root_layer == layer_. (While non-GM applies both)

This CL changes the behavior so that both CSS clip and overflow clip are
ignored whether both or either one present. It is believed that it will
also fix a bug that prevented us from enabling impl-side scrolling on
scrollers that has CSS clip.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2856373002
Cr-Commit-Position: refs/heads/master@{#469449}

BUG=None

Review-Url: https://codereview.chromium.org/2855303003
Cr-Commit-Position: refs/heads/master@{#469448}

Plug in the JourneyLogger on the Desktop code and use it
to record CanMakePayment metrics.

BUG=716483

Review-Url: https://codereview.chromium.org/2851893002
Cr-Commit-Position: refs/heads/master@{#469447}

... instead of just chromium.android.json.

Review-Url: https://codereview.chromium.org/2848703002
Cr-Commit-Position: refs/heads/master@{#469446}

context: https://codereview.chromium.org/2851453003/

BUG=

Review-Url: https://codereview.chromium.org/2855333002
Cr-Commit-Position: refs/heads/master@{#469445}

It's possible for SkSurface creation of a bitmap to fail for various
reasons, although most commonly because it's too big.

RecordingImageBufferSurface and UnacceleratedImageBufferSurface
should handle the case when the SkSurface for the fallback
surface fails to be created.

Bug: 705498
Change-Id: I348ed2199403053d5690d8c3c0f07a80837f66e3
Reviewed-on: https://chromium-review.googlesource.com/493775
Commit-Queue: enne <enne@chromium.org>
Reviewed-by: Justin Novosad <junov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#469444}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/18b10cbe616e..d9a69250dacb

$ git log 18b10cbe6..d9a69250d --date=short --no-merges --format='%ad %ae %s'
2017-05-04 fmeawad Add lpy@ to tracing/OWNERS

Created with:
  roll-dep src/third_party/catapult


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: Ibba94d6833b39ac843a36d6f47d2dce8a50f3b88
Reviewed-on: https://chromium-review.googlesource.com/495499
Reviewed-by: <catapult-deps-roller@chromium.org>
Commit-Queue: <catapult-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#469443}

Adds |WindowTreeHostMusInitParams.use_classic_ime| to enable using
InputMethodChromeOS instead of InputMethodMus. Later we will wire this up
with a command line argument so we can use classic IME in --mus.

BUG=706913

Review-Url: https://codereview.chromium.org/2831583005
Cr-Commit-Position: refs/heads/master@{#469442}

For the logging of main intent metrics and creating NTPs due to
inactivity, we only want to do this if we believe the user came
from the launcher.  Chrome sends itself MAIN intents and those
should not be counted towards this.

We should follow up and remove dispatching MAIN intents to ourself
as a followup, but this is a step towards the intent of this logging
and behavior.

Adds a test that if we get a MAIN intent without the launcher
category, that we are not going to be waiting for a behavior to
be logged via the main intent tracker.

BUG=717754

Review-Url: https://codereview.chromium.org/2858043007
Cr-Commit-Position: refs/heads/master@{#469441}

The flakes are from 2011 and don't seem to be happening anymore. De-flake
the test.

BUG=91684

Review-Url: https://codereview.chromium.org/2864493002
Cr-Commit-Position: refs/heads/master@{#469440}

disable_display_vsync is read by GpuProcessTransportFactory and
TestCompositorFrameSink only. It is not used by Renderers so it should not be
in RendererSettings.

GpuProcessTransportFactory gets disable_display_vsync from command line switch
and stores it in disable_display_vsync_.

LayerTreeTest and its subclasses pass disable_display_vsync in to
TestCompositorFrameSink via its constructor. LayerTreeHostPerfTest overrides
LayerTreeTest::CreateCompositorFrameSink to set disable_display_vsync to true
to preserve behaviors.

BUG=717959
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=piman@chromium.org

Review-Url: https://codereview.chromium.org/2854953006
Cr-Commit-Position: refs/heads/master@{#469439}

The main change is to rename postmortem_report_extractor to stability_report_extractor, and pull it out to a separate target. We want to use this not only postmortem, but also on crash.

BUG=620813

Review-Url: https://codereview.chromium.org/2856923002
Cr-Commit-Position: refs/heads/master@{#469438}