GitLab

BUG=397741

Review URL: https://codereview.chromium.org/473553002

Cr-Commit-Position: refs/heads/master@{#289655}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289655 0039d316-1c4b-4281-b951-d872f2087c98

BUG=403083

Review URL: https://codereview.chromium.org/454053005

Cr-Commit-Position: refs/heads/master@{#289654}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289654 0039d316-1c4b-4281-b951-d872f2087c98

Format conversions are now handled internally by AP, allowing us to
to tear out the conversion code from MSAP. Instead, we use a simple
FIFO to buffer the incoming audio into the 10 ms chunks AP requires.

Add an AudioBus wrapper to get an array of channel pointers, since this
is the type AP deals in.

Add a few TODOs around two suspect areas: i) there appears to be an
assumption on the sink type based on the input format, and ii) don't
we want ProcessAndConsumeData() to output float data?

BUG=400933
TESTED=Audio processing behaves as expected on a MacBook, using both
44.1 and 48 kHz as the render and capture rates (set through "Audio
Midi Setup"). Audio sounds fine when processing is disabled through
constraints.

Review URL: https://codereview.chromium.org/420603004

Cr-Commit-Position: refs/heads/master@{#289653}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289653 0039d316-1c4b-4281-b951-d872f2087c98

Cr-Commit-Position: refs/heads/master@{#289652}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289652 0039d316-1c4b-4281-b951-d872f2087c98

There is no active profile in guest mode, thus we cannot call
avatar_menu->GetItemAt(avatar_menu->GetActiveProfileIndex()) in ProfileChooserView::ShowView unconditionally. Instead the call should be moved to CreateSwitchUserView where it is guaranteed that the current profile is signed in.

BUG=402119
R=noms@chromium.org, sky@chromium.org

Review URL: https://codereview.chromium.org/458893003

Cr-Commit-Position: refs/heads/master@{#289651}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289651 0039d316-1c4b-4281-b951-d872f2087c98

TBR=iannucci@chromium.org
NOTRY=true
BUG=402543

Review URL: https://codereview.chromium.org/458353003

Cr-Commit-Position: refs/heads/master@{#289650}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289650 0039d316-1c4b-4281-b951-d872f2087c98

BUG=399660
R=oshima@chromium.org

Review URL: https://codereview.chromium.org/475813002

Cr-Commit-Position: refs/heads/master@{#289649}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289649 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Remove unnecessary static function (patchset #2 of https://codereview.chromium.org/444983002/)

Reason for revert:
Perf regression, due to the method no longer being inline, and using doubles instead of floats.

Original issue's description:
> Remove unnecessary static function
> 
> Use gfx::CrossProduct() instead of defining a new static function.
> 
> BUG=
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288372

TBR=enne@chromium.org,heejin.r.chung@samsung.com
NOTREECHECKS=true
NOTRY=true
BUG=402552

Review URL: https://codereview.chromium.org/471113002

Cr-Commit-Position: refs/heads/master@{#289645}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289645 0039d316-1c4b-4281-b951-d872f2087c98

Cr-Commit-Position: refs/heads/master@{#289644}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289644 0039d316-1c4b-4281-b951-d872f2087c98

TBR=nduca@chromium.org

Review URL: https://codereview.chromium.org/469303002

Cr-Commit-Position: refs/heads/master@{#289643}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289643 0039d316-1c4b-4281-b951-d872f2087c98

Fixes:
base/android/linker/linker_jni.cc:300:  Single-parameter constructors should be marked explicit.  [runtime/explicit] [5]
base/android/linker/linker_jni.cc:313:  Weird number of spaces at line-start.  Are you using a 2-space indent?  [whitespace/indent] [3]
base/android/linker/linker_jni.cc:319:  Weird number of spaces at line-start.  Are you using a 2-space indent?  [whitespace/indent] [3]
base/android/linker/linker_jni.cc:320:  Weird number of spaces at line-start.  Are you using a 2-space indent?  [whitespace/indent] [3]

BUG=

Review URL: https://codereview.chromium.org/470943002

Cr-Commit-Position: refs/heads/master@{#289642}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289642 0039d316-1c4b-4281-b951-d872f2087c98

Cr-Commit-Position: refs/heads/master@{#289641}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289641 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=180192:180219&mode=html
TBR=zerny@chromium.org,adamk@chromium.org
BUG=

Review URL: https://codereview.chromium.org/477503002

Cr-Commit-Position: refs/heads/master@{#289640}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289640 0039d316-1c4b-4281-b951-d872f2087c98

GetProfileByUserUnsafe was called to yearly sometimes, when profile was not
created yet. I replaced GetProfileByUserUnsafe with GetProfileByUser and added
check that it is not NULL.

BUG=361528

Review URL: https://codereview.chromium.org/460233004

Cr-Commit-Position: refs/heads/master@{#289639}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289639 0039d316-1c4b-4281-b951-d872f2087c98

I see it sometimes failing on try jobs even with reruns. i.e.
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_swarming/builds/1619
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_swarming/builds/1672

BUG=128961
TBR=sky@chromium.org

Review URL: https://codereview.chromium.org/473733004

Cr-Commit-Position: refs/heads/master@{#289638}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289638 0039d316-1c4b-4281-b951-d872f2087c98

the cookies.
Before, in the password manager python tests, each website had its
own way to logout (ex: click on a button or follow a link). This cl
allows to have the same logout mechanism for all the websites
thought cleaning cookies because this makes creating and maintaining
tests simpler. It makes also the tests more robust.

TBR=vabr@chromium.org
BUG=403746

Review URL: https://codereview.chromium.org/472823002

Cr-Commit-Position: refs/heads/master@{#289637}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289637 0039d316-1c4b-4281-b951-d872f2087c98

- remove the profile preference that used to keep track of showing the
tutorial any time the user manager was shown for a particular profile.

- show the upgrade bubble for local profiles as well (so that local profiles
have a chance to see the tutorial)

- for the local profiles upgrade bubble, don't show the "Not you?" link as
it doesn't really make sense.

BUG=399679
TBR=rpetterson@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288817

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289005

Review URL: https://codereview.chromium.org/454153002

Cr-Commit-Position: refs/heads/master@{#289636}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289636 0039d316-1c4b-4281-b951-d872f2087c98

Implementation of the Battery Status API for the Windows platform.
Implementation uses a message window to receive battery notifications.
On versions prior to Vista there is limited support as the
RegisterPowerSettingNotification function is not available.

BUG=122593
TEST=http://jsbin.com/battery-status-test (manual)

Review URL: https://codereview.chromium.org/447853002

Cr-Commit-Position: refs/heads/master@{#289634}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289634 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_swarming/builds/1633

BUG=55915
TBR=avi@chromium.org

Review URL: https://codereview.chromium.org/470953003

Cr-Commit-Position: refs/heads/master@{#289632}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289632 0039d316-1c4b-4281-b951-d872f2087c98

This prefix was added in https://src.chromium.org/viewvc/chrome?revision=207246&view=revision,
and even then it was a no-op. Despite the no-op-ness, the test flakiness
was fixed over a year ago (see bug).

Now the prefix serves only to it only serves to confuse sheriff-o-matic.

BUG=251742
TBR=ojan@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/475063002

Cr-Commit-Position: refs/heads/master@{#289631}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289631 0039d316-1c4b-4281-b951-d872f2087c98

Usign an empty scopes set leads to a server response "code: BAD_REQUEST,
http status: 400, MISSING_SCOPE" on iOS. This CL uses a non-empty
scopes set for the account id tracker.

BUG=NONE

Review URL: https://codereview.chromium.org/472773002

Cr-Commit-Position: refs/heads/master@{#289630}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289630 0039d316-1c4b-4281-b951-d872f2087c98

BUG=402766
TBR=xhwang@chromium.org

Review URL: https://codereview.chromium.org/476683003

Cr-Commit-Position: refs/heads/master@{#289628}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289628 0039d316-1c4b-4281-b951-d872f2087c98

R=darin@chromium.org

Review URL: https://codereview.chromium.org/472903002

Cr-Commit-Position: refs/heads/master@{#289627}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289627 0039d316-1c4b-4281-b951-d872f2087c98

GetOpenFileName can cause 3rd-party shell extensions to be loaded into the caller's process. By putting it in a separate process we protect the browser process from potential instability.

BUG=73098

Review URL: https://codereview.chromium.org/419523006

Cr-Commit-Position: refs/heads/master@{#289625}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289625 0039d316-1c4b-4281-b951-d872f2087c98

This change adds atomic operations for MIPS64.

BUG=400684

Review URL: https://codereview.chromium.org/450343002

Cr-Commit-Position: refs/heads/master@{#289624}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289624 0039d316-1c4b-4281-b951-d872f2087c98

Extensions won't get installed if they declare a managed storage schema
and the schema is invalid. But if the schema is modified or deleted
after the extension is installed then this CHECK will be hit whenever
Chrome restarts.

If the schema is modified or becomes invalid then the managed storage
API won't pickup the right policies for the extension, but that's
better than crashing the browser.

BUG=399208

Review URL: https://codereview.chromium.org/464893002

Cr-Commit-Position: refs/heads/master@{#289623}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289623 0039d316-1c4b-4281-b951-d872f2087c98

The CL adds tests for 

 * Copy
 * Delete
 * Zip

operations of the class.

BUG=315439
TEST=run the test

Review URL: https://codereview.chromium.org/460963002

Cr-Commit-Position: refs/heads/master@{#289622}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289622 0039d316-1c4b-4281-b951-d872f2087c98

The feature will work only when the flag is on.

BUG=305511
TEST=Confirms the cast icon doesn't appear when the flag is off.

Review URL: https://codereview.chromium.org/471903002

Cr-Commit-Position: refs/heads/master@{#289621}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289621 0039d316-1c4b-4281-b951-d872f2087c98

TBR=asvitkine@chromium.org
BUG=None

Review URL: https://codereview.chromium.org/475653002

Cr-Commit-Position: refs/heads/master@{#289620}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289620 0039d316-1c4b-4281-b951-d872f2087c98

BUG=388504
TEST=build
TBR=sky@chromium.org for include fix under chrome/browser

Review URL: https://codereview.chromium.org/470523002

Cr-Commit-Position: refs/heads/master@{#289619}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289619 0039d316-1c4b-4281-b951-d872f2087c98

Due to the latency of running separate shell commands, the length of a test
could sometimes be largely incorrect with respect to the cpu idle sample
times, causing c-state residency percent of some states to be several
points below zero.

BUG=336561

Review URL: https://codereview.chromium.org/425133002

Cr-Commit-Position: refs/heads/master@{#289618}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289618 0039d316-1c4b-4281-b951-d872f2087c98

R=pbos@chromium.org, ronghuawu@chromium.org
TBR=ronghuawu@chromium.org
BUG=

Review URL: https://codereview.chromium.org/475833002

Cr-Commit-Position: refs/heads/master@{#289617}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289617 0039d316-1c4b-4281-b951-d872f2087c98

This eliminates the ENABLED_COMPONENT state, and fixes the path CHECK failure.

BUG=402377

Review URL: https://codereview.chromium.org/462533002

Cr-Commit-Position: refs/heads/master@{#289616}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289616 0039d316-1c4b-4281-b951-d872f2087c98

BUG=311897

Review URL: https://codereview.chromium.org/463113002

Cr-Commit-Position: refs/heads/master@{#289615}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289615 0039d316-1c4b-4281-b951-d872f2087c98

The URLFetcher will send an X-Privet-Auth token, which it gets from the
delegate, for PrivetV3. It will not send an X-Privet-Token.

BUG=

Review URL: https://codereview.chromium.org/454623002

Cr-Commit-Position: refs/heads/master@{#289614}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289614 0039d316-1c4b-4281-b951-d872f2087c98

This is the last patch to get the About overlay showing in the Settings page
on Chrome OS when Settings in a window is enabled, so that we can hide the
uber navigation frame and truly display Settings in its own window.

BUG=379348
R=dbeam@chromium.org,ben@chromium.org

ben: please review:
    chrome/browser/browser_about_handler.cc
i hope i'm not doing anything blasphemous here!

Review URL: https://codereview.chromium.org/449623003

Cr-Commit-Position: refs/heads/master@{#289613}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289613 0039d316-1c4b-4281-b951-d872f2087c98

According to http://chromium-build-logs.appspot.com/gtest_query?gtest_query=ServiceWorkerBrowserTest.Reload this test failed only on Android after r288301.

BUG=393486

Review URL: https://codereview.chromium.org/475543005

Cr-Commit-Position: refs/heads/master@{#289610}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289610 0039d316-1c4b-4281-b951-d872f2087c98

This reduces telemetry_perf_unittests by 30s.

BUG=388256

Review URL: https://codereview.chromium.org/474493002

Cr-Commit-Position: refs/heads/master@{#289609}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289609 0039d316-1c4b-4281-b951-d872f2087c98

BUG=402931
TEST=manually tested

Review URL: https://codereview.chromium.org/477603002

Cr-Commit-Position: refs/heads/master@{#289608}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289608 0039d316-1c4b-4281-b951-d872f2087c98

Nothing sets or uses the position, its name suggests nothing will.

R=enne

Review URL: https://codereview.chromium.org/470753002

Cr-Commit-Position: refs/heads/master@{#289607}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289607 0039d316-1c4b-4281-b951-d872f2087c98