GitLab

This adds the capability to replace a dialog's ModelList while the
dialog is being displayed. More details can be found in the crbug.

Bug: 993528
Change-Id: I43f8934cd4e138f7a4b99e1ad923b7515dacb46b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758547Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689174}

This change:
1) Removes some stub code that was trying to disable a test
2) Fixes SwitchTabsMac on 10.14+, where SendGlobalKeyEventsAndWait CHECKs

Bug: 852232
Change-Id: I304c12488de83dcf6c361018f359c776a23cf1d0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762485
Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689173}

This CL makes AppCache for frames use new BrowserInterfaceBrokerProxy mechanism
instead of DocumentInterfaceBroker.

Before this CL, AppCache used DocumentInterfaceBroker for frames, and
BrowserInterfaceBrokerProxy for workers. That complicated the code. After this
CL, both frames and workers use the same BrowserInterfaceBrokerProxy mechanism.

Relevant CL for AppCache for workers: https://crrev.com/c/1746128

Bug: 936482
Change-Id: I6f30ddec6d2055c9e4748c42a41c031f6c220b82
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758038
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689172}

This patch fixes logic for snapping layers to physical pixel boundaries,
when pixel canvas is not enabled, by allowing the subpixel offset to be
dynamically computed. Previously, layers could get stuck at 100% DPI
pixel boundaries (making some UI blurry on platforms where fractional
scale factors are used, e.g. Windows), as once an explicit value was
set, the offset would no longer be dynamically computed.

This patch
 - Updates SnapLayerToPixelBoundary to stop View from setting explicit
   subpixel offsets for non-pixel-canvas platforms so that they may be
   auto computed.
 - Updates view_unittest.

Bug: 992730
Change-Id: I8e8c87107f13157e92f125bcfb281226ebc6c422
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761301Reviewed-by: Malay Keshav <malaykeshav@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Brian Liu Xu <brx@microsoft.com>
Auto-Submit: Brian Liu Xu <brx@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#689171}

Moved the key for this pref and the logic for getting / setting it from
ScriptingPermissionsModifier to ExtensionPrefs. This lays the groundwork
for making it cleaner to set this value on installation if permissions
were withheld on installation.

Bug: 984069
Change-Id: I5580dfbdd57f4e2a3e92dd7b62b02bf04b35fee9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762720Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Tim Judkins <tjudkins@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689170}

Ensures that apps with tabs still have the expected
tab grab width.

Bug: 846546
Change-Id: I43660db954cceb7097bae7998f030da2aa5e22cc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763269
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689169}

Add an activity to show a list of recent WebView crashes ordered by the
time they are captured.

It's a simple ListView where each item is a TextView that shows:
- Crash Upload ID (if the crash is uploaded).
- Crash Upload time (if the crash is uploaded).
- Crash Upload Status.
- Crash Local ID (unique id for the crash report on the device).
- Crash Capture time (the time when the crash is captured).
- App Package Name (the package name where the crash took place).
- Variations (experiments keys that were running when the crash
  happened).

A report button is only enabled for uploaded crashes to provide more
info about the crash. It opens a webpage to open an issue on crbug.com
using "WebView Bugs" template quoting crash-upload-id.

Bug: 948923
Bug: 990189
Binary-Size: This change adds a new ui activity to webview, it also adds many strings which probably caused that large increase in binary size. However, all these strings are marked as not translatable so this should significantly cut down the size increase estimated by the bot.
Change-Id: Ie09b4a95da4a2cc60898b69f69f7fde04420240e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700202Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Reviewed-by: Nate Fischer <ntfschr@chromium.org>
Commit-Queue: Hazem Ashmawy <hazems@chromium.org>
Auto-Submit: Hazem Ashmawy <hazems@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689168}

Using wpt-import in Chromium 0641cddc.
With Chromium commits locally applied on WPT:
1194775a "Add ability to block same-origin access via document-access feature policy"
ecaae252 "Code health refactoring of animation.cc."
ff24116c "[css-layout-api] Re-add LayoutEdges."


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

NOAUTOREVERT=true
TBR=raphael.kubo.da.costa

No-Export: true
Change-Id: I5cc34a3af34ae00127390b9f9b5c678444676332
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763874Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#689167}

Bug: 959679
Change-Id: I220a180d2f1113404eb51972664f4e60bcb37152
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762250Reviewed-by: Jenny Zhang <jennyz@chromium.org>
Commit-Queue: Tony Yeoman <tby@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689166}

This reverts commit a1fe850a.

Reason for revert: speculative revert for crbug.com/996037.

Original change's description:
> Cache animation base computed style only on default StyleForElement()
> 
> StyleForElement() can be used to get the default style (i.e. the
> style that will be applied on the element), or style derived from
> custom parent style for e.g. inherited first line style. We should
> cache animation base computed style in the first case only.
> 
> Bug: 989490
> Change-Id: Ia30b3e7bcd65cdb9456eb925e5c24f156353bff9
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1753030
> Reviewed-by: Rune Lillesveen <futhark@chromium.org>
> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#686915}

TBR=wangxianzhu@chromium.org,futhark@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 989490,996037
Change-Id: Ib12e4e55e70eaeb2c82ca173c145c225c1d79802
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763343Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689165}

Since ServiceManager went away, we're clearing up some leftover
CupsProxyService constants. Trivial change.

Bug: chromium:945409
Test: confirmed service behavior unchanged
Change-Id: I45ffdeb3b0ad1990798a4a4d5115e791a6eefbfe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764430
Auto-Submit: Luum Habtemariam <luum@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689164}

The perf collector issues dbus commands to run perf as root but the dbus client
is not thread safe.
Temporarily, map the collector task runner to the current thread (UI), until we
can implement a fix in the dbus client.

BUG=b:139816773

Change-Id: I02766ed512a10f1868dda7bd58205397997ef9e0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764319Reviewed-by: Gabriel Marin <gmx@chromium.org>
Reviewed-by: Mike Wittman <wittman@chromium.org>
Commit-Queue: Gabriel Marin <gmx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689163}

This changes the CookieStore's GetCookieListCallback from taking a
CookieList (for included cookies) and a CookieStatusList (for excluded
cookies), to taking a CookieStatusList for both. Previously, the
statuses of included cookies could be assumed to be INCLUDE, so they
did not need to be passed to the callback. The next change adds more
nuanced information to CookieInclusionStatus such that statuses must
be explicitly passed even for included cookies, hence a CookieStatusList
must be provided.

This also makes GetAllCookiesCallback take a CookieList only, since the
second CookieStatusList parameter (for excluded cookies, of which there
were none, since we are getting all cookies) was unused.

Bug: 993843
Change-Id: I4c6bedc0c161f863b9a1755bb93e615f2793202e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758437
Commit-Queue: Lily Chen <chlily@chromium.org>
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Reviewed-by: Maks Orlovich <morlovich@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689162}

This changes ProfileImpl to own the IdentityService instance directly,
lazily initialized by a direct call to Profile::GetIdentityService()
instead of going through the Service Manager.

Bug: 977637
Change-Id: I6ab794e019fabb8c65c80491ac124778dd0e822f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761217Reviewed-by: Tao Wu <wutao@chromium.org>
Reviewed-by: Sam McNally <sammc@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Ken Rockot <rockot@google.com>
Cr-Commit-Position: refs/heads/master@{#689161}

In ExecutePerformActions function, we dispatch key events first, mouse
events then touch events, some code are redundant with different pointer
types. I cleaned some code shared with different pointer type.

Bug: 606367
Change-Id: I27e7e538db8026b87938abd19ae71f59e1c6844a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762769Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: Lan Wei <lanwei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689160}

Fix enforcing RSA certificate keyUsage for known roots when cert verification completes asynchronously.

Bug: 795089
Change-Id: Ic830507465887d6bfe13b6fd9e05dc08d9f52dcc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763636Reviewed-by: David Benjamin <davidben@chromium.org>
Commit-Queue: Matt Mueller <mattm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689159}

WebAudio legacy code often does something like:

  DCHECK(foo);
  if (!foo)
    return;

The style guide says the if/return should be removed; DCHECK failures
should not be handled.

Part 2 of N: Update a few more files and for the most obvious cases
where we can remove the if/return.

Bug: 957654
Change-Id: Ie5a30a67a58b88df9b5eb579d06894c710c9b1dd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758593Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Commit-Queue: Raymond Toy <rtoy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689158}

This is necessary because ThemeProperties::GetDefaultColor() is never actually
reached for COLOR_TOOLBAR_BUTTON_ICON (so the kGoogleGrey100 return in
GetIncognitoColor() was dead code).  ThemeService::GetDefaultColor()
unconditionally uses the tint, which was {-1, -1, -1} in dark mode after
http://crrev.com/688233 .  This approximately restores the behavior from before
that CL, when dark-mode was special-cased for TINT_BUTTONS to just return white.

Another way to solve this would be to remove this code from ThemeService, add
a "return kChromeIconGrey" to GetLightModeColor() for COLOR_TOOLBAR_BUTTON_ICON,
and add processing to browser_theme_pack.cc to compute an override color if the
theme specifies TINT_BUTTONS.  This would change HasCustomColor() to return true
"more accurately" -- i.e. only if the theme customizes the color, instead of
what it does now, which is to return true any time the tint is not a no-op.
Looking at callers of HasCustomColor(COLOR_TOOLBAR_BUTTON_ICON), they seem to
want it to return true in the dark/incognito case, so I've avoided this route
for now, although perhaps these callers could be updated (e.g. to check if the
returned color was non-default or just unconditionally use the returned color as
if it's "custom").

This does not apply the dark tinting to TINT_FRAME*, since doing so will cause
dark mode to darken the frame images of every theme that uses them without
explicitly setting a manual tint (i.e. almost all themes that use custom frame
images).  This is sort of an interesting effect, but would almost certainly be
considered "breaking" these themes.

Bug: 995681
Change-Id: I4dd8a7c24323b5a4caf24b3ad08188f73de028c9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762943
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689157}

This test doesn't work and can't be made to work on 10.14+: it
requires CGEventPost (because window dragging is handled by the
WindowServer), which either pops a permission modal or simply
does nothing depending on system config.

Bug: 767299
Change-Id: I09e305c0bce83131df4b40a5154b6bd5af52a21a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762476
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: ccameron <ccameron@chromium.org>
Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: ccameron <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689156}

Need to change for androidx presubmit check.

Bug: 767058
Change-Id: I2efb55945ebce3533807a0c63b8044f1cbe3cb54
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762545Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Nate Fischer <ntfschr@chromium.org>
Reviewed-by: Peter Wen <wnwen@chromium.org>
Reviewed-by: Yun Liu <yliuyliu@google.com>
Commit-Queue: benjamin joyce <bjoyce@google.com>
Cr-Commit-Position: refs/heads/master@{#689155}

Turns out that ReadFromClipboard does use the buffer argument.

Here's[1] an overload supporting it, and here's[2] a use-case with kDrag.

[1]: https://cs.chromium.org/chromium/src/components/bookmarks/browser/bookmark_node_data_mac.mm?rcl=d5f58793b0d31cc3e2f05c23ba3194c4d5191da3&l=42
[2]: https://cs.chromium.org/chromium/src/chrome/browser/ui/cocoa/tab_contents/web_drag_bookmark_handler_mac.mm?rcl=d5f58793b0d31cc3e2f05c23ba3194c4d5191da3&l=27

Change-Id: I59c2645c865ed52215afaa4c111dcfbca4c26819
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763213Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Darwin Huang <huangdarwin@chromium.org>
Auto-Submit: Darwin Huang <huangdarwin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689154}

Previously interface ModuleInstallUi.FailureUiListener has two
callbacks: {onRetry(), onCancel()}. This CL merges the callbacks to
onFailureResponse(), which takes a |retry| param to distinguish the two
cases. This results in a slight savings in method counts (4 right now).

Bug: 927131
Change-Id: I2965906f033fc05920657ea4cb1cd7424bc8a86c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763640Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Commit-Queue: Samuel Huang <huangs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689153}

Bug: 960513
Change-Id: I4321dec43926b10b4b07a1767eae556f7df5ee72
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1745772
Commit-Queue: Sean Harrison <harrisonsean@chromium.org>
Reviewed-by: Robert Ogden <robertogden@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689152}

This reverts commit 5805ac7f.

Reason for revert: breaking Windows compile:

In file included from ../..\base/task/lazy_task_runner.h:17:
../..\base/task/task_traits.h(263,5): error: static_assert failed due to requirement 'has_thread_pool ^ has_extension' "Traits must explicitly specify a destination (e.g. ThreadPool or a named thread like BrowserThread)"
    static_assert(
    ^
../..\chrome/chrome_cleaner/ipc/proto_chrome_prompt_ipc.h(108,39): note: in instantiation of function template specialization 'base::TaskTraits::TaskTraits<base::MayBlock, void>' requested here
      base::CreateSequencedTaskRunner({base::MayBlock()});
                                      ^
1 error generated.

Original change's description:
> Reland "Implement ProtoChromePromptIPC."
> 
> This is a reland of e5f1b06d
> 
> It was reverted in https://crrev.com/c/1760644 for causing test failures on CI
> builders that couldn't be reproduced on other machines.
> 
> This patch disables the failing tests. A followup will reenable the tests with
> extra debugging to diagnose the failures on the CI builders.
> 
> TBR=wfh
> TBR_REASON=Reland of test-only proto change that was already reviewed.
> 
> Original change's description:
> > Implement ProtoChromePromptIPC.
> >
> > Bug: 969139
> > Change-Id: I35d551b6bdb41b4e6bd7689120c21d9d683ad72f
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733747
> > Commit-Queue: Oliver Li <olivierli@chromium.org>
> > Reviewed-by: Will Harris <wfh@chromium.org>
> > Reviewed-by: Joe Mason <joenotcharles@google.com>
> > Cr-Commit-Position: refs/heads/master@{#688357}
> 
> Bug: 969139
> Change-Id: Iafdc22cc06fbedd5de73bf8bb7881fc46e01f350
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1759154
> Reviewed-by: Joe Mason <joenotcharles@google.com>
> Reviewed-by: Will Harris <wfh@chromium.org>
> Commit-Queue: Joe Mason <joenotcharles@google.com>
> Cr-Commit-Position: refs/heads/master@{#689074}

TBR=joenotcharles@google.com,wfh@chromium.org,olivierli@chromium.org

Change-Id: I42f06162b45d41212816410027153f89f95a28f1
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 969139
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764124Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689151}

This reverts commit 047c361c.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> Defer location change events and processing during page load
> 
> Improves speed of page load stress test from 146 seconds to 43 seconds.
> 
> Also add logging for accessibility page load speed.
> 
> Bug: 976849
> Change-Id: I51d2833366b7b54b2abb9fde40811d29ef287aef
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1675917
> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
> Commit-Queue: Nektarios Paisios <nektar@chromium.org>
> Reviewed-by: Nektarios Paisios <nektar@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#672315}

TBR=nektar@chromium.org,aleventhal@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 976849
Change-Id: I0ef892affa0f6c9a2888307262f12bc720c55148
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761715Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689150}

When in layer list mode:

- Initialize root properties in LayerTreeTest::SetupTree()
- Provide LayerTreeTest::SetupViewport() (previously global function
  CreateVirtualViewportLayers in layer_tree_test.h). A test needing
  viewport layers and properties can call it from its SetupTree().
- Tests setup their layers and properties in SetupTree().

property_tree_test_utils.h provides helper functions for convenience
of tests to setup properties in the following way:

  scoped_refptr<Layer> layer = Layer::Create();
  ...
  InheritProperties(layer.get(), parent_layer_for_properties);
  auto& transform_node = CreateTransform(layer.get());
  transform_node.xxx = // customize the transform node
  root_layer->AddChild(layer);

This changes the procedure of pixel tests in layer list mode when
setting up layers and properties. Previously we setup property tree
outside of SetupTree() before BeginTest() when layer_tree_host() was
not created yet, causing many inconveninces. Now we always setup
layers and properties in SetupTree().

Bug: 994361
Change-Id: I2b3c0a47037c685618372bdff389551e09b62634
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761642
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Reviewed-by: enne <enne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689149}

As discussed @
https://chromium-review.googlesource.com/c/chromium/src/+/1758440/8#message-f222f67d1440dc03932cb7b666ad65dde5a22b33

Used the following regex to identify files with such variables:
(Browser|Web)TaskEnvironment ([^t]|t[^a]|ta[^s]|tas[^k])\w*;

And then replaced remaining \w*(threads_|bundle_)\w* in the affected
files.

TBR=dcheng@chromium.org

Bug: 992483
Change-Id: Ie363916c3b362d3b1b797db97000b51bceb148aa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762330
Commit-Queue: Gabriel Charette <gab@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689148}

This flag is not to be confused with the Chrome flag with the same name.
This one in particular is not used anywhere.

Change-Id: Ie6ce31e516d0f4c19ab1291a8bbb37ea63eb97de
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764150Reviewed-by: Peter Beverloo <peter@chromium.org>
Commit-Queue: Yang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689147}

As the ResourceProvider::snapshot() may return a nullptr, the subsequent calls
cause chrome to crash. Add checks before calling snapshot().

Bug: 991385

Change-Id: Ia00189a991afdbe8aff25d037cf02d78af376989
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760276
Commit-Queue: Yi Xu <yiyix@chromium.org>
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689146}

It is based on CTATestRule which does not apply.

Bug: None
Change-Id: I793c6e30f487f0052a2e25ad763565d9335e1a23
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763333Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Commit-Queue: Ian Vollick <vollick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689145}

NullValue() is represented as a NaN in a double. We could better return
a base::Optional<double> and use the undefined base::Optional as null
value. Also there is no need for the IsNull() call as we could just use
the returned value as a boolean.

Bug: 994811
Change-Id: I2c5eb88ba563486f4864480b8f842ce349c610f7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760965
Commit-Queue: Sergio Villar <svillar@igalia.com>
Reviewed-by: Kevin Ellis <kevers@chromium.org>
Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689144}

* Only show IPH item for grid mode in TabSwitcher.
* Correctly setup/restore the padding of the recyclerView.
* Add a TODO for future refactoring.

Bug: 987043
Change-Id: I15609a1f823f25b03f29ef0c8a7bf0f5af78dec4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763630Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Commit-Queue: Yue Zhang <yuezhanggg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689143}

This issue was found while working on the fix in this[1] CL.

Prior to this CL, when transitioning from scrolling to anything, a scroll
end event was scheduled, but not immediately dispatched. This is so that
if the scroll is going to be followed by a momentum scroll (fling), the
scroll end event wouldn't be sent. However, momentum scrolling doesn't
always occur after a scroll, and because of an issue with Direct
Manipulation, sometimes a scroll begin then end event would be sent when
the user is actually doing a pinch zoom. In this case, we know that we
can immediately dispatch the end event rather than scheduling it.

Now with this change, if we are transitioning from a scroll to a pinch,
the momentum_phase of an event is set to Blocked, signalling that a
momentum scroll will not happen. We then immediately dispatch the end
event without waiting.

[1]: https://chromium-review.googlesource.com/c/chromium/src/+/1725349

Bug: 908758
Change-Id: If89fea60a396ff10b54d56b986052c704eabb0b2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1708994
Commit-Queue: Mario Bianucci <mabian@microsoft.com>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689142}

This reverts commit d7b74986.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 689097 as the
culprit for failures in the build cycles as shown on:
https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2Q3Yjc0OTg2MWUwODE0YzAxODgwNjVmZWUwY2Q2MTcyMTQwZDMzOTMM

Sample Failed Build: https://ci.chromium.org/buildbot/chromium/win32-archive-rel/4058

Sample Failed Step: compile

Original change's description:
> Reland "Reland [base] Require task posters to specify an explicit destination"
> 
> This is a reland of dd34a877
> 
> Rebased on a few more fixes including a local full build of:
>  - Windows + is_chrome_branded
>  - ChromeOS + is_chrome_branded
>    (except for the libassistant portion which is giving weird errors...)
> 
> Original change's description:
> > Reland [base] Require task posters to specify an explicit destination
> >
> > This patch makes it a requirement for all task traits to specify their
> > thread affinity. Previously task traits that did not name a specific
> > thread would implicitly run on the thread pool, which could be
> > surprising. To make this more obvious, thread pool tasks must now use
> > the base::ThreadPool() trait.
> >
> > This is the final reland of
> > https://chromium-review.googlesource.com/c/chromium/src/+/1635827
> > (will attempt to fix errors that caused original revert before
> >  relanding).
> >
> > Bug: 968047
> > Change-Id: Ice339db270a27815b2be68200930e5bc105e8a96
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1759056
> > Commit-Queue: Gabriel Charette <gab@chromium.org>
> > Reviewed-by: François Doray <fdoray@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#688782}
> 
> Bug: 968047
> Change-Id: Iccd12e0a9f1535cb10b903777c5004a7d1acb34a
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761362
> Commit-Queue: Gabriel Charette <gab@chromium.org>
> Reviewed-by: François Doray <fdoray@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#689097}


Change-Id: I9e1f30313cc2c3a09a27dda011112f577ba4cbe8
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 968047
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764428
Cr-Commit-Position: refs/heads/master@{#689141}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a15c33510ba9..d60490eeff86


Created with:
  gclient setdep -r src-internal@d60490eeff86

The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=jbudorick@google.com

Bug: chromium:None,chromium:None
Change-Id: I35e9dd10e4760eb66f731282ec1bfc4c8f2487df
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764231Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#689140}

Determines if platform supports overridden status of permission by
querying PermissionControllerDelegate. Since most delegates have static
permission statuses, this queries the permission status by default.
Overridden classes, such as PermissionManager (used for Chrome) and
WebTestPermissionManager, have dynamic permission settings which are
queried in a different fashion. If permission is not supported, this
is indicated. PermissionControllerImpl, which controls overrides,
uses this decision to choose whether or not to override, which is
then forwarded to the callee. Browser.setPermission uses this to
indicate if setting permission failed/succeeded. Browser.grantPermission
ignores the result.

Design doc: go/chromedriver-permissions-ext

Bug: 976308
Change-Id: I0124ea1b2238a33c379476b74d6ef322327413a2
Tested: Adds unit tests to each affected level.
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752176
Commit-Queue: Rohan Pavone <rohpavone@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689139}

More than half of the tests don't care about it but had to implement
an empty body for it. We had total 266 AfterTest() overrides and
166 of them were just empty.

Add a default empty implementation for the function and remove the
empty overrides.

Change-Id: Iac538bd6a470d55eeea371ede83ce9e3fc23dd59
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764173
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689138}

Passes the context associated with the profile invoker's ScriptState
into v8::CpuProfilingOptions for filtration, providing isolation of
traces to the invoker's realm.

Bug: 956688
Change-Id: Iafb46d1990841656b216588a67ef63e3198b0a14
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762249Reviewed-by: Peter Marshall <petermarshall@chromium.org>
Reviewed-by: Nicolás Peña Moreno <npm@chromium.org>
Commit-Queue: Andrew Comminos <acomminos@fb.com>
Cr-Commit-Position: refs/heads/master@{#689137}

This CHECK hasn't tripped in the recent Canary builds, it's safe to turn
it back into a DCHECK.

Bug: 966059
Change-Id: Ieeb23543146fb276d601790638b3d3fbd1880c44
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760279
Auto-Submit: Sébastien Marchand <sebmarchand@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689136}

The version code is useful to identify java proguard mappings.
Also removes posting task for metadata generation in privacy
filtered mode.

Change-Id: Ifd26a4ee39010467a89a73c7159bada02e15490c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1759293
Commit-Queue: ssid <ssid@chromium.org>
Reviewed-by: oysteine <oysteine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689135}