- 03 Nov, 2018 40 commits
-
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/671341ac6669..9f878f6e97fa git log 671341ac6669..9f878f6e97fa --date=short --no-merges --format='%ad %ae %s' 2018-11-03 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision b58a0334..4e7c87b5 (605082:605184) Created with: gclient setdep -r src/third_party/webrtc@9f878f6e97fa The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ifa81ec6e0c2127fd99fb395feecba01ad4b3709d Reviewed-on: https://chromium-review.googlesource.com/c/1316998Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#605191}
-
Xiaohan Wang authored
Since COMPONENT_EXPORT(MEDIA) is too long, still keep MEDIA_EXPORT. But instead of defining our own, define it to be COMPONENT_EXPORT(MEDIA). Bug: None Change-Id: I0b24844d3227f918ef1d567a405a03356f66d289 Reviewed-on: https://chromium-review.googlesource.com/c/1313879 Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#605190}
-
Koji Ishii authored
This patch changes NGPaintFragment to remove children before it is destructed. Because NGPaintFragment keeps its children as a linked list, the destructor will deref its first child and next sibling, which will call their destructors recursively. This patch removes children first to avoid stack overflow when there are many children. Bug: 901105 Change-Id: I0bbb5745468926178ce0132208d4c07f56839cf4 Reviewed-on: https://chromium-review.googlesource.com/c/1314020 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#605189}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/072d61b49093..3304997ac5db Created with: gclient setdep -r src-internal@3304997ac5db The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ie198e35c34adf0af81f5c8a8b5aba3043fd42972 Reviewed-on: https://chromium-review.googlesource.com/c/1316997Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#605188}
-
Zach Helfinstein authored
Bug: None Change-Id: Idb37b6255dd3c5a5158426544cec48b487fc5945 Reviewed-on: https://chromium-review.googlesource.com/c/1313729Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Zach Helfinstein <zhelfins@chromium.org> Cr-Commit-Position: refs/heads/master@{#605187}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f900879ca7b2..072d61b49093 Created with: gclient setdep -r src-internal@072d61b49093 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I513f5b2b4c1608c9eb6aabbb18c3b3d46a1d5e1c Reviewed-on: https://chromium-review.googlesource.com/c/1316996Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#605186}
-
David Tseng authored
- Adds an extension api, chrome.brailleDisplayPrivate.updateBluetoothBrailleDisplayAddress, which will [re]start brltty with the given device. - adds a pref to track the braille display desired by a given user - adds logic to start and stop brltty on launch given a bluetooth braille display TODO: - the UI which will do the initial connection/pairing, and unpairing/forgetting of a device Bug: 882261 Test: manually call all relevant api functions. Change-Id: Ief0189a3f76ea6518bd8b644d3df816435feb019 - call chrome.brailleDisplayPrivate.updateBluetoothBrailleDisplayAddress - observe brltty is launched with the given address - unload and reload chromevox and observe brltty is appropriately loaded/unloaded Depends on: https://chromium-review.googlesource.com/c/chromiumos/overlays/chromiumos-overlay/+/1308895 Change-Id: Ief0189a3f76ea6518bd8b644d3df816435feb019 Reviewed-on: https://chromium-review.googlesource.com/c/1308986 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#605185}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 2dfb9d5d. With Chromium commits locally applied on WPT: 270d4abd "ServiceWorker: Add new WPT tests to make sure to update a registration with different script type and identical script content." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: hbos@chromium.org, hta@chromium.org: external/wpt/webrtc NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I3b79b6c61626d72622a0b645bc30ba429ff8b9cd Reviewed-on: https://chromium-review.googlesource.com/c/1317028 Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#605184}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c785d3146073..f900879ca7b2 Created with: gclient setdep -r src-internal@f900879ca7b2 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Iaab110b11503472b75b576c01e20069bd8dc1b7d Reviewed-on: https://chromium-review.googlesource.com/c/1316994Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#605183}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/b5ae3b5afc29..7e4081554d06 git log b5ae3b5afc29..7e4081554d06 --date=short --no-merges --format='%ad %ae %s' 2018-11-03 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader d0d9928f376c..9911aca4f7c6 (1 commits) Created with: gclient setdep -r src/third_party/skia@7e4081554d06 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=herb@chromium.org Change-Id: Idc9daf862e2866f993b2d8200277abf499cf0d10 Reviewed-on: https://chromium-review.googlesource.com/c/1316995Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#605182}
-
Arthur Sonzogni authored
In bug 882661: one mojo::URLLoader is sending OnStartLoadingResponseBody without sending OnReceiveResponse before. Add instrumentation to check this never happen with this class. Bug: 882661 Change-Id: Ia9df5debbc03f0a5296c64edbcf6d975806bc021 Reviewed-on: https://chromium-review.googlesource.com/c/1304435Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#605181}
-
Findit authored
This reverts commit 0301a791. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 605068 as the culprit for flakes in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vMDMwMWE3OTFiODBiMDQ1NjU5NGUwZjBlOTEwOGU3YTNjZjMxNmZlOQw Sample Failed Build: https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-dbg/8686 Sample Failed Step: single_process_mash_browser_tests Sample Flaky Test: LockScreenNoteTakingTest.DataAvailableOnRestart Original change's description: > Android: turning on bytecode checker > > This arg was defaulting to false when it should have defaulted to true. > > TBR=turning off bytecode checks for certain dirs > > Bug: 874854 > Change-Id: I248ccab0ed52079106b07e43a302927bfa4414c8 > Reviewed-on: https://chromium-review.googlesource.com/c/1309973 > Commit-Queue: Sam Maier <smaier@chromium.org> > Reviewed-by: agrieve <agrieve@chromium.org> > Cr-Commit-Position: refs/heads/master@{#605068} Change-Id: I6cbeb762a8de75dde103493010715c5f5ed8074e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 874854, 901616 Reviewed-on: https://chromium-review.googlesource.com/c/1317030 Cr-Commit-Position: refs/heads/master@{#605180}
-
BUG=762641 TBR=derat@chromium.org Change-Id: Ibd3af6f96bc4d347be17e0dac5fa23932e9e1fe8 Reviewed-on: https://chromium-review.googlesource.com/c/1316928Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#605179}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/0e6fc6fdae02..b5ae3b5afc29 git log 0e6fc6fdae02..b5ae3b5afc29 --date=short --no-merges --format='%ad %ae %s' 2018-11-03 kjlubick@google.com [canvaskit] Add drawVertices API Created with: gclient setdep -r src/third_party/skia@b5ae3b5afc29 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=herb@chromium.org Change-Id: Ib9619ee3ac69e37f1c1189008fc025778583dfbd Reviewed-on: https://chromium-review.googlesource.com/c/1316992Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#605178}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/5c96f848d874..c785d3146073 Created with: gclient setdep -r src-internal@c785d3146073 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ie45518696b6f49903d33608917d9db45671ae412 Reviewed-on: https://chromium-review.googlesource.com/c/1316993Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#605177}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/eb8ed5d3b973..5c96f848d874 Created with: gclient setdep -r src-internal@5c96f848d874 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Idb9f835d4efa6f33f9a13a180cd92f23fdc3cd39 Reviewed-on: https://chromium-review.googlesource.com/c/1316991Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#605176}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/e1b1d056fed9..0e6fc6fdae02 git log e1b1d056fed9..0e6fc6fdae02 --date=short --no-merges --format='%ad %ae %s' 2018-11-03 mtklein@google.com focus legacy blitters a little more 2018-11-03 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 155f802a6be3..d0d9928f376c (1 commits) Created with: gclient setdep -r src/third_party/skia@0e6fc6fdae02 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=herb@chromium.org Change-Id: Ibf9bfb7717d4317bf9cce71d370e5008932477ae Reviewed-on: https://chromium-review.googlesource.com/c/1316990Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#605175}
-
Chromium WPT Sync authored
Using wpt-import in Chromium d2055859. With Chromium commits locally applied on WPT: 270d4abd "ServiceWorker: Add new WPT tests to make sure to update a registration with different script type and identical script content." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: hbos@chromium.org, hta@chromium.org: external/wpt/webrtc NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Id6816ed5e313da42e20734084cb83fd5a166cf37 Reviewed-on: https://chromium-review.googlesource.com/c/1317027 Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#605174}
-
Jinho Bang authored
Related spec change: https://github.com/w3c/payment-request/pull/805 Bug: 861704 Change-Id: Ic15a8cd0b66c52277abecbd6b976c5e4af2f9022 Reviewed-on: https://chromium-review.googlesource.com/c/1312144 Commit-Queue: Jinho Bang <jinho.bang@samsung.com> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#605173}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/55acaa0198e5..eb8ed5d3b973 Created with: gclient setdep -r src-internal@eb8ed5d3b973 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I8a59385584d88437d815a494aa3610646c1f6786 Reviewed-on: https://chromium-review.googlesource.com/c/1316989Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#605172}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/f1ec3918534f..e1b1d056fed9 git log f1ec3918534f..e1b1d056fed9 --date=short --no-merges --format='%ad %ae %s' 2018-11-03 mtklein@google.com Revert "Remove one field of unique data from SkGlyphCacheBuilder" Created with: gclient setdep -r src/third_party/skia@e1b1d056fed9 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=herb@chromium.org Change-Id: I153c0c17a7237b31790015765e948e930ecea0a6 Reviewed-on: https://chromium-review.googlesource.com/c/1316988Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#605171}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/04f5bc21c7a8..55acaa0198e5 Created with: gclient setdep -r src-internal@55acaa0198e5 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I1d90b6d74abeae6c4373fa0570127d10422f5e99 Reviewed-on: https://chromium-review.googlesource.com/c/1316987Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#605170}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 7563cd4d. With Chromium commits locally applied on WPT: 270d4abd "ServiceWorker: Add new WPT tests to make sure to update a registration with different script type and identical script content." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Iff4642aae156fd73bd06ced508a9ee6804d3c46e Reviewed-on: https://chromium-review.googlesource.com/c/1316679 Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#605169}
-
Morten Stenshorne authored
Available size may change from one layout pass to another, but that doesn't have to mean that we need to re-lay out a child. If we can be sure that its size will remain the same, and that if it will keep the same size, that won't affect any descendants, we can skip layout and return the cached fragment. We cannot ignore initial containing block size changes if there are orthogonal flow root children, so keep track of that. Makes perf_tests/layout/many-block-children-fixed-inline-size.html about 3 times faster. Update expectations for one invalidation test. The test has some fixed-width descendants, so when only the window width changes, there's less work to do, than before. Update one unit test, and expand it a bit, to provide a case where we actually still do need layout. Bug: 897450 Change-Id: I063f650110d5a488de430b938b3d46e713a1433e Reviewed-on: https://chromium-review.googlesource.com/c/1297367 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#605168}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/b3babd683abb..f1ec3918534f git log b3babd683abb..f1ec3918534f --date=short --no-merges --format='%ad %ae %s' 2018-11-03 skia-bookmaker@skia-swarming-bots.iam.gserviceaccount.com Update markdown files Created with: gclient setdep -r src/third_party/skia@f1ec3918534f The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=herb@chromium.org Change-Id: Ibbacfed4a643980f7f338d6b9fa3a6f91e339ff6 Reviewed-on: https://chromium-review.googlesource.com/c/1316864Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#605167}
-
Ken Rockot authored
Changes the app_list UI to use Content Service client library to display answer card web contents, rather than using some one-off IPCs to drive remote WebContents behavior with a special WebContentsDelegate/Observer in chrome/browser code. This allows quite a bit of code to be deleted from src/chrome while retaining all the existing functionality of answer cards in the app_list search UI. Prior to this change, AnswerCardSearchProvider would query the potential card URL (i.e. google.com/coac?q=whatever) and only send a corresponding search result back to Ash if the response was a valid card response. Instead, now all queries are treated as potentially valid search results, and AnswerCardSearchProvider is little more than a translator which turns a search query string into a useful answer card query URL. Ash-side code then navigates its own NavigableContents to any potential card URL it receives, inspecting response headers to determine whether or not the contents are actually a card. If they are, it displays them in the UI. The key results of this CL are: * Most relevant app_list answer card support logic lives in Ash now. A future change could probably move the rest of it, but that requires a more fundamental reconsideration of the browser's role (or non-role) in supporting app_list search behavior. * All of the Ash/Chrome code to support answer cards in the app_list UI is unified for in- and out-of-process Ash cases. * We have a working Content Service client being used in production Chrome OS code, which establishes precedent for improving several other features that embed WebContents within Chrome OS system UI. Bug: 854367 Change-Id: Id913460d7a4bd4558d385b9b3f9b52845aa0f0e7 Reviewed-on: https://chromium-review.googlesource.com/c/1269622 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Eric Roman <eroman@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#605166}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. The AutoRoll server is located here: https://autoroll.skia.org/r/afdo-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: I6b89d0b78a7fcdd71e2acbc57f367870c4315db7 Reviewed-on: https://chromium-review.googlesource.com/c/1316865Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#605165}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7708b03d24a5..04f5bc21c7a8 Created with: gclient setdep -r src-internal@04f5bc21c7a8 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ic7f5d243c19dbfb8adf9e1087c15a6e45773723c Reviewed-on: https://chromium-review.googlesource.com/c/1316863Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#605164}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/9f8459473cdf..b3babd683abb git log 9f8459473cdf..b3babd683abb --date=short --no-merges --format='%ad %ae %s' 2018-11-03 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update go_deps asset Created with: gclient setdep -r src/third_party/skia@b3babd683abb The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=herb@chromium.org Change-Id: I2ec65dc1a890626f4dc8c11aeee52e46ab3dddb6 Reviewed-on: https://chromium-review.googlesource.com/c/1316862Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#605163}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 3e2a36d0. With Chromium commits locally applied on WPT: 270d4abd "ServiceWorker: Add new WPT tests to make sure to update a registration with different script type and identical script content." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: cvazac@akamai.com, igrigorik@chromium.org: external/wpt/server-timing hbos@chromium.org, hta@chromium.org: external/wpt/webrtc jsbell@chromium.org: external/wpt/resources meade@chromium.org: external/wpt/web-animations rouslan@chromium.org, mathp@chromium.org: external/wpt/payment-request NOAUTOREVERT=true TBR=raphael.kubo.da.costa@intel.com No-Export: true Change-Id: Ieb221eabbd65408d4f202e7615c5d75041ccaf15 Reviewed-on: https://chromium-review.googlesource.com/c/1316671 Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#605162}
-
Christopher Cameron authored
This will help in cleaning up the issue. RenderWidgetHostViewMac no longer participates in CATransationObserver (except for native embedders like ContentShell, which will now have non-smooth resize). TBR=fsamuel Bug: 897156 Change-Id: Ifced689c801a71b4edbcc41e7f523ce0eeedc5b0 Reviewed-on: https://chromium-review.googlesource.com/c/1316673Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#605161}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/28201fd02165..7708b03d24a5 Created with: gclient setdep -r src-internal@7708b03d24a5 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I4461e7b50fbf0201454a4d079c28e73855f164aa Reviewed-on: https://chromium-review.googlesource.com/c/1316861Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#605160}
-
Siddhartha authored
We have tried to unwind the stack frame and the failure rate of unwinding android framework frames with libunwind is too high to get meaningful data. So, scan the stack to find all chrome PCs if unwinding fails. We can try to sanitize the stack on the server side. BUG=859260 Change-Id: I689b59f03f6b088576e45667fbad878c67940ba2 Reviewed-on: https://chromium-review.googlesource.com/c/1308717 Commit-Queue: ssid <ssid@chromium.org> Reviewed-by:
Mike Wittman <wittman@chromium.org> Cr-Commit-Position: refs/heads/master@{#605159}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/3ad9cf63..35240cdb Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Iaad8a52448ea3a75ee84648b832a5eb539c8e656 Reviewed-on: https://chromium-review.googlesource.com/c/1316670Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#605158}
-
Wez authored
This reverts commit f130981c. Reason for revert: Doesn't actually fix anything. >.< Original change's description: > Add FDIO_EVT_PEER_CLOSED to WatchFileDescriptor(WATCH_READ) events. > > WatchFileDescriptor(WATCH_READ) should result in > OnFileCanReadWithoutBlocking() if the descriptor is at end-of-stream > when it is invoked, to wake the caller to detect that by attempting to > read and receiving zero bytes. > > Bug: 898938, 706592, 884299 > Change-Id: I77662fe77eb8fb988089640a75a60d470770b78f > Reviewed-on: https://chromium-review.googlesource.com/c/1316672 > Commit-Queue: Wez <wez@chromium.org> > Reviewed-by: Sergey Ulanov <sergeyu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#605154} TBR=wez@chromium.org,sergeyu@chromium.org,fdegans@chromium.org Change-Id: I1a98ece4b90de54c2c789dee64c226eb92bcda38 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 898938, 706592, 884299 Reviewed-on: https://chromium-review.googlesource.com/c/1316675Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#605157}
-
Shakti Sahu authored
Since Formatter.formatFileSize switched to SI system starting from android-O, we show 1.07GB for a 1GB file. Using our own formatter that works with multiples of 1024 fixes this issue which is also used for download home and notifications. Bug: 891457 Change-Id: I238c0a2654908d550c91f4c77ec9a5a802bd6775 Reviewed-on: https://chromium-review.googlesource.com/c/1315700Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#605156}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/fea094c83229..28201fd02165 Created with: gclient setdep -r src-internal@28201fd02165 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I193f5dcb23410a2944e8ebc04759e71a44192aa8 Reviewed-on: https://chromium-review.googlesource.com/c/1316860Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#605155}
-
Wez authored
WatchFileDescriptor(WATCH_READ) should result in OnFileCanReadWithoutBlocking() if the descriptor is at end-of-stream when it is invoked, to wake the caller to detect that by attempting to read and receiving zero bytes. Bug: 898938, 706592, 884299 Change-Id: I77662fe77eb8fb988089640a75a60d470770b78f Reviewed-on: https://chromium-review.googlesource.com/c/1316672 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#605154}
-
Qingsi Wang authored
MdnsResponderInterface is introduced in WebRTC to handle the hostname generation and resolution of ICE host candidates when concealing their local IP addresses. For WebRTC in Chromium, we implement it as a client of the service provided by network::mojom::MdnsResponder. Bug: 878465 Change-Id: Id7b79694deba0ef308e51f83d6134062ddcb3985 Reviewed-on: https://chromium-review.googlesource.com/c/1206002 Commit-Queue: Qingsi Wang <qingsi@google.com> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Cr-Commit-Position: refs/heads/master@{#605153}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/570b99d69e5b..9f8459473cdf git log 570b99d69e5b..9f8459473cdf --date=short --no-merges --format='%ad %ae %s' 2018-11-03 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 6ba22ee13768..37297a4f1440 (3 commits) 2018-11-03 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@9f8459473cdf The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=herb@chromium.org Change-Id: I80bef10706d7daf52535cccb332ee87deaf7d07b Reviewed-on: https://chromium-review.googlesource.com/c/1316859Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#605152}
-