- 23 Mar, 2018 40 commits
-
-
Matt Menke authored
ResourceDispatcherHost pushes pending load state of all frames to the UI thread once every 250 milliseconds when there's a pending load. This happens even when the UI thread is blocked. Apparently it's causing an OOM when the UI thread is blocked. Whatever is blocking the UI thread is another issue entirely, but we shouldn't use unbounded memory in the browser process. This CL prevents load state updates from being sent until the previous set was ACKed by the UI thread. Bug: 824869 TBR: jam@chromium.org Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I3b68522c5281d477d3a621ac02e5df1f75153d99 Reviewed-on: https://chromium-review.googlesource.com/978383 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#545616}
-
wutao authored
This cl puts the focus on the search box when Keyboard Shortcut Viewer (KSV): 1. The first time the window is created. 2. Every time it exits search mode by Esc or back arrow. Bug: 822333 Test: manual test. Change-Id: Ia0fdeb744e3090d246769aee58c9ee42d58e14e5 Reviewed-on: https://chromium-review.googlesource.com/978784Reviewed-by:
Qiang Xu <warx@google.com> Commit-Queue: Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#545615}
-
Matt Menke authored
The system ProxyConfigService is now created on Chrome's UI thread, so the references were outdated. Also, net/ really shouldn't know about content/'s threads. Bug: 823063 Change-Id: I399bdc13fa46b89f45111cafb393e2c9cd735bdd Reviewed-on: https://chromium-review.googlesource.com/978386 Commit-Queue: Eric Roman <eroman@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#545614}
-
Yuly Novikov authored
TBR=kbr@chromium.org BUG=675997 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I688e9e0987a3359c904f3be9ff1cd4f26efc4d1d Reviewed-on: https://chromium-review.googlesource.com/978627 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#545613}
-
Xida Chen authored
At this moment, this is how we check whether an animation is main thread compositable or not: 1. The runtime feature TurnOff2DAndOpacityCompositorAnimationsEnabled is on 2. There is either an opacity or 2d transform animation There is a problem with this logic. When there is an opacity animation on an element and the element has "will-change: transform", we will put this animation as main thread compositable. This is not true, we should categorize it as composited animation because "will-change: transform" will create a layer anyways. This CL fixes this problem. We care about the most common cases: "will-change: transform" and 3D transform. So step 2 in the above becomes: when there is no "will-change: transform" and there is no 3D transform, and there is either opacity or 2D transform, then this is a main thread compositable animation. This CL also added a test to verify that an element with "will-change: transform" + opacity animation will end up having a composited animation even when the runtime feature is on. Bug: 818809 Change-Id: Ifcd027223df96c17447955eb52568d74bb5505ff Reviewed-on: https://chromium-review.googlesource.com/951719 Commit-Queue: Xida Chen <xidachen@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#545612}
-
Charlie Harrison authored
Before PlzNavigate, we needed this because BLOCK_REQUEST_AND_COLLAPSE was only supported at navigation start. Now, it is unused. Bug: None Change-Id: Icb9274ed41283afafb73b32ab72d1389a4ed5dd0 Reviewed-on: https://chromium-review.googlesource.com/978391Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#545611}
-
Stephen Kyle authored
Certain telemetry benchmarks in tools/perf don't use the default telemetry mechanism for handling commandline arguments. As such, we reimplement the handling of --enable-systrace in each case. This covers: smoothness.* blink_perf.* thread_times.* Change-Id: I276f7ab96d8a17bd9f053b6159c26b0224055b6d Bug: catapult:#3504 Reviewed-on: https://chromium-review.googlesource.com/978122Reviewed-by:
Ned Nguyen <nednguyen@google.com> Reviewed-by:
Charlie Andrews <charliea@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Commit-Queue: Adenilson Cavalcanti <cavalcantii@chromium.org> Cr-Commit-Position: refs/heads/master@{#545610}
-
liberato@chromium.org authored
Previously, MCVD destroyed the textures that back the VideoFrames when MCVD was destroyed. When the pipeline suspends, this causes any VideoFrame to become undrawable. This CL adds TexturePool, which holds references to the textures until all VideoFrames are destroyed. While the implementation isn't exactly a pool, we will be adding pool functionality to it shortly. This CL also introduces a wrapper for GL command buffer stubs, to allow for easier testing. Similarly, this CL adds a wrapper around TextureRef. Bug: 737220 Test: TexturePoolTest Cq-Include-Trybots: luci.chromium.try:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I3d9bd42b9f8d3782b3eb4ceca30388774dc4854b Reviewed-on: https://chromium-review.googlesource.com/966782 Commit-Queue: Frank Liberato <liberato@chromium.org> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#545609}
-
Yue Li authored
Bug: 820255 Test: Manual Change-Id: Id7d63099b36f2b59c2389c539c5b433dd14c0b65 Reviewed-on: https://chromium-review.googlesource.com/978660Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Yue Li <updowndota@chromium.org> Cr-Commit-Position: refs/heads/master@{#545608}
-
Filip Gorski authored
This patch only changes how files are built and target name. Change-Id: Ifbeec1a862208db183c2dd8107df7bab43f70c76 Reviewed-on: https://chromium-review.googlesource.com/978846 Commit-Queue: Filip Gorski <fgorski@chromium.org> Reviewed-by:
Patrick Noland <pnoland@google.com> Cr-Commit-Position: refs/heads/master@{#545607}
-
Chris Harrelson authored
PLC::CollectFragments includes fragmentation offset if called in GeometryMapper mode. However, when hit testing under transform, we apply fragmentation and transform, then hit test each fragment without any fragmentation or transform offset. Therefore, in this post-fragment/transform mode, don't apply fragmentation offset again. The callsites in PaintLayerPainter for the equivalent situation during paint already correctly pass an empty LayoutPoint offset for layer bounds. Bug: 823255 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I3135e51b72c5fd02a9d67b3dcbdc51e39ef3cde2 Reviewed-on: https://chromium-review.googlesource.com/978675Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#545606}
-
Kevin Marshall authored
A previous CL regressed this behavior, leading to the generated runner being generated with absolute paths in the buildbot's filesystem. Change-Id: I16aaca1556c9f8eccc81d3cdd841b4a3c71de3f2 Reviewed-on: https://chromium-review.googlesource.com/978639Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#545605}
-
Abhishek Arya authored
Use base::StringPiece in cases where caller expects input in std: :string is null terminated whereas base::StringPiece is not. base: :StringPiece as it helps to catch for overflow cases. Change-Id: I0c70d1f8c40fc5f0e826ced5073f563bc74d1d80 Reviewed-on: https://chromium-review.googlesource.com/978036 Commit-Queue: Abhishek Arya <inferno@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Max Moroz <mmoroz@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#545604}
-
Fredrik Hubinette authored
VP8 has no color space information apart from full range / limited range. However, because of a comment in the VP8 spec that says that vp8 content is "like bt601", ffmpeg sets the matrix to SMPTE470BG. When we assign the color space to the video frame we default the other parameters to BT709, leading to a color space like: { primaries=BT709, transfer=BT709, matrix=SMPTE470BG, range=Limited } This mix of color spaces is is clearly wrong. This fix works around the ffmpeg behavior and leaves the color space completely unset when this happens. Unset color spaces defaults to BT709 later on, which is probably what we weant. Full-range content gets a JPEG color space. Bug: 754986 Cq-Include-Trybots: luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I04694e949d211b134312ade01555fa1954a82bad Reviewed-on: https://chromium-review.googlesource.com/912436 Commit-Queue: Fredrik Hubinette <hubbe@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#545603}
-
Erik Chen authored
This is required to correctly perform accounting of shared memory on macOS. Bug: 823915 Change-Id: I75a3bc4951e38bc24cc8c2b7867cfdd952fb860d Reviewed-on: https://chromium-review.googlesource.com/974443Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#545602}
-
David Jacobo authored
This one-liner is to make this UI looks like the spec, also the other bubbles on the omnibox doesn't have a visible arrow. Bug: None. Test: Build, also on an ARC device enabled poked around with pinterest. Change-Id: Iad9913d68d86b9a276f793b5a34962644c836344 Reviewed-on: https://chromium-review.googlesource.com/978671Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: David Jacobo <djacobo@chromium.org> Cr-Commit-Position: refs/heads/master@{#545601}
-
Alexey Kozyatinskiy authored
TBR=pfeldman@chromium.org Bug: chromium:825349 Change-Id: I70390a29c684afa69555b14aa20b96345d5ce1e3 Reviewed-on: https://chromium-review.googlesource.com/978844Reviewed-by:
Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#545600}
-
Jonathan Metzman authored
TBR=inferno@chromium.org Change-Id: I0aa9a1a30dba80b064b0fcb59598d69def1f8071 Reviewed-on: https://chromium-review.googlesource.com/978866 Commit-Queue: Jonathan Metzman <metzman@chromium.org> Reviewed-by:
Abhishek Arya <inferno@chromium.org> Reviewed-by:
Jonathan Metzman <metzman@chromium.org> Cr-Commit-Position: refs/heads/master@{#545599}
-
Zhiheng Vincent Li authored
1. Intead of hard code the initial visibility priority, add a parameter to allow web app to set its initial value of visibility priority. 2. Report visibility change to cast apps through intents and JNI interfaces. This is a follow up change of https://chromium-review.googlesource.com/c/chromium/src/+/940809 Design doc: go/cast-to-android Test: cast_shell_junit_tests browsertests Bug: b/65100261 b/72227153 b/72436346 b/72237087 b/72912957 b/72436104 b/72712171 Change-Id: I6189b55beca64e3529a0f43fbef9790dbd3f0c2e Reviewed-on: https://chromium-review.googlesource.com/977057 Commit-Queue: Zhiheng(Vincent) Li <vincentli@google.com> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#545598}
-
Ken MacKay authored
Add a hack (since priority inheritance doesn't work with PostTask) to avoid priority inversion on the mixer thread, to reduce underruns. Add logging for per-stream underrun. Add some special-case buffering for communications streams to avoid issues with voice calling. Bug: internal b/74603750 Change-Id: I82be8f03558cccac6bf04967ef48a31828f29cda Reviewed-on: https://chromium-review.googlesource.com/977037 Commit-Queue: Kenneth MacKay <kmackay@chromium.org> Reviewed-by:
Stephen Lanham <slan@chromium.org> Cr-Commit-Position: refs/heads/master@{#545597}
-
Matt Wolenetz authored
Conditionally disables these 2 tests on windows dbg builds. BUG=825038,823003 TBR=tsepez@chromium.org,thestig@chromium.org NO-TRY=True Change-Id: I31b9365a71c29c794af7c1c424d3f6eeed9ea708 Reviewed-on: https://chromium-review.googlesource.com/978940Reviewed-by:
Matthew Wolenetz <wolenetz@chromium.org> Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Cr-Commit-Position: refs/heads/master@{#545596}
-
Candice Sy authored
Undoing the reordering from https://chromium-review.googlesource.com/969925 because this change created bugs related to starting/stopping the foreground service. Correct usage of notifyDownloadPaused() with isAutoResumable true and of notifyDownloadInterrupted() is to mark downloads as pending if they are not already paused. Bug: 812576,825113,825163 Change-Id: I6c33e035ec501c418c93acff916b7852f2b66cbd Reviewed-on: https://chromium-review.googlesource.com/978612Reviewed-by:
Joy Ming <jming@chromium.org> Commit-Queue: Candice Sy <cmsy@google.com> Cr-Commit-Position: refs/heads/master@{#545595}
-
Amirhossein Simjour authored
This reverts commit a8b44439. This will fix the problem with keyboard not staying after tap. I reopen 820898. Bug: 825175 Change-Id: I41ca2828fe6f81ac8c6569ebe99f97616506bcb5 Reviewed-on: https://chromium-review.googlesource.com/978035Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Amirhossein Simjour <asimjour@chromium.org> Cr-Commit-Position: refs/heads/master@{#545594}
-
Lei Zhang authored
Change-Id: I388cf30b67d43939bfca0f8827d5fe3339ed123d Reviewed-on: https://chromium-review.googlesource.com/978480Reviewed-by:
Wei Li <weili@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#545593}
-
Ian Vollick authored
This updates the system indicators to match the spec. When hovered, a tooltip appears with details. Bug: 824187 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ie5c44bb0e448febe4c253d6ce91a0b43aad50535 Reviewed-on: https://chromium-review.googlesource.com/978614Reviewed-by:
Christopher Grant <cjgrant@chromium.org> Commit-Queue: Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#545592}
-
David Benjamin authored
Bug: none Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I39b362f41eeb9f8d8951bf3f73900bbb39d36df1 Reviewed-on: https://chromium-review.googlesource.com/977005Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#545591}
-
Ryan Landay authored
The logic in StackLayoutBase#setTabLists() has a bug that's causing it to not reduce the number of stacks properly when the number of TabLists is reduced. This does not affect the StackLayout used in production since it always uses a fixed number of stacks, and I apparently didn't notice this when testing the prototype I was working on at the time. Bug: 648314 Change-Id: I93374f398b376ad2f39a09211d928abb407af0b6 Reviewed-on: https://chromium-review.googlesource.com/972199Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Ryan Landay <rlanday@chromium.org> Cr-Commit-Position: refs/heads/master@{#545590}
-
Chromium WPT Sync authored
Using wpt-import in Chromium bf5bef7e. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/14369 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: yhirano@chromium.org, mkwst@chromium.org, japhet@chromium.org: external/wpt/fetch TBR=danyao No-Export: true Change-Id: Ia839d9516782a9a2e07cc647f229d571f927f9df Reviewed-on: https://chromium-review.googlesource.com/978037 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#545589}
-
Robert Ma authored
html.idl changed in upstream https://github.com/w3c/web-platform-tests/pull/10110 and imported in https://crrev.com/c/978021 Bug: 825191 Change-Id: Ie1a04e730aabd50c615f1dab079f92eeaa22565a Reviewed-on: https://chromium-review.googlesource.com/978508 Commit-Queue: Robert Ma <robertma@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#545588}
-
Michael Giuffrida authored
ShellExtensionsClient::IsScriptableURL() can be called a lot, so it would be better if it didn't log NOTIMPLEMENTED(). We can consider it to be "implemented". Bug: None Change-Id: I4dd42c526d2aa75f3d7146527f1d6dfa7beb20fa Reviewed-on: https://chromium-review.googlesource.com/967602Reviewed-by:
Ben Wells <benwells@chromium.org> Commit-Queue: Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#545587}
-
Xiaoqian Dai authored
ScreenOrientationController is deleted earlier than SplitViewController in Shell during shutdown, so it's possible to have a nullptr dereference crash. Bug: 817520 Change-Id: I0e4ea1730c34dc7d767edffee80e5f09a88bb7af Reviewed-on: https://chromium-review.googlesource.com/976370Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#545586}
-
Kurt Horimoto authored
Bug: 805120 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I610f604d1f20695d028571166e443c12cd11cc20 Reviewed-on: https://chromium-review.googlesource.com/952766 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#545585}
-
Nasko Oskov authored
When a content script is injected into a document, it can make requests to origins in its manifest. With recent changes to allow Chrome to block cross-site documents, the initiator of content scripts requests was changed to reflect the extension origin. This change meant that SameSite cookies were not attached to those requests. This CL introduces a check for content scripts making subresource requests and tags those requests to allow attaching SameSite cookies. Reland of https://chromium-review.googlesource.com/c/chromium/src/+/896690 Bug: 796480 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I8316f259f8b04c4fad406c398ba5207abef8a00e Reviewed-on: https://chromium-review.googlesource.com/974882 Commit-Queue: Nasko Oskov <nasko@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#545584}
-
Vaclav Brozek authored
The _CheckUmaHistogramChanges checks whether newly added UMA_HISTOGRAM_* calls only use defined histogram names. This CL removes two ways to introduce false positives: * Unrelated macro names which contain UMA_HISTOGRAM as a continuous substring * More than one string literal on the line with the histogram name. While those cases are rare, there seems no downside to fixing them. Bug: 821981 Change-Id: Ie1a803f562883f567d577e742ed2ed87fd0dfe66 Reviewed-on: https://chromium-review.googlesource.com/978245 Commit-Queue: Vaclav Brozek <vabr@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#545583}
-
Paul Irish authored
Change-Id: I8fa0b6e606f828df9677deefbcbf7254359fe5c6 Reviewed-on: https://chromium-review.googlesource.com/974178 Commit-Queue: Paul Irish <paulirish@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Patrick Hulce <phulce@chromium.org> Cr-Commit-Position: refs/heads/master@{#545582}
-
Mike Dougherty authored
Bug: 228355 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I871fe76d7e2d8ce96ce5e70475e503216f711326 Reviewed-on: https://chromium-review.googlesource.com/975996 Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#545581}
-
Xiaoqian Dai authored
Define SPLITVIEW_ANIMATION_RESTORE_OVERVIEW_WINDOW. And also animate the overview window from its position in overview grid to its snapped postion. Bug: 822486 Change-Id: I64a48b33012c428a5529dfea58f048f30c043e73 Reviewed-on: https://chromium-review.googlesource.com/972562Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#545580}
-
Matt Wolenetz authored
Conditionally disables this test on dbg win. BUG=825304,823003 TBR=dpapad@chromium.org NO-TRY=True Change-Id: Ic6950d3d6a2e1fd52a6d30f1f6a549045619ee2f Reviewed-on: https://chromium-review.googlesource.com/978863Reviewed-by:
Matthew Wolenetz <wolenetz@chromium.org> Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Cr-Commit-Position: refs/heads/master@{#545579}
-
erikchen authored
There are no longer any cross-platform consumers of this code. There are two ChromeOS consumers of the latter, which have been extracted into a function only defined on ChromeOS. Bug: 819289 Change-Id: Iaa0c12c94619ba54be44e23eb45abc5337da4621 Reviewed-on: https://chromium-review.googlesource.com/973943 Commit-Queue: Erik Chen <erikchen@chromium.org> Reviewed-by:
Nick Carter <nick@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#545578}
-
Jao-ke Chin-Lee authored
win_chromium_dbg_ng has had 176 tests running over 3 hours in the 1000 builds between 4670 and 3669. Currently, these show up as infra failures rather than test failures. Increase the hard timeout to 4 hours, as no build in the above sample exceeded 4 hours. BUG=731384 Change-Id: Iff6dba2ffb43920aa991cfef7fdc4bb6e5773eb4 Reviewed-on: https://chromium-review.googlesource.com/978673 Commit-Queue: Jao-ke Chin-Lee <jchinlee@chromium.org> Reviewed-by:
Marc-Antoine Ruel <maruel@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#545577}
-