- 20 May, 2019 40 commits
-
-
Kent Tamura authored
Add support of disabledFeatures=['shadow'] in a custom element definition. It disables Element.attachShadow(). Specification PR: https://github.com/whatwg/dom/pull/760 The behavior is behind "ElemnetInternals" runtime flag. Bug: 905922 Change-Id: Ib950883b5c995945eb60bf9b92c715ad3996dfa4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1609022 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Hayato Ito <hayato@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#661327}
-
Tsuyoshi Horo authored
I submitted crrev.com/c/1619582 before fixing misspelling. TBR=ksakamoto@chromium.org Bug: 935267 Change-Id: I7611ccabbf05bbc6d7139efde3a1275537abf16c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1619592Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#661326}
-
Fredrik Söderquist authored
Change-Id: Ibed70c17d5ba2bb9a9073e5b6174896744064a80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1619689 Commit-Queue: Daniel Bratell <bratell@opera.com> Auto-Submit: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#661325}
-
Robbie Gibson authored
This CL adds the G icon as a fallback icon for answers with no more specific icon. It also renames the "currency" imageset to "stock" as that icon is actually used for the stock price suggestion, not the currency conversion suggestion (which uses the "conversion" icon). Bug: 963860 Change-Id: I446a07cbab6b1a5ab0a38629947d09e17522499e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614219 Commit-Queue: Robbie Gibson <rkgibson@google.com> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#661324}
-
Mathias Carlen authored
Before this patch, we kept adding new observers to the list of cache data observers when closing the app (without the app being destroyed). Resuming the activity by triggering another run would reuse the existing profile cache and the default profile image was shown. This patch introduces a destroy() function to the header coordinator so that it can clean up internals when we go out of scope. In particular it removes the profile data observer registered in the constructor. Bug: b/132379462 Change-Id: I96c473b6748bd8b7105cab58bfdb497411e6f93c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1609779 Commit-Queue: Mathias Carlen <mcarlen@chromium.org> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#661323}
-
Chromium WPT Sync authored
Using wpt-import in Chromium adf1af3d. With Chromium commits locally applied on WPT: c4dc3441 "[WPT] Reland Upload a test for sending mouse events with key pressed" fec827fb "Added wpt tests for overscroll customization." c9077e39 "Restore original tail-processing for ScriptProcessor and AudioWorklet" d814fafc "Check for detached ArrayBuffers in Web Bluetooth writeValue functions" 64cbdf7a "Replace originOffset public member with getOffsetReferenceSpace method" e90c6ef0 "NG/DL: Implement size containment (and display lock) for NG fieldset algo" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Ib989922e053045fad4fc79be505077aac5d4d6fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1619334Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#661322}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/866576d99019..7676d01d0f8b git log 866576d99019..7676d01d0f8b --date=short --no-merges --format='%ad %ae %s' 2019-05-20 taylori@google.com Merge "perfetto-ui: Remove search" Created with: gclient setdep -r src/third_party/perfetto@7676d01d0f8b The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I93a2e10c1cd8e6ce85d06d1ed0aa326a7271f006 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1619645Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#661321}
-
arthursonzogni authored
It used to return the routing_id of the RenderFrameProxyHost for which a RenderFrameProxy was initialized. This is a bit arbitrary and as a result, among 6 callers, nobody was using it, except BrowserPluginHost. It is probably better to return nothing instead. Bug: None. Change-Id: Idcc46d469f3eae53cabd5d09fa29636165804b69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614177 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#661320}
-
chrome://flags#enable-sxg-subresource-prefetchingTsuyoshi Horo authored
Bug: 935267 Change-Id: Ibec8974f52a703ac3930517ce3a9de0bfb13f94f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1619582Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#661319}
-
Koji Ishii authored
Following r659675 (crrev.com/c/1612219), this patch guards |FirstLineBoxTopLeft()| from when the layout tree is dirty. Normally, all calls are limited to only when layout is clean. However, scroll anchoring reads fragment data from dirty tree after r660998 (crrev.com/c/1615680). Ideally, we'd like to guard |FirstInlineFragment()| instead. This aligns the concept of r659675, but ~10 tests in AX and scroll anchoring depends on reading dirty trees. This indicates that there are cases where we want to read dirty trees. What to do more for reading dirty tree is for future investigations. Bug: 964619, 963103, 964854 Change-Id: I7ed4f9aac554f27ab8c2848a6d0b09a1e070215e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1619512 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#661318}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/3b6e788f138b..af03ff75d3a7 Created with: gclient setdep -r src-internal@af03ff75d3a7 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=mbarowsky@google.com,sidereal@google.com Change-Id: I7ed0197f739bc9b614837a9c73e5704a2b755ace Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1619643Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#661317}
-
Eric Willigers authored
'left' and 'right' values for the 'text-underline-position' property shipped in M71. https://www.chromestatus.com/features/5749634488074240 The flag TextUnderlinePositionLeftRight has been enabled since https://chromium-review.googlesource.com/1226485 BUG=313888 Change-Id: I893bbc0d402439a092c96d39b629dd8c94627622 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1616832Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#661316}
-
Eric Willigers authored
Inheritance, parsing and computed value tests for background-position-x, background-position-y https://drafts.csswg.org/css-backgrounds-4/#background-position-longhands BUG=964885 Change-Id: I55630b41918557be536f28e3eb640bb3fc803c4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614007 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#661315}
-
Yoshifumi Inoue authored
This patch converts use-after-tree to CHECK() by changing Element#innerText to cause CEHCK() instead of DCHECK in StringView constructor to avoid use-after-tree. Note: We are not sure of root causes both use-after-free tree and wrong StringView constructor call. Bug: 964464 Change-Id: If4d289c8f6fe4072c1869553cd952d0c153a3369 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1619510Reviewed-by:
-
Ren-Pei Zeng authored
The size of SharedMemoryHandle is now checked when mapping, so we should pass correct buffer sizes in JEA. Bug: b:133119111 Test: Take picture and check HW encoding works from /var/log/messages. Change-Id: I30c95e85a329f95083ae16cf3383ff3377e53409 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1619517Reviewed-by:
Ricky Liang <jcliang@chromium.org> Commit-Queue: Ren-Pei Zeng <kamesan@chromium.org> Cr-Commit-Position: refs/heads/master@{#661313}
-
Takashi Toyoshima authored
UMA_HISTOGRAM_COUNTS_10000 was to small for measuring total memory pressure in bytes. 10M or larger range would be preferable. Bug: 961602 Change-Id: I4e94ca973d65a74860cd16a0d424e1ea128a39b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1619452 Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Auto-Submit: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#661312}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/82728b140ee0..866576d99019 git log 82728b140ee0..866576d99019 --date=short --no-merges --format='%ad %ae %s' 2019-05-20 taylori@google.com Merge "perfetto-ui: Replace query with fast version" 2019-05-20 taylori@google.com Merge "perfetto-ui: Fix performance issue when opening panels" Created with: gclient setdep -r src/third_party/perfetto@866576d99019 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I99aabbc59f9025dabf2e888c46a9d68e4ced3a89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1619644Reviewed-by:
-
Eric Willigers authored
https://drafts.csswg.org/css-logical-1/#propdef-inset-block Change-Id: I32ba1428ab52ce8003add1fb5b0b4d4d17cfea88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1615402Reviewed-by:
-
Peter K. Lee authored
Change-Id: I6dedc52a8f0eb4ff4bd0186158485bd15671e89e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618316 Auto-Submit: Peter Lee <pkl@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#661309}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/ed2255b4ea13..f4c66ccafcb7 git log ed2255b4ea13..f4c66ccafcb7 --date=short --no-merges --format='%ad %ae %s' 2019-05-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 06de90c66c18..70958d15db70 (8 commits) 2019-05-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 5ca9f956..4dc9df3b (533 commits) 2019-05-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader ab1e2b49fe88..7ab65834bc02 (24 commits) Created with: gclient setdep -r src/third_party/skia@f4c66ccafcb7 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=csmartdalton@google.com Change-Id: Ic5e8c89c1215cd0d85c5834056a0bc682dd087b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1619551Reviewed-by:
-
Yi Su authored
This CL moves WKNavigationDelegate.didStartProvisionalNavigation from CRWWebController into CRWWKNavigationHandler. Bug: 956511 Change-Id: Ie20352c10350b00842c4ff8ce037f2e2f1df85de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617354 Commit-Queue: Yi Su <mrsuyi@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#661307}
-
Hirokazu Honda authored
media::BitstreamBuffer should be read-only if it is created from base::SharedMemoryHandle. The BitstreamBuffer for input buffers on video decoding and video encoding should not be modified by video decoder and encoder. In other words, they should be read-only. This CL sets |read_only| to true in VideoDecodeAccelerator/VideoEncodeAccelerator Client for ARC++ path. Bug: None Test: Play videos with YouTube app Test: Record videos with Google Camera App Change-Id: I1fd96881ee27ad46c47bd8bc0df6d1c748ccfbad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1619449 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Matthew Cary <mattcary@chromium.org> Cr-Commit-Position: refs/heads/master@{#661306}
-
Eric Willigers authored
flood-color accepts <<color>> values. https://drafts.fxtf.org/filter-effects/#propdef-flood-color The computed flood-color value for rgb() and rgba() is as specified. The computed flood-color value for color keywords, hex values and 'transparent' is an rgb() or rgba() function. https://drafts.csswg.org/css-color-3/#foreground Change-Id: Iae210734d3829964ad64ae4a7ba7899c391b1898 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1619518 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
-
Yi Su authored
This CL moves WKNavigationDelegate.decidePolicyForNavigationResponse from CRWWebController into CRWWKNavigationHandler. Bug: 956511 Change-Id: I03be8af43fd644ef87fde6ef215098725ab1f33e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617491 Commit-Queue: Yi Su <mrsuyi@chromium.org> Reviewed-by:
-
Eric Willigers authored
Computed value is per side, either the keyword auto or a computed <length-percentage> value. https://drafts.csswg.org/css-scroll-snap-1/#propdef-scroll-padding Change-Id: Id3200ae8a8af9a2e8ee87e675d14f3a6965ea841 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1619454 Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I117a5cb0b4e7d28d3463b9d660763831da466a7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1619642Reviewed-by:
-
Yi Su authored
This CL moves WKNavigationDelegate method "webView:decidePolicyForNavigationAction:decisionHandler" from CRWWebController into CRWWKNavigationHandler. Bug: 956511 Change-Id: I174e56214a59c8f272c36d983445fe4e230fc8ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1609906 Commit-Queue: Yi Su <mrsuyi@chromium.org> Reviewed-by:
-
Christian Dullweber authored
SessionStorageNamespaceImplMojo::RemoveOriginData didn't call its callback when the origin was not found in origin_areas_. Bug: 963533 Change-Id: Id71bc617d0d9d28d164a1f0ec97e76d18c2b1b47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1615180Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#661300}
-
Ramin Halavati authored
Profile::GetProfileType() is made protected to persuade usage of profile type functions (IsRegularProfile, IsIncognito, IsGuestProfile). Bug: 947933 Change-Id: Ie049488fa714002b3a0372946040fef82672d440 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611986Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#661299}
-
Kent Tamura authored
Tests in custom-elements/tentative were upstreamed to WPT by https://github.com/web-platform-tests/wpt/pull/15740 . Bug: 905922 Change-Id: I3e0b24486562b69e6fa212fd93927d3811d13967 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1619590Reviewed-by:
-
Victor Hugo Vianna Silva authored
We introduce a new layer FaviconRequestHandler that is used by both FaviconSource and RecentTabsMenuModel to request favicons by pageurl. The layer first queries the local storage (FaviconService) and if that fails then queries sync storage (FaviconCache). No behavior is changed. Bug: 955475 Change-Id: I4836cd21cc6a7f30147c84f5de04fdef3d1a32ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1603563 Commit-Queue: Victor Vianna <victorvianna@google.com> Reviewed-by:
Esmael El-Moslimany <aee@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Auto-Submit: Victor Vianna <victorvianna@google.com> Cr-Commit-Position: refs/heads/master@{#661297}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/cf6269b441f1..7639f1999ac1 git log cf6269b441f1..7639f1999ac1 --date=short --no-merges --format='%ad %ae %s' 2019-05-20 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@7639f1999ac1 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: Id9f3e9ed2b697f705e270f996c481e20557fc3d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1619559Reviewed-by:
-
Kent Tamura authored
This CL follows the latest specification PR; https://github.com/whatwg/html/pull/4383 Add the |anchor| argument to setValidity(). ElementInternals has a data member to store it. ListedElement shows a validation bubble on ValidationAnchor() result, which returns the data member if it's not null, returns the target element otherwise. Internals::isValidationMessageVisible() is updated so that it asks ValidationMessageClient directly because we can show validation bubble on any elements. Bug: 905922 Change-Id: I20e1bdfeed6ab2635fd3f171e5160feeba170681 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614644 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
-
Roman Sorokin authored
Just went through all cases on a real device and corrected the mixin a bit. Bug: 952855 Change-Id: I941473ce9ea2bf92b5d8c70637a5a1b4077b3a41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1615143Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#661294}
-
Jia authored
This contains the following changes 1. In addition to saving a trained personal curve, we also save global curve and model iteration count when a new curve is saved. 2. Saved model is discarded if initial global curve specified from config or finch is different from the saved global curve. 3. No longer need to fetch finch params "auto_brightness_als_horizon" and "model_als_horizon_seconds" from adapter.cc or modeller_impl.cc because finch-flag checking is done by model_config_loader.cc Bug: 881215 Change-Id: If6f7718948ae675909eb18ab1b216b7d83be62b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1609746Reviewed-by:
Michael Martis <martis@chromium.org> Commit-Queue: Jia Meng <jiameng@chromium.org> Cr-Commit-Position: refs/heads/master@{#661293}
-
David Jean authored
This is a reland of 950edae3 Original change's description: > [ios] extract JS injection from web controller > > Moved JS injection relative code to a new class in crw_js_injector. > Updated CRWJSInjectionEvaluator to have a executeUserJavaScript that > seemed to logicaly have been there already. > > Bug: 954137 > Change-Id: I3a80c995de82329f22532d791c20d84b9ecbfe46 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1571703 > Commit-Queue: David Jean <djean@chromium.org> > Reviewed-by: Eugene But <eugenebut@chromium.org> > Reviewed-by: Mike Dougherty <michaeldo@chromium.org> > Reviewed-by: Mark Cogan <marq@chromium.org> > Cr-Commit-Position: refs/heads/master@{#657195} Bug: 954137 Change-Id: I1b4950cc3bf5c7ebe0f38b82c080324bd42c845f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1601051 Commit-Queue: David Jean <djean@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
-
Yi Su authored
This CL adds an unittest containing one test case for wk_web_view_util.IsSafeBrowsingWarningDisplayedInWebView. Notice that private API of WKPreferences and WKWebView are used in this test case to enable safe browsing and to display the warning. It's also only supported by iOS 12.2+. Bug: 956511 Change-Id: Ib39f7b3ba544bbc07d3b579ac6bf29c619e25f7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617483 Commit-Queue: Yi Su <mrsuyi@chromium.org> Reviewed-by:
-
Ren-Pei Zeng authored
Correct the size parameters used to create SharedMemoryHandle. Bug: b:132928975 Test: Open camera app and check JDA is working in messages. Change-Id: Ib2f18ed80fce1b55b983780cea541b111d18f903 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1616874Reviewed-by:
-
Peter K. Lee authored
This has been removed from @protocol ActivitySErvicePositioner Change-Id: I3a5a3676dfc8f2d3451f38bb4b3409e1429c8df4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1616931 Auto-Submit: Peter Lee <pkl@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#661289}
-
Abhijeet Kandalkar authored
This CL uses IsA<FooElement> and To<FooElement> as replacement for casting helper ToFooElementOrDie. Bug: 891908 Change-Id: Ib14fc4e89089b44c6d5be94a4930e3b467283dcf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1616927Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Cr-Commit-Position: refs/heads/master@{#661288}
-
