- 09 Dec, 2020 17 commits
-
-
Amr Aboelkher authored
The PSM RLWE OPRF/Query response will be assigned to the DeviceManagementResponse in several places after providing the mocked async replies from the server. Thus, this CL is providing helper functions to assign these replies accordingly. The async replies will be used to mock the behaviour when the PSM is in progress and OnConnectionChanged has been triggered, which will trigger RetryStep again. That will be needed due to a bug that shows that both protocols will be executed at the same time, instead of waiting until PSM finishes. Its fix, along with tests will be uploaded in another CL. BUG=chromium:1156119 Change-Id: I0e333987c63eac161437a0853049e015d10a7ace Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577496Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Roland Bock <rbock@google.com> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Commit-Queue: Amr Aboelkher <amraboelkher@google.com> Cr-Commit-Position: refs/heads/master@{#834973}
-
James Cook authored
ChangeMetricsReportingState() has side effects that occur even if the reporting state didn't change, including recording an UMA metric and clearing some stability data. Change MetricsRecordingObserver to only call the method when the state actually changed, rather than unconditionally on startup and on change. Bug: 1148604 Test: added to unit_tests Change-Id: Ia510bcb99c5b8dd0ad23e7ade0c8595ad8d86cfa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580841Reviewed-by:
Erik Chen <erikchen@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#834972}
-
danakj authored
The detection code makes a COM SoftwareBitmap from an SkBitmap, and has a DCHECK to verify the bitmap is N32 format, but the mojom allows other formats. We add CHECKs to ensure that a malicious renderer can not produce an incorrectly sized Buffer. R=reillyg@chromium.org Bug: 1156854 Change-Id: Iecfddbf4512f69bb7102378379ff7129426c488a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580027Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#834971}
-
Phillis Tang authored
Add unit tests for install In-Product Help recording and triggering functions. Bug: 1149670 Change-Id: Ibb91438b6a12787b9eac6794ab8747bd13136009 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545782Reviewed-by:
Phillis Tang <phillis@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Commit-Queue: Phillis Tang <phillis@chromium.org> Cr-Commit-Position: refs/heads/master@{#834970}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/09a26915bd92..eca04eeeb8d8 2020-12-08 nifong@google.com Always attempt to flatten images with mskp image ids 2020-12-08 johnstiles@google.com Error out gracefully in SPIR-V when an intrinsic is missing. 2020-12-08 csmartdalton@google.com Assert that no FP needs local coords when the variable is void 2020-12-08 fmalita@chromium.org [svg] Text shaping and layout 2020-12-08 johnstiles@google.com Fix GN dirty checking for SPIR-V test files. 2020-12-08 reed@google.com Add flag to hide non-sampling imageshader factories 2020-12-08 brianosman@google.com Remove legacy reference to fInputColor in GrSkSLFP If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jmbetancourt@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: jmbetancourt@google.com Change-Id: I38a2accea6264c862df702475a20966c6a800828 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2579836Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#834969}
-
Brandon Wylie authored
Bug: 1148747 Change-Id: I4e1a3ed449ae27a2caca8f1387b9bbf4d407aa39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2579720Reviewed-by:
Filip Gorski <fgorski@chromium.org> Commit-Queue: Brandon Wylie <wylieb@chromium.org> Cr-Commit-Position: refs/heads/master@{#834968}
-
Ben Kelly authored
This CL provides an initial implementation of the URLPattern.exec() method. It mainly differs from test() in that it returns a full URLPatternResult object instead of just a boolean. The result object looks something like: { input: <input string or object passed to exec()>, protocol: <component result>, username: <component result>, password: <component result>, hostname: <component result>, port: <component result>, pathname: <component result>, search: <component result>, hash: <component result> } Each URLPatternComponentResult looks like: { input: <input component string>, groups: { <group name or numeric number string>: <matched group value> } } To support extracting matched group values this CL enhances ScriptRegexp to populate an optional vector of strings. In addition, this CL enhances the WPT tests to process expected result objects. In general it is only necessary to provide component results for components that match non-empty inputs. The test runner will automatically add expected results for empty components. This CL also contains a fix in ApplyInit()'s handling of baseURL. The intent was to treat non-specified components as the explicit empty string. The code now does this. This also happens to handle the unexpected behavior of KURL::GetPass() which always returns a null string in place of an empty string. Finally, this CL removes the toRegex() stub as well. That API is unlikely to land in the current form, so lets just remove it until it can be properly designed. Bug: 1141510 Change-Id: Iedd0598a3d5e493c3e7ed0eb5dce4b09019abca3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575343 Commit-Queue: Ben Kelly <wanderview@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#834967}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/3bf980426002..26a24ee9aebf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I5f1651472b4949edb0da279ae618078ee157f922 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580779Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#834966}
-
danielng authored
Currently startup metrics are recorded every time the VM is shutdown using the functionality in the context manager. This is incorrect, we should only be recording startup metrics when a startup attempt has completed. The change makes it so that shutdowns that cancel a startup attempt (noted by startup tasks existing) emit a metric, but other shutdowns do not. Bug: none Change-Id: Iecb5c91e143f3a0550f9bc4bec7283f7c1bebfbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577079Reviewed-by:
Nic Hollingum <hollingum@google.com> Commit-Queue: Daniel Ng <danielng@google.com> Cr-Commit-Position: refs/heads/master@{#834965}
-
Ionel Popescu authored
http://crrev.com/c/2390613 had a nit for the password reveal button id: "passwrod-reveal" -> "password-reveal" Bug: 1124623 Change-Id: I14423cbf7870b2f0e8f30c43bbb81315c4fae230 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2579965Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Ionel Popescu <iopopesc@microsoft.com> Cr-Commit-Position: refs/heads/master@{#834964}
-
Jeffrey Kardatzke authored
BUG=b:153111783 TEST=Fuzzer passes Change-Id: Iab634196b5f5027b2f1feda35c33771201f71ebf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2579789 Auto-Submit: Jeffrey Kardatzke <jkardatzke@google.com> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#834963}
-
Basia Zimirska authored
With this cl adding and removing languages to kAcceptLanguages will be handled by language_prefs. The idea behind this refactoring work is to separate concepts of accept languages (saved in Chrome format, consumed by translate and non-translate clients) and blocked/fluent languages that are stored in translate format and are consumed by translate clients. Next step is to move isFluent from language_prefs to translate_prefs. Bug: 949251 Change-Id: I6971887bec72856c35ca61010c4ff6976f622164 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2565069Reviewed-by:
Megan Jablonski <megjablon@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Trevor Perrier <perrier@chromium.org> Commit-Queue: Basia Zimirska <basiaz@google.com> Cr-Commit-Position: refs/heads/master@{#834962}
-
Sinan Sahin authored
This CL updates the ContextMenuNativeDelegate bridge to hold a reference on the Java side and get a C++ pointer when it will be used. This is done to prevent a use-after-free. Bug: 1150622 Change-Id: Iaf22d7b6ba37923ec98d7e2f7c497dc45b5ce474 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578127 Commit-Queue: Sinan Sahin <sinansahin@google.com> Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#834961}
-
Aaron Leventhal authored
This is the test for the fix in CL:2579523 TBR=vmpstr@chromium.org Bug: 1147481 Change-Id: I3847f6efd43ddaf5c69f4487b7cf55aae18df0d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575815Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#834960}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/cebafe7ed6b7..19739b881bea 2020-12-08 chrche@microsoft.com [Loc] Migrate help to localization V2 2020-12-08 yangguo@chromium.org Save search term in Search panel on keydown rather than on enter. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1136655 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I348815856099bf05fb04626274587730c56ebaa5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2579835Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#834959}
-
Gordon Seto authored
Update device visibility button text in Nearby settings subpage. Fix 'try again' link a11y in Nearby settings subpage dialog so that the entire message is read out by ChromeVox when the link is focused, rather than just the text of the link. Fixed: 1154718, 1156777 Change-Id: I6594bcef97263e1f529112d1d9d5779fa66436a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575885Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Commit-Queue: Gordon Seto <gordonseto@google.com> Cr-Commit-Position: refs/heads/master@{#834958}
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: I2d5b27e7d6c6480b57a34ed6ffa8cdef5a91d2b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2579727Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#834957}
-
- 08 Dec, 2020 23 commits
-
-
Shimi Zhang authored
This test was added before we introduced AwOriginMatcher. Previously, we use ProxyBypassRule which has implicit rule by default and we don't want when no any rule specified and then the origin is matched by implicit rule, see crrev/c/1924874 However, after we introduced AwOriginMatcher, the new matcher doesn't have implicit rule, this test is not necessary anymore. See crrev/c/2069024 Bug: 1030110 Change-Id: Ief6c67c7e46aae1341cfc778caf6e0530b3e072c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580105 Auto-Submit: Shimi Zhang <ctzsm@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#834956}
-
Nancy Wang authored
BUG=1146900 Change-Id: I3063503edd5942983cd51d14ef5a74d03cf12978 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563150 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#834955}
-
Alexander Surkov authored
Bug: 1133330 Change-Id: I91a7ea05fc01c171ad6075a145abb8dba4530d1d AX-Relnotes: n/a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2571797 Commit-Queue: Alexander Surkov <asurkov@igalia.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#834954}
-
Alex Gough authored
This helper is only used in integration.cc so can be moved out of the header. No functional changes. Change-Id: Ia9670e58feb4d6123610545ffdfe941f8cb2c084 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580499 Commit-Queue: Alex Gough <ajgo@chromium.org> Auto-Submit: Alex Gough <ajgo@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#834953}
-
Marijn Kruisselbrink authored
This method was recording its start time, but not its end time. Bug: 1156511 Change-Id: I9318e64d65c95dbd844878428cff2e78c221ecc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580004Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#834952}
-
Robert Ma authored
This is required by rebaseline-cl. Note that this is in fact a JSONP file. The file name is an unfortunate historical artifact. See comments for more details. Bug: 1154085 Change-Id: I0868bcc8a08f2a8bfd3a60176879f9d67c252239 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575584 Commit-Queue: Robert Ma <robertma@chromium.org> Reviewed-by:
Luke Z <lpz@chromium.org> Cr-Commit-Position: refs/heads/master@{#834951}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/56b18c5a..42f37e5c Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I0afe34156b6a1d32ea229870229286ddebd3d7e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2579665Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#834950}
-
Sven Zheng authored
Symbol level was not correctly set and some symbols are missing. Bug: 1156216 Change-Id: I2ac40fedc69a9f8b486420ec8f9bbda03b7c6ad4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576033 Commit-Queue: Sven Zheng <svenzheng@chromium.org> Auto-Submit: Sven Zheng <svenzheng@chromium.org> Reviewed-by:
Michael Moss <mmoss@chromium.org> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#834949}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b57da84fcd71..4997984ca190 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jrw@google.com,domfc@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1156216 Tbr: jrw@google.com,domfc@google.com Change-Id: I23768022fb71b56ab94902f3c2db92fec5b979ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580759Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#834948}
-
Yulun Wu authored
Bug: 1154906 Change-Id: Iccfe3922f1139e552e78dd4f283f19f94d4e0958 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575558Reviewed-by:
Yulun Wu <yulunwu@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Yulun Wu <yulunwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#834947}
-
Min Qin authored
BUG=1155639 Change-Id: I76c425702d914c77e7eb80779957a6d656b823d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574066Reviewed-by:
Xing Liu <xingliu@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#834946}
-
cfredric authored
These methods will be called in later CLs by the implementation of the SameParty attribute. Bug: 1143756 Change-Id: Id256e2a3971dccd4339f167516275a8dbcb46167 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576110Reviewed-by:
Eric Orth <ericorth@chromium.org> Reviewed-by:
Lily Chen <chlily@chromium.org> Commit-Queue: Chris Fredrickson <cfredric@chromium.org> Cr-Commit-Position: refs/heads/master@{#834945}
-
danakj authored
These bitmaps are safer for transport from untrustworthy sources since all bitmaps should be in N32 format and the browser can make bad assumptions as a result. Bug: 1144462 Change-Id: I9f568aeb1a29c546250d7088cb392fe2f1967301 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580010Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#834944}
-
Jonathan Wright authored
https://chromium.googlesource.com/chromium/deps/libjpeg_turbo.git/+log/bbb828223e9c..e9a659a09e96 $ git log bbb828223..e9a659a09 --date=short --no-merges --format='%ad %ae %s' 2020-12-08 jonathan.wright Cherry-pick upstream fix for uninitialised reads Created with: roll-dep src/third_party/libjpeg_turbo Bug: 1156513 Change-Id: I28130aae7f67cfcb174e064d598d869c83ffb3bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580778 Commit-Queue: Jonathan Wright <jonathan.wright@arm.com> Commit-Queue: Leon Scroggins <scroggo@google.com> Reviewed-by:
Leon Scroggins <scroggo@google.com> Cr-Commit-Position: refs/heads/master@{#834943}
-
danakj authored
When ImageSkiaRep makes its bitmap internally, it makes an N32 bitmap, but it also allows callers to pass a bitmap in. Often, these bitmaps come from untrustworthy places. Consumers of ImageSkia assume that bitmaps they pull out of it are N32 color type and use the pixel pointer or getAddr32() to manipulate the contents of the bitmap. If a malicious bitmap was inserted this could lead to out-of-bounds accesses to the SkBitmap. getAddr32() is guarded by an assert but that doesn't protect us from bad actors in the wild. So we add a CHECK() in ImageSkiaRep to ensure all bitmaps coming out of the class will be N32 format. R=sky@chromium.org Bug: 1155258 Change-Id: I3f90e550d8728fce145013b9887987741f1aa1b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574025Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#834942}
-
danakj authored
These bitmaps are safer for transport from untrustworthy sources since all bitmaps should be in N32 format and the browser can make bad assumptions as a result. Bug: 1144462 Change-Id: Ia485df7965d957c908636671ba674d8b5164d4b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575262Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Auto-Submit: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#834941}
-
Kinuko Yasuda authored
Bug: 862175 Change-Id: I6c2db4246f2e332c60df9c208def7a3fd6e75391 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576879Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#834940}
-
danakj authored
These bitmaps are safer for transport from untrustworthy sources since all bitmaps should be in N32 format and the browser can make bad assumptions as a result. Bug: 1144462 Change-Id: Ic7703565594544e958da1e8709d9de55741c1762 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580462Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#834939}
-
Aleks Totic authored
The test asserted that: <table style="table-layout:fixed; width:auto"> getComputedStyle().tableLayout == "auto" This is incorrect per spec: https://drafts.csswg.org/cssom-1/#resolved-values table-layout is not defined as "Resolved value" No existing browsers passed this test. Change-Id: Icf411e47ed8da1d53e59dea16796dc3a7e48a221 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580359 Commit-Queue: Aleks Totic <atotic@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
David Grogan <dgrogan@chromium.org> Auto-Submit: Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#834938}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/26a24ee9aebf..a737e5f65ca1 2020-12-08 treehugger-gerrit@google.com Merge "tp: implement support for scoped slices in async track set" 2020-12-08 delphick@google.com Merge "metrics: Add test for cpu_by_combined_rail_mode table" 2020-12-08 lalitm@google.com Merge "tp: minor refactoring of async track set tracker for scoped slices" 2020-12-08 lalitm@google.com Merge "ui: fix displaying CPU profiles with sample id 0" 2020-12-08 lalitm@google.com Merge "tp: fix nest count handling for async slices" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I41e92854ee29379c39f44037162d1b84337484f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2579998Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#834937}
-
Rachel Carpenter authored
Also add buganizer/os for help_app_ui, media_app_ui and release_notes. Bug: b/175135936, b/175151096 Change-Id: I7bceda1959c133e585637b000586729947e1dc81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2579926Reviewed-by:
Bugs Nash <bugsnash@chromium.org> Commit-Queue: Rachel Carpenter <carpenterr@chromium.org> Cr-Commit-Position: refs/heads/master@{#834936}
-
Evan Stade authored
This change also combines two callbacks into one, since exactly one of them should be called. Bug: 1152276 Change-Id: If607bc48d34993a4ae73dc53e968afa553f9e66b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577013Reviewed-by:
Xing Liu <xingliu@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#834935}
-
Xing Liu authored
waitForOfflinePageSaved should poll and wait instead of only blocking the UI thread for once. Also use OfflineTestUtil to simplify the code. TBR=dtrainor@chromium.org Bug: 1155401 Change-Id: I81f6d00ef6337d4e9d656cdf04720c16c4ca5698 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2579719 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
Brandon Wylie <wylieb@chromium.org> Cr-Commit-Position: refs/heads/master@{#834934}
-