GitLab

. Eliminate the implementation of LayerAnimationObserver. It seems no one expects WED to be a LAO anymore.
. Remove WindowTreeHostDelegate. This involves moving some of the functions to WTH, removing some completely, and moving the remainder to the WED public API. A little icky for now, but I plan to take a pass on cleaning up WED's public API once I get it pared down.
. window_tree_host_x11_unittest provided an implementation of WTHD that was not WED. This is not a valid situation now since various functions in WTH now call directly through to WED. Replaced this with a simple EventHandler to test that events are being dispatched.

R=sky@chromium.org
http://crbug.com/308843

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255368

Review URL: https://codereview.chromium.org/188223002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255533 0039d316-1c4b-4281-b951-d872f2087c98

BUG=341662
TEST=none

Review URL: https://codereview.chromium.org/183663027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255532 0039d316-1c4b-4281-b951-d872f2087c98

* Prevent the banner from being hidden while it's being animated onto the screen for the first time.

* Use the GestureHandler's onShowPress() function to determine when to show a highlight.

* Tweak the fling dismissal behavior so it somewhat takes into account the fling velocity (which often has a sign... or magnitude... that doesn't make sense).  Track a secondary velocity determined by how long it takes for a user to translate the banner.

* Replace the word "banner" everywhere in SwipableOverlayView with "view".

* Change the banner interpolator to make it feel more floaty when it is coming back to the center of the screen.

Submitted as NOTRY=true because the Java-only changed passed the android bots.

NOTRY=true
BUG=341556

Review URL: https://codereview.chromium.org/187593007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255531 0039d316-1c4b-4281-b951-d872f2087c98

BUG=340735
TBR=maruel@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/189783002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255530 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none

Review URL: https://codereview.chromium.org/188393002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255529 0039d316-1c4b-4281-b951-d872f2087c98

All the chromium.mac bots were happy, but the official builder didn't like it.

> Introduce a mock ui_unittests Framework for loading resources.
> 
> This allows ui_unittests to stop depending on the chrome framework.
> 
> On Mac, this creates (e.g.)
> - out/ui_unittests Framework.framework/
>   +-- Resources -> Versions/A/Resources
>   \-- Versions
>       \-- A
>           \-- Resources
>               +-- Info.plist
>               +-- am.lproj
>               |   \-- locale.pak
>               +-- ...
>               +-- chrome_100_percent.pak -> ui_test.pak
>               +-- ...
>               +-- en.lproj
>               |   \-- locale.pak
>               +-- ...
> 
> On other platforms, out/ui_test.pak is loaded directly and
> out/ui_unittests_strings/ is set as the locale folder (for tests that
> load en-US.pak from there). ui_unittests currently depends on
> out/locales/ which is only created when Chrome is built.
> 
> Note that ui_unittests does not currently succeed in a clobber build
> (crbug.com/347851), so that missing dependency is fixed by this change
> as well.
> 
> BUG=331669, 35878, 347851
> TEST=ui_unittests should build and run after clobbering the build folder
> 
> Review URL: https://codereview.chromium.org/152543005

TBR=tapted@chromium.org

Review URL: https://codereview.chromium.org/190133003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255528 0039d316-1c4b-4281-b951-d872f2087c98

Introduces two new StatusChangeCheckers: UpdatedProgressMarkerChecker
and QuiesceStatusChangeChecker.

The first, UpdatedProgressMarkerChecker, is a simple checker for
ensuring progress markers are "fully synced".  It's a bit flaky, but no
flakier than the functions that preceded it.

The second, QuiesceStatusChangeChecker, is intended to be a replacement
for AwaitQuiescence and many other Await* methods.  The logic is
different, but the heuristic used is essentially the same.  We want to
wait until all clients pass the 'HasLatestProgressMarkers()' check, then
make sure that their progress markers match each other.  The new
implementation is a bit simpler, since it takes advantage of the
transitive properties of equality rather than doing O(N^2) comparisons.

The QuiesceStatusChangeChecker is made more complicated by the fact that
the HasLatestProgressMarkers() is not very reliable.  This becomes a
problem in practice if we call that function on some "Profile A" in
response to an event that happened in "Profile B".  So the naive
implementation of QuiesceStatusChangeChecker won't work.

The implementation in this CL uses a system of observers to make the
calls to HasLatestProgressMarker() safer.  It's an ugly hack, but IMHO
no uglier than the existing set of hacks.

BUG=323380

Review URL: https://codereview.chromium.org/184993006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255525 0039d316-1c4b-4281-b951-d872f2087c98

Every time |Screen.GetPrimaryDisplay()| is accessed on Android, which can be
multiple times a frame, we're querying the command-line for
kForceDeviceScaleFactor.  Instead, cache the result of the query, saving ~8us
(50% of the cost) per GetPrimaryDisplay() call on a typical Android device.

BUG=341613

Review URL: https://codereview.chromium.org/186733009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255524 0039d316-1c4b-4281-b951-d872f2087c98

BUG=333129

Review URL: https://codereview.chromium.org/187663005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255523 0039d316-1c4b-4281-b951-d872f2087c98

BUG=341634

Review URL: https://codereview.chromium.org/188753003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255519 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255517 0039d316-1c4b-4281-b951-d872f2087c98

This will allow the core storage API implementation to move to //extensions where app_shell can use it.

* Split SyncOrLocalValueStoreCache into SyncValueStoreCache and LocalValueStoreCache
* Move SettingsFrontend::GetBackendForSync() to settings_sync_util::GetSyncableService()

BUG=348058
TEST=unit_tests *Settings* and browser_tests ExtensionSettings*
TBR=zea@chromium.org for trivial change to chrome/browser/sync/profile_sync_components_factory_impl.cc

Review URL: https://codereview.chromium.org/184043031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255515 0039d316-1c4b-4281-b951-d872f2087c98

This allows ui_unittests to stop depending on the chrome framework.

On Mac, this creates (e.g.)
- out/ui_unittests Framework.framework/
  +-- Resources -> Versions/A/Resources
  \-- Versions
      \-- A
          \-- Resources
              +-- Info.plist
              +-- am.lproj
              |   \-- locale.pak
              +-- ...
              +-- chrome_100_percent.pak -> ui_test.pak
              +-- ...
              +-- en.lproj
              |   \-- locale.pak
              +-- ...

On other platforms, out/ui_test.pak is loaded directly and
out/ui_unittests_strings/ is set as the locale folder (for tests that
load en-US.pak from there). ui_unittests currently depends on
out/locales/ which is only created when Chrome is built.

Note that ui_unittests does not currently succeed in a clobber build
(crbug.com/347851), so that missing dependency is fixed by this change
as well.

BUG=331669, 35878, 347851
TEST=ui_unittests should build and run after clobbering the build folder

Review URL: https://codereview.chromium.org/152543005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255512 0039d316-1c4b-4281-b951-d872f2087c98

BUG=110119

Review URL: https://codereview.chromium.org/187663004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255508 0039d316-1c4b-4281-b951-d872f2087c98

When the disabled-by-default-cc.debug.scheduler category is enabled,
also include the scheduler client state in the dumped data. This is
mainly useful for the the draw, commit and activation time duration
estimates.

No tests since this only affects debugging code.

BUG=347366,309648

Review URL: https://codereview.chromium.org/176973007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255507 0039d316-1c4b-4281-b951-d872f2087c98

partial file, if exists, can no longer be used to complete the download.

R=asanka@chromium.org
BUG=none
TEST=DownloadItemTest.UnresumableInterrupt

Review URL: https://codereview.chromium.org/183743019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255506 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
R=craigdh@chromium.org

Review URL: https://codereview.chromium.org/189913002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255504 0039d316-1c4b-4281-b951-d872f2087c98

Refactor of QUIC's rtt storage and calculation to have a single RttStats
object used by the SentPacketManager, LossDetectionAlgorithms, and SendAlgorithms.

Merge internal change: 62624956
https://codereview.chromium.org/185053006/


QUIC refactor to move the pending_crypto_packet_count_ from the
QuicSentPacketManager to the QuicUnackedPacketMap.

Merge internal change: 62614116
https://codereview.chromium.org/188273003/


QUIC - Fix the spelling error in "frame received." message.

Merge internal change: 62491376
https://codereview.chromium.org/188173003/


Doing a best-effort attempt to send connection close packet for open
quic connection before we call exit().

The actual sending of the connection close is flag protected, though
worst case we'd crash right before exit() anyway.

Merge internal change: 62484710
https://codereview.chromium.org/180953008/


Test only change to QUIC TCPLossAlgorithmTest to ensure the early
retransmit alarms is set for the earliest outstanding packet.

Merge internal change: 62438180
https://codereview.chromium.org/188153003/


CL generated with data from dead-code analysis using Scythe
remove_dead_code tool.

Cleanup of net/quic using Scythe

Merge internal change: 62404986
https://codereview.chromium.org/183683025/


Allow fixed (non-negotiated) values to be sent in QUIC CHLO/SHLO. Also
adds IFCW tag for describing initial flow control window in CHLO/SHLO.

Not used yet.

Merge internal change: 62403534
https://codereview.chromium.org/188183002/


Sync'ing changes with internal tree.

https://codereview.chromium.org/184853014/
Merge internal change: 62295877


Make the VER tag required in QUIC CHLO and SHLO messages.

Merge internal change: 62286870
https://codereview.chromium.org/186313002/

R=rch@chromium.org

Review URL: https://codereview.chromium.org/188333003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255503 0039d316-1c4b-4281-b951-d872f2087c98

Simple cache has been shipping on android stable for a few releases now.
No need to have switch to disable it.

BUG=350143
NOTRY=true

Review URL: https://codereview.chromium.org/187693009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255502 0039d316-1c4b-4281-b951-d872f2087c98

file.

BUG=350057
R=yoz@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/189123002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255501 0039d316-1c4b-4281-b951-d872f2087c98

This CL enables the subtitle and new fullscreen video for chrome.
The new fullscreen mode has been in testing for a while, this Cl will enable this new fullscreen mode.

BUG=262945

Review URL: https://codereview.chromium.org/182493003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255500 0039d316-1c4b-4281-b951-d872f2087c98

Debug metadata is not part of the PNaCl stable bitcode format
so is stripped before deployment. In order to make debugging
easier (no separate translation), allow a separate debug URL
in the NMF file which can point to the unstripped
LLVM-formatted pexe which should still have debug metadata.

BUG= https://code.google.com/p/nativeclient/issues/detail?id=3765
TEST=browser_tests --gtest_filter=*PnaclDebugURL

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=254212

R=bradnelson@chromium.org, bradnelson@google.com, dmichael@chromium.org

Review URL: https://codereview.chromium.org/181153002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255499 0039d316-1c4b-4281-b951-d872f2087c98

This patch is intended for M34

BUG=350063
TBR=cpu@chromium.org

Review URL: https://codereview.chromium.org/188793004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255498 0039d316-1c4b-4281-b951-d872f2087c98

This is part of a series of changes that cleans up code style and unnecessary
members inside FileDownloader.

I've kept this small to make the changes easier to review.

BUG=none

Review URL: https://codereview.chromium.org/186483006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255497 0039d316-1c4b-4281-b951-d872f2087c98

Some CoreAudio drivers may fire device change notifications when
creating a stream; resulting in re-entrancy issues.

BUG=349604
TEST=unittests still pass.

Review URL: https://codereview.chromium.org/187693006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255496 0039d316-1c4b-4281-b951-d872f2087c98

Since the ObjectManager class managers the set of object proxies and
properties structures for remote service it needs to handle the
NameOwnerChanged signal, deleting the current set of objects when a
previously owned name changes to a new owner (or is released) and
re-requesting the set of managed objects when a name is claimed by
a new owner.

BUG=346975
TEST=dbus_unittests

Review URL: https://codereview.chromium.org/177703006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255495 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=N/A

Review URL: https://codereview.chromium.org/189233003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255493 0039d316-1c4b-4281-b951-d872f2087c98

> Fill out the rest of the StringPiece functions for 16-bit.
> 
> I was originally opposed to these since we didn't need them and they were complicated. But I'm wanting to use some of these functions in a different patch, so it seems like a good time to fill out the std::string-like finding functions for StringPiece16.
> 
> This deletes the old StringPieceDetails for which the only point was to share the common stuff between the two BasicStringPiece specializations.
> 
> I used the pattern of having two versions of each function declared in the header and then expanding the template in the .cc file, to avoid template bloat in the header.
> 
> This replaces all of the size_type goop with size_t. Chrome code assumes these are the same and we encourage people to just use size_t in loops, for example, rather than using the size_type of the template they're iterating over. This makes the code more readable in many places. It also solves a problem with declaration ordering since most of the functions that used size_type are now moved above where the size_type is actually declared.
> 
> R=viettrungluu@chromium.org
> TBR=akalin, ben
> 
> Review URL: https://codereview.chromium.org/187793004

TBR=brettw@chromium.org

Review URL: https://codereview.chromium.org/189793002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255492 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
R=mmenke@chromium.org

Review URL: https://codereview.chromium.org/185053007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255489 0039d316-1c4b-4281-b951-d872f2087c98

BUG=349948
TEST=unit_tests,browser_tests
R=asargent@chromium.org, oshima@chromium.org

Review URL: https://codereview.chromium.org/177923010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255488 0039d316-1c4b-4281-b951-d872f2087c98

Previously each individual histogram name had to be hashed and whitelisted.
This had the drawback of older versions of Chrome not knowing about newer
histogram names which were added, and then would be discarded.  Now we match
against known prefixes to allow a broader range of future histogram names.

BUG=317833
R=bbudge@chromium.org, isherman@chromium.org

Review URL: https://codereview.chromium.org/187593009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255487 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None

Review URL: https://codereview.chromium.org/188113002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255484 0039d316-1c4b-4281-b951-d872f2087c98

* GCMProfileService adds a check that the app is currently registered for the sender_id of the sender that sent the message 
* IncomingMessage is extended to add sender_id 
* GCMClientImpl adds the sender_id to the incoming message in the handling code. 
* Adding a test verifying that messages are not delivered when not registered for senders 
* fixing the GCM Profile Service tests that were previously not registering for senders before delivering messages 
* Also: moving the DCHECKS in the GCMClientImpl::HandleIncomingMessage higher up to run them as soon as the checks values are available. 

This CL obsoletes https://codereview.chromium.org/185933003/

BUG=344665

Review URL: https://codereview.chromium.org/185133008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255483 0039d316-1c4b-4281-b951-d872f2087c98

The raw pointer can cause issues: if the ScopedLayerAnimationSettings object survives the
respective LayerAnimator object, a seg fault occurs when ScopedLayerAnimationSettings is deleted.
This is particularly problematic when the animation in question has a 0 duration (which can be
the case for unit tests). When animation's duration is 0, the Animator gets deleted right away,
by the same setter that starts the animation.

BUG=

Review URL: https://codereview.chromium.org/185793005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255482 0039d316-1c4b-4281-b951-d872f2087c98

It is already always on on Android and Chrome OS. Consensus is that we should
turn on on all Aura platform. The flag is a noop on other platforms.

BUG=344083

Review URL: https://codereview.chromium.org/183883023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255481 0039d316-1c4b-4281-b951-d872f2087c98

BUG=349863
TEST=manual

Review URL: https://codereview.chromium.org/188573002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255480 0039d316-1c4b-4281-b951-d872f2087c98

BUG=304341
R=jamesr@chromium.org

Review URL: https://codereview.chromium.org/177923011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255479 0039d316-1c4b-4281-b951-d872f2087c98

NOTRY=true

Review URL: https://codereview.chromium.org/189293003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255478 0039d316-1c4b-4281-b951-d872f2087c98

BUG=133527
NOTRY=true

Review URL: https://codereview.chromium.org/186173002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255477 0039d316-1c4b-4281-b951-d872f2087c98

BUG=349781
NOTRY=true

Review URL: https://codereview.chromium.org/177923009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255476 0039d316-1c4b-4281-b951-d872f2087c98