GitLab

Original CL: Review URL: https://codereview.chromium.org/686503002

BUG=425996
TBR=oshima, sadrul, tbarzic

Review URL: https://codereview.chromium.org/690943003

Cr-Commit-Position: refs/heads/master@{#302142}

BUG=417090

Review URL: https://codereview.chromium.org/627573002

Cr-Commit-Position: refs/heads/master@{#302141}

Method AccountTracker::StartFetchingUserInfo is executed in browser's UI thread, and it causes jank.
In Canary 40.0.2201.2 on Win, 19.9 jph is caused by AccountTracker::StartFetchingUserInfo,
which average execution time in UI thread is 227 ms. On Mac, we have 17.7 jph and 71.1ms avg. I need to instrument
the code inside it to find out which part causes jank.

This is a mechanical change that adds instrumentation required to locate the
source of jankiness (i.e. a long-running fragment of code executed as a part of
the task that causes jank) in the code. See the bug for details on what kind of
jank we are after.
A number of similar CLs were landed, and none of them caused issues. They've
helped to find and fix janky code. The code of the instrumentation is highly
optimized and is not expected to affect performance. The code simply creates a
diagnostic task which is identical to ones created by PostTask or IPC message
handlers. The task gets created only in developer build and in Canary channel.

BUG=422460

Review URL: https://codereview.chromium.org/690073002

Cr-Commit-Position: refs/heads/master@{#302140}

BUG=

Review URL: https://codereview.chromium.org/681103002

Cr-Commit-Position: refs/heads/master@{#302139}

Previously, when generate_v14_compatible_resources.py encountered an
invalid XML file, it showed an error message that didn't tell which
file it was processing. E.g.:

  Traceback (most recent call last):
    ...
    File "/usr/lib/python2.7/xml/dom/expatbuilder.py", line 207, in parseFile
      parser.Parse(buffer, 0)
  ExpatError: unbound prefix: line 6, column 0

Now it also prints the name of the file that couldn't be parsed. E.g.

  Traceback (most recent call last):
    ...
    File "/usr/lib/python2.7/xml/dom/expatbuilder.py", line 207, in parseFile
      parser.Parse(buffer, 0)
  ExpatError: unbound prefix: line 6, column 0
  Failed to parse XML file: chrome/android/res/layout/my_layout.xml

Review URL: https://codereview.chromium.org/661433005

Cr-Commit-Position: refs/heads/master@{#302138}

BUG=423229

Review URL: https://codereview.chromium.org/686803003

Cr-Commit-Position: refs/heads/master@{#302137}

Push Notifications not only support Ask already, it is the default value, so this should match that reality.

BUG=425698

Review URL: https://codereview.chromium.org/689993002

Cr-Commit-Position: refs/heads/master@{#302136}

In Ozone the touch events are received in device coordinates. This
change consolidates the different transformations into one function and
makes it use the touchscreen size when computing the transformation for
Ozone and the framebuffer size for X11.

BUG=425258
TESTS=Manually verified that X11 in single, mirror, extended and docked
mode work with external touchscreen.

Review URL: https://codereview.chromium.org/688183002

Cr-Commit-Position: refs/heads/master@{#302135}

TBR=yurys
BUG=

Review URL: https://codereview.chromium.org/686643003

Cr-Commit-Position: refs/heads/master@{#302134}

This reverts commit ea73a785.

TBR=pstew@chromium.org
BUG=

Review URL: https://codereview.chromium.org/655833007

Cr-Commit-Position: refs/heads/master@{#302133}

Namely, -Winconsistent-missing-override. No behavior change.

BUG=428099

Review URL: https://codereview.chromium.org/687453006

Cr-Commit-Position: refs/heads/master@{#302132}

BUG=421422

Review URL: https://codereview.chromium.org/685403004

Cr-Commit-Position: refs/heads/master@{#302131}

Revert of Add Search Service in Enhanced Bookmark Bridge (patchset #6 id:100001 of https://codereview.chromium.org/637323005/)

Reason for revert:
Broke compilation in http://build.chromium.org/p/chromium.gpu/builders/Android%20Debug%20%28Nexus%207%29/builds/14002

Original issue's description:
> Add Search Service in Enhanced Bookmark Bridge
>
> A Search client is created during initialization of
> EnhancedBookmarkBridge. And when the bridge destructs, search service is
> also destroyed.
>
> BUG=415774
>
> Committed: https://crrev.com/e52346f194e9f2d097b4f6d3fbfa359eca7c92df
> Cr-Commit-Position: refs/heads/master@{#302107}

TBR=tedchoc@chromium.org,danduong@chromium.org,kkimlabs@chromium.org,noyau@chromium.org,lpromero@chromium.org,ianwen@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=415774

Review URL: https://codereview.chromium.org/688883002

Cr-Commit-Position: refs/heads/master@{#302130}

This is needed to make more enums work with GlEnumToString, particularly
CONTEXT_LOST_KHR.

BUG=428332

Review URL: https://codereview.chromium.org/690753005

Cr-Commit-Position: refs/heads/master@{#302129}

Revert of Wait 60s instead of 30s for browser to launch. (patchset #1 id:1 of https://codereview.chromium.org/691683002/)

Reason for revert:
Didn't help -- stuck subprocesses are still showing up.

Original issue's description:
> Wait 60s instead of 30s for browser to launch.
>
> There's a guess that the browser may be launching extremely slowly on
> some bots and that when the browser main process is killed it's
> leaking sub-processes that are in the middle of being spawned.
> Increase the timeout to try to confirm this hypothesis.
>
> BUG=424024
> R=tonyg@chromium.org
>
> Committed: https://crrev.com/7ef2c0036f70bdcc59dd7c8f23c8b7c5a3f114d9
> Cr-Commit-Position: refs/heads/master@{#302087}

TBR=tonyg@chromium.org,nednguyen@google.com
NOTREECHECKS=true
NOTRY=true
BUG=424024

Review URL: https://codereview.chromium.org/667733004

Cr-Commit-Position: refs/heads/master@{#302128}

* It was broken after the git switch (it used SVN internally)
* Generate Pepper indexes to
  c-api-{channel} instead of pepper_{channel}/c

This relies on using Doxygen 1.7.6.1, which was installed by default on Lucid. Doxygen 1.8 does not work, and maybe never will.

You can set the DOXYGEN environment variable to point to a good version of doxygen.

No trybots because it is a documentation generation only change. I tested locally to ensure this wouldn't break stuff.

BUG=none
TEST=local
NOTRY=true
R=sbc@chromium.org

Review URL: https://codereview.chromium.org/591683002

Cr-Commit-Position: refs/heads/master@{#302127}

As discovered by japhet@, if we navigate cross-site in a browser test using the '/cross-site/' redirector syntax, the initial URL is relative to the embedded_test_server, which happens to also be the SiteInstance of the top-level page. This causes an extra process swap, which is unnecessary and can create unexpected effects in the test. I've added GetURL(hostname, path) method to EmbeddedTestServer to give us the proper URL directly without following a redirect path and this CL updates the tests to use this new method.

BUG=418236

Review URL: https://codereview.chromium.org/688363002

Cr-Commit-Position: refs/heads/master@{#302126}

Review URL: https://codereview.chromium.org/690713002

Cr-Commit-Position: refs/heads/master@{#302125}

BUG=425601

Review URL: https://codereview.chromium.org/660563004

Cr-Commit-Position: refs/heads/master@{#302124}

Also just update some closure URLs.

R=arv@chromium.org
TBR=xians@chromium.org,zmo@chromium.org
BUG=none

Review URL: https://codereview.chromium.org/681303005

Cr-Commit-Position: refs/heads/master@{#302123}

Provide an API for callers to list available document scanners,
and to acquire a single-page scan from one such device.  This
currently takes advantage of the lorgnette scanning API in
ChromeOS but can be extended to use native document acquisition
APIs on other platforms.

BUG=375334

R=asargent@chromium.org, mef@chromium.org, asvitkine@chromium.org

Review URL: https://codereview.chromium.org/286933006

Cr-Commit-Position: refs/heads/master@{#302122}

Move all the logic of handling wpr_mode into 1 place. This
also update page_runner_unittest.TestUseLiveSiteFlag to
assert the wpr_mode of network_controller instead of the browser_options.

BUG=418278

Review URL: https://codereview.chromium.org/671873003

Cr-Commit-Position: refs/heads/master@{#302121}

BUG=386048
NOTRY=true

Review URL: https://codereview.chromium.org/694563002

Cr-Commit-Position: refs/heads/master@{#302120}

Only one event factory can exist. Make OnDeviceEvent/ OnDispatcherListChanged
protected will allow to overload this implementation to add specific behaviour
to the evdev input devices one.
Add lgenevet@cisco.com in authors.

Review URL: https://codereview.chromium.org/689933004

Cr-Commit-Position: refs/heads/master@{#302119}

Revert of Reduce frequency of requesting bookmark clusters. (patchset #8 id:140001 of https://codereview.chromium.org/682933002/)

Reason for revert:
This appears to have broken Chromium Linux on Android Arm64 Builder (dbg).

FAILED: /mnt/data/b/build/goma/gomacc /mnt/data/b/build/slave/Android_Arm64_Builder__dbg_/build/src/third_party/android_tools/ndk//toolchains/aarch64-linux-android-4.9/prebuilt/linux-x86_64/bin/aarch64-linux-android-g++ -MMD -MF obj/chrome/browser/android/enhanced_bookmarks/browser.enhanced_bookmarks_bridge.o.d -DV8_DEPRECATION_WARNINGS -D_FILE_OFFSET_BITS=64 -DNO_TCMALLOC -DDISABLE_NACL -DCHROMIUM_BUILD -DUSE_LIBJPEG_TURBO=1 -DENABLE_WEBRTC=1 -DUSE_PROPRIETARY_CODECS -DENABLE_BROWSER_CDMS -DENABLE_CONFIGURATION_POLICY -DDISCARDABLE_MEMORY_ALWAYS_SUPPORTED_NATIVELY -DSYSTEM_NATIVELY_SIGNALS_MEMORY_PRESSURE -DENABLE_AUTOFILL_DIALOG=1 -DCLD_VERSION=1 -DENABLE_PRINTING=1 -DENABLE_MANAGED_USERS=1 -DVIDEO_HOLE=1 -DENABLE_LOAD_COMPLETION_HACKS=1 -DNACL_WINDOWS=0 -DNACL_LINUX=1 -DNACL_OSX=0 -DNACL_ANDROID=1 -DFULL_SAFE_BROWSING -DMOJO_USE_SYSTEM_IMPL -DPROTOBUF_USE_DLLS -DGOOGLE_PROTOBUF_NO_RTTI -DGOOGLE_PROTOBUF_NO_STATIC_INITIALIZER -DAUTOFILL_ENABLE_SYNC -DPASSWORD_MANAGER_ENABLE_SYNC '-DPRECACHE_CONFIG_SETTINGS_URL="https://www.gstatic.com/chrome/wifiprefetch/precache_config"' '-DPRECACHE_MANIFEST_URL_PREFIX="https://www.gstatic.com/chrome/wifiprefetch/precache_manifest_"' -DAPPCACHE_USE_SIMPLE_CACHE -DSK_ENABLE_INST_COUNT=0 -DSK_SUPPORT_GPU=1 '-DGR_GL_CUSTOM_SETUP_HEADER="GrGLConfig_chrome.h"' -DSK_ENABLE_LEGACY_API_ALIASING=1 -DSK_ATTR_DEPRECATED=SK_NOTHING_ARG1 -DGR_GL_IGNORE_ES3_MSAA=0 -DSK_WILL_NEVER_DRAW_PERSPECTIVE_TEXT -DSK_FM_NEW_MATCH_FAMILY_STYLE_CHARACTER=1 -DSK_SUPPORT_LEGACY_TEXTRENDERMODE -DSK_LEGACY_NO_DISTANCE_FIELD_PATHS -DSK_BUILD_FOR_ANDROID -DSK_USE_POSIX_THREADS -DU_USING_ICU_NAMESPACE=0 -DU_ENABLE_DYLOAD=0 -DU_STATIC_IMPLEMENTATION -DFEATURE_ENABLE_SSL -DFEATURE_ENABLE_VOICEMAIL -DEXPAT_RELATIVE_PATH -DGTEST_RELATIVE_PATH -DNO_MAIN_THREAD_WRAPPING -DNO_SOUND_SYSTEM -DANDROID -DPOSIX -DWEBRTC_POSIX -DLIBXML_STATIC -DPOSIX_AVOID_MMAP -DMEDIA_DISABLE_LIBVPX -DXML_STATIC -DWEBRTC_CHROMIUM_BUILD -DWEBRTC_LINUX -DWEBRTC_ANDROID -DWEBRTC_ANDROID_OPENSLES -DMESA_EGL_NO_X11_HEADERS -DUSE_OPENSSL=1 -DUSE_OPENSSL_CERTS=1 -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__GNU_SOURCE=1 -DUSE_STLPORT=1 -D_STLP_USE_PTR_SPECIALIZATIONS=1 '-DCHROME_BUILD_ID=""' -DHAVE_SYS_UIO_H -DDYNAMIC_ANNOTATIONS_ENABLED=1 -DWTF_USE_DYNAMIC_ANNOTATIONS=1 -D_DEBUG -Igen -I../.. -Iobj/chrome/browser.gen -I../../third_party/khronos -I../../gpu -I../../skia/config -I../../third_party/WebKit/Source -Igen/angle -Igen/protoc_out -I../../third_party/protobuf -I../../third_party/protobuf/src -I../../third_party/dom_distiller_js/package/proto_gen -Igen/chrome -Igen/components/strings -I../../third_party/WebKit -I../../third_party/skia/src/core -I../../third_party/skia/include/core -I../../third_party/skia/include/effects -I../../third_party/skia/include/pdf -I../../third_party/skia/include/gpu -I../../third_party/skia/include/lazy -I../../third_party/skia/include/pathops -I../../third_party/skia/include/pipe -I../../third_party/skia/include/ports -I../../third_party/skia/include/utils -I../../skia/ext -I../../third_party/cacheinvalidation/overrides -I../../third_party/cacheinvalidation/src -I../../third_party/cacheinvalidation/google/cacheinvalidation -I../../third_party/icu/source/i18n -I../../third_party/icu/source/common -I../../third_party/webrtc/overrides -I../../third_party/libjingle/overrides -I../../third_party/libjingle/source -I../../testing/gtest/include -I../../third_party -I../../third_party/libxml/linux/include -I../../third_party/libxml/src/include -I../../third_party/zlib -Igen/ui/resources -I../../third_party/re2 -Igen/content/app/resources/ -I../../third_party/expat/files/lib -I../../third_party/leveldatabase/src/include -I../../third_party/leveldatabase/src -I../../third_party/leveldatabase -I../../third_party/libyuv/include -I../../third_party/libyuv -I../../third_party/npapi -I../../third_party/npapi/bindings -Igen/ui/gl -I../../third_party/mesa/src/include -I../../v8/include -Igen/policy --param=ssp-buffer-size=4 -Werror -fno-strict-aliasing -Wall -Wno-unused-parameter -Wno-missing-field-initializers -fvisibility=hidden -pipe -fPIC -Wno-unused-local-typedefs -ffunction-sections -funwind-tables -g -fno-short-enums -finline-limit=64 -Wa,--noexecstack --sysroot=/mnt/data/b/build/slave/Android_Arm64_Builder__dbg_/build/src/third_party/android_tools/ndk//platforms/android-21/arch-arm64 -isystem/mnt/data/b/build/slave/Android_Arm64_Builder__dbg_/build/src/third_party/android_tools/ndk//sources/cxx-stl/stlport/stlport -Os -g -gdwarf-4 -fdata-sections -ffunction-sections -funwind-tables -g1 -fno-exceptions -fno-rtti -fno-threadsafe-statics -fvisibility-inlines-hidden -Wsign-compare -std=gnu++11 -Wno-narrowing -Wno-literal-suffix  -c ../../chrome/browser/android/enhanced_bookmarks/enhanced_bookmarks_bridge.cc -o obj/chrome/browser/android/enhanced_bookmarks/browser.enhanced_bookmarks_bridge.o
../../chrome/browser/android/enhanced_bookmarks/enhanced_bookmarks_bridge.cc: In constructor 'enhanced_bookmarks::android::EnhancedBookmarksBridge::EnhancedBookmarksBridge(JNIEnv*, jobject, Profile*)':
../../chrome/browser/android/enhanced_bookmarks/enhanced_bookmarks_bridge.cc:52:67:error: invalid new-expression of abstract class type 'enhanced_bookmarks::BookmarkServerSearchService'
       EnhancedBookmarkModelFactory::GetForBrowserContext(profile_)));
                                                                   ^
In file included from ../../chrome/browser/android/enhanced_bookmarks/enhanced_bookmarks_bridge.h:12:0,
                 from ../../chrome/browser/android/enhanced_bookmarks/enhanced_bookmarks_bridge.cc:5:
../../components/enhanced_bookmarks/bookmark_server_search_service.h:21:7: note:   because the following virtual functions are pure within 'enhanced_bookmarks::BookmarkServerSearchService':
 class BookmarkServerSearchService : public BookmarkServerService {
       ^
In file included from ../../components/enhanced_bookmarks/bookmark_server_service.h:11:0,
                 from ../../components/enhanced_bookmarks/bookmark_server_search_service.h:12,
                 from ../../chrome/browser/android/enhanced_bookmarks/enhanced_bookmarks_bridge.h:12,
                 from ../../chrome/browser/android/enhanced_bookmarks/enhanced_bookmarks_bridge.cc:5:
../../components/enhanced_bookmarks/enhanced_bookmark_model_observer.h:29:16: note: 	virtual void enhanced_bookmarks::EnhancedBookmarkModelObserver::EnhancedBookmarkNodeChanged(const BookmarkNode*)
   virtual void EnhancedBookmarkNodeChanged(const BookmarkNode* node) = 0;
                ^
In file included from ../../storage/browser/fileapi/plugin_private_file_system_backend.h:13:0,
                 from ../../storage/browser/fileapi/file_system_context.h:20,
                 from ../../content/public/browser/content_browser_client.h:30,
                 from ../../chrome/browser/profiles/profile.h:17,
                 from ../../chrome/browser/android/enhanced_bookmarks/enhanced_bookmarks_bridge.h:10,
                 from ../../chrome/browser/android/enhanced_bookmarks/enhanced_bookmarks_bridge.cc:5:
../../storage/browser/fileapi/file_system_backend.h: At global scope:
../../storage/browser/fileapi/file_system_backend.h:43:13:error: 'storage::kMaximumLength' defined but not used [-Werror=unused-variable]
 const int64 kMaximumLength = std::numeric_limits<int64>::max();

Original issue's description:
> Reduce frequency of requesting bookmark clusters.
>
> Currently, we fetch for bookmarks on SyncCycleCompleted.  We
> actually just want to trigger a request for clusters when
> bookmarks change due to a SyncCycle.  By watching for
> ExtensiveChanges from the BookmarksModel and saving some
> state, we can more accurately determine this.
>
> BUG=424254
>
> Committed: https://crrev.com/2d0c8cfc2d67eea473132d8582430c21529ce897
> Cr-Commit-Position: refs/heads/master@{#302111}

TBR=yfriedman@chromium.org,kkimlabs@chromium.org,noyau@chromium.org,mcolbert@chromium.org,danduong@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=424254

Review URL: https://codereview.chromium.org/693513003

Cr-Commit-Position: refs/heads/master@{#302118}

These test validate that the implementation of the chrome.hid API is using
the API provided by //device/hid correctly. It does not talk to real devices
or validate platform-specific functionality.

BUG=

Review URL: https://codereview.chromium.org/690473002

Cr-Commit-Position: refs/heads/master@{#302117}

RecordStorage will storage data in a file obtained from chrome.syncFileSystem allowing "local" dedupe data to be synced between a users devices.

BUG=420680

TEST=browser_test: *ImportHistoryTest*

Review URL: https://codereview.chromium.org/677213002

Cr-Commit-Position: refs/heads/master@{#302116}

BUG=427031

Review URL: https://codereview.chromium.org/691623002

Cr-Commit-Position: refs/heads/master@{#302115}

This adds the character, and word navigation commands with tentitive key bindings.
There is placeholder code to compute the utterance to be spokenwhich is not suitable for braille.

Review URL: https://codereview.chromium.org/674263003

Cr-Commit-Position: refs/heads/master@{#302114}

Retain the tight 0640 mode for most existing callers, but honor the user's
umask for downloaded files.

This is a re-land of https://codereview.chromium.org/639253004/.

BUG=409416, 362887
TBR=asanka,mdempsky,rvargas

Review URL: https://codereview.chromium.org/689713006

Cr-Commit-Position: refs/heads/master@{#302113}

With current implementation, in-process utility thread clean up is taken care by IO thread on detecting that concern IPC communication channel been closed. And utility thread has ThreadRestrictions to disallowed IO. Apparently it asserts (SIG-ABORT) before performing join in pre-check.

With this CL we are making sure that before IO thread waits for utility thread's cleanup it enables ThreadRestrictions to allow IO for utility thread so that it can join. This avoids chromium crash on fresh launch.

BUG=421007
R=mpcomplete@chromium.org

Review URL: https://codereview.chromium.org/683083002

Cr-Commit-Position: refs/heads/master@{#302112}

Currently, we fetch for bookmarks on SyncCycleCompleted.  We
actually just want to trigger a request for clusters when
bookmarks change due to a SyncCycle.  By watching for
ExtensiveChanges from the BookmarksModel and saving some
state, we can more accurately determine this.

BUG=424254

Review URL: https://codereview.chromium.org/682933002

Cr-Commit-Position: refs/heads/master@{#302111}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/79f8fae..6500760

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=hcm@google.com

Review URL: https://codereview.chromium.org/690953003

Cr-Commit-Position: refs/heads/master@{#302110}

TBR=ncbray@chromium.org
BUG=428838

Review URL: https://codereview.chromium.org/695493003

Cr-Commit-Position: refs/heads/master@{#302109}

BUG=414189
TBR=glider@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/694583002

Cr-Commit-Position: refs/heads/master@{#302108}

A Search client is created during initialization of
EnhancedBookmarkBridge. And when the bridge destructs, search service is
also destroyed.

BUG=415774

Review URL: https://codereview.chromium.org/637323005

Cr-Commit-Position: refs/heads/master@{#302107}

The iOS whitelist was incomplete but things were still working due to
a bug in grit where some resources are being added even if they are not
in the whitelist. The fix for that grit bug is in
https://chromiumcodereview.appspot.com/669763002/

Also, the dependency on ui/native_theme is removed from iOS
because it is unused, allowing the resources to be omitted from the
.pak file.

BUG=None

Review URL: https://codereview.chromium.org/667223003

Cr-Commit-Position: refs/heads/master@{#302106}

Enabled a11y audit test.
Made the tests async in order to run the a11y audit after the UI is settled down.

Fix issue where decorative icon had no descriptive text. Added alt="".
Fix issue where margins were obscured by a warning dialog but were still accessible. When elements are obscured by the overlay, they are now hidden.

Cleaned up redundant code by moving it into functions.

BUG=423178

Review URL: https://codereview.chromium.org/601083004

Cr-Commit-Position: refs/heads/master@{#302105}

It is used to catch problem where the audio fails silently.

BUG=428706

Review URL: https://codereview.chromium.org/685403002

Cr-Commit-Position: refs/heads/master@{#302104}

This test checks that following a cross-site link with rel="nofererrer" does not create a new SiteInstance per https://crbug.com/24447.  However, the test expectations should change with --site-per-process, as we do expect a process swap in this mode.  This is similar to how DontSwapProcessWithOnlyTargetBlank behaves (https://codereview.chromium.org/635933002/).

BUG=417518

Review URL: https://codereview.chromium.org/692703002

Cr-Commit-Position: refs/heads/master@{#302103}