- 16 Aug, 2019 40 commits
-
-
Abhijeet Kandalkar authored
This CL convert .h/.cc to use new mojo types and port dependent files to adopt new implementation. Bug: 955171, 978694 Change-Id: I80bba8d7c1caa5597d1456371d4050b00968ac90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1755797Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Cr-Commit-Position: refs/heads/master@{#687672}
-
Sahel Sharify authored
This cl marks compositing/reflections/nested-reflection-anchor-point.html as flaky on Windows and Linux. flakiness dashboard: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&tests=compositing%2Freflections%2Fnested-reflection-anchor-point.html TBR=schenney@chromium.org NOTRY=TRUE Bug: 994692 Change-Id: I3b0c5b624ce24f4c34207fb3edada8146545ce78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757088Reviewed-by:
Sahel Sharify <sahel@chromium.org> Commit-Queue: Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#687671}
-
Ben Kirchman authored
Bug: 994428 Change-Id: I590987ce4d5e583e9b91252b739ca67d4cfdea66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758324 Commit-Queue: Benjamin Kirchman <kirchman@google.com> Commit-Queue: Paul Jensen <pauljensen@chromium.org> Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Cr-Commit-Position: refs/heads/master@{#687670}
-
Chromium WPT Sync authored
Using wpt-import in Chromium d5ecd93e. With Chromium commits locally applied on WPT: 329c91e5 "Attempt to make test more stable" 02426f68 "Rewrite interpolation-testcommon.js" be8f9eea "[IntersectionObserver] Use inclusive intersect with remote frame parent" 4ba540d7 "Clean up WPT TestExpectations for CSS animations and transitions" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I6265eeb3a545a5dd4aada053599638a8caccafdb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757486Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#687669}
-
Jeffrey Cohen authored
Revert "[SendTabToSelf] Use new cache guid method to assert that local device is not listed as a target" This reverts commit 38392a67. Reason for revert: This caused a regression crbug/991943 on android and i have been unable to determine a root cause of that platform treating the current local cache guid differently than other platforms. Original change's description: > [SendTabToSelf] Use new cache guid method to assert that local device is not listed as a target > > Bug: 966413 > Change-Id: I29fe887806b07a51d7490603aaf81415a5a349cb > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721379 > Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org> > Reviewed-by: Mikel Astiz <mastiz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#682341} TBR=mastiz@chromium.org,jeffreycohen@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 966413 Change-Id: I054d328715c6d71944f06946f5e2631501835cc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757168Reviewed-by:
Jeffrey Cohen <jeffreycohen@chromium.org> Reviewed-by:
Ramya Nagarajan <ramyan@chromium.org> Commit-Queue: Ramya Nagarajan <ramyan@chromium.org> Auto-Submit: Jeffrey Cohen <jeffreycohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#687668}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/material-components/material-components-ios/+log/26ba6a09142b..2ed6691f2848 git log 26ba6a09142b..2ed6691f2848 --date=short --no-merges --format='%ad %ae %s' 2019-08-16 rsmoore@google.com Merge branch 'release-candidate' into stable Created with: gclient setdep -r src/ios/third_party/material_components_ios/src@2ed6691f2848 The AutoRoll server is located here: https://autoroll.skia.org/r/material-components-ios-chromium Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:ios-internal-mdc TBR=bling-p10-rolls@google.com Bug: None Change-Id: I8fa7048c7c42653e073d7a5343702d2a840eb35a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758134Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#687667}
-
Chris Hamilton authored
This entirely retires the old private observer implementation. BUG=910288 Change-Id: I6369c51accc5f38a9145a515cd77c757c5bc28da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1756255 Commit-Queue: Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#687666}
-
Rayan Kanso authored
The Background Sync BackgroundTask fires ready background sync events, which schedules another background task if necessary. This change doesn't allow rescheduling to happen if the firing of events originates from the Background Task. When the events are complete, another background task can be scheduled if necessary. Bug: 991326 Change-Id: I974e7bedae6125dd4e3fe9c3a3693601bb8910f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1755916Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#687665}
-
Anthony Vallee-Dubois authored
Change-Id: Id2972c13c2da888a4c7f2974b933ae190fdfe2fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1756147Reviewed-by:
Alexandre Frechette <frechette@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: anthonyvd <anthonyvd@chromium.org> Cr-Commit-Position: refs/heads/master@{#687664}
-
Finnur Thorarinsson authored
Bug: 993775, 860467 Change-Id: I1cb4cbfa9e66cca8b97a16d56ab95409bd6c97a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1754012 Commit-Queue: Jesse Doherty <jwd@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Auto-Submit: Finnur Thorarinsson <finnur@chromium.org> Cr-Commit-Position: refs/heads/master@{#687663}
-
Shelley Vohr authored
Using const container elements like const std::vector<const std::string> a = {"a"}; will fail when building with libc++ on: 'The C++ Standard forbids containers of const elements because allocator<const T> is ill-formed." Electron encountered this issue as we build Chromedriver with libc++. This fixes the issue by changing the elements to non-const std::strings. Bug: 994347 Change-Id: I309a521fa360e3b36beca53354edadc668a9a12f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1756424Reviewed-by:John Chen <johnchen@chromium.org> Reviewed-by:
Nina Satragno <nsatragno@chromium.org> Commit-Queue: Nina Satragno <nsatragno@chromium.org> Cr-Commit-Position: refs/heads/master@{#687662}
-
Owen Min authored
Enable device info and device local account policy. Pretty print, policy type conversion and user policies are enabled by default. Policy value conversion is disabled by default. Also update the documentation of extension api definition. Bug: 983174 Change-Id: I20747c3b607e41dfd364d6488bb83acd65204d1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757124 Auto-Submit: Owen Min <zmin@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#687661}
-
Owen Min authored
The failure is not able to be reproduced. Going to re-enable the test and watch. Change-Id: I385491388093be9701ed0ff2b58ba6553311f443 Bug: 984902 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1756863Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#687660}
-
Kenichi Ishibashi authored
We've noticed that some tasks related to IndexedDB took considerable amount of time while service worker controlled navigations. Add IndexedDB category to background tracing so that we can check what's going on. Bug: 561209 Change-Id: Ib615bd74ed22dca64205c31bb1eaaf2a60876987 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1745678Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#687659}
-
jongkwon.lee authored
Re-enable interactive uitests that were disabled for crbug/823543 and crbug/824418. These issues are because of crbug/641969 which is no longer reproduced on MacViews browser now. This CL disables StatusBubbleMacInteractiveUITest because ui_test_utils::BringBrowserWindowToFront makes trouble on NSApp hide: and unhide:. BUG=823543, 824418, 641969 Change-Id: Ideab87d4416bdb3f7549b01968c0a5f96eb59107 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1743428Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#687658}
-
Yi Gu authored
WaitForHitTestDataOrChildSurfaceReady has been renamed. Update the comment to reflect the change. Bug: None Change-Id: I417370405a70a5fb04251486684b416007167520 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1754667Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#687657}
-
Hiroki Nakagawa authored
This code path is no longer used. Bug: 967272 Change-Id: Ib426e6895d03c19f6684dfa5c049b1af5e706cba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757607 Auto-Submit: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#687656}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/5a26bf885013..7ee0ac8ea00f git log 5a26bf885013..7ee0ac8ea00f --date=short --no-merges --format='%ad %ae %s' 2019-08-16 taylori@google.com Merge "Split up FrontendLocalState" 2019-08-16 rsavitski@google.com Merge "gcc8+ build fixups" Created with: gclient setdep -r src/third_party/perfetto@7ee0ac8ea00f The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Bug: None Change-Id: I77caf108ec18189664d1a7656cffc0b0ad4bab59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758213Reviewed-by:
-
Abhijeet Kandalkar authored
This CL convert .h/.cc to use new mojo types and port dependent files to adopt new implementation. Bug: 955171, 978694 Change-Id: I4c99d0c576281e759cb18a64d40fe2db07735a17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757964Reviewed-by:
-
Stephen McGruer authored
Previously the generated test names were of the form: property foo from <value> to <value> at <progress> is <actual-value> This read weirdly when the test failed: property foo from 0 to 1 at 0.5 is 'bananas': expected 0.5 but got 'bananas' This CL re-words the test names to read like: property foo from 0 to 1 at 0.5 should be 0.5: expected 0.5 but got 'bananas' Bug: 900581 Change-Id: I77a02a24648171b3945d41cbf81d982879f4500d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758283Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#687653}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/2e905346..7b861aca Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I2d3648ea66b6b1e038793d8ba2618ed632a65b3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757485Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#687652}
-
Edvard Thörnros authored
SVGAnimationElement::calculateKeyTimesForCalcModePaced() used to overwrite the data passed in by the user. This commit fixes the issue and there are now two lists stored, one with the user data and one with the key times for paced. This is a bug fix and should only affect SVGAnimationElements, there will be an increase in memory usage, especially for animation intensive scenes. Can be avoided by changing to a CPU heavy approach, but this will probably be more energy efficient for mobile devices. Bug: 231525 Change-Id: Ief9bbb8c6d1133d0041ad2c8f5a3d63f9ddcde90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757825Reviewed-by:
Fredrik Söderquist <fs@opera.com> Commit-Queue: Edvard Thörnros <edvardt@opera.com> Cr-Commit-Position: refs/heads/master@{#687651}
-
Pavel Shmakov authored
Bug: 994726 Change-Id: I3a03bb71ce29d9b6f7f557d35167387e687d6fe6 TBR=triploblastic@google.com,treib@chromium.org Change-Id: I3a03bb71ce29d9b6f7f557d35167387e687d6fe6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758077Reviewed-by:
Pavel Shmakov <pshmakov@chromium.org> Commit-Queue: Pavel Shmakov <pshmakov@chromium.org> Cr-Commit-Position: refs/heads/master@{#687650}
-
Christian Dullweber authored
This reverts commit b21dff94. Reason for revert: Suspected to cause lots of renderer crashes: crbug.com/994557 Original change's description: > Pass top frame origin to cookie settings > > In order to correctly apply content settings with secondary patterns, > CookieSettings needs to know the TopFrameOrigin of a request. > Currently it only has access to SiteForCookies, which can be an empty > url for cross-origin iframes. > This CL passes TopFrameOrigin from UrlRequests to CookieSettings and > uses this value to look up ContentSettings. SiteForOrigin is still > used to determine whether the cookie is used in a third-party context. > > As TopFrameOrigin is not yet always available, this new behavior is > behind the ImprovedCookieControls flag. > > Bug: 988398 > Change-Id: Ibb6180b68ae9f4780046be6fb2a9dcbb39f9ccf4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1698419 > Commit-Queue: Christian Dullweber <dullweber@chromium.org> > Reviewed-by: Roger Tawa <rogerta@chromium.org> > Reviewed-by: Balazs Engedy <engedy@chromium.org> > Reviewed-by: Mike West <mkwst@chromium.org> > Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> > Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org> > Reviewed-by: John Rummell <jrummell@chromium.org> > Reviewed-by: Nate Fischer <ntfschr@chromium.org> > Reviewed-by: Maks Orlovich <morlovich@chromium.org> > Cr-Commit-Position: refs/heads/master@{#686759} TBR=rogerta@chromium.org,engedy@chromium.org,jrummell@chromium.org,sdefresne@chromium.org,ntfschr@chromium.org,dullweber@chromium.org,mkwst@chromium.org,morlovich@chromium.org,arthursonzogni@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 988398, 994557 Change-Id: I11a101ea05a9f8a095c8750431c978e52d89184b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757832Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#687649}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/cc3fb9940216..96a45cf8d1b0 Created with: gclient setdep -r src-internal@96a45cf8d1b0 The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: Id80a269cd57e15ff11a36801d76a8caa1d57942c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757876Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#687648}
-
Stephen McGruer authored
Bug: 900581 Change-Id: Ib549a18ca17223ee252b2171194e25357f0ef45f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758133Reviewed-by:
-
Morten Stenshorne authored
TBR=eae@chromium.org Bug: 994435, 994550 Change-Id: Ib6844ccb6ebb33634fd6e29e87c70bb43ce9d00b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758071Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#687646}
-
kylechar authored
ARC++ screen capture is returning an empty buffer with OOP-D enabled. This is caused by a synchronization problem in ArcScreenCaptureSession::CopyDesktopTextureToGpuBuffer() where the CopyOutputResult release callback is run immediately after GL commands for texture copy are issued. The release callback would return resources on the same GPU channel as ArcScreenCaptureSession before OOP-D so no explicit synchronization was needed. The display compositor is moved out of the browser GPU so the resources are no longer returned on the same GPU channel. Include a SyncToken from the browser main thread context with the release callback to avoid this. Bug: b/138331095, 994336 Change-Id: I79f417775a259dba0d1f1c586600856c14c2940f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1756704 Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
J Kardatzke <jkardatzke@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Cr-Commit-Position: refs/heads/master@{#687645}
-
Juan Antonio Navarro Pérez authored
This reverts commit 1a5d567a. Reason for revert: Broke cronet/android/test/javaperftests/run.py https://ci.chromium.org/p/chromium/builders/ci/android-cronet-marshmallow-arm64-perf-rel/4349 Original change's description: > [tools/perf] Remove implicit telemetry import in core module > > We want to be able for some tools, e.g. results_processor, to be used > independently of Telemetry. > > Thus, we remove the implicit import for Telemetry when a client > script imports from the core module in tools/perf. > > Also remove convert_legacy_wpr_archive, script no longer works as one > of its dependencies (Python's wpr implementation) no longer exists. > > Bug: 981349 > Change-Id: Iae9569e3a495de6fc08653bc3c2cc1b6e4e6e19f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1755913 > Reviewed-by: John Budorick <jbudorick@chromium.org> > Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> > Cr-Commit-Position: refs/heads/master@{#687600} TBR=perezju@chromium.org,jbudorick@chromium.org Change-Id: I69bda995f0cbc9ef9fe6d058f76bae48d462200f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 981349 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757835Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#687644}
-
Michael van Ouwerkerk authored
Bug: 992345 Change-Id: I2bdb1fda6da817524956b235581e4c474f63e6f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757833Reviewed-by:
Richard Knoll <knollr@chromium.org> Commit-Queue: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Cr-Commit-Position: refs/heads/master@{#687643}
-
Pavel Shmakov authored
Bug: 994722 Change-Id: Idfb87101dc1a63acd26ad154431ee9892dceaa9f TBR=kirchman@chromium.org,pauljensen@chromium.org Change-Id: Idfb87101dc1a63acd26ad154431ee9892dceaa9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758075 Commit-Queue: Pavel Shmakov <pshmakov@chromium.org> Reviewed-by:
-
Eric Karl authored
SurfaceWrapper cannot be parceled / sent over IPC if it has a null SurfaceView. See [1]. Before change [2] we wouldn't return a SurfaceWrapper with a null SurfaceView from GpuProcessCallback.getViewSurface, but now we can, leading to a crash during parceling. This change updates the implementation so we won't generate a SurfaceWrapper with a null SurfaceView. [1] https://cs.chromium.org/chromium/src/content/public/android/java/src/org/chromium/content/common/SurfaceWrapper.java?rcl=478440c3d858369abbda6f79b92c7d4ca7d435bb&l=47 [2] https://chromium-review.googlesource.com/c/chromium/src/+/1597251/5/content/public/android/java/src/org/chromium/content/browser/GpuProcessCallback.java#b25 Bug: 991894 Change-Id: I8a88209643eba355a51840b43c5cfd9a8813bde7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1755346 Auto-Submit: Eric Karl <ericrk@chromium.org> Commit-Queue: Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#687641}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Ie720d7f950a43058db2937385dbdaaebf3d90987 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757875Reviewed-by:
-
Justin Miron authored
The PageLoadMetricsObserverDelegate returns global state about page loads that PageLoadMetricsObservers should have access to. Interfacing with it only requires a const& since every API call is const. BUG=993367 Change-Id: I7aa66649862e7d42cf55fcce4fe9e3d14d0e80c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1756165Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Commit-Queue: Justin Miron <justinmiron@google.com> Cr-Commit-Position: refs/heads/master@{#687639}
-
Michael van Ouwerkerk authored
Bug: 992345 Change-Id: I174c8c4c80a5cfcaa5a3e48845eb6629ab24e87b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758073Reviewed-by:
-
Rafał Godlewski authored
Implements redirecting to password checkup when user clicked "Check passwords" button for the existing dialog case. Clears existing dialog controller on window closing. Bug: 986317 Change-Id: Ieb31842c1d227f25e889e520f4e68f54d318a36c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1754205 Commit-Queue: Rafał Godlewski <rgod@google.com> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#687637}
-
Kenichi Ishibashi authored
Currently EmbeddedWorker::AddMessageToConsole mojo message is effectively no-op as WebEmbeddedWorkerImpl does not implement it. This CL adds an alternative way to show messages for cases where we can't use DevTools attached to the service worker. We want to show a message to web developers when something goes wrong. However, in some situations like the worker isn't responding, there is no available DevTools console (DevTools attached to the worker wouldn't be responding too). When we used shadow page we routed such messages to shadow page's DevTools but shadow page was gone. We need an alternative way to show messages even when DevTools isn't available. This CL adds a method which shows such messages to chrome://serviceworker-internals. Web developers can see such messages in "Log" field when they already opened the page. Bug: 538751 Change-Id: I4f4d8d32968a97798b4068de5568db20f0004fe6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757257 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/7a39c017c233..5a26bf885013 git log 7a39c017c233..5a26bf885013 --date=short --no-merges --format='%ad %ae %s' 2019-08-15 rsavitski@google.com Slightly reword HeapBuffered<> example. Created with: gclient setdep -r src/third_party/perfetto@5a26bf885013 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Bug: None Change-Id: I4f7fd968d1b21ccc381840ae259c934caf7506d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757874Reviewed-by:
-
Stephen McGruer authored
Bug: 900581 Change-Id: Ib213b2fe64062fd6d0be7d6cbecd4a5af0a0498b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757269Reviewed-by:
-
Katharine Daly authored
The LinkProperties.GetPrivateDnsServerName API method can return null, which causes a DCHECK error for Android Pie and above when we convert from Java to c++. Bug: 994459 Change-Id: I5a365df252254bc6f3e8cab4576be8ebce9a589b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757352 Commit-Queue: Paul Jensen <pauljensen@chromium.org> Reviewed-by:
-
