- 06 Jan, 2021 40 commits
-
-
Nico Weber authored
- Make python script do checks directly instead of shelling out to a bash script - Check all symbols against actual framework.order file instead of just checking the symbol at the highest address - Check all global symbols, not just __TEXT __text - Attempt to make error messages friendlier - Add symbols for coverage builds to framework.order (...e.g. on mac-rel) - Run verify-order in asan builds too. Bug: 1159620 Change-Id: I4620f211b596f9a025e65b9a86e7c98489eb5b3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600900 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#840573}
-
Paul Wankadia authored
https://chromium.googlesource.com/external/github.com/google/re2.git/+log/9e5430536b59..c33d1680c7e9 $ git log 9e5430536..c33d1680c --date=short --no-merges --format='%ad %ae %s' 2020-12-30 junyer Make RequiredPrefixForAccel() "see through" capturing groups. 2020-12-29 junyer Correct the WINVER check for SRWLOCK. 2020-11-25 junyer Remove a double space from mksyntaxgo for Go folks. Created with: roll-dep src/third_party/re2/src R=thakis@chromium.org Change-Id: I9bc576045e901a8f5fb04140867ff961097c9073 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610994 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#840572}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/f9a1b53d2809..4dde23fea599 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ieba05819c433a6bcc61674f05a170a2d2bff1160 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611875Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#840571}
-
Gauthier Ambard authored
Launch bug: crbug.com/1137329 Bug: none Change-Id: I2c1c51a92b636c7c3685f84c1ca4e5fb4e3905dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2549706 Auto-Submit: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#840570}
-
Robbie Gibson authored
Fixed: 1138289 Change-Id: I2b5f6e671ac479f8b211927937cfa6961a2b5635 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600745Reviewed-by:
Caitlin Fischer <caitlinfischer@google.com> Commit-Queue: Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#840569}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/goldctl-mac-chromium-autoroll Please CC bsheedy@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: bsheedy@chromium.org Change-Id: I107ed1ce5a0525812a1b06a17eb9471422acdc82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612818Reviewed-by:
-
Morten Stenshorne authored
TBR=sammiequon@chromium.org Bug: 1163489 Change-Id: Id7522dc2da9562b970249b4ab976ccccd31a3ec9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613044Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#840567}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/goldctl-linux-chromium-autoroll Please CC bsheedy@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: bsheedy@chromium.org Change-Id: I4f0faa88e31722a4dcbf75e336d3b459bc7c7cc1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612814Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/07f478f0cc63..cfc9da2f6195 2021-01-06 tvanderlippe@chromium.org Move accessibility-legacy to integration_test_runner If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1131500 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I77169b67acd0d06466e4f9a8b2d03b6eb3ca0f23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612819Reviewed-by:
-
Regan Hsu authored
If the "Silence phone" button is disabled, but the phone is silenced, change the background color of the disabled button to enabled background color with the same disabled background opacity. Screenshots: Disabled and off - https://screenshot.googleplex.com/8iXioEXF9H6osoP Disabled and on - https://screenshot.googleplex.com/6q7mkrQLPUk4zQr Fixed: 1155784 Bug: 1106937 Change-Id: I26ac0ab132115f7e91efcece422945991fbdd09d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605224Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Regan Hsu <hsuregan@chromium.org> Cr-Commit-Position: refs/heads/master@{#840564}
-
Alice Wang authored
This CL removes the non-existent filename in PRESUBMIT.py. Bug: 1152505 Change-Id: I42ea1b13ad96c3c894ab670bbc149fe0ffd10dfb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610921Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#840563}
-
Finnur Thorarinsson authored
Bug: 1146450 Change-Id: I946263d21ca851e78f67788737cfe812b148629c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595296 Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Auto-Submit: Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#840562}
-
Ramin Halavati authored
DevToolsWindow::CreateDevToolsBrowser() assumes that a browser object can be created in all conditions which is not true and can result in a crash. This is fixed by checking for possibility of Browser creation and ignoring passed actions if Browser does not exist. Bug: 1162796 Change-Id: Ibb7cd93b5fa73d00b1223597896e37908e55ad84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2609133Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#840561}
-
Morten Stenshorne authored
This reverts commit c83fe85c. Reason for revert: Made ModeSelectionWindowCycleControllerTest.CycleShowsWindowsPerMode flaky. https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-dbg/22082 Original change's description: > Bento: AltTabMode: Update highlighted window after switching mode. > > Regardless of where the highlight position is, after switching > alt-tab mode, the highlight will be reset to the first or second > window. This is consistent with highlighting when users first > enter alt-tab mode: > - In general case, highlight the second (next) most recently used > window after the current one. > - In the special case that the most recently used is minimized, > highlight itself (the MRU window), so tabbing into it causes it > to unminimize rather than opening up the next window in the list. > > - Track mode switching state in the controller to differentiate > between normal tab pressing and mode switching. > - Add Ash unit tests for both cases. > > `ash_unittests --gtest_filter=ModeSelectionWindowCycleControllerTest.SwitchingModeUpdates*WindowHighlight` > > Bug: 1157100 > Test: Manual test (a video uploaded to crbug) and ash unit tests > Change-Id: Id85b389ba9d59eb1815b8250d640e5aa9128240b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2604907 > Reviewed-by: Xiaoqian Dai <xdai@chromium.org> > Reviewed-by: Min Chen <minch@chromium.org> > Commit-Queue: Cattalyya Nuengsigkapian <cattalyya@chromium.org> > Cr-Commit-Position: refs/heads/master@{#840348} TBR=xdai@chromium.org,minch@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,cattalyya@chromium.org Change-Id: I2551bf6393988d2ee1f790f2f39fdeae9cb0abba No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1157100 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611090Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/goldctl-win-chromium-autoroll Please CC bsheedy@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: bsheedy@chromium.org Change-Id: I6e85072690c5c34dbbba233df4b74cb09c22f9f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612813Reviewed-by:
-
Ramin Halavati authored
Guest option in Signin Intercept is tunneled from UI to DiceWebSigninInterceptor. Bug: 1157764 Change-Id: Ia5f61a6abd38419e13eebaf6cef84ca032ee03da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584933 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#840558}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/af799e0c26ae..3da30cd29fe3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC mstensho@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: mstensho@google.com Change-Id: Ib3fe7616857a037a80d033cb8d34632b98e21212 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612691Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#840557}
-
Morten Stenshorne authored
It doesn't only fail when run as part of virtual/compositor-threaded-percent-based-scrolling-dsf-2/ TBR=joalmei@microsoft.com Bug: 1157857 Change-Id: I862c5ce5ac083b158052d4e9f78369451fd96e6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612965Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1609901004-b6100cca62988d37b209179165fea1bab189422a.profdata to chrome-win32-master-1609912549-501f8e0b1fb8f960dee14203abdc5f5559a20bab.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I1c0448bbcbbb035e774b41bb4a1be821bc19f96a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612809Reviewed-by:
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: I6fe2629408723a0abb5c7fa94a049219f1a9eee8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612924Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#840554}
-
Satoshi Niwa authored
Context : http://b/175833465#comment26 parent_path.Append(child_path) fails if child_path is an absolute path when DCHECK is enabled https://source.chromium.org/chromium/chromium/src/+/master:base/files/file_path.cc;l=494;drc=4aa966b22d5d01458c8e8f80a812c7533f62a0b6 BUG=b:171847983 TEST=unittest Change-Id: Ib7e173d349c29ac22be7c8e11467891de0e3ef3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599685Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Commit-Queue: Satoshi Niwa <niwa@chromium.org> Auto-Submit: Satoshi Niwa <niwa@chromium.org> Cr-Commit-Position: refs/heads/master@{#840553}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/a27c44126b13..07f478f0cc63 2021-01-06 patrick.brosset@microsoft.com Grid: Remove the cssGridFeatures experiment flag If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1162894 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I774d5a9c45a64f63d83116eee7e240c0d7d21cf6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612811Reviewed-by:
-
Guido Urdaneta authored
Replace the raw pointer to a PushableMediaStreamVideoSource with a weak pointer. Bug: 1162036 Change-Id: I9b786cfd3800f8e37daabacf039e6b12e2423f76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610036 Auto-Submit: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Harald Alvestrand <hta@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#840551}
-
Ramin Halavati authored
Adds ephemeral profile tests to StartupBrowserCreatorCorruptProfileTest. Please see go/ephemeral-guest-profiles for more context. Bug: 1125474 Change-Id: Ie1a0c433f6a7e575b59110281d5fb3e9270b2a79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574944Reviewed-by:
Tommy Martino <tmartino@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#840550}
-
David Jean authored
Bug: 1086521 Change-Id: I385697702c6a4bf137e58fb86dd0bc9045e75bd7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601358Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: David Jean <djean@chromium.org> Cr-Commit-Position: refs/heads/master@{#840549}
-
Primiano Tucci authored
https://android.googlesource.com/platform/external/perfetto.git/+log/f9a1b53d2809..4dde23fea5 2021-01-06 primiano@google.com Speculative fix of Fuchsia build by Primiano Tucci 2021-01-06 treehugger-gerrit@google.com Merge "test: Add using statement for testing::DoAll." by Primiano Tucci 2021-01-06 costan@google.com test: Add using statement for testing::DoAll. by Victor Costan 2021-01-05 primiano@google.com Speculative fix of NaCL build 2021-01-05 primiano@google.com Merge "Win port: Disable android_{stats,internal} at build time" 2021-01-05 primiano@google.com Merge "Windows port: LITTLE_ENDIAN, ENTRYPOINT and minor test fixes" 2021-01-05 treehugger-gerrit@google.com Merge "Rename client factory files." 2021-01-05 primiano@google.com Merge "Checkout test data directly in /test, remove symlink" 2021-01-05 primiano@google.com Merge "base: Port subprocess to Windows" Change-Id: I97be23c350c2bfe985c60f2d58fdcbe5574695be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612884 Auto-Submit: Primiano Tucci <primiano@chromium.org> Commit-Queue: Primiano Tucci <primiano@chromium.org> Commit-Queue: Eric Seckler <eseckler@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#840548}
-
Sami Kyostila authored
Make sure the V8_USE_PERFETTO is defined when building the gin bindings with Perfetto enabled. Otherwise v8 and gin will be built using mismatching values of this definition, leading to subtle incompatibilities. Bug: 1006541 Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Change-Id: Ib99c53de684f3d04bbb8c5f95d4e130cbefe207b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611266 Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Auto-Submit: Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#840547}
-
Shengsong Tan authored
This is part of the "Views Posse" effort. See this document: https://docs.google.com/document/d/1Rst3792TjXtVA8k8GXaPD8MnuB1JAneSOpIILdA4268/edit?usp=sharing Bug: 1159562 Test: build Change-Id: I00bcf50061a3e8914608049fe3e3f9a9713852fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602040 Commit-Queue: Shengsong Tan <sstan@google.com> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#840546}
-
dpapad authored
Bug: 1000989 Change-Id: I4ac4ab15f50e1cdd3decee13fbc2630875561ace Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2609848 Commit-Queue: dpapad <dpapad@chromium.org> Auto-Submit: dpapad <dpapad@chromium.org> Reviewed-by:
John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#840545}
-
Peter E Conn authored
Last step of this change: https://chromium-review.googlesource.com/c/chromium/src/+/2563260 Change-Id: Ia33bb0de1c58bc8ab60128ba3ff2bf2d6f04e438 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2607927Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Commit-Queue: Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#840544}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/b590fd1b9a59..382bf2883fa9 2021-01-06 syoussefi@chromium.org Organize AST transforms per backend If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:1084580,chromium:1161513 Tbr: ianelliott@google.com Change-Id: I7595743e0ab3c1ca72eea6812a1969f627a54e48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611993Reviewed-by:
-
Morten Stenshorne authored
This reverts commit 6be1b3d6. Reason for revert: Suspected cause of AutofillPrivateApiTest.GetCountryList browser_test failure. https://ci.chromium.org/p/chromium/builders/ci/Mac10.11%20Tests/59127 Original change's description: > service worker: Simplify main resource "handler" & "interceptor" (1/3) > > ServiceWorkerMainResourceLoaderInteceptor doesn't need to delegate > to ServiceWorkerControlleeRequestHandler to create subresource > params. It can access the ServiceWorkerProviderHost directly. > > This simplifies calling the loader callback. > > Bug: 1138155 > Change-Id: Ibf31c379a755c9c94471c707633a582bf7cba85d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602965 > Commit-Queue: Matt Falkenhagen <falken@chromium.org> > Reviewed-by: Asami Doi <asamidoi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#840506} TBR=falken@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,asamidoi@chromium.org Change-Id: I05ae0bac856d4de7570d7e03980557d8a9cb2b6a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1138155 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612719Reviewed-by:
-
Morten Stenshorne authored
This reverts commit 28610054. Reason for revert: See https://chromium-review.googlesource.com/c/chromium/src/+/2612719 Original change's description: > service worker: Simplify main resource "handler" & "interceptor" (2/3) > > The "handler" can call the loader callback directly. > > Bug: 1138155 > Change-Id: I618991ca62f83d1336405de7f824fcf43c893ac0 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596592 > Commit-Queue: Matt Falkenhagen <falken@chromium.org> > Reviewed-by: Asami Doi <asamidoi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#840521} TBR=falken@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,asamidoi@chromium.org Change-Id: I8be851619679e14b41448625c47e70e62fa4450c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1138155 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612964Reviewed-by:
-
Shengsong Tan authored
This is part of the "Views Posse" effort. See this document: https://docs.google.com/document/d/1Rst3792TjXtVA8k8GXaPD8MnuB1JAneSOpIILdA4268/edit?usp=sharing Bug: 1159562 Test: build Change-Id: Iec730721fe656d85c9a1d89ed321e25586b2b67d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601984Reviewed-by:
-
dpapad authored
Also fix new PRESUBMIT warning about TESTONLY_AND_VISIBILITY in optimize_webui.gni. Bug: None Change-Id: I588d8c3ab26073756e47227cc0813ab5bb890d0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611332 Commit-Queue: dpapad <dpapad@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#840539}
-
Mihai Sardarescu authored
Methods OPrimaryAccountSet/Cleared() are deprecated, so this CL changes the chrome/browser/extensions/api/identity/* to override the method OnPrimaryAccountChanged(). Bug: 1163126 Change-Id: If5a4c51889816e2c7da2f5642f1ea610503f2775 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610101Reviewed-by:
Alex Ilin <alexilin@chromium.org> Reviewed-by:
Tanmoy Mollik <triploblastic@chromium.org> Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#840538}
-
Morten Stenshorne authored
This reverts commit e5b17137. Reason for revert: browser_test OSSettingsSwitchAccessActionAssignmentDialogV3Test.All fails. https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-dbg/22079 Original change's description: > Support device specific keys in Switch Access > > This change implements the infrastructure for assignment and capture of > Switch Access keys tied to a specific type of input device (internal, > usb, bluetooth). > > Along the way, it also cleans up unused code, obsoleted preferences. > > It does not hook up the final UI for the device type which will be > handled separately once UX is finalized. > > R=josiahk@chromium.org > > Bug: 1163226 > Test: preexisting ash_unittests > Change-Id: I381bbfb32e1de25ab6228cac7b52707170e136ab > AX-Relnotes: n/a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599923 > Commit-Queue: David Tseng <dtseng@chromium.org> > Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org> > Reviewed-by: Josiah Krutz <josiahk@chromium.org> > Reviewed-by: Ramin Halavati <rhalavati@chromium.org> > Reviewed-by: Michael Giuffrida <michaelpg@chromium.org> > Reviewed-by: James Cook <jamescook@chromium.org> > Reviewed-by: Josiah Krutz <josiahk@google.com> > Cr-Commit-Position: refs/heads/master@{#840466} TBR=jamescook@chromium.org,dtseng@chromium.org,michaelpg@chromium.org,josiahk@google.com,zentaro@chromium.org,rhalavati@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,josiahk@chromium.org Change-Id: I93cdd3fb63a28b9b20d5271a5dca16985b0282a0 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1163226 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612944Reviewed-by:
-
Elizabeth Popova authored
These are common label values found on top 20 Indonesian websites. This should improve classification when field name is absent or ambiguous. Also modify french regex for names to exclude words like "nombre" and "nomor", but still match "nom" and "nom de famille". Bug: 1154727 Change-Id: I5772df8ce6a1092a800b7178dc17b3ac6c7f2e9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2598853Reviewed-by:
Matthias Körber <koerber@google.com> Commit-Queue: Elizabeth Popova <lizapopova@google.com> Cr-Commit-Position: refs/heads/master@{#840536}
-
David Roger authored
This histogram was created when the feature was implemented. The feature is still working (the histogram still has samples), but it is no longer actively monitored and can be removed now. Fixed: 1144801 Change-Id: Icad11d27f7f5cc1be8f889ccfaf1572e5a3c70a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599856Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#840535}
-
Ella Ge authored
Converting the remaining "base::Bind" and "base::Callback" after crrev.com/c/2600389 and crrev.com/c/2602358. Bug: 1152282 Change-Id: Ic61df1e0346acd6e9ad8c784e21fc436d12fd126 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602378Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#840534}
-
