- 03 Aug, 2017 40 commits
-
-
Doug Turner authored
Currently, nvda_chrome_tests.py _WaitForSpeech will block for a period of time until NVDA speaks some given text. The implementation reads output from a log file that NVDA writes to. This read just starts at the start of the file and builds a list of what was said. This means that each call to _WaitForSpeech() must contain the prior expected text. This CL simply remembers the last offsite and when reading the file again we ignore old stuff. I don't think that re-reading the file is a big deal since we're barely testing with this approach. At some point, if it becomes a problem, we might think of something more clever. Bug: 742592 Change-Id: I47b417f7aa7b7cf8f6f6361d4581ab0ea562a042 Reviewed-on: https://chromium-review.googlesource.com/599373Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Commit-Queue: Doug Turner <dougt@chromium.org> Cr-Commit-Position: refs/heads/master@{#491869}
-
Frank Henigman authored
https://chromium.googlesource.com/angle/angle.git/+log/a0bcc50..13c0dd4 BUG= TEST=bots CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I2cccfe2d8a3fd84eecb9bbb6ecec1b382dcddbda Reviewed-on: https://chromium-review.googlesource.com/600854Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Frank Henigman <fjhenigman@chromium.org> Cr-Commit-Position: refs/heads/master@{#491868}
-
Weidong Guo authored
https://codereview.chromium.org/2946813002 was intended to fix a issue when |contents| is null and bookmark bar exists. But it also unintendedly changed case when when |contents| is null and bookmark bar does not exist. This patch just reverts that case. The crash is not easily reproducible. This CL only speculatively fix the crash. The bug will remain open until the crash is confirmed fix. BUG=744211 Change-Id: Id092d16a75e087650a7edcba27115809de446d57 Reviewed-on: https://chromium-review.googlesource.com/595250 Commit-Queue: Weidong Guo <weidongg@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#491867}
-
Ryan Landay authored
This CL consolidates two switch statements in this method and makes the code easier to follow. It also removes NOTREACHED() from the switch statement to allow adding painting code for a DocumentMarker in a separate CL from the editing changes. Bug: Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Ic125d633078ff3e74105f62ba64c5ebc349002bc Reviewed-on: https://chromium-review.googlesource.com/592327Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Ryan Landay <rlanday@chromium.org> Cr-Commit-Position: refs/heads/master@{#491866}
-
Eric Karl authored
The memory program cache currently uses quite a lot of memory: Up to 6MB on desktop, 2MB on normal Android and 512Kb on low-end Android. Compressing shader binaries results in a 4-10x decrease in size (depending on the driver's binary representation). Compression adds a measureable performance hit (around 500-1000 microseconds). But when compared to overall shader compile/link time, which is around 6000 to 25000 microseconds, this seems acceptable for the memory wins. UMA stats have been added so we can ensure these values behave as expected in the wild. Decompression is fairly cheap (<200 microseconds). Currently, this feature is only turned on for low-end devices, as those are the ones with the most memory pressure. However, if the results are good, it might make sense to enable this in general. Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ie5d389f060504837efc86993811e83af8d630ce8 Reviewed-on: https://chromium-review.googlesource.com/572546 Commit-Queue: Eric Karl <ericrk@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Leon Scroggins <scroggo@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#491865}
-
Reilly Grant authored
This reverts commit fe5c2f3d. Reason for revert: This appears to be causing flake in the WebUSB layout tests. Original change's description: > Dispatch interfacerequest event in a new microtask > > This change modifies the MojoInterfaceInterceptor so that the > 'interfacerequest' event, fired when a request for the intercepted > interface is made, is dispatched in a new microtask instead of > synchronously. > > This has the benefit of not reentering JavaScript to execute event > handlers synchronously which is both different from the usual case for > binding interfaces that are provided by other processes and avoids the > possibilty of attempting to dispatch this event to JavaScript from a > scope where script is forbidden. > > Change-Id: I08b8c25a04da047381a3786af08b62979ca7b837 > Reviewed-on: https://chromium-review.googlesource.com/594716 > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Yuzhu Shen <yzshen@chromium.org> > Commit-Queue: Reilly Grant <reillyg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#491552} TBR=dcheng@chromium.org,yzshen@chromium.org,reillyg@chromium.org Change-Id: Ibc179e1313fceba9a6e8da37e5220ccb6aa7c204 Bug: 751955 Reviewed-on: https://chromium-review.googlesource.com/601007 Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#491864}
-
Stefan Zager authored
Aside from reducing code duplication, this also fixes a few layout tests when root layer scrolling is enabled: accessibility/scroll-to-global-point-main-window.html accessibility/scroll-to-global-point-nested.html accessibility/scroll-to-make-visible-nested-2.html R=dmazzoni@chromium.org,skobes@chromium.org BUG=711468 Change-Id: I1368600b7ce82f1268a69c1a345226dda66dbd03 Reviewed-on: https://chromium-review.googlesource.com/598627 Commit-Queue: Stefan Zager <szager@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#491863}
-
Gauri Manikpure authored
Bug: chromedriver:1910 Change-Id: I66d1fdaab5c1b87deffc3c894d9cdad69c9a39a9 Reviewed-on: https://chromium-review.googlesource.com/599112Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Gauri Manikpure <gmanikpure@chromium.org> Cr-Commit-Position: refs/heads/master@{#491862}
-
Takumi Fujimoto authored
[Media Router] Factor out calls to EventPageRequestManager out of MediaRouterMojoImpl into its own class On desktop, the calls to the MRP are queued with EventPageRequestManager until the Mojo connections with the extension are established. This CL factors out the calls to EventPageRequestManager into MediaRouterDesktop, a subclass of MediaRouterMojoImpl, so that MediaRouterMojoImpl is not aware of extension- related details. Changes to unit tests: - Move tests from MRMojoImplTest to MRMojoTest so that they can shared with MRDesktopTest - Merge MRMojoExtensionTest into MRDesktopTest Bug: 737320 Change-Id: I8271932b0418af2490a2bbea49e444120d9e2aa6 Reviewed-on: https://chromium-review.googlesource.com/572501Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Derek Cheng <imcheng@chromium.org> Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#491861}
-
Robert Sesek authored
A WaitableEvent is now a Mach port with a message queue length of one. Signaling the event enqueues an empty message on the port, or times out if one is already queued. Waiting on the event receives a message on the port, dequeuing it if the event is auto-reset, or just peeking it if the event is manual-reset. WaitMany is implemented by adding all the events' ports to a port set and receiving on it. WaitableEventWatcher is implemented using a TYPE_MACH_RECV dispatch source for auto-reset events and manual-reset events on 10.12. For manual-reset events on macOS prior to 10.12, a lock-protected list of watcher callbacks is used instead of dispatch, because dispatch does not provide timely and reliable invocation callbacks if the event were to be Reset() immediately after Signal(). Bug: 681167 Change-Id: I22a9294ad0ae8900d16716d8033285fe91510eda Reviewed-on: https://chromium-review.googlesource.com/592516 Commit-Queue: Robert Sesek <rsesek@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#491860}
-
Michael Moss authored
RPM packages are going to still be signed with the old key for now because rpm apparently can't handle our new GPG subkeys. R=thestig@chromium.org Bug: 677046 Change-Id: I54037622ca38e20d8403f3f60bab33fcf5e2f8ec Reviewed-on: https://chromium-review.googlesource.com/600893Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Michael Moss <mmoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#491859}
-
Lei Zhang authored
The affected maps all contain very few items. Change-Id: Ib4036f2cdc5a4fbd17518e988a840906e5543a9c Reviewed-on: https://chromium-review.googlesource.com/599588Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#491858}
-
Mike Dougherty authored
Bug: None Change-Id: Idceb31b8ba0d4beb44bfd4f2d16a1faa5b8e531d Reviewed-on: https://chromium-review.googlesource.com/600028Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#491857}
-
Bruce Dawson authored
In order to enable clang-cl's printf format string mismatch checking we need to fix a few dozen existing errors. These are mostly places where DWORD (unsigned long) is printed with %X - an 'l' is needed. This change fixes three of these and these files now build cleanly with clang-cl with PRINTF_FORMAT checking enabled. R=scheib@chromium.org BUG=751171 Change-Id: I6321593fb579f9c70f8adb5f885daffd0e5a6c74 Reviewed-on: https://chromium-review.googlesource.com/598827 Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Vincent Scheib <scheib@chromium.org> Cr-Commit-Position: refs/heads/master@{#491856}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/2857b6b6c858..a62e07f86606 $ git log 2857b6b6c..a62e07f86 --date=short --no-merges --format='%ad %ae %s' 2017-08-03 nednguyen Always use wprgo for Telemetry recording script Created with: roll-dep src/third_party/catapult BUG=730036 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I533077c0f042a0701ea5246e20aca528346e484e Reviewed-on: https://chromium-review.googlesource.com/601048 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#491855}
-
Scott Chen authored
Follow up of 598504 (missed committing a change that I made locally). Bug: 741226 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I03848ef5dd9c9207262c2d48f491d678980e2b9c Reviewed-on: https://chromium-review.googlesource.com/599221Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#491854}
-
Roger McFarlane authored
Only applies when --show-autofill-type-predictions is given. After parsing forms, the autofill manager defers sending the predicted types for queryable forms to the render until the query has completed. If the server predictions don't arrive, the heuristic precictions are never sent to the renderer. This CL sends the predictions for the queryable forms after initial parse (the non-queryable predictions are already sent). If and when the query completes, the predictions are updated as per the current flow. BUG=752225, 715828 Change-Id: Idebcda81317dcb9fcaa3c914983218e449970b65 Reviewed-on: https://chromium-review.googlesource.com/601003Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Commit-Queue: Roger McFarlane <rogerm@chromium.org> Cr-Commit-Position: refs/heads/master@{#491853}
-
Roger McFarlane authored
Corrects the code that generates field title strings when the --show-autofill-type-predictions flag is specified. Formatting bugs were introduced when the string was moved out of the .pak file and into code (escape sequences for string replacement were retained and some values were duplicated/missing due to copy-paste). BUG=703134 Change-Id: Id81a974be4ee12f0c6e2870da2b80c592962d730 Reviewed-on: https://chromium-review.googlesource.com/600994 Commit-Queue: Roger McFarlane <rogerm@chromium.org> Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#491852}
-
Hector Dearman authored
WaitableEvent needs to outlive Thread to avoid a use after return. Bug: 751748 Change-Id: I99181842fd81ccad71dba967deebf5d1014affc7 Reviewed-on: https://chromium-review.googlesource.com/600213Reviewed-by:
Primiano Tucci <primiano@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Scott Graham <scottmg@chromium.org> Commit-Queue: Hector Dearman <hjd@chromium.org> Cr-Commit-Position: refs/heads/master@{#491851}
-
Matthew Halpern authored
This CL enables tab-level CPU profiling infrastructure in GRC (i.e. the resource_coordinator service) and sends collected profiles to UKM. The CPU profiles consist of sequences of CPU measruements collected at a specified interval for a given period. Both the CPU use measurement interval and duration are configurable through Finch parameters. BUG=691886,741768 Change-Id: I486f26db06789e16ff4a80a6c72e9ac869f29d8a Reviewed-on: https://chromium-review.googlesource.com/580288 Commit-Queue: Matthew Halpern <matthalp@google.com> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Zhen Wang <zhenw@chromium.org> Reviewed-by:
Oystein Eftevaag <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#491850}
-
Steven Bennetts authored
This moves the network_proxy element to a shared location so that it can be used by Web UI dialogs. It also adds a network_proxy_section element to handle proxy related prefs that are specific to Settings. Bug: 748204 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I6e0380bddf5448546c2328a3c577a6226b639e7f Reviewed-on: https://chromium-review.googlesource.com/596543 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#491849}
-
Randy Smith authored
I missed a couple of comments in https://chromium-review.googlesource.com/c/581797, so executing on them in a separate CL. TBR=mmenke@chromium.org Bug: 721395 Change-Id: Ica4c496ff28cd202026406f1ebcf4194045c969c Reviewed-on: https://chromium-review.googlesource.com/600632 Commit-Queue: Randy Smith <rdsmith@chromium.org> Reviewed-by:
Randy Smith <rdsmith@chromium.org> Cr-Commit-Position: refs/heads/master@{#491848}
-
Scott Chen authored
- Removes unnecessary registerTests() - Breaks down CrExtensionBrowserTest to smaller sub-classes so test files are included as needed, instead of loading all test files in each TEST_F. (This reduced the generated .cc file from 25XX lines to 16XX lines). - Allow (in the future) each sub-classes to specify a more specific browserPreload url instead of always loading the entire page. Bug: 750842 Change-Id: I9e178728724f41c63e59b4edc81589b4366c9df9 Reviewed-on: https://chromium-review.googlesource.com/595188 Commit-Queue: Scott Chen <scottchen@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#491847}
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/d1a8458e6390..6c740e29640c $ git log d1a8458e6..6c740e296 --date=short --no-merges --format='%ad %ae %s' 2017-08-03 thestig Remove CPDF_Array::Truncate(). 2017-08-02 thestig Do not truncate the filter array in PDF_DataDecode(). 2017-08-03 npm Roll FreeType to 7e50824288fac5a36c2938fdb3e1c949ea53f982 Created with: roll-dep src/third_party/pdfium BUG=750993 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls TBR=dsinclair@chromium.org Change-Id: Ib61110d74872b3efb04880d86ce15d2d95d17ec4 Reviewed-on: https://chromium-review.googlesource.com/600891 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#491846}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/1a2e3e1e77bf..49fd5d5b7407 $ git log 1a2e3e1e7..49fd5d5b7 --date=short --no-merges --format='%ad %ae %s' 2017-08-03 liyuqian Disable Delta AA for MSVC for now 2017-08-01 brianosman Add support for object creation/snapshot/deletion events 2017-08-03 mtklein same 16->8 bit packing trick for SSE2/SSE4.1 2017-08-03 brianosman Add missing newline to initial DM output Created with: roll-dep src/third_party/skia Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=liyuqian@chromium.org Change-Id: Iead48129cdd2f0b130b2625967b4d68145d7c159 Reviewed-on: https://chromium-review.googlesource.com/600889Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#491845}
-
Tommy C. Li authored
Since this feature is completely rolled out, beleatedly turn it on as the default on Chromium. Bug: 696790 Change-Id: Id4b93d7d0882fb51e32326553b699b1ccbaf7e79 Reviewed-on: https://chromium-review.googlesource.com/599114Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#491844}
-
Stephen Martinis authored
Disables the https://www.flickr.com/ story in the thread_times.simple_mobile_sites benchmark TBR=nednguyen@google.com Bug: chromium:#752228 Change-Id: I00f08c1c9b99c6896906801ebc5abfb16e25c209 Reviewed-on: https://chromium-review.googlesource.com/601004 Commit-Queue: Stephen Martinis <martiniss@chromium.org> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#491843}
-
Ben Chan authored
On Chrome OS, the settings UI supports enabling and disabling SIM locking on a cellular modem, and changing the SIM PIN. In the current implementation, all these actions eventually triggers NetworkingPrivateChromeOS::SetCellularSimState, which then calls the org.chromium.flimflam.Device.RequirePIN and org.chromium.flimflam.Device.ChangePIN DBus API exposed by shill. The "Change Pin" action is available after SIM locking is enabled. RequirePIN is called once when SIM locking is enabled. After that, ChangePIN should be used to change the PIN. However, NetworkingPrivateChromeOS::SetCellularSimState currently handles the "Change Pin" action by first calling RequirePIN first and then ChangePIN upon the success completion of RequirePIN. That results in two successive RequirePIN calls, and the second RequirePIN isn't necessary and often fails as the modem complains about SIM locking is already enabled. This CL changes NetworkingPrivateChromeOS::SetCellularSimState to simply call ChangePIN for the "Change Pin" action. BUG=b:63803092 BUG=chromium:751792 TEST=Manually tested the following with a few cellular modems: Under the expanded view of "Settings > Network > Mobile data": 1. Enable and disable SIM locking: a. Turn on "Enable SIM locking". A SIM PIN dialog is shown and asks for a previously set PIN. b. Enter a wrong PIN. The action fails. c. Enter the correct PIN. The action succeeds. d. Turn off "Enable SIM locking". e. Enter a wrong PIN. The action fails. f. Enter the correct PIN. The action succeeds. 2. Enable SIM locking, change the PIN, and disable SIM locking: a. Turn on "Enable SIM locking". A SIM PIN dialog is shown and asks for a previously set PIN. b. Enter the correct PIN. The action succeeds. c. Click "Change Pin". A SIM PIN dialog is shown and asks for the current PIN, the new PIN and the confirmation of the new PIN. d. Enter a wrong current PIN. The action fails. e. Enter the correct current PIN, but the confirmation of the new PIN not matching the new PIN. The action fails. f. Enter the correct current PIN, the new PIN and the confirmation of the new PIN that matches the new PIN. The action succeeds. g. Turn off "Enable SIM locking". h. Enter the old PIN. The action fails. i. Enter the new PIN. The action succeeds. 3. Enable SIM locking, reboot the system, and enter PIN to unlock the SIM: a. Turn on "Enable SIM locking". A SIM PIN dialog is shown and asks for a previously set PIN. b. Enter the correct PIN. The action succeeds. c. Reboot the system. d. A "SIM card is locked" message is shown under "Mobile data". e. Click "Unlock". A SIM PIN dialog is shown and asks for a PIN. f. Enter a wrong PIN. The action fails. g. Enter the correct PIN. The action succeeds. h. The cellular connection can be established after the SIM is unlocked. Change-Id: Ia095c4243ffd777fcfc822a1dcf2b32003257c78 Reviewed-on: https://chromium-review.googlesource.com/595327Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Ben Chan <benchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#491842}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/ad701e38..16721dfd Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org Change-Id: I2e37bcf113a9e6a344700feb61ccfbfb7edc67e0 Reviewed-on: https://chromium-review.googlesource.com/600735Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#491841}
-
Vladislav Kaznacheev authored
The screenshot implementation copies the layer tree and inherits the transform from the root window. When user zoom is applied, this transform contains scaling which affects the screenshot size. Resetting this transform on the copied layer tree root ensures that the screenshot is taken in screen pixels. TBR=lhchavez@chromium.org Bug: 752217 Change-Id: I5278217d0dc0c663b274ac695078c3d3bfff28fd Reviewed-on: https://chromium-review.googlesource.com/600849 Commit-Queue: Vladislav Kaznacheev <kaznacheev@chromium.org> Reviewed-by:
Vladislav Kaznacheev <kaznacheev@chromium.org> Cr-Commit-Position: refs/heads/master@{#491840}
-
Yoland Yan authored
This CL allow test information that was once listed by parsing proguard dump or dexdump to be produced by JUnit runner run all the tests without executing them. The TestListInstrumentationRunListener is registered in the BaseChromiumAndroidJUnitRunner and will write all tests to a json file which then will be pulled to host side by host side runner script BUG: 640116 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester Change-Id: Iea277ea8c7a1d07a2367b1e0a286ce77199935be Reviewed-on: https://chromium-review.googlesource.com/590694 Commit-Queue: Yoland Yan <yolandyan@chromium.org> Reviewed-by:
Helen Li <xunjieli@chromium.org> Reviewed-by:
Michael Case <mikecase@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#491839}
-
kapishnikov authored
The change improves the performance of CRNHTTPProtocolHandlerProxyWithClientThread and simplifies the code. Profiling indicates that the new postBlockToClientThread method is about 37% faster than the removed postToClientThread method. Bug: 740139 Change-Id: Ib35e17f1c04318845bc1a1e4cb19aa0876023845 Reviewed-on: https://chromium-review.googlesource.com/600112 Commit-Queue: Andrei Kapishnikov <kapishnikov@chromium.org> Reviewed-by:
Misha Efimov <mef@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#491838}
-
Nasko Oskov authored
Bug: 477840, 746407 Change-Id: Id10d8f38903bf64c67d0a8ca8dc0f09142907355 Reviewed-on: https://chromium-review.googlesource.com/600949 Commit-Queue: Nasko Oskov <nasko@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#491837}
-
Nasko Oskov authored
Bug: 708139 Change-Id: Idb9eb18755219be4164b6fc2585aa43ed9798dc1 Reviewed-on: https://chromium-review.googlesource.com/601027Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#491836}
-
Etienne Pierre-Doray authored
This CL adds ImageIndex, which stores annotation of an image file for quick access to raw data and embedded references. Note that some functionality from EncodedView from original implementation have been moved into ImageIndex. Bug: 729154 Change-Id: I1d5353fc8093543f2be0400361affa8b57333924 Reviewed-on: https://chromium-review.googlesource.com/589809 Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#491835}
-
Leslie Watkins authored
Do not start a scan when the Default network changes unless both the Default network and the Tether network are disconnected. This is done to prevent a scan from starting when Ethernet and Tether are both connected, and then Ethernet is disconnected (but Tether remains connected). This CL also ensures a scan on login, regardless of whether or not the Default network is connected. Bug: 672263, 738542 Change-Id: I062fdc3dc825df6a6e986db80964fa92732774f7 Reviewed-on: https://chromium-review.googlesource.com/598940 Commit-Queue: Leslie Watkins <lesliewatkins@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#491834}
-
David Benjamin authored
net/cert including net/ssl would be a circular dependency, but these includes aren't actually used. Bug: none Change-Id: I47ee0f9e3ccdca07b6127ba653798aeae0084ffa Reviewed-on: https://chromium-review.googlesource.com/578498Reviewed-by:
Matt Mueller <mattm@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#491833}
-
Dave Schuyler authored
This CL removes some CSS overrides that were making paper-icon-button-light ripple sizes incorrect. So this fix is to remove the overrides. (relates to 746584) Bug: 746584 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I88e1bae2eed231e6dd5b6a6f0e78405e5e220a64 Reviewed-on: https://chromium-review.googlesource.com/599070Reviewed-by:
Scott Chen <scottchen@chromium.org> Commit-Queue: Dave Schuyler <dschuyler@chromium.org> Cr-Commit-Position: refs/heads/master@{#491832}
-
Will Chen authored
After landing a batch of migrated tests, one of the tests got marked as flaky and then got reverted: * crbug.com/751906 * https://chromium-review.googlesource.com/c/599828 Bug: 667560 Change-Id: Ie5a819ca59b428a7a009a6ff21b3b66768ba0cd4 Reviewed-on: https://chromium-review.googlesource.com/600829Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Will Chen <chenwilliam@chromium.org> Cr-Commit-Position: refs/heads/master@{#491831}
-
Michael Lippautz authored
Bug: Change-Id: I23ad4603ce6dcc8934827e0cfbef0f8427afe5ad Reviewed-on: https://chromium-review.googlesource.com/600189 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#491830}
-