GitLab

'rem' and 'ch' units were unrecognized when used inside MQs/sizes, since they were not in the unit table.
I've added them and fixed another bug related to CH and MQs.

I've also added the 'fr' and 'turn' units to the unit table, even though there aren't valid MQs that can use them,
since some other code may use the unit table in the future, and they should be there for completeness.

BUG=398185

Review URL: https://codereview.chromium.org/427683002

git-svn-id: svn://svn.chromium.org/blink/trunk@179103 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Since the size of ScriptWrappableBase is zero, this change will not increase the size of CSSValue, etc.

BUG=235436

Review URL: https://codereview.chromium.org/424783002

git-svn-id: svn://svn.chromium.org/blink/trunk@179102 bbb929c8-8fbe-4397-9dbb-9b2b20218538

According to the CSS3 standard calc() expressions can contain time,
angle and frequency values. (http://www.w3.org/TR/css3-values/#calc).
The patch implements this feature.

The patch is partially based on http://trac.webkit.org/changeset/168685
and http://trac.webkit.org/changeset/170544 (Patch by Martin Hodovan,
reviewers were: Darin Adler and Simon Fraser)

R=mikelawther@chromium.org,alancutter@chromium.org
BUG=390566

Review URL: https://codereview.chromium.org/345903005

git-svn-id: svn://svn.chromium.org/blink/trunk@179101 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Mark http/tests/w3c/webperf/submission/Intel/user-timing/test_user_timing_mark.html as flaky on debug Windows

TBR=simonjam@chromium.org
NOTRY=TRUE
BUG=398295

Review URL: https://codereview.chromium.org/422223004

git-svn-id: svn://svn.chromium.org/blink/trunk@179100 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=340522

Review URL: https://codereview.chromium.org/415013003

git-svn-id: svn://svn.chromium.org/blink/trunk@179099 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Introduces ScriptWrappableBase class in order to provide the internal pointer independent from V8Type.

The end to end change will be http://crrev.com/420233002

BUG=235436

Review URL: https://codereview.chromium.org/422873002

git-svn-id: svn://svn.chromium.org/blink/trunk@179098 bbb929c8-8fbe-4397-9dbb-9b2b20218538

In r172647, I changed the AnimationPlayerCountedSet from a HashCountedSet to a HashMap, because at that time Oilpan didn't support a HashCountedSet. Now that Oilpan supports a HashCountedSet, this CL changes it back to a HashCountedSet again.

BUG=340522

Review URL: https://codereview.chromium.org/425903003

git-svn-id: svn://svn.chromium.org/blink/trunk@179097 bbb929c8-8fbe-4397-9dbb-9b2b20218538

    
    Children of flexbox with flex-direction: column/column-reverse
    shrinked their height after applying the overflow: scroll
    style. Children shows an incorrect height. The difference
    in height coming is equal to scrollbarLogicalHeight.
    
    This bug is occuring because we are not taking into
    account the scrollbar height while computing the
    mainAxisExtentForChild. This patch fixes this bug
    by adding scrollbarLogicalHeight while calculating
    mainAxisExtentForChild.
    
    BUG=364977

Review URL: https://codereview.chromium.org/417153003

git-svn-id: svn://svn.chromium.org/blink/trunk@179095 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=179076

BUG=394619
TBR=wangxianzhu@chromium.org

Review URL: https://codereview.chromium.org/422843006

git-svn-id: svn://svn.chromium.org/blink/trunk@179094 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Cast highestEnclosingNodeOfType() return value to tighter type to increase
code readability. This CL also renames the type checking functions passed
to highestEnclosingNodeOfType() to make it clear what type of Node/Element
is returned.

R=leviw@chromium.org

Review URL: https://codereview.chromium.org/417113011

git-svn-id: svn://svn.chromium.org/blink/trunk@179093 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is a simple refactoring.
We should use enum instead of '1 /* on prototype */' and '0 /* on instance */'.
There is no change in behavior.

Review URL: https://codereview.chromium.org/425853006

git-svn-id: svn://svn.chromium.org/blink/trunk@179091 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=374343

Review URL: https://codereview.chromium.org/413403010

git-svn-id: svn://svn.chromium.org/blink/trunk@179090 bbb929c8-8fbe-4397-9dbb-9b2b20218538

removed and also release the reference to DrawingBuffer, so that make
sure the DrawingBuffer has a chance to be destroyed.
    
BUG=390960

Review URL: https://codereview.chromium.org/415123002

git-svn-id: svn://svn.chromium.org/blink/trunk@179089 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Revert of Fix SharedWorker leak when script load has failed. (https://codereview.chromium.org/424653002/)

Reason for revert:
May cause crash

Original issue's description:
> Fix SharedWorker leak when script load has failed.
> 
> When SharedWorker script load has failed and the |WebSharedWorkerImpl|
> was explicit told to terminate, the |WebSharedWorkerImpl| instance
> was never deleted.
> 
> This CL fixes the issue by invoking "delete this" when a worker thread
> instance does not exist in |stopWorkerThread()|.
> 
> TEST=fast/workers/worker-crash-with-invalid-location.html doesn't leak when --enable-leak-detection
> BUG=364390
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179011

TBR=falken@chromium.org,tkent@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=364390

Review URL: https://codereview.chromium.org/424923002

git-svn-id: svn://svn.chromium.org/blink/trunk@179088 bbb929c8-8fbe-4397-9dbb-9b2b20218538

- Make SelectorCheckerContext STACK_ALLOCATED.
- Make FocusCandidate STACK_ALLOCATED.
- Make TreeBoundaryCrossingRuleSetMap a hash map from Member<Node> to Member<CSSStyleSheetRuleSubSet>. This hash map doesn't need to be weak.

BUG=340522

Review URL: https://codereview.chromium.org/423953003

git-svn-id: svn://svn.chromium.org/blink/trunk@179087 bbb929c8-8fbe-4397-9dbb-9b2b20218538

- Make StyleResolver's StyleSharingList a HeapDeque of Member<Element>s.
- Make CSSFontFaceSrcValue::m_svgFontFaceElement a Member<Element>.
- Add a FIXME to make ScriptLoader::m_element to a Member<Element>.
Given that ResourceClient is going to be moved to the heap soon,
it would be better to just wait for it rather than making it a Persistent<Element>.

BUG=340522

Review URL: https://codereview.chromium.org/423013002

git-svn-id: svn://svn.chromium.org/blink/trunk@179086 bbb929c8-8fbe-4397-9dbb-9b2b20218538

r174506 replaced toV8Context() with v8::Object::CreationContext(),
and it caused 16% regression in dromaeo.jslibeventjquery.
This is because v8::Object::CreationContext() is slow.

This CL reverts the change.

BUG=383926

Review URL: https://codereview.chromium.org/429433002

git-svn-id: svn://svn.chromium.org/blink/trunk@179085 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=179059

BUG=392794
TBR=wangxianzhu@chromium.org

Review URL: https://codereview.chromium.org/427693006

git-svn-id: svn://svn.chromium.org/blink/trunk@179084 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This constructor has no references to it. Hence, removing it.

BUG=None

Review URL: https://codereview.chromium.org/426573004

git-svn-id: svn://svn.chromium.org/blink/trunk@179083 bbb929c8-8fbe-4397-9dbb-9b2b20218538

CSS3 Text spec about text-align-last has been modified
as the property only can affect to the last line when test-align is justify.

http://www.w3.org/TR/css-text-3/#text-align-last-property

BUG=248839

Review URL: https://codereview.chromium.org/59753002

git-svn-id: svn://svn.chromium.org/blink/trunk@179082 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Move Node::enclosingBlockFlowElement() / inSameContainingBlockFlowElement() to
htmlediting.h as this is only needed for editing.

R=leviw@chromium.org, yosin@chromium.org

Review URL: https://codereview.chromium.org/421293004

git-svn-id: svn://svn.chromium.org/blink/trunk@179081 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=340522

Review URL: https://codereview.chromium.org/417953002

git-svn-id: svn://svn.chromium.org/blink/trunk@179080 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL moves SelectorFilter::ParentStackFrame from a private section to a public section to use a WTF_ALLOW_INIT_WITH_MEM_FUNCTIONS macro.

BUG=340522

Review URL: https://codereview.chromium.org/422143005

git-svn-id: svn://svn.chromium.org/blink/trunk@179079 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Since the issue was opened, the validity of removing
RenderObject::positionFromPaintInvalidationContainer
was questioned and it was determined that it's
probably not such a good idea anyway.

BUG=368416

Review URL: https://codereview.chromium.org/423943002

git-svn-id: svn://svn.chromium.org/blink/trunk@179078 bbb929c8-8fbe-4397-9dbb-9b2b20218538

During error recovery after failing to start a server, there might actually
not be an error log where we think there should be one.

TBR=eseidel@chromium.org
BUG=378444

Review URL: https://codereview.chromium.org/421413002

git-svn-id: svn://svn.chromium.org/blink/trunk@179077 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The optimization prunes SVG subtree paint invalidation walking if
the container's transform changed. However, the transform changed
flag is only updated during layout causing:
- If multiple layouts before an invalidation, later layouts may
  clear the flag set by previous layout;
- For paint-only invalidation (after we use unified invalidation)
  the flag may remain uncleared if there is no layout causing
  incorrect pruning of tree walking.

SvgCubics doesn't show visible performance change with this patch.

BUG=394619

Review URL: https://codereview.chromium.org/412083003

git-svn-id: svn://svn.chromium.org/blink/trunk@179076 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is the first step in switching to the mocha testing framework.

We'll use the Chai assertion library, which provides should-style,
expect-style, and assert-style assertions. We should avoid 'should',
since it modifies Object.prototype. 'expect' is more readable and
flexible than 'assert', although the (optional) chaining keywords can
make it overly verbose. For a full comparison, see:
http://chaijs.com/guide/styles/

I've used 'expect' in the two example tests, but left out the unnecessary
chaining keywords. This makes the most sense to me but feel free to
disagree.

Finally, Karma is a test runner that allows us to remotely run unit tests
in Chrome from the command line. We may need to use some trickery to have
this work for both Chrome and Chromium, but that is for another patch.

R=esprehn@chromium.org,ojan@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/411763003

git-svn-id: svn://svn.chromium.org/blink/trunk@179075 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Currently RecordingImageBufferSurface determines whether
the canvas was cleared by tracking opaque draws.  For this
purpose we need all draw operations that completely
overwrite the destination pixels to be treated as opaque
even though the resulting pixels may not be opaque
(alpha = 1). To solve this problem we introduce an alternate
mode of operation in OpaqueRegionSkia, which was renamed to
RegionTracker, to reflect its new more generic vocation.

BUG=397205
TEST=blink platform unit test RecordingImageBufferSurface.clearRect

Review URL: https://codereview.chromium.org/413313002

git-svn-id: svn://svn.chromium.org/blink/trunk@179074 bbb929c8-8fbe-4397-9dbb-9b2b20218538

-x/y were swapped. Create a mock canvas context so we actually
test this code path.
-The zoomer was below the test list. z-index:1 to put it above.

NOTRY=true

Review URL: https://codereview.chromium.org/423703002

git-svn-id: svn://svn.chromium.org/blink/trunk@179073 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Use tighter typing in editing to increase code readability.
This CL focuses on DeleteSelectionCommand.

R=leviw@chromium.org

Review URL: https://codereview.chromium.org/420053002

git-svn-id: svn://svn.chromium.org/blink/trunk@179072 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Fix the loop condition in BidiRunList::replaceRunWithRuns to check if a
next run exists before accessing it.

R=inferno@chromium.org
BUG=397479

Review URL: https://codereview.chromium.org/421383002

git-svn-id: svn://svn.chromium.org/blink/trunk@179068 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Use new Traversal<> API more in the code base to simplify code a bit and
increase readability.

R=esprehn@chromium.org, adamk@chromium.org

Review URL: https://codereview.chromium.org/420193007

git-svn-id: svn://svn.chromium.org/blink/trunk@179067 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL replaces Document* pointers in objects with Member<Document>s.

- Move TextAutosizer to oilpan's heap.
- Move FastTextAutosizer to oilpan's heap.
- Make FastBulider STACK_ALLOCATED.
- Make ViewportStyleResolver::m_document a Member.

BUG=340522

Review URL: https://codereview.chromium.org/420273005

git-svn-id: svn://svn.chromium.org/blink/trunk@179066 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The functions have been converted to ConvertableToTraceFormat
since this comment was introduced but it wasn't removed.

Review URL: https://codereview.chromium.org/423943004

git-svn-id: svn://svn.chromium.org/blink/trunk@179065 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Remove Traversal<Element> template specializations for lastWithin() /
previous() as they are now identical to the generic implementations after
r178540.

R=esprehn@chromium.org, abarth@chromium.org

Review URL: https://codereview.chromium.org/413133008

git-svn-id: svn://svn.chromium.org/blink/trunk@179064 bbb929c8-8fbe-4397-9dbb-9b2b20218538

These calls do nothing and in fact cause extra cycles
in Element::styleForRenderer().

Review URL: https://codereview.chromium.org/419033002

git-svn-id: svn://svn.chromium.org/blink/trunk@179063 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Move Node::lastDescendantOrSelf() to NodeTraversal and rename to
lastWithinOrSelf() as this is a node traversal utility function and it avoids
code duplication with NodeTraversal::lastWithin().

R=esprehn@chromium.org, adamk@chromium.org

Review URL: https://codereview.chromium.org/420323002

git-svn-id: svn://svn.chromium.org/blink/trunk@179062 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Use ContainerNode::hasChildren() instead of firstChild() in conditionals to
increase code readability a bit.

R=rob.buis@samsung.com

Review URL: https://codereview.chromium.org/428533006

git-svn-id: svn://svn.chromium.org/blink/trunk@179061 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=391177
R=dsinclair@chromium.org

Review URL: https://codereview.chromium.org/403723004

git-svn-id: svn://svn.chromium.org/blink/trunk@179060 bbb929c8-8fbe-4397-9dbb-9b2b20218538

When an object is being removed, it calls
paintInvalidationForWholeRenderer() which previously invalidated the
current repaint rect only. However if the object has been layouted
after the last invalidation, we'll miss invalidation of the object's
previous location.

Now let the method also invalidate the previous paint rect if possible.

BUG=392794, 394004
TEST=fast/repaint/remove-block-after-layout.html
TEST=fast/repaint/remove-inline-after-layout.html
TEST=fast/repaint/remove-inline-layer-after-layout.html
R=dsinclair@chromium.org, jchaffraix@chromium.org

Review URL: https://codereview.chromium.org/395463003

git-svn-id: svn://svn.chromium.org/blink/trunk@179059 bbb929c8-8fbe-4397-9dbb-9b2b20218538